Commit graph

807 commits

Author SHA1 Message Date
Hrvoje Senjan
28281d7741 Merge remote-tracking branch 'origin/KDE/4.10' 2013-06-03 17:28:35 +02:00
Hrvoje Senjan
66691b0528 Use dialog svg instead of tooltip for folderview's popupview
Fixes popup rendering when tooltip != dialog background
Also fixed compiler warning
REVIEW: 110786
CCBUG: 320265
2013-06-03 17:18:18 +02:00
Eike Hein
c0d0eadd0c Don't throw away icon positions when changing the text color.
CCBUG:182712
2013-05-31 21:34:10 +02:00
Eike Hein
c4a4efae68 Don't throw away icon positions when changing the text color.
CCBUG:182712
2013-05-31 21:33:18 +02:00
Eike Hein
c4b133f50e Merge branch 'KDE/4.10' 2013-05-27 16:22:10 +02:00
Eike Hein
ce159c94b6 Don't accumulate 'Open with <File Manager>' actions in the context menu. 2013-05-27 16:21:47 +02:00
Eike Hein
da9cf52bf2 Fix build. 2013-05-23 10:06:55 +02:00
Eike Hein
1cef3607f6 Merge branch 'KDE/4.10' 2013-05-23 10:04:44 +02:00
Eike Hein
378c4476ab Cleanup.
Abusing the saved positions system to cope with theme changes
is no longer necessary now that updateGridSize() no longer
throws out position data.
2013-05-23 10:04:05 +02:00
Eike Hein
360d8c703f Merge branch 'KDE/4.10' 2013-05-22 03:35:32 +02:00
Eike Hein
f86bf88770 Preserve relative positions when changing icon size in containment case.
Icon positions are preserved by scaling the top-left coordinate pair
by the difference between the old and new grid sizes, or by recreating
the same logical column/row coordinate pair in the newly-calculated
grid if the align-to-grid option is enabled.

Icons that run out of bounds (or exceed the maximum column or row)
accumulate at the relevant screen edges. There is a precedent for
this behavior in the general align-to-grid code.

The left-to-right or right-to-left flow is taken into account when
scaling.

Smarter behaviors can be imagined as an optimization (e.g. identi-
fying groups of icons along screen edges and preserving their edge
alignment regardless of overall layout flow), but this simple scaling
implementation certainly beats throwing positions away altogether.

However, positions do still get thrown away in the non-containment
case - as the regular widget is capable of handling overflow via a
scrollbar, relayouting to exploit that felt better in practice.

CCBUG:182712
2013-05-22 03:35:00 +02:00
Eike Hein
03f308af8c Merge branch 'KDE/4.10' 2013-05-20 03:09:15 +02:00
Eike Hein
ff68ed3e6a Preserve icon positions across theme changes. 2013-05-20 03:07:47 +02:00
Eike Hein
da6c1903b0 Merge branch 'KDE/4.10' 2013-05-16 19:57:03 +02:00
Eike Hein
e14314d5c0 Fix non-square icon scaling when items are selected. 2013-05-16 19:56:42 +02:00
Michael Drueing
3236d9761d Only require X11 libraries if actually compiling on X11
This will fix compilation on Win32 (and probably others)
2013-04-24 19:54:02 +02:00
Ignat Semenov
6639567e2b whatsthis tips for the Arrange In and Align combos 2013-04-24 16:57:30 +04:00
Ignat Semenov
76916d27b0 whatsthis tip for the Descending checkbox 2013-04-24 16:57:30 +04:00
Ignat Semenov
d554fe95f1 whatsthis tip for the Folders first checkbox 2013-04-24 16:57:30 +04:00
Ignat Semenov
cdf2c40bcf rename Display page to Icons; change icon accordingly 2013-04-24 16:57:30 +04:00
Ignat Semenov
d9e48c575a Align Icons -> Align (menu name already provides context) 2013-04-24 16:57:30 +04:00
Ignat Semenov
68d649b82e Arrange -> Arrange In for consistency with Sort By 2013-04-24 16:57:30 +04:00
Ignat Semenov
9d30c8d1f4 Sort Icons -> Sort By for consistency with Dolphin 2013-04-24 16:57:30 +04:00
Ignat Semenov
1b4a5b4aa0 make Descending a checkbox, not a combo 2013-04-24 16:57:27 +04:00
Ignat Semenov
91b007d428 change i18nc context comment for simplicity 2013-04-24 16:56:26 +04:00
Ignat Semenov
a8ddc6bb67 simplify alignment action strings 2013-04-24 16:56:26 +04:00
Ignat Semenov
efbd7ec1fb Verbify Layout and Alignment, reword Layout for less technical 2013-04-24 16:56:26 +04:00
Ignat Semenov
fcb97d234e verbify Sorting for consistency 2013-04-24 16:56:26 +04:00
Ignat Semenov
ec33d65184 an attempt at categorizing the settings 2013-04-24 16:56:25 +04:00
Ignat Semenov
7fd7f69ab9 icon arrangement mega-patch for usability and maintainability
This splits the enum IconView::Flow into two enums
- IconView::Layout { Rows, Columns }
- IconView::Alignment { Left, Right }

Note that Qt::Alignment is not used to emphasize the fact that
these two properties are orthogonal (layoutDirection() is used
e.g. to place the scrollbar at the correct side of the screen,
whereas IconView::Alignment is about the side of the screen
the user want their icons to stick to.

This patch greatly improves the readability of the IconView
layouting code, as well as the user-friendliness of the
applet's Display configuration page, with a distinct separation
of the two layout-related factors.

Corresponding context menu actions have been added. They update
the configuration dialog combos when selected if the dialog is
open at that moment.

CCBUG:306537
2013-04-24 16:56:23 +04:00
Ignat Semenov
b77e0f6655 only show Unsorted when the view is manually sorted 2013-04-24 16:47:29 +04:00
Ignat Semenov
fe3290d9db avoid a potential stall: QComboBox::maxCount() -> QComboBox::count() 2013-04-24 16:47:28 +04:00
Ignat Semenov
3a7b07633d hardcoded -1 -> enum FolderView::Unsorted 2013-04-24 16:47:28 +04:00
Ignat Semenov
7665ee95af keep 4 context menu checkboxes and Display page in sync 2013-04-24 16:47:28 +04:00
Ignat Semenov
9bf43b7459 update the order, direction, flow combos on menu actions 2013-04-24 16:47:28 +04:00
Ignat Semenov
8b3cb0f09e if the user has moved the icons, update the combo 2013-04-24 16:47:28 +04:00
Ignat Semenov
7d6669c25b even less code duplication 2013-04-24 16:47:28 +04:00
Ignat Semenov
f407bf3f33 --code duplication 2013-04-24 16:47:28 +04:00
Ignat Semenov
69370f22f8 consistency++ 2013-04-24 16:47:28 +04:00
Ignat Semenov
7518b54ce3 not necessary 2013-04-24 16:47:28 +04:00
Ignat Semenov
2b272d99d5 QActionGroup + foreach loop -> less code 2013-04-24 16:47:28 +04:00
Ignat Semenov
d77e60ce6b add a "Folders first" checkbox to the Display config page
Allow the user to set the "Folders first" option using the Settings dialog.

BUG:306537
2013-04-24 16:47:21 +04:00
Ignat Semenov
7e2883afcf add a "Sort order" combo to the Display config page
Allow the user to change sorting order using the Settings dialog.
2013-04-24 16:47:13 +04:00
Ignat Semenov
35da405097 rename the flow enums for better readability 2013-04-24 16:47:13 +04:00
Ignat Semenov
08556ebdd3 add "Arrange icons" submenu to the context menu
Allow the user to change icon flow in an icon view using the context menu.

BUG:306537
2013-04-24 16:47:05 +04:00
Script Kiddy
b212ee8147 SVN_SILENT made messages (.desktop file) 2013-04-20 09:44:11 +02:00
Script Kiddy
8a299ad08c SVN_SILENT made messages (.desktop file) 2013-04-19 13:27:40 +02:00
Ignat Semenov
574cd6de32 avoid a potential stall: QComboBox::maxCount() -> QComboBox::count() 2013-04-16 22:51:01 +04:00
Ignat Semenov
08d003fbdc avoid a potential stall: QComboBox::maxCount() -> QComboBox::count() 2013-04-16 22:47:50 +04:00
Eike Hein
6fb5b07f62 Merge branch 'KDE/4.10' 2013-04-15 16:27:18 +02:00