Shaun Reich
5cec8a2dd9
Middle-clicking on tabs will now close them.
...
svn path=/trunk/KDE/kdebase/apps/; revision=924467
2009-02-10 20:48:16 +00:00
Peter Penz
3cfeee94d4
Fixed issue that the 'Create New' menu might be disabled although creating of files is allowed. Thanks to Frank Reininghaus for the patch!
...
BUG: 183812
svn path=/trunk/KDE/kdebase/apps/; revision=924120
2009-02-10 07:09:49 +00:00
Shaun Reich
8f6e9890fd
The Column Widget would not disconnect it's connection to request a tab(seen with a middle-click on a folder). So it would actually open 2 or more tabs, but only in the Column View mode.
...
svn path=/trunk/KDE/kdebase/apps/; revision=923757
2009-02-09 11:23:40 +00:00
Peter Penz
af808a7ba3
* open folders always on single click
...
* open files/select files dependent from the global single click/double click setting
* open a new column when pressing the Key_Right
Thanks to Shaun Michael Reich for the original patches!
CCMAIL: predator106@gmail.com
svn path=/trunk/KDE/kdebase/apps/; revision=923423
2009-02-08 18:32:44 +00:00
Peter Penz
681929dc67
Allow the view implementations to directly trigger an item without mouse interaction. This is e. g. necessary when the column view wants to implement a custom key handling where a folder should be triggered.
...
svn path=/trunk/KDE/kdebase/apps/; revision=923417
2009-02-08 18:26:23 +00:00
Script Kiddy
95f85fb719
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=923249
2009-02-08 14:11:41 +00:00
Peter Penz
2f0a6a86d6
Revert SVN commit 923057: This code should not be part of DolphinController, it should be handled in the column view itself.
...
CCMAIL: predator106@gmail.com
svn path=/trunk/KDE/kdebase/apps/; revision=923072
2009-02-08 07:15:26 +00:00
Shaun Reich
4a5218b367
Added right arrow key usage when in the Column View mode. When a directory is selected, and the right arrow is used, it will navigate into it (like double/single clicking a directory). Note, this only works on directories, not files, it was made this way by intention.
...
svn path=/trunk/KDE/kdebase/apps/; revision=923057
2009-02-08 04:33:00 +00:00
Peter Penz
95607a31cd
The layout algorithm of QListView in Qt4.5 also respects the style-hint QStyle::SH_ScrollView_FrameOnlyAroundContents. To assure that Dolphin uses the maximum available width for the size hint of the items, the style-hint must be included too for Qt 4.5.
...
I tested this fix also with Qt4.4 and it seems that the style-hint returns always 0 in this case -> this patch seems to be backward compatible...
svn path=/trunk/KDE/kdebase/apps/; revision=922900
2009-02-07 18:56:28 +00:00
Shaun Reich
eb9dd90419
Changed the order of the shortcut for opening a new tab from Ctrl+Shift+N to Ctrl+T, so the latter is now the default, and is shown like that. It now shows up like the other items in the file menu. (it doesn't have a shift key modifier in it).
...
svn path=/trunk/KDE/kdebase/apps/; revision=922452
2009-02-07 04:47:04 +00:00
Shaun Reich
b9f1ebca00
SVN_SILENT Added newline at EOF.
...
svn path=/trunk/KDE/kdebase/apps/; revision=922440
2009-02-07 02:01:18 +00:00
Script Kiddy
8adae52095
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=922231
2009-02-06 15:34:47 +00:00
Shaun Reich
131b4e5ea7
Reverted r921975, I wasn't aware that the lack of reading the double-click setting was intentional, I originally wanted the double-click setting to apply only to files, and the single click apply to only folders :) .
...
CCMAIL: peter.penz@gmx.at
svn path=/trunk/KDE/kdebase/apps/; revision=922070
2009-02-06 11:53:14 +00:00
Shaun Reich
2a3e27b9fe
The column view did not obey single/double-click navigation settings, it does now. The signals were only connected to the singleClick(), not the doubleClick() method. They are now also connected/disconnected according to the setting that is set globally.
...
svn path=/trunk/KDE/kdebase/apps/; revision=921975
2009-02-06 02:52:23 +00:00
Shaun Reich
5e20f374e3
SVN_SILENT: Added a comment.
...
svn path=/trunk/KDE/kdebase/apps/; revision=921970
2009-02-06 02:39:31 +00:00
Script Kiddy
18960dc749
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=921684
2009-02-05 14:09:41 +00:00
Script Kiddy
e543fd18a5
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=921220
2009-02-04 16:27:07 +00:00
Shaun Reich
5c53ea1f60
The Home folder location, when set via loadSettings(), and when set via the 'Use Default Location' button, now will use KUrl::prettyUrl(); Prior to this, saving an address of '/home/user/' would be changed to 'file:///home/user' (on Linux) normally (through applySettings()). However, when the listed methods were called, the text of the line edit would be just '/home/user/'. It will now (basically) be set to 'file:///'... all throughout.
...
svn path=/trunk/KDE/kdebase/apps/; revision=920943
2009-02-04 03:44:13 +00:00
Shaun Reich
6969b704c0
Added const bools for a few settings that were referenced more than once. Otherwise, the fellow coder would probably just think these were taken out of seemingly thin air.
...
svn path=/trunk/KDE/kdebase/apps/; revision=920920
2009-02-04 01:24:38 +00:00
Peter Penz
6c75649664
Check whether the global single-click/double-click setting has been changed during runtime and assure that the behavior of the view is adjusted.
...
CCMAIL: predator106@gmail.com
BUG: 175635
BUG: 175280
svn path=/trunk/KDE/kdebase/apps/; revision=920754
2009-02-03 18:40:59 +00:00
Peter Penz
0217168998
Don't differ between single-click and double-click in the column view, stay consistent with the behavior like the Places Panel or Folders Panel.
...
svn path=/trunk/KDE/kdebase/apps/; revision=920753
2009-02-03 18:35:19 +00:00
Peter Penz
7af662dc12
rename the checkbox "Browse through archives" to "Open archives as folder"
...
CCBUG: 182991
svn path=/trunk/KDE/kdebase/apps/; revision=920733
2009-02-03 17:54:33 +00:00
Peter Penz
aa885d4e21
SVN_SILENT: updated comment
...
svn path=/trunk/KDE/kdebase/apps/; revision=920731
2009-02-03 17:49:27 +00:00
Script Kiddy
e65710b849
SVN_SILENT made messages (.desktop file, second try)
...
svn path=/trunk/KDE/kdebase/apps/; revision=920635
2009-02-03 14:52:58 +00:00
Peter Penz
58373c05fe
* no general settings are read -> invoking loadSettings has no effect in restoreDefaults()
...
* use constants for the defaults, as hardcoding the defaults in 2 methods might be error-prone when changing the defaults in future
CCMAIL: predator106@gmail.com
svn path=/trunk/KDE/kdebase/apps/; revision=920531
2009-02-03 06:24:39 +00:00
Shaun Reich
4f00fc19cd
String change - Added clarification in the displayed message box for when the settings are applied in the Startup page, and there is an error. This is under the home folder setting. It now says that "the home folder is invalid or does not exist" as opposed to just saying it is invalid. I believe that it was kind of misleading as to what was wrong, so I figured it should give them _some_ hint as to what the problem is.
...
svn path=/trunk/KDE/kdebase/apps/; revision=920501
2009-02-03 03:20:47 +00:00
Shaun Reich
5d230c956f
SVN_SILENT Small update to a comment.
...
svn path=/trunk/KDE/kdebase/apps/; revision=920497
2009-02-03 01:40:30 +00:00
Shaun Reich
58c95bc8d8
Both the 'preview size' slider and the 'embed thumbnails in files' settings now restore to defaults when asked to.
...
svn path=/trunk/KDE/kdebase/apps/; revision=920491
2009-02-03 01:20:53 +00:00
Shaun Reich
a8d577ff2d
A few more fixes...mostly cleanups.
...
*Grouped some statements that it didn't make sense to put after a certain block of code (giving the impression that it had to be after this block).
*There is no need to set the value of the QSpinBox equal to that of the slider, when loading settings... their valueChanges() signals are connected to the opposite one's slot.
*Made a now unused variable be used, it was inconsistent in this code block, two times '1' was used, but other times a var set to '1' would be used.
*Moved some blocks of code from the loadSettings() method, into the constructor, since the loadSettings() method is called more than once, so it's more resource-friendly to do it this way.
svn path=/trunk/KDE/kdebase/apps/; revision=920441
2009-02-02 22:23:06 +00:00
Shaun Reich
c2429b1dcb
We were calling methods within loadSettings() which should have been moved to inside the constructor instead. Examples include setting up a slider's notch-type(bottom or top). Especially significant since loadSettings() gets called more often than the constructor.
...
svn path=/trunk/KDE/kdebase/apps/; revision=920419
2009-02-02 21:35:37 +00:00
Shaun Reich
b1319c769c
SVN_SILENT Fix to avoid accidental doxygen-highlighted header license.
...
svn path=/trunk/KDE/kdebase/apps/; revision=920402
2009-02-02 20:51:15 +00:00
Shaun Reich
97425edcf6
Navigation click type (single/double-click) now gets set to it's default when asked (the default is single-click).
...
svn path=/trunk/KDE/kdebase/apps/; revision=920400
2009-02-02 20:40:33 +00:00
Shaun Reich
8230d0f7f4
Changed group config reference pertaining to the "kcminputrc" file. The Navigation page setting of whether to use single/double click navigation now saves itself properly, instead of insisting on using single-click. :)
...
P.S. Bear in mind that the setting still does not apply itself until a restart of Dolphin.
CCMAIL: peter.penz@gmx.at
svn path=/trunk/KDE/kdebase/apps/; revision=920390
2009-02-02 20:14:42 +00:00
Shaun Reich
c48b347e58
Reverted my previous commit(919897), I was incorrect, it looked to work like this, but didn't.
...
svn path=/trunk/KDE/kdebase/apps/; revision=920374
2009-02-02 19:43:02 +00:00
Script Kiddy
0e78a57fdb
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=920235
2009-02-02 15:35:50 +00:00
Shaun Reich
952fc86039
Confirmations of the following settings now reset themselves to their defaults:
...
*Move to Trash
*Delete
These are located in the General page->Context Menu tab of the settings dialog.
svn path=/trunk/KDE/kdebase/apps/; revision=920205
2009-02-02 14:44:25 +00:00
Shaun Reich
bacc9c9137
The "Show 'Delete' Command" checkbox now gets restored to it's default (false).
...
svn path=/trunk/KDE/kdebase/apps/; revision=919996
2009-02-02 02:38:42 +00:00
Shaun Reich
9587d04b80
These radio buttons are paired, when you enable one, you inherently disable the other, so we're just repeating ourselves by doing this manually.
...
svn path=/trunk/KDE/kdebase/apps/; revision=919995
2009-02-02 02:34:57 +00:00
Simon Paul St James
b1d8854ad2
Hovering over blank space in a view while dragging would trigger the FolderExpander on the folder represented by the view, which we don't want. Detect and prevent it.
...
BUG:182618
Shipped! ;)
svn path=/trunk/KDE/kdebase/apps/; revision=919950
2009-02-01 22:03:04 +00:00
Shaun Reich
e3bf301477
I forgot to change these three tabs to the new method usage also. Effected was the View Modes page.
...
svn path=/trunk/KDE/kdebase/apps/; revision=919919
2009-02-01 21:01:06 +00:00
Shaun Reich
9f7c2424d9
Now when you click the button "Defaults" in the settings dialog, it will push the settings to the UI, then the user can apply, cancel, or modify them from there. Also removed the message box prompt. Use settings->useDefaults(true), then set it back to false after you are done loading settings in the restoreDefaults() method calls. Don't use ->setDefaults() normally, anymore.
...
svn path=/trunk/KDE/kdebase/apps/; revision=919897
2009-02-01 20:43:26 +00:00
Script Kiddy
3df531dcf6
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=919783
2009-02-01 16:24:40 +00:00
Peter Penz
8e13b80d5f
Replace patch for bug 181226 by a different approach, as the previous patch resulted in a changed behavior when using the double-click mode (-> a treeview item had to be pressed twice to show it in the main view).
...
CCBUG: 172360
CCBUG: 181226
svn path=/trunk/KDE/kdebase/apps/; revision=919648
2009-02-01 14:08:40 +00:00
Script Kiddy
d56646dd0f
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=919234
2009-01-31 15:57:53 +00:00
Peter Penz
e5edeb7446
Postpone the creating of the media object until the play- or stop-button has been pressed. This solves the issue that Dolphin might get blocked during hovering media files. Dolphin still gets blocked when requesting a media object the first time, but for the user this "just" means that after pressing the play-button the first time, that the playing starts a little bit later.
...
CCMAIL: kretz@kde.org
CCMAIL: kdedevel@etotheipiplusone.com
svn path=/trunk/KDE/kdebase/apps/; revision=919063
2009-01-31 13:04:40 +00:00
Peter Penz
68a7ed8bcf
Don't delete and recreate the phonon widget each time the URL changes, use the existing widget instance if possible.
...
svn path=/trunk/KDE/kdebase/apps/; revision=919058
2009-01-31 12:42:01 +00:00
Peter Penz
29a5af6390
* move the search button to the end
...
* use the default search icon instead of the nepomuk icon
svn path=/trunk/KDE/kdebase/apps/; revision=919051
2009-01-31 12:21:52 +00:00
Peter Penz
341f8456f0
Allow to enable/disable the "Expandable Folders" setting of the details-view by the context menu of the header.
...
CCMAIL: faure@kde.org
svn path=/trunk/KDE/kdebase/apps/; revision=919035
2009-01-31 11:36:44 +00:00
Peter Penz
dc34436f23
Display correct folder names in tabs, if they contain a '&' character. Thanks to Frank Reininghaus for the patch!
...
BUG: 181765
svn path=/trunk/KDE/kdebase/apps/; revision=919021
2009-01-31 11:08:08 +00:00
Peter Penz
1f3916a222
SVN_SILENT: just mention what the method does, skip implementation details
...
svn path=/trunk/KDE/kdebase/apps/; revision=918538
2009-01-30 06:16:13 +00:00