kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-09-19 16:31:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed issue that the 'Create New' menu might be disabled although creating of files is allowed. Thanks to Frank Reininghaus for the patch!

Browse source 
BUG: 183812

svn path=/trunk/KDE/kdebase/apps/; revision=924120
This commit is contained in:
Peter Penz 2009-02-10 07:09:49 +00:00
parent 8f6e9890fd
commit 3cfeee94d4
2 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/dolphinviewcontainer.cpp
View file

@ -66,6 +66,7 @@ DolphinViewContainer::DolphinViewContainer(DolphinMainWindow* mainWindow,
const KUrl& url) :
QWidget(parent),
m_showProgress(false),
m_isFolderWritable(false),
m_mainWindow(mainWindow),
m_topLayout(0),
m_urlNavigator(0),
@ -182,7 +183,10 @@ void DolphinViewContainer::setUrl(const KUrl& newUrl)
// Temporary disable the 'File'->'Create New...' menu until
// the write permissions can be checked in a fast way at
// DolphinViewContainer::slotDirListerCompleted().
m_mainWindow->newMenu()->menu()->setEnabled(false);
m_isFolderWritable = false;
if (isActive()) {
m_mainWindow->newMenu()->menu()->setEnabled(false);
}
}
}
@ -195,6 +199,9 @@ void DolphinViewContainer::setActive(bool active)
{
m_urlNavigator->setActive(active);
m_view->setActive(active);
if (active) {
m_mainWindow->newMenu()->menu()->setEnabled(m_isFolderWritable);
}
}
bool DolphinViewContainer::isActive() const
@ -262,14 +269,17 @@ void DolphinViewContainer::slotDirListerCompleted()
// Enable the 'File'->'Create New...' menu only if the directory
// supports writing.
KMenu* createNew = m_mainWindow->newMenu()->menu();
KFileItem item = m_dirLister->rootItem();
if (item.isNull()) {
// it is unclear whether writing is supported
createNew->setEnabled(true);
m_isFolderWritable = true;
} else {
KonqFileItemCapabilities capabilities(KFileItemList() << item);
createNew->setEnabled(capabilities.supportsWriting());
m_isFolderWritable = capabilities.supportsWriting();
}
if (isActive()) {
m_mainWindow->newMenu()->menu()->setEnabled(m_isFolderWritable);
}
}

1
src/dolphinviewcontainer.h
View file

@ -234,6 +234,7 @@ private slots:
private:
bool m_showProgress;
bool m_isFolderWritable;
DolphinMainWindow* m_mainWindow;
QVBoxLayout* m_topLayout;