Commit graph

723 commits

Author SHA1 Message Date
Méven Car
a1c5c5cf81 KDirectoryContentsCounter: show intermediate dir size counting results, improve stopping, improve data caching
Two user visible changes:
 * we can see the dir size changing as it is updated.
 * This makes the file counting a lot more reactive, when changing directories for instance.

`KDirectoryContentsCounterWorker::walkDir` is not recursive anymore.

The cache is now shared and only a single thread is used to count size recursively.
2023-05-26 15:10:09 +00:00
Méven Car
c9217337c7 TerminalPanel: rename currentWorkingDirectoryIsParentOf to currentWorkingDirectoryIsChildOf
NO_CHANGELOG
2023-04-22 09:33:01 +02:00
Méven Car
a654b8dae6 TerminalPanel: better check if terminal needs to change its currentWorkingDirectory when unmounting
CCBUG: 467403
2023-04-21 15:32:58 +02:00
Méven Car
e190977a90 PlacesPanel: clean some warnings
NO_CHANGELOG
2023-04-03 15:34:16 +02:00
Oliver Beard
278380bf17 panels/information: Add option to not show information for hovered item
BUG: 364956
BUG: 453211
2023-03-25 10:01:52 +00:00
Serg Podtynnyi
38c34eeca3 Add clang-format and format code as in Frameworks 2023-02-05 12:45:38 +07:00
Kai Uwe Broulik
de289800b2 Places Panel: Delegate open file error to KIO
This functionality is now provided by `KFilePlacesModel` as long as
you tell it to do the teardown rather than calling into the device yourself.
2022-11-29 10:22:19 +00:00
Haozhe Jiang
dfe05c587b Use \r to terminate command in integrated terminal
\r should be used instead of \n

BUG: 458411
2022-11-23 17:46:00 +00:00
Ahmad Samir
197a7f6905 Port away from deprecated KIO API 2022-10-16 13:13:55 +02:00
John Brooks
3656da18b0 terminal: Clear line using escapes instead of SIGINT
Sending SIGINT can be destructive, for example if we interrupt the
loading of the shell init files (e.g. .bashrc) and clobber history
preservation settings. Follow the example of Kate and send a Ctrl-E
Ctrl-U to clear the prompt instead.

BUG: 279614
Signed-off-by: John Brooks <john@fastquake.com>
2022-10-02 07:14:23 +00:00
Laurent Montel
e19aa49a08 Remove unused includes 2022-09-26 08:17:13 +02:00
Kai Uwe Broulik
a44830c3a9 Don't show error message on ERR_USER_CANCELED
There's no point telling the user what they just did.

After f192c133eb
this error has a text associated with it, so it might
show up in the UI.
2022-08-24 17:00:01 +02:00
Méven Car
4150960081 InformationPanel: better refresh state when current dir changes
Refactor and simplify things along the way.

BUG: 457813
2022-08-22 23:32:28 +02:00
Kai Uwe Broulik
06df12013b Places Panel: Don't show error message on UserCanceled
There's no point telling the user what they just did
2022-08-22 19:55:30 +02:00
Harald Sitter
8d7e600f63 portalize drag urls
this enables sandboxed application to receive drop events
2022-07-11 09:04:14 +00:00
Ahmad Samir
8aa81a1dc7 Cleanup config-dolphin.h includes 2022-06-15 11:28:44 +02:00
Ahmad Samir
8a0003bfbc Use one config-dolphin.h.cmake configuration file 2022-06-15 11:27:55 +02:00
Laurent Montel
6a727b1a7d Port to QStringView 2022-05-11 08:18:02 +02:00
Felix Ernst
e70e12e3bd Fix terminal panel not keeping up with dir changes
The terminal panel is supposed to show the same location as the
currently active Dolphin view at all times.

However there was an issue when the terminal is supposed to
quickly switch to a new location and then back again to the old
one. The terminal ignored the switch to the old location unless it
had already fully switched to the new location. Because it isn't
particularly fast at fully switching to the new location, it would
never do the expected thing of switching back to the old location.

This commit makes it so the switch to the old location is only
ignored if there are no in-progress switches to a different
location.

BUG: 391380

BUG: 416690

FIXED-IN: 22.04.2

Not totally sure if this fixes everything but it seems like an improvement.
2022-04-27 10:40:40 +00:00
Kai Uwe Broulik
df79f5b477 [Places Panel] Reject drops on unwritable locations
Indicate that you cannot drop here.

Avoids a "Cannot drop file" or "not supported" error when
dropping files ontop of a search or timeline URL.

It is done in Dolphin rather than the library as there we cannot
assume what a consumer might be doing with the drop.
2022-03-04 18:25:38 +00:00
Kai Uwe Broulik
e9bd295b3c [Places Panel] Make use of KFilePlacesView::dragAutoActivationDelay
Code moved to KIO
2022-02-07 07:29:35 +00:00
Méven Car
08a9aaad2c InformationPanel: Improve video arrow overlay appearance 2022-02-02 18:16:59 +01:00
Bharadwaj Raju
487e95376d Don't set ignoreMaximumSize on preview jobs for slow files
With this change (plus https://invent.kde.org/frameworks/kio/-/merge_requests/702), slow files will be treated as remote files for generating previews. This should make browsing local mounts of remote locations smoother.
2022-02-02 09:41:10 +00:00
Stephan Sahm
d71b617205 Expose konsolepart shortcuts in Dolphin's shortcuts view
Adapt some changes from Yakuake a0b08cb1f7

credit to Stephan Sahm @schlichtanders

BUG: 428265
2022-01-25 17:33:01 +00:00
Kai Uwe Broulik
7c5af3f88e [Places Panel] Stop drag activation timer when dropping
Avoids switching folders after a drop while interacting with
the Copy/Move/Link menu.
2022-01-24 17:44:03 +01:00
Kai Uwe Broulik
0603e18cd4 Port back to KFilePlacesView
This removes the custom-view engine version of the places panel
and replaces it with the upstream `KFilePlacesView` from KIO.
2022-01-09 18:09:10 +01:00
Fushan Wen
eb0a7da653
kitemlistview: Port KItemListView::itemAt to std::optional
Use `value_or(-1)` for those functions that don't use `std::optional`.
2021-12-28 22:48:28 +08:00
Alessio Bonfiglio
65b18bf935 Enable Ctrl/Shift-Click to open folder in a new tab/window
and more
2021-12-17 14:11:46 +00:00
Kai Uwe Broulik
4bfc339bac [Information Panel] Remove unused PlacesItemModel 2021-12-16 12:06:51 +00:00
Alexander Lohnau
bff2ef9385 Port away from deprecated QDateTime::.toTime_t method 2021-12-01 22:10:58 +00:00
Alexander Lohnau
82202a24e2 Port away from deprecated KPluginLoader 2021-12-01 22:10:58 +00:00
Laurent Montel
1118413c63 Remove duplicate include from .h/.cpp 2021-11-02 13:20:10 +01:00
Elvis Angelaccio
8b4d3624ad Merge branch 'release/21.08' 2021-08-29 19:42:51 +02:00
Jan Paul Batrina
1d125057cb FoldersPanel: Fix inline renaming
Commit 5a0da4a9c8 changed the value
for emitRoleEditingFinished() to a struct containing
the new name, but folderspanel was not updated.

BUG: 441124
2021-08-27 07:29:29 +00:00
Eugene Popov
90699c2c2d [PlacesPanel] Remove horizontal scrollbar
This MR removes the horizontal scrollbar of the Places panel. For titles that don't fit in the panel, their elided versions will be used (i.e., with ...).

BUG: 301758


(cherry picked from commit deaf5916f2)
2021-07-24 03:30:51 +00:00
Eugene Popov
deaf5916f2 [PlacesPanel] Remove horizontal scrollbar
This MR removes the horizontal scrollbar of the Places panel. For titles that don't fit in the panel, their elided versions will be used (i.e., with ...).

BUG: 301758
2021-07-18 16:58:10 +00:00
Méven Car
6f632283d0 Allow to have HiDpi previews
BUG: 401170
2021-07-16 06:53:32 +00:00
Méven Car
8048e6ed1b InformationPanel ensure to have a showUrl when no items are selected 2021-07-04 10:04:00 +00:00
Nicolas Fella
32ebe96eca Port konsolepart loading to use KPluginLoader directly
No need to go via KService
2021-07-04 09:13:01 +00:00
Eugene Popov
443968a6a3 Revert "Improve padding in the Places View"
This reverts commit e9a39700fc.
2021-05-29 22:16:18 +00:00
Eugene Popov
7a5d4033f4 Revert "fix padding in places view"
This reverts commit 56888a567f.
2021-05-29 22:16:18 +00:00
Eugene Popov
df9ae6c24e Use SmallMedium icon size in the Places panel as default
This patch makes the Places panel to use SmallMedium icon size as default, making it easier to read. It also removes extra spacing from items with small icons (reverts e9a39700 and 56888a56).

BUG: 437345
2021-05-29 22:16:18 +00:00
Saravanan K
6b64c7ff56 Add action to places panel context menu trash entry to open trash settings
BUG: 367583
FIXED-IN: 21.08
2021-05-20 16:04:41 +00:00
Ismael Asensio
4d9ea4261a Merge branch 'release/21.04' 2021-05-13 15:09:42 +02:00
Méven Car
6cec386192 InformationPanel: Allow to refresh the panel when its displayed content changes
BUG: 430095
BUG: 412902
FIXED-IN: 21.08
2021-04-24 09:00:31 +00:00
Harald Sitter
56888a567f fix padding in places view
padding was only applied when the icon size was applied, the icon size
however is only applied when the user had set an explicit size. this
resulted in inconsistent spacing. by default no padding would be used if
the user had changed the icon size to medium and back to small it would
suddenly have padding.

to fix this, set padding unconditionally on construction and never touch
it again .

BUG: 435731
2021-04-19 16:07:50 +00:00
Nate Graham
a32373e587 Allow selecting filename in information panel
BUG: 434329
FIXED-IN: 21.04
2021-03-15 09:43:46 -06:00
Laurent Montel
a440ff1acb Remove not implement methods 2021-03-07 20:41:15 +01:00
David Lerch
0811bf4a2b Use only enabled preview plugins in InformationPanelContent and ToolTipManager. 2021-02-19 23:07:54 +01:00
Méven Car
61a4ae4d3f Remove a missing emit KEYWORD
NO_CHANGELOG
2021-02-14 15:21:22 +01:00