kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-10-05 16:19:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Port konsolepart loading to use KPluginLoader directly

Browse source 
No need to go via KService
This commit is contained in:
Nicolas Fella 2021-07-03 20:13:39 +02:00 committed by Elvis Angelaccio
parent 7f562433c0
commit 32ebe96eca
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/panels/terminal/terminalpanel.cpp
View file

@ -17,7 +17,6 @@
#include <KPluginFactory>
#include <KPluginLoader>
#include <KProtocolInfo>
#include <KService>
#include <KShell>
#include <kde_terminal_interface.h>
@ -130,11 +129,8 @@ void TerminalPanel::showEvent(QShowEvent* event)
if (!m_terminal) {
m_clearTerminal = true;
KPluginFactory* factory = nullptr;
KService::Ptr service = KService::serviceByDesktopName(QStringLiteral("konsolepart"));
if (service) {
factory = KPluginLoader(service->library()).factory();
}
KPluginLoader loader(QStringLiteral("konsolepart"));
KPluginFactory* factory = loader.factory();
m_konsolePart = factory ? (factory->create<KParts::ReadOnlyPart>(this)) : nullptr;
if (m_konsolePart) {
connect(m_konsolePart, &KParts::ReadOnlyPart::destroyed, this, &TerminalPanel::terminalExited);