kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-07-15 18:01:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix padding in places view

Browse source 
padding was only applied when the icon size was applied, the icon size
however is only applied when the user had set an explicit size. this
resulted in inconsistent spacing. by default no padding would be used if
the user had changed the icon size to medium and back to small it would
suddenly have padding.

to fix this, set padding unconditionally on construction and never touch
it again .

BUG: 435731
This commit is contained in:
Harald Sitter 2021-04-19 12:39:00 +02:00
parent 61b2e2fd5e
commit 56888a567f
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/panels/places/placesview.cpp
View file

@ -1,5 +1,6 @@
/*
* SPDX-FileCopyrightText: 2012 Frank Reininghaus <frank78ac@googlemail.com>
* SPDX-FileCopyrightText: 2021 Harald Sitter <sitter@kde.org>
*
* SPDX-License-Identifier: GPL-2.0-or-later
*/
@ -11,6 +12,10 @@
PlacesView::PlacesView(QGraphicsWidget* parent) :
KStandardItemListView(parent)
{
KItemListStyleOption option = styleOption();
option.padding = 4;
setStyleOption(option);
const int iconSize = PlacesPanelSettings::iconSize();
if (iconSize >= 0) {
setIconSize(iconSize);
@ -26,7 +31,6 @@ void PlacesView::setIconSize(int size)
KItemListStyleOption option = styleOption();
option.iconSize = size;
option.padding = 4;
setStyleOption(option);
}
}