The YAML files already use the gitlab URLs, while the json doesn't.
The gnome-apps-nightly build script reads the json file, and the
builds have been failing because of this.
Update the json file accordingly.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/485
_GNU_SOURCE is required to be able to use POSIX functions that are not
available on non-Linux system. Specifically, we use sys/types for
requesting user accounts with getpwent and similars.
Usually systems seems to compile with this set, however some systems
like RHEL doesn't assume it so.
Since this is more correct to set it explicitly, this commit does that
by passing an argument to meson project.
setpwent is used but we didn't include the necessary headers.
It was building in Fedora because some other header included it,
but that's not the case in RHEL.
Since 13a8d3efac
there is no need for some variables.
The removed variables were used to distinguish between single or
double click. This is no longer needed as GTK3 offers support
for this through gestures.
This patch removes those variables.
Currently, for double-click mode, middle-clicking a folder in
List View fails to open a new tab, but only highlights the
selection instead. Middle-clicking the folder again opens it
in a new tab.
For double-click mode, middle-clicking a folder should open it
in a new tab. Also, middle-clicking a file should open it.
This patch fixes this behaviour.
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/453
In nautilus_get_mounted_mount_for_root
g_volume_monitor_get is called
without cleanup
We need cleanup or auto cleanup
for GVolumeMonitor
g_autoptr is added for auto cleanup
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/471
NautilusSelectionCanvasItem lost a few properties that control the way
the selection rectangle is drawn, namely the color and
stippling-enabling ones, which results in different rendering of the
file outlines when dragging multiple of them. At the moment, the
outlines are styled according to GTK_STYLE_CLASS_RUBBERBAND, which gives
them solid blue-ish borders and a light blue background.
This commit removes the code that sets those properties.
This takes care of a couple of things:
- not claiming the sequence at the end of the button press handler
breaks ctrl-clicking;
- chaining up to button_press_event() in some cases is superfluous;
- chaining up to button_press_event() instead of propagating the
event down breaks expanders.
Even though more convoluted than the previous solution, this one
should last longer. Canvas item icons are now colorized by first drawing
the background to a Cairo surface and then multiplying the color values
of the original icon pixbuf and the ones from the newly created one.
So far we have been building master of all of our dependencies, also
master of the Sdk. This is good for testing the next version of the
ecosystem, but has many downsides that we now can avoid with Flatpak.
For instance, we want to be buildable at any point in the history,
specially when doing bisects. Also, we need to be a bit stable so that
when designers, users or others build the latest Nautilus they are able
to work with it regardless of its dependencies on other projects.
Even more, now with CI we can test the master of the ecosystem regularly
while not affecting our regular development and operations by depending
on that.
So let's separate in two different manifests the development version
with stable dependencies, intended for our regular operations, and a
development version with all the ecosystem on master, to test the
ecosystem regularly on the CI or on-demand locally.
According to GTK+ docs, this should be the same for all windows of an
application, and GTK+ defaults to doing that itself. However, there is a
slight issue in that the properties window sets a custom window icon
that isn’t reset instantaneously after closing the dialog.
