gnome/nautilus
gnome/nautilus
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/nautilus synced 2024-07-16 10:17:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

general: Stop relying on side effect in warning macros

Browse source 
The expression will not be evaluated if the macros are disabled.
This commit is contained in:
Ernestas Kulik 2018-05-25 15:56:46 +03:00
parent fc4cbbe647
commit 35536fdea8
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/nautilus-batch-rename-dialog.c
View file

@ -1704,7 +1704,10 @@ on_motion_notify (GtkWidget *widget,
update_row_shadowing (dialog->preselected_row2, FALSE);
}
g_return_val_if_fail (gdk_event_get_coords (event, NULL, &y), GDK_EVENT_PROPAGATE);
if (G_UNLIKELY (!gdk_event_get_coords (event, NULL, &y)))
{
g_return_val_if_reached (GDK_EVENT_PROPAGATE);
}
if (widget == dialog->result_listbox)
{

5
src/nautilus-list-view-dnd.c
View file

@ -285,7 +285,10 @@ nautilus_list_view_dnd_drag_begin (NautilusListView *list_view,
source_target_list = nautilus_list_model_get_drag_target_list ();
}
g_return_val_if_fail (gdk_event_get_coords (event, &x, &y), GDK_EVENT_PROPAGATE);
if (G_UNLIKELY (!gdk_event_get_coords (event, &x, &y)))
{
g_return_val_if_reached (GDK_EVENT_PROPAGATE);
}
if (gtk_drag_check_threshold (GTK_WIDGET (list_view->details->tree_view),
list_view->details->drag_x,