Nautilus can show "Unable to find the requested file. Please check the
spelling and try again." error when starting. The message doesn't indicate
what file was not found. Let's add the file name to that dialog to make it
obvious.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1793
The slot.files-view-mode action takes hardcoded id values. This may
break if the ids enumeration changes.
Instead, let's define the values with a macro which we can stringify.
While we are at it, drop the unused EMPTY id.
We define a NautilusWindow method in nauitlus-window-slot.c. That's
just wrong.
Also, there is no reason for this to be a NautilusWindow method,
rather than a slot one.
The only consumers are NautilusWindow and NautilusToolbar, and both
have a pointer to the current slot, so let's make this a slot method.
For convenience, also add a private NautilusWindow wrapper method.
Last commit removed the only subclass because switching slot class is
problematic, so we probably don't want to do it again.
This partially reverts 0a512d00b6
The NautilusOtherLocationsWindowSlot subclass has been introduced along
with its sibling NautilusDesktopWindowSlot.[0]
However, the desktop one is now gone, and this is the only subclass.
It does only 2 things differently from its parent class:
* Creates a NautilusPlacesView instead of a NautilusFilesView
* Disables the slot.files-view-mode-toggle and files-view-mode actions
There is little reason not to handle both things in the parent class.
Also, changing slots when going in and out of the Other Locations place
throws away the navigation data; while this can be worked around by
saving and restoring this data, this outweights any potential benefits
of subclassing.
This commit is equivalent to reverting [0], but due to code style and
other changes, a clean revert was not possible.
Effectively fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/32
[0] commit 5f295bd92c
The feature that allows opening a new window from the history popup menu
by middle-clicking hasn’t been working for three years, since the flags
parameter in nautilus_window_back_or_forward() is not honored. In some
places it’s used inappropriately, so it’s better to just drop the code
and rethink the approach if such a feature is desirable.
When the "Show Hidden Files" check button is toggled, the popover is closed,
however, when the "Show Sidebar" check button is toggled, the popover stays
opened. This is inconsistent and the popover should stay open in all cases.
This happens because of a bug in the `nautilus_toolbar_is_menu_visible`
function implementation, which is checking the visibility of the `view_button`
popover instead of the `app_menu` popover. Let's check the visibility of the
correct popover to fix this inconsistency.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1827
This reverts commit 54d1ad250e.
This signal has been added because NautilusApplication needed to update
the previewer when selection changes. It no longer does that, since the
previous commit, so this signal is no longer needed.
When the NautilusFilesView:selection property changes, this change is
notified to the slot, the the window, then the application, though a
chain of bindings and singals. The application class then calls a
NautilusFilesView method to actually update the preview.
The NautilusApplication class used to update the preview when the
active window changes, but that's no longer the case after the changes
in commit 0b7a7f95f8.
This whole roadtrip to NautilusApplication and back is useless now, so
let's handle it all in NautilusFilesView.
The description of a folder in the properties dialog precise the
mime-type but it is useless for folders
Test if the mime type is not equal to "inode/directory" before
adding it to the detailed string.
https://gitlab.gnome.org/GNOME/nautilus/-/issues/1737
When the properties window is opened, the name field get the focus automaticaly.
The user can accedentily change the file name, so let's prevent the name field from
being automaticaly selected.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1805
When creating a new file using a template, it's possible for is_added
to be FALSE, so make sure the file is unref'd regardless.
This actually resolves an issue in caja and nemo which is caused by
files created in this manner not being finalized when no longer in use.
I can reproduce the issue with nautilus, but this *does not* fix it,
so I think that there may be an additional leak somewhere else (maybe
not related to template-created files).
To reproduce:
- Create an svg file and save in ~/Templates.
- Right-click, Create document-> svg file, name it whatever.
- Navigate out of the folder.
- Modify the file in a visible manner.
- Re-enter the folder, note that it never finishes loading.
Original report:
https://github.com/linuxmint/nemo/issues/2736
Animating unmapped widgets can still change their size, so they have to
be measured every time. https://gitlab.gnome.org/GNOME/gtk/-/issues/1025
As a workaround, ensure the spinner doesn't animate while it's not shown,
to reduce CPU usage.
It is a very specific corner case when the previewer (sushi) is
being used alongside multiple windows of Nautilus.
This causes a race condition when the change of active-window
notification arrives out of order with the check for the previewer
"Visible" property, making the update process loop when previewing
videos.
Fixes#1823
When running an executable text file as a program, it's reasonable to
expect that the directory currently displayed by the file browser
becomes the current working directory for that program. This used to be
handled correctly by the activation action.
While taking "Run as a Program" out of activation into a standalone
action, this behavior was left behind.
Let's add it back to the standalone action to fix the regression.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1842
The new filename entry has the automatically suggested part of the name
selected for convenience since 9108b4028b
However, the logic for this relies on extensions offsets, causing
crashes when failing to handle the extensionless case, which is common
for folders.
So, improve the logic here to handle extensionless filenames, looking
at their length instead.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1841
Currently, an empty string is passed to gnome-autoar if the archive
extraction password dialog is cancelled. This is not problem currently
as immediately the `abort_job` function is called, however, it would
be nice to return `NULL` to make obvious that the prompt dialog was
cancelled.
https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/657#note_1084750
When extracting encrypted archives, Nautilus randomly crashes when opening
the password dialog. This happens pretty often under X11, but I have
already seen a few crashes on Wayland as well. I suppose that all those
crashes are caused because the password dialog is constructed on the
extraction thread and GTK is not thread-safe. Let's modify the code to call
GTK on the main thread only to fix those crashes.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1825
The `validate-desktop`, `validate-desktop-autorun-software` and
`validate-appdata` meson tests fail currently because of the updated meson.
This is because of the recent change, which requires explicit specification
of dependencies. Let's specify them to fix the pipeline.
https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/372
The network access is no more needed for gvfs support as it currently
uses named sockets instead of abstract ones. It is enough to allow access
to `xdg-run/gvfsd` folder, where the named sockets reside. I'm not aware
of other reasons for allowing network access. Let's drop the network
access. This also workarounds "Too many open files" errors caused by
leftover sockets (GNOME/gvfs#542).
Relates: https://gitlab.gnome.org/GNOME/gvfs/-/issues/515
