2001-01-24 Pavel Cisler <pavel@eazel.com>
reviewed by: John Sullivan <sullivan@eazel.com>
* src/file-manager/fm-directory-view.c:
(fm_directory_view_destroy),
(schedule_update_menus):
A simple tweak to reduce the number of menu item updates --
schedule fm_directory_view_update_menus using a gtk_timeout_add
instead of gtk_idle_add, use a 300 ms interval for coalescing
menu item updates.
* src/file-manager/fm-directory-view.c:
(fm_directory_view_pop_up_selection_context_menu),
(fm_directory_view_pop_up_background_context_menu):
Call fm_directory_view_update_menus directly to make sure the
context menu comes up set up right instead of flickering.
2001-01-24 Gene Z. Ragan <gzr@eazel.com>
reviewed by: Pavel Cisler <pavel@eazel.com>
Fixed bug 5710, Images no longer snap to size after hitting Refresh
* components/image-viewer/nautilus-image-view.c: (redraw_control),
(load_image_from_stream), (scrolled_window_size_allocate_callback):
Restore the previous zoom setting when reloading a file from a stream.
Fixed a logic flaw dealing with renaming NautilusLinks. The icon view
had duplicated some logic that was present in NautilusFile. There were
slight differences in the logic that lead to some confusion in determing
if a link could be renamed.
* libnautilus-extensions/nautilus-file.c:
(nautilus_file_can_rename):
* src/file-manager/fm-icon-view.c: (fm_icon_view_update_menus):
* src/nautilus-window-menus.c: (get_static_bookmarks_file_path):
fixed bug 5985, we should use timestamps to determine which
static bookmarks file to use; now it does.
reviewed by: Ramiro Estrugo
* components/music/nautilus-music-view.c: (add_play_controls):
Set alignment of playtime so it's flush left, otherwise it jumps
around slightly.
2001-01-24 Josh Barrow <josh@eazel.com>
* icons/i-directory-192.png:
Removed this file. This was one of the old GNOME icons, and it
was no longer in use.
reviewed by: Ramiro Estrugo
* components/music/nautilus-music-view.c:
(nautilus_music_view_initialize), (add_play_controls):
Removed a call to problematic call to gtk_widget_set_usize
and added FIXMEs for the remaining calls to it - bug 5967.
Fix bug 5797 (Critical received when double-clicking on throbber):
* src/nautilus-window-private.h:
* src/nautilus-window.c: (location_change_at_idle_callback):
Callback to do actual location change at idle time instead of
right inside the property bag callback from the throbber.
(throbber_location_change_request_callback): Use the new idle
approach instead of changing the location right away.
(nautilus_window_destroy): Cancel the idle if it's still
outstanding.
* libnautilus-extensions/nautilus-file.c:
(nautilus_file_get_string_attribute_with_default): Mark a string
for translation.
(get_description): Mark some warning strings for translation since
they are warnings we think real users might see.
* applets/launcher/.cvsignore:
* applets/preferences-applet/.cvsignore:
Ignore some files.
* data/static_bookmarks.xml:
A tiny fix from Brian Frank. Also, save the file as a regular
text file without the DOS extra CRs.
* src/nautilus-sidebar-title.c:
(sidebar_title_create_title_label),
(sidebar_title_create_more_info_label): Center justify the sidebar
title labels.
* src/nautilus-property-browser.c:
(nautilus_property_browser_initialize), (make_category_link):
removed some set_usize calls that I had only commented out before.
* AUTHORS:
* THANKS:
* src/nautilus-window-menus.c: (help_menu_about_nautilus_callback):
Updated based on recent check-ins and other contributions.
* check-THANKS.pl: Updated to check the about list against the
AUTHORS file and to fix some other things.
* libnautilus/nautilus-view-component.idl: Fix a comment and
remove a stray empty line.
reviewed by: George Lebl
* components/image-viewer/nautilus-image-view.c:
(control_destroy_callback), (control_factory_common):
image-view was using freed (widget) memory.
* src/nautilus-theme-selector.c: (remove_button_callback),
(exit_remove_mode):
fixed recently introduced problem where it was still
treating button labels as nautilus_labels instead of
gtk_labels.
* src/nautilus-theme-selector.c:
(nautilus_theme_selector_initialize), (remove_button_callback),
(exit_remove_mode):
fixed bug 5972, remove theme button uses aa text, by using
a gtk_label instead of a nautilus_label. Also, hide the
add button during remove mode so it's less confusing.
* libnautilus-extensions/nautilus-theme.c:
(nautilus_theme_make_selector):
fixed a crash when an installed theme lacked a preview icon,
cleaned up code and fixed a memory leak.
* components/services/install/command-line/eazel-alt-install-corba.
c: (md5_check_failed), (delete_files):
Changed output in md5_failed to be readable.
Only ask about deleting files if any where downloaded (the check
was commented out for some reason)
* components/services/install/command-line/eazel-test-packsys.c:
(test_package_load), (test_query), (test_query_owns_mem),
(is_installed), (test_install), (test_uninstall), (test_verify),
(main):
s/packagedata_destroy/gtk_object_unref/ - eazel-test-packsys now
no longer leaks packagedata objects.
* components/services/install/lib/eazel-install-corba-callback.c:
(impl_md5_check_failed):
Removed an debug output.
* components/services/install/lib/eazel-install-logic2.c:
(is_satisfied), (is_satisfied_features):
(check_dependencies_foreach), (check_dependencies):
Fixed nasty bug that caused the install service to loop on some
packages that have circular dependency (found by Ken).
* components/services/install/nautilus-view/nautilus-service-instal
l-view.c: (nautilus_install_parse_uri),
(nautilus_service_install_view_update_from_uri):
Fixed the port thing again (should fix 5960)
* libnautilus-extensions/nautilus-directory-background.c:
(theme_image_path_to_uri):
fixed bug 5908, assert hit when background pattern is deleted, by
testing explicitly for the file missing and returning NULL in that
case instead of asserting.
could be faster)
Fixed bug 5687 (Sidebar flickers and CPU thrashes during
deep count calculation in properties window)
Changed the deep count calculation to send a specialized
signal when the in-progress count updates, instead of using
"file_changed", since many parts of the UI react to file_changed
by doing (in this case unnecessary) work. My stopwatch measurement
on a large directory showed that the time to calculate 20000
contained files went from 147 seconds to 8 seconds, and the CPU
usage pegged around 15% (formerly 100%).
* libnautilus-extensions/nautilus-directory-async.c:
(deep_count_callback): Call nautilus_file_changed only when
count is finished; call nautilus_file_updated_deep_count_in_progress
after every new higher value is computed.
* libnautilus-extensions/nautilus-file-private.h:
Added prototype for nautilus_file_updated_deep_count_in_progress.
* libnautilus-extensions/nautilus-file.h:
* libnautilus-extensions/nautilus-file.c:
(nautilus_file_initialize_class): define "updated_deep_count_in_progres"
signal.
(nautilus_file_updated_deep_count_in_progress): send this new signal
for this file (which must be a directory) and any links pointing to
it.
* src/file-manager/fm-properties-window.c:
(attach_directory_contents_value_field): Make text field in properties
window react to new signal instead of "changed".
dialog should be in quotes)
* libnautilus-extensions/nautilus-program-chooser.c:
(nautilus_program_chooser_show_no_choices_message):
Put quotes around file name in dialog.
* components/hardware/nautilus-hardware-view.c:
(hardware_view_load_location_callback):
fixed bug 5746, hardware title in hardware view not translated, by
explicitly setting the title using a localized string. This also
fixes the minor problem of the title not being capitalized
* icons/villanova/villanova.xml:
fixed bug 5658, Sierra theme lacks description, by adding a
description to the xml file.
* src/nautilus-property-browser.c:
(nautilus_property_browser_initialize), (make_category_link):
fixed bug 5587, hard-coded button geometry in the property browser,
fixed by removing the set_usizes and allowing gtk to adaptively
size them and replacing the table that was holding them with a
box so they will be centered properly.
2001-01-23 Robin * Slomkowski <rslomkow@eazel.com>
* nautilus.spec.in: changed mozilla required version
to 0.7 this messes upgrades since 0.7 is lower than M18
* src/nautilus-theme-selector.c:
(nautilus_theme_selector_initialize):
Band aid fix for bug 5910 - Font size for Theme name is too large
in "Nautilus Theme Selector" dialog. I made the column larger to
fit up to and including the length of the currently largest known
theme name "Crux-Eggplant"
There are many reason why this is a lame band aid fix. The real
fix is to not hard code any geometry in this code. I filed a bug
for that (5951).
* components/services/install/command-line/eazel-alt-install-corba.
c: (set_parameters_from_command_line), (something_failed):
Removed the --port argument (since --server is now in server:port
form).
Removed --tmp as you shouldn't set it anymore.
Rename --noauth to --no-auth and --ssl_rename to --ssl-rename.
Default behaviour is now that no server or no-auth argument causes
eazel-install to use trilobite server setting and proxy. --no-auth
just uses trilobite server and no proxy, --server sets the server
and no proxy.
Changed output in something_failed.
* components/services/install/lib/eazel-install-logic.c:
(eazel_install_start_signal), (eazel_install_failed_signal):
Don't emit progress in uninstall (since the EazelInstall object
didn't have them, I was currently emitting install progress
signals)
Only emit failed signals on the toplevel.
* components/services/install/lib/eazel-install-logic2.c:
(eazel_install_check_existing_packages), (get_softcat_info),
(is_satisfied):
More ifdeffed debug.
Uncommented a commented out gtk_object_unref.
Commented out a unref and emit_failed, since the pruner is doing
this.
In is_satisifed, if no version in dep, check if package is
installed before checking features list. Faster and safer.
* components/services/install/lib/eazel-package-system-rpm3.c:
(make_rpm_argument_list),
(monitor_rpm_process_pipe_percent_output),
(monitor_rpm_process_pipe), (eazel_package_system_rpm3_execute):
Some ifdeffed code for --percent handling.
Set go==FALSE in execute if root helper fails (fixes a bug where
the installer would hang if wrong password was entered).
* components/services/install/nautilus-view/nautilus-service-instal
l-view.c: (nautilus_service_install_view_update_from_uri):
Default to port 80 if trilobite_get_services_address did not
include a port.
Fix bug 5914 - First run of Nautilus on clean system crashes.
* src/nautilus-application.c: (nautilus_application_initialize),
(nautilus_application_destroy), (nautilus_application_startup):
Add the preference callback for show_desktop much later in the
initialization of the Nautilus Application. Otherwise, the first
time druid triggers prefernece changes that cause the desktop to
turn on in the middle of the first time druid being presented to
the user.
2001-01-22 Rebecca Schulman <rebecka@eazel.com>
* libnautilus-extensions/nautilus-search-uri.c:
(nautilus_self_check_search_uri):
Fixed "make check." Oh, the woes.
Earlier I removed a field from a struct in
nautilus-search-uri and broke binary compatibility
between the many mysterious structs here. It seems
they all must be the same size.
Added a fixme so that we know this in the future,
hopefully. Also added an additional test during
debugging.
* src/nautilus-sidebar-tabs.c: (draw_one_tab_themed),
(draw_or_layout_all_tabs):
fixed bug 5895, critical errors when you make the sidebar small.
Fixed by clipping the amount we draw to fit within the destination
buffer before calling gdk_pixbuf_composite. Also fixed another crash
when trying to draw aa-text for the tab labels when the starting
offset is bigger than the buffer; in that case, don't draw anything.
reviewed by: Ramiro Estrugo
* libnautilus-extensions/nautilus-directory-background.c:
(desktop_background_realized),
(nautilus_connect_desktop_background_to_file_metadata),
(image_loading_done_callback),
(nautilus_connect_background_to_file_metadata):
Desktop backgrounds were being drawn before they were initialized.
Bugs 5853 & 5896.
2001-01-22 Rebecca Schulman <rebecka@eazel.com>
Fix bug 5316, that search results code has
empty strings marked for translation.
* libnautilus-extensions/nautilus-search-uri.c: (parse_uri):
Remove "prefixes" for search criteria that were
always blank.
