development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-13 06:48:17 +00:00
Code Issues Packages Projects Releases Wiki Activity
100785 commits 1119 branches 299 tags 1.2 GiB
Commit graph

12874 commits

Author SHA1 Message Date
Matt Bierner 00bb9bdefc
Always log tsserver exit code, even for kill processes (#156378) 
We suspect that some exit code info is being dropped since 1.61. Changing this code to always log, even when the user manually restarts the server
 2022-07-27 11:54:24 -07:00
Martin Aeschlimann 857412ab10
devcontainer schema: handle deprecated properties (#156425) 2022-07-27 20:27:47 +02:00
Alex Ross a3b712e04e
Create a insiders.vscode.dev link when I use insiders for sharing (#156436) 
Fixes #156255
 2022-07-27 10:55:08 -04:00
Matt Bierner 241c770203
Exclude esbuild files from build (#156362) 2022-07-27 09:32:07 -04:00
Ladislau Szomoru d01945923c
Git - Fix regression with Commit action button icon (#156417) 
Fix regression with Commit action button icon
 2022-07-27 13:11:07 +02:00
Ladislau Szomoru e210bbfea4
Git - fix edge case during rebase (#156410) 
Fix blocking issue while resolving conflicts during rebase
 2022-07-27 12:03:47 +03:00
Matt Bierner 9cf2fabdd6
Rename editor.dropIntoEditor.enabled setting (#156381) 
Fixes #156344
 2022-07-27 06:44:44 +02:00
Michael Lively 53c3028c47 add notebook-out to .gitignore 2022-07-26 12:29:23 -07:00
Michael Lively 2077ae5120 fix package.json/esbuild.js for files in publish 2022-07-26 12:19:27 -07:00
Matt Bierner cf145a83ac
Enable safe inline svg tags in trusted html (#156216) 
Enable safe svg tags in trusted html

From cce00ac40d/src/tags.js (L124)
 2022-07-25 16:32:10 -07:00
易良 fbdc848c29
fix: typos (#155310) 
* fix: typos

* chore: revert formatting changes

* fix: Remove redundant blank lines
 2022-07-25 15:41:30 -07:00
Martin Aeschlimann 0b7a99104d
theme-seti icon Laravel .blade.php lose php icon when installing blade related extension (#156204) 
theme-seti icon Laravel .blade.php lose php icon when installing blade related extension. Fixes #153410
 2022-07-25 16:35:30 -04:00
Raymond Zhao 52a71a1843
Make some Emmet settings language-overridable (#156184) 
Fixes #156075
 2022-07-25 20:00:36 +02:00
Martin Aeschlimann 361215a168
seperate out devContainer schemas for vscode & codespaces (#156170) 
* seperateout devContainer schemas for vscode & codespaces

* fix for vscode schema
 2022-07-25 18:17:23 +02:00
Matt Bierner 68cbaa708e
Pick up new version of markdown-language-server (#156010) 
This fixes md diagnostics and links for multiroot workspaces
 2022-07-24 22:22:03 -07:00
Matt Bierner a9b387204b
Add some additional logging to md server (#156007) 
Logs watcher operations
 2022-07-23 00:32:10 +02:00
Peng Lyu e6ad5f0a6f
Update ipynb yarn lock (#156004) 2022-07-22 23:26:14 +02:00
Michael Lively 9428c6650b
Merge pull request #155777 from Yoyokrazy/temp 
Added support for jupyter attachment field, embedded image rendering in markdown notebook cells
 2022-07-22 12:04:44 -07:00
ryuurock 42e79ca270
Update typescriptServiceClient.ts, fix naming errors (#155946) 
Update typescriptServiceClient.ts

fix naming errors
 2022-07-22 17:46:48 +00:00
Johannes Rieken b8876a2d60
enable merge editor by default (#155937) 2022-07-22 11:28:49 +02:00
Matt Bierner e2006a52da
Add npmignore to markdown server (#155898) 
* Add npmignore to markdown server

* Update version
 2022-07-21 16:21:57 -07:00
Matt Bierner b2daf1af82
Add MD server tracing and update diagnostics on files changes (#155797) 2022-07-21 10:07:06 -07:00
Johannes Rieken bbbae594da
show "Accept Merge" only for files currently under conflict. (#155822) 
While the merge editor shows users can handle merge conflicts outside of it, e.g on the console via `git add <FILE>`. The merge editor should have this graceful and step one is to hide the "Accept Merge" command when the file isn't conflicting anymore

* Adds a git-context key that contains all resource-uri-strings under conflict
* Enable/placement of the Accept Merge command is driven by that
* some merge editor context key sugar
 2022-07-21 13:25:23 +02:00
Angelo cef02dae8d
Contribute to html language server with a custom language. (#146731) 
* Contribute to html language server with a custom language.

Fixes #146730

Signed-off-by: azerr <azerr@redhat.com>

* refactor out LanguageParticipants

* restart client on language selector change

* htmlLanguage -> htmlLanguageParticipants

* tune autoInsert wording

* tune autoInsert description

Co-authored-by: azerr <azerr@redhat.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
 2022-07-21 13:19:01 +02:00
Benjamin Pasero 6cad4b9494
skip test & 💄 (#155826) 2022-07-21 12:47:23 +02:00
Ladislau Szomoru ace330ba2c
SCM - Fixed a regression due to which post-commit commands were not being executed (#155824) 
Fixed a regression due to which post-commit commands were not being executed
 2022-07-21 12:25:15 +02:00
Matt Bierner 924dde5c1e
Documenting markdown LS (#155789) 2022-07-21 11:48:30 +02:00
Benjamin Pasero 477af8c842
skip flaky test (#152145) (#155809) 2022-07-21 11:46:51 +02:00
Ladislau Szomoru cd90b2b5ad
Git - Add telemetry comments (#155811) 
Add telemetry comments
 2022-07-21 09:34:19 +02:00
Ladislau Szomoru e0e7ad368e
Git - Enable action button while rebasing (#155744) 
Enable action button while rebasing
 2022-07-20 23:35:05 -07:00
Michael Lively eaf321d50d formatting 2022-07-20 16:12:32 -07:00
Michael Lively 63142212a1 remove md-it dependency, added undefined check to attachments 2022-07-20 16:10:54 -07:00
Michael Lively ff31f6b577
Update package.json 2022-07-20 15:01:40 -07:00
Michael Lively 3a23dda32c
removed commented code 2022-07-20 13:47:26 -07:00
Michael Lively d7b6596808 yarn.lock with yarnpkg instead of npm 2022-07-20 12:35:42 -07:00
Michael Lively 6a73a0d22d rm package-lock.json 2022-07-20 12:25:57 -07:00
Michael Lively 1b59f566bb rendering of attachment images complete via tokens 2022-07-20 12:23:37 -07:00
Michael Lively 735ead82f5 added attachment and metadata support back in... rebasing is scary 2022-07-20 12:23:37 -07:00
Michael Lively 3981a5804c added build stuff 2022-07-20 12:23:37 -07:00
Michael Lively 0fa857c9a1 okay now things are actually fresh and working 2022-07-20 12:23:24 -07:00
Ladislau Szomoru f19251a4ca
Git - Use GIT_EDITOR environment variable to suppress the git commit editor during rebase (#155748) 
Use GIT_EDITOR environment variable to suppress the git commit editor during rebase
 2022-07-20 17:52:56 +02:00
Ping 0b2c56eb7b
Fix #114461 (#151824) 
suppress the editor during git rebase, fix #114461

Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
 2022-07-20 15:03:43 +02:00
Martin Aeschlimann d0769c7e7f
[html] update service and fix url resolving (#155725) 2022-07-20 14:38:10 +02:00
Martin Aeschlimann 28be5d9906
Configurations ${WorkSpace} autocomplete broken after update (#155713) 
Configurations ${WorkSpace} autocomplete broken after update. Fixes #155638
 2022-07-20 08:01:52 -04:00
Johannes Rieken ce5d92e998
use commit-icon for description, tweak codicon font-size (#155714) 
https://github.com/microsoft/vscode/issues/150863
 2022-07-20 13:49:24 +02:00
Johannes Rieken 7cdaa57928
also default to opening merge editor when conflict is about adding (#155711) 
fixes https://github.com/microsoft/vscode/issues/153737#issuecomment-1189357241
 2022-07-20 12:36:08 +02:00
Matt Bierner 32f5e49082
Move MD diagnostics to language server (#155653) 
* Move MD diagnostics to language server

This switches us to using the LSP pull diagnostic model with a new version of the language service

* Bump package version

* Delete unused file
 2022-07-19 16:34:09 -07:00
Ladislau Szomoru 03c16c9c00
Git - The git.sync command should use the git.rebaseWhenSync setting (#155511) 
The git.sync command should use the git.rebaseWhenSync setting
 2022-07-18 18:38:58 +02:00
Ladislau Szomoru b3218963c4
Git - Do not show SmartCommit dialog when using "Commit All" (#155486) 
Do not show SmartCommit dialog when using "Commit All"
 2022-07-18 16:55:41 +02:00
Johannes Rieken 8bada27fdd
Merge pull request #155148 from microsoft/joh/double-barnacle 
joh/double barnacle
 2022-07-18 16:45:00 +02:00
Joyce Er 73b34320c1
Add ability to continue desktop edit session in vscode.dev 2022-07-15 15:51:51 -07:00
Martin Aeschlimann e225afee30
Add syntax highlighting for .env files without extensions (#155298) 
Add syntax highlighting for .env files without extensions. Fixes #154111
 2022-07-15 12:24:40 +00:00
Matt Bierner 394eaa9fa3
Fix md document links for untitled files (#155248) 2022-07-14 18:15:13 -07:00
Joyce Er a0c9ebe6b4
Disable chunking to prevent importScripts calls in web (#155226) 2022-07-14 18:55:38 +00:00
Johannes Rieken 1878583319
read REBASE_HEAD when rebasing, swap yours/theirs (label, sides) as well (#155208) 
https://github.com/microsoft/vscode/issues/153737
 2022-07-14 09:23:44 -07:00
Ladislau Szomoru ee18db8144
Sync Changes button - only show when local branch is ahead/behind the remote branch (#155192) 
Only show Sync Changes button when local branch is ahead/behind the remote branch
 2022-07-14 13:51:47 +00:00
Ladislau Szomoru 70a1ebd595
Git - Add events to IPostCommitCommandsProviderRegistry (#155051) 
* Add events to IPostCommitCommandsProviderRegistry

* Pull request feedback
 2022-07-14 10:46:57 +02:00
Johannes 0f0101be5f
use TabInputTextMerge in git extensions 
For now only when checking for tabs, not yet for opening tabs
 2022-07-14 09:41:54 +02:00
Ladislau Szomoru f6332bd86d
Git - Use cloud icon for remote branches (#155140) 
Use cloud icon for remote branches
 2022-07-14 08:55:29 +02:00
Matt Bierner 9ee8961347
Move MD references, rename, and definition support to md LS (#155127) 2022-07-14 08:32:27 +02:00
Matt Bierner 867acc336f
Remove references to finalized drop api (#155128) 2022-07-14 08:27:25 +02:00
Matt Bierner 50056f3e78
Finalize drop into editor api (#155102) 
Fixes #142990
Fixes #149779
 2022-07-13 12:54:52 -07:00
Matt Bierner bec36ce756
Move md path completions and document links to language server (#155100) 2022-07-13 12:49:37 -07:00
Ladislau Szomoru bc51adde6f
git - Add localization comment for Publish Branch action button (#155053) 
* Add localization comment for Publish Branch action button

* Pull request feedback
 2022-07-13 14:39:18 +00:00
Rich Chiodo 052d5b0027
Fix issue with kernel preselection being overridden by view state (#154968) 
* Fix view state overriding selected kernel

* Add test to verify correct kernel is used
 2022-07-12 18:03:49 -07:00
Matt Bierner 75e231ad82
Clean up document link resolve (#154959) 
- Move vscode scheme normalization to the DocumentLinkProvider
- Remove extra function since we already recognize uri-like links
 2022-07-12 15:55:21 -07:00
Matt Bierner 8f4d1a97f3
Clean up HtmlRenderingHook (#154961) 
- Pass `HtmlRenderingHook` to hook
-  Rename register function to make it clear it is experimental
- Add docs
 2022-07-12 11:27:47 -07:00
Raymond Zhao d627aa4606
Emmet: Add back trigger character arguments (#154940) 
Fixes #154375
 2022-07-12 09:15:01 -07:00
Ladislau Szomoru c7c0acd2ce
Git - Commit action button extension api (#154555) 2022-07-12 17:06:16 +02:00
Matt Bierner eeb8d49317
Move md workspace symbol search to language service (#154874) 
* Move md workspace symbol search to language service

Also implements more of IWorkspace for the server

* Revert extra change
 2022-07-12 10:04:25 -04:00
Alexander Fadeev 491a83446e
Add Makefile tests for upgraded grammar: comma, comment, shebang (#154625) 
Add Makefile tests for upgraded grammar: comma, comment, shebang.

1. Add comma separator for function calls and conditions.
2. Escaping a comment with an odd count of backslashes (\#, \\\#).
3. Match debian/rules files based on shebang.

Co-authored-by: Alex Ross <alros@microsoft.com>
 2022-07-12 13:11:36 +02:00
Ladislau Szomoru acd1db24f2
Git - fix edge case with Windows mapped drives (#154342) 
* Fix an edge case with computing relative path on Windows

* Refactor the fix
 2022-07-12 12:20:41 +02:00
Johannes Rieken c46640d635
remove obsolete API proposal name from api-tests, fyi @Tyriar (#154902) 2022-07-12 11:35:56 +02:00
Matt Bierner c9bf4393d5
Rename drop API interface (#154876) 
Makes the names more consistent
 2022-07-12 11:33:13 +02:00
Matt Bierner 3a9292f23f
Remove extra files from build (#154875) 
These server files should not be included
 2022-07-12 11:31:43 +02:00
Aiday Marlen Kyzy 47a1f80c65
Adding keepLines feature to the settings (#154790) 
* Adding the keepLines feature into the settings so the user can format while keeping the original line positions in json documents

* update service

* update dependencies

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
 2022-07-12 09:59:33 +02:00
Matt Bierner e02c71e3c6
Fix range of reference links (#154819) 
Fixes #150921
 2022-07-11 17:46:15 +02:00
Matt Bierner 82687c84ee
Add hook for extending built-in html renderer (#154316) 
Fixes #153836

Lets extension register a hook that is invoked after the html element is renderered
 2022-07-11 08:21:02 -07:00
Daniel Imms ded49a19ef
Merge branch 'main' into proposal-130231 2022-07-11 07:06:18 -07:00
Alex Ross 473c57e261
Update make grammar (#154789) 2022-07-11 12:14:40 +02:00
Ladislau Szomoru 5d18f94bb0
Git - Maintain spaces in the arguments (#154685) 
Maintain spaces in the arguments
 2022-07-11 02:28:57 -07:00
Ladislau Szomoru f2a475346f
Fix compilation error (#154699) 2022-07-10 07:50:17 -07:00
Daniel Imms 741b3cace8
Merge branch 'main' into proposal-130231 2022-07-10 07:40:11 -07:00
Matt Bierner 2b3912fa29
Fix markdown extension path (#154656) 
Fixes #154645
Fixes #154653
 2022-07-10 14:25:45 +02:00
jeanp413 318bdcc4cc Fix tests 2022-07-08 00:16:11 -05:00
Ladislau Szomoru eb2e5d8558
Git - Commit action button should use smart commit settings (#154169) 
Consider smart commit settings when rendering the commit action button
 2022-07-07 21:31:10 +02:00
Matt Bierner 2fb56e9d62
Move smart select and folding to md language server (#154334) 
* Move smart select and folding to md language server

Also fixes a few minor issues:

- Don't log to web console
- Remove convert code since it is no longer needed
- Use correct extension id

* bump cache

* Bump package version

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
 2022-07-07 07:30:03 -07:00
Johannes Rieken e5f5a16b74
joh/issue145374 (#154360) 
* enroll more places into `snippetWorkspaceEdit` proposal,

https://github.com/microsoft/vscode/issues/145374

* tweak API proposal for snippet edits, make this `WorkspaceEdit` only, remove old proposal bit

https://github.com/microsoft/vscode/issues/145374
 2022-07-07 12:55:51 +00:00
João Moreno b4525a77fb
update yarn.lock (#154336) 2022-07-07 09:26:12 +02:00
Logan Ramos a20329d291
Switch extensions to 1DS (#154299) 
* Move extensions to 1DS

* Switch extensions to 1DS
 2022-07-06 17:18:41 -07:00
Matt Bierner ad9675f099
Scaffold out basic markdown language server (#154293) 
* Scaffold out basic markdown lsp

This scaffolds out a new markdown language server and then uses it to implement document symbols. After the change, the markdown extension will have the following structure:

- languageService — Where all the LSP language stuff will eventually land
- server — The actual language server. Consumes ` languageService`
- src — The current extension that launches the server and implements VS Code specific functions

* Adding build scripts

* a

* Use language service from github

* Remove ls build scripts

* Bump versions

* Only build ext

* Enable for web

* Fixing for browser
 2022-07-06 16:03:24 -07:00
Connor Peet d88ab38f1b npm: remove icon from localization 
For #153743
 2022-07-06 10:57:16 -07:00
Peng Lyu f9f353c90b
support vscode.dev link generation in notebook editor (#154183) 
* support vscode.dev link generation in notebook editor

* Update comments.
 2022-07-06 17:53:12 +02:00
Ladislau Szomoru 6624aea0d0
GitHub - Add translation comment not to translate the $(github) codicon (#154269) 
* Add translation comment not to translate the $(github) codicon

* Add an additional comment
 2022-07-06 08:11:44 -07:00
Martin Aeschlimann ac74e9d093
[html] unresolved import error in embedded JavaScript (#154261) 
[html] unresolved import error in embedded JavaScript #154002
 2022-07-06 15:09:06 +02:00
Johannes Rieken 71c221c532
joh/theoretical quokka (#154157) 
* add `SnippetController#apply(ISnippetEdit[])`

This replaces the initial ugly trick with a more sound implementation of arbitrary snippet edits. A snippet edit can cover disconnected regions, each will be applied as separate text edit but everything will become a single `OneSnippet` instance

* add integration test for SnippetString-text edit inside workspace edit
 2022-07-05 12:30:01 -07:00
Matt Bierner f6271dd82e
Fix angle bracket path completions for link defs (#154182) 
Fixes #153866
 2022-07-05 11:55:20 -07:00
Matt Bierner fc0bd9d377
Remove reliance on document.lineAt (#154191) 
* Remove reliance on document.lineAt

This helps aligning more with the LSP types: https://github.com/microsoft/vscode-languageserver-node/issues/146

* Strip newline
 2022-07-05 11:52:47 -07:00
Alex Ross 7b69a3c4e1
Update grammars (#154099) 2022-07-05 09:53:51 +02:00
Ladislau Szomoru 57609a19da
Git - Update commit button icon and tooltip based on branch protection (#154101) 
Update commit button icon and tooltip based on branch protection
 2022-07-04 20:18:16 +02:00
Henning Dieterichs 451ae1ffa3
Merge branch 'main' into feature/support-angle-bracket-matching-in-typescript 2022-07-04 17:17:14 +02:00
Ladislau Szomoru 32406a7157
Debt - Prevent icon translations (#154094) 
Prevent icon translations
 2022-07-04 14:37:52 +00:00
Henning Dieterichs 8c72572c79
Merge pull request #153917 from microsoft/joh/issue153288 2022-07-04 10:57:29 +02:00
João Moreno 2fcd34a41b
Fixes #148568 (#154008) 
fixes #148568
 2022-07-04 07:41:54 +02:00
Raymond Zhao 623cde6b38
Disable inline completions by default for Emmet (#153926) 
Ref #139247
 2022-07-01 16:20:19 +00:00
Johannes fb97ffc160
be tolerant to other events happing but still enforce that the expected events are there 
fixes https://github.com/microsoft/vscode/issues/153288
 2022-07-01 15:39:51 +02:00
Alex Ross 48fef0c1da
Share link from File Menu shouldn't include active file (#153911) 
Fixes #153537
 2022-07-01 15:04:12 +02:00
Ladislau Szomoru 53c752ac8a
Git - Disable commit button while merge is in progress (#153890) 
Disable commit button while merge is in progress
 2022-07-01 02:56:29 -07:00
Matt Bierner 0b3574dcef
Update id of markdown-it renderer (#153876) 
Fixes #153873
 2022-06-30 23:19:49 +00:00
Matt Bierner e44361365e
Don't include reference links that are inside other links (#153864) 
Fixes #150921
 2022-06-30 15:43:31 -07:00
Matt Bierner bbce24d8bb
Handle fs error in markdown path completions (#153869) 
Fixes #153867
 2022-06-30 22:32:32 +00:00
Ladislau Szomoru b18f9e0630
Git - Do not show Sync Changes and Publish Branch action button when commit is in progress (#153821) 
Do not show Sync Changes and Publish Branch action button when commit is in progress
 2022-06-30 07:27:42 -07:00
Ladislau Szomoru cf532ac7db
Git - Tweak the git.useEditorAsCommitInput setting description (#153794) 
* Tweak the setting description

* Update extensions/git/package.nls.json

Co-authored-by: João Moreno <joao.moreno@microsoft.com>

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
 2022-06-30 06:42:23 -07:00
Ladislau Szomoru 1230b7c300
Git - "Commit & Push" command now publishes the branch if there is no tracking remote (#153749) 
"Commit & Push" command now publishes the branch if there is no tracking remote
 2022-06-30 02:12:31 -07:00
Martin Aeschlimann 257bb1ae83
Update seti for the gitcommit language (#153711) 2022-06-29 21:40:21 +02:00
Ladislau Szomoru 6ca8db83e7
Git - Disable undo last commit command while commit is in progress (#153739) 
Disable undo last commit command while commit is in progress
 2022-06-29 18:45:21 +00:00
Rob Lourens 50e1886048
Fix slow integration test (#153735) 
Fixes #152886
 2022-06-29 18:22:29 +00:00
Ladislau Szomoru 8045df1b94
Git - Add commands to the editor title to accept/discard commit message (#153692) 
Add commands to the editor title to accept/discard commit message
 2022-06-29 14:00:09 +00:00
Johannes Rieken 7aec222831
joh/issue150862 (#153677) 
* execute `workbench.view.scm` to reval SCM view after accepting merge

fixes https://github.com/microsoft/vscode/issues/150862

* only reveal viewlet when stage/accept was done
 2022-06-29 12:20:49 +00:00
Johannes Rieken bd24f72d42
fix 153492 (#153667) 
* enable "accept merge" for merge editor only
* close merge editor before staging file, only stage file when editor has been closed

fixes https://github.com/microsoft/vscode/issues/153492
 2022-06-29 14:08:09 +02:00
Alex Ross 1634eaec83
Share link shows with untitled document (#153671) 
Fixes #153544
 2022-06-29 14:02:34 +02:00
Ladislau Szomoru a424998dfd
Git - Action button precedence (#153662) 2022-06-29 12:48:22 +02:00
Harald Kirschner 56cade24a3
Make the guided git.missing welcome view default (#149668) 2022-06-29 01:14:39 -07:00
Andrew Branch 1d16e313d6
[typescript-language-features] Add setting for autoImportFileExcludePatterns (#153160) 
* Add setting for autoImportFileExcludePatterns

* Add TS 4.8 to message
 2022-06-28 16:43:24 -07:00
Ladislau Szomoru e773c97507
Git - commit action button does not appear on the initial commit (#153605) 
Fix #153507
 2022-06-28 14:07:16 -07:00
Ladislau Szomoru adecb6b529
Git - fix secondary action localization (#153604) 
Fix #153503
 2022-06-28 20:46:03 +00:00
Bryan Lee fac840f22c Add support for angle bracket matching and colorization in Typescript 2022-06-29 01:59:31 +08:00
Ladislau Szomoru 75b3fd5253
Git - Remove icons from branch picker to address regression (#153433) 
* Remove icons from branch picker to address regression

* Fix create branch from issue

* Pull request feedback
 2022-06-28 14:12:08 +02:00
Matt Bierner e13feea6ae
Only compute diagnostics for opened md files (#153395) 
* Only compute diagnostics for opened md files

For #152494

* Make tests stable for result ordering
 2022-06-27 15:55:38 -07:00
Matt Bierner fc709e2d35
Use more standard values for scheme constants (#153367) 
This drops the `:` from the scheme constants as it was easy to misuse this
 2022-06-27 22:35:17 +02:00
Matt Bierner c16036705e
Initial contents for experimentation in typescript-language-features. (#153358) 
Co-authored-by: Daniel Rosenwasser <Daniel.Rosenwasser@microsoft.com>
 2022-06-27 12:53:24 -07:00
Matt Bierner da0f64881a
Dispose in markdown tests (#153345) 
Updates the markdown tests to dispose of disposables created during the test
 2022-06-27 15:52:59 -04:00
Matt Bierner 9051021473
Clarify label on source action (#153356) 
Clairify label on source action

For https://github.com/microsoft/vscode-eslint/issues/1428
 2022-06-27 19:01:41 +00:00
Johannes Rieken 9b1c6cb3ff
joh/issue152834 (#153298) 
* update sample

* dynamically alias `ms-vscode.references-view` onto `vscode.references-view`
 2022-06-27 15:26:49 +02:00
Johannes aae22c1605
rename setting to git.mergeEditor, no more experimental 2022-06-27 12:54:55 +02:00
Alex Ross ffe53e8d71
Add a Share menu and a share vscode.dev command (#152765) 
* Add a share menu
Fixes #146309

* Add vscod.dev command in github extension

* Make share menu proposed

* Add share submenu into editor context

* Add proposed to editor share menu
 2022-06-27 09:56:36 +02:00
Matt Bierner d1b4630a50
Fix Markdown tests on windows (#153212) 
Fix windows tests
 2022-06-25 18:59:25 +02:00
Matt Bierner 3b549009fe
Markdown path completions tests use mocked out fs (#153045) 
* Markdown path completions tests use mocked out fs

This updates the path completion tests to stop depending on the actual fs and instead use `IMdWorkspace`

* Update remaining tests
 2022-06-24 23:01:24 +00:00
Matt Bierner 64305a732e
Better handling of text/uri-list in built-in extensions (#153163) 
- When splitting `text/uri-list`, we should split on `\n` to handle against spec versions of `text/uri-list`
- However when constructing a `text/uri-list`, we should use `\r\n` to align with the spec
 2022-06-24 15:24:16 -07:00
Matt Bierner 7fd834b64f
Enable angle bracket path completions in markdown (#153158) 
Fixes #152510
 2022-06-24 15:04:40 -07:00
Matt Bierner 8acfd0ae60
Exclude empty links from md results (#153161) 
These are technically valid links but we don't care about them since they take up no space
 2022-06-24 21:42:00 +00:00
Matt Bierner 00ad6bc3d4
Markdown document links should reveal cell in notebook (#153147) 
Fixes #141024
 2022-06-24 15:49:15 -04:00
Ladislau Szomoru 45427b2346
Git - Add icons to branch picker (#153149) 
Add icons to branch picker
 2022-06-24 15:46:51 -04:00
Ulugbek Abdullaev af0309e325
add progress reporting for fetching repos (#153082) 
Fixes #151922

Co-authored-by: Ulugbek <ulugbek.abdullaev@jetbrains.com>
 2022-06-24 07:42:01 -07:00
Ladislau Szomoru 367eefd5f1
Git - commit action button (#153031) 2022-06-24 16:07:24 +02:00
Martin Aeschlimann b3cc787d78
[json] use language indicator for folding limit warnings (#153104) 
* reduce number of json notifications

* use language indicator for folding limit warnings. For #142496

* add comment for resultLimit + 1
 2022-06-24 15:01:02 +02:00
Johannes Rieken dfeb3e0050
joh/careful silverfish (#153089) 
* don't show `openChange` command for merge editor

https://github.com/microsoft/vscode/issues/151125

* disable and not-place the conflicting merge-conflict navigation commands for the merge editor

https://github.com/microsoft/vscode/issues/153087

* disable (configurable) merge-conflict featues (code lens, decorations) when git is configured to use merge editor

https://github.com/microsoft/vscode/issues/153087
 2022-06-24 09:33:06 +00:00
Ladislau Szomoru 4a72009c59
Git - Update git.terminalGitEditor default value (#153085) 
Update git.terminalGitEditor default value
 2022-06-24 10:54:24 +02:00
Sandeep Somavarapu c8ee8a25c5
adopt snippets with profile change (#153079) 
* adopt snippets with profile change

* feedback
 2022-06-24 10:10:22 +02:00
Benjamin Pasero 0dfbf42795
tests - skip all flaky webview tests (#153066) (#153067) 2022-06-23 22:51:58 -07:00
Matt Bierner d6497d3db1
Use ResourceMap (#153051) 
Replaces `Set` of uris with a `ResourceMap`
 2022-06-24 01:00:05 +00:00
Matt Bierner 9b7696cc9c
Fix notebook links to other docs in edited markdown cells (#153052) 
Fixes #148199

This makes us resolve links in notebooks relative to the notebook document instead of relaitve to the cell
 2022-06-23 20:55:08 -04:00
Matt Bierner ab7bc9fb0b
Split up MD link tests (#153048) 
This splits the markdown link tests in two:

- Tests for detecting links in md files (`MdLinkComputer`)
- Tests for the actual vs code editor link provider

Also fixes a few cases splitting these tests up caught
 2022-06-23 17:53:56 -07:00
Logan Ramos 4a7a6a597a
Update extension telemetry modules (#153057) 2022-06-24 00:53:23 +00:00
Alex Dima bae316c7ad
Merge remote-tracking branch 'origin/main' into alexd/worrying-bandicoot 2022-06-23 22:45:59 +02:00
Ladislau Szomoru 25cc6c0dd0
Git - Remove git.branchProtectionIndicator setting (#153020) 
Remove git.branchProtectionIndicator setting
 2022-06-23 21:56:54 +02:00
Matt Bierner 385bf5036b
Optimize NoLinkRanges lookup (#153010) 
This switches us to use a map to check if a position exists inside the no link ranges
 2022-06-23 11:38:13 -07:00
Benjamin Pasero a9cacc5d9a
skip flaky webview test (#150682) (#153006) 2022-06-23 17:43:04 +00:00
Daniel Imms 96ca51210f
Merge pull request #152967 from microsoft/tyriar/152966 
Fix initial compilation problem matching in tsc-watch
 2022-06-23 10:31:51 -07:00
Henning Dieterichs a2eccb109e
Merge pull request #152865 from microsoft/3wm 2022-06-23 17:35:24 +02:00
Daniel Imms e733f73119
Merge pull request #152973 from microsoft/tyriar/152780 
Fix terminal selection contrast in solarized light
 2022-06-23 08:28:13 -07:00
Ladislau Szomoru 1513f91ac2
Git - fix regression with creating an empty commit (#152974) 2022-06-23 16:06:06 +02:00
Raymond Zhao 70738ed4f2
Fix Emmet integration test warning, fixes #152827 (#152925) 2022-06-23 06:57:26 -07:00
Daniel Imms fc7ba026bf
Fix terminal selection contrast in solarized light 
Fixes #152780
 2022-06-23 06:05:06 -07:00
Daniel Imms f0cf1ea129
Fix initial compilation problem matching in tsc-watch 
Fixes #152966
 2022-06-23 04:48:25 -07:00
Matt Bierner 07144d22c4
Rename types in the markdown extension (#152905) 
Renames in the markdown extension

This renames some types and splits up some files as part of an exploration towards a proper LSP. Changes:

- `SkinnyTextDocument` -> `ITextDocument`
- Moved `ITextDocument` to own file
- `MdWorkspaceContents` -> `IMdWorkspace`
 2022-06-22 14:12:48 -07:00
Raymond Zhao 5f0a3888b4
Fix command encoding. Fixes #151364 (#152896) 2022-06-22 14:12:32 -07:00
Ladislau Szomoru b9484e8e16
SCM - Action button localization fix (#152903) 
* Localization fix

* Fix typo in key
 2022-06-22 19:27:27 +00:00
Miguel Solorio 901b2a0299
Add listActiveSelectionFocus color token (#152260) 
* Add listActiveSelectionFocus color token (Refs #151577)

* Update colors

* Update color token name to `listFocusAndSelectionOutline` and re-order
 2022-06-22 12:24:49 -07:00
Matt Bierner be1ee5d9f1
Re-validate md files when a linked to file is created or deleted (#152520) 2022-06-22 19:02:46 +00:00
Sandeep Somavarapu a1e1e307e3
introduce application config model (#152889) 
* introduce application config model
- application configuration is active and used only in non default profiles
- read/write application scoped settings only from application layer and not from user layer
- extensions get application scoped values as global values
- settings editor does not show application scoped settings in non default profle
- added unit tests

* fix tests
 2022-06-22 11:57:39 -07:00
Ladislau Szomoru df0fc08407
Git - Fix configuration service warnings (#152867) 
Fix configuration service warnings
 2022-06-22 15:58:57 +02:00
Matt Bierner 321423db2b
Standardize text/uri-list handling (#152756) 
This creates a common set of functions for creating and parsing the `text/uri-list` mime type. As part of this, I also aligned us with the standard, which uses `\r\n` between lines instead of just `\n`
 2022-06-22 13:53:37 +02:00
Ladislau Szomoru 08a46984d6
SCM - Add capability to disable the SCM action button (#152849) 
Add capability to disable the SCM action button
 2022-06-22 13:01:20 +02:00
Henning Dieterichs b673b4274d
Some 3wm cleanup. 2022-06-22 11:49:09 +02:00
Ladislau Szomoru 75362a6268
Git - add settings to control the branch protection indicator (#152469) 
* Add settings to control the branch protection indicator

* Pull request feedback
 2022-06-22 01:02:13 -07:00
Matt Bierner 5437480941
Enable md paste actions by default (#152810) 
Turns on pasting of links for easier testing. However `editor.experimental.pasteActions.enabled` is still off by default so this won't be enabled by default
 2022-06-22 08:19:52 +02:00
Benjamin Pasero 886c112cbd
Merge branch 'main' into alexd/worrying-bandicoot 2022-06-22 06:48:39 +02:00
Rich Chiodo f361c5b71d
Halve the number of executions to speed up test (#152768) 2022-06-22 06:24:21 +02:00
Matt Bierner c84655d123
Reduce recomputation of state in markdown extension (#152804) 
* Reduce recomputation of state in markdown extension

- Use `getForDocument` more often to avoid refetching documents
- Debounce `MdTableOfContentsWatcher`. We don't want this to trigger on every keystroke :)

* Cache LinkDefinitionSet

* Add test file change

* Fix toc watcher for tests
 2022-06-21 16:25:10 -07:00
Matt Bierner 389aa8a935
Fix MdDocumentInfoCache computing values twice (#152799) 
* Fix MdDocumentInfoCache computing values twice

Fixes a race where values could be computed twice before being cached

* Remove only
 2022-06-21 16:22:07 -07:00
Matt Bierner d5a75f2ceb
Add logging for MD language features (#152792) 
This verbose logging will help track down inefficient calling patterns (such as recomputing stuff)
 2022-06-21 14:18:36 -07:00
Matt Bierner bbe7b54cf4
Remove custom editor tests (#152777) 
These tests are not actively being run or maintained. Removing them for now
 2022-06-21 15:37:19 -04:00
Matt Bierner fa53aa6fec
Cleanup pass for md extension (#152760) 
Clean up names in md extension
 2022-06-21 15:36:32 -04:00
Henning Dieterichs 467eef9270
Sets titles to yours and theirs in the git extension & swaps order. Fixes #150853 2022-06-21 17:23:21 +02:00
Alex Dima 617abbf3a1
Merge remote-tracking branch 'origin/main' into alexd/worrying-bandicoot 2022-06-21 14:55:00 +02:00
Henning Dieterichs 50255ca91e
Merge pull request #152691 from microsoft/rzhao271/inline-completion-description 2022-06-21 14:24:40 +02:00
Matt Bierner 2249b171f4
Reduce number of times MD docs are re-tokenized (#152674) 
This change reduces the number of times we retokenize a markdown file by doing the following:

- Use `MdTableOfContentsProvider` in more places
- Introduce a `IMarkdownParser` interface that lets us drop in a caching version of the tokenizer
 2022-06-21 08:43:01 +02:00
Raymond Zhao 9ef049b089
Add note to description 2022-06-20 17:15:07 -07:00
Matt Bierner 369252a027
Skip diagnostics for non-open md files (#152687) 
Currently we only show diagnostics for opened tabs. This means we shouldn't waste time computing diagnostics for these non open files
 2022-06-20 16:39:01 -07:00
Matt Bierner 0bc3109761
Don't try parsing non-markdown files (#152661) 
This fixes our references and rename provider to not try parsing non-markdown files as if they were markdown
 2022-06-20 10:44:50 -07:00
Matt Bierner 4c72dedb4a
Optimize markdown workspace scanning (#152563) 
* Optimize markdown workspace scanning

- Adds cache for markdown file
- Avoid reading non-markdown files from disk (when we expect markdown files)
- Use `range.contains(pos)` instead of `range.intersects(range)`

* Don't remove cached document on change

We only want to invalidate the cached document when it is first opened (since the cached version is the one from disk). Otherwise we can use the live version of the doc
 2022-06-19 09:40:10 -07:00
Matt Bierner 5a175207de
Improve markdown link regexp (#152533) 
* Improve markdown link regexp

This makes the markdown link regexp more readable and also combines the two regular expressions we were running

* Fixed backtracking
 2022-06-19 06:25:54 +02:00
Benjamin Pasero 0203aabaa5
fix integration tests 2022-06-18 07:44:05 +02:00
Matt Bierner 78597fd026
Don't hardcode use of github slugifier (#152507) 
Use `engine.slugifier` for this instead
 2022-06-17 17:25:54 -04:00
Matt Bierner dea813ff7c
Add table of contents provider abstraction (#152504) 
We currently re-compute the same table of contents for markdown files multiple times. This is because multiple language features all need table of contents

With this change, we introduce a new `TableOfContentsProvider` which maintains a cache of the table of contents per file. This provider is then passed into every caller that needs a toc
 2022-06-17 18:20:02 +00:00
Martin Aeschlimann 083cf01e10
json indent pattern: handle escape characters (#152475) 2022-06-17 14:31:03 +00:00
Alex Ross 4e53b01452
Pull in cpp grammar fixes (#152449) 2022-06-17 11:17:09 +00:00
Martin Aeschlimann 630809a1ea
html: observe insertFinalNewline (#152446) 2022-06-17 12:38:36 +02:00
Benjamin Pasero 0662ad271a
tests - skip flake (#152145) (#152442) 2022-06-17 11:56:58 +02:00
Matt Bierner 623f55f437
Refactor markdown language features (#152402) 
(sorry for the size of this PR)

This change cleans up the markdown language features by making the following changes:

- Use `registerXSupport` public functions to register these
- Expose the slugifier the `MarkdownEngine` uses. You never want to use a different one if you already have a markdown engine
- Sort of clean up names. I'd introduced a bunch of confusing names while iterating in this space. What I'm working towards:

    - `Computer` — Stateless thing that computer data
    - `Provider` — Potentially stateful thing that provides data (which may be cached)
    - `VsCodeProvider` — The actual implementation of the various vscode language features (which should only be used by VS Code and in tests, not shared with other features)
- Introduce `MdLinkProvider` to avoid recomputing links for a given document. Also use this to hide more internals of link computation
 2022-06-17 10:25:52 +02:00
Matt Bierner afe316c08c
Add diagnostic manager enablement change tests (#152392) 
* Add test for MD diagnostic manager config changes

Add a simple test the enabling/disable diagnostics should make the diagnostic manager recompute diagnostics

* Add `.get`
 2022-06-16 15:53:19 -07:00
Matt Bierner cb5fa75d11
Clean up markdown diagnostic tests (#152374) 
* Clean up markdown diagnostic tests

This splits the diagnostic compute tests from the test for the diagnostic manager

* Mark internal field as private
 2022-06-16 22:33:11 +02:00
Matt Bierner 3114ee690b
Split out VS Code reference provider from markdown reference provider (#152369) 
This change renames the main markdown reference provider class to `MdReferenceComputer` and then uses this to implement a `vscode.ReferenceProvider`

This more cleanly splits the VS Code part of the logic from the general reference calculation stuff other providers consume
 2022-06-16 15:47:48 -04:00
Matt Bierner 6c252851f2
Revalidate linked files on header change (#152366) 
Fixes #150945

With this change, when the headers in a file change, we should also try to revalidate all files that link to it
 2022-06-16 18:14:01 +00:00
Ladislau Szomoru 88731bf6d6
Git - enable using the editor as the git commit input (#152158) 2022-06-16 16:27:35 +02:00
Ladislau Szomoru 46d9d7acda
Git - branch protection (#152218) 
Co-authored-by: João Moreno <joao.moreno@microsoft.com>
 2022-06-16 16:25:03 +02:00
Matt Bierner 8559324b09
Use more optional chaining in TS extension (#152271) 
Use optional chaining in TS extension

Also removes `prefer-const` since this is now enabled globally
 2022-06-16 05:33:58 +02:00
Matt Bierner 4fc5d76213
Fix ranges and validation setting for MD own path + header links (#152270) 
* Fix ranges and validation setting for MD own path + header links

Previously for a `file.md`, links to headers in that file that use paths, such as `[link](./file.md#some-header)` were validated using `markdown.experimental.validate.fragmentLinks.enabled`

This is confusing as that setting was only meant to be used for links such as`[link](#some-header`). It also resulted in the diagnostic having the incorrect range

This change instead makes these links be validated by `markdown.experimental.validate.fileLinks.markdownFragmentLinks`

* Fix compile
 2022-06-15 20:02:41 -07:00
Matt Bierner a765abcf07
Adopt ResourceMap for MD diagnostics (#152264) 
Adopt ResourceMap

Switches to use `ResourceMap` instead of our own implementation
 2022-06-15 15:43:09 -07:00
Matt Bierner a289e64e09
Switch to finalized TS protocol types (#152259) 2022-06-15 15:37:21 -07:00
Matt Bierner 8fb977f2c1
Make jsx: react the default for implicit js/ts projects (#152256) 
Make jsx: react the default

Fixes #152150

This fixes imports of `react` getting removed with TS 4.7 in implicit projects
 2022-06-15 21:41:52 +00:00
Matt Bierner f17b33faf2
Use .?method() in more places (#152112) 
Switches simple patterns like:

```ts
if (some.thing) {
    some.thing.method();
}
```

to:

```ts
some.thing?.method()
```

This is more concise and avoids having to repeat the `some.thing` part
 2022-06-15 16:28:31 +00:00
Johannes Rieken dfc37187b0
rename ref-viewlet's publisher back to vscode (#152213) 2022-06-15 08:58:11 -07:00
Matt Bierner 354e1a0595
Finalize data file reading API (#152127) 
Fixes #147481
Also reverts #150963 since the `kind` field is not being finalized
 2022-06-15 07:56:02 -07:00
Johannes Rieken 9e21aff42e
joh/ts transpile (#152199) 
transpile-only tasks for client and extensions

* extract transpile into its own file
* add transpile-client task, polish transpiler
* add transpile-extensions, improve transpile logic
* move declaration of "const enum" above it usage so that it can be used with const-enum-inlining
* (ugly) make d.ts transpilation configurable because it is needed for extensions but a problem for client
* hack my way around so that `getOwnEmitOutputFilePath` is reusable by our transpile
* honor `noEmit` flag
 2022-06-15 16:52:48 +02:00
Martin Aeschlimann 6bd36f5295
update seti (#152157) 2022-06-15 16:13:17 +02:00
Ladislau Szomoru 03be93691c
SourceControlInputBox API finalization (#152171) 2022-06-15 15:14:28 +02:00
Benjamin Pasero 68433fb7fd
tests - remote invalid proposed API (#152181) 2022-06-15 14:34:56 +02:00
Priyank Rastogi 9e1f017b8c
Add latex to markdown embedded languages (#151732) 2022-06-15 00:01:37 +00:00
Matt Bierner 00273730e8
Split markdown linkComputer from linkProvider (#152124) 
Instead of passing around a full `vscode.DocumentLinkProvider`, we should pass just the more minimal interface that consumers need
 2022-06-14 15:34:05 -07:00
Ladislau Szomoru c5318659ec
Git - add support for SSH Uri (#152051) 
* Add support for SSH Uri

* Update extensions/git/src/protocolHandler.ts

Co-authored-by: João Moreno <joao.moreno@microsoft.com>

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
 2022-06-14 20:41:54 +02:00
Matt Bierner 00574df08a
Remove extra path field in FileLinksData (#152004) 
Remove extra `path` field

This field is no longer needed after we switched to use `ResourceMap` vs `Map`

Also inlines the `FileLinksData` type def
 2022-06-14 08:01:53 -07:00
Ladislau Szomoru 5bf63b6e37
Git - fix close all diff editors command (#152059) 
Fix #150315
 2022-06-14 13:21:43 +00:00
Alex Ross 037af4beaf
Update fsharp grammar (#152048) 2022-06-14 14:41:04 +02:00
Matt Bierner a658c04b0a
Adjust md external header link diagnostic range (#152001) 
Fixes #151998

Makes errors for invalid headers on file links only cover the fragment range instead of the entire link range
 2022-06-14 09:39:49 +02:00
Martin Aeschlimann c46555d9c8
Tests for configuration editing completion providers (#151953) 
tests for configuration editing completion providers
 2022-06-14 09:08:27 +02:00
Raymond Zhao 76f65c4521
Emmet inline completions (#151559) 
Affects #139247

This PR changes Emmet to use inline completions when suggesting completions.
It also provides a boolean setting so that users can opt out.
This PR does not change the "Wrap with Abbreviation" behaviour in Emmet.

Co-authored-by: Henning Dieterichs <notify.henning.dieterichs@live.de>
 2022-06-14 08:39:28 +02:00
Shi Chen 90e6cb4a40 support more external use in API 
Signed-off-by: Shi Chen <chenshi@microsoft.com>
 2022-06-14 10:03:55 +08:00
Matt Bierner 1a07fd15d7
Clarify markdown validate settings (#151997) 
Clairify markdown validate settings

Fixes #150949

- Rename headerLinks -> fragmentLinks
- Add new `fileLink.markdownFragmentsLinks` to validate the headers on fragment links (inherits the default setting value from `fragmentLinks`)
 2022-06-13 17:06:28 -07:00
Matt Bierner 8b0b3ee72e
Remove notebook editor decoration type (#151574) 
* Remove the notebookEditorDecorationType API proposal

Fixes #146838

* Remove all the infastructure around the now removed notebookEditorDecorationType api
 2022-06-13 13:51:10 -07:00
Matt Bierner 7284c3e4c1
Use classes for drop/paste edit types (#151980) 2022-06-13 13:10:07 -07:00
Johannes Rieken 82f7daa016
Revert "rename references-view publisher to vscode so that NLS works, fixes https://github.com/microsoft/vscode/issues/142168 (#151696)" (#151969) 
This reverts commit 66f8ae48b0.
 2022-06-13 17:47:31 +00:00
Martin Aeschlimann 375681e51e
json: use default word pattern (#151754) 2022-06-13 14:36:42 +02:00
Sandeep Somavarapu 22fe16d3e5
adopt merge editor in settings sync 
- use merge editor for conflicts
- expose base resource in resource syncrhonziers
- add baseResourceScheme context to contribute Accept Merge button per feature
- support old way of handling conflicts behind an internal setting
 2022-06-12 15:49:45 +02:00
Megan Rogge cf94d8370d
use const instead of literal (#151742) 
use const
 2022-06-10 13:56:43 +00:00
Alex Ross bd1abe08c3
Update C grammar locations (#151733) 
Fixes #150288
 2022-06-10 13:55:11 +00:00
Babak K. Shandiz 766743629d
Polish PR template picker (#151415) 
* 🔨 Set ignoreFocusOut to true on PR template selection

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Translate PR template paths to relative in quick pick list

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 💄 Shorten line length

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* ⚗️ Update tests with latest required args

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* ⚗️ Update GitHub extension unit tests

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
 2022-06-10 12:54:37 +00:00
Johannes Rieken 66f8ae48b0
rename references-view publisher to vscode so that NLS works, fixes https://github.com/microsoft/vscode/issues/142168 (#151696) 2022-06-10 09:39:34 +00:00
Johannes ed9ed45794
Merge branch 'main' into joh/voluminous-lobster 2022-06-10 09:07:30 +02:00
Rob Lourens d5e7687940
Fix updating outputs of another cell using a NotebookCellExecution (#151573) 
Fixes #151468
 2022-06-09 20:27:36 -07:00
Megan Rogge 4222eb73aa
allow excluding npm install script from the npm scripts view (#151647) 
fix #149924
 2022-06-09 17:15:43 -07:00
Matt Bierner f7e12a3a92
Use optional method calls in more places (#151634) 
This replaces code like:

```ts
if (foo.bar) {
    foo.bar(cat);
}
```

with:

```ts
foo.bar?.(cat)
```

Which is more concise but has the same meaning
 2022-06-09 15:04:28 -07:00
Babak K. Shandiz a8de8e2112
[markdown] Ignore brackets inside link text (#151610) 
* 🔨 Allow texts in bracket pairs inside link titles; [text](link)

Signed-off-by: GitHub <noreply@github.com>

* 🔨 Allow texts in bracket pairs inside link titles; [text](<link>)

Signed-off-by: GitHub <noreply@github.com>

* ⚗️ Add tests to verify  link titles can include bracket pairs

Signed-off-by: GitHub <noreply@github.com>
 2022-06-09 11:48:50 -07:00
Johannes 43c31079ee
manual fixing of prefer-const violations 2022-06-09 10:19:56 +02:00
Johannes 3622010b64
Merge branch 'main' into joh/voluminous-lobster 2022-06-09 09:08:20 +02:00
Matt Bierner d7c90c2b2b
Update text editor drop proposal (#151552) 
This updates the text editor drop proposal (#142990). This change introduces `DocumentDropEdit` which removes the need for `SnippetTextEdit`. This interface may also be extended in the future with additional metadata
 2022-06-08 17:44:28 -04:00
Matt Bierner 48cfaa2187
Fix rename of paths in markdown reference link definitions (#151545) 
Fixes #151117
 2022-06-08 19:20:17 +00:00
Matt Bierner 370dfd5fee
Iterate on paste edit provider api (#151477) 
* Iterate on paste edit provider api

For #30066

- Pass all selections to paste providers. For #151326
- Introduce `DocumentPasteEdit` as return type. This new type uses an `insertText` that is applied to every paste location (for multicursor), plus an optional additional edit
-  Add `DocumentPasteProviderMetadata`. This lets extensions tell us which types of mimetypes they are interested in, letting us avoid round trips if no extensions care about the pasted data

* Correctly batch insertText
 2022-06-08 15:06:55 -04:00
Andrew Branch 5a32c3ff17
[typescript-language-features] Pass through all typescript.unstable.* settings (#151472) 
Pass through all `typescript.unstable.*` settings
 2022-06-08 11:53:06 -07:00