development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 05:19:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove extra path field in FileLinksData (#152004)

Browse source 
Remove extra `path` field

This field is no longer needed after we switched to use `ResourceMap` vs `Map`

Also inlines the `FileLinksData` type def
This commit is contained in:
Matt Bierner 2022-06-14 08:01:53 -07:00 committed by GitHub
parent 112712fd92
commit 00574df08a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
extensions/markdown-language-features/src/languageFeatures/diagnostics.ts
View file

@ -340,21 +340,17 @@ export class DiagnosticManager extends Disposable {
}
}
interface FileLinksData {
readonly path: vscode.Uri;
readonly links: Array<{
readonly source: MdLinkSource;
readonly fragment: string;
}>;
}
/**
* Map of file paths to markdown links to that file.
*/
class FileLinkMap {
private readonly _filesToLinksMap = new ResourceMap<FileLinksData>();
private readonly _filesToLinksMap = new ResourceMap<{
readonly outgoingLinks: Array<{
readonly source: MdLinkSource;
readonly fragment: string;
}>;
}>();
constructor(links: Iterable<MdLink>) {
for (const link of links) {
@ -365,9 +361,9 @@ class FileLinkMap {
const existingFileEntry = this._filesToLinksMap.get(link.href.path);
const linkData = { source: link.source, fragment: link.href.fragment };
if (existingFileEntry) {
existingFileEntry.links.push(linkData);
existingFileEntry.outgoingLinks.push(linkData);
} else {
this._filesToLinksMap.set(link.href.path, { path: link.href.path, links: [linkData] });
this._filesToLinksMap.set(link.href.path, { outgoingLinks: [linkData] });
}
}
}
@ -376,8 +372,8 @@ class FileLinkMap {
return this._filesToLinksMap.size;
}
public entries(): Iterable<FileLinksData> {
return this._filesToLinksMap.values();
public entries() {
return this._filesToLinksMap.entries();
}
}
@ -469,7 +465,7 @@ export class DiagnosticComputer {
const diagnostics: vscode.Diagnostic[] = [];
await Promise.all(
Array.from(linkSet.entries()).map(({ path, links }) => {
Array.from(linkSet.entries()).map(([path, { outgoingLinks: links }]) => {
return limiter.queue(async () => {
if (token.isCancellationRequested) {
return;