Use classes for drop/paste edit types (#151980)

extensions/markdown-language-features/src/languageFeatures/copyPaste.ts

@@ -21,10 +21,7 @@ export function registerPasteProvider(selector: vscode.DocumentSelector) {
 			}
 
 			const snippet = await tryGetUriListSnippet(document, dataTransfer, token);
-			if (snippet) {
-				return { insertText: snippet };
-			}
-			return undefined;
+			return snippet ? new vscode.DocumentPasteEdit(snippet) : undefined;
 		}
 	}, {
 		pasteMimeTypes: ['text/uri-list']

extensions/markdown-language-features/src/languageFeatures/dropIntoEditor.ts

@@ -32,10 +32,7 @@ export function registerDropIntoEditor(selector: vscode.DocumentSelector) {
 			}
 
 			const snippet = await tryGetUriListSnippet(document, dataTransfer, token);
-			if (snippet) {
-				return { insertText: snippet };
-			}
-			return undefined;
+			return snippet ? new vscode.DocumentDropEdit(snippet) : undefined;
 		}
 	});
 }

src/vs/workbench/api/common/extHost.api.impl.ts

@@ -1298,6 +1298,8 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
 			ViewColumn: extHostTypes.ViewColumn,
 			WorkspaceEdit: extHostTypes.WorkspaceEdit,
 			// proposed api types
+			DocumentDropEdit: extHostTypes.DocumentDropEdit,
+			DocumentPasteEdit: extHostTypes.DocumentPasteEdit,
 			InlayHint: extHostTypes.InlayHint,
 			InlayHintLabelPart: extHostTypes.InlayHintLabelPart,
 			InlayHintKind: extHostTypes.InlayHintKind,

src/vs/workbench/api/common/extHostTypes.ts

@@ -2480,6 +2480,27 @@ export class DataTransfer {
 	}
 }
 
+@es5ClassCompat
+export class DocumentDropEdit {
+	insertText: string | SnippetString;
+
+	additionalEdit?: WorkspaceEdit;
+
+	constructor(insertText: string | SnippetString) {
+		this.insertText = insertText;
+	}
+}
+
+@es5ClassCompat
+export class DocumentPasteEdit {
+	insertText: string | SnippetString;
+
+	additionalEdit?: WorkspaceEdit;
+
+	constructor(insertText: string | SnippetString) {
+		this.insertText = insertText;
+	}
+}
 
 @es5ClassCompat
 export class ThemeIcon {

src/vscode-dts/vscode.proposed.documentPaste.d.ts

@@ -43,7 +43,7 @@ declare module 'vscode' {
 	/**
 	 * An operation applied on paste
 	 */
-	interface DocumentPasteEdit {
+	class DocumentPasteEdit {
 		/**
 		 * The text or snippet to insert at the pasted locations.
 		 */
@@ -53,6 +53,11 @@ declare module 'vscode' {
 		 * An optional additional edit to apply on paste.
 		 */
 		readonly additionalEdit?: WorkspaceEdit;
+
+		/**
+		 * @param insertText The text or snippet to insert at the pasted locations.
+		 */
+		constructor(insertText: string | SnippetString);
 	}
 
 	interface DocumentPasteProviderMetadata {

src/vscode-dts/vscode.proposed.textEditorDrop.d.ts

@@ -30,16 +30,21 @@ declare module 'vscode' {
 	/**
 	 * An edit operation applied on drop.
 	 */
-	export interface DocumentDropEdit {
+	export class DocumentDropEdit {
 		/**
 		 * The text or snippet to insert at the drop location.
 		 */
-		readonly insertText: string | SnippetString;
+		insertText: string | SnippetString;
 
 		/**
 		 * An optional additional edit to apply on drop.
 		 */
-		readonly additionalEdit?: WorkspaceEdit;
+		additionalEdit?: WorkspaceEdit;
+
+		/**
+		 * @param insertText The text or snippet to insert at the drop location.
+		 */
+		constructor(insertText: string | SnippetString);
 	}
 
 	export namespace languages {