development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-18 01:58:27 +00:00
Code Issues Packages Projects Releases Wiki Activity
104438 commits 1080 branches 296 tags 1.3 GiB
Commit graph

278 commits

Author SHA1 Message Date
Benjamin Pasero 6508a29d23
smoke - more verbose logging on windows 2022-04-05 09:17:17 +02:00
Benjamin Pasero 17a7edb8bb
smoke - remove some unused methods from driver 2022-04-05 08:04:40 +02:00
Benjamin Pasero 0390d4f2a4
smoke - try to use locator API for window ready 2022-04-04 15:47:21 +02:00
Benjamin Pasero 44aea76875
💄 2022-04-04 15:47:21 +02:00
Benjamin Pasero 65bfe1ef11
smoke - enable multi root tests in web 2022-04-04 13:47:43 +02:00
Benjamin Pasero 2ada17080c
Use playwright for desktop smoke tests (#146692) 
* Use `playwright` for desktop smoke tests

* fix distro issues

* tests - enable prefs tests for web
 2022-04-04 10:13:08 +02:00
Tyler Leonhardt e3d1bab639
update minimist in smoke tests 2022-03-29 11:53:20 -07:00
Benjamin Pasero 3e5c7e2c57
smoke - disable trust 
cc @sbatten @lszomoru
 2022-03-12 08:23:43 +01:00
Robo 32d40cf44e
chore: update to electron 17 (#143223) 
* chore: bump electron@17.0.0

* Revert "chore: revert to electron@13 (#143851)"

This reverts commit df645f1450.

* chore: bump electron@17.1.0

* Revert "ci: fix build with latest node-gyp"

This reverts commit c3e948aa30.

* chore: revert ci changes for node v16

* chore: update yarn.lock

* chore: bump electron@17.1.1
 2022-03-11 00:51:37 +09:00
Matt Bierner c569182d08
Encode webview parent origin in authority 
Fixes #144703
 2022-03-08 11:28:59 -08:00
Robo df645f1450
chore: revert to electron@13 (#143851) 
* Revert "chore: update to electron 16 (#137241)"

This reverts commit 01df559c18.
This reverts commit 46301339b7

* ci: fix remote compiler for sdl-scan

* chore: fix remote/.yarnrc

* chore: fix build/npm/postinstall.js

* chore: rm crash reporter from shared process

* chore: rm crash reporter from ext host

* chore: fix build/lib/layersChecker.ts

* :chore: preserve some more changes

* fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
 2022-02-24 17:49:49 +01:00
Matt Bierner 31b199da9c
Bump webview commit 2022-02-15 18:36:12 -08:00
Matt Bierner 82fe581566
Bump webview commit 2022-02-14 13:45:05 -08:00
Martin Aeschlimann 22e5d7274a
prepare tests for license terms check 2022-02-09 16:18:37 +01:00
Robo 01df559c18
chore: update to electron 16 (#137241) 
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488dd8f.

* Revert "watcher - enable crash reports on linux (#136264)"

This reverts commit af261488f8.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix #137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs https://github.com/microsoft/vscode/issues/137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs 797723ec83

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs https://github.com/microsoft/vscode/issues/137659

* ci: switch to buster for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs #137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf37c.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73951.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3732.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
 2022-02-08 20:09:00 +01:00
Megan Rogge 921264bfe3
add splitCwd smoke test for linux/mac (NaiveCwdDetection) (#141974) 2022-02-03 19:57:26 -06:00
Johannes Rieken 4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391 2022-02-02 14:35:33 +01:00
Sandeep Somavarapu fb8316c8f4
#141054 check line numbers in settigns file 2022-02-01 09:35:54 +01:00
Alex Dima 81ad1f968d
Do not force that a connection token CLI argument is present 2022-01-24 14:02:41 +01:00
Benjamin Pasero b7cdfce7e5
Smoke test runner fails or hangs without error (fix #141148) 2022-01-22 08:43:21 +01:00
Martin Aeschlimann ef4549b141
Merge branch 'main' into aeschli/noremoteindicatorweb 2022-01-21 17:19:52 +01:00
Alex Dima 715dbb0c16
Refuse launching unless a connection token is provided 2022-01-21 13:25:20 +01:00
Martin Aeschlimann f9cac7c28a
adopt --server-data-dir 2022-01-21 12:11:47 +01:00
Martin Aeschlimann 8047f9c877
no remote indicator for code server web 2022-01-21 10:00:20 +01:00
Benjamin Pasero 295984b33b
tests - adopt new URL syntax when web is connected to a remote 2022-01-20 15:55:18 +01:00
Benjamin Pasero 365fea1d61
fix #141060 2022-01-20 13:59:47 +01:00
Benjamin Pasero 13461f8c61
Web: change yarn web to run with our server instead of playground (#139725) 
* web - first cut `yarn web` via our server

* properly pipe output

* web - remove traces of web playground

* web - remember last opened workspace for convinience

* use vscode-test-web for server less, clean up web commands

* fix comment

* fix `yarn web`

* rename to code-server

* open system browser

* code-server script: use minimist

* test resolver: use ./scripts/code-server

* integartion tests: fix code-server command name

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
 2022-01-20 13:48:08 +01:00
Martin Aeschlimann ad928a4e0f
adopt server script in integration tests 2022-01-19 18:08:04 +01:00
Sandeep Somavarapu 066671a902
Fix #140838 2022-01-18 17:43:20 +01:00
Benjamin Pasero 9be2757019
🆙 playwright@1.18 (#140767) 
* tests - use `@playwright/test@1.18.0-rc1`

* fix bad dependency

* clear more weird ts dependencies
 2022-01-15 09:35:39 +01:00
João Moreno 8c9870d298
Smoke Test: forcefully kill electron if exit doesn't work (#140570) 
* smoke test: forcefully kill electron if exit doesn't work

* use tree-kill

* roll back veto
 2022-01-12 17:02:52 +01:00
Matt Bierner 9f867c3ed8
Revert service worker usage of MessageChannel (#140351) 
* Revert service worker usage of MessageChannel

Reverts 66b6adf035

While I'm not 100% about this, I think 66b6adf035 causes resourses to occasionally not load. I believe this can happen if the service worker is unitilized while the webview remains active. I can't reproduce this myself so it may be related to memory pressure or resource usage, however relying on the service worker not being reinitilized does seem like a potentially bad idea https://stackoverflow.com/questions/34775105/what-causes-the-global-context-of-a-service-worker-to-be-reset

Will investigate if there's another way to achive this since using MessagePort did clean up the code and slightly improve performance

* Bump webview commit versions
 2022-01-10 14:22:49 -08:00
Benjamin Pasero a224ef4fb3
smoke - fix selectTab to select tab? 2022-01-04 09:47:09 +01:00
Benjamin Pasero 18a7108073
smoke - select tab over quick pick (#139944) 
* smoke - further try to reduce usages of quick pick

* poke
 2021-12-30 22:38:59 +01:00
Benjamin Pasero 99fabbdb27
smoke - more logging 2021-12-29 17:46:52 +01:00
Benjamin Pasero bd43c04262
smoke - log electron stdout into log file 2021-12-29 17:35:54 +01:00
Benjamin Pasero 9c0cce1dae
smoke - take screenshot when waiting long for window ready 2021-12-28 15:32:35 +01:00
Benjamin Pasero b2e79a699f
smoke - improve app lifecycle (#139693) 
* smoke - make sure app is closed when `app.start` fails

* smoke - `capturePage` to fallback to active window

* smoke - more logging around remote resolving
 2021-12-23 16:38:54 +01:00
Daniel Imms daf4ba622f
Merge pull request #138516 from microsoft/tyriar/137847 
Try removing timeout in checkWindowReady
 2021-12-22 10:38:41 -08:00
Benjamin Pasero bb39ae82cf
smoke - improve runCommand and disable more tests 2021-12-20 08:25:08 +01:00
Benjamin Pasero 2d77c9e23a
smoke - more robust usage of quick input / access (#139367) 
* smoke - more robust `openQuickAccessAndWait`

* tweaks

* 💄

* trigger

* fix fluke

* poke

* fix terminal weirdness

* poke

* address feedback
 2021-12-17 18:49:17 +01:00
Benjamin Pasero ae8aeb653d
smoke - use absolute paths for opening files (#139322) 2021-12-16 20:14:12 +01:00
Benjamin Pasero fa739870a2
smoke - remove doubleClick usage 2021-12-16 14:27:21 +01:00
Benjamin Pasero fdc4b7101d
smoke - actually retry quick access usage 2021-12-16 14:25:12 +01:00
Daniel Imms da308a9a7f Format 2021-12-15 19:35:16 +00:00
Daniel Imms fa61def811
Merge branch 'main' into tyriar/137847 2021-12-15 09:29:49 -08:00
Rob Lourens b823936907 Wait for window to connect before starting browser smoketests 
Fix #138045
 2021-12-14 20:23:44 -08:00
Matt Bierner 8cf4dcdade
Re-enable notebook smoke tests (#139127) 
Fixes #126371
 2021-12-14 16:50:22 -08:00
Daniel Imms 2eb4cec44b Wait for terminal to be ready before changing color 
Fixes #139081
 2021-12-14 10:14:06 -08:00
Daniel Imms 9d1a7abe35 Some jsdoc 2021-12-13 16:57:14 -08:00
Daniel Imms 50f96a3c6b Clean up terminal creation in smoke tests 2021-12-13 16:54:42 -08:00
Daniel Imms 73a19337ac Merge remote-tracking branch 'origin/main' into tyriar/133524 2021-12-13 16:28:23 -08:00
Daniel Imms 9566e299dd Add auto replies test 2021-12-13 16:20:34 -08:00
Megan Rogge a2f5ec29b2
Revert "Revert "be sure that terminal target gets set for the instance (#138875)"" 
This reverts commit 8605d7aeff.
 2021-12-13 17:08:29 -06:00
Daniel Imms 8605d7aeff Revert "be sure that terminal target gets set for the instance (#138875)" 
This reverts commit 578eb0d4ae.
 2021-12-13 08:15:32 -08:00
Megan Rogge 578eb0d4ae
be sure that terminal target gets set for the instance (#138875) 2021-12-10 14:51:45 -08:00
Daniel Imms 7d35da6eb9 Wait for host on web as well 2021-12-10 11:15:59 -08:00
Daniel Imms da7ab25150 Merge remote-tracking branch 'origin/main' into tyriar/137847 2021-12-10 11:11:49 -08:00
Daniel Imms 866b9df390 Wait for quick input to open again after runCommandWithValue 
Fixes #138658
 2021-12-10 10:59:40 -08:00
Rob Lourens 9893857d4b Handle "clear search results" cancelling running search 
Fix #138841
 2021-12-10 10:51:26 -08:00
Rob Lourens e5637ce9af Fix #138748 2021-12-09 10:00:25 -08:00
Benjamin Pasero 27e38a8e27
smoke - always create screenshot on failure on desktop 2021-12-09 09:51:55 +01:00
Benjamin Pasero 158bd2507e
smoke - always have a logger 2021-12-09 08:48:42 +01:00
Benjamin Pasero 15415b6de6
smoke - align killing 2021-12-09 08:03:48 +01:00
Benjamin Pasero ec3ba7a320
smoke - rewrite killing 2021-12-09 07:55:25 +01:00
Benjamin Pasero acc0803f38
cleanup automation 2021-12-09 07:03:29 +01:00
Rob Lourens 1341ca3d7f Remove timeouts in search smoketest. 
Improvements came from waiting for search to complete before clicking buttons, clearing previous results before starting the search, and adding a retry around the clicking.
 2021-12-08 15:34:35 -08:00
Daniel Imms 465402dd4b Merge remote-tracking branch 'origin/main' into tyriar/137847 2021-12-08 06:28:35 -08:00
Benjamin Pasero 18cba4882d
smoke - more logging 2021-12-08 15:23:27 +01:00
Benjamin Pasero 64562e2a0e
smoke - reimplement logging 2021-12-08 14:13:41 +01:00
Benjamin Pasero fbad065eea
Playwright: record a trace per failing test, not suite (#138600) 
* smoke - record traces per test and not entire suite

* smoke - only persist failing tests

* smoke - cleanup

* smoke - more logging

* smoke - push a test failure to proof the point

* smoke - switch back to chrome for smoke tests

* smoke - warn when exit takes 10s

* Revert "smoke - push a test failure to proof the point"

This reverts commit e572a0c40d.
 2021-12-08 10:09:30 +01:00
Tyler James Leonhardt 224701f74d
try remove timeouts in smoke tests for quickaccess (#138615) 2021-12-07 12:25:35 -08:00
Benjamin Pasero 13c0ed811e
🆙 playwright & set trace names (#138539) 2021-12-06 19:42:05 +01:00
Daniel Imms 110345a97b Try removing timeout in checkWindowReady 
Part of #137847
 2021-12-06 06:35:57 -08:00
Benjamin Pasero ff970e88e5
Revert "smoke - 🆙 retry timeout" 
This reverts commit d60b844aa3.
 2021-12-02 07:38:04 +01:00
Benjamin Pasero 9d427e4df4
smoke test tweaks 
- remove timeout on shutdown
- log exactly where time is spend on shutdown (web)
- stop spawning code when terminated
 2021-12-02 07:34:13 +01:00
Benjamin Pasero d60b844aa3
smoke - 🆙 retry timeout 2021-12-01 11:34:25 +01:00
Megan Rogge 7b3078d931
fix #137795 2021-11-30 12:48:58 -08:00
Megan Rogge 005947e3b8
fix #137722 
fix #137808
 2021-11-30 11:54:28 -08:00
Megan Rogge e89889fe54
fix #137799 2021-11-30 11:21:01 -08:00
Megan Rogge 18725fc147
set default profile to pwsh for only windows for #137225 2021-11-30 10:57:59 -08:00
Megan Rogge 4be98a3bce
set default to pwsh instead of bash for #137725 2021-11-30 10:21:15 -08:00
Daniel Imms d5bfd6d31c Remove unneeded logs in test 2021-11-29 11:48:14 -08:00
Daniel Imms e208c8604e Remove timeout from automation terminal util 
I don't believe this was ever required, awaiting writeInTerminal should make sure the
data event is triggered in xterm, the following enter should just trigger another data
event. This doesn't guarantee it was accepted by the process yet, just that xterm.js
emitted the event.

Part of #137847
 2021-11-29 11:46:57 -08:00
Benjamin Pasero 1af6cb0edc
smoke test tweaks 2021-11-29 17:53:11 +01:00
Benjamin Pasero 18c6692316
tests - print main process pid when killing fails 2021-11-29 13:48:27 +01:00
MalikIdreesHasanKhan 595d893fdc
Fixed typos. (#135729) 2021-11-29 11:32:14 +01:00
Benjamin Pasero e71b28a444
Smoke test lifecycle changes (#137969) 
* rewrite teardown

* 💄

* avoid spam errors

* 💄

* split spawning browser from electron

* await copyExtension

* cleanup

* refactor methods

* cleanup

* cleanup

* cleanup

* 🆙 deps
 2021-11-28 10:30:52 +01:00
Benjamin Pasero df4b5d6d04
smoke - strengthen shutdown path 2021-11-26 18:08:27 +01:00
Benjamin Pasero a11814c57a
smoke - switch away from potentially flaky editors.selectTab method 2021-11-26 09:22:19 +01:00
Benjamin Pasero 6f2239307b
Smoke test tweaks (#137809) 
* smoke - move data migration tests into one and align

* fix app starting

* `createWorkspaceFile` is not async

* 💄

* support screenshot on failure even for stable app

* smoke - try to remove timeout (#137847)

* improve exit call
 2021-11-25 14:37:22 +01:00
Rob Lourens 2932ec095d Add retry to quickaccess tests 
Fix #137733
 2021-11-23 15:35:48 -08:00
Daniel Imms ef440e563d Merge remote-tracking branch 'origin/main' into tyriar/persist_tests 2021-11-23 12:47:36 -08:00
Benjamin Pasero 954ce2c3f4
proper await exit 2021-11-23 10:31:46 +01:00
Megan Rogge 4e303fcc52
fix #137590 2021-11-21 10:04:21 -08:00
Daniel Imms 5dec5256d7 Add some detach/attach tests 2021-11-19 10:33:43 -08:00
Megan Rogge f66bc86da8
add terminal editor and tab smoke tests (#137393) 
* Add a bunch of tests

* tweak tests

* add profile tests, now breaking (no profiles showing up)

* uncomment tests

* update expected

* fix test

* merge

* all passing

* bunch of improvements

* improve readability

* all should be passing and cleaned up

* all passing

* fix #137243 and clean-up

* remove .only

* fix #137247

* get rid of enum

* see if this fixes timing issue

* use keybinding for show terminal instead

* remove delay, implement better accept function

* get rid of unneeded index

* try something else

* wait for empty editor to be active

* remove .only

* decrease redundancy in names

* re-add xterm selector

* try something else

* undo change that broke things worse

* add terminal-tabs test

* all tabs tests passing locally

* kill all

* await before running each

* fix tests

* remove .only

* try waiting for focused xterm

* remove .only

* clean up

* 🧹

* fix profiles tests by using this.app.props

* revert to use default shell

* re-add conditional

* Get tests passing on WebKit

On WebKit the smoke tests were failing because the quick pick was
triggering a focus event on the terminal after the blur event had
already happened, this caused the view service to think the terminal
was still focused when it wasn't. The fix was to reset the context key
also in IViewsService.closeView.

* Safari -> WebKit

* Prefer arrow functions

* remove beforeEach timeout

* add timeouts to contributed profile tests

* add terminal editor tests, fix #137377

* add a bunch of tests

* refactor

* get rid of profile specific command

* more polish

* refactor getTabs -> assertTerminalGroups

* fix failing test

* more polish

* remove .only

* add assertSingleTab

* remove unused import

* fix error

* fix more failures

* more changes

* fix almost all except for plus button

* fix failing plus button test

* all passing

* modify error that gets thrown

* modify error message again

* remove unused wildcard/ ANY_NAME, fix icon code

* fix icon code

* large refactor, improvements

* finish polish

* 1 failing

* get test to pass

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
 2021-11-18 15:11:40 -08:00
Megan Rogge 239a94cee8
remove debug log 2021-11-17 14:01:31 -08:00
Megan Rogge 00fa317c43
Add terminal profile smoke tests (#137079) 2021-11-17 14:00:01 -08:00
Benjamin Pasero 6f28593438
smoke - retry quick open search (fix #136499) 2021-11-15 07:52:12 +01:00