development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-07-17 02:57:19 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

fix #137590

Browse source
This commit is contained in:
Megan Rogge 2021-11-21 10:04:21 -08:00
parent 6729fbbc86
commit 4e303fcc52
No known key found for this signature in database
GPG key ID: 69182D7934F25879
3 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
test/automation/src/playwrightDriver.ts
View file

@ -72,7 +72,7 @@ class PlaywrightDriver implements IDriver {
await timeout(100);
}
if (keybinding.startsWith('Alt') || keybinding.startsWith('Control')) {
if (keybinding.startsWith('Alt') || keybinding.startsWith('Control') || keybinding.startsWith('Backspace')) {
await this._page.keyboard.press(keybinding);
return;
}

9
test/automation/src/terminal.ts
View file

@ -64,10 +64,13 @@ export class Terminal {
}
async runCommandWithValue(commandId: TerminalCommandIdWithValue, value?: string, altKey?: boolean): Promise<void> {
const shouldKeepOpen = !!value || commandId === TerminalCommandIdWithValue.SelectDefaultProfile || commandId === TerminalCommandIdWithValue.NewWithProfile;
const shouldKeepOpen = !!value || commandId === TerminalCommandIdWithValue.SelectDefaultProfile || commandId === TerminalCommandIdWithValue.NewWithProfile || commandId === TerminalCommandIdWithValue.Rename;
await this.quickaccess.runCommand(commandId, shouldKeepOpen);
if (value) {
await this.code.waitForSetValue(QuickInput.QUICK_INPUT_INPUT, value);
} else if (commandId === TerminalCommandIdWithValue.Rename) {
// Reset
await this.code.dispatchKeybinding('Backspace');
}
await this.code.dispatchKeybinding(altKey ? 'Alt+Enter' : 'enter');
await this.quickinput.waitForQuickInputClosed();
@ -108,6 +111,10 @@ export class Terminal {
}
}
async getSingleTabName(): Promise<string> {
return await (await this.code.waitForElement(Selector.SingleTab, singleTab => !!singleTab && singleTab?.textContent.length > 1)).textContent;
}
private async assertTabExpected(selector?: string, listIndex?: number, nameRegex?: RegExp, icon?: string, color?: string): Promise<void> {
if (listIndex) {
if (nameRegex) {

9
test/smoke/src/areas/terminal/terminal-tabs.test.ts
View file

@ -67,6 +67,15 @@ export function setup(opts: ParsedArgs) {
await terminal.assertSingleTab({ name });
});
it('should reset the tab name to the default value when no name is provided', async () => {
await terminal.runCommand(TerminalCommandId.Show);
const defaultName = await terminal.getSingleTabName();
const name = 'my terminal name';
await terminal.runCommandWithValue(TerminalCommandIdWithValue.Rename, name);
await terminal.runCommandWithValue(TerminalCommandIdWithValue.Rename, undefined);
await terminal.assertSingleTab({ name: defaultName });
});
it('should rename the tab in the tabs list', async () => {
await terminal.runCommand(TerminalCommandId.Show);
await terminal.runCommand(TerminalCommandId.Split);