Tyler James Leonhardt
9b3e147d6d
GitHub Enterprise Auth improvements ( #165082 )
...
1. Namespace secrets based on the value of github-enterprise.uri to support "multiple separate GHES instances"
2. If the setting value disappears, continue using last set value. Fixes https://github.com/microsoft/vscode-pull-request-github/issues/3992
3. Mark github-enterprise.uri as requires trust
3. Refactoring like:
* UriHandler is handled in extension.ts and passed down everywhere since we can only have 1 instance of it
* misc style (`private` usage, better `disposable` handling)
2022-10-31 12:18:54 -07:00
Tyler James Leonhardt
0091bcae20
Fixes #164073 ( #164384 )
...
Fixes #164073
2022-10-23 17:47:27 +02:00
Tyler James Leonhardt
6684350a58
Onboard GitHub & Microsoft auth extensions to l10n ( #163662 )
...
* onboard github-auth completely to l10n
* onboard microsoft-authentication entirely on to l10n
2022-10-14 08:41:21 -07:00
Tyler James Leonhardt
2457d9eb46
Plumbing for desktop to pick up strings from language packs ( #163494 )
...
Web will come in the next PR (hence the TODO)
Also this includes the smallest translation change which will be the ultimate test that this is all working.
2022-10-12 17:08:27 -07:00
Tyler James Leonhardt
29e985eca0
rev vscode-nls to version that doesn't ask for vscode-nls-web-data ( #161819 )
...
ref #161297
2022-09-26 11:10:54 -07:00
Daniel Rosenwasser
5cde74b767
Fix accidental case fallthroughs in experimentation services. ( #161339 )
2022-09-20 12:00:32 -07:00
Sandeep Somavarapu
35c7ee9d02
Support log output channels for extensions ( #161249 )
...
* introduce log api in extension context
* separate registering output vs log channel
* Separate extension log channels in show logs command
* add logging error to embedder logger
* show extension log in the extension editor
* configure log level per extension
* change the order of log entries
* introduce logger
* align with output chanel
* revert changes
* fixes
2022-09-19 09:03:41 -07:00
Tyler James Leonhardt
fc1ef74eb0
GHES oauth flow support ( #160679 )
...
* GHES oauth flow support
* update server number
* delete testing line
2022-09-14 11:26:02 -07:00
Tyler James Leonhardt
d8453c0440
Rev built-in versions of vscode-nls to 5.1.0 ( #157530 )
...
* rev version of vscode-nls to 5.1.0
* and yarn lock
2022-08-08 18:43:45 +02:00
Tyler James Leonhardt
13066d79e3
up timeout to 5min ( #156846 )
2022-08-01 17:15:52 -07:00
Logan Ramos
a20329d291
Switch extensions to 1DS ( #154299 )
...
* Move extensions to 1DS
* Switch extensions to 1DS
2022-07-06 17:18:41 -07:00
Logan Ramos
4a7a6a597a
Update extension telemetry modules ( #153057 )
2022-06-24 00:53:23 +00:00
Johannes
0656d21d11
auto-fixed prefer-const violation
2022-06-08 17:49:21 +02:00
Tyler James Leonhardt
15253f1528
add a comment for session.scopes ( #151050 )
2022-06-01 20:02:05 -07:00
Tyler James Leonhardt
0715386207
Return scope array that was given to us so that account icon number goes away ( #151027 )
2022-06-01 14:16:24 -07:00
Logan Ramos
3a8b1fe03e
More telemetry comments ( #150303 )
...
* Add owners to all telemetry events
* More comments
* Add comments to non typescript GDPR annotation
* Another comment
2022-05-24 16:00:55 -07:00
Tyler James Leonhardt
847629239b
add owner and comment to some telemetry events ( #148752 )
2022-05-05 17:30:51 -04:00
Logan Ramos
b16dc5f6ef
Upgrade tas client modules ( #148796 )
...
* Upgrade tas client modules
* Fix root package being wrong version
Co-authored-by: SteVen Batten <6561887+sbatten@users.noreply.github.com>
2022-05-05 13:37:33 -04:00
Joyce Er
9556854c8f
Bump vscode-tas-client for CG ( #148673 )
2022-05-03 17:37:34 -07:00
João Moreno
af684a4906
fixes #148414 ( #148418 )
2022-05-02 07:14:26 -07:00
Tyler Leonhardt
e2ec6f0a54
more accurate naming of pages
2022-04-27 15:40:41 -07:00
Tyler Leonhardt
842a41c8ab
add additional log statement
2022-04-27 15:38:56 -07:00
Tyler Leonhardt
a900709990
better handling of prompting and ensure PAT doesn't show up in supported products
2022-04-25 17:27:26 -07:00
Tyler Leonhardt
ed6d360182
add fallback auth server for github auth and better fallback logic
2022-04-15 15:48:29 -07:00
Tyler Leonhardt
5919378269
don't surface error on gets and remove microsoft secret migration. Fixes #146553
2022-04-14 12:18:33 -07:00
Tyler Leonhardt
46452a2dbf
ensure GitHub Edu telemetry fires only per account not per session
2022-04-11 11:04:53 -07:00
Tyler Leonhardt
62866e4fa5
use URL class in a few places
2022-03-29 16:20:08 -07:00
Tyler Leonhardt
b1fb11e18c
have code-oss use device code flow
2022-03-28 09:05:28 -07:00
Tyler Leonhardt
bee517564c
remove leading / so that local dev would work
2022-03-23 16:03:26 -07:00
Tyler Leonhardt
39c6779828
depend on stable vscode.dev for auth extensions
2022-03-21 09:35:34 -07:00
Tyler James Leonhardt
18df55c4d4
Use vscode.dev for GH auth ( #145424 )
...
* Use vscode.dev for GH auth
* use correct urls and fix URLSearchParams typing
2022-03-18 15:58:44 -07:00
Logan Ramos
9b7268acf9
Update telemetry module
2022-03-18 11:34:33 -04:00
Robo
32d40cf44e
chore: update to electron 17 ( #143223 )
...
* chore: bump electron@17.0.0
* Revert "chore: revert to electron@13 (#143851 )"
This reverts commit df645f1450c3e948aa30
2022-03-11 00:51:37 +09:00
Tyler Leonhardt
c254a23e72
update vscode-tas-client
2022-02-28 16:23:14 -08:00
Robo
df645f1450
chore: revert to electron@13 ( #143851 )
...
* Revert "chore: update to electron 16 (#137241 )"
This reverts commit 01df559c1846301339b7
2022-02-24 17:49:49 +01:00
dependabot[bot]
ad70ffe4e9
Bump follow-redirects in /extensions/github-authentication ( #142891 )
...
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects ) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases )
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8 )
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-21 12:41:24 +01:00
Robo
01df559c18
chore: update to electron 16 ( #137241 )
...
* chore: bump electron@15.3.0
* chore: bump node@16.x
* chore: enable render process reuse
* Revert "watcher - use `type` property for crash reporter location"
This reverts commit bfa488dd8f#136264 )"
This reverts commit af261488f8💄 changes
* align with changes
* adopt more fs.rm
* 💄
* chore: bump @vscode/sqlite3@5.0.4
* fix layers check to account for duplicated types from node.js
* update todo for type casts
* smoke - fix compile issue
* chore: update module cache
* watcher - fix unhandled rejection (fix #137416 )
* ci: update node version
* enable stack dumping
* update electron types to 16.x
* chore: bump @vscode/sqlite3@5.0.5
Refs https://github.com/microsoft/vscode/issues/137496
* fix layer issue
* add `AbortSignal` to core types
* chore: update linux compile flags
Refs 797723ec83https://github.com/microsoft/vscode/issues/137659
* ci: switch to buster for linux arm
Refs https://github.com/microsoft/vscode/issues/137927
* ci: fix build on linux arm64
* ci: fix arm client compiler toolchain
Refs #137927
* chore: bump electron@16.0.3
* ci: fix compile flags for the c toolchain
* chore: bump electron@16.0.4
* Add experimental dark mode flag (#139109 )
* Add experimental dark mode flag
* Apply PR feedback
* chore: bump electron@16.0.6
* chore: bump electron@16.0.7
Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300
* chore: experimental highlight API
* smoke - fix compile issue
* FIXME: custom ELECTRON_RUN_AS_NODE with node worker
* Revert "chore: bump electron@16.0.7"
This reverts commit 5fd01cf37ca7f1b73951https://github.com/microsoft/vscode/issues/137927
* ci: force build
* chore: update yarn.lock
* address feedback
* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"
This reverts commit 7b48fa3732🆙 `versionSpec`
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00
Johannes Rieken
4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391
2022-02-02 14:35:33 +01:00
Tyler Leonhardt
c68d433ac8
copy & continue. Fixes microsoft/vscode-internalbacklog#2613
2022-01-27 16:55:27 -08:00
dependabot[bot]
e137d37e79
Bump node-fetch from 2.6.1 to 2.6.7 in /extensions/github-authentication ( #141537 )
...
Bumps [node-fetch](https://github.com/node-fetch/node-fetch ) from 2.6.1 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases )
- [Commits](https://github.com/node-fetch/node-fetch/compare/v2.6.1...v2.6.7 )
---
updated-dependencies:
- dependency-name: node-fetch
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-26 10:16:05 -08:00
Logan Ramos
c047af40b2
Fix compilation
2022-01-19 16:18:14 -05:00
Logan Ramos
b22ee20028
Move to @vscode/extension-telemetry
2022-01-19 15:57:17 -05:00
dependabot[bot]
43822f57e0
Bump follow-redirects in /extensions/github-authentication ( #140797 )
...
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects ) from 1.14.5 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases )
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.5...v1.14.7 )
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-17 10:57:41 -08:00
svennergr
22e45e9f88
Add proper error message on getUserInfo ( #140277 )
...
* Add proper error message on getUserInfo
* improved error message on getUserInfo
either display the response message or the http status text
Co-authored-by: Sven Grossmann <mail@grossmann.dev>
2022-01-10 11:35:20 -08:00
Logan Ramos
932ab8e485
Update vscode extension telemetry modules
2021-12-28 11:06:48 -05:00
Tyler Leonhardt
e8a26d3ebf
ensure we treat scopes sorted and we only return a single session since GH only supports a single log in
2021-12-20 17:12:53 -05:00
Tyler James Leonhardt
f67a8b753f
Use device flow over PAT when we are running in a server full environment but not in a supported uri ( #139255 )
...
* initial attempt
* use github-authentication instead
* rework error handling
* update copy
* explain why Workspace
2021-12-15 22:07:49 -05:00
Tyler Leonhardt
a3e60d2dff
Add messages for rejected promises
2021-12-07 16:23:04 -08:00
Johannes Rieken
09c9d4c293
use enabledApiProposals instead of wildcard property, also update compilation units to only include d.ts-files that are needed, https://github.com/microsoft/vscode/issues/131165
2021-11-12 11:05:57 +01:00
Johannes Rieken
a4d426a1c2
split vscode.proposed.d.ts into a file per proposal, https://github.com/microsoft/vscode/issues/131165
2021-11-12 09:48:17 +01:00
