Tyler James Leonhardt
57f26d2907
Fixes #173380 ( #173428 )
...
Fixes #173380
2023-02-04 15:57:24 +01:00
Tyler James Leonhardt
06eb374137
Improve GHES flow ( #172959 )
...
* Improve GHES flow
It's clear to me now that a lot of users of the GHES flow have auth behind a VPN. Something that we cannot support in the OAuth flow because we require making a request to vscode.dev who makes a request to the GHES instance.
In light of this, we will remove the OAuth flow for GHES. Fear not, though... because both the Device Code Flow and the PAT flow are there and the PAT flow has been improved in 1.75... so in conclusion, I think GHES is handled as best we can with this PR.
Additionally, there is some "Hosted GitHub Enterprise" scenarios popping up, and this future proofs that by allowing "Hosted GitHub Enterprise" experiences to go through the OAuth flow because we know for a fact that they will be accessible from vscode.dev.
Fixes #169619
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/3398
* Use api. sub domain and update telemetry logic
2023-01-31 13:25:12 -08:00
Logan Ramos
8cea434dec
Remove unused proposals ( #172035 )
2023-01-23 19:09:07 +01:00
Tyler James Leonhardt
656e526b3e
Add EMU to session telemetry ( #171186 )
...
* Telemetry for EMU
* comment
2023-01-12 18:51:18 +01:00
Logan Ramos
4acf2d9b46
Update the telemetry modules ( #170512 )
...
Update the module
2023-01-03 15:10:45 -05:00
Tyler James Leonhardt
a790196c19
Improve PAT auth flow ( #170239 )
...
This improves the PAT auth flow by showing a modal to open github.com with the scopes already pre-filled.
This should allow for less room for error during the PAT auth.
Additionally, this allows PAT auth flow to be used as a fallback for GH Enterprise flows.
2022-12-29 20:28:57 +01:00
Logan Ramos
b1076b41f3
Bump telemetry packages ( #169283 )
2022-12-15 17:29:10 +01:00
Tyler James Leonhardt
342a1f4f52
Don't run the local server option if we are running in remote ( #169076 )
...
Additionally improve the conditional for device code flow.
ref #168338
2022-12-13 17:18:25 -08:00
Joyce Er
3bdea7784d
authentication
implicit activation events (#166715 )
...
* `authentication` implicit activation events
* More safety accessing `.id`
2022-11-19 08:30:48 -08:00
Logan Ramos
73d882bcf7
Update telemetry package ( #166292 )
2022-11-14 09:30:33 -08:00
Tyler James Leonhardt
b9b93f2b45
Depend on platform implementations for common features ( #165950 )
...
* don't depend on externals
* remove unneeded externals
2022-11-09 14:29:21 -08:00
Sandeep Somavarapu
2cd8ea24f2
#159892 Finalize ( #165925 )
2022-11-09 10:28:27 -05:00
Logan Ramos
bf1697d98c
Consume proposed telemetry API ( #165862 )
...
* Consume proposed telemetry API
* Update webpack
2022-11-08 21:58:28 -05:00
Tyler James Leonhardt
9b3e147d6d
GitHub Enterprise Auth improvements ( #165082 )
...
1. Namespace secrets based on the value of github-enterprise.uri to support "multiple separate GHES instances"
2. If the setting value disappears, continue using last set value. Fixes https://github.com/microsoft/vscode-pull-request-github/issues/3992
3. Mark github-enterprise.uri as requires trust
3. Refactoring like:
* UriHandler is handled in extension.ts and passed down everywhere since we can only have 1 instance of it
* misc style (`private` usage, better `disposable` handling)
2022-10-31 12:18:54 -07:00
Tyler James Leonhardt
0091bcae20
Fixes #164073 ( #164384 )
...
Fixes #164073
2022-10-23 17:47:27 +02:00
Tyler James Leonhardt
6684350a58
Onboard GitHub & Microsoft auth extensions to l10n ( #163662 )
...
* onboard github-auth completely to l10n
* onboard microsoft-authentication entirely on to l10n
2022-10-14 08:41:21 -07:00
Tyler James Leonhardt
2457d9eb46
Plumbing for desktop to pick up strings from language packs ( #163494 )
...
Web will come in the next PR (hence the TODO)
Also this includes the smallest translation change which will be the ultimate test that this is all working.
2022-10-12 17:08:27 -07:00
Tyler James Leonhardt
29e985eca0
rev vscode-nls to version that doesn't ask for vscode-nls-web-data ( #161819 )
...
ref #161297
2022-09-26 11:10:54 -07:00
Daniel Rosenwasser
5cde74b767
Fix accidental case fallthroughs in experimentation services. ( #161339 )
2022-09-20 12:00:32 -07:00
Sandeep Somavarapu
35c7ee9d02
Support log output channels for extensions ( #161249 )
...
* introduce log api in extension context
* separate registering output vs log channel
* Separate extension log channels in show logs command
* add logging error to embedder logger
* show extension log in the extension editor
* configure log level per extension
* change the order of log entries
* introduce logger
* align with output chanel
* revert changes
* fixes
2022-09-19 09:03:41 -07:00
Tyler James Leonhardt
fc1ef74eb0
GHES oauth flow support ( #160679 )
...
* GHES oauth flow support
* update server number
* delete testing line
2022-09-14 11:26:02 -07:00
Tyler James Leonhardt
d8453c0440
Rev built-in versions of vscode-nls to 5.1.0 ( #157530 )
...
* rev version of vscode-nls to 5.1.0
* and yarn lock
2022-08-08 18:43:45 +02:00
Tyler James Leonhardt
13066d79e3
up timeout to 5min ( #156846 )
2022-08-01 17:15:52 -07:00
Logan Ramos
a20329d291
Switch extensions to 1DS ( #154299 )
...
* Move extensions to 1DS
* Switch extensions to 1DS
2022-07-06 17:18:41 -07:00
Logan Ramos
4a7a6a597a
Update extension telemetry modules ( #153057 )
2022-06-24 00:53:23 +00:00
Johannes
0656d21d11
auto-fixed prefer-const violation
2022-06-08 17:49:21 +02:00
Tyler James Leonhardt
15253f1528
add a comment for session.scopes ( #151050 )
2022-06-01 20:02:05 -07:00
Tyler James Leonhardt
0715386207
Return scope array that was given to us so that account icon number goes away ( #151027 )
2022-06-01 14:16:24 -07:00
Logan Ramos
3a8b1fe03e
More telemetry comments ( #150303 )
...
* Add owners to all telemetry events
* More comments
* Add comments to non typescript GDPR annotation
* Another comment
2022-05-24 16:00:55 -07:00
Tyler James Leonhardt
847629239b
add owner and comment to some telemetry events ( #148752 )
2022-05-05 17:30:51 -04:00
Logan Ramos
b16dc5f6ef
Upgrade tas client modules ( #148796 )
...
* Upgrade tas client modules
* Fix root package being wrong version
Co-authored-by: SteVen Batten <6561887+sbatten@users.noreply.github.com>
2022-05-05 13:37:33 -04:00
Joyce Er
9556854c8f
Bump vscode-tas-client for CG ( #148673 )
2022-05-03 17:37:34 -07:00
João Moreno
af684a4906
fixes #148414 ( #148418 )
2022-05-02 07:14:26 -07:00
Tyler Leonhardt
e2ec6f0a54
more accurate naming of pages
2022-04-27 15:40:41 -07:00
Tyler Leonhardt
842a41c8ab
add additional log statement
2022-04-27 15:38:56 -07:00
Tyler Leonhardt
a900709990
better handling of prompting and ensure PAT doesn't show up in supported products
2022-04-25 17:27:26 -07:00
Tyler Leonhardt
ed6d360182
add fallback auth server for github auth and better fallback logic
2022-04-15 15:48:29 -07:00
Tyler Leonhardt
5919378269
don't surface error on gets and remove microsoft secret migration. Fixes #146553
2022-04-14 12:18:33 -07:00
Tyler Leonhardt
46452a2dbf
ensure GitHub Edu telemetry fires only per account not per session
2022-04-11 11:04:53 -07:00
Tyler Leonhardt
62866e4fa5
use URL class in a few places
2022-03-29 16:20:08 -07:00
Tyler Leonhardt
b1fb11e18c
have code-oss use device code flow
2022-03-28 09:05:28 -07:00
Tyler Leonhardt
bee517564c
remove leading / so that local dev would work
2022-03-23 16:03:26 -07:00
Tyler Leonhardt
39c6779828
depend on stable vscode.dev for auth extensions
2022-03-21 09:35:34 -07:00
Tyler James Leonhardt
18df55c4d4
Use vscode.dev for GH auth ( #145424 )
...
* Use vscode.dev for GH auth
* use correct urls and fix URLSearchParams typing
2022-03-18 15:58:44 -07:00
Logan Ramos
9b7268acf9
Update telemetry module
2022-03-18 11:34:33 -04:00
Robo
32d40cf44e
chore: update to electron 17 ( #143223 )
...
* chore: bump electron@17.0.0
* Revert "chore: revert to electron@13 (#143851 )"
This reverts commit df645f1450
.
* chore: bump electron@17.1.0
* Revert "ci: fix build with latest node-gyp"
This reverts commit c3e948aa30
.
* chore: revert ci changes for node v16
* chore: update yarn.lock
* chore: bump electron@17.1.1
2022-03-11 00:51:37 +09:00
Tyler Leonhardt
c254a23e72
update vscode-tas-client
2022-02-28 16:23:14 -08:00
Robo
df645f1450
chore: revert to electron@13 ( #143851 )
...
* Revert "chore: update to electron 16 (#137241 )"
This reverts commit 01df559c18
.
This reverts commit 46301339b7
* ci: fix remote compiler for sdl-scan
* chore: fix remote/.yarnrc
* chore: fix build/npm/postinstall.js
* chore: rm crash reporter from shared process
* chore: rm crash reporter from ext host
* chore: fix build/lib/layersChecker.ts
* :chore: preserve some more changes
* fix tests
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-02-24 17:49:49 +01:00
dependabot[bot]
ad70ffe4e9
Bump follow-redirects in /extensions/github-authentication ( #142891 )
...
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects ) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases )
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8 )
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-21 12:41:24 +01:00
Robo
01df559c18
chore: update to electron 16 ( #137241 )
...
* chore: bump electron@15.3.0
* chore: bump node@16.x
* chore: enable render process reuse
* Revert "watcher - use `type` property for crash reporter location"
This reverts commit bfa488dd8f
.
* Revert "watcher - enable crash reports on linux (#136264 )"
This reverts commit af261488f8
.
* chore: enable crashpad on linux
* chore: bump electron@15.3.1
* chore: update api changes
* chore: bump @vscode/sqlite3@5.0.3
* spec: skip non-context aware module unittests
* chore: fix perf hook integration with node environment
* fix: adopt fs api changes
* chore: fix integration tests
* chore: bump electron@15.3.2
* chore: bump electron@16.0.0
* temp(macOS): kill test instances in OSS
* Revert "temp(macOS): kill test instances in OSS"
This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.
* chore: update chromium version for clang downloader
* some 💄 changes
* align with changes
* adopt more fs.rm
* 💄
* chore: bump @vscode/sqlite3@5.0.4
* fix layers check to account for duplicated types from node.js
* update todo for type casts
* smoke - fix compile issue
* chore: update module cache
* watcher - fix unhandled rejection (fix #137416 )
* ci: update node version
* enable stack dumping
* update electron types to 16.x
* chore: bump @vscode/sqlite3@5.0.5
Refs https://github.com/microsoft/vscode/issues/137496
* fix layer issue
* add `AbortSignal` to core types
* chore: update linux compile flags
Refs 797723ec83
* ci: fix linux build
* ci: update github ci cache
* ci: fix remote build in github ci
* ci: better fix for remote build
* chore: bump azure cache
* chore: fix merge conflict
* :chore: update to electron@16.0.2
* chore: bump @vscode/sqlite3@5.0.7
* ci: update to gcc-4.9 for remote
Refs https://github.com/microsoft/vscode/issues/137659
* ci: switch to buster for linux arm
Refs https://github.com/microsoft/vscode/issues/137927
* ci: fix build on linux arm64
* ci: fix arm client compiler toolchain
Refs #137927
* chore: bump electron@16.0.3
* ci: fix compile flags for the c toolchain
* chore: bump electron@16.0.4
* Add experimental dark mode flag (#139109 )
* Add experimental dark mode flag
* Apply PR feedback
* chore: bump electron@16.0.6
* chore: bump electron@16.0.7
Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300
* chore: experimental highlight API
* smoke - fix compile issue
* FIXME: custom ELECTRON_RUN_AS_NODE with node worker
* Revert "chore: bump electron@16.0.7"
This reverts commit 5fd01cf37c
.
* Revert "Revert "chore: bump electron@16.0.7""
This reverts commit a7f1b73951
.
* chore: fix github linux workflow
* chore: address review feedback
* chore: bump electron@16.0.8
* ci: revert to stretch distro for linux arm
Refs https://github.com/microsoft/vscode/issues/137927
* ci: force build
* chore: update yarn.lock
* address feedback
* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"
This reverts commit 7b48fa3732
.
* ci: fix remote folder build
* chore: fix github linux ci
* 🆙 `versionSpec`
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00