Commit graph

43881 commits

Author SHA1 Message Date
Matt Bierner 574e06eb4b Use a single state value to track parameter hint state
The parameter hints model can only be in a single state at a time. Use a single state variable to better track this
2018-12-19 17:21:48 -08:00
Matt Bierner 6422adaffe Remove redundant type annotations for generic emitter properties
Code like:

```
private readonly _onDidEncounterLanguage: Emitter<LanguageId> = new Emitter<LanguageId>();
```

Does not need to repeat the `Emitter<LanguageId>` type annotation
2018-12-19 17:10:39 -08:00
Matt Bierner 60e788cda1 Extract paramterHintsModel to own file 2018-12-19 14:57:37 -08:00
Matt Bierner 5f40bbf67f Use shorthand instead of extra nesting 2018-12-19 14:51:00 -08:00
Matt Bierner ac812433df Remove not null assertions 2018-12-19 14:48:59 -08:00
Matt Bierner dbeaaa6890 Remove commented out code 2018-12-19 14:42:54 -08:00
Matt Bierner 8a58c3e7a6 Try to disable menu keyboard shortcuts on macos when executing command inside of webview
Fixes #64724

Should prevent double dispatch of keyboard events in most cases
2018-12-19 14:20:13 -08:00
Matt Bierner 23508cf1a0 Update markdown dependencies 2018-12-19 13:40:54 -08:00
Matt Bierner aa301e3435 Update js/ts grammar 2018-12-19 13:40:54 -08:00
Alexander 33ed0d8cf8 Enable strict null checking for quickOpenScorer test (#65299)
* Enable strict null checking for quickOpenScorer test

* Changing as any to Exclamation mark
2018-12-19 13:40:34 -08:00
Alexandru Dima 24d357a4ad
Merge pull request #64228 from Microsoft/alex/35225
Detect menu items invoked via keybinding and dispatch keybinding on renderer
2018-12-19 20:35:27 +01:00
Alexander 85dcbf72d2 Enable strict null checking for Notifications test (#65291)
* Enable strict null checking for Notirications test

* Changing as any to Exclamation mark
2018-12-19 11:09:56 -08:00
Prabhanjan S Koushik 55ebf93842 fix-65287 Added webviewManager.refresh() (#65396) 2018-12-19 11:05:57 -08:00
Benjamin Pasero 3e78e05f79 electron 3.0.x - --no-untrusted-code-mitigations does not seem to do anything 2018-12-19 19:24:45 +01:00
Benjamin Pasero 2d0492fd3b labels - lift some event handling up 2018-12-19 19:22:15 +01:00
Benjamin Pasero 51582b9dfe
Merge pull request #65408 from Microsoft/ben/labels
introduce ResourceLabels
2018-12-19 19:08:53 +01:00
Benjamin Pasero 43e502affa labels - 💄 2018-12-19 19:08:28 +01:00
Benjamin Pasero d9bfe033f5 labels - visibility 2018-12-19 18:55:28 +01:00
Johannes Rieken 48e30655e8 lazy - more delayed services 2018-12-19 18:33:00 +01:00
Pine Wu e489f935a2 Ensure no spaces when working on html LS 2018-12-19 09:14:49 -08:00
Pine Wu a04ddffb9d No forcing tabsize on users 2018-12-19 09:10:53 -08:00
Johannes Rieken 9b4ae10715 update ref-viewlet extension 2018-12-19 18:06:39 +01:00
SteVen Batten 15e3946654
only dismiss editor context menu when scrollTop has changed (#65111) 2018-12-19 09:03:05 -08:00
Christof Marti 40ff57e055 Set defaultPort (#65118) 2018-12-19 17:24:29 +01:00
Benjamin Pasero db535e02ea labels - clear() is not needed when the label is set right after 2018-12-19 17:10:32 +01:00
Benjamin Pasero b07f007596 labels - cleanup click handler 2018-12-19 17:06:58 +01:00
Johannes Rieken e537b19c1d 💄 2018-12-19 17:01:43 +01:00
Benjamin Pasero 83af15ccf2 Merge branch 'master' into ben/labels 2018-12-19 17:00:48 +01:00
Sandeep Somavarapu 02464b727d Fix #65274 2018-12-19 16:51:10 +01:00
Johannes Rieken 0163625758 perf - a few more delayed services 2018-12-19 16:37:58 +01:00
Alexandru Dima 7e995286dd
Merge pull request #65072 from TiagoR98/issue24344fix
Feature #24344 implemented
2018-12-19 16:33:48 +01:00
Alex Dima 699101e3ab Use Alt to avoid collision with font zooming & other small tweaks 2018-12-19 16:32:23 +01:00
Joao Moreno 16d736d9f1 fixes #65213 2018-12-19 16:32:20 +01:00
Sandeep Somavarapu 55fa388f23 fix #65272 2018-12-19 16:15:57 +01:00
Alex Dima 986de605e3 Merge remote-tracking branch 'origin/master' into pr/TiagoR98/65072 2018-12-19 16:11:59 +01:00
Johannes Rieken 03a2a1effd tweak proposed api check 2018-12-19 16:05:22 +01:00
Andre Weinand 5fece3f30e do not ignore debggers that lack a label; fixes #61649 2018-12-19 16:03:17 +01:00
Tiago Ribeiro 19994c6a74 Implement fast scrolling (#24344) 2018-12-19 15:59:42 +01:00
Johannes Rieken 321535761a format - extract formatting logic, make it so that we potentially run multiple providers sequentially (off for now) 2018-12-19 15:52:28 +01:00
Benjamin Pasero 98b1ed2ed0 labels - 💄 2018-12-19 15:50:00 +01:00
Benjamin Pasero c87e3e7929 labels - renames 2018-12-19 15:47:30 +01:00
Benjamin Pasero 5d5e7e715a labels - adopt for breadcrumbs 2018-12-19 15:39:30 +01:00
Benjamin Pasero 5bf377230a labels - adopt for explorer 2018-12-19 15:35:03 +01:00
Benjamin Pasero ab168f71b7 labels - adopt in comments panel 2018-12-19 15:29:36 +01:00
Benjamin Pasero f729ca0e7b labels - adopt for SCM viewlet 2018-12-19 15:22:42 +01:00
Benjamin Pasero 129016f0e1 labels - adopt for search view 2018-12-19 15:20:07 +01:00
Benjamin Pasero 5d04ca2ec7 labels - adopt for open editors view 2018-12-19 15:13:22 +01:00
João Moreno 45d4e2182f
Merge pull request #65307 from usernamehw/strict_null_splitview
Enable strict null checking for SplitView test
2018-12-19 15:12:55 +01:00
João Moreno ec796111cd
Merge pull request #65305 from usernamehw/strict_null_grid
Enable strict null checking for GridView test
2018-12-19 15:12:37 +01:00
Benjamin Pasero 33475542d7 labels - adopt for markers panel 2018-12-19 15:09:01 +01:00