development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-19 18:48:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #65307 from usernamehw/strict_null_splitview

Browse source 
Enable strict null checking for SplitView test
This commit is contained in:
João Moreno 2018-12-19 15:12:55 +01:00 committed by GitHub
parent ec796111cd aad2c69479
commit 45d4e2182f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/tsconfig.strictNullChecks.json
View file

@ -110,6 +110,7 @@
"./vs/base/test/browser/ui/grid/util.ts",
"./vs/base/test/browser/ui/list/listView.test.ts",
"./vs/base/test/browser/ui/list/rangeMap.test.ts",
"./vs/base/test/browser/ui/splitview/splitview.test.ts",
"./vs/base/test/browser/ui/scrollbar/scrollableElement.test.ts",
"./vs/base/test/browser/ui/scrollbar/scrollbarState.test.ts",
"./vs/base/test/browser/ui/tree/asyncDataTree.test.ts",

6
src/vs/base/test/browser/ui/splitview/splitview.test.ts
View file

@ -72,13 +72,9 @@ suite('Splitview', () => {
container.style.height = `${200}px`;
});
teardown(() => {
container = null;
});
test('empty splitview has empty DOM', () => {
const splitview = new SplitView(container);
assert.equal(container.firstElementChild.firstElementChild.childElementCount, 0, 'split view should be empty');
assert.equal(container.firstElementChild!.firstElementChild!.childElementCount, 0, 'split view should be empty');
splitview.dispose();
});