Commit graph

49921 commits

Author SHA1 Message Date
Benjamin Pasero 3ae69da3a5 status - incremental updates 2019-06-11 09:59:01 +02:00
Sandeep Somavarapu 0d0e4dfe40 Fix #75109 2019-06-11 09:55:20 +02:00
Benjamin Pasero eabd2c51a4 fix #69334 2019-06-11 09:54:48 +02:00
Benjamin Pasero 85d0ec7171 update distro 2019-06-11 09:43:46 +02:00
SteVen Batten ea2f8036d1
remove simple search service for complete remote implementation (#75224)
* code separation

* search working

* cleanup

* remove commented simple search
2019-06-10 23:44:06 -07:00
Daniel Imms 12a43eafbd Fix region comment 2019-06-10 18:45:02 -07:00
Matt Bierner 856086b818 Use disposableStore in a few test files 2019-06-10 16:25:41 -07:00
Matt Bierner ecad75fdeb Use disposableStore in feedback 2019-06-10 16:20:27 -07:00
Matt Bierner 69f08cbf5c Use DisposableStore 2019-06-10 16:17:21 -07:00
Matt Bierner d32ba26ae2 Use DisposableStore for htmlContentRenderer 2019-06-10 16:15:45 -07:00
Matt Bierner 1f4e2a21fc Add support for loading contributed TS version
Fixes https://github.com/microsoft/vscode/issues/75222
Fixes https://github.com/microsoft/TypeScript/issues/31623
2019-06-10 15:42:35 -07:00
Daniel Imms 18b659dd5e Fix xterm addons in browser services 2019-06-10 15:08:29 -07:00
Miguel Solorio 1b4eaa3a72 Add icon for Find All References 2019-06-10 15:03:54 -07:00
SteVen Batten ddb7b78449 don't show menu bar action in menu on macOS 2019-06-10 14:42:43 -07:00
SteVen Batten 096fdbc08a
Merge pull request #75218 from sbatten/menubarRefactor
Separate Native and Custom Menubar Controls for clearer dependencies
2019-06-10 14:38:47 -07:00
SteVen Batten 2d54b4fc8d refactor menubar to separate native and custom 2019-06-10 14:17:58 -07:00
SteVen Batten ea6f48abd3 commit to branch 2019-06-10 13:51:44 -07:00
Daniel Imms 0a489fdcf7 Introduce browser level terminal services 2019-06-10 12:31:00 -07:00
Daniel Imms 3579abf05c Move electron-browser terminal service into new service 2019-06-10 12:01:05 -07:00
Miguel Solorio c4953cebf6 Update icons in Reference viewlet 2019-06-10 11:58:46 -07:00
Matt Bierner e234ea9eec
Merge pull request #74582 from microsoft/dev/mjbvz/fixes-74579
Fixes #74579 - Enable break word for hovers
2019-06-10 11:38:39 -07:00
Matt Bierner a1c33c6c12 Don't try creating untitled files in a refactoring
Fixes #75132
2019-06-10 11:11:12 -07:00
Daniel Imms 69940c9510 Update typings and fix private API access 2019-06-10 11:00:53 -07:00
Daniel Imms cc2392a8e4 xterm@3.15.0-beta34
Based on 566f594

Includes a lot of refactors
2019-06-10 11:00:53 -07:00
Peng Lyu ca332c345c assert native keybinding in web. 2019-06-10 10:53:10 -07:00
Peng Lyu 63672ffaa7
Merge pull request #74930 from microsoft/rebornix/commentreactions
Comment Reaction API
2019-06-10 10:36:21 -07:00
Miguel Solorio 673295580a Fix #75192 2019-06-10 09:14:56 -07:00
Isidor Nikolic f3ea637528
Merge pull request #75043 from jeanp413/fix-70331
Call revealLastElement within runAtThisOrScheduleAtNextAnimationFrame in repl
2019-06-10 14:30:59 +02:00
jeanp413 002ac09795 Improve the provisional height computation of repl elements. Fixes #70331 2019-06-10 06:42:25 -05:00
SteVen Batten 81d7885dc2 fix main proc launch config for windows 2019-06-07 21:51:50 -07:00
Miguel Solorio c802a84ccd Update open change icon, include it in SCM actions 2019-06-07 18:51:05 -07:00
Miguel Solorio 77b250d4d6 Fix #74978, Update initialize icon 2019-06-07 18:50:47 -07:00
Miguel Solorio a2ce8bed5a Target only SCM icons in the viewlet toolbar 2019-06-07 18:46:48 -07:00
Matt Bierner 714691abd6 Fixing another DisposableStore issue in referencesWidget
Should use clear to reset, not dispose. `readonly` can help catch errors like this
2019-06-07 18:32:06 -07:00
Matt Bierner d27fd54828 Have more inferface / classes that are disposable extend IDisposable
This makes it easier to track which objects are disposable, since we can use findAllReferences on them
2019-06-07 18:26:19 -07:00
Matt Bierner 1e9fae2fba Partial fix for ExtHost CodeLenses registering commands after they have already been disposed of
For #75105

This change ensures that we do not try registering a command while resolving a code lens. However it does not fix the issue where we can end up trying to invoke a command that has already been disposed of
2019-06-07 18:26:19 -07:00
Matt Bierner f16e33cf13 ReferenceWidget should call clear to reset itself when the model changes 2019-06-07 18:26:19 -07:00
Matt Bierner 79aace1b39 Better funciton name 2019-06-07 18:26:19 -07:00
Matt Bierner a074400eef Log stack when registering disposable on already disposed object
This should help track down issues
2019-06-07 18:26:19 -07:00
Matt Bierner 50a85fa123 Working on re-structuring code action logic:
- The oracle should only handle triggering
- The model should manage code action requests
- The controller should handle presenting data from the model
2019-06-07 18:26:19 -07:00
Matt Bierner 729943d8ff 💄 2019-06-07 18:26:19 -07:00
Matt Bierner 9678a18c12 Use delegate instead of event to link QuickFixController to codeActionWidget 2019-06-07 18:26:19 -07:00
Matt Bierner 3a62fd8df9 Rename 2019-06-07 18:26:19 -07:00
SteVen Batten cd424b65a1 nix need for menubarservice in websimpleservices 2019-06-08 00:21:38 +00:00
Miguel Solorio 1d067cac75 Fix #74977, make debug icons a little thicker 2019-06-07 14:20:00 -07:00
Miguel Solorio 916f6bf9e8 Add icon for going to settings UI and keyboard shortcuts 2019-06-07 13:34:53 -07:00
Miguel Solorio c45b2fa5de Make preview icon the same height as the split icon 2019-06-07 13:34:00 -07:00
Miguel Solorio b3ed222a5f Shrink refresh icons 2019-06-07 13:04:53 -07:00
Daniel Imms 4a502054ef Move refreshActiveTab to common 2019-06-07 12:58:57 -07:00
Miguel Solorio b27befb519 Fix #75067, fill lightbulb icons 2019-06-07 12:54:05 -07:00