development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 21:55:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

ReferenceWidget should call clear to reset itself when the model changes

Browse source
This commit is contained in:
Matt Bierner 2019-06-07 18:07:54 -07:00
parent 79aace1b39
commit f16e33cf13
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/vs/editor/contrib/referenceSearch/referencesWidget.ts
View file

@ -194,8 +194,8 @@ export class ReferenceWidget extends PeekViewWidget {
private _model: ReferencesModel | undefined;
private _decorationsManager: DecorationsManager;
private _disposeOnNewModel = new DisposableStore();
private _callOnDispose = new DisposableStore();
private readonly _disposeOnNewModel = new DisposableStore();
private readonly _callOnDispose = new DisposableStore();
private _onDidSelectReference = new Emitter<SelectionEvent>();
private _tree: WorkbenchAsyncDataTree<ReferencesModel | FileReferences, TreeElement, FuzzyScore>;
@ -230,6 +230,7 @@ export class ReferenceWidget extends PeekViewWidget {
dispose(): void {
this.setModel(undefined);
this._callOnDispose.dispose();
this._disposeOnNewModel.dispose();
dispose(this._preview);
dispose(this._previewNotAvailableMessage);
dispose(this._tree);
@ -424,7 +425,7 @@ export class ReferenceWidget extends PeekViewWidget {
public setModel(newModel: ReferencesModel | undefined): Promise<any> {
// clean up
this._disposeOnNewModel = dispose(this._disposeOnNewModel);
this._disposeOnNewModel.clear();
this._model = newModel;
if (this._model) {
return this._onNewModel();