Commit graph

101641 commits

Author SHA1 Message Date
Daniel Imms 0ccdfcab03
Merge pull request #163551 from microsoft/tyriar/console_image
Add commented out debug helper for logging an image to the console
2022-10-13 11:10:18 -07:00
Daniel Imms 5d48408ed6
Merge pull request #163577 from microsoft/tyriar/runWhenIdle_docs
Add docs for runWhenIdle
2022-10-13 11:03:36 -07:00
Tyler James Leonhardt 4502088b10
fix empty check for json (#163576) 2022-10-13 11:01:05 -07:00
Connor Peet a5b8370294
Merge pull request #163574 from microsoft/connor4312/dead-test-code
testing: remove dead filter code
2022-10-13 10:53:06 -07:00
Daniel Imms d1104a8b5e
Add docs for runWhenIdle
Had to explain timeout in #163313.

Part of #163572
2022-10-13 10:48:53 -07:00
Connor Peet 8d82e91fab
testing: remove dead filter code
Refs https://github.com/microsoft/vscode/issues/162304
2022-10-13 10:39:58 -07:00
Henning Dieterichs 404a282465
Fixes #163279 (#163573) 2022-10-13 10:21:14 -07:00
Daniel Imms 4dec035c7a
Merge pull request #163220 from babakks/fix-unawaited-workspace-picker
🐛 Fix un-awaited call to show CWD picker
2022-10-13 10:11:16 -07:00
Tyler James Leonhardt 77d14a4711
use size to check if any files were added (#163571)
use size
2022-10-13 09:54:57 -07:00
Sandeep Somavarapu 2b50ab06b1
support passing extension log level from cli (#163566) 2022-10-13 18:21:47 +02:00
João Moreno af4b19dd24
make eager service registration explicit (#163558)
Related-to: #159178
2022-10-13 07:57:36 -07:00
Henning Dieterichs 1436dd71bd
Implements #160292: diffing against base (#163553) 2022-10-13 16:42:45 +02:00
Henning Dieterichs bf85140dfd
Fixes #162173 (#163548) 2022-10-13 15:36:42 +02:00
Martin Aeschlimann 73e5ad2edf
avoid using string and boolean as variable name (#163550) 2022-10-13 09:35:59 -04:00
Daniel Imms f9415ab383
Add commented out debug helper for logging an image to the console 2022-10-13 06:31:06 -07:00
Johannes Rieken 0dd2dc89d2
hook up unhandled extension errors with extension telemetry (#163424)
* hook up unhandled extension errors with extension telemetry

* fix layering

* forward unhandled language provider errors to extension telemetry loggers
2022-10-13 09:04:08 -04:00
Martin Aeschlimann 17c7a08962
Add cli & command to run the code server on the desktop (#163546)
Add cli & command to run the code server on the desktop
2022-10-13 15:02:42 +02:00
Sandeep Somavarapu 1e9295c908
Fix #163313 (#163542) 2022-10-13 14:56:33 +02:00
Sandeep Somavarapu 894aa9a7a7
Log improvements (#163532)
* - expose log level in the proposed api
- ability to set log level per logger

* fix tests
2022-10-13 03:48:52 -07:00
Henning Dieterichs a78f7af399
Adresses #159178 (#163535) 2022-10-13 12:19:27 +02:00
Don Jayamanne 6527023564
Additional test for handling stream outputs in notebooks (#163502)
* Additional test for nb stream output handling

* test
2022-10-13 18:02:35 +11:00
Connor Peet aea0fb3f03
Merge pull request #163521 from microsoft/cli-lint-fixes
cli: apply lint fixes
2022-10-12 23:14:08 -07:00
Connor Peet 8991187c38
cli: apply lint fixes 2022-10-12 22:39:57 -07:00
Tyler James Leonhardt a8108049ab
Allow extensions to use new API and it get included in Language Packs (#163493)
* Allow extensions to use new API and it get included in Language Packs

This leverages the l10n-dev package to analyze ts files for `l10n.t` calls.

* delete console.logs
2022-10-12 17:28:34 -07:00
Connor Peet 8a942246fb
Merge pull request #163496 from microsoft/fix-cli-tests
ci: fix wrong file in cli tests
2022-10-12 17:25:50 -07:00
Matt Bierner db9f5f9b9b
Fix electron webviews not always updating _webviewKeyboardHandler when focus changes (#163495)
I believe any focus changes should also update the `_webviewKeyboardHandler`. Right now programatic focuses don't
2022-10-12 17:12:14 -07:00
Tyler James Leonhardt 2457d9eb46
Plumbing for desktop to pick up strings from language packs (#163494)
Web will come in the next PR (hence the TODO)

Also this includes the smallest translation change which will be the ultimate test that this is all working.
2022-10-12 17:08:27 -07:00
Connor Peet a5e9b83d65
ci: fix wrong file in cli tests 2022-10-12 17:05:41 -07:00
Matt Bierner 5b7233c5e3
Use for-of loop instead (#163491) 2022-10-12 17:01:38 -07:00
Matt Bierner 24a2b8af8c
Re-apply: Clean up how the notebook renderer entrypoint is passed around (#163486)
Revert "Revert "Clean up how the notebook renderer entrypoint is passed around (#163373)""

This reverts commit a3d8c33761.

Fixes #163415
2022-10-12 16:49:40 -07:00
Matt Bierner 7cfb34dff4
Freeze the notebook kernel context (#163488)
This is an API object so it should not be extensible
2022-10-12 16:47:22 -07:00
Jake Bailey 07b87405e7
Don't depend on typescript protocol.d.ts (#163365) 2022-10-12 16:03:07 -07:00
Megan Rogge 6f7820c454
add accessibility setting tag (#163358) 2022-10-12 15:38:57 -07:00
Matt Bierner f5ced8231b
Small clean up for terminal tab list rendering lifecycle (#163485)
Small clean up for terminal tab list lifecycle

- Reuse the same `DisposableStore` across calls to `renderElement`
- Make sure we call `dispose` on the actionbar instead of `clear`. This looks like an oversight
2022-10-12 15:38:29 -07:00
Matt Bierner b5542cae84
Document more of lifecycle.ts (#163482) 2022-10-12 15:23:09 -07:00
Alexandru Dima fd0b0ae532
Merge pull request #163476 from microsoft/alexd/delighted-emu
Clamp the hover result range to make sure the hover stays on the same view line
2022-10-12 23:58:25 +02:00
Megan Rogge 3ddce0580e
add diff editor navigation tip to aria label (#163368) 2022-10-12 14:19:38 -07:00
Tyler James Leonhardt 342aa9c59a
Improvements to i18n (#163372)
* remove dead code from Transifex

* use @vscode/l10n-dev for XLF operations for extensions

* generated files

* more generated files

* remove dead code

* move l10n-dev to where gulp is

* generated
2022-10-12 14:10:57 -07:00
Suven-p 22ff985c19
Add multiple template parameters (#163191) 2022-10-12 14:06:19 -07:00
Matt Bierner d055619b39
Re-use label listener when rendering explorer elements (#163474)
This moves the label render listener to the template instead of being created for each element. To do this, we also need to store some context info on the current template data

This further improves performance as it avoids registering an extra event and adding to the disposable store for each rendered explorer item
2022-10-12 17:05:39 -04:00
Johannes Rieken 2c332cefa2
commit characters must check suggest model state before proceeding (#163467)
fixes https://github.com/microsoft/vscode/issues/163431
2022-10-12 23:05:11 +02:00
Rob Lourens c1ac9ecbb5
Initialize context keys a bit later to avoid triggering recursive instantiation (#163445)
Fix #163314
2022-10-12 13:37:23 -07:00
Alex Dima 3c9854fe86
Fixes #95328: Clamp the hover result range to make sure the hover stays on the same view line 2022-10-12 22:35:13 +02:00
Matt Bierner a2aeb3110a
Use toggle instead of dynamic call to class list add/remove (#163464) 2022-10-12 11:06:27 -07:00
Matt Bierner b2d129c4e5
Fix ipv6 support for simple browser (#163374)
Fixes #158599

This correctly handles ipv6 uris, such as `http://[::]:3000`. In these cases, the brackets are required
2022-10-12 11:04:56 -07:00
Matt Bierner c56e49670e
Reduce event listeners created when rendering explorer items (#163394)
Reduce event listeners created when rendering explorer

Every time an explorer item is rendered, we currently hook up a `themeService.onDidFileIconThemeChange` listener for it. This ends up creating a lot of extra event listeners even though this even it pretty rarely fired

Instead, this PR switches us to have a single listener the re-renders the entire tree. Since this should not be a common event, I believe this is reasonable. Profiling also shows that this cuts both the rendering time and amount of garbage generated
2022-10-12 10:19:43 -07:00
Rob Lourens 749f480915
Fix "Add Configuration" launch.json button on Windows (#163444)
Fix #163266
2022-10-12 09:37:24 -07:00
Matt Bierner 61532aeb56
Re-use DisposableStores when rendering explorer items (#163380)
While trying to debug an performance issue with scrolling the explorer, I noticed that the explorer list renderer creates a new `DisposableStore` every time it renders an item

For performance, it's better to create a DisposableStore for each template and then re-use this when rendering elements. This store is cleared in the `disposeElement` function
2022-10-12 09:02:57 -07:00
Matt Bierner f26411046b
Don't create extra disposable stores when rendering settings tree elements (#163407)
Re-use disposable stores when rendering settings tree
2022-10-12 09:02:22 -07:00
Connor Peet 6353f80f3d
Merge pull request #161640 from microsoft/build-integrated-cli
Update build process to include integrated CLI
2022-10-12 08:59:37 -07:00