development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-18 01:58:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

avoid using string and boolean as variable name (#163550)

Browse source
This commit is contained in:
Martin Aeschlimann 2022-10-13 15:35:59 +02:00 committed by GitHub
parent 0dd2dc89d2
commit 73e5ad2edf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/vs/platform/environment/node/argv.ts
View file

@ -209,8 +209,8 @@ export function parseArgs<T>(args: string[], options: OptionDescriptions<T>, err
const firstArg = args.find(a => a.length > 0 && a[0] !== '-');
const alias: { [key: string]: string } = {};
const string: string[] = ['_'];
const boolean: string[] = [];
const stringOptions: string[] = ['_'];
const booleanOptions: string[] = [];
const globalOptions: OptionDescriptions<any> = {};
let command: Subcommand<any> | undefined = undefined;
for (const optionId in options) {
@ -225,14 +225,14 @@ export function parseArgs<T>(args: string[], options: OptionDescriptions<T>, err
}
if (o.type === 'string' || o.type === 'string[]') {
string.push(optionId);
stringOptions.push(optionId);
if (o.deprecates) {
string.push(...o.deprecates);
stringOptions.push(...o.deprecates);
}
} else if (o.type === 'boolean') {
boolean.push(optionId);
booleanOptions.push(optionId);
if (o.deprecates) {
boolean.push(...o.deprecates);
booleanOptions.push(...o.deprecates);
}
}
if (o.global) {
@ -255,7 +255,7 @@ export function parseArgs<T>(args: string[], options: OptionDescriptions<T>, err
// remove aliases to avoid confusion
const parsedArgs = minimist(args, { string, boolean, alias });
const parsedArgs = minimist(args, { string: stringOptions, boolean: booleanOptions, alias });
const cleanedArgs: any = {};
const remainingArgs: any = parsedArgs;