development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 13:46:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
104494 commits 1072 branches 296 tags 1.2 GiB
Commit graph

13315 commits

Author SHA1 Message Date
Matt Bierner 3544aabd5a
Fix markdown document deleting (#164829) 
Fixes #164562

My previous fix was incorrect as it checked if the document existed by still consulting our `_documentCache`. When we are deleting/renaming an opened md document, it should pretty much always exist in our cache

The fix is to instead treat `this.documents` and the file system as the source of truth when determining if the doc should be deleted or not
 2022-10-27 21:49:05 +02:00
Matt Bierner 0570a7678d
Use posix path for markdown links (#164822) 
Fixes #164782
 2022-10-27 19:21:03 +02:00
Rob Lourens 98f401e8b9
Fix .ipynb extension name capitalization (#164817) 
Towards microsoft/vscode-jupyter#11773
 2022-10-27 18:05:28 +02:00
Alexandru Dima 0f2285c3e9
Don't ship yarn.lock file with the markdown extension (#164794) 2022-10-27 12:09:38 +02:00
Matt Bierner 1316bf789f
Rework markdown update link glob (#164766) 
* Rework markdown update link glob

Fixes #164587

This changes the `externalFileGlobs` setting to instead be a include array of globs that should trigger link updates. I've split the globs into markdown files and image/video files

This also makes it easier for users to add their own new globs to the list

* Fix scopes
 2022-10-27 01:45:45 +02:00
Matt Bierner d2f8ae6cce
Clean up a few markdown setting descriptions (#164765) 
Clean up wording and make sure we use `Markdown` uppercase
 2022-10-26 16:29:06 -07:00
Matt Bierner d1af68711d
Pick up latest markdown LS (#164763) 
Includes a few more fixes for link update on rename
 2022-10-27 00:39:58 +02:00
Matt Bierner 7060fb81dd
Shorten markdown link button titles (#164764) 
Fixes #164556
 2022-10-27 00:39:30 +02:00
Matt Bierner 5f87632829
Fix markdown server not updating documents properly on folder rename (#164752) 
Fixes #164562
 2022-10-26 14:48:20 -07:00
w1redch4d 70328b1b48
fix problems with html style comments in embedded code (#160981) 
* fix problems with html style comments in embedded code

* add spacings to the replaced characters

add same amount of characters, in the replacements so that all offsets stays the same

* revert javascriptMode.ts

* add replace characters in embeddedSupport.ts instead

* added few more tests with javascript

more testcases with js code before and after the comments

* polish

Co-authored-by: UwUeeb <106700035+UwUeeb@users.noreply.github.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
 2022-10-26 08:41:05 +00:00
Matt Bierner a887d72e8d
Pick up latest markdown language service (#164655) 2022-10-25 16:46:53 -07:00
Joyce Er 812c9bedf2
Fix cloning with specific branch (#164619) 2022-10-25 15:27:41 -07:00
Matt Bierner f5cbe7e391
Use dirname as default uri for md links (#164641) 
Fixes #164612
 2022-10-25 21:59:20 +02:00
Matt Bierner 882cdc0a17
Use newlines to separate inserted images (#164632) 
Fixes #164610
 2022-10-25 12:21:36 -07:00
Matt Bierner 21431fce38
Disable canSelectFolders in markdown link inserter (#164636) 
Fixes #164549
 2022-10-25 12:01:08 -07:00
Matt Bierner 3ca4fca56e
Pick up latest markdown language service (#164625) 
This failed yesterday due to a cache issue in dev ops. We need this version for testing
 2022-10-25 10:52:57 -07:00
Matt Bierner 586f252740
Revert "Pick up markdown language service update (#164524)" (#164533) 
This reverts commit ab3926ab48.
 2022-10-24 19:09:08 -07:00
Matt Bierner ab3926ab48
Pick up markdown language service update (#164524) 
Picking up one more small update before endgame
 2022-10-24 16:53:17 -07:00
Matt Bierner 9f5d3eb135
Pick up latest markdown language service and clean up server package (#164516) 
- Picks up newest markdown language service
- Excludes some files from server publish
- Delete unused file
- Update readme
- Align server version with LS version
 2022-10-24 15:58:45 -07:00
Matt Bierner babb2f9677
Remove experimental tag from markdown settings (#164509) 2022-10-24 14:44:43 -07:00
Matt Bierner 4eef476a4f
Remove old notebook editor api proposal (#164504) 
All consumers should now be on the finalized api

Fixes #151661
 2022-10-24 14:40:53 -07:00
Connor Peet beed9ac381
debug: activate auto launch onStartupFinished (#164481) 
For https://github.com/microsoft/vscode-internalbacklog/issues/3209

We still need to activate it for every workspace, but since Daniel's
improvements to environment variable application a few months ago, using
onStartupFinished should be pretty safe and seamless.
 2022-10-24 11:25:22 -07:00
Ladislau Szomoru 7bd27b4287
Git - getSCMResource() should also look at the merge group (#164450) 
getSCMResource() should also look at the merge group
 2022-10-24 06:27:56 -07:00
Ladislau Szomoru 566e71b346
Revert "Git - parse config file for remotes (#164151)" (#164433) 
This reverts commit 798cd3bcac.
 2022-10-24 13:28:06 +02:00
Joyce Er 7318c90996
Checkout specific branch during clone operation (#163705) 2022-10-23 20:23:35 +02:00
Tyler James Leonhardt 0091bcae20
Fixes #164073 (#164384) 
Fixes #164073
 2022-10-23 17:47:27 +02:00
Matt Bierner b11bb04298
Add optional markdown occurrences highlighting (#164292) 
Fixes #164290
 2022-10-21 14:19:50 -07:00
Ladislau Szomoru 798cd3bcac
Git - parse config file for remotes (#164151) 2022-10-21 06:57:22 -07:00
Ladislau Szomoru d1c8746455
Git - Add operation start/end trace log (#164242) 
Add operation start/end trace log
 2022-10-21 14:29:54 +02:00
Matt Bierner 504c5a768a
Avoid extra html write on first markdown preview update (#164201) 2022-10-20 19:40:19 -07:00
Raymond Zhao 72a7d0f2e4
Add to emmet.triggerExpansionOnTab description (#164197) 
Fixes #159111
 2022-10-20 17:38:59 -07:00
Alex Ross cf4c9e469d
Update python grammar (#164191) 2022-10-20 15:45:17 -07:00
Raymond Zhao d9846c8e43
Remove resource scopes (#164158) 2022-10-20 13:51:17 -07:00
Ladislau Szomoru 9c76d66e69
Git - implement cancellation for updating the model (#163926) 
* Initial implementation

* Polish implementation

* Add cancelled label in the output

* Revert change that is not needed

* Pull request feedback

* Dispose listener

* Port changes manually
 2022-10-20 06:26:22 -07:00
Ladislau Szomoru 2fa61a14b8
Git - Extract querying for status so that it can run in parallel with the other operations (#163990) 2022-10-20 04:37:04 -07:00
Ladislau Szomoru 76191c7c75
Engineering - Remove proposal that has been finalized (#164127) 
Remove proposal that has been finalized
 2022-10-20 04:30:27 -07:00
Ladislau Szomoru c139361a3c
Git - catch exceptions while fast-forwarding a branch (#164128) 
Fixes #163685
 2022-10-20 04:30:10 -07:00
Jake Bailey b99cf7e41e
Ensure 'undefined' does not make it into tsserver.web.js (#164064) 2022-10-19 16:44:03 -07:00
Daniel Rosenwasser 182beb6ee4
Merge pull request #163498 from DanielRosenwasser/iconsForWalkthroughs 
Allow walkthroughs to specify icons.
 2022-10-19 11:26:51 -07:00
Matt Bierner 7f99b7c655
Remove references to finalized proposals in js/ts (#164040) 2022-10-19 13:23:48 -04:00
Matt Bierner 33378c2ec0
Fix organize imports (#164035) 
Fixes #163994

This fixes the organize imports command (it was using the wrong id) and also cleans up the implementation
 2022-10-19 09:27:41 -07:00
Andrew Branch 1fb956d2f5
[typescript-language-features] Add removeUnusedImports command (#161654) 
* Add `removeUnusedImports` command

* Continue to send `skipDestructiveCodeActions` for older TS versions

* Expose Sort Imports and Remove Unused Imports commands

* Update localization keys

* Update for 4.9 protocol

* Proto must be type only import?
 2022-10-18 09:00:16 -07:00
Logan Ramos 256aaf296b
Don't use @microsoft.com in source code (#163933) 2022-10-18 07:38:15 -07:00
Ladislau Szomoru d4773517f1
Git - Get HEAD details in parallel (#163756) 2022-10-18 09:42:07 +02:00
Alex Ross 42d99283fd
Use dotnet/razor-tooling repo for razor grammar (#163898) 2022-10-17 16:26:25 -07:00
Matt Bierner bad3dcca69
Fix insert image/link for untitled files (#163897) 2022-10-17 16:14:16 -07:00
Martin Aeschlimann c83eff40dd
Remove too many folding regions notification (#163854) 
* Remove too many folding regions notification

* remove duplicate folding limit item for JSON/JSONC

* polish

* fix test
 2022-10-17 14:42:02 -07:00
Matt Bierner 15c111eb21
Pick up latest katex (#163866) 
Fixes #162379
 2022-10-17 14:09:09 -04:00
Henning Dieterichs f1a27d7b8b
Recognize stash merge conflicts (#163680) 2022-10-17 07:42:07 -07:00
Ladislau Szomoru e1e7ce5d17
Git - adopt log output channel api (#163695) 2022-10-17 02:49:12 -07:00
Joyce Er f9a0fdeff2
Tolerate minor edit session identity differences (#163804) 
Also add basic support for partial edit session identity matches
 2022-10-16 23:51:51 -07:00
Matt Bierner 641046a11d
Add commands to insert images/links in markdown (#163706) 
* Add commands to insert images/links in markdown

Fixes #162809

* Rename commands and allow passing in uris

* Support selecting many images/files
 2022-10-14 16:05:36 -07:00
Matt Bierner 3b255af0cb
Pick up latest vscode-markdown-languageservice (#163681) 2022-10-14 11:46:24 -07:00
Tyler James Leonhardt 6684350a58
Onboard GitHub & Microsoft auth extensions to l10n (#163662) 
* onboard github-auth completely to l10n

* onboard microsoft-authentication entirely on to l10n
 2022-10-14 08:41:21 -07:00
Matt Bierner 186d3415a3
Use ??= in more places (#163594) 2022-10-13 14:59:35 -07:00
Jake Bailey 65a9097aa2
Remove forgoten reference to typescript/lib/protocol (#163585) 2022-10-13 13:15:13 -07:00
Sandeep Somavarapu 894aa9a7a7
Log improvements (#163532) 
* - expose log level in the proposed api
- ability to set log level per logger

* fix tests
 2022-10-13 03:48:52 -07:00
Daniel Rosenwasser a053a4d505 Allow walkthroughs to specify icons. 
Useful for specifying icons *other* than those of the contributing extension.
 2022-10-12 17:14:42 -07:00
Tyler James Leonhardt 2457d9eb46
Plumbing for desktop to pick up strings from language packs (#163494) 
Web will come in the next PR (hence the TODO)

Also this includes the smallest translation change which will be the ultimate test that this is all working.
 2022-10-12 17:08:27 -07:00
Jake Bailey 07b87405e7
Don't depend on typescript protocol.d.ts (#163365) 2022-10-12 16:03:07 -07:00
Suven-p 22ff985c19
Add multiple template parameters (#163191) 2022-10-12 14:06:19 -07:00
Matt Bierner b2d129c4e5
Fix ipv6 support for simple browser (#163374) 
Fixes #158599

This correctly handles ipv6 uris, such as `http://[::]:3000`. In these cases, the brackets are required
 2022-10-12 11:04:56 -07:00
Raymond Zhao bf220dd91e
Darken red colour in light theme for better contrast (#163335) 2022-10-12 08:47:13 -07:00
Ladislau Szomoru b43c281df2
Git - Attempt to parse HEAD file before invoking git.exe (#162572) 
* Attempt to parse HEAD file before invoking git.exe

* Pull request feedback

* Pull request feedback

* More pull request feedback
 2022-10-12 15:56:36 +02:00
Ladislau Szomoru 3992d5b9ab
Git - Show progress indicator while running fetch (#163425) 
Show progress indicator while running fetch
 2022-10-12 04:31:31 -07:00
Ladislau Szomoru 3e4df23350
Git- get commit input template in parallel with other operations (#163423) 2022-10-12 13:31:08 +02:00
Ladislau Szomoru 8c946e23f4
Git - Fix typo in setting description (#163400) 
Fix typo in setting description
 2022-10-12 09:12:39 +02:00
Jean Pierre 24b8eb0d54
Fixes simple browser webview is not reused if restored (#163389) 
Fixes #163387
 2022-10-11 20:59:54 -07:00
Rob Lourens cf47b76c63
Finalize notebookDebugOptions API (#163316) 
* Finalize notebookDebugOptions API
Fix #147264

* Backcompat for the option from vscode-jupyter

* Undo comment

* Fix build
 2022-10-11 20:25:51 -07:00
Matt Bierner e1a373defd
Finalize markdown link updating on file move (#163378) 
Fixes #148146
 2022-10-11 17:42:10 -07:00
Matt Bierner 6cf68a1f23
Remove .only and fix tests (#163376) 
Fixes #162159
 2022-10-11 17:41:13 -07:00
Matt Bierner d05d85a78b
Move html rewriting for old webviews to (#163367) 
The `asWebviewUri` methods was introduced in VS Code 1.38. It's silly that we still force every single webview to pay the cost of trying to rewrite the old style uris we supported in very old versions of VS Code

Instead I've moved this logic into the extension host and disabled it for all extensions that target VS Code 1.60+ or newer. This means it never applies to internal webviews, notebooks, webview views, or custom editors (these public apis were all introduced after the switch to `asWebviewUri`)
 2022-10-11 16:08:17 -07:00
Don Jayamanne 43957ccfe1
Compress streams in notebook outputs (#160946) 
* Revert "Compress notebook output streams before rendering (#160667)"

This reverts commit 4230c22a08.

* Compress stream output items

* Minor perf improvements

* Misc

* Comments

* Added tests

* Merge issue

* More merge issues

* Misc

* Address code review comments
 2022-10-11 14:43:46 -07:00
Tyler James Leonhardt 4322170fd8
comment is an array (#163348) 2022-10-11 13:39:12 -07:00
Joyce Er 7666d7acd4
Avoid * activating ipynb extension (#163325) 2022-10-11 10:53:07 -07:00
Sean McManus 3f2adbfe3e
Update language-configuration.json (#163182) 2022-10-11 09:23:42 +02:00
Alex Ross 5dfca53892
Try out a new razor grammar (#163212) 
Part of #163149
 2022-10-10 12:43:02 -07:00
jannisspeer b2d7afc634
Remove Snakefile from being classified as Python (#162749) 
Update package.json

Co-authored-by: Alex Ross <alros@microsoft.com>
 2022-10-10 21:32:26 +02:00
Alex Ross 23e6c032af
Start enforcing the tunnels API (#163187) 
* Start enforcing the tunnels API

* Fix API test
 2022-10-10 10:10:24 -07:00
Ladislau Szomoru d53074babf
Git - Fix Commit action button enablement regression (#163159) 
Fix Commit action button enablement regression
 2022-10-10 14:06:20 +02:00
Johannes Rieken 03f98efb75
fix Extract Telemetry step (#162832) 2022-10-06 06:17:12 -07:00
Johannes Rieken b2b7e0be6e
send telemetry about git-exec duration (#162731) 
* send telemetry about git-exec duration

* measure spawn and exec
 2022-10-06 04:04:35 -07:00
Matt Bierner bfb1a738d1
Fix markdown open preview opening duplicate preview (#162793) 
This fixes the markdown 'open preview' command when used with `vscode.ViewColumn.Active` or `vscode.ViewColumn.Beside`
 2022-10-06 09:50:10 +02:00
Matt Bierner 4991cf2112
Remove console.log (#162784) 2022-10-05 15:25:52 -07:00
Matt Bierner d47ae7a2e7
Pick up latest markdown language service version (#162777) 
Fixes #162776
Fixes #162775
 2022-10-05 15:08:51 -07:00
Matt Bierner 3ee9749b35
Remove extra enums (#162686) 
`showMessage` returns the selected item, so we don't need to create an enum here and can instead used the returned items directly
 2022-10-04 10:46:53 -07:00
Alex Ross fd4346210f
Update grammars (#162673) 2022-10-04 08:50:55 -07:00
Ladislau Szomoru d904014287
Git - fix commitInProgress context key (#162562) 
Fix #154628
 2022-10-03 15:02:24 +02:00
Christof Marti 85bf7f1d9b Update schema with new properties (microsoft/vscode-remote-release#7278) 2022-10-03 11:52:07 +02:00
Sandeep Somavarapu 029ed84d6d
Merge pull request #162423 from microsoft/aeschli/162332 
IntelliSense in JSON keyboard shortcut editor doesn't work for non-default profiles
 2022-10-03 10:27:05 +02:00
Ladislau Szomoru 9bc43c7f8a
Git - Rename git.fetchBeforeCheckout to git.pullBeforeCheckout (#162303) 
Rename git.fetchBeforeCheckout to git.pullBeforeCheckout
 2022-09-30 00:42:20 -07:00
Martin Aeschlimann 4e7be94149
IntelliSense in JSON keyboard shortcut editor doesn't work for non-default profiles 2022-09-30 09:24:35 +02:00
Matt Bierner feb3d2d205
Fix null ref in attachments check (#162396) 
Fixes #162391

Also reduces use of `any`
 2022-09-29 13:15:01 -07:00
Henning Dieterichs 46afa5b108
Fixes #162043 by renaming "Accept Merge" to "Complete Merge" (#162361) 2022-09-29 08:19:06 -07:00
Johannes Rieken a2fe848791
set git.mergeChanges context key for all repos, not just one (#162339) 
fixes https://github.com/microsoft/vscode/issues/162224
 2022-09-29 05:50:07 -07:00
Henning Dieterichs 6cba93633d
Merge pull request #162318 from microsoft/hediet/amused-whale 
Fixes #162027
 2022-09-29 12:21:52 +02:00
Martin Aeschlimann 320f338681
[html] Sytax Highlighting is way off with new line after event handler (#162319) 2022-09-29 12:19:36 +02:00
Henning Dieterichs c4359c2dab
Addresses #162112 (#162321) 2022-09-29 12:18:18 +02:00
Henning Dieterichs b29b217e36
Fixes #162027 2022-09-29 10:50:48 +02:00
Ladislau Szomoru 197bfd9088
Git - Use modal dialog after cloning a repository (#162306) 
Use modal dialog after cloning a repository
 2022-09-29 01:01:29 -07:00
Josh Abernathy d3e330e4da
Update devcontainer schema for customizations.codespaces.openFiles (#161637) 2022-09-29 00:02:29 -07:00
Matt Bierner cbb0a982fd
Pick up final markdown language service 0.1 release (#162256) 
Just pulling in the stable release
 2022-09-28 14:02:26 -07:00
6⭐ Sygna Suit Red-EX dd4d29dd8b
Update Python source highlighting example to be more idiomatic (#154013) 2022-09-28 11:29:18 -07:00
Matt Bierner 5296b0faf3
Add explicit "inherit" setting for fragments links (#162231) 
Fixes #162129
 2022-09-28 14:08:03 -04:00
Sandeep Somavarapu b3434bf251
Fix #161868 (#162148) 2022-09-28 03:28:32 -07:00
Ladislau Szomoru 7559012a34
Git protocol handler improvements (#162144) 2022-09-28 02:58:10 -07:00
Matt Bierner c2a2ad4f63
Rename image-preview extension to media-preview (#162093) 
Fixes #162092

Also removes `aac` from the list of supported audio formats
 2022-09-27 21:01:14 -07:00
Matt Bierner 4f0edb3fe7
Pick up latest TS 4.8.4 recovery (#162059) 2022-09-27 14:28:39 -07:00
Matt Bierner ca635a3cdf
Add playsInline to video (#162065) 
We want the video to play in the editor, not go fullscreen
 2022-09-27 14:28:22 -07:00
Matt Bierner b4600dab29
Fix audio mime type listing (#162063) 2022-09-27 13:39:05 -07:00
Harald Kirschner ea5b244abd
File snippets for HTML and PHP (#161881) 
* Adding file snippets for HTML and PHP to start small.

* Adding TS
 2022-09-27 08:15:57 -07:00
Alexandru Dima 29b8a1e27f
Run OSS tool (#161956) 2022-09-27 05:21:59 -07:00
Henning Dieterichs 42a198b98b
Merge pull request #160385 from thernstig/patch-1 
Update Groovy extension language contribution
 2022-09-27 14:07:49 +02:00
Martin Aeschlimann 06bd7ae776
[css] use findDocumentSymbols (#161847) 
[css] use findDocumentSymbols. For #157356
 2022-09-26 14:16:07 -07:00
Martin Aeschlimann 741fa37b10
[json/css/html] update services / deps (#161831) 2022-09-26 12:41:26 -07:00
Tyler James Leonhardt 29e985eca0
rev vscode-nls to version that doesn't ask for vscode-nls-web-data (#161819) 
ref #161297
 2022-09-26 11:10:54 -07:00
Matt Bierner b8a7485526
Fix markdown preview refresh from disk (#161800) 
Fixes #149974
 2022-09-26 09:49:53 -07:00
Martin Aeschlimann ae8cf2186e
The properties language uses a Java icon in the Seti theme (#161770) 
The properties language uses a Java icon in the Seti theme. Fixes #158453
 2022-09-26 07:31:08 -07:00
Trond Einar Snekvik 83248ce374
Default to config icon for the property language (#158454) 2022-09-26 07:00:07 -07:00
Gerrit Birkeland cace09d0eb
Add schema for typedoc.json to default jsonValidation (#157592) 
Add schema for typedoc.json to default 
jsonValidation
 2022-09-26 15:51:42 +02:00
Gerrit Birkeland 9ac5f48ff3
Add jsonc registration for TypeDoc config (#157362) 
This is supported as of TypeDoc 0.23. Since it is more commonly used than ember-cli, seems reasonable to add it here.
 2022-09-26 15:51:23 +02:00
Colen Garoutte-Carson 33787082be
Enable auto-close of multi-line comments in cpp (#160357) 2022-09-26 15:29:05 +02:00
Daniel Rosenwasser da506e9b8d
Tag existing events with experimentation info in typescript-language-features (#161463) 
* Associate experiment info with existing telemetry.

* Move the ExperimentTelemetryReporter to its own file.

* Roughly copied the 'getPackageInfo' function from other extensions.

* Addressed code review feedback.
 2022-09-23 15:18:57 -07:00
Henning Dieterichs d7ad82454e
Revert "Bracket support for #if and #endif in cpp" 2022-09-23 13:59:23 +02:00
Matt Bierner 2a4fb40a6e
Align list of supported tags in rendered markdown (#161544) 
This expands the list of html tags we allow in markdown. To get this list, I've copied the list of tags from `markdownDocumentRenderer` into `dom` after  reviewing them

For #134514, I've also added `video` to the list of allowed tags
 2022-09-22 18:25:48 -07:00
Matt Bierner 82c1bf86bf
Show better error when rename fails in md (#161525) 
* Show better error when rename fails in md

* Pick up latest MDLanguage service
 2022-09-22 16:27:25 -07:00
Matt Bierner 023930e3dc
Fix extra dot in pasted file names (#161434) 2022-09-21 23:29:21 +02:00
Matt Bierner 07a5d2749f
Allow _ in notebook markdown links (#161437) 
Fixes #160853
 2022-09-21 14:23:47 -07:00
Matt Bierner 17bb582b85
Finalize markdown diagnostics (#161427) 
Fixes #146303

This moves the markdown diagnostic support out of `experimental` and to an official feature (however it remains off by default)
 2022-09-21 12:20:25 -07:00
Alex Ross 1562a35c86
Indent using spaces 🤷‍♀️ (#161405) 2022-09-21 07:41:57 -07:00
Ladislau Szomoru ce7e388ef1
Git - Checkout command aria label now includes the branch name (#161385) 
* Checkout command aria label now includes the branch name

* Pull request feedback
 2022-09-21 07:10:52 -07:00
Alex Ross 8aa37f3c9b
Add group to copy vscode.dev link in share (#161400) 
Part of #157722
 2022-09-21 07:03:38 -07:00
Henning Dieterichs 40a262dc13
merge editor temp model (#161315) 
Introduces hidden mergeEditor.useWorkingCopy setting,
implements reset when the merge editor opens
 2022-09-21 16:02:50 +02:00
Matt Bierner 333754f29b
Better handle moves of multiple markdown links (#161354) 
This makes the markdown language service handle moving/renaming multiple files instead of making multiple calls into the language service
 2022-09-20 21:53:58 -07:00
Matt Bierner f25d47121b
Pick up newer vscode-tas-client version (#161344) 2022-09-20 13:52:29 -07:00
Matt Bierner a5f5a730d6
Fix hiding of image preview status bar items (#161278) 2022-09-20 13:49:03 -07:00
Daniel Rosenwasser 5cde74b767
Fix accidental case fallthroughs in experimentation services. (#161339) 2022-09-20 12:00:32 -07:00
Johannes Rieken c1b80f6402
Disable merge-conflict commands for 3wm-editor (#161304) 
fixes https://github.com/microsoft/vscode/issues/159156
 2022-09-20 13:50:21 +02:00
Rob Lourens 0e333cd799
Convert NotebookCellStatusBarItem test from integration test to unit test (#161274) 
Fix #157828
 2022-09-20 09:55:58 +02:00
Sandeep Somavarapu 35c7ee9d02
Support log output channels for extensions (#161249) 
* introduce log api in extension context

* separate registering output vs log channel

* Separate extension log channels in show logs command

* add logging error to embedder logger

* show extension log in the extension editor

* configure log level per extension

* change the order of log entries

* introduce logger

* align with output chanel

* revert changes

* fixes
 2022-09-19 09:03:41 -07:00
Matt Bierner d03f015931
Clean up structure of markdown extension (#161148) 
- Move things related to the client under `client`
- Remove extra abstractions that are no longer used
- Add MdLanguageClient type
 2022-09-19 07:16:45 +02:00
Matt Bierner f4bf1f30a2
Skip ul and ol when highlighting selected markdown element (#161139) 
Fixes #155552

For lists, the outer ul/ol always has the same source line as the first element in the list. We should prefer using the first element in the list when highlighting the active line

This also fixes a bug where scroll sync would stop working if you added lines to the doc. This was caused by `lineCount` getting out of sync as the document is being updated. I've removed this state and made the reveal logic more robust instead
 2022-09-19 07:16:06 +02:00
Matt Bierner a10bdfb49b
Allow underscores in rendered md headers (#161149) 
Follow up from https://github.com/microsoft/vscode-markdown-languageservice/pull/49
 2022-09-16 20:52:50 -04:00
Matt Bierner 4c9c3f628d
Pick up latest markdown language service (#161142) 2022-09-16 20:52:16 -04:00
Peng Lyu 6e8bc02be4
Cell attachment cleanup tool improvement in diff editor (#161132) 
* Move attachment out of custom metadata, prep for attachment clean up in diff editor

* recover attachments from dirty notebook document

* Allow metadata to be restored when content changed/reverted in nb diff editor
 2022-09-16 14:12:53 -07:00
Matt Bierner 7c3ea7ac06
Pick up TS 4.8.3 (#161126) 
Picks up latest TS stable build
 2022-09-16 10:22:13 -07:00
Martin Aeschlimann 724a088c68
update vscode-uri, fix links in untited (fixes #147788) (#161108) 2022-09-16 07:57:10 -07:00
Johannes Rieken 21a2eca3b7
The openMergeEditor command should check the active tab when it is called without an URI (#161072) 
https://github.com/microsoft/vscode/issues/160924
 2022-09-16 11:55:06 +02:00
Johannes Rieken 77309b33d4
add WorkspaceEditMetadata and use it for applyEdit, (#160996) 
* add `WorkspaceEditMetadata` and use it for `applyEdit`,

https://github.com/microsoft/vscode/issues/112109

* fix compilo in tests

* workspace edits from updating paths are marked as refactoring fyi @mjbvz
 2022-09-16 09:44:19 +02:00
Benjamin Pasero ec56dddd9f
tests - remove snippetWorkspaceEdit usage (#161043) 2022-09-16 00:34:30 -07:00
Matt Bierner 3c37a5a8d7
Reapply JavaScript and Node.js walkthrough (#161003) 
This reverts commit cfc0119755.

Brings the walkthrough back in but makes sure it is only loaded on desktop
 2022-09-15 13:02:43 -07:00
Daniel Rosenwasser 9dfd49db63
Ensure ExperimentationService gets disposed. (#161004) 2022-09-15 11:06:53 -07:00
Peng Lyu 0f05c6dd4f
Fix #160729. Disable workspace md paste handler for notebook. (#160833) 
Co-authored-by: Matt Bierner <matb@microsoft.com>
 2022-09-15 09:48:21 -07:00
Joyce Er 6835a98d4a
Fix branch checkout after git clone (#160922) 
* Fix branch checkout after git clone

* Add progress notification while checking out ref

* Remove promise chain
 2022-09-15 18:11:29 +02:00
Ladislau Szomoru e1c7285ab5
Git - Add the ability to fetch a branch before it is checked out (#160181) 2022-09-15 16:04:37 +02:00
Ladislau Szomoru fd2b0d888f
Git - Do not override SSH_ASKPASS for the terminal (#160935) 
Do not override SSH_ASKPASS for the terminal
 2022-09-15 13:48:05 +02:00
Matt Bierner 03ada8a3e8
Rework how markdown server works with documents (#160948) 
* Rework how markdown server works with documents

This rewrites how the markdown server works with documents. The goal is to better handle switching between in-memory versions of a doc (from `TextDocument`) and versions of the same doc on disk. From the markdown service's POV, there is only one type of document

As part of this, I've also adopted the newest markdown language service version

* Bump package-lock versions
 2022-09-15 09:27:02 +02:00
Benjamin Pasero cfc0119755
Revert "JavaScript and Node.js walkthrough" (#160959) 
Revert "JavaScript and Node.js walkthrough (#157965)"

This reverts commit 0cbcb1b1ab.
 2022-09-15 08:26:22 +02:00
Don Jayamanne c6698eaced
Pass element to the JS preEvaluate renderer hook (#160851) 2022-09-14 17:21:48 -07:00
Tyler James Leonhardt ccddb94f98
initial cut of vscode.l10n (#158328) 2022-09-14 16:48:25 -07:00
Rob Lourens c717237d7c
Reenable a couple notebook smoketests (#159521) 
* Remove vscode-notebook-tests in favor of an .ipynb in vscode-smoketest-express

* Update build folder

* Add build task to correct platform

* Build for smoke tests on other platforms

* Fix repo url and remove comment

* Just -media?

* Update darwin/win32 as well
 2022-09-14 13:22:16 -07:00
Isidor Nikolic 65cbb9324b
change git.mergeEditor setting to be false (#160923) 2022-09-14 11:41:41 -07:00
Ladislau Szomoru e97b478d06
Commit dropdown button uses text-overflow (#160834) 2022-09-14 20:40:06 +02:00
Tyler James Leonhardt fc1ef74eb0
GHES oauth flow support (#160679) 
* GHES oauth flow support

* update server number

* delete testing line
 2022-09-14 11:26:02 -07:00
Joyce Er 51ab74bc88
Don't register git protocol handler till after git commands are registered (#160857) 2022-09-14 19:23:38 +02:00
Ladislau Szomoru 3dc9b8a26c
GitHub - Tweak working of the GitHub publishing welcome view (#160916) 
Tweak working of the GitHub publishing welcome view
 2022-09-14 10:02:43 -07:00
Daniel Rosenwasser 0cbcb1b1ab
JavaScript and Node.js walkthrough (#157965) 
* Initial contents for JavaScript walkthrough.

* Just suggest a `.js` file.

* Switch the walkthrough to be a Node.js walkthrough.

* Remove leftover file from HTML walkthrough.

* Add basic detection mechanism for node.

* Don't check for a Node install until the user runs debug.

* Add "learn more" link.

* Some assets.

* Remove "run" section.

* Add a "try debugging anyway" option just in case.

* Remove "view terminal" command in run & debug.

* More copy.

* Remove unused command.

* Update icon and themed walkthrough SVGs

* Default to not showing the extension.

* Replace icon

* Delete TODO.md

* jsWelcome -> nodejsWelcome

Co-authored-by: David Dossett <ddossett@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
 2022-09-14 09:53:37 -07:00
Rob Lourens 37f08d1195
Remove notebookEditorEdit proposal requirement (#160912) 2022-09-14 09:41:21 -07:00
Daniel Rosenwasser 00902daee1
Instantiate ExperimentationService in typescript-language-features. (#160877) 
Co-authored-by: Matt Bierner <matb@microsoft.com>
 2022-09-14 09:34:04 -07:00
Matt Bierner fa1fee3b21
Pick up latest Markdown language service (#160831) 2022-09-14 09:20:52 -07:00
Matt Bierner 2cf7468289
Fix markdown server deleting documents on close if they still exist on disk (#160859) 2022-09-14 09:16:39 -07:00
Daniel Imms a4cce8f575
Merge pull request #160900 from babakks/add-change-shell-event 
Add `onDidChangeShell` event to the API
 2022-09-14 07:53:50 -07:00
Daniel Imms c4611298a3
Add envShellEvent to vscode-api-tests 2022-09-14 07:32:41 -07:00
Ladislau Szomoru 60fa7bc579
Git - Improve git fetch command for repositories with multiple remotes (#159644) 
* Improve git fetch command for repositories with multiple remotes

* Refactored and cleaned up the implementation

* Pull request feedback
 2022-09-14 11:06:27 +02:00
Martin Aeschlimann 5431050e5f
Use Uri.Utils (#160780) 
* Use Uri.Utils

* handle base as folder
 2022-09-13 17:46:01 +02:00
Michael Chirico 77dd5f36d5
Better paired operators for R (#155882) 
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
 2022-09-13 09:37:21 +02:00
Don Jayamanne 4230c22a08
Compress notebook output streams before rendering (#160667) 
* Compress notebook output streams before rendering

* OOps

* Combine the buffers manually

* Address code review

* oops

* Fixes

* We can have multiple stream mimes in an output

* oops
 2022-09-13 08:56:32 +10:00
Matt Bierner 1d500fb4de
Add CodeActionKind.RefactorMove (#160730) 
Fixes #160728
 2022-09-12 15:14:06 -07:00
Matt Bierner 2514759850
Remove notebook content provider save and backup functionality (#160581) 
For #147248

When stepping through the liveshare code, we figured out they do not appear to be using `save`, `saveAs`, or `backup` (they return empty results for these)

This PR removes this part of the proposal so we can track just the parts of the api that they are using
 2022-09-12 14:08:25 -07:00
Matt Bierner 3729f509b5
Support creating image in workspace when pasting image data into markdown (#160554) 
For #157043
 2022-09-10 08:56:18 -07:00
Ladislau Szomoru d2c241ffc0
Git - Disable git.init command, and a welcome view that uses the git.init command in codespaces (#160597) 
Disable git.init command, and a welcome view that uses the git.init command in codespaces
 2022-09-10 10:38:41 +02:00
Michael Lively 42238bdaab
notebook image cleaning automation (#159212) 
* cache and cleaner complete, needs debounce

* minor renaming and reformatting

* bugfix for paste into new cell

* cleaning functionality complete

* refer to metadata as copy of current cell's

* check undef before reading from cache

* working state, pending cache restructure

* dots -> brackets

* pre-class refactor

* massive cleaner refactor

* cache typing, closed nb check, workspaceEdit only if metadata is changed

* undefined access fix

* proper debouncer

* get it up to work again

* no need to loop

* cell metadata uri parsing regression

* diagnostic

* Show diagnostics on document open

* transfer cache before file renames

* disable word wrap in notebook diff editor

* Avoid early notebook cell metadata deep clone

* No special case empty cell

* rename

* better naming

* Quick fix for invalid image attachment

* cleanup

* Add code action metadata

Co-authored-by: rebornix <penn.lv@gmail.com>
 2022-09-09 11:32:10 -07:00
Ladislau Szomoru df51f5af27
GitHub - Disable command & view in codespaces (#160546) 
Disable command & view in codespaces
 2022-09-09 11:22:39 -07:00
Benjamin Simmonds 8268e5d27d
Remove enabledApiProposals badge from test ext (#160526) 2022-09-09 15:36:53 +02:00
Ladislau Szomoru 52223728f8
Git - Add the ability to commit and not execute a post-commit command (#160527) 
Add the ability to commit and not execute a post-commit command
 2022-09-09 14:58:38 +02:00
Matt Bierner ded9a310a4
Add webm/VP8 support to video viewer (#160459) 
Add VP8 support to video viewer
 2022-09-08 17:28:24 -07:00
Matt Bierner d7d18aa0da
Clean up video styling (#160461) 2022-09-08 17:28:14 -07:00
Matt Bierner a77d1c2563
Add JS notebook renderer hook (#160453) 
Fixes #160451
 2022-09-08 15:37:24 -07:00
Matt Bierner 5d5ea15a65
Allow passing in custom workspace/parser to markdown server (#160429) 
For #159805

This splits the markdown server into two main functions:

- `startVsCodeServer` which assumes the client can implement all the functionality of VS Code. It is not specific to VS Code however, the client just need to implement the custom messages that VS Code does

- `startServer` which lets you pass in your own implementation of the parser and workspace. A consumer of the server can then use this to have their own custom server implementation, which might use normal node apis to read files
 2022-09-08 11:35:42 -07:00
Logan Ramos b8afe8d6ed
Skip tab getter tests on web because notebooks are flaky (#160403) 
Skip tab tests on web because notebooks are flaky
 2022-09-08 04:59:12 -07:00
Johannes Rieken ac5591282f
send uris for git.mergeChanges context as objects (#160390) 
That way they undergo uri transformation and the setContext-command will stringify them so that everything works, fixes https://github.com/microsoft/vscode/issues/159837
 2022-09-08 02:33:19 -07:00
Tobias Hernstig 00414a3755
Update Groovy extension language contribution 
Change `filenamePatterns` to `Jenkinsfile.*` to `Jenkinsfile*` to capture files starting with Jenkinsfile, not necessarily having a period as a delimiter.
 2022-09-08 10:37:31 +02:00
João Moreno 9e6e1312fb
avoid calling setContext when not necessary (#160297) 
* avoid calling setContext when not necessary

* Update extensions/git/src/repository.ts
 2022-09-08 09:54:35 +02:00
Ladislau Szomoru f285179711
GitHub - publish repository (#160348) 2022-09-08 00:29:58 -07:00
Matt Bierner 2d27f8db6a
Use MD LS for resolving all document links (#160238) 
* Use MD LS for resolving all document links

This switches the markdown extension to use the markdown language service when resolving the link. This lets us delete a lot of code that was duplicated between the extension and the LS

* Pick up new ls version
 2022-09-07 20:55:14 -07:00
Joyce Er 6d08356a85
Show modal error when git protocol clone fails (#160350) 2022-09-07 15:12:49 -07:00
Matt Bierner f4f68a568d
Make default JS renderer treat js as modules (#160347) 
Fixes #157076
 2022-09-08 06:47:01 +10:00
Martin Aeschlimann 440e61ffab
bring back css tests (#160326) 2022-09-07 10:43:47 -07:00
Johannes Rieken 9bbc7b2bb0
Merge pull request #160193 from microsoft/joh/ordinary-canidae 
support `contents` option with `WorkspaceEdit#createFile`
 2022-09-07 16:33:42 +02:00
Ladislau Szomoru a6272c9416
Git - implement SSH_ASKPASS handler (#159573) 2022-09-07 15:59:40 +02:00
Ladislau Szomoru eff6fa7696
Git - discover nested git repositories (#159291) 2022-09-07 15:35:46 +02:00
Ladislau Szomoru 1e99736c27
Git - Add merge abort command (#159753) 
* Add merge abort command

* Pull request feedback
 2022-09-07 06:06:20 -07:00
Johannes 4da1e34afe
add content property to vscode-dts-defined properties 2022-09-07 13:21:05 +02:00
Matt Bierner 077f5865da
Support latest md ls (#160228) 
- Update `looksLikeMarkdownPath` to look at open documents and notebooks, not just the uri
- Register custom command  for document links
 2022-09-07 07:17:41 +02:00
Raymond Zhao 50140a53cc
Revert "Fix language-specific tab expansion and polish (#157035)" (#160233) 
This reverts commit 9f80085795.
 2022-09-06 15:21:34 -07:00
Johannes Rieken 50cdf1d71b
Merge pull request #160176 from microsoft/joh/nasty-rook 
have an explicit `SnippetTextEdit` and all to set them onto a workspace edit
 2022-09-07 00:02:46 +02:00
Johannes b0140c2ca4
support contents option with WorkspaceEdit#createFile 2022-09-06 16:19:08 +02:00
Johannes bcf6547e92
fix API tests for new API 2022-09-06 14:53:43 +02:00
Benjamin Simmonds f51258b93b
Optional TreeItem Checkbox (#158250) 2022-09-06 12:41:57 +02:00
Martin Aeschlimann daf5eb2262
fix css tests (#160155) 
* fix tests

* add skip
 2022-09-06 11:27:06 +02:00
Martin Aeschlimann 3c9ab33d33
fix tests (#160146) 2022-09-06 09:39:08 +02:00
Ladislau Szomoru 4542a16b0b
Git - fix telemetry comment (#160117) 
Fix telemetry comment
 2022-09-05 21:09:24 +02:00
Martin Aeschlimann 48d1e04d9d
[css/json/html] update servers and services (#160108) 2022-09-05 19:10:32 +02:00
Ladislau Szomoru bb2c77dea1
Git - Initial repository scan telemetry (#160102) 
Initial repository scan telemetry
 2022-09-05 08:12:25 -07:00
Henning Dieterichs 9b381c5cd9
Merge pull request #159654 from microsoft/hediet/september 
Hediet/september
 2022-09-05 13:00:40 +02:00
Henning Dieterichs 226be69989
Adresses feedback from PR 2022-09-05 09:59:56 +02:00
Blip blop 13a51cea1d
Updated support for #if and #endif 2022-09-03 22:26:50 +05:30
Joyce Er d337885984
Route user to download missing git (#159505) 
* Factor out captured variables that are not reused outside findGit callback

* Always register git protocol handler

* Notify the user when cloning without git installed

* Actually notify the user when cloning without git installed

Errors when invoking a command don't seem to get thrown in the extension host

* Add output channel logging

* Revert "Factor out captured variables that are not reused outside findGit callback"

This reverts commit df005bdda5.
 2022-09-02 16:31:17 +02:00
Benjamin Pasero 968d9eda2c
Integration test failure: openTextDocument, untitled closes on save (#157897) (#159888) 2022-09-02 13:43:44 +02:00
Henning Dieterichs 6a853ed3f3
Introduces mergeEditorMenus proposal & fixes issues from PR. 2022-09-02 09:06:24 +02:00
Joyce Er 9b994545f1
Generate head links for Continue Edit Session (#159833) 2022-09-02 16:32:48 +10:00
Matt Bierner c4722f1bb2
Write markdown link setting change to correct scope (#159816) 
Fixes #159084

Also fixes the same issue for JS/TS
 2022-09-02 13:38:41 +10:00
Matt Bierner d9fd208c29
Default to workspace root when dropping into untitled md files (#159814) 
Fixes #159812
 2022-09-01 16:03:40 -07:00
Michael Lively 834ad7365b small fix in logic 2022-08-31 15:41:15 -07:00
Matt Bierner edcf6e24b3
Add built-in video preview (#159623) 
Fixes #159106

Also hooks up our service worker to support seeking in local video resources. This requires handling range requests properly
 2022-08-31 13:06:06 -07:00
Joyce Er 8d28ffac6d
Allow ref checkout after protocol handler clone (#159481) 2022-08-31 11:06:44 +02:00
Matt Bierner 21337aed3f
Pick up newest markdown language service (#159619) 
This brings support for code actions and source actions, along with some bug fixes

Also fixes `getAllMarkdownDocuments` to prefer open documents instead of those on disk
 2022-08-31 09:20:41 +02:00
Matt Bierner 01ea9c11ea
Update extension enabled tsconfig libs (#159631) 
Matches what we set for `src/`
 2022-08-31 07:57:15 +02:00
Matt Bierner 1895178d00
Finalize notebookWorkspaceEdit api (#159613) 
Fixes #155245
 2022-08-30 15:36:40 -07:00
Logan Ramos a2cd34f347
Allow showTextDocument to open notebook cell URIs (#158477) 
* Fix #123270

* Update to use `getCodeEditor`
 2022-08-30 06:39:00 -04:00
Ladislau Szomoru 933c22a53f
Git - Handle repository paths with a trailing \ character (#159461) 
* Fix another edge case with Windows path that contains a trailing \ character

* Pull request feedback
 2022-08-30 02:58:45 -07:00
Matt Bierner e9d0bed9e5
Reduce duplication for image/audio preview (#159507) 2022-08-30 00:11:50 -07:00
Matt Bierner 5e92794be6
Re-enable running our eslint rules using ts-node (#159495) 
Resubmission of #157532 with the following changes:

- Use `eslint-plugin-local` instead of `yarn` link to run our plugins
- Move our plugins to a top level `.eslintplugin` dir (as required by `eslint-plugin-local`)
- Update all names to `local/`
 2022-08-30 08:40:04 +02:00
Matt Bierner a13e5e1da6
Also apply max-width to videos in webviews (#159500) 2022-08-30 00:52:54 +02:00
Matt Bierner 9e5248072a
Fix ts-node for eslint (#159483) 
Bumps the cachesalt to make sure ts-node is installed
 2022-08-29 20:51:12 +02:00
Matt Bierner 5b21c7f28b
Run our custom eslint rules using ts-node (#157532) 
* Run our custom eslint rules using ts-node

Use `ts-node` to run our custom eslint rules.  This lets us delete the pre-compiled js. It also means you can don't have to compile the rules while editing them

As part of this change, I've also switched us to using an eslint plugin instead of a rulesDir. This is now the preferred way to ship custom rules

* Fix two more disables

* Move ts-node to project root

* Enable transpileOnly
 2022-08-29 09:39:09 -07:00
Matt Bierner 07025f0b0d
Remove notebook editor edit api (#158988) 
Fixes #149181
 2022-08-29 09:34:57 -07:00
Martin Aeschlimann c1dd46c2f4
[npm] package.json latest vue version incorrect (#159315) 
[npm] package.json latest vue version incorrect. FIxes #158850
 2022-08-29 15:49:48 +02:00
Alex Ross ec5b41ddc2
Update grammars (#159445) 
Update grammar
 2022-08-29 14:08:44 +02:00
Alex Ross 41a6299276
Simple browser opener doesn't work with IPv6 hosts (#159276) 
Fixes #158599
 2022-08-29 10:58:17 +02:00
Matt Bierner 33c1f51a17
Add built-in audio preview (#159345) 
For #159106

Note that we're using the native audio control at the moment, which looks kind of out of place and can't easily be styled. May need to switch to a custom UI
 2022-08-29 00:19:21 -07:00
Henning Dieterichs 7688a40249
Implements commands to recompute merge with git merge-file 2022-08-28 16:41:13 +02:00
Matt Bierner b5a1bb34e9
Pick up latest TS for building VS Code (#158420) 2022-08-26 23:00:38 +02:00
Matt Bierner b91533f3d7
Pick up latest vscode-markdown-languageservice (#159341) 2022-08-26 13:08:49 -07:00
Matt Bierner ea6cfdd2ef
Pick up 8.0.2 for MD language client (#159319) 
Missed updating this when pulling in new server version

https://github.com/microsoft/vscode-languageserver-node/issues/1064
 2022-08-26 11:13:37 -04:00
Matt Bierner 0a7b686a48
Fix markdown not registering find all references support (#159242) 2022-08-26 01:42:52 +02:00
Matt Bierner c9a97b5581
Pick up TS 4.8 final (#159238) 
Fixes #157527
 2022-08-26 01:30:07 +02:00
Michael Lively 05ae151b7d return object, change placeholder 2022-08-25 15:33:50 -07:00
Michael Lively 16f842ea76 fix for attachment naming within notebook metadata 2022-08-25 15:04:56 -07:00
Tyler James Leonhardt dc9336c303
make sure we add offline_access when creating sessions (#159116) 2022-08-25 08:48:01 -04:00
David Dossett 52f8bfaf5b
Inherit editor inactive selection colors in terminal (Fix #158899) (#158950) 
* Inherit editor inactive selection colors in terminal (Fix #158899)

* Remove unused import

* Add terminal inactive selection colors to default dark and light themes

* Update monokai terminal inactive selection

* Merge branch 'main' into ddossett/thoughtful-butterfly
 2022-08-25 01:00:34 +02:00
Michael Lively 6671589cdc fix setting description for #159091 2022-08-24 12:20:38 -07:00
Michael Lively 6273efd6b6
Merge branch 'main' into mlively/pasteRefactor 2022-08-24 10:42:21 -07:00
Michael Lively 614c7dd5f4 fix conflict demo 2022-08-24 10:37:37 -07:00
Matt Bierner 940abc9c11
Fix workspace edit format for update md paths on move (#158965) 
Unblocks testing #158416
 2022-08-23 16:33:00 -07:00
Michael Lively 02cb45c3cb
demo merge conflict 2022-08-23 16:10:56 -07:00
Michael Lively ae1167bd94 refactor with updated metadata properties 2022-08-23 16:09:30 -07:00
Matt Bierner f00fde0f24
Mark that notebook metadata is readonly (#158960) 
Mark that metadata is `readonly`

Fixes #158955

We freeze the object here 0656d21d11/src/vs/workbench/api/common/extHostNotebookDocument.ts (L70)
 2022-08-23 14:52:00 -07:00
Matt Bierner b72671133b
Fix any types and extract method (#158967) 
`currentCell` and `notebookUri` are currently any types, which hides type errors. To fix this and clean up the code, I've extracted a new `getCellFromCellDocument` method
 2022-08-23 13:57:44 -07:00
Michael Lively 1076180257
Merge branch 'main' into mlively/newCellPasteBug 2022-08-22 14:57:15 -07:00
Harald Kirschner bb70d7ab19
Instrument slow git status updates (#158325) 
* Instrument slow git status updates

* Add expiration
 2022-08-22 22:01:51 +02:00
Johannes Rieken 337cd4b1cf
Expose editor "blue button" as menu (#158740) 
* Expose editor "blue button" as menu

* rename proposed `MergeToolbar` to `EditorContent` menu
* adopt GIT and sync conflicts usage
* use content menu for "open in 3wm" command
* add new `ctxIsMergeResultEditor` context key

Better fix for https://github.com/microsoft/vscode/issues/153800

* fix typo
 2022-08-22 15:24:56 +02:00
Ladislau Szomoru 052b1e4d1b
Git - Clear global state if setting is not enabled (#158747) 
Clear global state if setting is not enabled
 2022-08-22 04:39:02 -07:00
Ladislau Szomoru 3cfc74c52e
Git - Add setting to remember post commit command (#158449) 2022-08-22 12:34:47 +02:00
Joyce Er fa4ff1519d
Implement and adopt edit session identifier API proposal (#157733) 
* Add canonical workspace identifier proposed API

* Use canonical id to store and resume edit sessions

* Add git extension workspace identity provider

* Fix warning incorrectly showing up

* Make auto resume behavior opt in

* * Create a separate service
* Accept WorkspaceFolder instead of URI
* Return string instead of object

* Make edit session restores resilient to provider registration races

* Introduce an activation event
* Activate contributing extension before using provider

* `CanonicalWorkspaceIdentity` -> `EditSessionIdentity`

* Show progress while resuming edit session

* Store edit session even if extension will take care of opening target workspace

* Address most of PR feedback

* `IEditSessionsWorkbenchService` -> `IEditSessionsStorageService`

* Unregister provider in renderer

* Split out proposal into new `editSessionIdentityProvider.d.ts`

* Fix bad merge

* Always show progress in window

* Convert URI schemes
 2022-08-19 08:01:43 -07:00
João Moreno 6dbddd8b91
fix: freeze Resource#command (#158579) 
Fixes: #157904
 2022-08-19 14:24:36 +02:00
Johannes Rieken 11b6d009a4
Merge branch 'main' into cs-reference-view-api 2022-08-19 12:57:24 +02:00
Michael Lively 519082320b Merge branch 'main' into mlively/newCellPasteBug 2022-08-18 11:58:52 -07:00
Michael Lively 6f7189b7bb refactor metadata into own fxn 2022-08-18 11:58:44 -07:00
Joyce Er 65abd2b037
Add icon for Open on vscode.dev command (#158519) 2022-08-18 20:11:41 +02:00
Logan Ramos 67e628e18a
The quest to debug vscode.open continues (#158483) 2022-08-18 15:13:18 +02:00
Benjamin Pasero 032662071c
openIntegration test failure: openTextDocument, untitled closes on save (#157897) (#158482) 2022-08-18 14:56:50 +02:00
Johannes Rieken c592ef8e18
use "Incoming" and "Current" everywhere (#158478) 
fixes https://github.com/microsoft/vscode/issues/156229
 2022-08-18 14:21:06 +02:00
Johannes Rieken c0ade8bc81
joh/unknown lemming (#158460) 
* make git's `openMergeEditor` user-facing command and show it for editors that have conflicts

also includes a workaround for an issue with untyped editor inputs... fyi @lramos15

* Patch matches

* Remove TODO

* set nowrap for white-space

fixes https://github.com/microsoft/vscode/issues/156402

Co-authored-by: Logan Ramos <lramos15@gmail.com>
 2022-08-18 06:58:30 -04:00
Michael Lively 880fda6ed9 fix pasting image into newly created cell bug 2022-08-17 12:17:39 -07:00
Matt Bierner 129f5bc976
Use own calls to localize (#158372) 
Fixes #156684
 2022-08-17 10:27:29 -04:00
Daniel Imms 95d21cbc37
Merge pull request #157654 from microsoft/tyriar/fish_lang 
Add .fish to shell script language
 2022-08-17 07:06:08 -07:00
Johannes Rieken 9759525167
push workaround for https://github.com/microsoft/vscode/issues/157904 (#158368) 2022-08-17 14:40:36 +01:00
Joyce Er e1628628a8
Provide context on which repository is being cloned (#158324) 2022-08-17 00:11:28 +01:00
Matt Bierner 3393b785de
Bump server version (#158297) 2022-08-16 14:38:41 -04:00
Matt Bierner 720a61fc28
Fix markdown link diagnostics not updated when directories are renamed / deleted (#157956) 
Fix markdown link diagnostics not updated when directories are renamed/deleted

Turns our that `createFileSystemWatcher` will not fire if a parent dir is renamed / deleted. See #60813

To fix this, I believe we have to create watchers for all parent directories too (or watch everything in the entire workspace)
 2022-08-12 13:48:40 -04:00
Rob Lourens 8c2fd550a3
Notebook cell execute in Interactive Window Test Fails on MacOS (#157963) 
* Notebook cell execute in Interactive Window Test Fails on MacOS
Fixes #157826

* Remove .only
 2022-08-12 09:31:11 -07:00
Henning Dieterichs 7dd5f05b6e
Enable conflict marker decorators even if merge editor is enabled. (#157982) 2022-08-12 15:21:38 +02:00
Matt Bierner dfe145441a
Pick up TS 4.8 RC (#157960) 
For #157527
 2022-08-11 16:58:48 -07:00
Matt Bierner b731beeef4
Use notebook document uri for drop / copy paste (#157939) 
Fixes #157938
 2022-08-11 19:52:55 +01:00
Aaron Munger 74f8a781d0
Merge pull request #157923 from amunger/interactiveExecute 
add parameter to Interactive Execute to specify resource
 2022-08-11 11:20:12 -07:00
aamunger 694324e3ac
add parameter to Interactive Execute to specify resource 2022-08-11 10:45:24 -07:00
Benjamin Pasero c6bcc3fcbf
API command test fail on MacOS (for #157824) (#157885) 
API command test fail on MacOS (fix #157824)
 2022-08-11 09:57:19 -04:00
Benjamin Pasero a3067cbbc6
assert that closed is defined (for #157897) (#157901) 2022-08-11 06:46:19 -07:00
Matt Bierner 38ea5c22a6
Pick up new markdown LS version (#157843) 2022-08-10 18:16:24 -07:00
Ladislau Szomoru b2212a1090
Git - Fix more scenarios where the post commit command setting is not honoured. (#157804) 
* Revert "Commit keyboard shortcut to honor the post commit command setting (#157617)"

This reverts commit fe946068ba.

* Fix more scenarios where the post commit command setting is not honoured.
 2022-08-10 16:12:26 -07:00
Alex Ross f146031624
Update grammars (#157773) 2022-08-10 06:40:17 -07:00
Matt Bierner 460768a452
Update TS versions (#157550) 
* Update TS versions

Update the bundled TS and build TS version

* Add explicit annotations

* Recompile JS
 2022-08-09 11:26:24 -07:00
Michael Lively 38477bf5f5
change dir of cellAttachmentRenderer (#157671) 
* change dir of cellAttachmentRenderer

* add new directories to `.vscodeignore`

* add the .js directories back in...

* hopefully now understanding `.vscodeignore`
 2022-08-09 20:00:24 +02:00
Tyler James Leonhardt bcb31b9cfb
disable nls on the web for now (#157665) 2022-08-09 18:30:23 +02:00
Matt Bierner 8bf82819fc
Add experimental support for update markdown links on file moves/renames (#157209) 
* Add experimental support for update markdown links on file moves/renames

Fixes #148146

This adds a new experimental setting that automatically updates markdown

Note that this needs a new version of the vscode-markdown-languageservice so the build is expected to break for now

* Pick up new LS version
 2022-08-09 08:31:40 -07:00
Ladislau Szomoru 81e6a02c18
Git - Upgrade file-type package (#156411) 2022-08-09 11:30:49 -04:00
Daniel Imms 5c2cbe2b7d
Add .fish to shell script language 2022-08-09 08:19:27 -07:00
Ladislau Szomoru fe946068ba
Commit keyboard shortcut to honor the post commit command setting (#157617) 2022-08-09 11:14:56 +02:00
Matt Bierner 389938998f
Show error when markdown preview restore fails (#157566) 
Fixes #155493
 2022-08-09 09:55:40 +02:00
ChaseKnowlden 19d0675506
Add offline_access to list of default scopes (#157453) 
Add a new scope to default scopes
 2022-08-08 14:55:13 -07:00
Michael Lively 9225503c85
Support for pasting images into markdown notebook cells (#156847) 
* dataflow support for updated metadata

* update cellAttachmentRenderer.ts to reflect metadata being a getter() inside MarkupCell

* document paste additions

* update condition to re-render cells, now includes metadata changes

* paste API working, debugging command added

* paste working with metadata. needs numbering, and cleaning upon delete

* paste screenshot works fully

* remove debugging command. Cleaning.

* notebook cells now re-render upon metadata changes

* changed name validity checking, remove unneeded function

* use _document for cell data, use snippet choice, dto fix

* return subscription, for loop, uri fix, alter metadata in-place, better snippet

* metadata fix, object.equals, fix cellAttRenderer metadata call

* added comment with source of encodeBase64

* gate mkdn image paste behind experimental setting
 2022-08-08 13:57:49 -07:00
Matt Bierner 0103536a60
Apply editor-font-family to all code in notebooks (#157554) 
Apply editor-font-family to all `code` in notebook

Fixes #146696

This matches what we do in the markdown preview
 2022-08-08 20:59:16 +02:00
Tyler James Leonhardt d8453c0440
Rev built-in versions of vscode-nls to 5.1.0 (#157530) 
* rev version of vscode-nls to 5.1.0

* and yarn lock
 2022-08-08 18:43:45 +02:00
Tyler James Leonhardt 49394cc44d
Enable translations for extension code for the web (#155355) 
* Initial attempt

* alex feedback
 2022-08-08 09:11:16 -07:00
Rob Lourens 8671778f8d
Fix notebook execution test failures (#157290) 
* Fix notebook execution test failures
An error thrown in an event handler did not cause the test to fail, using DeferredPromise. Adjusting the api event to account for Unconfirmed vs Pending states. And accounting for onDidChangeNotebookDocument being fired multiple times during a test, causing the test to complete early while execution was still happening.
Fixes #157067

* Remove log
 2022-08-05 11:07:20 -07:00
Benjamin Pasero 73fd3f1103
fix build (#157217) 
* fix build

* fix compile

* flaky

* .
 2022-08-05 09:16:20 +02:00
Matt Bierner 07e45c5a71
Fix package version (#157202) 
Not sure why this was not caught by earlier builds
 2022-08-04 21:40:06 -07:00
Matt Bierner b012216211
Fix markdown images having duplicate ids (#157177) 
Fixes #153144
 2022-08-05 06:31:42 +02:00
Tyler James Leonhardt d859b334cb
We only need to wait on the input box for un-supported environments (#157157) 
we only need to wait on the input box for un-supported environments
 2022-08-04 23:55:51 +02:00
Matt Bierner c5f857f0cf
Remove skipped webview tests (#157155) 
Fixes #153066

It's unclear what is causing these to occasionally fail in CI but keeping around these skipped tests is not useful
 2022-08-04 23:49:05 +02:00
Matt Bierner 68912bd844
Use 'import type' for '@jupyterlab/nbformat' (#157153) 
This is a type only dev dep so we should prevent referencing it as a value
 2022-08-04 23:46:53 +02:00
Matt Bierner 0c78644c6e
Use tabs to figure out when to report JS/TS diagnostics (#157117) 
Fixes #101885

We currently only want to report diagnostics for opened JS/TS files
 2022-08-04 10:46:56 -07:00
Raymond Zhao 9f80085795
Fix language-specific tab expansion and polish (#157035) 
* Fix language-specific tab expansion and polish

Fixes #156075

* Add back check
 2022-08-03 16:31:19 -07:00
Peng Lyu 5d4730dbec
Merge pull request #157029 from microsoft/rebornix/notebook-no-test-skip 
No skip tests in notebook api/kernel
 2022-08-03 14:48:09 -07:00
rebornix 336373dfc5
bring back kernel execute test 2022-08-03 10:14:45 -07:00
rebornix 82314b9ed5
remove outdated test 2022-08-03 10:08:02 -07:00
Michael Lively 61e8687fa3
Notebook Cells re-render upon changes to metadata (#156917) 
* dataflow support for updated metadata

* update cellAttachmentRenderer.ts to reflect metadata being a getter() inside MarkupCell

* update condition to re-render cells, now includes metadata changes

* notebook cells now re-render upon metadata changes

* fix missing metadata update

Co-authored-by: Peng Lyu <penn.lv@gmail.com>
 2022-08-03 09:46:12 -07:00
Matt Bierner 784de60319
Add activeWebviewPanelId context key (#156944) 
Fixes #156942

This context tracks the id of the active webviewPanel
 2022-08-03 07:03:33 +02:00
Peng Lyu 7833aade5a
Separate notebook kernel and api test (#156946) 
* Separate notebook kernel and api test.

* no need to test reopen dirty document
 2022-08-03 07:03:10 +02:00
Peng Lyu 418b944396
debt: move insert command towards unit tests. (#156929) 2022-08-03 01:42:53 +02:00
Matt Bierner 8b27dcb1f8
Pick up latest markdown language service (#156933) 2022-08-02 23:31:58 +02:00
Peng Lyu 4b551dab35
Turn on notebook document test. (#156932) 2022-08-02 23:20:00 +02:00
John Murray 7e400c7137
Provide valid markdown-specific default for editor.quickSuggestions setting (#156686) (#156689) 
Co-authored-by: Matt Bierner <matb@microsoft.com>
 2022-08-02 13:51:41 -07:00
Matt Bierner e3267b75c6
Fix onDidDeleteMarkdownDocument not hooked up (#156913) 2022-08-02 22:18:08 +02:00
Matt Bierner 1097f3e440
Use finalized vscode-languageserver version (#156910) 
Use finalized vscode-languageserver build
 2022-08-02 15:51:07 -04:00
Matt Bierner 3a5a458643
Clear markdown diagnostics when file is closed (#156912) 2022-08-02 20:32:02 +02:00
Matt Bierner 424fe151f1
Add patch for enabling new TS plugins on web approach (#149186) 
* Add patch for enabling new TS plugins on web approach

https://github.com/microsoft/TypeScript/pull/47377

To run plugins on web, we need to shim out `dynamicImport`. This is done in a file call `tsserverWeb.js`, which is added by the linked PR

* Update for new files names
 2022-08-02 20:00:22 +02:00
Peng Lyu fded572606
Re #155587. Move undo/redo to unit tests. (#156849) 2022-08-02 09:28:37 +02:00
Tyler James Leonhardt 13066d79e3
up timeout to 5min (#156846) 2022-08-01 17:15:52 -07:00
Matt Bierner cf43717e18
Pick up new md grammar (#156844) 
Also updates themes to better handle https://github.com/microsoft/vscode-markdown-tm-grammar/issues/4
 2022-08-01 17:13:55 -07:00
Matt Bierner f0434c0960
Pick up TS 4.8 for JS/TS extension (#156828) 2022-08-01 13:59:07 -07:00
Peng Lyu f31a88e161
Remove move cell integration test (#156825) 
* Remove move cell integration test

* 💄

* test didn't really run locally
 2022-08-01 16:54:49 -04:00
Peng Lyu f4433141c7
Move off asPromise (#155920) 
* Troubleshoot asPromise

* Update batch edit api

* Update workspace edit

* fix #156663

* 💄
 2022-08-01 21:09:41 +02:00
Matt Bierner 97c8a97261
Include globally enabled TS Server plugins when reporting issues (#156510) 
We're seeing a lot of crashes caused by TS Server plugins (usually those that come from extension). This will be easier to track down if we also include the enabled plugins when reporting issues
 2022-08-01 10:44:46 -07:00
Matt Bierner 4eef7a94e1
Tell users about enabled TS plugins on crash (#156514) 
We've been seeing a fair number of reported issues about TS Server crashes that are caused by plugins contributed by extension. This change adds info to the error message about enabled global plugins so users can try disabling them

Other changes:

- Use `JS/TS` instead of Typescript since the server is used for javascript too (a common source of confusion)
- Fix some missing checks to `_isPromptingAfterCrash` and some extra guards that were causing some crashes to now show this message
- Use `crashed` instead of `died unexpectedly`
 2022-08-01 10:44:33 -07:00
Babak K. Shandiz 2150470804
🎁 Add option to disable script hovers in package.json files (#156752) 
* ⚙️ Define `npm.scriptHover` configuration parameter

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🌐 Add localized description for `npm.scriptHover` config parameter

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🎁 Respect `npm.scriptHover` config parameter in `NpmScriptHoverProvider`

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
 2022-08-01 09:43:31 -07:00
Alex Ross 12b08be500
Only use the commit in share link when upstream (#156658) 
Fixes #156627
 2022-07-29 12:30:05 +02:00
Michael Lively 6fbee10cc1 more checking for undefined objects, fixed bug casuing markdown renderer to entirely crash 2022-07-28 11:53:51 -07:00
Tyler James Leonhardt 4017fd126f
Show quick pick when redirect fails to complete redirect to be more robust (#156515) 
* show quick pick when redirect fails to complete redirect to be more robust

* matt feedback
 2022-07-28 10:26:18 -07:00
Matt Bierner 06f8d52e37
Always log on tsserver exits (#156495) 
This ensures we also log if the TS Server exits with no code but a valid signal. Useful for figuring out how many users are hitting OOM errors
 2022-07-27 12:58:52 -07:00
Matt Bierner 00bb9bdefc
Always log tsserver exit code, even for kill processes (#156378) 
We suspect that some exit code info is being dropped since 1.61. Changing this code to always log, even when the user manually restarts the server
 2022-07-27 11:54:24 -07:00
Martin Aeschlimann 857412ab10
devcontainer schema: handle deprecated properties (#156425) 2022-07-27 20:27:47 +02:00
Alex Ross a3b712e04e
Create a insiders.vscode.dev link when I use insiders for sharing (#156436) 
Fixes #156255
 2022-07-27 10:55:08 -04:00
Matt Bierner 241c770203
Exclude esbuild files from build (#156362) 2022-07-27 09:32:07 -04:00
Ladislau Szomoru d01945923c
Git - Fix regression with Commit action button icon (#156417) 
Fix regression with Commit action button icon
 2022-07-27 13:11:07 +02:00
Ladislau Szomoru e210bbfea4
Git - fix edge case during rebase (#156410) 
Fix blocking issue while resolving conflicts during rebase
 2022-07-27 12:03:47 +03:00
Matt Bierner 9cf2fabdd6
Rename editor.dropIntoEditor.enabled setting (#156381) 
Fixes #156344
 2022-07-27 06:44:44 +02:00
Michael Lively 53c3028c47 add notebook-out to .gitignore 2022-07-26 12:29:23 -07:00
Michael Lively 2077ae5120 fix package.json/esbuild.js for files in publish 2022-07-26 12:19:27 -07:00