Commit graph

13315 commits

Author SHA1 Message Date
aamunger 888fd835ca
don't clean attachments for a cell that is removed 2022-11-17 10:16:13 -08:00
Ladislau Szomoru dff6f568a1
GitHub - fix dialog when user does not have permissions to commit (#166595) 2022-11-17 07:36:54 -08:00
Babak K. Shandiz 9f56e365d7
🎁 Add killOnServerStop to debug configuration (#163779)
* 🎁 Add `killOnServerStop` to schema

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 📜 Add description for `killOnServerStop`

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Stop created debug session on server stop

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Push kill listeners into another disposable container

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🐛 Prevent leak when new debug session fails to start

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Use more verbose name for debug session tracker ID

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2022-11-17 06:20:08 -08:00
Alex Ross 328ed10651
Git drop stash commands should use modal dialog (#166573)
Since the warning is initiated through user action, and the user is required to interact with the warning to finish their intended action we should use a modal dialog here.
2022-11-17 12:49:56 +01:00
Aaron Munger 5588a85039
Merge pull request #166512 from amunger/integrationTest
Don't rely on notebook focus when adding cells
2022-11-16 14:58:30 -08:00
Matt Bierner 838b48504c
Pick up TS 4.9 final (#166509) 2022-11-16 14:16:36 -08:00
aamunger 2deaa43aa6
specify notebook document 2022-11-16 14:01:31 -08:00
Greg Van Liew 816f31f691
More settings description tuning (#166429) 2022-11-16 09:33:33 -08:00
Johannes Rieken 3ffb834054
Merge branch 'main' into joh/rewrite-privates 2022-11-16 10:20:49 +01:00
Benjamin Pasero f176ad8e28
workspace.applyEdit drops the TextEdit if there is a RenameFile later #77735 (fix #166436) (#166439) 2022-11-16 09:43:07 +01:00
Matt Bierner 5452c6af10
Eagerly delete diagnostic on quick fix (#166417)
Fixes #166415
2022-11-16 07:43:28 +01:00
Matt Bierner edccbd1307
Pick up latest markdown language server (#166404)
Also removes some duplicated files
2022-11-15 18:27:22 -08:00
Matt Bierner 7d6c575031
Check cancellation token earlier and avoid capturing resolve (#166416) 2022-11-15 16:33:01 -08:00
Matt Bierner d0d28a6295
Reapply building of web server (#166391)
* Reapply building of web server

Revert 8b4642ab23

* Fix critical dep error
2022-11-15 14:55:40 -08:00
Matt Bierner 04ef3dad8f
Adopt @vscode/l10n for markdown language server (#165880) 2022-11-15 22:56:12 +01:00
Matt Bierner 4fdcdb17c6
Pick up latest jsonc parser (#166334) 2022-11-15 13:46:52 -08:00
Matt Bierner 7e62f31610
Pick up latest esbuild and parcel for building extensions (#166389)
Pick up latest esbuild for extensions
2022-11-15 11:08:45 -08:00
Henning Dieterichs b11207c539 Revert "Copy webServer from Typescript to VS Code (#165771)"
This reverts commit cb43019d6a.
2022-11-15 14:45:32 +01:00
Johannes 5912ad3ff1
Merge branch 'main' into joh/rewrite-privates 2022-11-15 09:44:34 +01:00
Matt Bierner 44441de137
Adopt prefer-readonly in JS/TS extension (#165089) 2022-11-14 20:12:10 -08:00
Matt Bierner 3684289a70
Enable onlyCompileBundledFiles
This prevents ts-loader from loading desktop files for web builds
2022-11-14 16:45:30 -08:00
Matt Bierner 0b9121953f
Added mangling loader for ts files in extensions 2022-11-14 16:34:04 -08:00
Greg Van Liew 27a550f451
Settings description edits (#166315)
* Settings description edits

* Remove unnecessary trailing line returns
2022-11-14 13:47:54 -08:00
Robert Jin fbaacfb921
Add explorer.autorevealExclude setting (#136905)
* Add explorer.autorevealExclude setting

* Update setting name, only check sibling once

* linting

* Correct boolean order and add catch for force reveal

* Check for force instead of converting

* Do not make revealexcludes inherit from file.excludes

* Linting
2022-11-14 15:50:55 -05:00
Tyler James Leonhardt fd7e27f9d3
onboard built-in debug extensions to l10n (#166300) 2022-11-14 11:03:54 -08:00
Nathan Shively-Sanders cb43019d6a
Copy webServer from Typescript to VS Code (#165771)
* Initial draft.

Not working.
Also not correctly formatted, I'll do that later.

* Various fixes

It works now

* A bit of cleanup

* Move webServer to its own directory

And prepare for getting rid of dynamicImportCompat.js hack

* Remove dynamicImportCompat.js hack

* Revert unrelated change

* Webpac tsserver.web.js with webServer.ts as entrypoint

Instead of using CopyPlugin.

1. Shipping multiple entrypoints in a single file required fixes to
build code.
2. There are a couple of warnings from `require` calls in
tsserverlibrary.js. Those are not relevant since they're in non-web
code, but I haven't figured how to turn them off; they are fully dynamic
so `externals` didn't work.

* Ignore warnings from dynamic import in tsserver

* Add to .vscodeignore files
2022-11-14 10:56:31 -08:00
Logan Ramos 73d882bcf7
Update telemetry package (#166292) 2022-11-14 09:30:33 -08:00
Ladislau Szomoru 687514b9f4
Git - Fix optimistic UI update for untracked changes (#166277) 2022-11-14 06:24:14 -08:00
Ladislau Szomoru b3eaceaf90
Git - 💄 Remove code duplication (#166263)
💄 Remove code duplication
2022-11-14 11:53:46 +01:00
Matt Bierner a62879bb46
Try computing windows paths correctly on markdown drop (#166077)
Fixes #165352
2022-11-13 15:03:05 -08:00
Ladislau Szomoru b4fbff3218
Git - Don't show progress for commands that support optimistic UI updates (#166124)
Don't show progress for commands that support optimistic UI updates
2022-11-11 08:11:41 -08:00
Ladislau Szomoru 9984da1a19
Git - Optimistic UI update for discarding changes (#166099)
Optimistic UI update for discarding changes
2022-11-11 02:25:01 -08:00
Matt Bierner ca15dea96b
Pick up latest dompurify and typings for vscode-markdown-languageservice (#166062)
Pick up latest typings from vscode-markdown-languageservice
2022-11-10 21:58:16 -08:00
Tyler James Leonhardt ef415578d1
Take advantage of platform features in Microsoft Authentication extension (#166066) 2022-11-10 18:26:48 -08:00
Matt Bierner 1ccc8d438b
Enable pasting of image attachments by default for ipynb (#166058)
Fixes https://github.com/microsoft/vscode-jupyter/issues/11987
2022-11-10 16:46:31 -08:00
Ladislau Szomoru 8fd500ed74
Git - Add calcellation support for getRefs (#165938) 2022-11-10 12:25:53 -08:00
Marina Miyaoka aa37e17423
Do not preprocess Unicode newlines in Markdown preview (#166026)
Revert LS PS preprocessing in Markdown preview
2022-11-10 19:46:43 +00:00
Sandeep Somavarapu d2441c5e3a
rename to Profile (#166030) 2022-11-10 13:25:07 -05:00
Ladislau Szomoru 624f4ac076
Git - Tweak git config parser (#166022)
Tweak git config parser
2022-11-10 18:04:35 +01:00
Ladislau Szomoru b149a6de63
Git - Improve branch publish prompt (#165949) 2022-11-10 15:20:27 +01:00
Ladislau Szomoru b4eaea6bc6
Git - get remotes from the config file (#165909) 2022-11-10 14:35:43 +01:00
Tyler James Leonhardt b9b93f2b45
Depend on platform implementations for common features (#165950)
* don't depend on externals

* remove unneeded externals
2022-11-09 14:29:21 -08:00
Debayan Ganguly 54543cf5bf
Fix: New md file scrolls to Top. (#164999)
Fixes #164071.
2022-11-09 13:48:39 -08:00
Sandeep Somavarapu 2cd8ea24f2
#159892 Finalize (#165925) 2022-11-09 10:28:27 -05:00
Logan Ramos bf1697d98c
Consume proposed telemetry API (#165862)
* Consume proposed telemetry API

* Update webpack
2022-11-08 21:58:28 -05:00
Rob Lourens 6aa5ca4c28
Add launch/task variable completions to workspace file (#165842)
Fix #164728
2022-11-08 10:05:55 -08:00
Martin Aeschlimann afac9524b6
[css/json/html] move to l10n (#165725)
[css/json/html] move to l10n (for #164438)
2022-11-08 07:32:38 -08:00
Ladislau Szomoru 57a5507e0b
Git - Tweak optimistic update (#165815)
Tweak optimistic update
2022-11-08 15:44:24 +01:00
Ladislau Szomoru 4130136c25
Git - Stage/Unstage optimistic UI updates (#165716) 2022-11-08 14:29:54 +01:00
Ladislau Szomoru 348a6585c7
Git - Show progress while doing the initial repository discovery (#165695)
Show progress while doing the initial repository discovery
2022-11-08 14:29:37 +01:00
Joyce Er 2282be522a
Fix edit session partial matches (#165782) 2022-11-07 20:56:53 -08:00
Matt Bierner 5d04c3b06c
Don't assume file paths in tsconfigs (#165779)
Fixes #160979
2022-11-07 20:24:31 -08:00
Matt Bierner 46caa3b490
Exclude @ from word pattern in js/ts (#165764)
Fixes #162862

#148874 Still seems to be working too after this change
2022-11-07 15:53:11 -08:00
Ladislau Szomoru d3611df987
Git - Optimistic UI updates for rebase continue (#165699)
Optimistic UI updates for rebase continue
2022-11-07 15:15:56 +01:00
Ladislau Szomoru 08baa8abb4
Git - Only use this.dotGit when resolving HEAD (#165497)
Fix #164363
2022-11-04 23:15:42 -07:00
Raymond Zhao 7f3a7edf0f
Localize emmet using l10n.t (#165568)
Ref #164438
2022-11-04 17:42:01 -07:00
Matt Bierner 3c874be287
Fix UI string (#165554) 2022-11-04 14:04:58 -07:00
Matt Bierner 952bbb6720
Adopt l10n for npm package (#165527)
For #164438
2022-11-04 13:56:39 -07:00
Matt Bierner ac26690ed8
Adopt l10n for grunt and php-language-features (#165552)
* Adopt l10n for grunt

For #164438

* Adopt l10n for php-language-features

For #164438
2022-11-04 13:50:21 -07:00
Matt Bierner 6ef8bb8a6a
Adopt l10n for gulp (#165543)
For #164438
2022-11-04 12:34:59 -07:00
Matt Bierner e8fa3e41f0
Adopt l10n for jake (#165541)
For #164438
2022-11-04 12:21:19 -07:00
Matt Bierner 8a37410ce2
Adopt l10n for extension-editing (#165523)
For #164438
2022-11-04 12:04:47 -07:00
Matt Bierner cdc521af16
Adopt l10n for merge-conflict (#165531)
For #164438
2022-11-04 11:26:04 -07:00
Matt Bierner 3ca015cebd
Adopt l10n for simple-browser (#165529)
For #164438
2022-11-04 11:15:23 -07:00
Matt Bierner 10dc1a34b5
Adopt l10n for media-preview (#165525)
For #164438
2022-11-04 10:57:02 -07:00
Logan Ramos eafc1e0fe1
Remove overzealous telemetry (#165524) 2022-11-04 10:47:35 -07:00
Matt Bierner 2d8202551e
Adopt l10n for configuration-editing (#165521)
For #164438
2022-11-04 10:46:09 -07:00
Ladislau Szomoru b208b8794d
Git - Optimistic UI plumbing (#165237) 2022-11-04 04:52:28 -07:00
Ladislau Szomoru f60ff405f4
Git - Add "OK, Don't Ask Again" button to the publish branch prompt (#165487)
Add "OK, Don't Ask Again" button to the publish branch prompt
2022-11-04 12:41:17 +01:00
Matt Bierner 0bd1531e00
Adopt l10n for ts extension (#165450)
For #164438

Also refines the eslint rule from #165448
2022-11-04 09:50:18 +01:00
Matt Bierner cd29f751eb
Adopt l10n for markdown extension (#165448)
For #164438

Also makes our eslint rules understand `vscode.l10n.t(`
2022-11-04 09:49:49 +01:00
Joyce Er 6199d0e9df
Improve file dialog action button (#165417)
* Improve file dialog action button

* `Location` -> `Destination`
2022-11-03 13:34:43 -07:00
Johannes Rieken e8eb39bac2
debt: move or remove NullXYZServices (#165397)
We have a few NullXYZServices. Those are useful for testing but we should move them to separate files so that we don't end up shipping them with the product
2022-11-03 10:52:14 -07:00
Ladislau Szomoru e3d7e621f2
Git - Remove localization from askpass-main (#165129)
Remove localization from askpass as it runs in a separate process
2022-11-03 09:35:45 -07:00
David Dossett 2da60fd58b
Update quick pick placeholders and/or remove titles (#165267) 2022-11-02 15:43:18 -07:00
Johannes Rieken ba9be48390
adopt vscode.l10n in references view (#165245)
https://github.com/microsoft/vscode/issues/164438
2022-11-02 08:21:33 -07:00
Ping 7fbec6dcc9
Fix KaTeX equation numbering in notebook preview (#156276)
Fixes https://github.com/microsoft/vscode/issues/155888
2022-11-02 01:09:32 -07:00
Matt Bierner 7233e19dd5
Remove notebook content provider api (#165195)
Fixes #160580
Fixes #147248
2022-11-01 17:23:32 -07:00
Matt Bierner c6559ccf21
Pick up TS 4.9 rc for bundled VS Code version (#165205) 2022-11-01 16:39:15 -07:00
Matt Bierner 8ad43669a9
Prompt users to test with extensions disabled (#165203) 2022-11-01 16:38:45 -07:00
Hugh Lilly 190db489e0
Markdown lang preview settings description (#165109)
* Change descriptions to just say “Enable…”

Previously these said “Enable or disable…”, which in the context of a tick box doesn’t make sense.

* Change “Enable/disable” wording in descriptions
2022-11-01 15:48:59 -07:00
Sandeep Somavarapu fe882ab334
api feedback (#164470)
* api feedback
- remove critical log level
- move log level off to be 0

* handle off log level

* fix disabling log level in tests

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
2022-11-01 10:41:19 -04:00
Alex Ross ceaf7a431b
Update grammars (#165100) 2022-11-01 07:21:34 -07:00
João Moreno 18f1101f70
skip flaky test (#165150)
* skip flaky test

related to #165149

* skip the entire suite
2022-11-01 06:26:44 -07:00
Matt Bierner 4bf630f00e
Pick up latest markdown language service (#165093) 2022-10-31 19:52:21 -07:00
Matt Bierner 33867c55f3
Adopt prefix private with _ in markdown extension (#165088) 2022-10-31 14:22:39 -07:00
Matt Bierner b97827dacf
Adopt notebook serializer for notebook document tests (#165081)
For #160580

Also remove one test that is no longer relevant
2022-10-31 12:56:40 -07:00
Tyler James Leonhardt 9b3e147d6d
GitHub Enterprise Auth improvements (#165082)
1. Namespace secrets based on the value of github-enterprise.uri to support "multiple separate GHES instances"
2. If the setting value disappears, continue using last set value. Fixes https://github.com/microsoft/vscode-pull-request-github/issues/3992
3. Mark github-enterprise.uri as requires trust
3. Refactoring like:
  * UriHandler is handled in extension.ts and passed down everywhere since we can only have 1 instance of it
  * misc style (`private` usage, better `disposable` handling)
2022-10-31 12:18:54 -07:00
Matt Bierner c60980ca7a
Adopt notebook serializer for test (#165078)
For #160580
2022-10-31 12:01:38 -07:00
Matt Bierner ef5671a46f
Pick up latest TS for VS Code (#165075) 2022-10-31 11:42:11 -07:00
Henning Dieterichs 6800f96aad
Merge pull request #165051 from microsoft/hediet/nearby-worm
Implements #164686
2022-10-31 18:57:46 +01:00
David Dossett 2e7c0662c3
Updates custom menu borders and item styles (#164165)
Updates menu item margin and radius and adds border to default themes
2022-10-31 10:27:56 -07:00
Henning Dieterichs d27d0c28e2
Implements #164686 2022-10-31 14:54:57 +01:00
Henning Dieterichs 50b1bccd17
Remove inlineCompletionsNew proposal. Fixes #164856 (#165044) 2022-10-31 13:29:04 +01:00
João Moreno 53ef06a2dc
bump unique names generator (#165015) 2022-10-31 08:25:51 +01:00
Matt Bierner 3e407526a1
Pick up latest markdown LS (#164945)
Picks up https://github.com/microsoft/vscode-markdown-languageservice/pull/84
2022-10-29 11:40:56 -07:00
Matt Bierner 7cb1b9d9f0
Fix bugs with close of markdown docs (#164942)
There are two bugs here:

- Something in the lsp is converting a value from `undefined` to `null`. To fix this, I've updated us just to check for falsy values instead
- The `hasInMemoryDoc` implementation was incorrect. It needs to verify that the value of `this.inMemoryDoc` is not null/undefined
2022-10-29 02:08:21 +02:00
Ladislau Szomoru 67b8c25157
Commit Action button polish (#164746) 2022-10-28 15:23:19 +02:00
Ladislau Szomoru f09c4124a2
Engineering - adopt l10n for git-base/git/github extesions (#164566)
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
2022-10-28 11:27:08 +02:00
Matt Bierner 12ada73bf9
Disable markdown insert link commands in readonly editors (#164820)
Disable insert link commands in readonly editors
2022-10-27 23:52:05 +02:00
Matt Bierner 3544aabd5a
Fix markdown document deleting (#164829)
Fixes #164562

My previous fix was incorrect as it checked if the document existed by still consulting our `_documentCache`. When we are deleting/renaming an opened md document, it should pretty much always exist in our cache

The fix is to instead treat `this.documents` and the file system as the source of truth when determining if the doc should be deleted or not
2022-10-27 21:49:05 +02:00
Matt Bierner 0570a7678d
Use posix path for markdown links (#164822)
Fixes #164782
2022-10-27 19:21:03 +02:00
Rob Lourens 98f401e8b9
Fix .ipynb extension name capitalization (#164817)
Towards microsoft/vscode-jupyter#11773
2022-10-27 18:05:28 +02:00
Alexandru Dima 0f2285c3e9
Don't ship yarn.lock file with the markdown extension (#164794) 2022-10-27 12:09:38 +02:00
Matt Bierner 1316bf789f
Rework markdown update link glob (#164766)
* Rework markdown update link glob

Fixes #164587

This changes the `externalFileGlobs` setting to instead be a include array of globs that should trigger link updates. I've split the globs into markdown files and image/video files

This also makes it easier for users to add their own new globs to the list

* Fix scopes
2022-10-27 01:45:45 +02:00
Matt Bierner d2f8ae6cce
Clean up a few markdown setting descriptions (#164765)
Clean up wording and make sure we use `Markdown` uppercase
2022-10-26 16:29:06 -07:00
Matt Bierner d1af68711d
Pick up latest markdown LS (#164763)
Includes a few more fixes for link update on rename
2022-10-27 00:39:58 +02:00
Matt Bierner 7060fb81dd
Shorten markdown link button titles (#164764)
Fixes #164556
2022-10-27 00:39:30 +02:00
Matt Bierner 5f87632829
Fix markdown server not updating documents properly on folder rename (#164752)
Fixes #164562
2022-10-26 14:48:20 -07:00
w1redch4d 70328b1b48
fix problems with html style comments in embedded code (#160981)
* fix problems with html style comments in embedded code

* add spacings to the replaced characters

add same amount of characters, in the replacements so that all offsets stays the same

* revert javascriptMode.ts

* add replace characters in embeddedSupport.ts instead

* added few more tests with javascript

more testcases with js code before and after the comments

* polish

Co-authored-by: UwUeeb <106700035+UwUeeb@users.noreply.github.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-10-26 08:41:05 +00:00
Matt Bierner a887d72e8d
Pick up latest markdown language service (#164655) 2022-10-25 16:46:53 -07:00
Joyce Er 812c9bedf2
Fix cloning with specific branch (#164619) 2022-10-25 15:27:41 -07:00
Matt Bierner f5cbe7e391
Use dirname as default uri for md links (#164641)
Fixes #164612
2022-10-25 21:59:20 +02:00
Matt Bierner 882cdc0a17
Use newlines to separate inserted images (#164632)
Fixes #164610
2022-10-25 12:21:36 -07:00
Matt Bierner 21431fce38
Disable canSelectFolders in markdown link inserter (#164636)
Fixes #164549
2022-10-25 12:01:08 -07:00
Matt Bierner 3ca4fca56e
Pick up latest markdown language service (#164625)
This failed yesterday due to a cache issue in dev ops. We need this version for testing
2022-10-25 10:52:57 -07:00
Matt Bierner 586f252740
Revert "Pick up markdown language service update (#164524)" (#164533)
This reverts commit ab3926ab48.
2022-10-24 19:09:08 -07:00
Matt Bierner ab3926ab48
Pick up markdown language service update (#164524)
Picking up one more small update before endgame
2022-10-24 16:53:17 -07:00
Matt Bierner 9f5d3eb135
Pick up latest markdown language service and clean up server package (#164516)
- Picks up newest markdown language service
- Excludes some files from server publish
- Delete unused file
- Update readme
- Align server version with LS version
2022-10-24 15:58:45 -07:00
Matt Bierner babb2f9677
Remove experimental tag from markdown settings (#164509) 2022-10-24 14:44:43 -07:00
Matt Bierner 4eef476a4f
Remove old notebook editor api proposal (#164504)
All consumers should now be on the finalized api

Fixes #151661
2022-10-24 14:40:53 -07:00
Connor Peet beed9ac381
debug: activate auto launch onStartupFinished (#164481)
For https://github.com/microsoft/vscode-internalbacklog/issues/3209

We still need to activate it for every workspace, but since Daniel's
improvements to environment variable application a few months ago, using
onStartupFinished should be pretty safe and seamless.
2022-10-24 11:25:22 -07:00
Ladislau Szomoru 7bd27b4287
Git - getSCMResource() should also look at the merge group (#164450)
getSCMResource() should also look at the merge group
2022-10-24 06:27:56 -07:00
Ladislau Szomoru 566e71b346
Revert "Git - parse config file for remotes (#164151)" (#164433)
This reverts commit 798cd3bcac.
2022-10-24 13:28:06 +02:00
Joyce Er 7318c90996
Checkout specific branch during clone operation (#163705) 2022-10-23 20:23:35 +02:00
Tyler James Leonhardt 0091bcae20
Fixes #164073 (#164384)
Fixes #164073
2022-10-23 17:47:27 +02:00
Matt Bierner b11bb04298
Add optional markdown occurrences highlighting (#164292)
Fixes #164290
2022-10-21 14:19:50 -07:00
Ladislau Szomoru 798cd3bcac
Git - parse config file for remotes (#164151) 2022-10-21 06:57:22 -07:00
Ladislau Szomoru d1c8746455
Git - Add operation start/end trace log (#164242)
Add operation start/end trace log
2022-10-21 14:29:54 +02:00
Matt Bierner 504c5a768a
Avoid extra html write on first markdown preview update (#164201) 2022-10-20 19:40:19 -07:00
Raymond Zhao 72a7d0f2e4
Add to emmet.triggerExpansionOnTab description (#164197)
Fixes #159111
2022-10-20 17:38:59 -07:00
Alex Ross cf4c9e469d
Update python grammar (#164191) 2022-10-20 15:45:17 -07:00
Raymond Zhao d9846c8e43
Remove resource scopes (#164158) 2022-10-20 13:51:17 -07:00
Ladislau Szomoru 9c76d66e69
Git - implement cancellation for updating the model (#163926)
* Initial implementation

* Polish implementation

* Add cancelled label in the output

* Revert change that is not needed

* Pull request feedback

* Dispose listener

* Port changes manually
2022-10-20 06:26:22 -07:00
Ladislau Szomoru 2fa61a14b8
Git - Extract querying for status so that it can run in parallel with the other operations (#163990) 2022-10-20 04:37:04 -07:00
Ladislau Szomoru 76191c7c75
Engineering - Remove proposal that has been finalized (#164127)
Remove proposal that has been finalized
2022-10-20 04:30:27 -07:00
Ladislau Szomoru c139361a3c
Git - catch exceptions while fast-forwarding a branch (#164128)
Fixes #163685
2022-10-20 04:30:10 -07:00
Jake Bailey b99cf7e41e
Ensure 'undefined' does not make it into tsserver.web.js (#164064) 2022-10-19 16:44:03 -07:00
Daniel Rosenwasser 182beb6ee4
Merge pull request #163498 from DanielRosenwasser/iconsForWalkthroughs
Allow walkthroughs to specify icons.
2022-10-19 11:26:51 -07:00
Matt Bierner 7f99b7c655
Remove references to finalized proposals in js/ts (#164040) 2022-10-19 13:23:48 -04:00
Matt Bierner 33378c2ec0
Fix organize imports (#164035)
Fixes #163994

This fixes the organize imports command (it was using the wrong id) and also cleans up the implementation
2022-10-19 09:27:41 -07:00
Andrew Branch 1fb956d2f5
[typescript-language-features] Add removeUnusedImports command (#161654)
* Add `removeUnusedImports` command

* Continue to send `skipDestructiveCodeActions` for older TS versions

* Expose Sort Imports and Remove Unused Imports commands

* Update localization keys

* Update for 4.9 protocol

* Proto must be type only import?
2022-10-18 09:00:16 -07:00
Logan Ramos 256aaf296b
Don't use @microsoft.com in source code (#163933) 2022-10-18 07:38:15 -07:00
Ladislau Szomoru d4773517f1
Git - Get HEAD details in parallel (#163756) 2022-10-18 09:42:07 +02:00
Alex Ross 42d99283fd
Use dotnet/razor-tooling repo for razor grammar (#163898) 2022-10-17 16:26:25 -07:00
Matt Bierner bad3dcca69
Fix insert image/link for untitled files (#163897) 2022-10-17 16:14:16 -07:00
Martin Aeschlimann c83eff40dd
Remove too many folding regions notification (#163854)
* Remove too many folding regions notification

* remove duplicate folding limit item for JSON/JSONC

* polish

* fix test
2022-10-17 14:42:02 -07:00
Matt Bierner 15c111eb21
Pick up latest katex (#163866)
Fixes #162379
2022-10-17 14:09:09 -04:00
Henning Dieterichs f1a27d7b8b
Recognize stash merge conflicts (#163680) 2022-10-17 07:42:07 -07:00
Ladislau Szomoru e1e7ce5d17
Git - adopt log output channel api (#163695) 2022-10-17 02:49:12 -07:00
Joyce Er f9a0fdeff2
Tolerate minor edit session identity differences (#163804)
Also add basic support for partial edit session identity matches
2022-10-16 23:51:51 -07:00
Matt Bierner 641046a11d
Add commands to insert images/links in markdown (#163706)
* Add commands to insert images/links in markdown

Fixes #162809

* Rename commands and allow passing in uris

* Support selecting many images/files
2022-10-14 16:05:36 -07:00
Matt Bierner 3b255af0cb
Pick up latest vscode-markdown-languageservice (#163681) 2022-10-14 11:46:24 -07:00
Tyler James Leonhardt 6684350a58
Onboard GitHub & Microsoft auth extensions to l10n (#163662)
* onboard github-auth completely to l10n

* onboard microsoft-authentication entirely on to l10n
2022-10-14 08:41:21 -07:00
Matt Bierner 186d3415a3
Use ??= in more places (#163594) 2022-10-13 14:59:35 -07:00
Jake Bailey 65a9097aa2
Remove forgoten reference to typescript/lib/protocol (#163585) 2022-10-13 13:15:13 -07:00
Sandeep Somavarapu 894aa9a7a7
Log improvements (#163532)
* - expose log level in the proposed api
- ability to set log level per logger

* fix tests
2022-10-13 03:48:52 -07:00
Daniel Rosenwasser a053a4d505 Allow walkthroughs to specify icons.
Useful for specifying icons *other* than those of the contributing extension.
2022-10-12 17:14:42 -07:00
Tyler James Leonhardt 2457d9eb46
Plumbing for desktop to pick up strings from language packs (#163494)
Web will come in the next PR (hence the TODO)

Also this includes the smallest translation change which will be the ultimate test that this is all working.
2022-10-12 17:08:27 -07:00
Jake Bailey 07b87405e7
Don't depend on typescript protocol.d.ts (#163365) 2022-10-12 16:03:07 -07:00
Suven-p 22ff985c19
Add multiple template parameters (#163191) 2022-10-12 14:06:19 -07:00
Matt Bierner b2d129c4e5
Fix ipv6 support for simple browser (#163374)
Fixes #158599

This correctly handles ipv6 uris, such as `http://[::]:3000`. In these cases, the brackets are required
2022-10-12 11:04:56 -07:00
Raymond Zhao bf220dd91e
Darken red colour in light theme for better contrast (#163335) 2022-10-12 08:47:13 -07:00
Ladislau Szomoru b43c281df2
Git - Attempt to parse HEAD file before invoking git.exe (#162572)
* Attempt to parse HEAD file before invoking git.exe

* Pull request feedback

* Pull request feedback

* More pull request feedback
2022-10-12 15:56:36 +02:00
Ladislau Szomoru 3992d5b9ab
Git - Show progress indicator while running fetch (#163425)
Show progress indicator while running fetch
2022-10-12 04:31:31 -07:00
Ladislau Szomoru 3e4df23350
Git- get commit input template in parallel with other operations (#163423) 2022-10-12 13:31:08 +02:00
Ladislau Szomoru 8c946e23f4
Git - Fix typo in setting description (#163400)
Fix typo in setting description
2022-10-12 09:12:39 +02:00
Jean Pierre 24b8eb0d54
Fixes simple browser webview is not reused if restored (#163389)
Fixes #163387
2022-10-11 20:59:54 -07:00
Rob Lourens cf47b76c63
Finalize notebookDebugOptions API (#163316)
* Finalize notebookDebugOptions API
Fix #147264

* Backcompat for the option from vscode-jupyter

* Undo comment

* Fix build
2022-10-11 20:25:51 -07:00
Matt Bierner e1a373defd
Finalize markdown link updating on file move (#163378)
Fixes #148146
2022-10-11 17:42:10 -07:00
Matt Bierner 6cf68a1f23
Remove .only and fix tests (#163376)
Fixes #162159
2022-10-11 17:41:13 -07:00
Matt Bierner d05d85a78b
Move html rewriting for old webviews to (#163367)
The `asWebviewUri` methods was introduced in VS Code 1.38. It's silly that we still force every single webview to pay the cost of trying to rewrite the old style uris we supported in very old versions of VS Code

Instead I've moved this logic into the extension host and disabled it for all extensions that target VS Code 1.60+ or newer. This means it never applies to internal webviews, notebooks, webview views, or custom editors (these public apis were all introduced after the switch to `asWebviewUri`)
2022-10-11 16:08:17 -07:00
Don Jayamanne 43957ccfe1
Compress streams in notebook outputs (#160946)
* Revert "Compress notebook output streams before rendering (#160667)"

This reverts commit 4230c22a08.

* Compress stream output items

* Minor perf improvements

* Misc

* Comments

* Added tests

* Merge issue

* More merge issues

* Misc

* Address code review comments
2022-10-11 14:43:46 -07:00
Tyler James Leonhardt 4322170fd8
comment is an array (#163348) 2022-10-11 13:39:12 -07:00
Joyce Er 7666d7acd4
Avoid * activating ipynb extension (#163325) 2022-10-11 10:53:07 -07:00
Sean McManus 3f2adbfe3e
Update language-configuration.json (#163182) 2022-10-11 09:23:42 +02:00
Alex Ross 5dfca53892
Try out a new razor grammar (#163212)
Part of #163149
2022-10-10 12:43:02 -07:00
jannisspeer b2d7afc634
Remove Snakefile from being classified as Python (#162749)
Update package.json

Co-authored-by: Alex Ross <alros@microsoft.com>
2022-10-10 21:32:26 +02:00
Alex Ross 23e6c032af
Start enforcing the tunnels API (#163187)
* Start enforcing the tunnels API

* Fix API test
2022-10-10 10:10:24 -07:00
Ladislau Szomoru d53074babf
Git - Fix Commit action button enablement regression (#163159)
Fix Commit action button enablement regression
2022-10-10 14:06:20 +02:00
Johannes Rieken 03f98efb75
fix Extract Telemetry step (#162832) 2022-10-06 06:17:12 -07:00
Johannes Rieken b2b7e0be6e
send telemetry about git-exec duration (#162731)
* send telemetry about git-exec duration

* measure spawn and exec
2022-10-06 04:04:35 -07:00
Matt Bierner bfb1a738d1
Fix markdown open preview opening duplicate preview (#162793)
This fixes the markdown 'open preview' command when used with `vscode.ViewColumn.Active` or `vscode.ViewColumn.Beside`
2022-10-06 09:50:10 +02:00
Matt Bierner 4991cf2112
Remove console.log (#162784) 2022-10-05 15:25:52 -07:00
Matt Bierner d47ae7a2e7
Pick up latest markdown language service version (#162777)
Fixes #162776
Fixes #162775
2022-10-05 15:08:51 -07:00
Matt Bierner 3ee9749b35
Remove extra enums (#162686)
`showMessage` returns the selected item, so we don't need to create an enum here and can instead used the returned items directly
2022-10-04 10:46:53 -07:00
Alex Ross fd4346210f
Update grammars (#162673) 2022-10-04 08:50:55 -07:00
Ladislau Szomoru d904014287
Git - fix commitInProgress context key (#162562)
Fix #154628
2022-10-03 15:02:24 +02:00
Christof Marti 85bf7f1d9b Update schema with new properties (microsoft/vscode-remote-release#7278) 2022-10-03 11:52:07 +02:00
Sandeep Somavarapu 029ed84d6d
Merge pull request #162423 from microsoft/aeschli/162332
IntelliSense in JSON keyboard shortcut editor doesn't work for non-default profiles
2022-10-03 10:27:05 +02:00
Ladislau Szomoru 9bc43c7f8a
Git - Rename git.fetchBeforeCheckout to git.pullBeforeCheckout (#162303)
Rename git.fetchBeforeCheckout to git.pullBeforeCheckout
2022-09-30 00:42:20 -07:00
Martin Aeschlimann 4e7be94149
IntelliSense in JSON keyboard shortcut editor doesn't work for non-default profiles 2022-09-30 09:24:35 +02:00
Matt Bierner feb3d2d205
Fix null ref in attachments check (#162396)
Fixes #162391

Also reduces use of `any`
2022-09-29 13:15:01 -07:00
Henning Dieterichs 46afa5b108
Fixes #162043 by renaming "Accept Merge" to "Complete Merge" (#162361) 2022-09-29 08:19:06 -07:00
Johannes Rieken a2fe848791
set git.mergeChanges context key for all repos, not just one (#162339)
fixes https://github.com/microsoft/vscode/issues/162224
2022-09-29 05:50:07 -07:00
Henning Dieterichs 6cba93633d
Merge pull request #162318 from microsoft/hediet/amused-whale
Fixes #162027
2022-09-29 12:21:52 +02:00
Martin Aeschlimann 320f338681
[html] Sytax Highlighting is way off with new line after event handler (#162319) 2022-09-29 12:19:36 +02:00
Henning Dieterichs c4359c2dab
Addresses #162112 (#162321) 2022-09-29 12:18:18 +02:00
Henning Dieterichs b29b217e36
Fixes #162027 2022-09-29 10:50:48 +02:00
Ladislau Szomoru 197bfd9088
Git - Use modal dialog after cloning a repository (#162306)
Use modal dialog after cloning a repository
2022-09-29 01:01:29 -07:00
Josh Abernathy d3e330e4da
Update devcontainer schema for customizations.codespaces.openFiles (#161637) 2022-09-29 00:02:29 -07:00
Matt Bierner cbb0a982fd
Pick up final markdown language service 0.1 release (#162256)
Just pulling in the stable release
2022-09-28 14:02:26 -07:00
6⭐ Sygna Suit Red-EX dd4d29dd8b
Update Python source highlighting example to be more idiomatic (#154013) 2022-09-28 11:29:18 -07:00
Matt Bierner 5296b0faf3
Add explicit "inherit" setting for fragments links (#162231)
Fixes #162129
2022-09-28 14:08:03 -04:00
Sandeep Somavarapu b3434bf251
Fix #161868 (#162148) 2022-09-28 03:28:32 -07:00
Ladislau Szomoru 7559012a34
Git protocol handler improvements (#162144) 2022-09-28 02:58:10 -07:00
Matt Bierner c2a2ad4f63
Rename image-preview extension to media-preview (#162093)
Fixes #162092

Also removes `aac` from the list of supported audio formats
2022-09-27 21:01:14 -07:00
Matt Bierner 4f0edb3fe7
Pick up latest TS 4.8.4 recovery (#162059) 2022-09-27 14:28:39 -07:00
Matt Bierner ca635a3cdf
Add playsInline to video (#162065)
We want the video to play in the editor, not go fullscreen
2022-09-27 14:28:22 -07:00
Matt Bierner b4600dab29
Fix audio mime type listing (#162063) 2022-09-27 13:39:05 -07:00
Harald Kirschner ea5b244abd
File snippets for HTML and PHP (#161881)
* Adding file snippets for HTML and PHP to start small.

* Adding TS
2022-09-27 08:15:57 -07:00
Alexandru Dima 29b8a1e27f
Run OSS tool (#161956) 2022-09-27 05:21:59 -07:00
Henning Dieterichs 42a198b98b
Merge pull request #160385 from thernstig/patch-1
Update Groovy extension language contribution
2022-09-27 14:07:49 +02:00
Martin Aeschlimann 06bd7ae776
[css] use findDocumentSymbols (#161847)
[css] use findDocumentSymbols. For #157356
2022-09-26 14:16:07 -07:00
Martin Aeschlimann 741fa37b10
[json/css/html] update services / deps (#161831) 2022-09-26 12:41:26 -07:00
Tyler James Leonhardt 29e985eca0
rev vscode-nls to version that doesn't ask for vscode-nls-web-data (#161819)
ref #161297
2022-09-26 11:10:54 -07:00
Matt Bierner b8a7485526
Fix markdown preview refresh from disk (#161800)
Fixes #149974
2022-09-26 09:49:53 -07:00
Martin Aeschlimann ae8cf2186e
The properties language uses a Java icon in the Seti theme (#161770)
The properties language uses a Java icon in the Seti theme. Fixes #158453
2022-09-26 07:31:08 -07:00
Trond Einar Snekvik 83248ce374
Default to config icon for the property language (#158454) 2022-09-26 07:00:07 -07:00
Gerrit Birkeland cace09d0eb
Add schema for typedoc.json to default jsonValidation (#157592)
Add schema for typedoc.json to default 
jsonValidation
2022-09-26 15:51:42 +02:00
Gerrit Birkeland 9ac5f48ff3
Add jsonc registration for TypeDoc config (#157362)
This is supported as of TypeDoc 0.23. Since it is more commonly used than ember-cli, seems reasonable to add it here.
2022-09-26 15:51:23 +02:00
Colen Garoutte-Carson 33787082be
Enable auto-close of multi-line comments in cpp (#160357) 2022-09-26 15:29:05 +02:00
Daniel Rosenwasser da506e9b8d
Tag existing events with experimentation info in typescript-language-features (#161463)
* Associate experiment info with existing telemetry.

* Move the ExperimentTelemetryReporter to its own file.

* Roughly copied the 'getPackageInfo' function from other extensions.

* Addressed code review feedback.
2022-09-23 15:18:57 -07:00
Henning Dieterichs d7ad82454e
Revert "Bracket support for #if and #endif in cpp" 2022-09-23 13:59:23 +02:00
Matt Bierner 2a4fb40a6e
Align list of supported tags in rendered markdown (#161544)
This expands the list of html tags we allow in markdown. To get this list, I've copied the list of tags from `markdownDocumentRenderer` into `dom` after  reviewing them

For #134514, I've also added `video` to the list of allowed tags
2022-09-22 18:25:48 -07:00
Matt Bierner 82c1bf86bf
Show better error when rename fails in md (#161525)
* Show better error when rename fails in md

* Pick up latest MDLanguage service
2022-09-22 16:27:25 -07:00
Matt Bierner 023930e3dc
Fix extra dot in pasted file names (#161434) 2022-09-21 23:29:21 +02:00
Matt Bierner 07a5d2749f
Allow _ in notebook markdown links (#161437)
Fixes #160853
2022-09-21 14:23:47 -07:00
Matt Bierner 17bb582b85
Finalize markdown diagnostics (#161427)
Fixes #146303

This moves the markdown diagnostic support out of `experimental` and to an official feature (however it remains off by default)
2022-09-21 12:20:25 -07:00
Alex Ross 1562a35c86
Indent using spaces 🤷‍♀️ (#161405) 2022-09-21 07:41:57 -07:00
Ladislau Szomoru ce7e388ef1
Git - Checkout command aria label now includes the branch name (#161385)
* Checkout command aria label now includes the branch name

* Pull request feedback
2022-09-21 07:10:52 -07:00
Alex Ross 8aa37f3c9b
Add group to copy vscode.dev link in share (#161400)
Part of #157722
2022-09-21 07:03:38 -07:00
Henning Dieterichs 40a262dc13
merge editor temp model (#161315)
Introduces hidden mergeEditor.useWorkingCopy setting,
implements reset when the merge editor opens
2022-09-21 16:02:50 +02:00
Matt Bierner 333754f29b
Better handle moves of multiple markdown links (#161354)
This makes the markdown language service handle moving/renaming multiple files instead of making multiple calls into the language service
2022-09-20 21:53:58 -07:00
Matt Bierner f25d47121b
Pick up newer vscode-tas-client version (#161344) 2022-09-20 13:52:29 -07:00
Matt Bierner a5f5a730d6
Fix hiding of image preview status bar items (#161278) 2022-09-20 13:49:03 -07:00
Daniel Rosenwasser 5cde74b767
Fix accidental case fallthroughs in experimentation services. (#161339) 2022-09-20 12:00:32 -07:00
Johannes Rieken c1b80f6402
Disable merge-conflict commands for 3wm-editor (#161304)
fixes https://github.com/microsoft/vscode/issues/159156
2022-09-20 13:50:21 +02:00
Rob Lourens 0e333cd799
Convert NotebookCellStatusBarItem test from integration test to unit test (#161274)
Fix #157828
2022-09-20 09:55:58 +02:00
Sandeep Somavarapu 35c7ee9d02
Support log output channels for extensions (#161249)
* introduce log api in extension context

* separate registering output vs log channel

* Separate extension log channels in show logs command

* add logging error to embedder logger

* show extension log in the extension editor

* configure log level per extension

* change the order of log entries

* introduce logger

* align with output chanel

* revert changes

* fixes
2022-09-19 09:03:41 -07:00
Matt Bierner d03f015931
Clean up structure of markdown extension (#161148)
- Move things related to the client under `client`
- Remove extra abstractions that are no longer used
- Add MdLanguageClient type
2022-09-19 07:16:45 +02:00
Matt Bierner f4bf1f30a2
Skip ul and ol when highlighting selected markdown element (#161139)
Fixes #155552

For lists, the outer ul/ol always has the same source line as the first element in the list. We should prefer using the first element in the list when highlighting the active line

This also fixes a bug where scroll sync would stop working if you added lines to the doc. This was caused by `lineCount` getting out of sync as the document is being updated. I've removed this state and made the reveal logic more robust instead
2022-09-19 07:16:06 +02:00
Matt Bierner a10bdfb49b
Allow underscores in rendered md headers (#161149)
Follow up from https://github.com/microsoft/vscode-markdown-languageservice/pull/49
2022-09-16 20:52:50 -04:00
Matt Bierner 4c9c3f628d
Pick up latest markdown language service (#161142) 2022-09-16 20:52:16 -04:00
Peng Lyu 6e8bc02be4
Cell attachment cleanup tool improvement in diff editor (#161132)
* Move attachment out of custom metadata, prep for attachment clean up in diff editor

* recover attachments from dirty notebook document

* Allow metadata to be restored when content changed/reverted in nb diff editor
2022-09-16 14:12:53 -07:00
Matt Bierner 7c3ea7ac06
Pick up TS 4.8.3 (#161126)
Picks up latest TS stable build
2022-09-16 10:22:13 -07:00
Martin Aeschlimann 724a088c68
update vscode-uri, fix links in untited (fixes #147788) (#161108) 2022-09-16 07:57:10 -07:00
Johannes Rieken 21a2eca3b7
The openMergeEditor command should check the active tab when it is called without an URI (#161072)
https://github.com/microsoft/vscode/issues/160924
2022-09-16 11:55:06 +02:00
Johannes Rieken 77309b33d4
add WorkspaceEditMetadata and use it for applyEdit, (#160996)
* add `WorkspaceEditMetadata` and use it for `applyEdit`,

https://github.com/microsoft/vscode/issues/112109

* fix compilo in tests

* workspace edits from updating paths are marked as refactoring fyi @mjbvz
2022-09-16 09:44:19 +02:00
Benjamin Pasero ec56dddd9f
tests - remove snippetWorkspaceEdit usage (#161043) 2022-09-16 00:34:30 -07:00