Commit graph

104494 commits

Author SHA1 Message Date
Joyce Er 05e1981145
Lint redundant package.json activation events (#171297) 2023-01-16 09:28:19 +01:00
Benjamin Pasero 8be8d96ab8
perf - log startup timings in web same as desktop (#171310) 2023-01-15 15:26:36 +01:00
Sandeep Somavarapu 5e4c5c7812
adopt pinned version (#171290)
support pinned version
- settings sync
- profiles
2023-01-14 19:47:17 +01:00
Sandeep Somavarapu 05d59b893e
Log: Enhancements and cleaup (#171325)
- Make logger service primary source for log level
- Automatically register output channels for loggers from anywhere
- Use logger channels on remote processes (server, pty)
- clean up loggers and log service
2023-01-14 19:46:46 +01:00
Benjamin Pasero a2bdb408ba
scorer - improve debug output (#171308) 2023-01-14 08:54:24 +01:00
Martin Aeschlimann 688900a2d6
ActionGroup.icon: use color from ThemeIcon (#171286) 2023-01-13 21:18:11 +01:00
Martin Aeschlimann d4237bd8d5
merge ThemeIcon and CSSIcon (#171279) 2023-01-13 20:15:16 +01:00
Ladislau Szomoru 99ecdd4122
Git - Another attempt to fix an edge case for adding a safe directory (#171151)
* Git - Another attempt to fix an edge case for adding a safe directory

* Pull request feedback
2023-01-13 20:10:48 +01:00
Joyce Er 30f439066e
API: emit event with waitUntil when an edit session identifier will be requested (#171210)
* Support syncing with remote before Continue On

* Use `AsyncEmitter` util to implement `waitUntil`
2023-01-13 19:24:56 +01:00
Megan Rogge 646dd5965a
play audio cues on cursor change in diff editors (#171275) 2023-01-13 12:14:03 -06:00
Rob Lourens c151349547
Fix debug line highlight (#171274)
Import new css file
Fix #171272
2023-01-13 18:46:34 +01:00
SteVen Batten 9194231bb6
support workspace trust keyboard shortcut (#171131)
* support workspace trust keyboard shortcut

* macos test/fix

* Add support for short labels to the Button

* Remove code that is not needed

Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
2023-01-13 09:42:14 -08:00
Megan Rogge 8f9abdacc2
support reading the line content and audio cues in diff review mode (#171212) 2023-01-13 17:49:26 +01:00
Daniel Imms 7d707d16ef
Merge pull request #171267 from microsoft/tyriar/commercial-scorpion
Improve separator setting description
2023-01-13 07:28:07 -08:00
Daniel Imms a3132d6bd7
Improve separator setting description 2023-01-13 07:08:51 -08:00
Daniel Imms 94c63cfd96
Merge pull request #171191 from microsoft/merogge/quick-fix-promises
ensure quick fix selector is registered before provider
2023-01-13 06:58:48 -08:00
Martin Aeschlimann 081f3eda34
use an object for Codicon (#171254)
* remove codicon as class

* use an Object for Codicon
2023-01-13 15:05:36 +01:00
Alex Ross 9bcc577478
Point to new microsoft/vscode-css repo (#171252)
Part of #169873
2023-01-13 14:33:39 +01:00
Henning Dieterichs 140004f4ee
Fixes #140708 by introducing Ctrl+Right/Left keybindings to accept/undo parts of inline completions. (#171251) 2023-01-13 14:32:37 +01:00
Johannes Rieken 05625e39e1
esm - remove getPathFromAmdModule, replace its usages with FileAccess.asFileUri and AppResourcePath (#171250) 2023-01-13 14:06:16 +01:00
Sandeep Somavarapu f7f964be79
remove picking icon from create flow (#171248) 2023-01-13 14:01:05 +01:00
Sandeep Somavarapu 3ce186a68e
Pin extension in the extensions manifest (#171247) 2023-01-13 13:54:57 +01:00
Christof Marti 201a2a458a Add e.affectsConfiguration('http.proxy') (#169806) 2023-01-13 12:03:59 +01:00
Alex Ross f6fc2b1e34
Bump distro (#171243) 2023-01-13 11:53:35 +01:00
Johannes Rieken 1cf4502987
Merge pull request #171242 from microsoft/joh/capable-gopher
joh/capable gopher
2023-01-13 11:31:39 +01:00
Johannes f2f6607cf4
even for node check for performance.timeOrigin global (ESM friendly-ness) 2023-01-13 11:06:02 +01:00
Johannes 6fe2f5e97b
update sinon to ESM friendly verson 2023-01-13 11:05:10 +01:00
Alex Ross ede5714228
Update SQL grammar (#171237)
Fixes #171114
2023-01-13 10:42:37 +01:00
Sandeep Somavarapu 42c8a5476c
fix #171233 (#171236) 2023-01-13 10:23:46 +01:00
Sandeep Somavarapu 222994d349
Enhance logger service (#171174)
- ILoggerService centrailised place for all loggers
- Provide options to display logger while creating/registering logger
- Listen to logger service and register log output channels accordingly
- Adopt this at all places where loggers are created
2023-01-13 09:12:58 +01:00
Tyler James Leonhardt 7c0e51357d
Pull l10n files from build folder for extensions that don't live in source (#171217)
This will allow the l10n build to pick up the bundle.l10n.json inside of js-debug

cc @connor4312
2023-01-13 08:34:14 +01:00
Megan Rogge 243854703b
remove logs (#171209)
* fix #170849

* rm logs

* Revert "fix #170849"

This reverts commit a201125e55.
2023-01-12 23:45:57 +01:00
Matt Bierner 848d300e8c
Use explicit flag to enable TS server project wide intellisense (#171208) 2023-01-12 23:15:18 +01:00
David Dossett 7daa453220
Fix typo lin Light+ V2 widgetBorder rule (#171203) 2023-01-12 22:17:41 +01:00
David Dossett b6acfe86f4
Fix editor cursor colors in v2 themes (#171202) 2023-01-12 22:15:04 +01:00
David Dossett 127a4c7b4a
Fix active icon color for selected list items in Light+ V2 (#171201) 2023-01-12 21:53:00 +01:00
Nathan Shively-Sanders 3261c7d3af
Cross-file Typescript support in vscode-web (#169311)
* recreate logging from other machine

* comment out openSystemBrowser

Because I dont have the default browser set up correctnly on any of my
machiens

* Add vscode-wasm-typescript dep

And some logging as I figure out how to use it

* remove unused reference to module

* use require reference that linter allows

* Add vscode-wasm-typescript to tsserver.web.js

Use webpack's CopyPlugin transform pattern to do this manually. This is
probably a bad idea! It's just for prototyping purposes.

* Update vscode-wasm-typescript dependency

* Fix minor syntax in webpack hack

Nonetheless required for it to work!

* Fix another typo in webpack hack!

* Fix provided typescript path

Another typo. Guess my local test wasn't running the contents really

* Try to improve module.exports handling in webpack hac

* tsserver.web.js comes from local builds

Also:
- tsserver.js is no longer minified
- log crossOriginIsolated

* First attempt to set up server-side support

* Remove auto-imported identifier

* Move sync-api setup code to serverProcess.browser.ts

Because it's browser-specific

* Reorder webpack hack and clean up unused logging

* Update vscode-wasm/vscode-wasm-typescript dependencies

* Add file watching

* Extract webpack hack

Build only the ts parts of tsserver.web.js, don't rebuild the vscode
extension. This is a lot faster.

* Remove manual verbose logging

Sheetal showed me the correct way to create a verbose logger instead.

* Add vscode-test-web to semantic-supported schemes

And make isWeb support semantic mode.

* Also update the webpack-hack-only build

* Switch to tsserverlibrary

Also paste in some example code for cancellation, which is not finished
at all.

* Remove bogus auto-import and unneeded (?) dep

* remove webpack-like hack

* move code from vscode-wasm-typescript

* Initial prototype of cancellation

It compiles and looks kind of plausible. But I haven't tested it yet.

* Switch tsserver to separate MessageChannel

* Move watches to a separate MessagePort

Further simplifies the message dispatch code by shifting complexity to
setup. And the setup is straight-line code.

* switch vscode-web from in-memory to real filesystem

goto-def is currently broken because some part of main vscode still
needs treat the files as in-memory, though.

* Make toResource translate / -> vscode-test-web

* Encode scheme and authority in TS filenames

Like the previous host did, but without the leading ^ that TS hard-codes
as "in-memory".

The tsserver host needs to know about the encoding, but the translation
is in a single function. This also means that displayed file paths are
prefixed with /scheme/authority (/vscode-test-web/mount in my testing), but I think that's fine.

* Lift parseUri outside createServerHost

I'm not using it to set the schema/authority for getCurrentDirectory
right now, so there's no shared state to mutate.

* Special-case URI of lib*d.ts in webServer.toResource

Similar to the special-casing in typescriptServiceClient.toResource.
Also requires passing in the extensionUri. This feels like it's breaking
through at least one abstraction layer, which might be a problem.

* Improve cancellation

1. Simplify cancellation checking in web tsserver host to match the
checking in typescript's node host.
2. Move cancellation of request in the extension to tryCancelRequest
from sendNextRequests.
3. Only send cancellation via node or web cancellation, not both.

* Pass in current request instead of waiting for a fresh one.

* Address initial PR comments

Also add some TODO comments for the revision to watches.

* Add cancellation bit to each (cancellable) request, locally fix an issue with retrieving the cancellation bit

* Switch to per-file/directory watches

Watching the entire filesystem recursively is supposed to be
inefficient.

Not done yet: there is an error when watching directories, but it works.
And I can't tell whether watching files works yet.

* Parse --serverMode partialSemantic in webServer

Now the syntax server actually runs as a syntax server.

* Simplify logging code

* Cleanup in webServer

1. Remove a little logging.
2. Correct failure return value for getFileSize
3. Reorder some methods and parameters.

* Switch to markdown extension's FileWatcherManager

I'm not sure if it's OK to depend on a module from another extension;
it's probably better to include the files from a central place instead.

* Clean up host methods

1. Copy and adapt implementations from node host where possible.
2. Note questions for the PR elsewhere.
3. Remove logging except for caught exceptions.

* More logging/TODO cleanup

* Remove duplicate dependency

* Add setting to enable/disable semantic mode on web

Also gate it behind a check to `crossOriginIsolated`

* Re-order and re-arrange code to minimise PR diff

It won't minimise it *much*, but I also consolidated some
unnecessarily-spread-out code that will be easier to read in the long
term, and possibly easier to read in diff form as well.

* Copy fileWatchingManager to typescript extension

Copy from markdown extension to typescript extension. I used the
existing dependencies in the typescript extension, but verified that
they would work the same.

* Fix linting of webServer

* Align formatting of catch / else

* Extract isProjectWideIntellisenseOnWebEnabled and keep using in-memory prefix when project wide intellisense is disabled

* Make sure we still work if SharedArrayBuffers aren't supported

* Remove symlink support and fix typo

Symlinks are implicitly supported by the filesystem right now.

* Fix compile errors

Co-authored-by: Johannes <johannes.rieken@gmail.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
2023-01-12 11:54:39 -08:00
Matt Bierner e14165e0f5
Remove extra space in log message (#171197) 2023-01-12 20:43:08 +01:00
meganrogge 178a0064fb
fix tests 2023-01-12 12:29:19 -06:00
meganrogge 20b37627f2
update tests 2023-01-12 12:26:23 -06:00
meganrogge a201125e55
fix #170849 2023-01-12 12:17:55 -06:00
Megan Rogge 54c55bcb3e
correct name of command to match behavior (#171113)
fix #171073
2023-01-12 11:57:09 -06:00
Tyler James Leonhardt 656e526b3e
Add EMU to session telemetry (#171186)
* Telemetry for EMU

* comment
2023-01-12 18:51:18 +01:00
Han e3f31b30c3
Adapter css for #165169 (#167030)
* adapter css variable for callStackEditorContribution

* adapter css variable for extensionEditor

* 💄

* adapter css variable for extensionActions

* Revert "adapter css variable for extensionActions"

This reverts commit 4cbac93e63.

* Revert "💄"

This reverts commit 90a33f75bc.

* Revert "adapter css variable for extensionEditor"

This reverts commit 3f00fd9f63.
2023-01-12 09:48:49 -08:00
David Dossett 1b8ec09a7c
Fix active editor line foreground in Light+ V2 (#171185)
Fix active editor line foreground
2023-01-12 18:43:24 +01:00
David Dossett 80f49e72fd
Fixi terminal cursor in Light+ V2 (#171184) 2023-01-12 18:41:53 +01:00
Megan Rogge 865590e011
add run recent and go to cwd to command decoration menu (#171000)
fix #170979
2023-01-12 11:31:53 -06:00
David Dossett ea7e0d5cfc
Fix badge foreground (#171182) 2023-01-12 18:31:02 +01:00
Rob Lourens 58eba95899
Fix uri transformer slowness over large buffers (#171126)
Fix #138784
2023-01-12 09:04:17 -08:00
Daniel Imms ca07d07a04
Merge pull request #171177 from microsoft/tyriar/term_menus
Fix new terminal menu item when clause
2023-01-12 08:49:44 -08:00