Commit graph

28120 commits

Author SHA1 Message Date
Markus Olsson e861209ba1 Wouldn't it be ironic if this crashes due to an unhandled promise rejection? 2020-11-24 12:13:22 +01:00
Markus Olsson aaad03eddd Call recordUnhandledRejection bound to the stats store instance 2020-11-24 12:11:40 +01:00
Markus Olsson 336fb5b56f
Merge pull request #10957 from desktop/stash-reentrancy
Refactor checkout branch and stash logic
2020-11-24 12:08:33 +01:00
Markus Olsson 923e5a2448 Merge branch 'development' into stash-reentrancy 2020-11-24 11:43:12 +01:00
Markus Olsson 8af5590143 Preseve metric semantics
Don't count a branch switch as a non default switch if we don't  know for sure what the default branch is
2020-11-24 11:25:49 +01:00
Markus Olsson 02d919d056 Roll single-use function into callsite 2020-11-24 11:06:39 +01:00
Markus Olsson aad5b41046 🎨 implicit type 2020-11-24 10:53:47 +01:00
Markus Olsson ad036a94b6 These checks aren't expensive, it's fine if we set it to what it already is 2020-11-24 10:53:41 +01:00
Markus Olsson 180ebf5e31
Merge pull request #11107 from desktop/what-if-we-did-fullscreen-search-tho
Fix fullscreen keyboard shortcut in split diff mode
2020-11-23 18:30:16 +01:00
Markus Olsson 520acced60 I'm in command but I don't have it under control 2020-11-23 13:43:03 +01:00
Markus Olsson 877423a233 Only show search on Ctrl/Cmd+F
Not Ctrl+Shift+F Cmd+Option+F etc. Closes https://github.com/desktop/desktop/issues/11069
2020-11-23 13:01:36 +01:00
Markus Olsson c2524e9540 Merge branch 'development' into stash-reentrancy 2020-11-20 11:37:51 +01:00
Markus Olsson 375f06a4d8 Merge branch 'development' into stash-reentrancy 2020-11-20 11:37:16 +01:00
Markus Olsson d09ae87e89
Merge pull request #11059 from desktop/unhandled-rejections-beta-only
Feature flag unhandled rejections to beta only
2020-11-20 11:33:48 +01:00
Markus Olsson adc0b9cf35
Merge pull request #11064 from desktop/you-spin-me-right-round
Fix split diff crashes by using loops instead of spreads
2020-11-20 11:33:14 +01:00
Markus Olsson fc6589602b
Merge pull request #11066 from desktop/no-files-no-drop
Handle users dropping strings and such onto the app
2020-11-20 11:32:23 +01:00
Markus Olsson 618255a89e
Merge pull request #11065 from olimart/patch-1
Fix typo (take 2)
2020-11-20 11:30:06 +01:00
Markus Olsson ee8af5ef95 🎨 cleanup 2020-11-18 19:37:40 +01:00
Olivier 5665d97076
Fix typo 2020-11-18 12:42:20 -05:00
Markus Olsson 24f2c169f2 Use loops instead of spreads
I hadn't anticipated these arrays ever growing so large but we've been getting multiple crash reports due to stack overflows thanks to spread/apply putting the arguments onto the stack, see https://stackoverflow.com/a/5081471/2114
2020-11-18 18:03:14 +01:00
Markus Olsson fefb2e70e3
Merge pull request #11058 from olimart/patch-1
Fix typo
2020-11-18 16:22:18 +01:00
Markus Olsson a187cefe30 🎨 cleanup 2020-11-18 11:36:34 +01:00
Markus Olsson c55888fdec Turns out the list can be empty!
It will be empty if the user drops something other than files onto the app (like a string or a link or something)
2020-11-18 11:35:47 +01:00
Markus Olsson d96823a778 One day I'll learn how to program 2020-11-18 10:56:11 +01:00
Markus Olsson 8023692119 🎨 reformatting 2020-11-18 10:51:24 +01:00
Markus Olsson 3121bcf7bb Throttle non fatal exceptions 2020-11-18 10:51:19 +01:00
Markus Olsson 3e69ed098c Skip submitting non fatal errors unless opted in 2020-11-18 10:42:19 +01:00
Markus Olsson 82f08d88d5 Remove nonFatal exceptions for willNavigate and newWindowPrevented
We never saw any of these reported so there's no need for them any more.
2020-11-18 10:40:50 +01:00
Markus Olsson 20fdd56c67 Record unhandled rejection count 2020-11-18 10:36:26 +01:00
Markus Olsson 267a44b81c 🎨 reformat 2020-11-18 10:31:02 +01:00
Markus Olsson c50ec82035 Only submit unhandled rejections if on beta and opted in 2020-11-18 10:30:42 +01:00
Markus Olsson e7ff706811 Add a feature flag for unhandled rejection reporting 2020-11-18 10:30:21 +01:00
Olivier 5082630613
Fix typo 2020-11-17 23:44:06 -05:00
Markus Olsson 1f6405476b
Merge pull request #11048 from desktop/releases/2.6.0
Release v2.6.0
2020-11-17 17:43:22 +01:00
Markus Olsson 159727a984
Merge pull request #11019 from desktop/dart-sass
Switch to using the dart version of sass instead of node-sass
2020-11-17 10:33:02 +01:00
Billy Griffin b666c0f323
Update changelog.json 2020-11-16 19:13:52 -07:00
Billy Griffin 02a04fff63
Update changelog.json 2020-11-16 19:13:44 -07:00
Billy Griffin f861781813
Update changelog.json 2020-11-16 19:13:38 -07:00
Billy Griffin 49e6a2e33e
Update changelog.json 2020-11-16 19:13:31 -07:00
Billy Griffin bd056254b8
Update changelog.json 2020-11-16 19:11:27 -07:00
Billy Griffin a7828998e4
Update changelog.json 2020-11-16 19:10:13 -07:00
Billy Griffin 4734a6ea56
Update changelog.json 2020-11-16 19:10:06 -07:00
Billy Griffin 2073d159b2
Update changelog.json 2020-11-16 19:09:58 -07:00
Markus Olsson d77ee208e6 Bump version number and add changelog 2020-11-16 17:39:42 +01:00
Markus Olsson 572e0646c0
Merge pull request #11024 from desktop/releases/2.6.0-beta1
Release v2.6.0-beta1
2020-11-16 17:23:27 +01:00
Markus Olsson ecaf0d0f3a Merge branch 'development' into releases/2.6.0-beta1 2020-11-13 14:12:17 +01:00
Markus Olsson 8bdb921821
Merge pull request #10965 from desktop/unleash-both-sides
Enable split diffs for production
2020-11-13 14:12:08 +01:00
Markus Olsson b87f71c63e Bump app version and prepare changelog 2020-11-13 14:11:23 +01:00
Markus Olsson 5cd24211a2
Merge pull request #11017 from desktop/the-biggest-sur
Increase title bar height on Big Sur
2020-11-13 14:06:23 +01:00
Markus Olsson 1e2ab46fe3
Merge pull request #11018 from desktop/peer-perr-prrr-pr
Add required peer-dependency for focus-trap-react
2020-11-13 13:47:48 +01:00