development/github-desktop
development/github-desktop
1
0
Fork 0
mirror of https://github.com/desktop/desktop synced 2024-09-20 00:21:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

🎨 reformat

Browse source
This commit is contained in:
Markus Olsson 2020-11-18 10:31:02 +01:00
parent c50ec82035
commit 267a44b81c
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
app/src/ui/index.tsx
View file

@ -203,16 +203,14 @@ process.on(
)
/**
* Chromium won't crash on an unhandled rejection (similar to how
* it won't crash on an unhandled error). We've taken the approach
* that unhandled errors should crash the app and very likely we
* should do the same thing for unhandled promise rejections but
* that's a bit too risky to do until we've established some sense
* of how often it happens. For now this simply stores the last
* rejection so that we can pass it along with the crash report
* if the app does crash. Note that this does not prevent the
* default browser behavior of logging since we're not calling
* `preventDefault` on the event.
* Chromium won't crash on an unhandled rejection (similar to how it won't crash
* on an unhandled error). We've taken the approach that unhandled errors should
* crash the app and very likely we should do the same thing for unhandled
* promise rejections but that's a bit too risky to do until we've established
* some sense of how often it happens. For now this simply stores the last
* rejection so that we can pass it along with the crash report if the app does
* crash. Note that this does not prevent the default browser behavior of
* logging since we're not calling `preventDefault` on the event.
*
* See https://developer.mozilla.org/en-US/docs/Web/API/Window/unhandledrejection_event
*/