Commit graph

26982 commits

Author SHA1 Message Date
Markus Olsson dbdd59c338 Remove unused ariaMode 2023-02-13 14:56:41 +01:00
Markus Olsson 5c7f4a788f Focus on first suitable child in sign in flow
When switching steps in the sign in flow we're essentially showing a new dialog (or at least it should behave as such) which means we'll need to reset the focus, if we don't then keyboard focus will just flow to the body whenever we change the dialog contents.
2023-02-13 11:48:21 +01:00
Markus Olsson a567e4e6d9 Favor ordinary buttons over the close button 2023-02-13 11:37:59 +01:00
tidy-dev 1aa0d389d4 Log out the current target 2023-02-10 14:21:58 -05:00
tidy-dev 50f41c54df bubbling up context menu invocation from list row in changes list 2023-02-10 13:52:24 -05:00
tidy-dev a72cb4907c Avatar only a button when it needs to be 2023-02-10 12:02:56 -05:00
tidy-dev 30a0f07d3b Make the close button a button; allow it to have focus 2023-02-10 11:39:36 -05:00
tidy-dev e9c383778c Use aria-label to describe the file 2023-02-10 10:41:13 -05:00
Markus Olsson d8142c50c0 Get rid of blank role attribute and rowgroup role on the innerGrid 2023-02-10 15:49:13 +01:00
Le Minh Tri f9ed154425
Merge remote-tracking branch 'origin/development' into feature/integration-tabby-terminal 2023-02-10 03:20:22 +07:00
tidy-dev 1099009f83 Revert "Make file status and checked status voice over annouceable"
This reverts commit dbfdbc5eeb.
2023-02-09 14:14:50 -05:00
tidy-dev 19431ced93
Merge pull request #16100 from desktop/avatar-keyboard-accessible
Commit Message/Misattributed commits Avatar Keyboard Accessible
2023-02-09 13:19:19 -05:00
tidy-dev a441ac72f2 Make border-radius of avatar button match avatar image 2023-02-09 12:22:01 -05:00
tidy-dev 04b9b3e55b
Merge pull request #16031 from tsvetilian-ty/dataspell-support-windows
JetBrains DataSpell support on Windows
2023-02-09 10:16:25 -05:00
tidy-dev f1019d2fdc
Merge pull request #16021 from jm-rivera/patch-1
Add DataSpell to darwin.ts
2023-02-09 10:11:57 -05:00
tidy-dev 2ef16d031d Add better, targeted styles 2023-02-09 09:27:45 -05:00
tidy-dev 05f3631a71 Make commit message avatar into a button 2023-02-09 09:21:19 -05:00
tidy-dev dbfdbc5eeb Make file status and checked status voice over annouceable 2023-02-09 08:45:13 -05:00
Sergio Padrino a481b032a2 Add support for PR comment notifications 2023-02-09 13:28:26 +01:00
Sergio Padrino 786f814d5e Add new tool to easily test notifications from real data 2023-02-09 13:23:44 +01:00
Sergio Padrino bae2b7dc5c Refactor PR review dialog 2023-02-09 13:14:12 +01:00
Le Minh Tri 51c21413ad
fix: handle logic for launching Tabby shell in a specified working dicrectory 2023-02-09 10:21:33 +07:00
Le Minh Tri 06abd7516c
Merge remote-tracking branch 'origin/development' into feature/integration-tabby-terminal 2023-02-09 10:14:45 +07:00
Sergio Padrino 297656a4c8
Merge pull request #16029 from adil192/patch-1
Add some IDEs from JetBrains Toolbox to Linux
2023-02-08 10:03:54 +01:00
Sergio Padrino d1a16d80e8
Merge branch 'development' into releases/3.1.6 2023-02-07 12:09:03 +01:00
Sergio Padrino 3abd7b29ac Bump changelog and version to 3.1.6 2023-02-06 16:50:50 +01:00
Sergio Padrino 43f1b55d8e Merge pull request #15915 from desktop/bump-git-2.39.0
Bump to git 2.39.0 and git-lfs 3.3.0
2023-02-06 16:48:56 +01:00
dependabot[bot] 6109dd49fa
Bump jszip from 3.7.1 to 3.10.1 in /app
Bumps [jszip](https://github.com/Stuk/jszip) from 3.7.1 to 3.10.1.
- [Release notes](https://github.com/Stuk/jszip/releases)
- [Changelog](https://github.com/Stuk/jszip/blob/main/CHANGES.md)
- [Commits](https://github.com/Stuk/jszip/compare/v3.7.1...v3.10.1)

---
updated-dependencies:
- dependency-name: jszip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-02-03 07:42:35 +00:00
Adil Hanney fe3fdfa62d
yarn lint:fix 2023-02-02 12:54:05 +00:00
tidy-dev 89c4daa00a Add axeDevTools extension 2023-02-01 13:03:50 -05:00
Le Minh Tri fc752078f4
feat(integration): add Tabby terminal integration for macOS 2023-01-31 14:10:51 +07:00
Tsvetilian Yankov 47152957bf Add support for JetBrains DataSpell on Windows 2023-01-30 00:43:17 +02:00
Brendan Forster b37a25a88e Add support for numerous additional editors on Linux
- Kate
 - gEdit
 - Notepadqq
 - GNOME Text Editor
 - GNOME Builder
 - VSCode (from WSL)
 - Geany
 - Mousepad

Co-Authored-By: gwyn <29720696+avalonv@users.noreply.github.com>
Co-Authored-By: PadowYT2 <71085027+PadowYT2@users.noreply.github.com>
Co-Authored-By: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-Authored-By: Amin Yahyaabadi <16418197+aminya@users.noreply.github.com>
Co-Authored-By: Etaash Mathamsetty <45927311+Etaash-mathamsetty@users.noreply.github.com>
Co-Authored-By: Richard Kellnberger <5147221+Richardk2n@users.noreply.github.com>
Co-Authored-By: Sky Barnes <429099+tsbarnes@users.noreply.github.com>
2023-01-29 16:36:00 -04:00
Adil Hanney 5f77706120
Recapitalise JetBrains 2023-01-29 20:30:03 +00:00
Adil Hanney 7bb7724f60
Add some IDEs from JetBrains Toolbox to Linux
I'm not sure about the snap locations but I've added them in for completeness. If I should remove them, let me know :)
2023-01-29 20:24:39 +00:00
tidy-dev 63592700cf
Need each one..
Co-authored-by: Sergio Padrino <sergiou87@github.com>
2023-01-27 10:52:12 -05:00
tidy-dev 13332ca8e3 Check for content 2023-01-27 10:17:15 -05:00
tidy-dev bd9513d397 Merge branch 'development' into pr/15165 2023-01-27 10:13:00 -05:00
Jorge Rivera 5fd16c922b
Add DataSpell to darwin.ts
Modify list of external editors to include JetBrains DataSpell
2023-01-27 14:48:20 +01:00
Sergio Padrino bce5000e43 Bump changelog and version to 3.1.6-beta2 2023-01-26 16:04:27 +01:00
Sergio Padrino 16eb9c1832
Merge pull request #15821 from Shivareddy-Aluri/trim-white-spaces-before-saving
Trim white spaces before saving repository URL changes
2023-01-26 11:41:59 +01:00
Sergio Padrino 21ecffa10d
Merge pull request #16003 from desktop/releases/3.1.6-beta1
Release 3.1.6-beta1
2023-01-26 11:37:23 +01:00
Sergio Padrino ed4c2d5546
Merge pull request #15813 from desktop/rstudio-fix
Update RStudio publisher to fix integration
2023-01-26 10:23:32 +01:00
Sergio Padrino d94b726686
Merge pull request #15981 from desktop/force-push-dropdown-optional-warning
Only show force-push warning when confirmation dialog is disabled
2023-01-26 10:05:45 +01:00
tidy-dev b66d481a47 Release 3.1.6-beta1 2023-01-25 12:57:47 -05:00
tidy-dev 89989fb958
Merge pull request #15982 from desktop/releases/3.1.5
Release 3.1.5
2023-01-25 12:14:57 -05:00
Sergio Padrino 18d1d6e0ee
Merge pull request #15915 from desktop/bump-git-2.39.0
Bump to git 2.39.0 and git-lfs 3.3.0
2023-01-25 18:08:23 +01:00
dependabot[bot] de25b4e03e
Bump ua-parser-js from 0.7.28 to 0.7.33 in /app
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.28 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.28...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-01-25 16:49:21 +00:00
tidy-dev 88b8bcd56e
Merge pull request #15831 from desktop/electron-22-0-0
Bump Electron to v22.0.3
2023-01-25 11:48:41 -05:00
Sergio Padrino c6e0865d6a
Merge branch 'development' into releases/3.1.5 2023-01-25 17:46:05 +01:00
Steve Ward e09e61c8d7
Merge branch 'development' into rstudio-fix 2023-01-24 07:12:47 -08:00
Steve Ward 45a8aecc07
Update app/src/lib/editors/win32.ts
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
2023-01-24 10:10:14 -05:00
Shivareddy-Aluri c3437a4469
Update repository-settings.tsx 2023-01-23 23:27:09 +05:30
tidy-dev 7f903a3056 Update Response Type to CallbackResponse Type 2023-01-23 11:42:41 -05:00
Sergio Padrino 61c5bdd57a Enable preventing closing while updating feature flag 2023-01-23 17:21:57 +01:00
Sergio Padrino 561930573f Bump changelog and version to 3.1.5 2023-01-23 17:21:20 +01:00
Sergio Padrino e6bfcc9bd9 Only show force-push warning when confirmation dialog is disabled 2023-01-23 13:12:16 +01:00
Sergio Padrino 924ab82c45
Merge pull request #15907 from desktop/pull-push-dropdown
Pull-push-fetch button + dropdown
2023-01-23 09:44:07 +01:00
Shivareddy-Aluri 144f30d8f8
Update repository-settings.tsx 2023-01-22 23:34:19 +05:30
Shivareddy-Aluri 9bf66270b7
Update repository-settings.tsx 2023-01-22 23:25:39 +05:30
Sergio Padrino f42da5109d Remove unnecessary parameters 2023-01-20 13:25:48 +01:00
Sergio Padrino 18c1553462 Feature-flag push-pull-fetch dropdown for beta builds 2023-01-20 13:10:05 +01:00
Shivareddy-Aluri 1d9cbd3baa review changes 2023-01-19 22:14:22 +05:30
tidy-dev fb2c178303 Avoiding disabling the linter.. 2023-01-18 13:08:19 -05:00
Sergio Padrino 5f534e8541
Merge pull request #15917 from tsvetilian-ty/macos-clion-support
Add JetBrains CLion support on macOS
2023-01-18 18:45:15 +01:00
Sergio Padrino 1eefb02f30 Merge branch 'development' into bump-git-2.39.0 2023-01-18 14:41:12 +01:00
Sergio Padrino 3deab3944b Bump dugite to 2.3.0 2023-01-18 14:05:02 +01:00
Sergio Padrino b909d42a8b
Merge branch 'development' into releases/3.1.4 2023-01-18 14:03:12 +01:00
Sergio Padrino 90527172a3
Merge pull request #15957 from desktop/releases/3.1.4-beta1
Release 3.1.4-beta1
2023-01-18 14:02:00 +01:00
Sergio Padrino 5c61417b10 Merge branch 'development' into bump-git-2.39.0 2023-01-18 14:00:47 +01:00
Dawn Walker 5380ffcb89 Update win32.ts 2023-01-18 21:05:09 +11:00
Markus Olsson eaeb66dd81 Move dugite dependency to app 2023-01-18 08:37:33 +01:00
Markus Olsson 54965753e3 Bump dugite in app folder 2023-01-18 08:36:03 +01:00
Dawn Walker f745df411c Update win32.ts 2023-01-18 17:06:28 +11:00
Dawn Walker e5af050d2d
Merge branch 'desktop:development' into development 2023-01-18 11:54:42 +11:00
tidy-dev ba6e0f13c0 Release 3.1.4 2023-01-17 15:43:19 -05:00
tidy-dev b55ac83289 Release 3.1.4-beta1 2023-01-17 15:29:40 -05:00
Sergio Padrino ced3ceae7a
Merge pull request #15780 from tsvetilian-ty/jetbrains-toolbox-support
Support for JetBrains Toolbox and JetBrains Fleet editor
2023-01-17 18:16:01 +01:00
Tsvetilian Yankov bdbc0ac820 Add JetBrains CLion support on MacOS 2023-01-12 22:55:47 +02:00
Sergio Padrino 7ce8047563 Update line endings change regex
This string changed in c970d30c2c
2023-01-12 17:01:53 +01:00
Sergio Padrino 7ec8e034cb Fix styling issues due to initial focus 2023-01-11 18:41:15 +01:00
Sergio Padrino 8412b4a6e1 Fix keyboard navigation due to modulo bug 2023-01-11 18:34:57 +01:00
Sergio Padrino 2d1f8f0002 Use the right colors for hover state 2023-01-11 16:26:26 +01:00
Sergio Padrino 746c32a407 Extract class name into constant 2023-01-11 13:30:14 +01:00
Sergio Padrino 8b227851ba Enable Up and Down arrows to navigate dropdown items 2023-01-11 13:28:55 +01:00
Sergio Padrino eb589b0c1c Only show force-push dropdown action on diverged branches 2023-01-11 12:05:42 +01:00
Sergio Padrino 4f34e2aac3 Add warning for force-push dropdown item 2023-01-11 11:44:35 +01:00
Sergio Padrino 2ab62206a0 No need for FocusTrap. Dropdowns already have one 2023-01-10 17:30:26 +01:00
Sergio Padrino 8920fb29a9 Refactor rendering push-pull dropdown items 2023-01-10 17:29:06 +01:00
Sergio Padrino 4ff49a42af Use dropdown or plain button depending on repo state 2023-01-10 17:12:54 +01:00
Sergio Padrino a507ce9b11 (WIP) First steps refactoring ToolbarDropdown 2023-01-09 12:31:35 +01:00
Sergio Padrino 39aaae548d (WIP) Trying to get an accessible dropdown working! 2023-01-09 12:31:35 +01:00
tidy-dev 41674c655e
Merge pull request #15864 from desktop/Align-branch-to-center
Align no branches text in the center
2023-01-05 12:57:35 -05:00
Sergio Padrino ce4fbb259e Merge branch 'development' into releases/3.1.3 2023-01-05 15:50:43 +01:00
Shivareddy-Aluri 5e3064cbe8 Update repository-settings.tsx 2023-01-05 00:07:26 +05:30
tidy-dev 94f50d3b3f Align no branches text in the center 2023-01-04 10:31:40 -05:00
tidy-dev af7b8ae7d1 Revert "Align no branches text in the center"
This reverts commit 2b3eaaaffd.
2023-01-04 10:31:21 -05:00
tidy-dev 2b3eaaaffd Align no branches text in the center 2023-01-04 10:30:26 -05:00
tidy-dev 37d0a59135
typo..
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
2023-01-04 09:38:42 -05:00
tidy-dev ce10ec491f Some reason this was missing? 2023-01-04 09:36:45 -05:00
tidy-dev 895fcec53f Merge branch 'development' into pr-preview-only-using-remote-base-branches 2023-01-04 09:32:56 -05:00
tidy-dev fc1acbf6d5 Better messaging when no branch found
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-01-04 09:24:17 -05:00
tidy-dev ecc5b00ec3 Lint.. 2023-01-04 08:29:30 -05:00
tidy-dev 0e3cc645dd Better naming
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2023-01-04 08:22:01 -05:00
tidy-dev ef1e403b49
Merge pull request #15747 from desktop/add-preview-pull-request-metrics
PR Preview: Add Preview Pull Request Metrics
2023-01-04 08:18:24 -05:00
zipperer 7165ffe672
Update linux.ts -- add editor Emacs
In `editors: ILinuxExternalEditor[]`, add entry for [Emacs](https://www.gnu.org/savannah-checkouts/gnu/emacs/emacs.html).
2023-01-03 11:25:11 -06:00
tidy-dev 739f633cb0
Update app/.npmrc
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
2023-01-03 11:43:35 -05:00
tidy-dev e7552e7c5f Remove deprecated new-window 2022-12-27 13:08:21 -05:00
tidy-dev bb99167736 Update PathType 2022-12-27 09:44:05 -05:00
tidy-dev af9ae5552b Upgrade Electron to 21.3.3 - Package bump - broken build) 2022-12-27 09:44:05 -05:00
Shivareddy-Aluri 81e5be127f Update repository-settings.tsx 2022-12-26 08:26:29 +05:30
Shivareddy-Aluri dddfb12f94 linters fix 2022-12-25 21:27:49 +05:30
Shivareddy-Aluri e461e22727 Update repository-settings.tsx 2022-12-25 19:51:49 +05:30
Steve Ward de6e131cac
Update RStudio publisher to new name 2022-12-21 10:48:22 -05:00
tidy-dev 25732d6750 Merge branch 'development' into add-preview-pull-request-metrics 2022-12-20 12:14:40 -05:00
Tsvetilian Yankov 9a3db00ce4 Update docs 2022-12-17 00:01:29 +02:00
Tsvetilian Yankov 7204c01aad Extract JetBrains Toolbox detection to a function 2022-12-16 22:07:54 +02:00
Tsvetilian Yankov f4b221afe9 Remove unnecessary type for toolbox 2022-12-16 22:03:37 +02:00
tidy-dev 695d121c2c Release 3.1.3-beta4 2022-12-14 11:10:16 -05:00
tidy-dev 4731f27676 Release 3.1.3 2022-12-14 10:35:05 -05:00
tidy-dev f7a4aa6bf6 Merge pull request #15549 from desktop/shift-down-arrow
Fix Shift + Down Arrow not selecting properly in the Commit List
2022-12-14 10:24:16 -05:00
tidy-dev 7700404834 Merge pull request #15468 from desktop/consistently-disable-multi-commit-operations-in-progress
Consistently disable multi commit operations
2022-12-14 10:22:47 -05:00
tidy-dev d47d694fc9 Merge pull request #15471 from angusdev/issue-13081-menu-disabled
Fix menu items disabled if close the "Resolve conflicts before Rebase" dialog
2022-12-14 10:21:59 -05:00
Sergio Padrino be3868e2ee Merge pull request #15445 from desktop/fix-cmd-enter-amend
Fix cmd/control + enter shortcut while amending a commit
2022-12-14 10:18:54 -05:00
tidy-dev 87fd61879f
Merge pull request #15668 from desktop/introduce-react-context-for-stacked-popups
PR Preview: Introduce react context for managing open/closing stacked popups
2022-12-14 09:18:52 -05:00
tidy-dev ef7c998327 Other isTopMost unmounts consistent
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2022-12-14 08:57:51 -05:00
tidy-dev 84fb598008
Use helper
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
2022-12-14 08:54:26 -05:00
tidy-dev 23aec14b75
Use helper
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
2022-12-14 08:54:19 -05:00
tidy-dev d2e0015305 Make popupStack Readonly
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2022-12-14 08:41:30 -05:00
tidy-dev 7d65115d05 Doc
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2022-12-14 08:35:34 -05:00
tidy-dev 3b722a6776
Redefine array on insert
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
2022-12-14 08:24:13 -05:00
Tsvetilian Yankov f8067510f0
Change JetBrains Fleet to Fleet
Matching the name of JetBrains Fleet with the other JetBrains products in GitHub Desktop on macOS
2022-12-13 22:13:47 +02:00
Tsvetilian Yankov 1bb55e7caa Update type docs 2022-12-13 21:20:06 +02:00
Tsvetilian Yankov b5e3898692 Add Fleet as supported editor on darwin systems 2022-12-13 20:46:41 +02:00
tidy-dev b819be4913 Insert popups in place instead of constructing the array for sorting
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2022-12-13 12:38:25 -05:00
tidy-dev 1722926154 Tidying
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2022-12-13 12:15:48 -05:00
tidy-dev 9bacb57ebf Make isTopMostDialog function 2022-12-13 12:06:44 -05:00
tidy-dev d0110bfe4d Revert unneeded change 2022-12-13 11:10:40 -05:00
Tsvetilian Yankov 45d18e19d6 Add JetBrains Fleet for Windows 2022-12-13 17:56:46 +02:00
Tsvetilian Yankov ae438b6488 Add support on Windows 2022-12-13 17:56:10 +02:00
tidy-dev 6c056236b9 Send it as undefined to use default online 2022-12-13 10:12:49 -05:00
tidy-dev 2e818e43fd Merge branch 'development' into pr-preview-should-always-open 2022-12-13 09:39:28 -05:00
tidy-dev 7efb2ab31e Merge branch 'development' into introduce-react-context-for-stacked-popups 2022-12-13 09:35:20 -05:00
tidy-dev bb340d87d4 Tidying.. 2022-12-12 13:18:44 -05:00
tidy-dev c3c4dd5d84 Tidying up a little I think.. 2022-12-12 12:47:41 -05:00
tidy-dev 8410f11928 Merge branch 'development' into pr-preview-only-using-remote-base-branches 2022-12-12 12:13:40 -05:00
tidy-dev 6381545b9a Consider Forks 2022-12-12 12:12:43 -05:00
Sergio Padrino 3f1845d0cd
Merge pull request #15524 from angusdev/issue-15511-mac-close-not-hide
Hide window instead of hide the app in Mac
2022-12-12 16:35:44 +01:00
tidy-dev 8e034d6254 Merge branch 'development' into add-preview-pull-request-metrics 2022-12-12 08:58:16 -05:00
tidy-dev 8cee99cf4a Merge branch 'add-preview-pull-request-metrics' of https://github.com/desktop/desktop into add-preview-pull-request-metrics 2022-12-12 08:49:44 -05:00
tidy-dev 1143f949da Note about tracking create pull request for preview included 2022-12-12 08:49:32 -05:00
tidy-dev 7dcdc9c2db
Update app/src/lib/stats/stats-store.ts
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
2022-12-12 08:45:06 -05:00
tidy-dev a689709ffd Use default remote branches for base branch options. 2022-12-09 10:55:57 -05:00
tidy-dev 3f414bf517 Local repos shouldn't be able to preview pull request 2022-12-09 10:55:12 -05:00
tidy-dev d3e9fc8261 Add Preview Pull Request Metrics 2022-12-07 09:08:07 -05:00
tidy-dev 673b9cbf90 Merge branch 'development' into add-base-branch-to-open-pr-on-github 2022-12-07 08:53:29 -05:00
tidy-dev f1e2f04436 Merge branch 'development' into pr-preview-should-always-open 2022-12-07 08:51:08 -05:00
tidy-dev 50b997c225 At least find a comparison branch 2022-12-07 08:09:47 -05:00
tidy-dev bde5fd2ddc Use isRepositoryWithGitHubRepository
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
2022-12-06 10:47:51 -05:00
tidy-dev 26f247be74 If not hosted on github, no submit button needed 2022-12-06 10:05:55 -05:00
tidy-dev c771c1b0f6 Create button is a view button if pr already exists 2022-12-06 10:05:55 -05:00
tidy-dev 4f494dde77 Close dialog on PR Preview 2022-12-06 10:02:40 -05:00
tidy-dev e460f7518b
Merge pull request #15700 from desktop/don't-try-to-open-a-dialog-again
PR Preview: Don't attempt to reopen the pull request dialog if already open
2022-12-06 09:44:50 -05:00
tidy-dev 6af7122537
Merge pull request #15703 from desktop/preview-pr-suggested-next-action-not-always-available
PR Preview: Suggested next action available when it is supposed to be
2022-12-06 09:44:33 -05:00
Markus Olsson 77f4af099f
Merge pull request #15709 from desktop/fix-hunk-handle
Position hunk handle properly in unified mode with "experimental" diff viewer
2022-12-05 13:04:09 +01:00
Markus Olsson ed439f027b
Merge pull request #15698 from desktop/dependabot/npm_and_yarn/app/minimatch-3.1.2
Bump minimatch from 3.0.4 to 3.1.2 in /app
2022-12-05 12:55:56 +01:00
tidy-dev 3f8d6c225e
Merge pull request #15699 from desktop/is-not-a-left-click
Things should only be dragged by left mouse clicks
2022-12-03 11:08:18 -05:00
Markus Olsson a5a7a73881
Merge pull request #15641 from desktop/retain-list-row-focus
Retain list row focus when scrolling
2022-12-02 16:25:41 +01:00
Sergio Padrino 3461fbe562 Position hunk handle properly 2022-12-02 11:56:55 +01:00
tidy-dev 5e87f8a4c8 If base branch isn't default, open GitHub to compare against that base 2022-11-30 13:55:22 -05:00
tidy-dev c947d024b5 Use preview pull request item state - not create pr 2022-11-30 07:29:45 -05:00
tidy-dev 3c4aa37991 Don't attempt to reopen the pull request dialog if already open 2022-11-29 15:46:45 -05:00
tidy-dev 0c0bb1bb11 Things can only be dragged for Left clicks 2022-11-29 15:28:40 -05:00
tidy-dev 213df72ee6 Pass prop/add reused logic service 2022-11-29 08:45:06 -05:00
dependabot[bot] d44c5d90c9
Bump minimatch from 3.0.4 to 3.1.2 in /app
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Commits](https://github.com/isaacs/minimatch/compare/v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-29 13:44:26 +00:00
tidy-dev d7bb19f00c Linter 2022-11-28 11:39:07 -05:00
tidy-dev cc10f0adf2 Tidying - Move repeated logic to context consumer class
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
2022-11-28 11:10:19 -05:00
Dawn Walker b4ae30c950 Update win32.ts
Support for codium insiders
2022-11-27 20:48:26 +11:00
Dawn Walker 7290059f2a Update win32.ts 2022-11-27 20:46:07 +11:00
Dawn Walker 854bfa1030
Merge branch 'desktop:development' into development 2022-11-27 16:52:45 +11:00
Sergio Padrino 0ca784e6f4
Merge pull request #15506 from Shivareddy-Aluri/issue-15137-ability-to-copy-tag-names-from-list-view
Ability to copy tag names from the commit list issue-15137
2022-11-24 08:29:27 +01:00
tidy-dev 6be77aae93 Feature flag rendering all popups at once 2022-11-22 14:10:37 -05:00
tidy-dev 7f0393d450 !important not necessary 2022-11-22 14:10:11 -05:00
tidy-dev 6001d01cc1 Add IsTopMost check to other dialogs with event listeners 2022-11-22 12:40:46 -05:00
tidy-dev 3a41ad5ede memoizeOne the mounting/unmounting of a dialog that happens when it is the top most 2022-11-22 12:40:46 -05:00
tidy-dev 03dea5741b Implement DialogStackContext for showing/closing modal 2022-11-22 12:40:46 -05:00
tidy-dev 4d34bedd5c Add Dialog Stack Context to the dialog component 2022-11-22 12:40:45 -05:00
tidy-dev 431b2d0653 Render all popups in the stack 2022-11-22 10:41:33 -05:00
tidy-dev 9a990d19b9 Add allPopups to the app state 2022-11-22 10:32:58 -05:00
tidy-dev 88a358b4b5 Add a method to get all the popups in the stack 2022-11-22 10:31:36 -05:00
Shivareddy-Aluri f1e74e526a linters fix 2022-11-22 09:02:17 +05:30
Markus Olsson bc8bbd5917 Render ahead/behind tooltip using custom Tooltip 2022-11-18 16:54:42 +01:00
Markus Olsson 51a5d7cd4f Retain list item focus while scrolling
Moves focus away from unmounted list items to the grid such that keyboard navigation still works after scrolling

Co-Authored-By: Mark Hicken <849930+markhicken@users.noreply.github.com>
2022-11-18 16:17:43 +01:00
Markus Olsson e3de3f8e8a Rerender diff when newlines are added/removed from EOF 2022-11-18 14:20:29 +01:00
Markus Olsson bbfe7f3e19 Text diff structural equality 2022-11-18 14:19:49 +01:00
Markus Olsson 5d829580cb Structural equality methods for diff line, hunk, and headers 2022-11-18 14:19:40 +01:00
Sergio Padrino da1b41b9c8
Merge pull request #15630 from desktop/check-fork-contribution-target
Fix issue with notifications not displayed when a fork contributes to its parent
2022-11-16 15:39:55 +01:00
Sergio Padrino b86157f97f Check for every check run id
Co-Authored-By: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
2022-11-16 15:16:08 +01:00
Sergio Padrino 5d4fa4f2bb No need to check the check suite id anymore 2022-11-16 13:46:51 +01:00
Sergio Padrino 320b9264e1 Skip known check RUNS instead of check SUITES 2022-11-16 12:18:30 +01:00