Commit graph

26982 commits

Author SHA1 Message Date
Markus Olsson f1b7e0ba71 Always show preference footer 2023-03-09 19:31:04 +01:00
Markus Olsson 65b768a0b1 Move notifications to its own tab 2023-03-09 19:29:51 +01:00
Markus Olsson 2b7b5027ae Fix the bell 2023-03-09 19:29:44 +01:00
Markus Olsson 477c32e040 Offset focus outline for buttons, vertical tabs 2023-03-09 19:05:25 +01:00
Markus Olsson e52c3ae36d Make button hover state border color themable 2023-03-09 18:51:39 +01:00
Markus Olsson bc86d5fe65 Skip border effect on secondary button hover 2023-03-09 18:46:27 +01:00
Sergio Padrino 822a50a26b Update feature-flag.ts 2023-03-09 13:59:20 +01:00
Sergio Padrino bbfbf79463 Bump changelog and version to 3.2.1-beta1 2023-03-09 13:57:58 +01:00
tidy-dev 6d0c8c7796 Learn more link in no remote is descriptive 2023-03-08 14:28:53 -05:00
tidy-dev dbae398530 gitignore learn more link is descriptive 2023-03-08 14:24:05 -05:00
tidy-dev 3fe5d0921a Unreachable commits learn more link is descriptive 2023-03-08 14:22:54 -05:00
tidy-dev cd27ee412f Misattributed learn more links are descriptive 2023-03-08 14:22:09 -05:00
tidy-dev 95a6b06b61 Add aria-labelled by to check runs popover 2023-03-08 11:17:16 -05:00
tidy-dev 580b518317 Add aria-labelledby to whitespace hint popover 2023-03-08 11:17:00 -05:00
tidy-dev 2c8ae4b6da Add aria-labelledby to popover dropdown header 2023-03-08 11:07:06 -05:00
tidy-dev 01b3d08484 Add diff options header labelledby 2023-03-08 10:59:47 -05:00
tidy-dev 65127b68f4 Give diff options a heading 2023-03-08 10:03:45 -05:00
tidy-dev 3d19bb8a85 Use aria-label for misattributed popover 2023-03-08 09:43:23 -05:00
tidy-dev 2617443c1d Add dialog role to popovers 2023-03-08 09:43:01 -05:00
tidy-dev 130cffb7f9 Add aria labelled by option to popovers 2023-03-08 09:42:53 -05:00
Markus Olsson 2e46fbbf24
Apply suggestions from code review
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
2023-03-08 09:22:19 +01:00
Markus Olsson aa26da26bb Increase border contrast on interactive buttons and text boxes 2023-03-07 18:26:21 +01:00
tidy-dev b5a9952de2 Less html 2023-03-07 09:41:17 -05:00
tidy-dev bcf568de15 Debounce only the screen reader text 2023-03-07 09:30:05 -05:00
Markus Olsson 04f3307faa
Merge pull request #16219 from desktop/distracted-scrolling
Don't move focus when scrolling to row
2023-03-07 14:11:37 +01:00
tidy-dev 707b92a622 Attempts at making aria-live more reliable 2023-03-06 14:26:40 -05:00
Sergio Padrino 4f1fe95d76
Merge pull request #16226 from desktop/pr-comments-beta
Enable Pull Request comment notifications for beta
2023-03-06 15:00:42 +01:00
tidy-dev dd47696964 Merge branch 'development' into announce-preferences-email-error-message 2023-03-06 08:50:08 -05:00
tidy-dev ece74c7b77 Merge branch 'development' into announce-preferences-email-error-message 2023-03-06 08:49:28 -05:00
tidy-dev 7c84e07a0b Make misattributed commit warning static for "other" 2023-03-06 08:49:20 -05:00
tidy-dev 000f84514d Make sure button component doesn't cause wierd warning symbol placement 2023-03-06 07:28:00 -05:00
tidy-dev 366967329e More Accurate Label 2023-03-02 09:53:03 -05:00
tidy-dev 43da32d0a0 Add email label to misattributed warning select 2023-03-02 09:19:30 -05:00
tidy-dev 4e20daa22c Add Email screen reader label to preference "Other" email input 2023-03-02 09:10:02 -05:00
tidy-dev b04ff25c0f Should be optional 2023-03-02 09:07:12 -05:00
tidy-dev f6b23e4f68 Add aria-label option to text box component 2023-03-02 09:06:51 -05:00
tidy-dev 3a8ce7bda9 Link other email text box to id 2023-03-02 07:43:37 -05:00
tidy-dev 3ee4b9e076 Give git misattributed attribute an Id 2023-03-02 07:43:15 -05:00
tidy-dev e1b443286f Add aria-described by option 2023-03-02 07:42:44 -05:00
tidy-dev 13bb945c46 Move shared css to diff.scss 2023-03-02 07:10:00 -05:00
Sergio Padrino 3406403068
Merge pull request #16224 from desktop/releases/3.2.0
Release 3.2.0
2023-03-01 11:29:27 +01:00
Sergio Padrino bce326d3fc Enable PR comments for beta 2023-02-28 17:31:53 +01:00
tidy-dev f59a950520 Release 3.2.0 2023-02-28 06:16:40 -05:00
Marco Di Bella 1202e7b352 Update darwin.ts 2023-02-27 18:06:41 +01:00
Sergio Padrino b6eb736096
Merge pull request #16050 from desktop/dependabot/npm_and_yarn/app/jszip-3.10.1
Bump jszip from 3.7.1 to 3.10.1 in /app
2023-02-27 17:13:41 +01:00
Markus Olsson 0ef377e4c1 Don't move focus when scrolling to row 2023-02-27 16:09:52 +01:00
Sergio Padrino 5be4ed1362
Merge pull request #16002 from desktop/dependabot/npm_and_yarn/app/ua-parser-js-0.7.33
Bump ua-parser-js from 0.7.28 to 0.7.33 in /app
2023-02-27 13:14:59 +01:00
Gary R Krause 99b837b8aa
Update app.tsx
Typo correction.
2023-02-24 17:59:45 -05:00
Sergio Padrino 80a53ec7a3 Make add/remove co-authors button keyboard accessible 2023-02-23 12:26:25 +01:00
Markus Olsson bf05ca8752
Merge pull request #16194 from desktop/releases/3.1.9-beta2
Release 3.1.9-beta2
2023-02-22 11:21:51 +01:00
Markus Olsson c035f3f91c
Merge branch 'development' into releases/3.1.9-beta1 2023-02-22 10:40:49 +01:00
Markus Olsson a685379a99
Merge pull request #16150 from desktop/preferences-initial-focus
Focus on tabs when opening preferences dialog
2023-02-22 08:13:00 +01:00
Markus Olsson d036395bdc Changelog and version bump 2023-02-22 06:46:50 +01:00
Markus Olsson 9325c8be4c There are no propTypes in prod builds 2023-02-22 06:43:22 +01:00
Markus Olsson 820d596b11
Merge pull request #16151 from desktop/no-proptypes-in-prod-builds
Fix prod build crash due to propTypes not being defined
2023-02-22 06:41:27 +01:00
Sergio Padrino bb6780783a
Merge pull request #16097 from desktop/pr-comment-notifications-support
Basic support for Pull Request comment notifications
2023-02-21 11:07:02 +01:00
tidy-dev ce52aefdfb Release 3.1.9-beta1 2023-02-17 12:20:16 -05:00
tidy-dev ec166fcc7d
Merge pull request #16041 from ansidev/feature/integration-tabby-terminal
feat(integration): add Tabby terminal integration for macOS
2023-02-17 09:52:57 -05:00
Markus Olsson 4335b01671 There are no propTypes in prod builds 2023-02-17 15:45:34 +01:00
Markus Olsson 38c6c6265e Don't use button type=submit for CTA 2023-02-17 15:08:21 +01:00
tidy-dev f131e63c34
Merge pull request #16114 from desktop/change-list-context-menu-invoking
Invoking Context Menu from ListRow component
2023-02-17 07:37:17 -05:00
tidy-dev 1c8dcaa1af
Update app/src/ui/lib/list/list-row.tsx
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
2023-02-17 07:13:55 -05:00
Markus Olsson 2729204c7c Merge branch 'development' into file-statuses-accessible-3283 2023-02-17 12:32:33 +01:00
Markus Olsson 9ec551d76b
Merge pull request #16108 from desktop/list-aria-fixes
Get rid of blank role attribute and rowgroup role on the innerGrid
2023-02-17 11:35:36 +01:00
tidy-dev bb6744c2d1 Merge branch 'list-aria-fixes' into change-list-context-menu-invoking 2023-02-16 14:53:53 -05:00
tidy-dev 2db776d7f3 Linter 2023-02-16 14:53:41 -05:00
tidy-dev 2b097bd364 Merge branch 'development' into change-list-context-menu-invoking 2023-02-16 13:34:45 -05:00
tidy-dev 69e3c59273 Add a list-row ariaLabel property and callback 2023-02-16 12:30:10 -05:00
Sergio Padrino 2fe76be965 Replace "Review Comment" with just "Comment" 2023-02-16 17:55:19 +01:00
Sergio Padrino 4d43566f8f Now request all issue and review comments from PRs… 2023-02-16 17:52:56 +01:00
Sergio Padrino 603d3994b3 Set the correct PullRequestCommentLike id 2023-02-16 17:52:38 +01:00
tidy-dev d1a3a2bebc Add aria-label prop to list-row 2023-02-16 09:44:17 -05:00
tidy-dev 6a381364fe
Merge pull request #16136 from desktop/releases/3.1.7
Release 3.1.7
2023-02-16 09:28:18 -05:00
tidy-dev 776684d4d8
Merge pull request #16133 from desktop/Misattributed-Commit-Button-Description
Give Misattributed Warning Avatar button a label
2023-02-16 09:27:27 -05:00
tidy-dev ffa8d28a05
Merge branch 'development' into releases/3.1.7 2023-02-16 09:02:38 -05:00
tidy-dev 8a4989878b
Merge pull request #16135 from desktop/releases/3.1.7-beta1
Release 3.1.7-beta1
2023-02-16 09:01:26 -05:00
tidy-dev e77ae2c73e Merge branch 'development' into file-statuses-accessible-3283 2023-02-16 08:57:58 -05:00
Sergio Padrino ccddcaa46e
Merge branch 'development' into releases/3.1.7-beta1 2023-02-15 15:23:08 +01:00
Markus Olsson 97eef00452 Update yarn.lock 2023-02-15 10:22:13 +01:00
Markus Olsson 4a24c245e4 Update yarn.lock 2023-02-15 09:04:57 +01:00
tidy-dev ec9a3f4c70 Dugite bump in app/package.json 2023-02-14 16:16:55 -05:00
tidy-dev 76a375aab9 Dugite bump in app/package.json 2023-02-14 16:16:44 -05:00
tidy-dev c24586e59a Release 3.1.7 2023-02-14 16:14:08 -05:00
tidy-dev 961daaa90a Upgrade dugite - to bump git to 2.39.2 2023-02-14 16:13:07 -05:00
tidy-dev 91abcc0d5e Release 3.1.7-beta1 2023-02-14 16:11:49 -05:00
tidy-dev bf6dfd8dcf Upgrade dugite - to bump git to 2.39.2 2023-02-14 16:09:20 -05:00
tidy-dev 17cc30593e Prevent default on close button 2023-02-14 14:50:06 -05:00
Markus Olsson aa886f246c Merge remote-tracking branch 'origin/development' into make-dialog-x-keyboard-navigable 2023-02-14 18:33:02 +01:00
Markus Olsson be270609f9 These are not the droids you are looking for 2023-02-14 18:31:24 +01:00
tidy-dev d941c53870 Give avatar button a label 2023-02-14 11:59:33 -05:00
Markus Olsson 3a5350dfb7 Merge branch 'development' into list-aria-fixes 2023-02-14 14:05:34 +01:00
Markus Olsson bec8dad7c3 Specify container props type 2023-02-14 14:04:43 +01:00
Markus Olsson 7551953c20
Merge pull request #16125 from desktop/sign-in-flow-kbd-focus
Focus on first suitable child in sign in flow
2023-02-14 12:57:05 +01:00
tidy-dev c2844bf03b Replace label with span 2023-02-14 06:46:27 -05:00
Markus Olsson 5af983c104 Maintain reference equality for containerProps when possible 2023-02-14 12:34:01 +01:00
tidy-dev 53598d3f1d
Merge pull request #16111 from desktop/Avatar-only-a-button-when-it-needs-to-be
Avatar only a button when it needs to be
2023-02-14 05:53:41 -05:00
Markus Olsson 94dcac88b7 Improve docs and ignore aria-readonly 2023-02-14 10:39:57 +01:00
Sergio Padrino fa4b31bc7e
Merge pull request #16096 from desktop/test-notifications-tool
Add new tool to easily test notifications from real data
2023-02-14 09:07:55 +01:00
Sergio Padrino 10a2463996
Merge pull request #16095 from desktop/refactor-pr-review-dialog
Refactor Pull Request review dialog
2023-02-13 16:31:45 +01:00
Markus Olsson 4d419e4079 Move a11y props to the Grid component 2023-02-13 15:00:58 +01:00