Commit graph

26982 commits

Author SHA1 Message Date
Markus Olsson c035f3f91c
Merge branch 'development' into releases/3.1.9-beta1 2023-02-22 10:40:49 +01:00
Markus Olsson a685379a99
Merge pull request #16150 from desktop/preferences-initial-focus
Focus on tabs when opening preferences dialog
2023-02-22 08:13:00 +01:00
Markus Olsson d036395bdc Changelog and version bump 2023-02-22 06:46:50 +01:00
Markus Olsson 9325c8be4c There are no propTypes in prod builds 2023-02-22 06:43:22 +01:00
Markus Olsson 820d596b11
Merge pull request #16151 from desktop/no-proptypes-in-prod-builds
Fix prod build crash due to propTypes not being defined
2023-02-22 06:41:27 +01:00
Sergio Padrino bb6780783a
Merge pull request #16097 from desktop/pr-comment-notifications-support
Basic support for Pull Request comment notifications
2023-02-21 11:07:02 +01:00
tidy-dev ce52aefdfb Release 3.1.9-beta1 2023-02-17 12:20:16 -05:00
tidy-dev ec166fcc7d
Merge pull request #16041 from ansidev/feature/integration-tabby-terminal
feat(integration): add Tabby terminal integration for macOS
2023-02-17 09:52:57 -05:00
Markus Olsson 4335b01671 There are no propTypes in prod builds 2023-02-17 15:45:34 +01:00
Markus Olsson 38c6c6265e Don't use button type=submit for CTA 2023-02-17 15:08:21 +01:00
tidy-dev f131e63c34
Merge pull request #16114 from desktop/change-list-context-menu-invoking
Invoking Context Menu from ListRow component
2023-02-17 07:37:17 -05:00
tidy-dev 1c8dcaa1af
Update app/src/ui/lib/list/list-row.tsx
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
2023-02-17 07:13:55 -05:00
Markus Olsson 2729204c7c Merge branch 'development' into file-statuses-accessible-3283 2023-02-17 12:32:33 +01:00
Markus Olsson 9ec551d76b
Merge pull request #16108 from desktop/list-aria-fixes
Get rid of blank role attribute and rowgroup role on the innerGrid
2023-02-17 11:35:36 +01:00
tidy-dev bb6744c2d1 Merge branch 'list-aria-fixes' into change-list-context-menu-invoking 2023-02-16 14:53:53 -05:00
tidy-dev 2db776d7f3 Linter 2023-02-16 14:53:41 -05:00
tidy-dev 2b097bd364 Merge branch 'development' into change-list-context-menu-invoking 2023-02-16 13:34:45 -05:00
tidy-dev 69e3c59273 Add a list-row ariaLabel property and callback 2023-02-16 12:30:10 -05:00
Sergio Padrino 2fe76be965 Replace "Review Comment" with just "Comment" 2023-02-16 17:55:19 +01:00
Sergio Padrino 4d43566f8f Now request all issue and review comments from PRs… 2023-02-16 17:52:56 +01:00
Sergio Padrino 603d3994b3 Set the correct PullRequestCommentLike id 2023-02-16 17:52:38 +01:00
tidy-dev d1a3a2bebc Add aria-label prop to list-row 2023-02-16 09:44:17 -05:00
tidy-dev 6a381364fe
Merge pull request #16136 from desktop/releases/3.1.7
Release 3.1.7
2023-02-16 09:28:18 -05:00
tidy-dev 776684d4d8
Merge pull request #16133 from desktop/Misattributed-Commit-Button-Description
Give Misattributed Warning Avatar button a label
2023-02-16 09:27:27 -05:00
tidy-dev ffa8d28a05
Merge branch 'development' into releases/3.1.7 2023-02-16 09:02:38 -05:00
tidy-dev 8a4989878b
Merge pull request #16135 from desktop/releases/3.1.7-beta1
Release 3.1.7-beta1
2023-02-16 09:01:26 -05:00
tidy-dev e77ae2c73e Merge branch 'development' into file-statuses-accessible-3283 2023-02-16 08:57:58 -05:00
Sergio Padrino ccddcaa46e
Merge branch 'development' into releases/3.1.7-beta1 2023-02-15 15:23:08 +01:00
Markus Olsson 97eef00452 Update yarn.lock 2023-02-15 10:22:13 +01:00
Markus Olsson 4a24c245e4 Update yarn.lock 2023-02-15 09:04:57 +01:00
tidy-dev ec9a3f4c70 Dugite bump in app/package.json 2023-02-14 16:16:55 -05:00
tidy-dev 76a375aab9 Dugite bump in app/package.json 2023-02-14 16:16:44 -05:00
tidy-dev c24586e59a Release 3.1.7 2023-02-14 16:14:08 -05:00
tidy-dev 961daaa90a Upgrade dugite - to bump git to 2.39.2 2023-02-14 16:13:07 -05:00
tidy-dev 91abcc0d5e Release 3.1.7-beta1 2023-02-14 16:11:49 -05:00
tidy-dev bf6dfd8dcf Upgrade dugite - to bump git to 2.39.2 2023-02-14 16:09:20 -05:00
tidy-dev 17cc30593e Prevent default on close button 2023-02-14 14:50:06 -05:00
Markus Olsson aa886f246c Merge remote-tracking branch 'origin/development' into make-dialog-x-keyboard-navigable 2023-02-14 18:33:02 +01:00
Markus Olsson be270609f9 These are not the droids you are looking for 2023-02-14 18:31:24 +01:00
tidy-dev d941c53870 Give avatar button a label 2023-02-14 11:59:33 -05:00
Markus Olsson 3a5350dfb7 Merge branch 'development' into list-aria-fixes 2023-02-14 14:05:34 +01:00
Markus Olsson bec8dad7c3 Specify container props type 2023-02-14 14:04:43 +01:00
Markus Olsson 7551953c20
Merge pull request #16125 from desktop/sign-in-flow-kbd-focus
Focus on first suitable child in sign in flow
2023-02-14 12:57:05 +01:00
tidy-dev c2844bf03b Replace label with span 2023-02-14 06:46:27 -05:00
Markus Olsson 5af983c104 Maintain reference equality for containerProps when possible 2023-02-14 12:34:01 +01:00
tidy-dev 53598d3f1d
Merge pull request #16111 from desktop/Avatar-only-a-button-when-it-needs-to-be
Avatar only a button when it needs to be
2023-02-14 05:53:41 -05:00
Markus Olsson 94dcac88b7 Improve docs and ignore aria-readonly 2023-02-14 10:39:57 +01:00
Sergio Padrino fa4b31bc7e
Merge pull request #16096 from desktop/test-notifications-tool
Add new tool to easily test notifications from real data
2023-02-14 09:07:55 +01:00
Sergio Padrino 10a2463996
Merge pull request #16095 from desktop/refactor-pr-review-dialog
Refactor Pull Request review dialog
2023-02-13 16:31:45 +01:00
Markus Olsson 4d419e4079 Move a11y props to the Grid component 2023-02-13 15:00:58 +01:00
Markus Olsson dbdd59c338 Remove unused ariaMode 2023-02-13 14:56:41 +01:00
Markus Olsson 5c7f4a788f Focus on first suitable child in sign in flow
When switching steps in the sign in flow we're essentially showing a new dialog (or at least it should behave as such) which means we'll need to reset the focus, if we don't then keyboard focus will just flow to the body whenever we change the dialog contents.
2023-02-13 11:48:21 +01:00
Markus Olsson a567e4e6d9 Favor ordinary buttons over the close button 2023-02-13 11:37:59 +01:00
tidy-dev 1aa0d389d4 Log out the current target 2023-02-10 14:21:58 -05:00
tidy-dev 50f41c54df bubbling up context menu invocation from list row in changes list 2023-02-10 13:52:24 -05:00
tidy-dev a72cb4907c Avatar only a button when it needs to be 2023-02-10 12:02:56 -05:00
tidy-dev 30a0f07d3b Make the close button a button; allow it to have focus 2023-02-10 11:39:36 -05:00
tidy-dev e9c383778c Use aria-label to describe the file 2023-02-10 10:41:13 -05:00
Markus Olsson d8142c50c0 Get rid of blank role attribute and rowgroup role on the innerGrid 2023-02-10 15:49:13 +01:00
Le Minh Tri f9ed154425
Merge remote-tracking branch 'origin/development' into feature/integration-tabby-terminal 2023-02-10 03:20:22 +07:00
tidy-dev 1099009f83 Revert "Make file status and checked status voice over annouceable"
This reverts commit dbfdbc5eeb.
2023-02-09 14:14:50 -05:00
tidy-dev 19431ced93
Merge pull request #16100 from desktop/avatar-keyboard-accessible
Commit Message/Misattributed commits Avatar Keyboard Accessible
2023-02-09 13:19:19 -05:00
tidy-dev a441ac72f2 Make border-radius of avatar button match avatar image 2023-02-09 12:22:01 -05:00
tidy-dev 04b9b3e55b
Merge pull request #16031 from tsvetilian-ty/dataspell-support-windows
JetBrains DataSpell support on Windows
2023-02-09 10:16:25 -05:00
tidy-dev f1019d2fdc
Merge pull request #16021 from jm-rivera/patch-1
Add DataSpell to darwin.ts
2023-02-09 10:11:57 -05:00
tidy-dev 2ef16d031d Add better, targeted styles 2023-02-09 09:27:45 -05:00
tidy-dev 05f3631a71 Make commit message avatar into a button 2023-02-09 09:21:19 -05:00
tidy-dev dbfdbc5eeb Make file status and checked status voice over annouceable 2023-02-09 08:45:13 -05:00
Sergio Padrino a481b032a2 Add support for PR comment notifications 2023-02-09 13:28:26 +01:00
Sergio Padrino 786f814d5e Add new tool to easily test notifications from real data 2023-02-09 13:23:44 +01:00
Sergio Padrino bae2b7dc5c Refactor PR review dialog 2023-02-09 13:14:12 +01:00
Le Minh Tri 51c21413ad
fix: handle logic for launching Tabby shell in a specified working dicrectory 2023-02-09 10:21:33 +07:00
Le Minh Tri 06abd7516c
Merge remote-tracking branch 'origin/development' into feature/integration-tabby-terminal 2023-02-09 10:14:45 +07:00
Sergio Padrino 297656a4c8
Merge pull request #16029 from adil192/patch-1
Add some IDEs from JetBrains Toolbox to Linux
2023-02-08 10:03:54 +01:00
Sergio Padrino d1a16d80e8
Merge branch 'development' into releases/3.1.6 2023-02-07 12:09:03 +01:00
Sergio Padrino 3abd7b29ac Bump changelog and version to 3.1.6 2023-02-06 16:50:50 +01:00
Sergio Padrino 43f1b55d8e Merge pull request #15915 from desktop/bump-git-2.39.0
Bump to git 2.39.0 and git-lfs 3.3.0
2023-02-06 16:48:56 +01:00
dependabot[bot] 6109dd49fa
Bump jszip from 3.7.1 to 3.10.1 in /app
Bumps [jszip](https://github.com/Stuk/jszip) from 3.7.1 to 3.10.1.
- [Release notes](https://github.com/Stuk/jszip/releases)
- [Changelog](https://github.com/Stuk/jszip/blob/main/CHANGES.md)
- [Commits](https://github.com/Stuk/jszip/compare/v3.7.1...v3.10.1)

---
updated-dependencies:
- dependency-name: jszip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-02-03 07:42:35 +00:00
Adil Hanney fe3fdfa62d
yarn lint:fix 2023-02-02 12:54:05 +00:00
tidy-dev 89c4daa00a Add axeDevTools extension 2023-02-01 13:03:50 -05:00
Le Minh Tri fc752078f4
feat(integration): add Tabby terminal integration for macOS 2023-01-31 14:10:51 +07:00
Tsvetilian Yankov 47152957bf Add support for JetBrains DataSpell on Windows 2023-01-30 00:43:17 +02:00
Brendan Forster b37a25a88e Add support for numerous additional editors on Linux
- Kate
 - gEdit
 - Notepadqq
 - GNOME Text Editor
 - GNOME Builder
 - VSCode (from WSL)
 - Geany
 - Mousepad

Co-Authored-By: gwyn <29720696+avalonv@users.noreply.github.com>
Co-Authored-By: PadowYT2 <71085027+PadowYT2@users.noreply.github.com>
Co-Authored-By: theofficialgman <28281419+theofficialgman@users.noreply.github.com>
Co-Authored-By: Amin Yahyaabadi <16418197+aminya@users.noreply.github.com>
Co-Authored-By: Etaash Mathamsetty <45927311+Etaash-mathamsetty@users.noreply.github.com>
Co-Authored-By: Richard Kellnberger <5147221+Richardk2n@users.noreply.github.com>
Co-Authored-By: Sky Barnes <429099+tsbarnes@users.noreply.github.com>
2023-01-29 16:36:00 -04:00
Adil Hanney 5f77706120
Recapitalise JetBrains 2023-01-29 20:30:03 +00:00
Adil Hanney 7bb7724f60
Add some IDEs from JetBrains Toolbox to Linux
I'm not sure about the snap locations but I've added them in for completeness. If I should remove them, let me know :)
2023-01-29 20:24:39 +00:00
tidy-dev 63592700cf
Need each one..
Co-authored-by: Sergio Padrino <sergiou87@github.com>
2023-01-27 10:52:12 -05:00
tidy-dev 13332ca8e3 Check for content 2023-01-27 10:17:15 -05:00
tidy-dev bd9513d397 Merge branch 'development' into pr/15165 2023-01-27 10:13:00 -05:00
Jorge Rivera 5fd16c922b
Add DataSpell to darwin.ts
Modify list of external editors to include JetBrains DataSpell
2023-01-27 14:48:20 +01:00
Sergio Padrino bce5000e43 Bump changelog and version to 3.1.6-beta2 2023-01-26 16:04:27 +01:00
Sergio Padrino 16eb9c1832
Merge pull request #15821 from Shivareddy-Aluri/trim-white-spaces-before-saving
Trim white spaces before saving repository URL changes
2023-01-26 11:41:59 +01:00
Sergio Padrino 21ecffa10d
Merge pull request #16003 from desktop/releases/3.1.6-beta1
Release 3.1.6-beta1
2023-01-26 11:37:23 +01:00
Sergio Padrino ed4c2d5546
Merge pull request #15813 from desktop/rstudio-fix
Update RStudio publisher to fix integration
2023-01-26 10:23:32 +01:00
Sergio Padrino d94b726686
Merge pull request #15981 from desktop/force-push-dropdown-optional-warning
Only show force-push warning when confirmation dialog is disabled
2023-01-26 10:05:45 +01:00
tidy-dev b66d481a47 Release 3.1.6-beta1 2023-01-25 12:57:47 -05:00
tidy-dev 89989fb958
Merge pull request #15982 from desktop/releases/3.1.5
Release 3.1.5
2023-01-25 12:14:57 -05:00
Sergio Padrino 18d1d6e0ee
Merge pull request #15915 from desktop/bump-git-2.39.0
Bump to git 2.39.0 and git-lfs 3.3.0
2023-01-25 18:08:23 +01:00
dependabot[bot] de25b4e03e
Bump ua-parser-js from 0.7.28 to 0.7.33 in /app
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.28 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.28...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-01-25 16:49:21 +00:00
tidy-dev 88b8bcd56e
Merge pull request #15831 from desktop/electron-22-0-0
Bump Electron to v22.0.3
2023-01-25 11:48:41 -05:00
Sergio Padrino c6e0865d6a
Merge branch 'development' into releases/3.1.5 2023-01-25 17:46:05 +01:00
Steve Ward e09e61c8d7
Merge branch 'development' into rstudio-fix 2023-01-24 07:12:47 -08:00
Steve Ward 45a8aecc07
Update app/src/lib/editors/win32.ts
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
2023-01-24 10:10:14 -05:00
Shivareddy-Aluri c3437a4469
Update repository-settings.tsx 2023-01-23 23:27:09 +05:30
tidy-dev 7f903a3056 Update Response Type to CallbackResponse Type 2023-01-23 11:42:41 -05:00
Sergio Padrino 61c5bdd57a Enable preventing closing while updating feature flag 2023-01-23 17:21:57 +01:00
Sergio Padrino 561930573f Bump changelog and version to 3.1.5 2023-01-23 17:21:20 +01:00
Sergio Padrino e6bfcc9bd9 Only show force-push warning when confirmation dialog is disabled 2023-01-23 13:12:16 +01:00
Sergio Padrino 924ab82c45
Merge pull request #15907 from desktop/pull-push-dropdown
Pull-push-fetch button + dropdown
2023-01-23 09:44:07 +01:00
Shivareddy-Aluri 144f30d8f8
Update repository-settings.tsx 2023-01-22 23:34:19 +05:30
Shivareddy-Aluri 9bf66270b7
Update repository-settings.tsx 2023-01-22 23:25:39 +05:30
Sergio Padrino f42da5109d Remove unnecessary parameters 2023-01-20 13:25:48 +01:00
Sergio Padrino 18c1553462 Feature-flag push-pull-fetch dropdown for beta builds 2023-01-20 13:10:05 +01:00
Shivareddy-Aluri 1d9cbd3baa review changes 2023-01-19 22:14:22 +05:30
tidy-dev fb2c178303 Avoiding disabling the linter.. 2023-01-18 13:08:19 -05:00
Sergio Padrino 5f534e8541
Merge pull request #15917 from tsvetilian-ty/macos-clion-support
Add JetBrains CLion support on macOS
2023-01-18 18:45:15 +01:00
Sergio Padrino 1eefb02f30 Merge branch 'development' into bump-git-2.39.0 2023-01-18 14:41:12 +01:00
Sergio Padrino 3deab3944b Bump dugite to 2.3.0 2023-01-18 14:05:02 +01:00
Sergio Padrino b909d42a8b
Merge branch 'development' into releases/3.1.4 2023-01-18 14:03:12 +01:00
Sergio Padrino 90527172a3
Merge pull request #15957 from desktop/releases/3.1.4-beta1
Release 3.1.4-beta1
2023-01-18 14:02:00 +01:00
Sergio Padrino 5c61417b10 Merge branch 'development' into bump-git-2.39.0 2023-01-18 14:00:47 +01:00
Dawn Walker 5380ffcb89 Update win32.ts 2023-01-18 21:05:09 +11:00
Markus Olsson eaeb66dd81 Move dugite dependency to app 2023-01-18 08:37:33 +01:00
Markus Olsson 54965753e3 Bump dugite in app folder 2023-01-18 08:36:03 +01:00
Dawn Walker f745df411c Update win32.ts 2023-01-18 17:06:28 +11:00
Dawn Walker e5af050d2d
Merge branch 'desktop:development' into development 2023-01-18 11:54:42 +11:00
tidy-dev ba6e0f13c0 Release 3.1.4 2023-01-17 15:43:19 -05:00
tidy-dev b55ac83289 Release 3.1.4-beta1 2023-01-17 15:29:40 -05:00
Sergio Padrino ced3ceae7a
Merge pull request #15780 from tsvetilian-ty/jetbrains-toolbox-support
Support for JetBrains Toolbox and JetBrains Fleet editor
2023-01-17 18:16:01 +01:00
Tsvetilian Yankov bdbc0ac820 Add JetBrains CLion support on MacOS 2023-01-12 22:55:47 +02:00
Sergio Padrino 7ce8047563 Update line endings change regex
This string changed in c970d30c2c
2023-01-12 17:01:53 +01:00
Sergio Padrino 7ec8e034cb Fix styling issues due to initial focus 2023-01-11 18:41:15 +01:00
Sergio Padrino 8412b4a6e1 Fix keyboard navigation due to modulo bug 2023-01-11 18:34:57 +01:00
Sergio Padrino 2d1f8f0002 Use the right colors for hover state 2023-01-11 16:26:26 +01:00
Sergio Padrino 746c32a407 Extract class name into constant 2023-01-11 13:30:14 +01:00
Sergio Padrino 8b227851ba Enable Up and Down arrows to navigate dropdown items 2023-01-11 13:28:55 +01:00
Sergio Padrino eb589b0c1c Only show force-push dropdown action on diverged branches 2023-01-11 12:05:42 +01:00
Sergio Padrino 4f34e2aac3 Add warning for force-push dropdown item 2023-01-11 11:44:35 +01:00
Sergio Padrino 2ab62206a0 No need for FocusTrap. Dropdowns already have one 2023-01-10 17:30:26 +01:00
Sergio Padrino 8920fb29a9 Refactor rendering push-pull dropdown items 2023-01-10 17:29:06 +01:00
Sergio Padrino 4ff49a42af Use dropdown or plain button depending on repo state 2023-01-10 17:12:54 +01:00
Sergio Padrino a507ce9b11 (WIP) First steps refactoring ToolbarDropdown 2023-01-09 12:31:35 +01:00
Sergio Padrino 39aaae548d (WIP) Trying to get an accessible dropdown working! 2023-01-09 12:31:35 +01:00
tidy-dev 41674c655e
Merge pull request #15864 from desktop/Align-branch-to-center
Align no branches text in the center
2023-01-05 12:57:35 -05:00
Sergio Padrino ce4fbb259e Merge branch 'development' into releases/3.1.3 2023-01-05 15:50:43 +01:00
Shivareddy-Aluri 5e3064cbe8 Update repository-settings.tsx 2023-01-05 00:07:26 +05:30
tidy-dev 94f50d3b3f Align no branches text in the center 2023-01-04 10:31:40 -05:00
tidy-dev af7b8ae7d1 Revert "Align no branches text in the center"
This reverts commit 2b3eaaaffd.
2023-01-04 10:31:21 -05:00
tidy-dev 2b3eaaaffd Align no branches text in the center 2023-01-04 10:30:26 -05:00
tidy-dev 37d0a59135
typo..
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
2023-01-04 09:38:42 -05:00
tidy-dev ce10ec491f Some reason this was missing? 2023-01-04 09:36:45 -05:00