2005-05-23 17:52:17 +00:00
|
|
|
/*
|
|
|
|
* apply.c
|
|
|
|
*
|
|
|
|
* Copyright (C) Linus Torvalds, 2005
|
|
|
|
*
|
|
|
|
* This applies patches on top of some (arbitrary) version of the SCM.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
#include "cache.h"
|
2006-04-23 23:52:52 +00:00
|
|
|
#include "cache-tree.h"
|
2005-10-15 04:54:52 +00:00
|
|
|
#include "quote.h"
|
2006-04-02 12:44:09 +00:00
|
|
|
#include "blob.h"
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
#include "delta.h"
|
2006-05-23 12:15:34 +00:00
|
|
|
#include "builtin.h"
|
2005-05-23 17:52:17 +00:00
|
|
|
|
2006-07-10 06:57:51 +00:00
|
|
|
/*
|
|
|
|
* --check turns on checking that the working tree matches the
|
|
|
|
* files that are being modified, but doesn't apply the patch
|
|
|
|
* --stat does just a diffstat, and doesn't actually apply
|
|
|
|
* --numstat does numeric diffstat, and doesn't actually apply
|
|
|
|
* --index-info shows the old and new index info for paths if available.
|
|
|
|
* --index updates the cache as well.
|
|
|
|
* --cached updates only the cache without ever touching the working tree.
|
|
|
|
*/
|
2005-11-26 07:14:15 +00:00
|
|
|
static const char *prefix;
|
|
|
|
static int prefix_length = -1;
|
2006-05-09 08:08:23 +00:00
|
|
|
static int newfd = -1;
|
2005-11-26 07:14:15 +00:00
|
|
|
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
static int unidiff_zero;
|
2006-01-31 05:36:24 +00:00
|
|
|
static int p_value = 1;
|
2007-02-22 00:05:56 +00:00
|
|
|
static int p_value_known;
|
2006-08-15 17:23:48 +00:00
|
|
|
static int check_index;
|
2007-04-02 05:46:06 +00:00
|
|
|
static int update_index;
|
2006-08-15 17:23:48 +00:00
|
|
|
static int cached;
|
|
|
|
static int diffstat;
|
|
|
|
static int numstat;
|
|
|
|
static int summary;
|
|
|
|
static int check;
|
2005-05-26 22:10:02 +00:00
|
|
|
static int apply = 1;
|
2006-08-15 17:23:48 +00:00
|
|
|
static int apply_in_reverse;
|
2006-08-17 00:55:29 +00:00
|
|
|
static int apply_with_reject;
|
2006-08-18 10:14:48 +00:00
|
|
|
static int apply_verbosely;
|
2006-08-15 17:23:48 +00:00
|
|
|
static int no_add;
|
2007-09-17 22:34:06 +00:00
|
|
|
static const char *fake_ancestor;
|
2005-10-15 04:54:52 +00:00
|
|
|
static int line_termination = '\n';
|
2006-11-05 07:27:07 +00:00
|
|
|
static unsigned long p_context = ULONG_MAX;
|
2005-07-14 03:28:55 +00:00
|
|
|
static const char apply_usage[] =
|
2007-11-24 19:57:41 +00:00
|
|
|
"git-apply [--stat] [--numstat] [--summary] [--check] [--index] [--cached] [--apply] [--no-add] [--index-info] [--allow-binary-replacement] [--reverse] [--reject] [--verbose] [-z] [-pNUM] [-CNUM] [--whitespace=<nowarn|warn|fix|error|error-all>] <patch>...";
|
2005-05-23 17:52:17 +00:00
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
static enum ws_error_action {
|
|
|
|
nowarn_ws_error,
|
|
|
|
warn_on_ws_error,
|
|
|
|
die_on_ws_error,
|
|
|
|
correct_ws_error,
|
|
|
|
} ws_error_action = warn_on_ws_error;
|
2006-08-15 17:23:48 +00:00
|
|
|
static int whitespace_error;
|
2006-02-27 22:16:30 +00:00
|
|
|
static int squelch_whitespace_errors = 5;
|
2007-06-03 02:55:54 +00:00
|
|
|
static int applied_after_fixing_ws;
|
2006-08-15 17:23:48 +00:00
|
|
|
static const char *patch_input_file;
|
The war on trailing whitespace
On Sat, 25 Feb 2006, Andrew Morton wrote:
>
> I'd suggest a) git will simply refuse to apply such a patch unless given a
> special `forcing' flag, b) even when thus forced, it will still warn and c)
> with a different flag, it will strip-then-apply, without generating a
> warning.
This doesn't do the "strip-then-apply" thing, but it allows you to make
git-apply generate a warning or error on extraneous whitespace.
Use --whitespace=warn to warn, and (surprise, surprise) --whitespace=error
to make it a fatal error to have whitespace at the end.
Totally untested, of course. But it compiles, so it must be fine.
HOWEVER! Note that this literally will check every single patch-line with
"+" at the beginning. Which means that if you fix a simple typo, and the
line had a space at the end before, and you didn't remove it, that's still
considered a "new line with whitespace at the end", even though obviously
the line wasn't really new.
I assume this is what you wanted, and there isn't really any sane
alternatives (you could make the warning activate only for _pure_
additions with no deletions at all in that hunk, but that sounds a bit
insane).
Linus
2006-02-26 17:29:00 +00:00
|
|
|
|
2006-02-27 22:47:45 +00:00
|
|
|
static void parse_whitespace_option(const char *option)
|
|
|
|
{
|
|
|
|
if (!option) {
|
2007-11-23 10:37:03 +00:00
|
|
|
ws_error_action = warn_on_ws_error;
|
2006-02-27 22:47:45 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (!strcmp(option, "warn")) {
|
2007-11-23 10:37:03 +00:00
|
|
|
ws_error_action = warn_on_ws_error;
|
2006-02-27 22:47:45 +00:00
|
|
|
return;
|
|
|
|
}
|
2006-02-28 01:07:16 +00:00
|
|
|
if (!strcmp(option, "nowarn")) {
|
2007-11-23 10:37:03 +00:00
|
|
|
ws_error_action = nowarn_ws_error;
|
2006-02-28 01:07:16 +00:00
|
|
|
return;
|
|
|
|
}
|
2006-02-27 22:47:45 +00:00
|
|
|
if (!strcmp(option, "error")) {
|
2007-11-23 10:37:03 +00:00
|
|
|
ws_error_action = die_on_ws_error;
|
2006-02-27 22:47:45 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (!strcmp(option, "error-all")) {
|
2007-11-23 10:37:03 +00:00
|
|
|
ws_error_action = die_on_ws_error;
|
2006-02-27 22:47:45 +00:00
|
|
|
squelch_whitespace_errors = 0;
|
|
|
|
return;
|
|
|
|
}
|
2007-11-23 10:37:03 +00:00
|
|
|
if (!strcmp(option, "strip") || !strcmp(option, "fix")) {
|
|
|
|
ws_error_action = correct_ws_error;
|
2006-02-27 22:47:45 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
die("unrecognized whitespace option '%s'", option);
|
|
|
|
}
|
|
|
|
|
2006-02-28 09:12:52 +00:00
|
|
|
static void set_default_whitespace_mode(const char *whitespace_option)
|
|
|
|
{
|
2007-11-23 10:37:03 +00:00
|
|
|
if (!whitespace_option && !apply_default_whitespace)
|
|
|
|
ws_error_action = (apply ? warn_on_ws_error : nowarn_ws_error);
|
2006-02-28 09:12:52 +00:00
|
|
|
}
|
|
|
|
|
2005-05-26 18:40:43 +00:00
|
|
|
/*
|
|
|
|
* For "diff-stat" like behaviour, we keep track of the biggest change
|
|
|
|
* we've seen, and the longest filename. That allows us to do simple
|
|
|
|
* scaling.
|
|
|
|
*/
|
|
|
|
static int max_change, max_len;
|
|
|
|
|
2005-05-23 23:09:09 +00:00
|
|
|
/*
|
|
|
|
* Various "current state", notably line numbers and what
|
|
|
|
* file (and how) we're patching right now.. The "is_xxxx"
|
|
|
|
* things are flags, where -1 means "don't know yet".
|
|
|
|
*/
|
2005-05-23 21:38:49 +00:00
|
|
|
static int linenr = 1;
|
2005-05-26 17:23:51 +00:00
|
|
|
|
2006-08-15 09:23:06 +00:00
|
|
|
/*
|
|
|
|
* This represents one "hunk" from a patch, starting with
|
|
|
|
* "@@ -oldpos,oldlines +newpos,newlines @@" marker. The
|
|
|
|
* patch text is pointed at by patch, and its byte length
|
|
|
|
* is stored in size. leading and trailing are the number
|
|
|
|
* of context lines.
|
|
|
|
*/
|
2005-05-26 17:23:51 +00:00
|
|
|
struct fragment {
|
2006-04-10 09:33:06 +00:00
|
|
|
unsigned long leading, trailing;
|
2005-05-26 17:23:51 +00:00
|
|
|
unsigned long oldpos, oldlines;
|
|
|
|
unsigned long newpos, newlines;
|
|
|
|
const char *patch;
|
|
|
|
int size;
|
2006-08-17 00:55:29 +00:00
|
|
|
int rejected;
|
2005-05-26 17:23:51 +00:00
|
|
|
struct fragment *next;
|
|
|
|
};
|
|
|
|
|
2006-08-15 09:23:06 +00:00
|
|
|
/*
|
|
|
|
* When dealing with a binary patch, we reuse "leading" field
|
|
|
|
* to store the type of the binary hunk, either deflated "delta"
|
|
|
|
* or deflated "literal".
|
|
|
|
*/
|
|
|
|
#define binary_patch_method leading
|
|
|
|
#define BINARY_DELTA_DEFLATED 1
|
|
|
|
#define BINARY_LITERAL_DEFLATED 2
|
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* This represents a "patch" to a file, both metainfo changes
|
|
|
|
* such as creation/deletion, filemode and content changes represented
|
|
|
|
* as a series of fragments.
|
|
|
|
*/
|
2005-05-26 17:23:51 +00:00
|
|
|
struct patch {
|
2005-05-26 20:11:24 +00:00
|
|
|
char *new_name, *old_name, *def_name;
|
2005-05-26 17:23:51 +00:00
|
|
|
unsigned int old_mode, new_mode;
|
2006-11-18 12:07:09 +00:00
|
|
|
int is_new, is_delete; /* -1 = unknown, 0 = false, 1 = true */
|
2006-08-17 00:55:29 +00:00
|
|
|
int rejected;
|
2007-12-06 08:14:14 +00:00
|
|
|
unsigned ws_rule;
|
2006-05-05 09:41:53 +00:00
|
|
|
unsigned long deflate_origlen;
|
2005-05-26 18:40:43 +00:00
|
|
|
int lines_added, lines_deleted;
|
2005-06-22 09:29:46 +00:00
|
|
|
int score;
|
2007-02-21 22:31:10 +00:00
|
|
|
unsigned int is_toplevel_relative:1;
|
2006-11-18 12:07:09 +00:00
|
|
|
unsigned int inaccurate_eof:1;
|
|
|
|
unsigned int is_binary:1;
|
|
|
|
unsigned int is_copy:1;
|
|
|
|
unsigned int is_rename:1;
|
2005-05-26 17:23:51 +00:00
|
|
|
struct fragment *fragments;
|
2005-06-05 21:05:43 +00:00
|
|
|
char *result;
|
2007-10-21 09:23:49 +00:00
|
|
|
size_t resultsize;
|
2005-10-07 10:42:00 +00:00
|
|
|
char old_sha1_prefix[41];
|
|
|
|
char new_sha1_prefix[41];
|
2005-05-26 17:23:51 +00:00
|
|
|
struct patch *next;
|
|
|
|
};
|
2005-05-23 21:38:49 +00:00
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
/*
|
|
|
|
* A line in a file, len-bytes long (includes the terminating LF,
|
|
|
|
* except for an incomplete line at the end if the file ends with
|
|
|
|
* one), and its contents hashes to 'hash'.
|
|
|
|
*/
|
|
|
|
struct line {
|
|
|
|
size_t len;
|
|
|
|
unsigned hash : 24;
|
|
|
|
unsigned flag : 8;
|
2008-01-29 08:17:55 +00:00
|
|
|
#define LINE_COMMON 1
|
2008-01-27 01:42:49 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This represents a "file", which is an array of "lines".
|
|
|
|
*/
|
|
|
|
struct image {
|
|
|
|
char *buf;
|
|
|
|
size_t len;
|
|
|
|
size_t nr;
|
2008-01-29 08:17:55 +00:00
|
|
|
size_t alloc;
|
2008-01-27 01:42:49 +00:00
|
|
|
struct line *line_allocated;
|
|
|
|
struct line *line;
|
|
|
|
};
|
|
|
|
|
|
|
|
static uint32_t hash_line(const char *cp, size_t len)
|
|
|
|
{
|
|
|
|
size_t i;
|
|
|
|
uint32_t h;
|
|
|
|
for (i = 0, h = 0; i < len; i++) {
|
|
|
|
if (!isspace(cp[i])) {
|
|
|
|
h = h * 3 + (cp[i] & 0xff);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return h;
|
|
|
|
}
|
|
|
|
|
2008-01-29 08:17:55 +00:00
|
|
|
static void add_line_info(struct image *img, const char *bol, size_t len, unsigned flag)
|
|
|
|
{
|
|
|
|
ALLOC_GROW(img->line_allocated, img->nr + 1, img->alloc);
|
|
|
|
img->line_allocated[img->nr].len = len;
|
|
|
|
img->line_allocated[img->nr].hash = hash_line(bol, len);
|
|
|
|
img->line_allocated[img->nr].flag = flag;
|
|
|
|
img->nr++;
|
|
|
|
}
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
static void prepare_image(struct image *image, char *buf, size_t len,
|
|
|
|
int prepare_linetable)
|
|
|
|
{
|
|
|
|
const char *cp, *ep;
|
|
|
|
|
2008-01-29 08:17:55 +00:00
|
|
|
memset(image, 0, sizeof(*image));
|
2008-01-27 01:42:49 +00:00
|
|
|
image->buf = buf;
|
|
|
|
image->len = len;
|
|
|
|
|
2008-01-29 08:17:55 +00:00
|
|
|
if (!prepare_linetable)
|
2008-01-27 01:42:49 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
ep = image->buf + image->len;
|
|
|
|
cp = image->buf;
|
|
|
|
while (cp < ep) {
|
|
|
|
const char *next;
|
|
|
|
for (next = cp; next < ep && *next != '\n'; next++)
|
|
|
|
;
|
|
|
|
if (next < ep)
|
|
|
|
next++;
|
2008-01-29 08:17:55 +00:00
|
|
|
add_line_info(image, cp, next - cp, 0);
|
2008-01-27 01:42:49 +00:00
|
|
|
cp = next;
|
|
|
|
}
|
2008-01-29 08:17:55 +00:00
|
|
|
image->line = image->line_allocated;
|
2008-01-27 01:42:49 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void clear_image(struct image *image)
|
|
|
|
{
|
|
|
|
free(image->buf);
|
|
|
|
image->buf = NULL;
|
|
|
|
image->len = 0;
|
|
|
|
}
|
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
static void say_patch_name(FILE *output, const char *pre,
|
|
|
|
struct patch *patch, const char *post)
|
2006-08-18 10:14:48 +00:00
|
|
|
{
|
|
|
|
fputs(pre, output);
|
|
|
|
if (patch->old_name && patch->new_name &&
|
|
|
|
strcmp(patch->old_name, patch->new_name)) {
|
Full rework of quote_c_style and write_name_quoted.
* quote_c_style works on a strbuf instead of a wild buffer.
* quote_c_style is now clever enough to not add double quotes if not needed.
* write_name_quoted inherits those advantages, but also take a different
set of arguments. Now instead of asking for quotes or not, you pass a
"terminator". If it's \0 then we assume you don't want to escape, else C
escaping is performed. In any case, the terminator is also appended to the
stream. It also no longer takes the prefix/prefix_len arguments, as it's
seldomly used, and makes some optimizations harder.
* write_name_quotedpfx is created to work like write_name_quoted and take
the prefix/prefix_len arguments.
Thanks to those API changes, diff.c has somehow lost weight, thanks to the
removal of functions that were wrappers around the old write_name_quoted
trying to give it a semantics like the new one, but performing a lot of
allocations for this goal. Now we always write directly to the stream, no
intermediate allocation is performed.
As a side effect of the refactor in builtin-apply.c, the length of the bar
graphs in diffstats are not affected anymore by the fact that the path was
clipped.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
2007-09-19 22:42:15 +00:00
|
|
|
quote_c_style(patch->old_name, NULL, output, 0);
|
2006-08-18 10:14:48 +00:00
|
|
|
fputs(" => ", output);
|
Full rework of quote_c_style and write_name_quoted.
* quote_c_style works on a strbuf instead of a wild buffer.
* quote_c_style is now clever enough to not add double quotes if not needed.
* write_name_quoted inherits those advantages, but also take a different
set of arguments. Now instead of asking for quotes or not, you pass a
"terminator". If it's \0 then we assume you don't want to escape, else C
escaping is performed. In any case, the terminator is also appended to the
stream. It also no longer takes the prefix/prefix_len arguments, as it's
seldomly used, and makes some optimizations harder.
* write_name_quotedpfx is created to work like write_name_quoted and take
the prefix/prefix_len arguments.
Thanks to those API changes, diff.c has somehow lost weight, thanks to the
removal of functions that were wrappers around the old write_name_quoted
trying to give it a semantics like the new one, but performing a lot of
allocations for this goal. Now we always write directly to the stream, no
intermediate allocation is performed.
As a side effect of the refactor in builtin-apply.c, the length of the bar
graphs in diffstats are not affected anymore by the fact that the path was
clipped.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
2007-09-19 22:42:15 +00:00
|
|
|
quote_c_style(patch->new_name, NULL, output, 0);
|
|
|
|
} else {
|
2006-08-18 10:14:48 +00:00
|
|
|
const char *n = patch->new_name;
|
|
|
|
if (!n)
|
|
|
|
n = patch->old_name;
|
Full rework of quote_c_style and write_name_quoted.
* quote_c_style works on a strbuf instead of a wild buffer.
* quote_c_style is now clever enough to not add double quotes if not needed.
* write_name_quoted inherits those advantages, but also take a different
set of arguments. Now instead of asking for quotes or not, you pass a
"terminator". If it's \0 then we assume you don't want to escape, else C
escaping is performed. In any case, the terminator is also appended to the
stream. It also no longer takes the prefix/prefix_len arguments, as it's
seldomly used, and makes some optimizations harder.
* write_name_quotedpfx is created to work like write_name_quoted and take
the prefix/prefix_len arguments.
Thanks to those API changes, diff.c has somehow lost weight, thanks to the
removal of functions that were wrappers around the old write_name_quoted
trying to give it a semantics like the new one, but performing a lot of
allocations for this goal. Now we always write directly to the stream, no
intermediate allocation is performed.
As a side effect of the refactor in builtin-apply.c, the length of the bar
graphs in diffstats are not affected anymore by the fact that the path was
clipped.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
2007-09-19 22:42:15 +00:00
|
|
|
quote_c_style(n, NULL, output, 0);
|
2006-08-18 10:14:48 +00:00
|
|
|
}
|
|
|
|
fputs(post, output);
|
|
|
|
}
|
|
|
|
|
2005-05-23 17:52:17 +00:00
|
|
|
#define CHUNKSIZE (8192)
|
2005-05-23 23:09:09 +00:00
|
|
|
#define SLOP (16)
|
2005-05-23 17:52:17 +00:00
|
|
|
|
2007-09-27 11:33:19 +00:00
|
|
|
static void read_patch_file(struct strbuf *sb, int fd)
|
2005-05-23 17:52:17 +00:00
|
|
|
{
|
2007-09-27 11:33:19 +00:00
|
|
|
if (strbuf_read(sb, fd, 0) < 0)
|
2007-09-06 11:20:09 +00:00
|
|
|
die("git-apply: read returned %s", strerror(errno));
|
2005-05-23 23:09:09 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Make sure that we have some slop in the buffer
|
|
|
|
* so that we can do speculative "memcmp" etc, and
|
|
|
|
* see to it that it is NUL-filled.
|
|
|
|
*/
|
2007-09-27 11:33:19 +00:00
|
|
|
strbuf_grow(sb, SLOP);
|
|
|
|
memset(sb->buf + sb->len, 0, SLOP);
|
2005-05-23 17:52:17 +00:00
|
|
|
}
|
|
|
|
|
2005-06-05 18:03:13 +00:00
|
|
|
static unsigned long linelen(const char *buffer, unsigned long size)
|
2005-05-23 17:52:17 +00:00
|
|
|
{
|
|
|
|
unsigned long len = 0;
|
|
|
|
while (size--) {
|
|
|
|
len++;
|
|
|
|
if (*buffer++ == '\n')
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return len;
|
|
|
|
}
|
|
|
|
|
2005-05-23 23:09:09 +00:00
|
|
|
static int is_dev_null(const char *str)
|
|
|
|
{
|
|
|
|
return !memcmp("/dev/null", str, 9) && isspace(str[9]);
|
|
|
|
}
|
|
|
|
|
2005-05-31 22:05:59 +00:00
|
|
|
#define TERM_SPACE 1
|
|
|
|
#define TERM_TAB 2
|
2005-05-24 02:13:55 +00:00
|
|
|
|
|
|
|
static int name_terminate(const char *name, int namelen, int c, int terminate)
|
|
|
|
{
|
|
|
|
if (c == ' ' && !(terminate & TERM_SPACE))
|
|
|
|
return 0;
|
|
|
|
if (c == '\t' && !(terminate & TERM_TAB))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2007-02-20 01:57:29 +00:00
|
|
|
static char *find_name(const char *line, char *def, int p_value, int terminate)
|
2005-05-23 17:52:17 +00:00
|
|
|
{
|
2005-05-23 23:09:09 +00:00
|
|
|
int len;
|
|
|
|
const char *start = line;
|
|
|
|
|
2005-10-15 04:54:52 +00:00
|
|
|
if (*line == '"') {
|
2007-09-19 22:42:14 +00:00
|
|
|
struct strbuf name;
|
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* Proposed "new-style" GNU patch/diff format; see
|
2005-10-15 04:54:52 +00:00
|
|
|
* http://marc.theaimsgroup.com/?l=git&m=112927316408690&w=2
|
|
|
|
*/
|
2007-09-19 22:42:14 +00:00
|
|
|
strbuf_init(&name, 0);
|
|
|
|
if (!unquote_c_style(&name, line, NULL)) {
|
|
|
|
char *cp;
|
|
|
|
|
|
|
|
for (cp = name.buf; p_value; p_value--) {
|
2007-09-18 10:12:58 +00:00
|
|
|
cp = strchr(cp, '/');
|
2005-10-15 04:54:52 +00:00
|
|
|
if (!cp)
|
|
|
|
break;
|
|
|
|
cp++;
|
|
|
|
}
|
|
|
|
if (cp) {
|
|
|
|
/* name can later be freed, so we need
|
|
|
|
* to memmove, not just return cp
|
|
|
|
*/
|
2007-09-19 22:42:14 +00:00
|
|
|
strbuf_remove(&name, 0, cp - name.buf);
|
2005-10-15 04:54:52 +00:00
|
|
|
free(def);
|
2007-09-27 10:58:23 +00:00
|
|
|
return strbuf_detach(&name, NULL);
|
2005-10-15 04:54:52 +00:00
|
|
|
}
|
|
|
|
}
|
2007-09-19 22:42:14 +00:00
|
|
|
strbuf_release(&name);
|
2005-10-15 04:54:52 +00:00
|
|
|
}
|
|
|
|
|
2005-05-23 17:52:17 +00:00
|
|
|
for (;;) {
|
2005-05-23 23:09:09 +00:00
|
|
|
char c = *line;
|
2005-05-24 02:13:55 +00:00
|
|
|
|
|
|
|
if (isspace(c)) {
|
|
|
|
if (c == '\n')
|
|
|
|
break;
|
|
|
|
if (name_terminate(start, line-start, c, terminate))
|
|
|
|
break;
|
|
|
|
}
|
2005-05-23 23:09:09 +00:00
|
|
|
line++;
|
|
|
|
if (c == '/' && !--p_value)
|
|
|
|
start = line;
|
|
|
|
}
|
|
|
|
if (!start)
|
|
|
|
return def;
|
|
|
|
len = line - start;
|
|
|
|
if (!len)
|
|
|
|
return def;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Generally we prefer the shorter name, especially
|
|
|
|
* if the other one is just a variation of that with
|
|
|
|
* something else tacked on to the end (ie "file.orig"
|
|
|
|
* or "file~").
|
|
|
|
*/
|
|
|
|
if (def) {
|
|
|
|
int deflen = strlen(def);
|
|
|
|
if (deflen < len && !strncmp(start, def, deflen))
|
|
|
|
return def;
|
2007-09-19 08:37:50 +00:00
|
|
|
free(def);
|
2005-05-23 17:52:17 +00:00
|
|
|
}
|
2005-05-23 23:09:09 +00:00
|
|
|
|
2007-09-15 22:32:36 +00:00
|
|
|
return xmemdupz(start, len);
|
2005-05-23 23:09:09 +00:00
|
|
|
}
|
|
|
|
|
2007-02-22 00:05:56 +00:00
|
|
|
static int count_slashes(const char *cp)
|
|
|
|
{
|
|
|
|
int cnt = 0;
|
|
|
|
char ch;
|
|
|
|
|
|
|
|
while ((ch = *cp++))
|
|
|
|
if (ch == '/')
|
|
|
|
cnt++;
|
|
|
|
return cnt;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Given the string after "--- " or "+++ ", guess the appropriate
|
|
|
|
* p_value for the given patch.
|
|
|
|
*/
|
|
|
|
static int guess_p_value(const char *nameline)
|
|
|
|
{
|
|
|
|
char *name, *cp;
|
|
|
|
int val = -1;
|
|
|
|
|
|
|
|
if (is_dev_null(nameline))
|
|
|
|
return -1;
|
|
|
|
name = find_name(nameline, NULL, 0, TERM_SPACE | TERM_TAB);
|
|
|
|
if (!name)
|
|
|
|
return -1;
|
|
|
|
cp = strchr(name, '/');
|
|
|
|
if (!cp)
|
|
|
|
val = 0;
|
|
|
|
else if (prefix) {
|
|
|
|
/*
|
|
|
|
* Does it begin with "a/$our-prefix" and such? Then this is
|
|
|
|
* very likely to apply to our directory.
|
|
|
|
*/
|
|
|
|
if (!strncmp(name, prefix, prefix_length))
|
|
|
|
val = count_slashes(prefix);
|
|
|
|
else {
|
|
|
|
cp++;
|
|
|
|
if (!strncmp(cp, prefix, prefix_length))
|
|
|
|
val = count_slashes(prefix) + 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
free(name);
|
|
|
|
return val;
|
|
|
|
}
|
|
|
|
|
2005-05-23 23:09:09 +00:00
|
|
|
/*
|
2008-05-17 08:46:47 +00:00
|
|
|
* Get the name etc info from the ---/+++ lines of a traditional patch header
|
2005-05-23 23:09:09 +00:00
|
|
|
*
|
2005-05-24 02:13:55 +00:00
|
|
|
* FIXME! The end-of-filename heuristics are kind of screwy. For existing
|
|
|
|
* files, we can happily check the index for a match, but for creating a
|
|
|
|
* new file we should try to match whatever "patch" does. I have no idea.
|
2005-05-23 23:09:09 +00:00
|
|
|
*/
|
2005-05-26 17:23:51 +00:00
|
|
|
static void parse_traditional_patch(const char *first, const char *second, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
|
|
|
char *name;
|
|
|
|
|
2006-07-10 06:57:51 +00:00
|
|
|
first += 4; /* skip "--- " */
|
|
|
|
second += 4; /* skip "+++ " */
|
2007-02-22 00:05:56 +00:00
|
|
|
if (!p_value_known) {
|
|
|
|
int p, q;
|
|
|
|
p = guess_p_value(first);
|
|
|
|
q = guess_p_value(second);
|
|
|
|
if (p < 0) p = q;
|
|
|
|
if (0 <= p && p == q) {
|
|
|
|
p_value = p;
|
|
|
|
p_value_known = 1;
|
|
|
|
}
|
|
|
|
}
|
2005-05-23 23:09:09 +00:00
|
|
|
if (is_dev_null(first)) {
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->is_new = 1;
|
|
|
|
patch->is_delete = 0;
|
2005-05-26 20:11:24 +00:00
|
|
|
name = find_name(second, NULL, p_value, TERM_SPACE | TERM_TAB);
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->new_name = name;
|
2005-05-23 23:09:09 +00:00
|
|
|
} else if (is_dev_null(second)) {
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->is_new = 0;
|
|
|
|
patch->is_delete = 1;
|
2005-05-31 22:05:59 +00:00
|
|
|
name = find_name(first, NULL, p_value, TERM_SPACE | TERM_TAB);
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->old_name = name;
|
2005-05-23 23:09:09 +00:00
|
|
|
} else {
|
2005-05-31 22:05:59 +00:00
|
|
|
name = find_name(first, NULL, p_value, TERM_SPACE | TERM_TAB);
|
|
|
|
name = find_name(second, name, p_value, TERM_SPACE | TERM_TAB);
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->old_name = patch->new_name = name;
|
2005-05-23 23:09:09 +00:00
|
|
|
}
|
|
|
|
if (!name)
|
|
|
|
die("unable to find filename in patch at line %d", linenr);
|
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_hdrend(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2005-05-24 02:54:55 +00:00
|
|
|
/*
|
|
|
|
* We're anal about diff header consistency, to make
|
|
|
|
* sure that we don't end up having strange ambiguous
|
|
|
|
* patches floating around.
|
|
|
|
*
|
|
|
|
* As a result, gitdiff_{old|new}name() will check
|
|
|
|
* their names against any previous information, just
|
|
|
|
* to make sure..
|
|
|
|
*/
|
|
|
|
static char *gitdiff_verify_name(const char *line, int isnull, char *orig_name, const char *oldnew)
|
|
|
|
{
|
|
|
|
if (!orig_name && !isnull)
|
2007-04-04 15:19:14 +00:00
|
|
|
return find_name(line, NULL, p_value, TERM_TAB);
|
2005-05-24 02:54:55 +00:00
|
|
|
|
|
|
|
if (orig_name) {
|
2005-10-15 04:54:52 +00:00
|
|
|
int len;
|
|
|
|
const char *name;
|
|
|
|
char *another;
|
2005-05-24 02:54:55 +00:00
|
|
|
name = orig_name;
|
|
|
|
len = strlen(name);
|
|
|
|
if (isnull)
|
|
|
|
die("git-apply: bad git-diff - expected /dev/null, got %s on line %d", name, linenr);
|
2007-04-04 15:19:14 +00:00
|
|
|
another = find_name(line, NULL, p_value, TERM_TAB);
|
2005-10-15 04:54:52 +00:00
|
|
|
if (!another || memcmp(another, name, len))
|
|
|
|
die("git-apply: bad git-diff - inconsistent %s filename on line %d", oldnew, linenr);
|
|
|
|
free(another);
|
2005-05-24 02:54:55 +00:00
|
|
|
return orig_name;
|
|
|
|
}
|
2005-10-15 04:54:52 +00:00
|
|
|
else {
|
|
|
|
/* expect "/dev/null" */
|
|
|
|
if (memcmp("/dev/null", line, 9) || line[9] != '\n')
|
|
|
|
die("git-apply: bad git-diff - expected /dev/null on line %d", linenr);
|
|
|
|
return NULL;
|
|
|
|
}
|
2005-05-24 02:54:55 +00:00
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_oldname(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->old_name = gitdiff_verify_name(line, patch->is_new, patch->old_name, "old");
|
2005-05-23 23:09:09 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_newname(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->new_name = gitdiff_verify_name(line, patch->is_delete, patch->new_name, "new");
|
2005-05-23 23:09:09 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_oldmode(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->old_mode = strtoul(line, NULL, 8);
|
2005-05-23 23:09:09 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_newmode(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->new_mode = strtoul(line, NULL, 8);
|
2005-05-23 23:09:09 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_delete(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->is_delete = 1;
|
2005-05-26 20:11:24 +00:00
|
|
|
patch->old_name = patch->def_name;
|
2005-05-26 17:23:51 +00:00
|
|
|
return gitdiff_oldmode(line, patch);
|
2005-05-23 23:09:09 +00:00
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_newfile(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->is_new = 1;
|
2005-05-26 20:11:24 +00:00
|
|
|
patch->new_name = patch->def_name;
|
2005-05-26 17:23:51 +00:00
|
|
|
return gitdiff_newmode(line, patch);
|
2005-05-23 23:09:09 +00:00
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_copysrc(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->is_copy = 1;
|
|
|
|
patch->old_name = find_name(line, NULL, 0, 0);
|
2005-05-23 23:09:09 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_copydst(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->is_copy = 1;
|
|
|
|
patch->new_name = find_name(line, NULL, 0, 0);
|
2005-05-23 23:09:09 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_renamesrc(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->is_rename = 1;
|
|
|
|
patch->old_name = find_name(line, NULL, 0, 0);
|
2005-05-23 23:09:09 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_renamedst(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->is_rename = 1;
|
|
|
|
patch->new_name = find_name(line, NULL, 0, 0);
|
2005-05-23 23:09:09 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_similarity(const char *line, struct patch *patch)
|
2005-05-23 23:09:09 +00:00
|
|
|
{
|
2005-06-22 09:29:46 +00:00
|
|
|
if ((patch->score = strtoul(line, NULL, 10)) == ULONG_MAX)
|
|
|
|
patch->score = 0;
|
2005-05-23 23:09:09 +00:00
|
|
|
return 0;
|
2005-05-23 17:52:17 +00:00
|
|
|
}
|
|
|
|
|
2005-05-30 23:40:16 +00:00
|
|
|
static int gitdiff_dissimilarity(const char *line, struct patch *patch)
|
|
|
|
{
|
2005-06-22 09:29:46 +00:00
|
|
|
if ((patch->score = strtoul(line, NULL, 10)) == ULONG_MAX)
|
|
|
|
patch->score = 0;
|
2005-05-30 23:40:16 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-10-07 10:42:00 +00:00
|
|
|
static int gitdiff_index(const char *line, struct patch *patch)
|
|
|
|
{
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* index line is N hexadecimal, "..", N hexadecimal,
|
2005-10-07 10:42:00 +00:00
|
|
|
* and optional space with octal mode.
|
|
|
|
*/
|
|
|
|
const char *ptr, *eol;
|
|
|
|
int len;
|
|
|
|
|
|
|
|
ptr = strchr(line, '.');
|
2005-11-15 01:15:07 +00:00
|
|
|
if (!ptr || ptr[1] != '.' || 40 < ptr - line)
|
2005-10-07 10:42:00 +00:00
|
|
|
return 0;
|
|
|
|
len = ptr - line;
|
|
|
|
memcpy(patch->old_sha1_prefix, line, len);
|
|
|
|
patch->old_sha1_prefix[len] = 0;
|
|
|
|
|
|
|
|
line = ptr + 2;
|
|
|
|
ptr = strchr(line, ' ');
|
|
|
|
eol = strchr(line, '\n');
|
|
|
|
|
|
|
|
if (!ptr || eol < ptr)
|
|
|
|
ptr = eol;
|
|
|
|
len = ptr - line;
|
|
|
|
|
2005-11-15 01:15:07 +00:00
|
|
|
if (40 < len)
|
2005-10-07 10:42:00 +00:00
|
|
|
return 0;
|
|
|
|
memcpy(patch->new_sha1_prefix, line, len);
|
|
|
|
patch->new_sha1_prefix[len] = 0;
|
|
|
|
if (*ptr == ' ')
|
|
|
|
patch->new_mode = patch->old_mode = strtoul(ptr+1, NULL, 8);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-05-24 02:13:55 +00:00
|
|
|
/*
|
|
|
|
* This is normal for a diff that doesn't change anything: we'll fall through
|
|
|
|
* into the next diff. Tell the parser to break out.
|
|
|
|
*/
|
2005-05-26 17:23:51 +00:00
|
|
|
static int gitdiff_unrecognized(const char *line, struct patch *patch)
|
2005-05-24 02:13:55 +00:00
|
|
|
{
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2005-10-15 04:54:52 +00:00
|
|
|
static const char *stop_at_slash(const char *line, int llen)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < llen; i++) {
|
|
|
|
int ch = line[i];
|
|
|
|
if (ch == '/')
|
|
|
|
return line + i;
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* This is to extract the same name that appears on "diff --git"
|
2005-10-15 04:54:52 +00:00
|
|
|
* line. We do not find and return anything if it is a rename
|
|
|
|
* patch, and it is OK because we will find the name elsewhere.
|
|
|
|
* We need to reliably find name only when it is mode-change only,
|
|
|
|
* creation or deletion of an empty file. In any of these cases,
|
|
|
|
* both sides are the same name under a/ and b/ respectively.
|
|
|
|
*/
|
|
|
|
static char *git_header_name(char *line, int llen)
|
2005-05-26 20:11:24 +00:00
|
|
|
{
|
2005-10-15 04:54:52 +00:00
|
|
|
const char *name;
|
|
|
|
const char *second = NULL;
|
2007-09-19 22:42:14 +00:00
|
|
|
size_t len;
|
2005-05-26 20:11:24 +00:00
|
|
|
|
2005-10-15 04:54:52 +00:00
|
|
|
line += strlen("diff --git ");
|
|
|
|
llen -= strlen("diff --git ");
|
|
|
|
|
|
|
|
if (*line == '"') {
|
|
|
|
const char *cp;
|
2007-09-19 22:42:14 +00:00
|
|
|
struct strbuf first;
|
|
|
|
struct strbuf sp;
|
|
|
|
|
|
|
|
strbuf_init(&first, 0);
|
|
|
|
strbuf_init(&sp, 0);
|
|
|
|
|
|
|
|
if (unquote_c_style(&first, line, &second))
|
|
|
|
goto free_and_fail1;
|
2005-10-15 04:54:52 +00:00
|
|
|
|
|
|
|
/* advance to the first slash */
|
2007-09-19 22:42:14 +00:00
|
|
|
cp = stop_at_slash(first.buf, first.len);
|
|
|
|
/* we do not accept absolute paths */
|
|
|
|
if (!cp || cp == first.buf)
|
|
|
|
goto free_and_fail1;
|
|
|
|
strbuf_remove(&first, 0, cp + 1 - first.buf);
|
2005-10-15 04:54:52 +00:00
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* second points at one past closing dq of name.
|
2005-10-15 04:54:52 +00:00
|
|
|
* find the second name.
|
|
|
|
*/
|
|
|
|
while ((second < line + llen) && isspace(*second))
|
|
|
|
second++;
|
|
|
|
|
|
|
|
if (line + llen <= second)
|
2007-09-19 22:42:14 +00:00
|
|
|
goto free_and_fail1;
|
2005-10-15 04:54:52 +00:00
|
|
|
if (*second == '"') {
|
2007-09-19 22:42:14 +00:00
|
|
|
if (unquote_c_style(&sp, second, NULL))
|
|
|
|
goto free_and_fail1;
|
|
|
|
cp = stop_at_slash(sp.buf, sp.len);
|
|
|
|
if (!cp || cp == sp.buf)
|
|
|
|
goto free_and_fail1;
|
2005-10-15 04:54:52 +00:00
|
|
|
/* They must match, otherwise ignore */
|
2007-09-19 22:42:14 +00:00
|
|
|
if (strcmp(cp + 1, first.buf))
|
|
|
|
goto free_and_fail1;
|
|
|
|
strbuf_release(&sp);
|
2007-09-27 10:58:23 +00:00
|
|
|
return strbuf_detach(&first, NULL);
|
2005-10-15 04:54:52 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* unquoted second */
|
|
|
|
cp = stop_at_slash(second, line + llen - second);
|
|
|
|
if (!cp || cp == second)
|
2007-09-19 22:42:14 +00:00
|
|
|
goto free_and_fail1;
|
2005-10-15 04:54:52 +00:00
|
|
|
cp++;
|
2007-09-19 22:42:14 +00:00
|
|
|
if (line + llen - cp != first.len + 1 ||
|
|
|
|
memcmp(first.buf, cp, first.len))
|
|
|
|
goto free_and_fail1;
|
2007-09-27 10:58:23 +00:00
|
|
|
return strbuf_detach(&first, NULL);
|
2007-09-19 22:42:14 +00:00
|
|
|
|
|
|
|
free_and_fail1:
|
|
|
|
strbuf_release(&first);
|
|
|
|
strbuf_release(&sp);
|
|
|
|
return NULL;
|
2005-05-26 20:11:24 +00:00
|
|
|
}
|
|
|
|
|
2005-10-15 04:54:52 +00:00
|
|
|
/* unquoted first name */
|
|
|
|
name = stop_at_slash(line, llen);
|
|
|
|
if (!name || name == line)
|
2005-05-26 20:11:24 +00:00
|
|
|
return NULL;
|
2005-10-15 04:54:52 +00:00
|
|
|
name++;
|
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* since the first name is unquoted, a dq if exists must be
|
2005-10-15 04:54:52 +00:00
|
|
|
* the beginning of the second name.
|
|
|
|
*/
|
|
|
|
for (second = name; second < line + llen; second++) {
|
|
|
|
if (*second == '"') {
|
2007-09-19 22:42:14 +00:00
|
|
|
struct strbuf sp;
|
2005-10-15 04:54:52 +00:00
|
|
|
const char *np;
|
2007-09-19 22:42:14 +00:00
|
|
|
|
|
|
|
strbuf_init(&sp, 0);
|
|
|
|
if (unquote_c_style(&sp, second, NULL))
|
|
|
|
goto free_and_fail2;
|
|
|
|
|
|
|
|
np = stop_at_slash(sp.buf, sp.len);
|
|
|
|
if (!np || np == sp.buf)
|
|
|
|
goto free_and_fail2;
|
2005-10-15 04:54:52 +00:00
|
|
|
np++;
|
2007-09-19 22:42:14 +00:00
|
|
|
|
|
|
|
len = sp.buf + sp.len - np;
|
|
|
|
if (len < second - name &&
|
2005-10-15 04:54:52 +00:00
|
|
|
!strncmp(np, name, len) &&
|
|
|
|
isspace(name[len])) {
|
|
|
|
/* Good */
|
2007-09-19 22:42:14 +00:00
|
|
|
strbuf_remove(&sp, 0, np - sp.buf);
|
2007-09-27 10:58:23 +00:00
|
|
|
return strbuf_detach(&sp, NULL);
|
2005-10-15 04:54:52 +00:00
|
|
|
}
|
2007-09-19 22:42:14 +00:00
|
|
|
|
|
|
|
free_and_fail2:
|
|
|
|
strbuf_release(&sp);
|
|
|
|
return NULL;
|
2005-10-15 04:54:52 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-05-26 20:11:24 +00:00
|
|
|
/*
|
|
|
|
* Accept a name only if it shows up twice, exactly the same
|
|
|
|
* form.
|
|
|
|
*/
|
|
|
|
for (len = 0 ; ; len++) {
|
2006-08-23 10:39:15 +00:00
|
|
|
switch (name[len]) {
|
2005-05-26 20:11:24 +00:00
|
|
|
default:
|
|
|
|
continue;
|
|
|
|
case '\n':
|
2005-08-28 15:24:27 +00:00
|
|
|
return NULL;
|
2005-05-26 20:11:24 +00:00
|
|
|
case '\t': case ' ':
|
|
|
|
second = name+len;
|
|
|
|
for (;;) {
|
|
|
|
char c = *second++;
|
|
|
|
if (c == '\n')
|
|
|
|
return NULL;
|
|
|
|
if (c == '/')
|
|
|
|
break;
|
|
|
|
}
|
2005-05-26 20:28:42 +00:00
|
|
|
if (second[len] == '\n' && !memcmp(name, second, len)) {
|
2007-09-15 22:32:36 +00:00
|
|
|
return xmemdupz(name, len);
|
2005-05-26 20:11:24 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-05-23 17:52:17 +00:00
|
|
|
/* Verify that we recognize the lines following a git header */
|
2005-05-26 17:23:51 +00:00
|
|
|
static int parse_git_header(char *line, int len, unsigned int size, struct patch *patch)
|
2005-05-23 17:52:17 +00:00
|
|
|
{
|
2005-05-23 23:09:09 +00:00
|
|
|
unsigned long offset;
|
|
|
|
|
|
|
|
/* A git diff has explicit new/delete information, so we don't guess */
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->is_new = 0;
|
|
|
|
patch->is_delete = 0;
|
2005-05-23 23:09:09 +00:00
|
|
|
|
2005-05-26 20:11:24 +00:00
|
|
|
/*
|
|
|
|
* Some things may not have the old name in the
|
|
|
|
* rest of the headers anywhere (pure mode changes,
|
|
|
|
* or removing or adding empty files), so we get
|
|
|
|
* the default name from the header.
|
|
|
|
*/
|
2005-10-15 04:54:52 +00:00
|
|
|
patch->def_name = git_header_name(line, len);
|
2005-05-26 20:11:24 +00:00
|
|
|
|
2005-05-23 23:09:09 +00:00
|
|
|
line += len;
|
|
|
|
size -= len;
|
|
|
|
linenr++;
|
|
|
|
for (offset = len ; size > 0 ; offset += len, size -= len, line += len, linenr++) {
|
|
|
|
static const struct opentry {
|
|
|
|
const char *str;
|
2005-05-26 17:23:51 +00:00
|
|
|
int (*fn)(const char *, struct patch *);
|
2005-05-23 23:09:09 +00:00
|
|
|
} optable[] = {
|
|
|
|
{ "@@ -", gitdiff_hdrend },
|
|
|
|
{ "--- ", gitdiff_oldname },
|
|
|
|
{ "+++ ", gitdiff_newname },
|
|
|
|
{ "old mode ", gitdiff_oldmode },
|
|
|
|
{ "new mode ", gitdiff_newmode },
|
|
|
|
{ "deleted file mode ", gitdiff_delete },
|
|
|
|
{ "new file mode ", gitdiff_newfile },
|
|
|
|
{ "copy from ", gitdiff_copysrc },
|
|
|
|
{ "copy to ", gitdiff_copydst },
|
2005-06-05 21:26:50 +00:00
|
|
|
{ "rename old ", gitdiff_renamesrc },
|
|
|
|
{ "rename new ", gitdiff_renamedst },
|
2005-06-05 22:31:52 +00:00
|
|
|
{ "rename from ", gitdiff_renamesrc },
|
|
|
|
{ "rename to ", gitdiff_renamedst },
|
2005-05-23 23:09:09 +00:00
|
|
|
{ "similarity index ", gitdiff_similarity },
|
2005-05-30 23:40:16 +00:00
|
|
|
{ "dissimilarity index ", gitdiff_dissimilarity },
|
2005-10-07 10:42:00 +00:00
|
|
|
{ "index ", gitdiff_index },
|
2005-05-24 02:13:55 +00:00
|
|
|
{ "", gitdiff_unrecognized },
|
2005-05-23 23:09:09 +00:00
|
|
|
};
|
|
|
|
int i;
|
2005-05-23 17:52:17 +00:00
|
|
|
|
|
|
|
len = linelen(line, size);
|
2005-05-23 23:09:09 +00:00
|
|
|
if (!len || line[len-1] != '\n')
|
2005-05-23 17:52:17 +00:00
|
|
|
break;
|
2006-03-09 19:58:05 +00:00
|
|
|
for (i = 0; i < ARRAY_SIZE(optable); i++) {
|
2005-05-23 23:09:09 +00:00
|
|
|
const struct opentry *p = optable + i;
|
|
|
|
int oplen = strlen(p->str);
|
|
|
|
if (len < oplen || memcmp(p->str, line, oplen))
|
|
|
|
continue;
|
2005-05-26 17:23:51 +00:00
|
|
|
if (p->fn(line + oplen, patch) < 0)
|
2005-05-23 23:09:09 +00:00
|
|
|
return offset;
|
2005-05-24 02:13:55 +00:00
|
|
|
break;
|
2005-05-23 23:09:09 +00:00
|
|
|
}
|
2005-05-23 17:52:17 +00:00
|
|
|
}
|
|
|
|
|
2005-05-23 23:09:09 +00:00
|
|
|
return offset;
|
2005-05-23 17:52:17 +00:00
|
|
|
}
|
|
|
|
|
2005-05-26 19:25:52 +00:00
|
|
|
static int parse_num(const char *line, unsigned long *p)
|
2005-05-23 21:38:49 +00:00
|
|
|
{
|
|
|
|
char *ptr;
|
2005-05-26 19:25:52 +00:00
|
|
|
|
|
|
|
if (!isdigit(*line))
|
|
|
|
return 0;
|
|
|
|
*p = strtoul(line, &ptr, 10);
|
|
|
|
return ptr - line;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int parse_range(const char *line, int len, int offset, const char *expect,
|
2007-11-23 10:37:03 +00:00
|
|
|
unsigned long *p1, unsigned long *p2)
|
2005-05-26 19:25:52 +00:00
|
|
|
{
|
2005-05-23 21:38:49 +00:00
|
|
|
int digits, ex;
|
|
|
|
|
|
|
|
if (offset < 0 || offset >= len)
|
|
|
|
return -1;
|
|
|
|
line += offset;
|
|
|
|
len -= offset;
|
|
|
|
|
2005-05-26 19:25:52 +00:00
|
|
|
digits = parse_num(line, p1);
|
|
|
|
if (!digits)
|
2005-05-23 21:38:49 +00:00
|
|
|
return -1;
|
|
|
|
|
|
|
|
offset += digits;
|
|
|
|
line += digits;
|
|
|
|
len -= digits;
|
|
|
|
|
2006-03-25 21:28:28 +00:00
|
|
|
*p2 = 1;
|
2005-05-26 19:25:52 +00:00
|
|
|
if (*line == ',') {
|
|
|
|
digits = parse_num(line+1, p2);
|
|
|
|
if (!digits)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
offset += digits+1;
|
|
|
|
line += digits+1;
|
|
|
|
len -= digits+1;
|
|
|
|
}
|
|
|
|
|
2005-05-23 21:38:49 +00:00
|
|
|
ex = strlen(expect);
|
|
|
|
if (ex > len)
|
|
|
|
return -1;
|
|
|
|
if (memcmp(line, expect, ex))
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
return offset + ex;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Parse a unified diff fragment header of the
|
|
|
|
* form "@@ -a,b +c,d @@"
|
|
|
|
*/
|
2005-05-26 17:23:51 +00:00
|
|
|
static int parse_fragment_header(char *line, int len, struct fragment *fragment)
|
2005-05-23 21:38:49 +00:00
|
|
|
{
|
|
|
|
int offset;
|
|
|
|
|
|
|
|
if (!len || line[len-1] != '\n')
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
/* Figure out the number of lines in a fragment */
|
2005-05-26 19:25:52 +00:00
|
|
|
offset = parse_range(line, len, 4, " +", &fragment->oldpos, &fragment->oldlines);
|
|
|
|
offset = parse_range(line, len, offset, " @@", &fragment->newpos, &fragment->newlines);
|
2005-05-23 21:38:49 +00:00
|
|
|
|
|
|
|
return offset;
|
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int find_header(char *line, unsigned long size, int *hdrsize, struct patch *patch)
|
2005-05-23 17:52:17 +00:00
|
|
|
{
|
|
|
|
unsigned long offset, len;
|
|
|
|
|
2007-02-21 22:31:10 +00:00
|
|
|
patch->is_toplevel_relative = 0;
|
2005-05-26 17:23:51 +00:00
|
|
|
patch->is_rename = patch->is_copy = 0;
|
|
|
|
patch->is_new = patch->is_delete = -1;
|
|
|
|
patch->old_mode = patch->new_mode = 0;
|
|
|
|
patch->old_name = patch->new_name = NULL;
|
2005-05-23 21:38:49 +00:00
|
|
|
for (offset = 0; size > 0; offset += len, size -= len, line += len, linenr++) {
|
2005-05-23 17:52:17 +00:00
|
|
|
unsigned long nextlen;
|
|
|
|
|
|
|
|
len = linelen(line, size);
|
|
|
|
if (!len)
|
|
|
|
break;
|
|
|
|
|
|
|
|
/* Testing this early allows us to take a few shortcuts.. */
|
|
|
|
if (len < 6)
|
|
|
|
continue;
|
2005-05-23 21:38:49 +00:00
|
|
|
|
|
|
|
/*
|
2006-07-10 05:50:18 +00:00
|
|
|
* Make sure we don't find any unconnected patch fragments.
|
2005-05-23 21:38:49 +00:00
|
|
|
* That's a sign that we didn't find a header, and that a
|
|
|
|
* patch has become corrupted/broken up.
|
|
|
|
*/
|
|
|
|
if (!memcmp("@@ -", line, 4)) {
|
2005-05-26 17:23:51 +00:00
|
|
|
struct fragment dummy;
|
|
|
|
if (parse_fragment_header(line, len, &dummy) < 0)
|
2005-05-23 21:38:49 +00:00
|
|
|
continue;
|
2007-01-09 19:50:53 +00:00
|
|
|
die("patch fragment without header at line %d: %.*s",
|
|
|
|
linenr, (int)len-1, line);
|
2005-05-23 21:38:49 +00:00
|
|
|
}
|
|
|
|
|
2005-05-23 17:52:17 +00:00
|
|
|
if (size < len + 6)
|
|
|
|
break;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Git patch? It might not have a real patch, just a rename
|
|
|
|
* or mode change, so we handle that specially
|
|
|
|
*/
|
|
|
|
if (!memcmp("diff --git ", line, 11)) {
|
2005-05-26 17:23:51 +00:00
|
|
|
int git_hdr_len = parse_git_header(line, len, size, patch);
|
2005-06-12 16:37:49 +00:00
|
|
|
if (git_hdr_len <= len)
|
2005-05-23 17:52:17 +00:00
|
|
|
continue;
|
2005-06-17 22:23:40 +00:00
|
|
|
if (!patch->old_name && !patch->new_name) {
|
|
|
|
if (!patch->def_name)
|
|
|
|
die("git diff header lacks filename information (line %d)", linenr);
|
|
|
|
patch->old_name = patch->new_name = patch->def_name;
|
|
|
|
}
|
2007-02-21 22:31:10 +00:00
|
|
|
patch->is_toplevel_relative = 1;
|
2005-05-23 23:09:09 +00:00
|
|
|
*hdrsize = git_hdr_len;
|
2005-05-23 17:52:17 +00:00
|
|
|
return offset;
|
|
|
|
}
|
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
/* --- followed by +++ ? */
|
2005-05-23 17:52:17 +00:00
|
|
|
if (memcmp("--- ", line, 4) || memcmp("+++ ", line + len, 4))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We only accept unified patches, so we want it to
|
|
|
|
* at least have "@@ -a,b +c,d @@\n", which is 14 chars
|
2007-11-23 10:37:03 +00:00
|
|
|
* minimum ("@@ -0,0 +1 @@\n" is the shortest).
|
2005-05-23 17:52:17 +00:00
|
|
|
*/
|
|
|
|
nextlen = linelen(line + len, size - len);
|
|
|
|
if (size < nextlen + 14 || memcmp("@@ -", line + len + nextlen, 4))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
/* Ok, we'll consider it a patch */
|
2005-05-26 17:23:51 +00:00
|
|
|
parse_traditional_patch(line, line+len, patch);
|
2005-05-23 17:52:17 +00:00
|
|
|
*hdrsize = len + nextlen;
|
2005-05-23 21:38:49 +00:00
|
|
|
linenr += 2;
|
2005-05-23 17:52:17 +00:00
|
|
|
return offset;
|
|
|
|
}
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2007-12-06 08:14:14 +00:00
|
|
|
static void check_whitespace(const char *line, int len, unsigned ws_rule)
|
2006-09-23 07:37:19 +00:00
|
|
|
{
|
2007-12-13 13:32:29 +00:00
|
|
|
char *err;
|
|
|
|
unsigned result = check_and_emit_line(line + 1, len - 1, ws_rule,
|
|
|
|
NULL, NULL, NULL, NULL);
|
|
|
|
if (!result)
|
|
|
|
return;
|
2006-09-23 07:37:19 +00:00
|
|
|
|
|
|
|
whitespace_error++;
|
|
|
|
if (squelch_whitespace_errors &&
|
|
|
|
squelch_whitespace_errors < whitespace_error)
|
|
|
|
;
|
2007-12-13 13:32:29 +00:00
|
|
|
else {
|
|
|
|
err = whitespace_error_string(result);
|
2007-12-13 13:32:30 +00:00
|
|
|
fprintf(stderr, "%s:%d: %s.\n%.*s\n",
|
|
|
|
patch_input_file, linenr, err, len - 2, line + 1);
|
2007-12-13 13:32:29 +00:00
|
|
|
free(err);
|
|
|
|
}
|
2006-09-23 07:37:19 +00:00
|
|
|
}
|
|
|
|
|
2005-05-23 17:52:17 +00:00
|
|
|
/*
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
* Parse a unified diff. Note that this really needs to parse each
|
|
|
|
* fragment separately, since the only way to know the difference
|
|
|
|
* between a "---" that is part of a patch, and a "---" that starts
|
|
|
|
* the next patch is to look at the line counts..
|
2005-05-23 17:52:17 +00:00
|
|
|
*/
|
2007-11-23 10:37:03 +00:00
|
|
|
static int parse_fragment(char *line, unsigned long size,
|
|
|
|
struct patch *patch, struct fragment *fragment)
|
2005-05-23 17:52:17 +00:00
|
|
|
{
|
2005-05-26 18:40:43 +00:00
|
|
|
int added, deleted;
|
2005-05-23 17:52:17 +00:00
|
|
|
int len = linelen(line, size), offset;
|
2005-06-05 19:43:56 +00:00
|
|
|
unsigned long oldlines, newlines;
|
2006-04-10 09:33:06 +00:00
|
|
|
unsigned long leading, trailing;
|
2005-05-23 17:52:17 +00:00
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
offset = parse_fragment_header(line, len, fragment);
|
2005-05-23 17:52:17 +00:00
|
|
|
if (offset < 0)
|
|
|
|
return -1;
|
2005-05-26 17:23:51 +00:00
|
|
|
oldlines = fragment->oldlines;
|
|
|
|
newlines = fragment->newlines;
|
2006-04-10 09:33:06 +00:00
|
|
|
leading = 0;
|
|
|
|
trailing = 0;
|
2005-05-23 17:52:17 +00:00
|
|
|
|
|
|
|
/* Parse the thing.. */
|
|
|
|
line += len;
|
|
|
|
size -= len;
|
2005-05-23 21:38:49 +00:00
|
|
|
linenr++;
|
2005-05-26 18:40:43 +00:00
|
|
|
added = deleted = 0;
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
for (offset = len;
|
|
|
|
0 < size;
|
|
|
|
offset += len, size -= len, line += len, linenr++) {
|
2005-05-23 17:52:17 +00:00
|
|
|
if (!oldlines && !newlines)
|
|
|
|
break;
|
|
|
|
len = linelen(line, size);
|
|
|
|
if (!len || line[len-1] != '\n')
|
|
|
|
return -1;
|
|
|
|
switch (*line) {
|
|
|
|
default:
|
|
|
|
return -1;
|
2006-10-20 02:26:08 +00:00
|
|
|
case '\n': /* newer GNU diff, an empty context line */
|
2005-05-23 17:52:17 +00:00
|
|
|
case ' ':
|
|
|
|
oldlines--;
|
|
|
|
newlines--;
|
2006-04-10 09:33:06 +00:00
|
|
|
if (!deleted && !added)
|
|
|
|
leading++;
|
|
|
|
trailing++;
|
2005-05-23 17:52:17 +00:00
|
|
|
break;
|
|
|
|
case '-':
|
2007-07-07 17:50:39 +00:00
|
|
|
if (apply_in_reverse &&
|
2007-11-23 10:37:03 +00:00
|
|
|
ws_error_action != nowarn_ws_error)
|
2007-12-06 08:14:14 +00:00
|
|
|
check_whitespace(line, len, patch->ws_rule);
|
2005-05-26 18:40:43 +00:00
|
|
|
deleted++;
|
2005-05-23 17:52:17 +00:00
|
|
|
oldlines--;
|
2006-04-10 09:33:06 +00:00
|
|
|
trailing = 0;
|
2005-05-23 17:52:17 +00:00
|
|
|
break;
|
|
|
|
case '+':
|
2007-07-07 17:50:39 +00:00
|
|
|
if (!apply_in_reverse &&
|
2007-11-23 10:37:03 +00:00
|
|
|
ws_error_action != nowarn_ws_error)
|
2007-12-06 08:14:14 +00:00
|
|
|
check_whitespace(line, len, patch->ws_rule);
|
2005-05-26 18:40:43 +00:00
|
|
|
added++;
|
2005-05-23 17:52:17 +00:00
|
|
|
newlines--;
|
2006-04-10 09:33:06 +00:00
|
|
|
trailing = 0;
|
2005-05-23 17:52:17 +00:00
|
|
|
break;
|
2005-09-04 17:29:02 +00:00
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* We allow "\ No newline at end of file". Depending
|
2005-09-04 17:29:02 +00:00
|
|
|
* on locale settings when the patch was produced we
|
|
|
|
* don't know what this line looks like. The only
|
2005-10-03 20:16:39 +00:00
|
|
|
* thing we do know is that it begins with "\ ".
|
|
|
|
* Checking for 12 is just for sanity check -- any
|
|
|
|
* l10n of "\ No newline..." is at least that long.
|
|
|
|
*/
|
2005-05-26 19:25:52 +00:00
|
|
|
case '\\':
|
2005-09-04 17:29:02 +00:00
|
|
|
if (len < 12 || memcmp(line, "\\ ", 2))
|
2005-06-05 18:03:13 +00:00
|
|
|
return -1;
|
2005-05-26 19:25:52 +00:00
|
|
|
break;
|
2005-05-23 17:52:17 +00:00
|
|
|
}
|
|
|
|
}
|
2006-03-25 21:28:28 +00:00
|
|
|
if (oldlines || newlines)
|
|
|
|
return -1;
|
2006-04-10 09:33:06 +00:00
|
|
|
fragment->leading = leading;
|
|
|
|
fragment->trailing = trailing;
|
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* If a fragment ends with an incomplete line, we failed to include
|
2005-07-22 16:56:39 +00:00
|
|
|
* it in the above loop because we hit oldlines == newlines == 0
|
|
|
|
* before seeing it.
|
|
|
|
*/
|
2005-09-04 17:29:02 +00:00
|
|
|
if (12 < size && !memcmp(line, "\\ ", 2))
|
2005-07-22 16:56:39 +00:00
|
|
|
offset += linelen(line, size);
|
|
|
|
|
2005-05-26 18:40:43 +00:00
|
|
|
patch->lines_added += added;
|
|
|
|
patch->lines_deleted += deleted;
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
|
|
|
|
if (0 < patch->is_new && oldlines)
|
|
|
|
return error("new file depends on old contents");
|
|
|
|
if (0 < patch->is_delete && newlines)
|
|
|
|
return error("deleted file still has contents");
|
2005-05-23 17:52:17 +00:00
|
|
|
return offset;
|
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int parse_single_patch(char *line, unsigned long size, struct patch *patch)
|
2005-05-23 17:52:17 +00:00
|
|
|
{
|
|
|
|
unsigned long offset = 0;
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
unsigned long oldlines = 0, newlines = 0, context = 0;
|
2005-05-26 17:23:51 +00:00
|
|
|
struct fragment **fragp = &patch->fragments;
|
2005-05-23 17:52:17 +00:00
|
|
|
|
|
|
|
while (size > 4 && !memcmp(line, "@@ -", 4)) {
|
2005-05-26 17:23:51 +00:00
|
|
|
struct fragment *fragment;
|
|
|
|
int len;
|
|
|
|
|
2006-04-03 18:30:46 +00:00
|
|
|
fragment = xcalloc(1, sizeof(*fragment));
|
2005-05-26 17:23:51 +00:00
|
|
|
len = parse_fragment(line, size, patch, fragment);
|
2005-05-23 17:52:17 +00:00
|
|
|
if (len <= 0)
|
2005-05-23 21:38:49 +00:00
|
|
|
die("corrupt patch at line %d", linenr);
|
2005-05-26 17:23:51 +00:00
|
|
|
fragment->patch = line;
|
|
|
|
fragment->size = len;
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
oldlines += fragment->oldlines;
|
|
|
|
newlines += fragment->newlines;
|
|
|
|
context += fragment->leading + fragment->trailing;
|
2005-05-26 17:23:51 +00:00
|
|
|
|
|
|
|
*fragp = fragment;
|
|
|
|
fragp = &fragment->next;
|
2005-05-23 17:52:17 +00:00
|
|
|
|
|
|
|
offset += len;
|
|
|
|
line += len;
|
|
|
|
size -= len;
|
|
|
|
}
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If something was removed (i.e. we have old-lines) it cannot
|
|
|
|
* be creation, and if something was added it cannot be
|
|
|
|
* deletion. However, the reverse is not true; --unified=0
|
|
|
|
* patches that only add are not necessarily creation even
|
|
|
|
* though they do not have any old lines, and ones that only
|
|
|
|
* delete are not necessarily deletion.
|
|
|
|
*
|
|
|
|
* Unfortunately, a real creation/deletion patch do _not_ have
|
|
|
|
* any context line by definition, so we cannot safely tell it
|
|
|
|
* apart with --unified=0 insanity. At least if the patch has
|
|
|
|
* more than one hunk it is not creation or deletion.
|
|
|
|
*/
|
|
|
|
if (patch->is_new < 0 &&
|
|
|
|
(oldlines || (patch->fragments && patch->fragments->next)))
|
|
|
|
patch->is_new = 0;
|
|
|
|
if (patch->is_delete < 0 &&
|
|
|
|
(newlines || (patch->fragments && patch->fragments->next)))
|
|
|
|
patch->is_delete = 0;
|
|
|
|
if (!unidiff_zero || context) {
|
|
|
|
/* If the user says the patch is not generated with
|
|
|
|
* --unified=0, or if we have seen context lines,
|
|
|
|
* then not having oldlines means the patch is creation,
|
|
|
|
* and not having newlines means the patch is deletion.
|
|
|
|
*/
|
2006-11-04 10:28:53 +00:00
|
|
|
if (patch->is_new < 0 && !oldlines) {
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
patch->is_new = 1;
|
2006-11-04 10:28:53 +00:00
|
|
|
patch->old_name = NULL;
|
|
|
|
}
|
|
|
|
if (patch->is_delete < 0 && !newlines) {
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
patch->is_delete = 1;
|
2006-11-04 10:28:53 +00:00
|
|
|
patch->new_name = NULL;
|
|
|
|
}
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (0 < patch->is_new && oldlines)
|
|
|
|
die("new file %s depends on old contents", patch->new_name);
|
|
|
|
if (0 < patch->is_delete && newlines)
|
|
|
|
die("deleted file %s still has contents", patch->old_name);
|
|
|
|
if (!patch->is_delete && !newlines && context)
|
|
|
|
fprintf(stderr, "** warning: file %s becomes empty but "
|
|
|
|
"is not deleted\n", patch->new_name);
|
|
|
|
|
2005-05-23 17:52:17 +00:00
|
|
|
return offset;
|
|
|
|
}
|
|
|
|
|
2005-10-01 06:25:23 +00:00
|
|
|
static inline int metadata_changes(struct patch *patch)
|
|
|
|
{
|
|
|
|
return patch->is_rename > 0 ||
|
|
|
|
patch->is_copy > 0 ||
|
|
|
|
patch->is_new > 0 ||
|
|
|
|
patch->is_delete ||
|
|
|
|
(patch->old_mode && patch->new_mode &&
|
|
|
|
patch->old_mode != patch->new_mode);
|
|
|
|
}
|
|
|
|
|
2006-08-15 09:23:06 +00:00
|
|
|
static char *inflate_it(const void *data, unsigned long size,
|
|
|
|
unsigned long inflated_size)
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
{
|
2006-08-15 09:23:06 +00:00
|
|
|
z_stream stream;
|
|
|
|
void *out;
|
|
|
|
int st;
|
|
|
|
|
|
|
|
memset(&stream, 0, sizeof(stream));
|
|
|
|
|
|
|
|
stream.next_in = (unsigned char *)data;
|
|
|
|
stream.avail_in = size;
|
|
|
|
stream.next_out = out = xmalloc(inflated_size);
|
|
|
|
stream.avail_out = inflated_size;
|
|
|
|
inflateInit(&stream);
|
|
|
|
st = inflate(&stream, Z_FINISH);
|
|
|
|
if ((st != Z_STREAM_END) || stream.total_out != inflated_size) {
|
|
|
|
free(out);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
return out;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct fragment *parse_binary_hunk(char **buf_p,
|
|
|
|
unsigned long *sz_p,
|
|
|
|
int *status_p,
|
|
|
|
int *used_p)
|
|
|
|
{
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* Expect a line that begins with binary patch method ("literal"
|
2006-08-15 09:23:06 +00:00
|
|
|
* or "delta"), followed by the length of data before deflating.
|
|
|
|
* a sequence of 'length-byte' followed by base-85 encoded data
|
|
|
|
* should follow, terminated by a newline.
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
*
|
|
|
|
* Each 5-byte sequence of base-85 encodes up to 4 bytes,
|
|
|
|
* and we would limit the patch line to 66 characters,
|
|
|
|
* so one line can fit up to 13 groups that would decode
|
|
|
|
* to 52 bytes max. The length byte 'A'-'Z' corresponds
|
|
|
|
* to 1-26 bytes, and 'a'-'z' corresponds to 27-52 bytes.
|
|
|
|
*/
|
|
|
|
int llen, used;
|
2006-08-15 09:23:06 +00:00
|
|
|
unsigned long size = *sz_p;
|
|
|
|
char *buffer = *buf_p;
|
|
|
|
int patch_method;
|
|
|
|
unsigned long origlen;
|
2006-05-05 09:41:53 +00:00
|
|
|
char *data = NULL;
|
2006-08-15 09:23:06 +00:00
|
|
|
int hunk_size = 0;
|
|
|
|
struct fragment *frag;
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
|
2006-05-05 09:41:53 +00:00
|
|
|
llen = linelen(buffer, size);
|
|
|
|
used = llen;
|
2006-08-15 09:23:06 +00:00
|
|
|
|
|
|
|
*status_p = 0;
|
2006-05-05 09:41:53 +00:00
|
|
|
|
Mechanical conversion to use prefixcmp()
This mechanically converts strncmp() to use prefixcmp(), but only when
the parameters match specific patterns, so that they can be verified
easily. Leftover from this will be fixed in a separate step, including
idiotic conversions like
if (!strncmp("foo", arg, 3))
=>
if (!(-prefixcmp(arg, "foo")))
This was done by using this script in px.perl
#!/usr/bin/perl -i.bak -p
if (/strncmp\(([^,]+), "([^\\"]*)", (\d+)\)/ && (length($2) == $3)) {
s|strncmp\(([^,]+), "([^\\"]*)", (\d+)\)|prefixcmp($1, "$2")|;
}
if (/strncmp\("([^\\"]*)", ([^,]+), (\d+)\)/ && (length($1) == $3)) {
s|strncmp\("([^\\"]*)", ([^,]+), (\d+)\)|(-prefixcmp($2, "$1"))|;
}
and running:
$ git grep -l strncmp -- '*.c' | xargs perl px.perl
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-02-20 09:53:29 +00:00
|
|
|
if (!prefixcmp(buffer, "delta ")) {
|
2006-08-15 09:23:06 +00:00
|
|
|
patch_method = BINARY_DELTA_DEFLATED;
|
|
|
|
origlen = strtoul(buffer + 6, NULL, 10);
|
2006-05-05 09:41:53 +00:00
|
|
|
}
|
Mechanical conversion to use prefixcmp()
This mechanically converts strncmp() to use prefixcmp(), but only when
the parameters match specific patterns, so that they can be verified
easily. Leftover from this will be fixed in a separate step, including
idiotic conversions like
if (!strncmp("foo", arg, 3))
=>
if (!(-prefixcmp(arg, "foo")))
This was done by using this script in px.perl
#!/usr/bin/perl -i.bak -p
if (/strncmp\(([^,]+), "([^\\"]*)", (\d+)\)/ && (length($2) == $3)) {
s|strncmp\(([^,]+), "([^\\"]*)", (\d+)\)|prefixcmp($1, "$2")|;
}
if (/strncmp\("([^\\"]*)", ([^,]+), (\d+)\)/ && (length($1) == $3)) {
s|strncmp\("([^\\"]*)", ([^,]+), (\d+)\)|(-prefixcmp($2, "$1"))|;
}
and running:
$ git grep -l strncmp -- '*.c' | xargs perl px.perl
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-02-20 09:53:29 +00:00
|
|
|
else if (!prefixcmp(buffer, "literal ")) {
|
2006-08-15 09:23:06 +00:00
|
|
|
patch_method = BINARY_LITERAL_DEFLATED;
|
|
|
|
origlen = strtoul(buffer + 8, NULL, 10);
|
2006-05-05 09:41:53 +00:00
|
|
|
}
|
|
|
|
else
|
2006-08-15 09:23:06 +00:00
|
|
|
return NULL;
|
|
|
|
|
|
|
|
linenr++;
|
2006-05-05 09:41:53 +00:00
|
|
|
buffer += llen;
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
while (1) {
|
|
|
|
int byte_length, max_byte_length, newsize;
|
|
|
|
llen = linelen(buffer, size);
|
|
|
|
used += llen;
|
|
|
|
linenr++;
|
2006-08-16 23:07:20 +00:00
|
|
|
if (llen == 1) {
|
|
|
|
/* consume the blank line */
|
|
|
|
buffer++;
|
|
|
|
size--;
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
break;
|
2006-08-16 23:07:20 +00:00
|
|
|
}
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* Minimum line is "A00000\n" which is 7-byte long,
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
* and the line length must be multiple of 5 plus 2.
|
|
|
|
*/
|
|
|
|
if ((llen < 7) || (llen-2) % 5)
|
|
|
|
goto corrupt;
|
|
|
|
max_byte_length = (llen - 2) / 5 * 4;
|
|
|
|
byte_length = *buffer;
|
|
|
|
if ('A' <= byte_length && byte_length <= 'Z')
|
|
|
|
byte_length = byte_length - 'A' + 1;
|
|
|
|
else if ('a' <= byte_length && byte_length <= 'z')
|
|
|
|
byte_length = byte_length - 'a' + 27;
|
|
|
|
else
|
|
|
|
goto corrupt;
|
|
|
|
/* if the input length was not multiple of 4, we would
|
|
|
|
* have filler at the end but the filler should never
|
|
|
|
* exceed 3 bytes
|
|
|
|
*/
|
|
|
|
if (max_byte_length < byte_length ||
|
|
|
|
byte_length <= max_byte_length - 4)
|
|
|
|
goto corrupt;
|
2006-08-15 09:23:06 +00:00
|
|
|
newsize = hunk_size + byte_length;
|
2006-05-05 09:41:53 +00:00
|
|
|
data = xrealloc(data, newsize);
|
2006-08-15 09:23:06 +00:00
|
|
|
if (decode_85(data + hunk_size, buffer + 1, byte_length))
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
goto corrupt;
|
2006-08-15 09:23:06 +00:00
|
|
|
hunk_size = newsize;
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
buffer += llen;
|
|
|
|
size -= llen;
|
|
|
|
}
|
2006-08-15 09:23:06 +00:00
|
|
|
|
|
|
|
frag = xcalloc(1, sizeof(*frag));
|
|
|
|
frag->patch = inflate_it(data, hunk_size, origlen);
|
|
|
|
if (!frag->patch)
|
|
|
|
goto corrupt;
|
|
|
|
free(data);
|
|
|
|
frag->size = origlen;
|
|
|
|
*buf_p = buffer;
|
|
|
|
*sz_p = size;
|
|
|
|
*used_p = used;
|
|
|
|
frag->binary_patch_method = patch_method;
|
|
|
|
return frag;
|
|
|
|
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
corrupt:
|
2006-08-28 04:19:39 +00:00
|
|
|
free(data);
|
2006-08-15 09:23:06 +00:00
|
|
|
*status_p = -1;
|
|
|
|
error("corrupt binary patch at line %d: %.*s",
|
|
|
|
linenr-1, llen-1, buffer);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int parse_binary(char *buffer, unsigned long size, struct patch *patch)
|
|
|
|
{
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* We have read "GIT binary patch\n"; what follows is a line
|
2006-08-15 09:23:06 +00:00
|
|
|
* that says the patch method (currently, either "literal" or
|
|
|
|
* "delta") and the length of data before deflating; a
|
|
|
|
* sequence of 'length-byte' followed by base-85 encoded data
|
|
|
|
* follows.
|
|
|
|
*
|
|
|
|
* When a binary patch is reversible, there is another binary
|
|
|
|
* hunk in the same format, starting with patch method (either
|
|
|
|
* "literal" or "delta") with the length of data, and a sequence
|
|
|
|
* of length-byte + base-85 encoded data, terminated with another
|
|
|
|
* empty line. This data, when applied to the postimage, produces
|
|
|
|
* the preimage.
|
|
|
|
*/
|
|
|
|
struct fragment *forward;
|
|
|
|
struct fragment *reverse;
|
|
|
|
int status;
|
|
|
|
int used, used_1;
|
|
|
|
|
|
|
|
forward = parse_binary_hunk(&buffer, &size, &status, &used);
|
|
|
|
if (!forward && !status)
|
|
|
|
/* there has to be one hunk (forward hunk) */
|
|
|
|
return error("unrecognized binary patch at line %d", linenr-1);
|
|
|
|
if (status)
|
|
|
|
/* otherwise we already gave an error message */
|
|
|
|
return status;
|
|
|
|
|
|
|
|
reverse = parse_binary_hunk(&buffer, &size, &status, &used_1);
|
|
|
|
if (reverse)
|
|
|
|
used += used_1;
|
|
|
|
else if (status) {
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* Not having reverse hunk is not an error, but having
|
2006-08-15 09:23:06 +00:00
|
|
|
* a corrupt reverse hunk is.
|
|
|
|
*/
|
|
|
|
free((void*) forward->patch);
|
|
|
|
free(forward);
|
|
|
|
return status;
|
|
|
|
}
|
|
|
|
forward->next = reverse;
|
|
|
|
patch->fragments = forward;
|
|
|
|
patch->is_binary = 1;
|
|
|
|
return used;
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
}
|
|
|
|
|
2005-05-26 17:23:51 +00:00
|
|
|
static int parse_chunk(char *buffer, unsigned long size, struct patch *patch)
|
2005-05-23 17:52:17 +00:00
|
|
|
{
|
|
|
|
int hdrsize, patchsize;
|
2005-05-26 17:23:51 +00:00
|
|
|
int offset = find_header(buffer, size, &hdrsize, patch);
|
2005-05-23 17:52:17 +00:00
|
|
|
|
|
|
|
if (offset < 0)
|
|
|
|
return offset;
|
|
|
|
|
2007-12-06 08:14:14 +00:00
|
|
|
patch->ws_rule = whitespace_rule(patch->new_name
|
|
|
|
? patch->new_name
|
|
|
|
: patch->old_name);
|
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
patchsize = parse_single_patch(buffer + offset + hdrsize,
|
|
|
|
size - offset - hdrsize, patch);
|
2005-05-23 17:52:17 +00:00
|
|
|
|
2005-11-16 22:12:56 +00:00
|
|
|
if (!patchsize) {
|
2005-11-18 04:46:29 +00:00
|
|
|
static const char *binhdr[] = {
|
|
|
|
"Binary files ",
|
|
|
|
"Files ",
|
|
|
|
NULL,
|
|
|
|
};
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
static const char git_binary[] = "GIT binary patch\n";
|
2005-11-18 04:46:29 +00:00
|
|
|
int i;
|
|
|
|
int hd = hdrsize + offset;
|
|
|
|
unsigned long llen = linelen(buffer + hd, size - hd);
|
|
|
|
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
if (llen == sizeof(git_binary) - 1 &&
|
|
|
|
!memcmp(git_binary, buffer + hd, llen)) {
|
|
|
|
int used;
|
|
|
|
linenr++;
|
|
|
|
used = parse_binary(buffer + hd + llen,
|
|
|
|
size - hd - llen, patch);
|
|
|
|
if (used)
|
|
|
|
patchsize = used + llen;
|
|
|
|
else
|
|
|
|
patchsize = 0;
|
|
|
|
}
|
|
|
|
else if (!memcmp(" differ\n", buffer + hd + llen - 8, 8)) {
|
2005-11-18 04:46:29 +00:00
|
|
|
for (i = 0; binhdr[i]; i++) {
|
|
|
|
int len = strlen(binhdr[i]);
|
|
|
|
if (len < size - hd &&
|
|
|
|
!memcmp(binhdr[i], buffer + hd, len)) {
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
linenr++;
|
2005-11-18 04:46:29 +00:00
|
|
|
patch->is_binary = 1;
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
patchsize = llen;
|
2005-11-18 04:46:29 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
}
|
2005-11-09 22:59:23 +00:00
|
|
|
|
2006-09-07 05:45:21 +00:00
|
|
|
/* Empty patch cannot be applied if it is a text patch
|
|
|
|
* without metadata change. A binary patch appears
|
|
|
|
* empty to us here.
|
2005-11-16 22:12:56 +00:00
|
|
|
*/
|
|
|
|
if ((apply || check) &&
|
2006-09-07 05:45:21 +00:00
|
|
|
(!patch->is_binary && !metadata_changes(patch)))
|
2005-11-09 22:59:23 +00:00
|
|
|
die("patch with only garbage at line %d", linenr);
|
|
|
|
}
|
2005-10-01 06:25:23 +00:00
|
|
|
|
2005-05-23 17:52:17 +00:00
|
|
|
return offset + hdrsize + patchsize;
|
|
|
|
}
|
|
|
|
|
2006-07-28 15:46:11 +00:00
|
|
|
#define swap(a,b) myswap((a),(b),sizeof(a))
|
|
|
|
|
|
|
|
#define myswap(a, b, size) do { \
|
|
|
|
unsigned char mytmp[size]; \
|
|
|
|
memcpy(mytmp, &a, size); \
|
|
|
|
memcpy(&a, &b, size); \
|
|
|
|
memcpy(&b, mytmp, size); \
|
|
|
|
} while (0)
|
|
|
|
|
|
|
|
static void reverse_patches(struct patch *p)
|
|
|
|
{
|
|
|
|
for (; p; p = p->next) {
|
|
|
|
struct fragment *frag = p->fragments;
|
|
|
|
|
|
|
|
swap(p->new_name, p->old_name);
|
|
|
|
swap(p->new_mode, p->old_mode);
|
|
|
|
swap(p->is_new, p->is_delete);
|
|
|
|
swap(p->lines_added, p->lines_deleted);
|
|
|
|
swap(p->old_sha1_prefix, p->new_sha1_prefix);
|
|
|
|
|
|
|
|
for (; frag; frag = frag->next) {
|
|
|
|
swap(frag->newpos, frag->oldpos);
|
|
|
|
swap(frag->newlines, frag->oldlines);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
static const char pluses[] =
|
|
|
|
"++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++";
|
|
|
|
static const char minuses[]=
|
|
|
|
"----------------------------------------------------------------------";
|
2005-05-26 18:40:43 +00:00
|
|
|
|
|
|
|
static void show_stats(struct patch *patch)
|
|
|
|
{
|
Full rework of quote_c_style and write_name_quoted.
* quote_c_style works on a strbuf instead of a wild buffer.
* quote_c_style is now clever enough to not add double quotes if not needed.
* write_name_quoted inherits those advantages, but also take a different
set of arguments. Now instead of asking for quotes or not, you pass a
"terminator". If it's \0 then we assume you don't want to escape, else C
escaping is performed. In any case, the terminator is also appended to the
stream. It also no longer takes the prefix/prefix_len arguments, as it's
seldomly used, and makes some optimizations harder.
* write_name_quotedpfx is created to work like write_name_quoted and take
the prefix/prefix_len arguments.
Thanks to those API changes, diff.c has somehow lost weight, thanks to the
removal of functions that were wrappers around the old write_name_quoted
trying to give it a semantics like the new one, but performing a lot of
allocations for this goal. Now we always write directly to the stream, no
intermediate allocation is performed.
As a side effect of the refactor in builtin-apply.c, the length of the bar
graphs in diffstats are not affected anymore by the fact that the path was
clipped.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
2007-09-19 22:42:15 +00:00
|
|
|
struct strbuf qname;
|
|
|
|
char *cp = patch->new_name ? patch->new_name : patch->old_name;
|
|
|
|
int max, add, del;
|
2005-05-26 18:40:43 +00:00
|
|
|
|
Full rework of quote_c_style and write_name_quoted.
* quote_c_style works on a strbuf instead of a wild buffer.
* quote_c_style is now clever enough to not add double quotes if not needed.
* write_name_quoted inherits those advantages, but also take a different
set of arguments. Now instead of asking for quotes or not, you pass a
"terminator". If it's \0 then we assume you don't want to escape, else C
escaping is performed. In any case, the terminator is also appended to the
stream. It also no longer takes the prefix/prefix_len arguments, as it's
seldomly used, and makes some optimizations harder.
* write_name_quotedpfx is created to work like write_name_quoted and take
the prefix/prefix_len arguments.
Thanks to those API changes, diff.c has somehow lost weight, thanks to the
removal of functions that were wrappers around the old write_name_quoted
trying to give it a semantics like the new one, but performing a lot of
allocations for this goal. Now we always write directly to the stream, no
intermediate allocation is performed.
As a side effect of the refactor in builtin-apply.c, the length of the bar
graphs in diffstats are not affected anymore by the fact that the path was
clipped.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
2007-09-19 22:42:15 +00:00
|
|
|
strbuf_init(&qname, 0);
|
|
|
|
quote_c_style(cp, &qname, NULL, 0);
|
2005-10-15 04:54:52 +00:00
|
|
|
|
2005-05-26 18:40:43 +00:00
|
|
|
/*
|
|
|
|
* "scale" the filename
|
|
|
|
*/
|
|
|
|
max = max_len;
|
|
|
|
if (max > 50)
|
|
|
|
max = 50;
|
Full rework of quote_c_style and write_name_quoted.
* quote_c_style works on a strbuf instead of a wild buffer.
* quote_c_style is now clever enough to not add double quotes if not needed.
* write_name_quoted inherits those advantages, but also take a different
set of arguments. Now instead of asking for quotes or not, you pass a
"terminator". If it's \0 then we assume you don't want to escape, else C
escaping is performed. In any case, the terminator is also appended to the
stream. It also no longer takes the prefix/prefix_len arguments, as it's
seldomly used, and makes some optimizations harder.
* write_name_quotedpfx is created to work like write_name_quoted and take
the prefix/prefix_len arguments.
Thanks to those API changes, diff.c has somehow lost weight, thanks to the
removal of functions that were wrappers around the old write_name_quoted
trying to give it a semantics like the new one, but performing a lot of
allocations for this goal. Now we always write directly to the stream, no
intermediate allocation is performed.
As a side effect of the refactor in builtin-apply.c, the length of the bar
graphs in diffstats are not affected anymore by the fact that the path was
clipped.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
2007-09-19 22:42:15 +00:00
|
|
|
|
|
|
|
if (qname.len > max) {
|
|
|
|
cp = strchr(qname.buf + qname.len + 3 - max, '/');
|
|
|
|
if (!cp)
|
|
|
|
cp = qname.buf + qname.len + 3 - max;
|
|
|
|
strbuf_splice(&qname, 0, cp - qname.buf, "...", 3);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (patch->is_binary) {
|
|
|
|
printf(" %-*s | Bin\n", max, qname.buf);
|
|
|
|
strbuf_release(&qname);
|
|
|
|
return;
|
2005-07-29 03:37:23 +00:00
|
|
|
}
|
Full rework of quote_c_style and write_name_quoted.
* quote_c_style works on a strbuf instead of a wild buffer.
* quote_c_style is now clever enough to not add double quotes if not needed.
* write_name_quoted inherits those advantages, but also take a different
set of arguments. Now instead of asking for quotes or not, you pass a
"terminator". If it's \0 then we assume you don't want to escape, else C
escaping is performed. In any case, the terminator is also appended to the
stream. It also no longer takes the prefix/prefix_len arguments, as it's
seldomly used, and makes some optimizations harder.
* write_name_quotedpfx is created to work like write_name_quoted and take
the prefix/prefix_len arguments.
Thanks to those API changes, diff.c has somehow lost weight, thanks to the
removal of functions that were wrappers around the old write_name_quoted
trying to give it a semantics like the new one, but performing a lot of
allocations for this goal. Now we always write directly to the stream, no
intermediate allocation is performed.
As a side effect of the refactor in builtin-apply.c, the length of the bar
graphs in diffstats are not affected anymore by the fact that the path was
clipped.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
2007-09-19 22:42:15 +00:00
|
|
|
|
|
|
|
printf(" %-*s |", max, qname.buf);
|
|
|
|
strbuf_release(&qname);
|
2005-05-26 18:40:43 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* scale the add/delete
|
|
|
|
*/
|
Full rework of quote_c_style and write_name_quoted.
* quote_c_style works on a strbuf instead of a wild buffer.
* quote_c_style is now clever enough to not add double quotes if not needed.
* write_name_quoted inherits those advantages, but also take a different
set of arguments. Now instead of asking for quotes or not, you pass a
"terminator". If it's \0 then we assume you don't want to escape, else C
escaping is performed. In any case, the terminator is also appended to the
stream. It also no longer takes the prefix/prefix_len arguments, as it's
seldomly used, and makes some optimizations harder.
* write_name_quotedpfx is created to work like write_name_quoted and take
the prefix/prefix_len arguments.
Thanks to those API changes, diff.c has somehow lost weight, thanks to the
removal of functions that were wrappers around the old write_name_quoted
trying to give it a semantics like the new one, but performing a lot of
allocations for this goal. Now we always write directly to the stream, no
intermediate allocation is performed.
As a side effect of the refactor in builtin-apply.c, the length of the bar
graphs in diffstats are not affected anymore by the fact that the path was
clipped.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
2007-09-19 22:42:15 +00:00
|
|
|
max = max + max_change > 70 ? 70 - max : max_change;
|
2005-06-01 03:50:49 +00:00
|
|
|
add = patch->lines_added;
|
|
|
|
del = patch->lines_deleted;
|
|
|
|
|
2005-06-21 15:14:30 +00:00
|
|
|
if (max_change > 0) {
|
Full rework of quote_c_style and write_name_quoted.
* quote_c_style works on a strbuf instead of a wild buffer.
* quote_c_style is now clever enough to not add double quotes if not needed.
* write_name_quoted inherits those advantages, but also take a different
set of arguments. Now instead of asking for quotes or not, you pass a
"terminator". If it's \0 then we assume you don't want to escape, else C
escaping is performed. In any case, the terminator is also appended to the
stream. It also no longer takes the prefix/prefix_len arguments, as it's
seldomly used, and makes some optimizations harder.
* write_name_quotedpfx is created to work like write_name_quoted and take
the prefix/prefix_len arguments.
Thanks to those API changes, diff.c has somehow lost weight, thanks to the
removal of functions that were wrappers around the old write_name_quoted
trying to give it a semantics like the new one, but performing a lot of
allocations for this goal. Now we always write directly to the stream, no
intermediate allocation is performed.
As a side effect of the refactor in builtin-apply.c, the length of the bar
graphs in diffstats are not affected anymore by the fact that the path was
clipped.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
2007-09-19 22:42:15 +00:00
|
|
|
int total = ((add + del) * max + max_change / 2) / max_change;
|
2005-06-21 15:14:30 +00:00
|
|
|
add = (add * max + max_change / 2) / max_change;
|
|
|
|
del = total - add;
|
|
|
|
}
|
Full rework of quote_c_style and write_name_quoted.
* quote_c_style works on a strbuf instead of a wild buffer.
* quote_c_style is now clever enough to not add double quotes if not needed.
* write_name_quoted inherits those advantages, but also take a different
set of arguments. Now instead of asking for quotes or not, you pass a
"terminator". If it's \0 then we assume you don't want to escape, else C
escaping is performed. In any case, the terminator is also appended to the
stream. It also no longer takes the prefix/prefix_len arguments, as it's
seldomly used, and makes some optimizations harder.
* write_name_quotedpfx is created to work like write_name_quoted and take
the prefix/prefix_len arguments.
Thanks to those API changes, diff.c has somehow lost weight, thanks to the
removal of functions that were wrappers around the old write_name_quoted
trying to give it a semantics like the new one, but performing a lot of
allocations for this goal. Now we always write directly to the stream, no
intermediate allocation is performed.
As a side effect of the refactor in builtin-apply.c, the length of the bar
graphs in diffstats are not affected anymore by the fact that the path was
clipped.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
2007-09-19 22:42:15 +00:00
|
|
|
printf("%5d %.*s%.*s\n", patch->lines_added + patch->lines_deleted,
|
|
|
|
add, pluses, del, minuses);
|
2005-05-26 18:40:43 +00:00
|
|
|
}
|
|
|
|
|
2007-09-16 16:54:42 +00:00
|
|
|
static int read_old_data(struct stat *st, const char *path, struct strbuf *buf)
|
2005-06-05 18:03:13 +00:00
|
|
|
{
|
|
|
|
switch (st->st_mode & S_IFMT) {
|
|
|
|
case S_IFLNK:
|
2007-09-16 16:54:42 +00:00
|
|
|
strbuf_grow(buf, st->st_size);
|
|
|
|
if (readlink(path, buf->buf, st->st_size) != st->st_size)
|
|
|
|
return -1;
|
|
|
|
strbuf_setlen(buf, st->st_size);
|
|
|
|
return 0;
|
2005-06-05 18:03:13 +00:00
|
|
|
case S_IFREG:
|
2007-09-27 13:25:55 +00:00
|
|
|
if (strbuf_read_file(buf, path, st->st_size) != st->st_size)
|
|
|
|
return error("unable to open or read %s", path);
|
safecrlf: Add mechanism to warn about irreversible crlf conversions
CRLF conversion bears a slight chance of corrupting data.
autocrlf=true will convert CRLF to LF during commit and LF to
CRLF during checkout. A file that contains a mixture of LF and
CRLF before the commit cannot be recreated by git. For text
files this is the right thing to do: it corrects line endings
such that we have only LF line endings in the repository.
But for binary files that are accidentally classified as text the
conversion can corrupt data.
If you recognize such corruption early you can easily fix it by
setting the conversion type explicitly in .gitattributes. Right
after committing you still have the original file in your work
tree and this file is not yet corrupted. You can explicitly tell
git that this file is binary and git will handle the file
appropriately.
Unfortunately, the desired effect of cleaning up text files with
mixed line endings and the undesired effect of corrupting binary
files cannot be distinguished. In both cases CRLFs are removed
in an irreversible way. For text files this is the right thing
to do because CRLFs are line endings, while for binary files
converting CRLFs corrupts data.
This patch adds a mechanism that can either warn the user about
an irreversible conversion or can even refuse to convert. The
mechanism is controlled by the variable core.safecrlf, with the
following values:
- false: disable safecrlf mechanism
- warn: warn about irreversible conversions
- true: refuse irreversible conversions
The default is to warn. Users are only affected by this default
if core.autocrlf is set. But the current default of git is to
leave core.autocrlf unset, so users will not see warnings unless
they deliberately chose to activate the autocrlf mechanism.
The safecrlf mechanism's details depend on the git command. The
general principles when safecrlf is active (not false) are:
- we warn/error out if files in the work tree can modified in an
irreversible way without giving the user a chance to backup the
original file.
- for read-only operations that do not modify files in the work tree
we do not not print annoying warnings.
There are exceptions. Even though...
- "git add" itself does not touch the files in the work tree, the
next checkout would, so the safety triggers;
- "git apply" to update a text file with a patch does touch the files
in the work tree, but the operation is about text files and CRLF
conversion is about fixing the line ending inconsistencies, so the
safety does not trigger;
- "git diff" itself does not touch the files in the work tree, it is
often run to inspect the changes you intend to next "git add". To
catch potential problems early, safety triggers.
The concept of a safety check was originally proposed in a similar
way by Linus Torvalds. Thanks to Dimitry Potapov for insisting
on getting the naked LF/autocrlf=true case right.
Signed-off-by: Steffen Prohaska <prohaska@zib.de>
2008-02-06 11:25:58 +00:00
|
|
|
convert_to_git(path, buf->buf, buf->len, buf, 0);
|
2007-09-16 16:54:42 +00:00
|
|
|
return 0;
|
2005-06-05 18:03:13 +00:00
|
|
|
default:
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
static void update_pre_post_images(struct image *preimage,
|
|
|
|
struct image *postimage,
|
|
|
|
char *buf,
|
|
|
|
size_t len)
|
2005-06-05 18:03:13 +00:00
|
|
|
{
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
int i, ctx;
|
|
|
|
char *new, *old, *fixed;
|
|
|
|
struct image fixed_preimage;
|
2005-06-05 18:03:13 +00:00
|
|
|
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
/*
|
|
|
|
* Update the preimage with whitespace fixes. Note that we
|
|
|
|
* are not losing preimage->buf -- apply_one_fragment() will
|
|
|
|
* free "oldlines".
|
|
|
|
*/
|
|
|
|
prepare_image(&fixed_preimage, buf, len, 1);
|
|
|
|
assert(fixed_preimage.nr == preimage->nr);
|
|
|
|
for (i = 0; i < preimage->nr; i++)
|
|
|
|
fixed_preimage.line[i].flag = preimage->line[i].flag;
|
|
|
|
free(preimage->line_allocated);
|
|
|
|
*preimage = fixed_preimage;
|
2005-06-05 18:03:13 +00:00
|
|
|
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
/*
|
|
|
|
* Adjust the common context lines in postimage, in place.
|
|
|
|
* This is possible because whitespace fixing does not make
|
|
|
|
* the string grow.
|
|
|
|
*/
|
|
|
|
new = old = postimage->buf;
|
|
|
|
fixed = preimage->buf;
|
|
|
|
for (i = ctx = 0; i < postimage->nr; i++) {
|
|
|
|
size_t len = postimage->line[i].len;
|
|
|
|
if (!(postimage->line[i].flag & LINE_COMMON)) {
|
|
|
|
/* an added line -- no counterparts in preimage */
|
|
|
|
memmove(new, old, len);
|
|
|
|
old += len;
|
|
|
|
new += len;
|
|
|
|
continue;
|
2005-06-05 18:03:13 +00:00
|
|
|
}
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
|
|
|
|
/* a common context -- skip it in the original postimage */
|
|
|
|
old += len;
|
|
|
|
|
|
|
|
/* and find the corresponding one in the fixed preimage */
|
|
|
|
while (ctx < preimage->nr &&
|
|
|
|
!(preimage->line[ctx].flag & LINE_COMMON)) {
|
|
|
|
fixed += preimage->line[ctx].len;
|
|
|
|
ctx++;
|
|
|
|
}
|
|
|
|
if (preimage->nr <= ctx)
|
|
|
|
die("oops");
|
|
|
|
|
|
|
|
/* and copy it in, while fixing the line length */
|
|
|
|
len = preimage->line[ctx].len;
|
|
|
|
memcpy(new, fixed, len);
|
|
|
|
new += len;
|
|
|
|
fixed += len;
|
|
|
|
postimage->line[i].len = len;
|
|
|
|
ctx++;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Fix the length of the whole thing */
|
|
|
|
postimage->len = new - postimage->buf;
|
|
|
|
}
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
static int match_fragment(struct image *img,
|
|
|
|
struct image *preimage,
|
|
|
|
struct image *postimage,
|
2008-01-19 08:42:22 +00:00
|
|
|
unsigned long try,
|
2008-01-27 01:42:49 +00:00
|
|
|
int try_lno,
|
2008-01-30 23:13:37 +00:00
|
|
|
unsigned ws_rule,
|
2008-01-19 09:58:34 +00:00
|
|
|
int match_beginning, int match_end)
|
2008-01-19 08:42:22 +00:00
|
|
|
{
|
2008-01-27 01:42:49 +00:00
|
|
|
int i;
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
char *fixed_buf, *buf, *orig, *target;
|
2008-01-27 01:42:49 +00:00
|
|
|
|
|
|
|
if (preimage->nr + try_lno > img->nr)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (match_beginning && try_lno)
|
2008-01-19 08:42:22 +00:00
|
|
|
return 0;
|
2008-01-19 09:58:34 +00:00
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
if (match_end && preimage->nr + try_lno != img->nr)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* Quick hash check */
|
|
|
|
for (i = 0; i < preimage->nr; i++)
|
|
|
|
if (preimage->line[i].hash != img->line[try_lno + i].hash)
|
|
|
|
return 0;
|
|
|
|
|
2008-01-19 09:58:34 +00:00
|
|
|
/*
|
|
|
|
* Do we have an exact match? If we were told to match
|
|
|
|
* at the end, size must be exactly at try+fragsize,
|
|
|
|
* otherwise try+fragsize must be still within the preimage,
|
|
|
|
* and either case, the old piece should match the preimage
|
|
|
|
* exactly.
|
|
|
|
*/
|
|
|
|
if ((match_end
|
2008-01-27 01:42:49 +00:00
|
|
|
? (try + preimage->len == img->len)
|
|
|
|
: (try + preimage->len <= img->len)) &&
|
|
|
|
!memcmp(img->buf + try, preimage->buf, preimage->len))
|
2008-01-19 09:58:34 +00:00
|
|
|
return 1;
|
|
|
|
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
if (ws_error_action != correct_ws_error)
|
|
|
|
return 0;
|
|
|
|
|
2008-01-19 09:58:34 +00:00
|
|
|
/*
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
* The hunk does not apply byte-by-byte, but the hash says
|
|
|
|
* it might with whitespace fuzz.
|
2008-01-19 09:58:34 +00:00
|
|
|
*/
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
fixed_buf = xmalloc(preimage->len + 1);
|
|
|
|
buf = fixed_buf;
|
|
|
|
orig = preimage->buf;
|
|
|
|
target = img->buf + try;
|
|
|
|
for (i = 0; i < preimage->nr; i++) {
|
|
|
|
size_t fixlen; /* length after fixing the preimage */
|
|
|
|
size_t oldlen = preimage->line[i].len;
|
|
|
|
size_t tgtlen = img->line[try_lno + i].len;
|
|
|
|
size_t tgtfixlen; /* length after fixing the target line */
|
|
|
|
char tgtfixbuf[1024], *tgtfix;
|
|
|
|
int match;
|
|
|
|
|
|
|
|
/* Try fixing the line in the preimage */
|
2008-02-24 00:59:16 +00:00
|
|
|
fixlen = ws_fix_copy(buf, orig, oldlen, ws_rule, NULL);
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
|
|
|
|
/* Try fixing the line in the target */
|
|
|
|
if (sizeof(tgtfixbuf) < tgtlen)
|
|
|
|
tgtfix = tgtfixbuf;
|
|
|
|
else
|
|
|
|
tgtfix = xmalloc(tgtlen);
|
2008-02-24 00:59:16 +00:00
|
|
|
tgtfixlen = ws_fix_copy(tgtfix, target, tgtlen, ws_rule, NULL);
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If they match, either the preimage was based on
|
|
|
|
* a version before our tree fixed whitespace breakage,
|
|
|
|
* or we are lacking a whitespace-fix patch the tree
|
|
|
|
* the preimage was based on already had (i.e. target
|
|
|
|
* has whitespace breakage, the preimage doesn't).
|
|
|
|
* In either case, we are fixing the whitespace breakages
|
|
|
|
* so we might as well take the fix together with their
|
|
|
|
* real change.
|
|
|
|
*/
|
|
|
|
match = (tgtfixlen == fixlen && !memcmp(tgtfix, buf, fixlen));
|
|
|
|
|
|
|
|
if (tgtfix != tgtfixbuf)
|
|
|
|
free(tgtfix);
|
|
|
|
if (!match)
|
|
|
|
goto unmatch_exit;
|
|
|
|
|
|
|
|
orig += oldlen;
|
|
|
|
buf += fixlen;
|
|
|
|
target += tgtlen;
|
2005-06-05 18:03:13 +00:00
|
|
|
}
|
|
|
|
|
git-apply --whitespace=fix: fix whitespace fuzz introduced by previous run
When you have more than one patch series, an earlier one of which
tries to introduce whitespace breakages and a later one of which
has such a new line in its context, "git-apply --whitespace=fix"
will apply and fix the whitespace breakages in the earlier one,
making the resulting file not to match the context of the later
patch.
A short demonstration is in the new test, t4125.
For example, suppose the first patch is:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -20,3 +20,3 @@
Hello world.$
-How Are you$
-Today?$
+How are you $
+today? $
to fix broken case in the string, but it introduces unwanted
trailing whitespaces to the result (pretend you are looking at
"cat -e" output of the patch --- '$' signs are not in the patch
but are shown to make the EOL stand out). And the second patch
is to change the wording of the greeting further:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings $
-Hello world.$
+Hello, everybody. $
How are you $
-today? $
+these days? $
If you apply the first one with --whitespace=fix, you will get
this as the result:
Hello world.$
How are you$
today?$
and this does not match the preimage of the second patch, which
demands extra whitespace after "How are you" and "today?".
This series is about teaching "git apply --whitespace=fix" to
cope with this situation better. If the patch does not apply,
it rewrites the second patch like this and retries:
diff a/hello.txt b/hello.txt
--- a/hello.txt
+++ b/hello.txt
@@ -18,5 +18,5 @@
Greetings$
-Hello world.$
+Hello, everybody.$
How are you$
-today?$
+these days?$
This is done by rewriting the preimage lines in the hunk
(i.e. the lines that begin with ' ' or '-'), using the same
whitespace fixing rules as it is using to apply the patches, so
that it can notice what it did to the previous ones in the
series.
A careful reader may notice that the first patch in the example
did not touch the "Greetings" line, so the trailing whitespace
that is in the original preimage of the second patch is not from
the series. Is rewriting this context line a problem?
If you think about it, you will realize that the reason for the
difference is because the submitter's tree was based on an
earlier version of the file that had whitespaces wrong on that
"Greetings" line, and the change that introduced the "Greetings"
line was added independently of this two-patch series to our
tree already with an earlier "git apply --whitespace=fix".
So it may appear this logic is rewriting too much, it is not
so. It is just rewriting what we would have rewritten in the
past.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-01-30 23:24:34 +00:00
|
|
|
/*
|
|
|
|
* Yes, the preimage is based on an older version that still
|
|
|
|
* has whitespace breakages unfixed, and fixing them makes the
|
|
|
|
* hunk match. Update the context lines in the postimage.
|
|
|
|
*/
|
|
|
|
update_pre_post_images(preimage, postimage,
|
|
|
|
fixed_buf, buf - fixed_buf);
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
unmatch_exit:
|
|
|
|
free(fixed_buf);
|
2008-01-19 09:58:34 +00:00
|
|
|
return 0;
|
2008-01-19 08:42:22 +00:00
|
|
|
}
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
static int find_pos(struct image *img,
|
|
|
|
struct image *preimage,
|
|
|
|
struct image *postimage,
|
|
|
|
int line,
|
2008-01-30 23:13:37 +00:00
|
|
|
unsigned ws_rule,
|
2008-01-27 01:42:49 +00:00
|
|
|
int match_beginning, int match_end)
|
2005-06-05 18:03:13 +00:00
|
|
|
{
|
2008-01-27 01:42:49 +00:00
|
|
|
int i;
|
|
|
|
unsigned long backwards, forwards, try;
|
|
|
|
int backwards_lno, forwards_lno, try_lno;
|
2005-06-05 18:03:13 +00:00
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
if (preimage->nr > img->nr)
|
2005-06-05 18:03:13 +00:00
|
|
|
return -1;
|
|
|
|
|
2008-01-28 11:04:30 +00:00
|
|
|
/*
|
|
|
|
* If match_begining or match_end is specified, there is no
|
|
|
|
* point starting from a wrong line that will never match and
|
|
|
|
* wander around and wait for a match at the specified end.
|
|
|
|
*/
|
|
|
|
if (match_beginning)
|
|
|
|
line = 0;
|
|
|
|
else if (match_end)
|
|
|
|
line = img->nr - preimage->nr;
|
|
|
|
|
2008-02-11 23:32:29 +00:00
|
|
|
if (line > img->nr)
|
|
|
|
line = img->nr;
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
try = 0;
|
|
|
|
for (i = 0; i < line; i++)
|
|
|
|
try += img->line[i].len;
|
2005-06-05 18:03:13 +00:00
|
|
|
|
2005-06-05 19:16:32 +00:00
|
|
|
/*
|
|
|
|
* There's probably some smart way to do this, but I'll leave
|
|
|
|
* that to the smart and beautiful people. I'm simple and stupid.
|
|
|
|
*/
|
2008-01-27 01:42:49 +00:00
|
|
|
backwards = try;
|
|
|
|
backwards_lno = line;
|
|
|
|
forwards = try;
|
|
|
|
forwards_lno = line;
|
|
|
|
try_lno = line;
|
2008-01-19 10:16:16 +00:00
|
|
|
|
2005-06-05 19:16:32 +00:00
|
|
|
for (i = 0; ; i++) {
|
2008-01-27 01:42:49 +00:00
|
|
|
if (match_fragment(img, preimage, postimage,
|
2008-01-30 23:13:37 +00:00
|
|
|
try, try_lno, ws_rule,
|
2008-01-27 01:42:49 +00:00
|
|
|
match_beginning, match_end))
|
|
|
|
return try_lno;
|
2008-01-19 10:16:16 +00:00
|
|
|
|
|
|
|
again:
|
2008-01-27 01:42:49 +00:00
|
|
|
if (backwards_lno == 0 && forwards_lno == img->nr)
|
2008-01-19 10:16:16 +00:00
|
|
|
break;
|
2005-06-05 19:16:32 +00:00
|
|
|
|
|
|
|
if (i & 1) {
|
2008-01-27 01:42:49 +00:00
|
|
|
if (backwards_lno == 0) {
|
2008-01-19 10:16:16 +00:00
|
|
|
i++;
|
|
|
|
goto again;
|
2005-06-05 19:16:32 +00:00
|
|
|
}
|
2008-01-27 01:42:49 +00:00
|
|
|
backwards_lno--;
|
|
|
|
backwards -= img->line[backwards_lno].len;
|
2005-06-05 19:16:32 +00:00
|
|
|
try = backwards;
|
2008-01-27 01:42:49 +00:00
|
|
|
try_lno = backwards_lno;
|
2005-06-05 19:16:32 +00:00
|
|
|
} else {
|
2008-01-27 01:42:49 +00:00
|
|
|
if (forwards_lno == img->nr) {
|
2008-01-19 10:16:16 +00:00
|
|
|
i++;
|
|
|
|
goto again;
|
2005-06-05 19:16:32 +00:00
|
|
|
}
|
2008-01-27 01:42:49 +00:00
|
|
|
forwards += img->line[forwards_lno].len;
|
|
|
|
forwards_lno++;
|
2005-06-05 19:16:32 +00:00
|
|
|
try = forwards;
|
2008-01-27 01:42:49 +00:00
|
|
|
try_lno = forwards_lno;
|
2005-06-05 19:16:32 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|
2005-06-05 18:03:13 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
static void remove_first_line(struct image *img)
|
2006-04-10 09:33:06 +00:00
|
|
|
{
|
2008-01-27 01:42:49 +00:00
|
|
|
img->buf += img->line[0].len;
|
|
|
|
img->len -= img->line[0].len;
|
|
|
|
img->line++;
|
|
|
|
img->nr--;
|
2006-04-10 09:33:06 +00:00
|
|
|
}
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
static void remove_last_line(struct image *img)
|
2006-04-10 09:33:06 +00:00
|
|
|
{
|
2008-01-27 01:42:49 +00:00
|
|
|
img->len -= img->line[--img->nr].len;
|
2006-04-10 09:33:06 +00:00
|
|
|
}
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
static void update_image(struct image *img,
|
|
|
|
int applied_pos,
|
|
|
|
struct image *preimage,
|
|
|
|
struct image *postimage)
|
2006-02-27 02:13:25 +00:00
|
|
|
{
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
2008-01-27 01:42:49 +00:00
|
|
|
* remove the copy of preimage at offset in img
|
|
|
|
* and replace it with postimage
|
2007-11-23 10:37:03 +00:00
|
|
|
*/
|
2008-01-27 01:42:49 +00:00
|
|
|
int i, nr;
|
|
|
|
size_t remove_count, insert_count, applied_at = 0;
|
|
|
|
char *result;
|
2007-11-24 04:14:20 +00:00
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
for (i = 0; i < applied_pos; i++)
|
|
|
|
applied_at += img->line[i].len;
|
|
|
|
|
|
|
|
remove_count = 0;
|
|
|
|
for (i = 0; i < preimage->nr; i++)
|
|
|
|
remove_count += img->line[applied_pos + i].len;
|
|
|
|
insert_count = postimage->len;
|
|
|
|
|
|
|
|
/* Adjust the contents */
|
|
|
|
result = xmalloc(img->len + insert_count - remove_count + 1);
|
|
|
|
memcpy(result, img->buf, applied_at);
|
|
|
|
memcpy(result + applied_at, postimage->buf, postimage->len);
|
|
|
|
memcpy(result + applied_at + postimage->len,
|
|
|
|
img->buf + (applied_at + remove_count),
|
|
|
|
img->len - (applied_at + remove_count));
|
|
|
|
free(img->buf);
|
|
|
|
img->buf = result;
|
|
|
|
img->len += insert_count - remove_count;
|
|
|
|
result[img->len] = '\0';
|
|
|
|
|
|
|
|
/* Adjust the line table */
|
|
|
|
nr = img->nr + postimage->nr - preimage->nr;
|
|
|
|
if (preimage->nr < postimage->nr) {
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
2008-01-27 01:42:49 +00:00
|
|
|
* NOTE: this knows that we never call remove_first_line()
|
|
|
|
* on anything other than pre/post image.
|
2006-09-23 07:37:19 +00:00
|
|
|
*/
|
2008-01-27 01:42:49 +00:00
|
|
|
img->line = xrealloc(img->line, nr * sizeof(*img->line));
|
|
|
|
img->line_allocated = img->line;
|
2006-09-23 07:37:19 +00:00
|
|
|
}
|
2008-01-27 01:42:49 +00:00
|
|
|
if (preimage->nr != postimage->nr)
|
|
|
|
memmove(img->line + applied_pos + postimage->nr,
|
|
|
|
img->line + applied_pos + preimage->nr,
|
|
|
|
(img->nr - (applied_pos + preimage->nr)) *
|
|
|
|
sizeof(*img->line));
|
|
|
|
memcpy(img->line + applied_pos,
|
|
|
|
postimage->line,
|
|
|
|
postimage->nr * sizeof(*img->line));
|
|
|
|
img->nr = nr;
|
2006-02-27 02:13:25 +00:00
|
|
|
}
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
static int apply_one_fragment(struct image *img, struct fragment *frag,
|
2007-12-06 08:14:14 +00:00
|
|
|
int inaccurate_eof, unsigned ws_rule)
|
2005-06-05 18:03:13 +00:00
|
|
|
{
|
2006-05-24 20:19:50 +00:00
|
|
|
int match_beginning, match_end;
|
2005-06-05 18:03:13 +00:00
|
|
|
const char *patch = frag->patch;
|
2008-01-27 01:42:49 +00:00
|
|
|
int size = frag->size;
|
2008-01-30 21:12:25 +00:00
|
|
|
char *old, *new, *oldlines, *newlines;
|
2007-05-21 06:51:06 +00:00
|
|
|
int new_blank_lines_at_end = 0;
|
2006-04-10 09:33:06 +00:00
|
|
|
unsigned long leading, trailing;
|
2008-01-27 01:42:49 +00:00
|
|
|
int pos, applied_pos;
|
|
|
|
struct image preimage;
|
|
|
|
struct image postimage;
|
2005-06-05 18:03:13 +00:00
|
|
|
|
2008-01-29 08:17:55 +00:00
|
|
|
memset(&preimage, 0, sizeof(preimage));
|
|
|
|
memset(&postimage, 0, sizeof(postimage));
|
2008-01-30 21:12:25 +00:00
|
|
|
oldlines = xmalloc(size);
|
|
|
|
newlines = xmalloc(size);
|
2008-01-29 08:17:55 +00:00
|
|
|
|
2008-01-30 21:12:25 +00:00
|
|
|
old = oldlines;
|
|
|
|
new = newlines;
|
2005-06-05 18:03:13 +00:00
|
|
|
while (size > 0) {
|
2006-07-28 15:46:11 +00:00
|
|
|
char first;
|
2005-06-05 18:03:13 +00:00
|
|
|
int len = linelen(patch, size);
|
2008-01-30 21:19:58 +00:00
|
|
|
int plen, added;
|
2007-05-21 06:51:06 +00:00
|
|
|
int added_blank_line = 0;
|
2005-06-05 18:03:13 +00:00
|
|
|
|
|
|
|
if (!len)
|
|
|
|
break;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* "plen" is how much of the line we should use for
|
|
|
|
* the actual patch data. Normally we just remove the
|
|
|
|
* first character on the line, but if the line is
|
|
|
|
* followed by "\ No newline", then we also remove the
|
|
|
|
* last one (which is the newline, of course).
|
|
|
|
*/
|
2008-01-30 21:12:25 +00:00
|
|
|
plen = len - 1;
|
2005-07-22 16:56:39 +00:00
|
|
|
if (len < size && patch[len] == '\\')
|
2005-06-05 18:03:13 +00:00
|
|
|
plen--;
|
2006-07-28 15:46:11 +00:00
|
|
|
first = *patch;
|
2006-08-15 06:26:51 +00:00
|
|
|
if (apply_in_reverse) {
|
2006-07-28 15:46:11 +00:00
|
|
|
if (first == '-')
|
|
|
|
first = '+';
|
|
|
|
else if (first == '+')
|
|
|
|
first = '-';
|
|
|
|
}
|
2007-05-20 12:45:59 +00:00
|
|
|
|
2006-07-28 15:46:11 +00:00
|
|
|
switch (first) {
|
2006-10-20 02:26:08 +00:00
|
|
|
case '\n':
|
|
|
|
/* Newer GNU diff, empty context line */
|
|
|
|
if (plen < 0)
|
|
|
|
/* ... followed by '\No newline'; nothing */
|
|
|
|
break;
|
2008-01-30 21:12:25 +00:00
|
|
|
*old++ = '\n';
|
|
|
|
*new++ = '\n';
|
2008-01-29 08:17:55 +00:00
|
|
|
add_line_info(&preimage, "\n", 1, LINE_COMMON);
|
|
|
|
add_line_info(&postimage, "\n", 1, LINE_COMMON);
|
2006-10-20 02:26:08 +00:00
|
|
|
break;
|
2005-06-05 18:03:13 +00:00
|
|
|
case ' ':
|
|
|
|
case '-':
|
2008-01-30 21:12:25 +00:00
|
|
|
memcpy(old, patch + 1, plen);
|
|
|
|
add_line_info(&preimage, old, plen,
|
2008-01-29 08:17:55 +00:00
|
|
|
(first == ' ' ? LINE_COMMON : 0));
|
2008-01-30 21:12:25 +00:00
|
|
|
old += plen;
|
2006-07-28 15:46:11 +00:00
|
|
|
if (first == '-')
|
2005-06-05 18:03:13 +00:00
|
|
|
break;
|
|
|
|
/* Fall-through for ' ' */
|
|
|
|
case '+':
|
2008-01-30 21:19:58 +00:00
|
|
|
/* --no-add does not add new lines */
|
|
|
|
if (first == '+' && no_add)
|
|
|
|
break;
|
|
|
|
|
|
|
|
if (first != '+' ||
|
|
|
|
!whitespace_error ||
|
|
|
|
ws_error_action != correct_ws_error) {
|
|
|
|
memcpy(new, patch + 1, plen);
|
|
|
|
added = plen;
|
|
|
|
}
|
|
|
|
else {
|
2008-02-24 00:59:16 +00:00
|
|
|
added = ws_fix_copy(new, patch + 1, plen, ws_rule, &applied_after_fixing_ws);
|
2007-05-21 06:51:06 +00:00
|
|
|
}
|
2008-01-30 21:19:58 +00:00
|
|
|
add_line_info(&postimage, new, added,
|
|
|
|
(first == '+' ? 0 : LINE_COMMON));
|
|
|
|
new += added;
|
|
|
|
if (first == '+' &&
|
|
|
|
added == 1 && new[-1] == '\n')
|
|
|
|
added_blank_line = 1;
|
2005-06-05 18:03:13 +00:00
|
|
|
break;
|
|
|
|
case '@': case '\\':
|
|
|
|
/* Ignore it, we already handled it */
|
|
|
|
break;
|
|
|
|
default:
|
2007-02-22 19:11:21 +00:00
|
|
|
if (apply_verbosely)
|
|
|
|
error("invalid start of line: '%c'", first);
|
2005-06-05 18:03:13 +00:00
|
|
|
return -1;
|
|
|
|
}
|
2007-05-21 06:51:06 +00:00
|
|
|
if (added_blank_line)
|
|
|
|
new_blank_lines_at_end++;
|
|
|
|
else
|
|
|
|
new_blank_lines_at_end = 0;
|
2005-06-05 18:03:13 +00:00
|
|
|
patch += len;
|
|
|
|
size -= len;
|
|
|
|
}
|
2007-11-23 10:37:03 +00:00
|
|
|
if (inaccurate_eof &&
|
2008-01-30 21:12:25 +00:00
|
|
|
old > oldlines && old[-1] == '\n' &&
|
|
|
|
new > newlines && new[-1] == '\n') {
|
|
|
|
old--;
|
|
|
|
new--;
|
2006-02-17 14:23:16 +00:00
|
|
|
}
|
2006-04-10 09:33:06 +00:00
|
|
|
|
|
|
|
leading = frag->leading;
|
|
|
|
trailing = frag->trailing;
|
2006-05-24 02:08:01 +00:00
|
|
|
|
|
|
|
/*
|
2008-04-07 02:21:45 +00:00
|
|
|
* A hunk to change lines at the beginning would begin with
|
|
|
|
* @@ -1,L +N,M @@
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
*
|
2008-04-07 02:21:45 +00:00
|
|
|
* And a hunk to add to an empty file would begin with
|
|
|
|
* @@ -0,0 +N,M @@
|
|
|
|
*
|
|
|
|
* In other words, a hunk that is (frag->oldpos <= 1) with or
|
|
|
|
* without leading context must match at the beginning.
|
2006-05-24 02:08:01 +00:00
|
|
|
*/
|
2008-04-07 02:21:45 +00:00
|
|
|
match_beginning = frag->oldpos <= 1;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* A hunk without trailing lines must match at the end.
|
|
|
|
* However, we simply cannot tell if a hunk must match end
|
|
|
|
* from the lack of trailing lines if the patch was generated
|
|
|
|
* with unidiff without any context.
|
|
|
|
*/
|
|
|
|
match_end = !unidiff_zero && !trailing;
|
2006-05-24 02:08:01 +00:00
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
pos = frag->newpos ? (frag->newpos - 1) : 0;
|
2008-01-30 21:12:25 +00:00
|
|
|
preimage.buf = oldlines;
|
|
|
|
preimage.len = old - oldlines;
|
|
|
|
postimage.buf = newlines;
|
|
|
|
postimage.len = new - newlines;
|
2008-01-29 08:17:55 +00:00
|
|
|
preimage.line = preimage.line_allocated;
|
|
|
|
postimage.line = postimage.line_allocated;
|
|
|
|
|
2006-04-10 09:33:06 +00:00
|
|
|
for (;;) {
|
2007-05-20 12:45:59 +00:00
|
|
|
|
2008-01-30 23:13:37 +00:00
|
|
|
applied_pos = find_pos(img, &preimage, &postimage, pos,
|
|
|
|
ws_rule, match_beginning, match_end);
|
2008-01-27 01:42:49 +00:00
|
|
|
|
|
|
|
if (applied_pos >= 0)
|
2006-04-10 09:33:06 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
/* Am I at my context limits? */
|
|
|
|
if ((leading <= p_context) && (trailing <= p_context))
|
|
|
|
break;
|
2006-05-24 20:19:50 +00:00
|
|
|
if (match_beginning || match_end) {
|
|
|
|
match_beginning = match_end = 0;
|
2006-05-24 02:08:01 +00:00
|
|
|
continue;
|
|
|
|
}
|
2008-01-27 01:42:49 +00:00
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* Reduce the number of context lines; reduce both
|
|
|
|
* leading and trailing if they are equal otherwise
|
|
|
|
* just reduce the larger context.
|
2006-04-10 09:33:06 +00:00
|
|
|
*/
|
|
|
|
if (leading >= trailing) {
|
2008-01-27 01:42:49 +00:00
|
|
|
remove_first_line(&preimage);
|
|
|
|
remove_first_line(&postimage);
|
2006-04-10 09:33:06 +00:00
|
|
|
pos--;
|
|
|
|
leading--;
|
|
|
|
}
|
|
|
|
if (trailing > leading) {
|
2008-01-27 01:42:49 +00:00
|
|
|
remove_last_line(&preimage);
|
|
|
|
remove_last_line(&postimage);
|
2006-04-10 09:33:06 +00:00
|
|
|
trailing--;
|
2005-06-05 19:16:32 +00:00
|
|
|
}
|
2005-06-05 18:03:13 +00:00
|
|
|
}
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
if (applied_pos >= 0) {
|
|
|
|
if (ws_error_action == correct_ws_error &&
|
|
|
|
new_blank_lines_at_end &&
|
|
|
|
postimage.nr + applied_pos == img->nr) {
|
|
|
|
/*
|
|
|
|
* If the patch application adds blank lines
|
|
|
|
* at the end, and if the patch applies at the
|
|
|
|
* end of the image, remove those added blank
|
|
|
|
* lines.
|
|
|
|
*/
|
|
|
|
while (new_blank_lines_at_end--)
|
|
|
|
remove_last_line(&postimage);
|
|
|
|
}
|
2007-02-22 19:11:21 +00:00
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
/*
|
|
|
|
* Warn if it was necessary to reduce the number
|
|
|
|
* of context lines.
|
|
|
|
*/
|
|
|
|
if ((leading != frag->leading) ||
|
|
|
|
(trailing != frag->trailing))
|
|
|
|
fprintf(stderr, "Context reduced to (%ld/%ld)"
|
|
|
|
" to apply fragment at %d\n",
|
|
|
|
leading, trailing, applied_pos+1);
|
|
|
|
update_image(img, applied_pos, &preimage, &postimage);
|
|
|
|
} else {
|
|
|
|
if (apply_verbosely)
|
2008-01-30 21:12:25 +00:00
|
|
|
error("while searching for:\n%.*s",
|
|
|
|
(int)(old - oldlines), oldlines);
|
2008-01-27 01:42:49 +00:00
|
|
|
}
|
2007-02-22 19:11:21 +00:00
|
|
|
|
2008-01-30 21:12:25 +00:00
|
|
|
free(oldlines);
|
|
|
|
free(newlines);
|
2008-01-27 01:42:49 +00:00
|
|
|
free(preimage.line_allocated);
|
|
|
|
free(postimage.line_allocated);
|
|
|
|
|
|
|
|
return (applied_pos < 0);
|
2005-06-05 18:03:13 +00:00
|
|
|
}
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
static int apply_binary_fragment(struct image *img, struct patch *patch)
|
2006-05-05 09:41:53 +00:00
|
|
|
{
|
|
|
|
struct fragment *fragment = patch->fragments;
|
2007-09-16 16:54:42 +00:00
|
|
|
unsigned long len;
|
|
|
|
void *dst;
|
2006-05-05 09:41:53 +00:00
|
|
|
|
2006-08-15 09:23:06 +00:00
|
|
|
/* Binary patch is irreversible without the optional second hunk */
|
|
|
|
if (apply_in_reverse) {
|
|
|
|
if (!fragment->next)
|
|
|
|
return error("cannot reverse-apply a binary patch "
|
|
|
|
"without the reverse hunk to '%s'",
|
|
|
|
patch->new_name
|
|
|
|
? patch->new_name : patch->old_name);
|
2006-08-16 23:07:20 +00:00
|
|
|
fragment = fragment->next;
|
2006-08-15 09:23:06 +00:00
|
|
|
}
|
|
|
|
switch (fragment->binary_patch_method) {
|
2006-05-05 09:41:53 +00:00
|
|
|
case BINARY_DELTA_DEFLATED:
|
2008-01-27 01:42:49 +00:00
|
|
|
dst = patch_delta(img->buf, img->len, fragment->patch,
|
2007-09-16 16:54:42 +00:00
|
|
|
fragment->size, &len);
|
|
|
|
if (!dst)
|
|
|
|
return -1;
|
2008-01-27 01:42:49 +00:00
|
|
|
clear_image(img);
|
|
|
|
img->buf = dst;
|
|
|
|
img->len = len;
|
2007-09-16 16:54:42 +00:00
|
|
|
return 0;
|
2006-05-05 09:41:53 +00:00
|
|
|
case BINARY_LITERAL_DEFLATED:
|
2008-01-27 01:42:49 +00:00
|
|
|
clear_image(img);
|
|
|
|
img->len = fragment->size;
|
|
|
|
img->buf = xmalloc(img->len+1);
|
|
|
|
memcpy(img->buf, fragment->patch, img->len);
|
|
|
|
img->buf[img->len] = '\0';
|
2007-09-16 16:54:42 +00:00
|
|
|
return 0;
|
2006-05-05 09:41:53 +00:00
|
|
|
}
|
2007-09-16 16:54:42 +00:00
|
|
|
return -1;
|
2006-05-05 09:41:53 +00:00
|
|
|
}
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
static int apply_binary(struct image *img, struct patch *patch)
|
2005-06-05 18:03:13 +00:00
|
|
|
{
|
2005-11-15 01:37:05 +00:00
|
|
|
const char *name = patch->old_name ? patch->old_name : patch->new_name;
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
unsigned char sha1[20];
|
2005-11-15 01:37:05 +00:00
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* For safety, we require patch index line to contain
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
* full 40-byte textual SHA1 for old and new, at least for now.
|
|
|
|
*/
|
|
|
|
if (strlen(patch->old_sha1_prefix) != 40 ||
|
|
|
|
strlen(patch->new_sha1_prefix) != 40 ||
|
|
|
|
get_sha1_hex(patch->old_sha1_prefix, sha1) ||
|
|
|
|
get_sha1_hex(patch->new_sha1_prefix, sha1))
|
|
|
|
return error("cannot apply binary patch to '%s' "
|
|
|
|
"without full index line", name);
|
2005-11-15 01:37:05 +00:00
|
|
|
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
if (patch->old_name) {
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* See if the old one matches what the patch
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
* applies to.
|
2005-11-15 01:37:05 +00:00
|
|
|
*/
|
2008-01-27 01:42:49 +00:00
|
|
|
hash_sha1_file(img->buf, img->len, blob_type, sha1);
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
if (strcmp(sha1_to_hex(sha1), patch->old_sha1_prefix))
|
|
|
|
return error("the patch applies to '%s' (%s), "
|
|
|
|
"which does not match the "
|
|
|
|
"current contents.",
|
|
|
|
name, sha1_to_hex(sha1));
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
/* Otherwise, the old one must be empty. */
|
2008-01-27 01:42:49 +00:00
|
|
|
if (img->len)
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
return error("the patch applies to an empty "
|
|
|
|
"'%s' but it is not empty", name);
|
|
|
|
}
|
2005-11-15 01:37:05 +00:00
|
|
|
|
2006-05-05 09:41:53 +00:00
|
|
|
get_sha1_hex(patch->new_sha1_prefix, sha1);
|
2006-08-15 20:37:19 +00:00
|
|
|
if (is_null_sha1(sha1)) {
|
2008-01-27 01:42:49 +00:00
|
|
|
clear_image(img);
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
return 0; /* deletion patch */
|
2006-05-05 09:41:53 +00:00
|
|
|
}
|
2005-11-15 01:37:05 +00:00
|
|
|
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
if (has_sha1_file(sha1)) {
|
2006-05-05 09:41:53 +00:00
|
|
|
/* We already have the postimage */
|
2007-02-26 19:55:59 +00:00
|
|
|
enum object_type type;
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
unsigned long size;
|
2007-09-16 16:54:42 +00:00
|
|
|
char *result;
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
|
2007-09-16 16:54:42 +00:00
|
|
|
result = read_sha1_file(sha1, &type, &size);
|
|
|
|
if (!result)
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
return error("the necessary postimage %s for "
|
|
|
|
"'%s' cannot be read",
|
|
|
|
patch->new_sha1_prefix, name);
|
2008-01-27 01:42:49 +00:00
|
|
|
clear_image(img);
|
|
|
|
img->buf = result;
|
|
|
|
img->len = size;
|
2007-09-16 16:54:42 +00:00
|
|
|
} else {
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* We have verified buf matches the preimage;
|
2006-05-05 09:41:53 +00:00
|
|
|
* apply the patch data to it, which is stored
|
|
|
|
* in the patch->fragments->{patch,size}.
|
2005-11-15 01:37:05 +00:00
|
|
|
*/
|
2008-01-27 01:42:49 +00:00
|
|
|
if (apply_binary_fragment(img, patch))
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
return error("binary patch does not apply to '%s'",
|
|
|
|
name);
|
2005-11-15 01:37:05 +00:00
|
|
|
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
/* verify that the result matches */
|
2008-01-27 01:42:49 +00:00
|
|
|
hash_sha1_file(img->buf, img->len, blob_type, sha1);
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
if (strcmp(sha1_to_hex(sha1), patch->new_sha1_prefix))
|
2007-09-16 16:54:42 +00:00
|
|
|
return error("binary patch to '%s' creates incorrect result (expecting %s, got %s)",
|
|
|
|
name, patch->new_sha1_prefix, sha1_to_hex(sha1));
|
2005-11-15 01:37:05 +00:00
|
|
|
}
|
2005-06-05 18:03:13 +00:00
|
|
|
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
static int apply_fragments(struct image *img, struct patch *patch)
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
{
|
|
|
|
struct fragment *frag = patch->fragments;
|
|
|
|
const char *name = patch->old_name ? patch->old_name : patch->new_name;
|
2007-12-06 08:14:14 +00:00
|
|
|
unsigned ws_rule = patch->ws_rule;
|
|
|
|
unsigned inaccurate_eof = patch->inaccurate_eof;
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
|
|
|
|
if (patch->is_binary)
|
2008-01-27 01:42:49 +00:00
|
|
|
return apply_binary(img, patch);
|
binary patch.
This adds "binary patch" to the diff output and teaches apply
what to do with them.
On the diff generation side, traditionally, we said "Binary
files differ\n" without giving anything other than the preimage
and postimage object name on the index line. This was good
enough for applying a patch generated from your own repository
(very useful while rebasing), because the postimage would be
available in such a case. However, this was not useful when the
recipient of such a patch via e-mail were to apply it, even if
the preimage was available.
This patch allows the diff to generate "binary" patch when
operating under --full-index option. The binary patch follows
the usual extended git diff headers, and looks like this:
"GIT binary patch\n"
<length byte><data>"\n"
...
"\n"
Each line is prefixed with a "length-byte", whose value is upper
or lowercase alphabet that encodes number of bytes that the data
on the line decodes to (1..52 -- 'A' means 1, 'B' means 2, ...,
'Z' means 26, 'a' means 27, ...). <data> is 1 or more groups of
5-byte sequence, each of which encodes up to 4 bytes in base85
encoding. Because 52 / 4 * 5 = 65 and we have the length byte,
an output line is capped to 66 characters. The payload is the
same diff-delta as we use in the packfiles.
On the consumption side, git-apply now can decode and apply the
binary patch when --allow-binary-replacement is given, the diff
was generated with --full-index, and the receiving repository
has the preimage blob, which is the same condition as it always
required when accepting an "Binary files differ\n" patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-05-04 23:51:44 +00:00
|
|
|
|
2005-06-05 18:03:13 +00:00
|
|
|
while (frag) {
|
2008-01-27 01:42:49 +00:00
|
|
|
if (apply_one_fragment(img, frag, inaccurate_eof, ws_rule)) {
|
2006-08-17 00:55:29 +00:00
|
|
|
error("patch failed: %s:%ld", name, frag->oldpos);
|
|
|
|
if (!apply_with_reject)
|
|
|
|
return -1;
|
|
|
|
frag->rejected = 1;
|
|
|
|
}
|
2005-06-05 18:03:13 +00:00
|
|
|
frag = frag->next;
|
|
|
|
}
|
2005-06-05 19:43:56 +00:00
|
|
|
return 0;
|
2005-06-05 18:03:13 +00:00
|
|
|
}
|
|
|
|
|
2007-09-16 16:54:42 +00:00
|
|
|
static int read_file_or_gitlink(struct cache_entry *ce, struct strbuf *buf)
|
2007-08-15 17:22:09 +00:00
|
|
|
{
|
|
|
|
if (!ce)
|
|
|
|
return 0;
|
|
|
|
|
2008-01-15 00:03:17 +00:00
|
|
|
if (S_ISGITLINK(ce->ce_mode)) {
|
2007-09-16 16:54:42 +00:00
|
|
|
strbuf_grow(buf, 100);
|
|
|
|
strbuf_addf(buf, "Subproject commit %s\n", sha1_to_hex(ce->sha1));
|
2007-08-15 17:22:09 +00:00
|
|
|
} else {
|
|
|
|
enum object_type type;
|
2007-09-16 16:54:42 +00:00
|
|
|
unsigned long sz;
|
|
|
|
char *result;
|
|
|
|
|
|
|
|
result = read_sha1_file(ce->sha1, &type, &sz);
|
|
|
|
if (!result)
|
2007-08-15 17:22:09 +00:00
|
|
|
return -1;
|
2007-09-16 16:54:42 +00:00
|
|
|
/* XXX read_sha1_file NUL-terminates */
|
|
|
|
strbuf_attach(buf, result, sz, sz + 1);
|
2007-08-15 17:22:09 +00:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-05-15 22:15:47 +00:00
|
|
|
static int apply_data(struct patch *patch, struct stat *st, struct cache_entry *ce)
|
2005-06-05 18:03:13 +00:00
|
|
|
{
|
2007-09-16 16:54:42 +00:00
|
|
|
struct strbuf buf;
|
2008-01-27 01:42:49 +00:00
|
|
|
struct image image;
|
|
|
|
size_t len;
|
|
|
|
char *img;
|
2005-06-05 18:03:13 +00:00
|
|
|
|
2007-09-16 16:54:42 +00:00
|
|
|
strbuf_init(&buf, 0);
|
2006-05-15 22:15:47 +00:00
|
|
|
if (cached) {
|
2007-09-16 16:54:42 +00:00
|
|
|
if (read_file_or_gitlink(ce, &buf))
|
2007-08-15 17:22:09 +00:00
|
|
|
return error("read of %s failed", patch->old_name);
|
|
|
|
} else if (patch->old_name) {
|
|
|
|
if (S_ISGITLINK(patch->old_mode)) {
|
2007-09-16 16:54:42 +00:00
|
|
|
if (ce) {
|
|
|
|
read_file_or_gitlink(ce, &buf);
|
|
|
|
} else {
|
2007-08-15 17:22:09 +00:00
|
|
|
/*
|
|
|
|
* There is no way to apply subproject
|
|
|
|
* patch without looking at the index.
|
|
|
|
*/
|
|
|
|
patch->fragments = NULL;
|
|
|
|
}
|
2007-09-16 16:54:42 +00:00
|
|
|
} else {
|
|
|
|
if (read_old_data(st, patch->old_name, &buf))
|
|
|
|
return error("read of %s failed", patch->old_name);
|
2006-05-15 22:15:47 +00:00
|
|
|
}
|
|
|
|
}
|
2005-06-05 19:16:32 +00:00
|
|
|
|
2008-01-27 01:42:49 +00:00
|
|
|
img = strbuf_detach(&buf, &len);
|
|
|
|
prepare_image(&image, img, len, !patch->is_binary);
|
|
|
|
|
|
|
|
if (apply_fragments(&image, patch) < 0)
|
2006-08-17 00:55:29 +00:00
|
|
|
return -1; /* note with --reject this succeeds. */
|
2008-01-27 01:42:49 +00:00
|
|
|
patch->result = image.buf;
|
|
|
|
patch->resultsize = image.len;
|
|
|
|
free(image.line_allocated);
|
2005-06-05 21:05:43 +00:00
|
|
|
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
if (0 < patch->is_delete && patch->resultsize)
|
2005-06-05 21:05:43 +00:00
|
|
|
return error("removal patch leaves file contents");
|
|
|
|
|
2005-06-05 18:03:13 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
apply: do not get confused by symlinks in the middle
HPA noticed that git-rebase fails when changes involve symlinks
in the middle of the hierarchy. Consider:
* The tree state before the patch is applied has arch/x86_64/boot
as a symlink pointing at ../i386/boot/
* The patch tries to remove arch/x86_64/boot symlink, and
create bunch of files there: .gitignore, Makefile, etc.
git-apply tries to be careful while applying patches; it never
touches the working tree until it is convinced that the patch
would apply cleanly. One of the check it does is that when it
knows a path is going to be created by the patch, it runs
lstat() on the path to make sure it does not exist.
This leads to a false alarm. Because we do not touch the
working tree before all the check passes, when we try to make
sure that arch/x86_64/boot/.gitignore does not exist yet, we
haven't removed the arch/x86_64/boot symlink. The lstat() check
ends up seeing arch/i386/boot/.gitignore through the
yet-to-be-removed symlink, and says "Hey, you already have a
file there, but what you fed me is a patch to create a new
file. I am not going to clobber what you have in the working
tree."
We have similar checks to see a file we are going to modify does
exist and match the preimage of the diff, which is done by
directly opening and reading the file.
For a file we are going to delete, we make sure that it does
exist and matches what is going to be removed (a removal patch
records the full preimage, so we check what you have in your
working tree matches it in full -- otherwise we would risk
losing your local changes), which again is done by directly
opening and reading the file.
These checks need to be adjusted so that they are not fooled by
symlinks in the middle.
- To make sure something does not exist, first lstat(). If it
does not exist, it does not, so be happy. If it _does_, we
might be getting fooled by a symlink in the middle, so break
leading paths and see if there are symlinks involved. When
we are checking for a path a/b/c/d, if any of a, a/b, a/b/c
is a symlink, then a/b/c/d does _NOT_ exist, for the purpose
of our test.
This would fix this particular case you saw, and would not
add extra overhead in the usual case.
- To make sure something already exists, first lstat(). If it
does not exist, barf (up to this, we already do). Even if it
does seem to exist, we might be getting fooled by a symlink
in the middle, so make sure leading paths are not symlinks.
This would make the normal codepath much more expensive for
deep trees, which is a bit worrisome.
This patch implements the first side of the check "making sure
it does not exist". The latter "making sure it exists" check is
not done yet, so applying the patch in reverse would still
fail, but we have to start from somewhere.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-05-12 05:26:08 +00:00
|
|
|
static int check_to_create_blob(const char *new_name, int ok_if_exists)
|
|
|
|
{
|
|
|
|
struct stat nst;
|
|
|
|
if (!lstat(new_name, &nst)) {
|
|
|
|
if (S_ISDIR(nst.st_mode) || ok_if_exists)
|
|
|
|
return 0;
|
|
|
|
/*
|
|
|
|
* A leading component of new_name might be a symlink
|
|
|
|
* that is going to be removed with this patch, but
|
|
|
|
* still pointing at somewhere that has the path.
|
|
|
|
* In such a case, path "new_name" does not exist as
|
|
|
|
* far as git is concerned.
|
|
|
|
*/
|
Optimize symlink/directory detection
This is the base for making symlink detection in the middle fo a pathname
saner and (much) more efficient.
Under various loads, we want to verify that the full path leading up to a
filename is a real directory tree, and that when we successfully do an
'lstat()' on a filename, we don't get a false positive due to a symlink in
the middle of the path that git should have seen as a symlink, not as a
normal path component.
The 'has_symlink_leading_path()' function already did this, and cached
a single level of symlink information, but didn't cache the _lack_ of a
symlink, so the normal behaviour was actually the wrong way around, and we
ended up doing an 'lstat()' on each path component to check that it was a
real directory.
This caches the last detected full directory and symlink entries, and
speeds up especially deep directory structures a lot by avoiding to
lstat() all the directories leading up to each entry in the index.
[ This can - and should - probably be extended upon so that we eventually
never do a bare 'lstat()' on any path entries at *all* when checking the
index, but always check the full path carefully. Right now we do not
generally check the whole path for all our normal quick index
revalidation.
We should also make sure that we're careful about all the invalidation,
ie when we remove a link and replace it by a directory we should
invalidate the symlink cache if it matches (and vice versa for the
directory cache).
But regardless, the basic function needs to be sane to do that. The old
'has_symlink_leading_path()' was not capable enough - or indeed the code
readable enough - to really do that sanely. So I'm pushing this as not
just an optimization, but as a base for further work. ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2008-05-09 16:21:07 +00:00
|
|
|
if (has_symlink_leading_path(strlen(new_name), new_name))
|
apply: do not get confused by symlinks in the middle
HPA noticed that git-rebase fails when changes involve symlinks
in the middle of the hierarchy. Consider:
* The tree state before the patch is applied has arch/x86_64/boot
as a symlink pointing at ../i386/boot/
* The patch tries to remove arch/x86_64/boot symlink, and
create bunch of files there: .gitignore, Makefile, etc.
git-apply tries to be careful while applying patches; it never
touches the working tree until it is convinced that the patch
would apply cleanly. One of the check it does is that when it
knows a path is going to be created by the patch, it runs
lstat() on the path to make sure it does not exist.
This leads to a false alarm. Because we do not touch the
working tree before all the check passes, when we try to make
sure that arch/x86_64/boot/.gitignore does not exist yet, we
haven't removed the arch/x86_64/boot symlink. The lstat() check
ends up seeing arch/i386/boot/.gitignore through the
yet-to-be-removed symlink, and says "Hey, you already have a
file there, but what you fed me is a patch to create a new
file. I am not going to clobber what you have in the working
tree."
We have similar checks to see a file we are going to modify does
exist and match the preimage of the diff, which is done by
directly opening and reading the file.
For a file we are going to delete, we make sure that it does
exist and matches what is going to be removed (a removal patch
records the full preimage, so we check what you have in your
working tree matches it in full -- otherwise we would risk
losing your local changes), which again is done by directly
opening and reading the file.
These checks need to be adjusted so that they are not fooled by
symlinks in the middle.
- To make sure something does not exist, first lstat(). If it
does not exist, it does not, so be happy. If it _does_, we
might be getting fooled by a symlink in the middle, so break
leading paths and see if there are symlinks involved. When
we are checking for a path a/b/c/d, if any of a, a/b, a/b/c
is a symlink, then a/b/c/d does _NOT_ exist, for the purpose
of our test.
This would fix this particular case you saw, and would not
add extra overhead in the usual case.
- To make sure something already exists, first lstat(). If it
does not exist, barf (up to this, we already do). Even if it
does seem to exist, we might be getting fooled by a symlink
in the middle, so make sure leading paths are not symlinks.
This would make the normal codepath much more expensive for
deep trees, which is a bit worrisome.
This patch implements the first side of the check "making sure
it does not exist". The latter "making sure it exists" check is
not done yet, so applying the patch in reverse would still
fail, but we have to start from somewhere.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-05-12 05:26:08 +00:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
return error("%s: already exists in working directory", new_name);
|
|
|
|
}
|
|
|
|
else if ((errno != ENOENT) && (errno != ENOTDIR))
|
|
|
|
return error("%s: %s", new_name, strerror(errno));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-08-15 17:22:09 +00:00
|
|
|
static int verify_index_match(struct cache_entry *ce, struct stat *st)
|
|
|
|
{
|
2008-01-15 00:03:17 +00:00
|
|
|
if (S_ISGITLINK(ce->ce_mode)) {
|
2007-08-15 17:22:09 +00:00
|
|
|
if (!S_ISDIR(st->st_mode))
|
|
|
|
return -1;
|
|
|
|
return 0;
|
|
|
|
}
|
2007-11-10 08:15:03 +00:00
|
|
|
return ce_match_stat(ce, st, CE_MATCH_IGNORE_VALID);
|
2007-08-15 17:22:09 +00:00
|
|
|
}
|
|
|
|
|
2006-07-17 07:10:47 +00:00
|
|
|
static int check_patch(struct patch *patch, struct patch *prev_patch)
|
2005-05-26 19:25:52 +00:00
|
|
|
{
|
2005-05-26 22:10:02 +00:00
|
|
|
struct stat st;
|
2005-05-26 19:25:52 +00:00
|
|
|
const char *old_name = patch->old_name;
|
|
|
|
const char *new_name = patch->new_name;
|
2005-11-15 01:37:05 +00:00
|
|
|
const char *name = old_name ? old_name : new_name;
|
2006-05-15 22:15:47 +00:00
|
|
|
struct cache_entry *ce = NULL;
|
2006-07-17 07:10:47 +00:00
|
|
|
int ok_if_exists;
|
2005-05-26 19:25:52 +00:00
|
|
|
|
2006-08-17 00:55:29 +00:00
|
|
|
patch->rejected = 1; /* we will drop this after we succeed */
|
2007-08-15 17:22:09 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Make sure that we do not have local modifications from the
|
|
|
|
* index when we are looking at the index. Also make sure
|
|
|
|
* we have the preimage file to be patched in the work tree,
|
|
|
|
* unless --cached, which tells git to apply only in the index.
|
|
|
|
*/
|
2005-05-26 19:25:52 +00:00
|
|
|
if (old_name) {
|
2006-05-15 22:15:47 +00:00
|
|
|
int stat_ret = 0;
|
|
|
|
unsigned st_mode = 0;
|
2005-05-26 22:10:02 +00:00
|
|
|
|
2006-05-15 22:15:47 +00:00
|
|
|
if (!cached)
|
|
|
|
stat_ret = lstat(old_name, &st);
|
2005-06-05 18:03:13 +00:00
|
|
|
if (check_index) {
|
|
|
|
int pos = cache_name_pos(old_name, strlen(old_name));
|
|
|
|
if (pos < 0)
|
2005-10-03 20:16:39 +00:00
|
|
|
return error("%s: does not exist in index",
|
|
|
|
old_name);
|
2006-05-15 22:15:47 +00:00
|
|
|
ce = active_cache[pos];
|
2005-10-03 20:16:39 +00:00
|
|
|
if (stat_ret < 0) {
|
|
|
|
struct checkout costate;
|
|
|
|
if (errno != ENOENT)
|
|
|
|
return error("%s: %s", old_name,
|
|
|
|
strerror(errno));
|
|
|
|
/* checkout */
|
|
|
|
costate.base_dir = "";
|
|
|
|
costate.base_dir_len = 0;
|
|
|
|
costate.force = 0;
|
|
|
|
costate.quiet = 0;
|
|
|
|
costate.not_new = 0;
|
|
|
|
costate.refresh_cache = 1;
|
2006-05-15 22:15:47 +00:00
|
|
|
if (checkout_entry(ce,
|
2006-03-05 08:24:15 +00:00
|
|
|
&costate,
|
|
|
|
NULL) ||
|
2005-10-03 20:16:39 +00:00
|
|
|
lstat(old_name, &st))
|
|
|
|
return -1;
|
|
|
|
}
|
2007-08-15 17:22:09 +00:00
|
|
|
if (!cached && verify_index_match(ce, &st))
|
2005-10-03 20:16:39 +00:00
|
|
|
return error("%s: does not match index",
|
|
|
|
old_name);
|
2006-05-15 22:15:47 +00:00
|
|
|
if (cached)
|
2008-01-15 00:03:17 +00:00
|
|
|
st_mode = ce->ce_mode;
|
2007-08-15 17:22:09 +00:00
|
|
|
} else if (stat_ret < 0)
|
2005-10-03 20:16:39 +00:00
|
|
|
return error("%s: %s", old_name, strerror(errno));
|
|
|
|
|
2006-05-15 22:15:47 +00:00
|
|
|
if (!cached)
|
2008-01-15 00:03:17 +00:00
|
|
|
st_mode = ce_mode_from_stat(ce, st.st_mode);
|
2006-05-15 22:15:47 +00:00
|
|
|
|
2005-06-05 18:03:13 +00:00
|
|
|
if (patch->is_new < 0)
|
|
|
|
patch->is_new = 0;
|
2005-05-26 22:10:02 +00:00
|
|
|
if (!patch->old_mode)
|
2006-05-15 22:15:47 +00:00
|
|
|
patch->old_mode = st_mode;
|
|
|
|
if ((st_mode ^ patch->old_mode) & S_IFMT)
|
2005-06-05 18:03:13 +00:00
|
|
|
return error("%s: wrong type", old_name);
|
2006-05-15 22:15:47 +00:00
|
|
|
if (st_mode != patch->old_mode)
|
2005-06-05 18:03:13 +00:00
|
|
|
fprintf(stderr, "warning: %s has type %o, expected %o\n",
|
2006-05-15 22:15:47 +00:00
|
|
|
old_name, st_mode, patch->old_mode);
|
2005-05-26 19:25:52 +00:00
|
|
|
}
|
2005-05-26 22:10:02 +00:00
|
|
|
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
if (new_name && prev_patch && 0 < prev_patch->is_delete &&
|
2006-07-17 07:10:47 +00:00
|
|
|
!strcmp(prev_patch->old_name, new_name))
|
2007-11-23 10:37:03 +00:00
|
|
|
/*
|
|
|
|
* A type-change diff is always split into a patch to
|
2006-07-17 07:10:47 +00:00
|
|
|
* delete old, immediately followed by a patch to
|
|
|
|
* create new (see diff.c::run_diff()); in such a case
|
|
|
|
* it is Ok that the entry to be deleted by the
|
|
|
|
* previous patch is still in the working tree and in
|
|
|
|
* the index.
|
|
|
|
*/
|
|
|
|
ok_if_exists = 1;
|
|
|
|
else
|
|
|
|
ok_if_exists = 0;
|
|
|
|
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
if (new_name &&
|
|
|
|
((0 < patch->is_new) | (0 < patch->is_rename) | patch->is_copy)) {
|
2006-07-17 07:10:47 +00:00
|
|
|
if (check_index &&
|
|
|
|
cache_name_pos(new_name, strlen(new_name)) >= 0 &&
|
|
|
|
!ok_if_exists)
|
2005-05-26 22:10:02 +00:00
|
|
|
return error("%s: already exists in index", new_name);
|
2006-05-17 23:56:13 +00:00
|
|
|
if (!cached) {
|
apply: do not get confused by symlinks in the middle
HPA noticed that git-rebase fails when changes involve symlinks
in the middle of the hierarchy. Consider:
* The tree state before the patch is applied has arch/x86_64/boot
as a symlink pointing at ../i386/boot/
* The patch tries to remove arch/x86_64/boot symlink, and
create bunch of files there: .gitignore, Makefile, etc.
git-apply tries to be careful while applying patches; it never
touches the working tree until it is convinced that the patch
would apply cleanly. One of the check it does is that when it
knows a path is going to be created by the patch, it runs
lstat() on the path to make sure it does not exist.
This leads to a false alarm. Because we do not touch the
working tree before all the check passes, when we try to make
sure that arch/x86_64/boot/.gitignore does not exist yet, we
haven't removed the arch/x86_64/boot symlink. The lstat() check
ends up seeing arch/i386/boot/.gitignore through the
yet-to-be-removed symlink, and says "Hey, you already have a
file there, but what you fed me is a patch to create a new
file. I am not going to clobber what you have in the working
tree."
We have similar checks to see a file we are going to modify does
exist and match the preimage of the diff, which is done by
directly opening and reading the file.
For a file we are going to delete, we make sure that it does
exist and matches what is going to be removed (a removal patch
records the full preimage, so we check what you have in your
working tree matches it in full -- otherwise we would risk
losing your local changes), which again is done by directly
opening and reading the file.
These checks need to be adjusted so that they are not fooled by
symlinks in the middle.
- To make sure something does not exist, first lstat(). If it
does not exist, it does not, so be happy. If it _does_, we
might be getting fooled by a symlink in the middle, so break
leading paths and see if there are symlinks involved. When
we are checking for a path a/b/c/d, if any of a, a/b, a/b/c
is a symlink, then a/b/c/d does _NOT_ exist, for the purpose
of our test.
This would fix this particular case you saw, and would not
add extra overhead in the usual case.
- To make sure something already exists, first lstat(). If it
does not exist, barf (up to this, we already do). Even if it
does seem to exist, we might be getting fooled by a symlink
in the middle, so make sure leading paths are not symlinks.
This would make the normal codepath much more expensive for
deep trees, which is a bit worrisome.
This patch implements the first side of the check "making sure
it does not exist". The latter "making sure it exists" check is
not done yet, so applying the patch in reverse would still
fail, but we have to start from somewhere.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-05-12 05:26:08 +00:00
|
|
|
int err = check_to_create_blob(new_name, ok_if_exists);
|
|
|
|
if (err)
|
|
|
|
return err;
|
2006-05-17 23:56:13 +00:00
|
|
|
}
|
2005-08-17 07:01:07 +00:00
|
|
|
if (!patch->new_mode) {
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
if (0 < patch->is_new)
|
2005-08-17 07:01:07 +00:00
|
|
|
patch->new_mode = S_IFREG | 0644;
|
|
|
|
else
|
|
|
|
patch->new_mode = patch->old_mode;
|
|
|
|
}
|
2005-05-26 19:25:52 +00:00
|
|
|
}
|
2005-06-05 18:03:13 +00:00
|
|
|
|
|
|
|
if (new_name && old_name) {
|
|
|
|
int same = !strcmp(old_name, new_name);
|
|
|
|
if (!patch->new_mode)
|
|
|
|
patch->new_mode = patch->old_mode;
|
|
|
|
if ((patch->old_mode ^ patch->new_mode) & S_IFMT)
|
|
|
|
return error("new mode (%o) of %s does not match old mode (%o)%s%s",
|
|
|
|
patch->new_mode, new_name, patch->old_mode,
|
|
|
|
same ? "" : " of ", same ? "" : old_name);
|
2006-05-15 22:15:47 +00:00
|
|
|
}
|
2005-06-05 18:03:13 +00:00
|
|
|
|
2006-05-15 22:15:47 +00:00
|
|
|
if (apply_data(patch, &st, ce) < 0)
|
2005-11-15 01:37:05 +00:00
|
|
|
return error("%s: patch does not apply", name);
|
2006-08-17 00:55:29 +00:00
|
|
|
patch->rejected = 0;
|
2005-05-26 22:10:02 +00:00
|
|
|
return 0;
|
2005-05-26 19:25:52 +00:00
|
|
|
}
|
|
|
|
|
2005-05-26 22:10:02 +00:00
|
|
|
static int check_patch_list(struct patch *patch)
|
2005-05-26 17:23:51 +00:00
|
|
|
{
|
2006-07-17 07:10:47 +00:00
|
|
|
struct patch *prev_patch = NULL;
|
2006-08-23 10:39:10 +00:00
|
|
|
int err = 0;
|
2005-05-26 22:10:02 +00:00
|
|
|
|
2006-07-17 07:10:47 +00:00
|
|
|
for (prev_patch = NULL; patch ; patch = patch->next) {
|
2006-08-18 10:14:48 +00:00
|
|
|
if (apply_verbosely)
|
|
|
|
say_patch_name(stderr,
|
|
|
|
"Checking patch ", patch, "...\n");
|
2006-08-23 10:39:10 +00:00
|
|
|
err |= check_patch(patch, prev_patch);
|
2006-07-17 07:10:47 +00:00
|
|
|
prev_patch = patch;
|
|
|
|
}
|
2006-08-23 10:39:10 +00:00
|
|
|
return err;
|
2005-05-26 22:10:02 +00:00
|
|
|
}
|
|
|
|
|
2007-09-17 00:24:57 +00:00
|
|
|
/* This function tries to read the sha1 from the current index */
|
|
|
|
static int get_current_sha1(const char *path, unsigned char *sha1)
|
|
|
|
{
|
|
|
|
int pos;
|
|
|
|
|
|
|
|
if (read_cache() < 0)
|
|
|
|
return -1;
|
|
|
|
pos = cache_name_pos(path, strlen(path));
|
|
|
|
if (pos < 0)
|
|
|
|
return -1;
|
|
|
|
hashcpy(sha1, active_cache[pos]->sha1);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-09-17 22:34:06 +00:00
|
|
|
/* Build an index that contains the just the files needed for a 3way merge */
|
|
|
|
static void build_fake_ancestor(struct patch *list, const char *filename)
|
2005-10-07 10:42:00 +00:00
|
|
|
{
|
|
|
|
struct patch *patch;
|
2007-09-17 22:34:06 +00:00
|
|
|
struct index_state result = { 0 };
|
|
|
|
int fd;
|
2005-10-07 10:42:00 +00:00
|
|
|
|
|
|
|
/* Once we start supporting the reverse patch, it may be
|
|
|
|
* worth showing the new sha1 prefix, but until then...
|
|
|
|
*/
|
|
|
|
for (patch = list; patch; patch = patch->next) {
|
|
|
|
const unsigned char *sha1_ptr;
|
|
|
|
unsigned char sha1[20];
|
2007-09-17 22:34:06 +00:00
|
|
|
struct cache_entry *ce;
|
2005-10-07 10:42:00 +00:00
|
|
|
const char *name;
|
|
|
|
|
|
|
|
name = patch->old_name ? patch->old_name : patch->new_name;
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
if (0 < patch->is_new)
|
2007-09-17 22:34:06 +00:00
|
|
|
continue;
|
2005-10-07 10:42:00 +00:00
|
|
|
else if (get_sha1(patch->old_sha1_prefix, sha1))
|
2007-09-17 00:24:57 +00:00
|
|
|
/* git diff has no index line for mode/type changes */
|
|
|
|
if (!patch->lines_added && !patch->lines_deleted) {
|
|
|
|
if (get_current_sha1(patch->new_name, sha1) ||
|
|
|
|
get_current_sha1(patch->old_name, sha1))
|
|
|
|
die("mode change for %s, which is not "
|
|
|
|
"in current HEAD", name);
|
|
|
|
sha1_ptr = sha1;
|
|
|
|
} else
|
|
|
|
die("sha1 information is lacking or useless "
|
|
|
|
"(%s).", name);
|
2005-10-07 10:42:00 +00:00
|
|
|
else
|
|
|
|
sha1_ptr = sha1;
|
2005-10-15 04:54:52 +00:00
|
|
|
|
2007-09-17 22:34:06 +00:00
|
|
|
ce = make_cache_entry(patch->old_mode, sha1_ptr, name, 0, 0);
|
|
|
|
if (add_index_entry(&result, ce, ADD_CACHE_OK_TO_ADD))
|
|
|
|
die ("Could not add %s to temporary index", name);
|
2005-10-07 10:42:00 +00:00
|
|
|
}
|
2007-09-17 22:34:06 +00:00
|
|
|
|
|
|
|
fd = open(filename, O_WRONLY | O_CREAT, 0666);
|
|
|
|
if (fd < 0 || write_index(&result, fd) || close(fd))
|
|
|
|
die ("Could not write temporary index to %s", filename);
|
|
|
|
|
|
|
|
discard_index(&result);
|
2005-10-07 10:42:00 +00:00
|
|
|
}
|
|
|
|
|
2005-05-26 22:10:02 +00:00
|
|
|
static void stat_patch_list(struct patch *patch)
|
|
|
|
{
|
|
|
|
int files, adds, dels;
|
|
|
|
|
|
|
|
for (files = adds = dels = 0 ; patch ; patch = patch->next) {
|
|
|
|
files++;
|
|
|
|
adds += patch->lines_added;
|
|
|
|
dels += patch->lines_deleted;
|
|
|
|
show_stats(patch);
|
|
|
|
}
|
|
|
|
|
|
|
|
printf(" %d files changed, %d insertions(+), %d deletions(-)\n", files, adds, dels);
|
2005-05-26 18:40:43 +00:00
|
|
|
}
|
|
|
|
|
2005-10-28 09:43:31 +00:00
|
|
|
static void numstat_patch_list(struct patch *patch)
|
|
|
|
{
|
|
|
|
for ( ; patch; patch = patch->next) {
|
|
|
|
const char *name;
|
2006-05-15 04:59:04 +00:00
|
|
|
name = patch->new_name ? patch->new_name : patch->old_name;
|
2006-11-15 06:23:18 +00:00
|
|
|
if (patch->is_binary)
|
|
|
|
printf("-\t-\t");
|
|
|
|
else
|
Full rework of quote_c_style and write_name_quoted.
* quote_c_style works on a strbuf instead of a wild buffer.
* quote_c_style is now clever enough to not add double quotes if not needed.
* write_name_quoted inherits those advantages, but also take a different
set of arguments. Now instead of asking for quotes or not, you pass a
"terminator". If it's \0 then we assume you don't want to escape, else C
escaping is performed. In any case, the terminator is also appended to the
stream. It also no longer takes the prefix/prefix_len arguments, as it's
seldomly used, and makes some optimizations harder.
* write_name_quotedpfx is created to work like write_name_quoted and take
the prefix/prefix_len arguments.
Thanks to those API changes, diff.c has somehow lost weight, thanks to the
removal of functions that were wrappers around the old write_name_quoted
trying to give it a semantics like the new one, but performing a lot of
allocations for this goal. Now we always write directly to the stream, no
intermediate allocation is performed.
As a side effect of the refactor in builtin-apply.c, the length of the bar
graphs in diffstats are not affected anymore by the fact that the path was
clipped.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
2007-09-19 22:42:15 +00:00
|
|
|
printf("%d\t%d\t", patch->lines_added, patch->lines_deleted);
|
|
|
|
write_name_quoted(name, stdout, line_termination);
|
2005-10-28 09:43:31 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-06-22 09:29:46 +00:00
|
|
|
static void show_file_mode_name(const char *newdelete, unsigned int mode, const char *name)
|
|
|
|
{
|
|
|
|
if (mode)
|
|
|
|
printf(" %s mode %06o %s\n", newdelete, mode, name);
|
|
|
|
else
|
|
|
|
printf(" %s %s\n", newdelete, name);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void show_mode_change(struct patch *p, int show_name)
|
|
|
|
{
|
|
|
|
if (p->old_mode && p->new_mode && p->old_mode != p->new_mode) {
|
|
|
|
if (show_name)
|
|
|
|
printf(" mode change %06o => %06o %s\n",
|
|
|
|
p->old_mode, p->new_mode, p->new_name);
|
|
|
|
else
|
|
|
|
printf(" mode change %06o => %06o\n",
|
|
|
|
p->old_mode, p->new_mode);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void show_rename_copy(struct patch *p)
|
|
|
|
{
|
|
|
|
const char *renamecopy = p->is_rename ? "rename" : "copy";
|
|
|
|
const char *old, *new;
|
|
|
|
|
|
|
|
/* Find common prefix */
|
|
|
|
old = p->old_name;
|
|
|
|
new = p->new_name;
|
|
|
|
while (1) {
|
|
|
|
const char *slash_old, *slash_new;
|
|
|
|
slash_old = strchr(old, '/');
|
|
|
|
slash_new = strchr(new, '/');
|
|
|
|
if (!slash_old ||
|
|
|
|
!slash_new ||
|
|
|
|
slash_old - old != slash_new - new ||
|
|
|
|
memcmp(old, new, slash_new - new))
|
|
|
|
break;
|
|
|
|
old = slash_old + 1;
|
|
|
|
new = slash_new + 1;
|
|
|
|
}
|
|
|
|
/* p->old_name thru old is the common prefix, and old and new
|
|
|
|
* through the end of names are renames
|
|
|
|
*/
|
|
|
|
if (old != p->old_name)
|
|
|
|
printf(" %s %.*s{%s => %s} (%d%%)\n", renamecopy,
|
2005-07-12 18:54:21 +00:00
|
|
|
(int)(old - p->old_name), p->old_name,
|
2005-06-22 09:29:46 +00:00
|
|
|
old, new, p->score);
|
|
|
|
else
|
|
|
|
printf(" %s %s => %s (%d%%)\n", renamecopy,
|
|
|
|
p->old_name, p->new_name, p->score);
|
|
|
|
show_mode_change(p, 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void summary_patch_list(struct patch *patch)
|
|
|
|
{
|
|
|
|
struct patch *p;
|
|
|
|
|
|
|
|
for (p = patch; p; p = p->next) {
|
|
|
|
if (p->is_new)
|
|
|
|
show_file_mode_name("create", p->new_mode, p->new_name);
|
|
|
|
else if (p->is_delete)
|
|
|
|
show_file_mode_name("delete", p->old_mode, p->old_name);
|
|
|
|
else {
|
|
|
|
if (p->is_rename || p->is_copy)
|
|
|
|
show_rename_copy(p);
|
|
|
|
else {
|
|
|
|
if (p->score) {
|
|
|
|
printf(" rewrite %s (%d%%)\n",
|
|
|
|
p->new_name, p->score);
|
|
|
|
show_mode_change(p, 0);
|
|
|
|
}
|
|
|
|
else
|
|
|
|
show_mode_change(p, 1);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-05-26 18:40:43 +00:00
|
|
|
static void patch_stats(struct patch *patch)
|
|
|
|
{
|
|
|
|
int lines = patch->lines_added + patch->lines_deleted;
|
|
|
|
|
|
|
|
if (lines > max_change)
|
|
|
|
max_change = lines;
|
|
|
|
if (patch->old_name) {
|
2005-10-15 04:54:52 +00:00
|
|
|
int len = quote_c_style(patch->old_name, NULL, NULL, 0);
|
|
|
|
if (!len)
|
|
|
|
len = strlen(patch->old_name);
|
2005-05-26 18:40:43 +00:00
|
|
|
if (len > max_len)
|
|
|
|
max_len = len;
|
|
|
|
}
|
|
|
|
if (patch->new_name) {
|
2005-10-15 04:54:52 +00:00
|
|
|
int len = quote_c_style(patch->new_name, NULL, NULL, 0);
|
|
|
|
if (!len)
|
|
|
|
len = strlen(patch->new_name);
|
2005-05-26 18:40:43 +00:00
|
|
|
if (len > max_len)
|
|
|
|
max_len = len;
|
|
|
|
}
|
2005-05-26 17:23:51 +00:00
|
|
|
}
|
|
|
|
|
2007-02-20 01:58:58 +00:00
|
|
|
static void remove_file(struct patch *patch, int rmdir_empty)
|
2005-06-05 21:05:43 +00:00
|
|
|
{
|
2007-04-02 05:46:06 +00:00
|
|
|
if (update_index) {
|
2005-06-05 21:05:43 +00:00
|
|
|
if (remove_file_from_cache(patch->old_name) < 0)
|
|
|
|
die("unable to remove %s from index", patch->old_name);
|
|
|
|
}
|
2007-01-09 20:25:46 +00:00
|
|
|
if (!cached) {
|
2007-08-15 17:22:09 +00:00
|
|
|
if (S_ISGITLINK(patch->old_mode)) {
|
|
|
|
if (rmdir(patch->old_name))
|
|
|
|
warning("unable to remove submodule %s",
|
|
|
|
patch->old_name);
|
|
|
|
} else if (!unlink(patch->old_name) && rmdir_empty) {
|
2007-01-09 20:25:46 +00:00
|
|
|
char *name = xstrdup(patch->old_name);
|
|
|
|
char *end = strrchr(name, '/');
|
|
|
|
while (end) {
|
|
|
|
*end = 0;
|
|
|
|
if (rmdir(name))
|
|
|
|
break;
|
|
|
|
end = strrchr(name, '/');
|
|
|
|
}
|
|
|
|
free(name);
|
|
|
|
}
|
|
|
|
}
|
2005-06-05 21:05:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void add_index_file(const char *path, unsigned mode, void *buf, unsigned long size)
|
|
|
|
{
|
|
|
|
struct stat st;
|
|
|
|
struct cache_entry *ce;
|
|
|
|
int namelen = strlen(path);
|
|
|
|
unsigned ce_size = cache_entry_size(namelen);
|
|
|
|
|
2007-04-02 05:46:06 +00:00
|
|
|
if (!update_index)
|
2005-06-05 21:05:43 +00:00
|
|
|
return;
|
|
|
|
|
2006-04-03 18:30:46 +00:00
|
|
|
ce = xcalloc(1, ce_size);
|
2005-06-05 21:05:43 +00:00
|
|
|
memcpy(ce->name, path, namelen);
|
|
|
|
ce->ce_mode = create_ce_mode(mode);
|
2008-01-15 00:03:17 +00:00
|
|
|
ce->ce_flags = namelen;
|
2007-08-15 17:22:09 +00:00
|
|
|
if (S_ISGITLINK(mode)) {
|
|
|
|
const char *s = buf;
|
|
|
|
|
|
|
|
if (get_sha1_hex(s + strlen("Subproject commit "), ce->sha1))
|
|
|
|
die("corrupt patch for subproject %s", path);
|
|
|
|
} else {
|
|
|
|
if (!cached) {
|
|
|
|
if (lstat(path, &st) < 0)
|
|
|
|
die("unable to stat newly created file %s",
|
|
|
|
path);
|
|
|
|
fill_stat_cache_info(ce, &st);
|
|
|
|
}
|
|
|
|
if (write_sha1_file(buf, size, blob_type, ce->sha1) < 0)
|
|
|
|
die("unable to create backing store for newly created file %s", path);
|
2006-05-15 22:15:47 +00:00
|
|
|
}
|
2005-06-05 21:05:43 +00:00
|
|
|
if (add_cache_entry(ce, ADD_CACHE_OK_TO_ADD) < 0)
|
|
|
|
die("unable to add cache entry for %s", path);
|
|
|
|
}
|
|
|
|
|
2005-07-14 00:25:53 +00:00
|
|
|
static int try_create_file(const char *path, unsigned int mode, const char *buf, unsigned long size)
|
|
|
|
{
|
2007-04-19 00:05:03 +00:00
|
|
|
int fd;
|
Rewrite convert_to_{git,working_tree} to use strbuf's.
* Now, those functions take an "out" strbuf argument, where they store their
result if any. In that case, it also returns 1, else it returns 0.
* those functions support "in place" editing, in the sense that it's OK to
call them this way:
convert_to_git(path, sb->buf, sb->len, sb);
When doable, conversions are done in place for real, else the strbuf
content is just replaced with the new one, transparentely for the caller.
If you want to create a new filter working this way, being the accumulation
of filter1, filter2, ... filtern, then your meta_filter would be:
int meta_filter(..., const char *src, size_t len, struct strbuf *sb)
{
int ret = 0;
ret |= filter1(...., src, len, sb);
if (ret) {
src = sb->buf;
len = sb->len;
}
ret |= filter2(...., src, len, sb);
if (ret) {
src = sb->buf;
len = sb->len;
}
....
return ret | filtern(..., src, len, sb);
}
That's why subfilters the convert_to_* functions called were also rewritten
to work this way.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2007-09-16 13:51:04 +00:00
|
|
|
struct strbuf nbuf;
|
2005-07-14 00:25:53 +00:00
|
|
|
|
2007-08-15 17:22:09 +00:00
|
|
|
if (S_ISGITLINK(mode)) {
|
|
|
|
struct stat st;
|
|
|
|
if (!lstat(path, &st) && S_ISDIR(st.st_mode))
|
|
|
|
return 0;
|
|
|
|
return mkdir(path, 0777);
|
|
|
|
}
|
|
|
|
|
2007-03-02 21:11:30 +00:00
|
|
|
if (has_symlinks && S_ISLNK(mode))
|
2006-08-10 05:47:25 +00:00
|
|
|
/* Although buf:size is counted string, it also is NUL
|
|
|
|
* terminated.
|
|
|
|
*/
|
2005-07-14 00:25:53 +00:00
|
|
|
return symlink(buf, path);
|
2007-03-23 00:32:51 +00:00
|
|
|
|
|
|
|
fd = open(path, O_CREAT | O_EXCL | O_WRONLY, (mode & 0100) ? 0777 : 0666);
|
|
|
|
if (fd < 0)
|
|
|
|
return -1;
|
|
|
|
|
Rewrite convert_to_{git,working_tree} to use strbuf's.
* Now, those functions take an "out" strbuf argument, where they store their
result if any. In that case, it also returns 1, else it returns 0.
* those functions support "in place" editing, in the sense that it's OK to
call them this way:
convert_to_git(path, sb->buf, sb->len, sb);
When doable, conversions are done in place for real, else the strbuf
content is just replaced with the new one, transparentely for the caller.
If you want to create a new filter working this way, being the accumulation
of filter1, filter2, ... filtern, then your meta_filter would be:
int meta_filter(..., const char *src, size_t len, struct strbuf *sb)
{
int ret = 0;
ret |= filter1(...., src, len, sb);
if (ret) {
src = sb->buf;
len = sb->len;
}
ret |= filter2(...., src, len, sb);
if (ret) {
src = sb->buf;
len = sb->len;
}
....
return ret | filtern(..., src, len, sb);
}
That's why subfilters the convert_to_* functions called were also rewritten
to work this way.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2007-09-16 13:51:04 +00:00
|
|
|
strbuf_init(&nbuf, 0);
|
|
|
|
if (convert_to_working_tree(path, buf, size, &nbuf)) {
|
|
|
|
size = nbuf.len;
|
|
|
|
buf = nbuf.buf;
|
2005-07-14 00:25:53 +00:00
|
|
|
}
|
2007-09-16 16:54:42 +00:00
|
|
|
write_or_die(fd, buf, size);
|
|
|
|
strbuf_release(&nbuf);
|
2007-04-19 00:05:03 +00:00
|
|
|
|
2005-07-14 00:25:53 +00:00
|
|
|
if (close(fd) < 0)
|
|
|
|
die("closing file %s: %s", path, strerror(errno));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-06-22 02:10:21 +00:00
|
|
|
/*
|
|
|
|
* We optimistically assume that the directories exist,
|
|
|
|
* which is true 99% of the time anyway. If they don't,
|
|
|
|
* we create them and try again.
|
|
|
|
*/
|
2006-02-04 06:50:57 +00:00
|
|
|
static void create_one_file(char *path, unsigned mode, const char *buf, unsigned long size)
|
2005-06-22 02:10:21 +00:00
|
|
|
{
|
2006-05-15 22:15:47 +00:00
|
|
|
if (cached)
|
|
|
|
return;
|
2005-07-14 00:25:53 +00:00
|
|
|
if (!try_create_file(path, mode, buf, size))
|
|
|
|
return;
|
2005-06-22 02:10:21 +00:00
|
|
|
|
2005-07-14 00:25:53 +00:00
|
|
|
if (errno == ENOENT) {
|
2006-02-04 06:50:57 +00:00
|
|
|
if (safe_create_leading_directories(path))
|
|
|
|
return;
|
2005-07-14 00:25:53 +00:00
|
|
|
if (!try_create_file(path, mode, buf, size))
|
|
|
|
return;
|
2005-06-22 02:10:21 +00:00
|
|
|
}
|
|
|
|
|
2006-07-18 17:46:34 +00:00
|
|
|
if (errno == EEXIST || errno == EACCES) {
|
2006-07-17 06:28:23 +00:00
|
|
|
/* We may be trying to create a file where a directory
|
|
|
|
* used to be.
|
|
|
|
*/
|
|
|
|
struct stat st;
|
2007-04-18 21:58:56 +00:00
|
|
|
if (!lstat(path, &st) && (!S_ISDIR(st.st_mode) || !rmdir(path)))
|
2006-07-17 06:28:23 +00:00
|
|
|
errno = EEXIST;
|
|
|
|
}
|
|
|
|
|
2005-07-14 00:25:53 +00:00
|
|
|
if (errno == EEXIST) {
|
|
|
|
unsigned int nr = getpid();
|
2005-06-22 02:10:21 +00:00
|
|
|
|
2005-07-14 00:25:53 +00:00
|
|
|
for (;;) {
|
|
|
|
const char *newpath;
|
|
|
|
newpath = mkpath("%s~%u", path, nr);
|
|
|
|
if (!try_create_file(newpath, mode, buf, size)) {
|
|
|
|
if (!rename(newpath, path))
|
|
|
|
return;
|
|
|
|
unlink(newpath);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (errno != EEXIST)
|
|
|
|
break;
|
2006-01-05 09:00:12 +00:00
|
|
|
++nr;
|
|
|
|
}
|
2005-06-22 02:10:21 +00:00
|
|
|
}
|
2005-07-14 00:25:53 +00:00
|
|
|
die("unable to write file %s mode %o", path, mode);
|
2005-06-22 02:10:21 +00:00
|
|
|
}
|
|
|
|
|
2005-06-05 21:05:43 +00:00
|
|
|
static void create_file(struct patch *patch)
|
|
|
|
{
|
2006-02-04 06:50:57 +00:00
|
|
|
char *path = patch->new_name;
|
2005-06-05 21:05:43 +00:00
|
|
|
unsigned mode = patch->new_mode;
|
|
|
|
unsigned long size = patch->resultsize;
|
|
|
|
char *buf = patch->result;
|
|
|
|
|
|
|
|
if (!mode)
|
|
|
|
mode = S_IFREG | 0644;
|
2006-04-23 23:52:52 +00:00
|
|
|
create_one_file(path, mode, buf, size);
|
2005-07-14 00:25:53 +00:00
|
|
|
add_index_file(path, mode, buf, size);
|
2005-06-05 21:05:43 +00:00
|
|
|
}
|
|
|
|
|
2006-07-17 06:52:09 +00:00
|
|
|
/* phase zero is to remove, phase one is to create */
|
|
|
|
static void write_out_one_result(struct patch *patch, int phase)
|
2005-06-05 21:05:43 +00:00
|
|
|
{
|
|
|
|
if (patch->is_delete > 0) {
|
2006-07-17 06:52:09 +00:00
|
|
|
if (phase == 0)
|
2007-02-20 01:58:58 +00:00
|
|
|
remove_file(patch, 1);
|
2005-06-05 21:05:43 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (patch->is_new > 0 || patch->is_copy) {
|
2006-07-17 06:52:09 +00:00
|
|
|
if (phase == 1)
|
|
|
|
create_file(patch);
|
2005-06-05 21:05:43 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
/*
|
|
|
|
* Rename or modification boils down to the same
|
|
|
|
* thing: remove the old, write the new
|
|
|
|
*/
|
2006-07-17 06:52:09 +00:00
|
|
|
if (phase == 0)
|
2007-08-05 04:48:08 +00:00
|
|
|
remove_file(patch, patch->is_rename);
|
2006-07-17 06:52:09 +00:00
|
|
|
if (phase == 1)
|
2006-08-17 00:55:29 +00:00
|
|
|
create_file(patch);
|
2005-06-05 21:05:43 +00:00
|
|
|
}
|
|
|
|
|
2006-08-17 00:55:29 +00:00
|
|
|
static int write_out_one_reject(struct patch *patch)
|
|
|
|
{
|
2006-08-18 10:10:19 +00:00
|
|
|
FILE *rej;
|
|
|
|
char namebuf[PATH_MAX];
|
2006-08-17 00:55:29 +00:00
|
|
|
struct fragment *frag;
|
2006-08-18 10:10:19 +00:00
|
|
|
int cnt = 0;
|
2006-08-17 00:55:29 +00:00
|
|
|
|
2006-08-18 10:10:19 +00:00
|
|
|
for (cnt = 0, frag = patch->fragments; frag; frag = frag->next) {
|
2006-08-17 00:55:29 +00:00
|
|
|
if (!frag->rejected)
|
|
|
|
continue;
|
2006-08-18 10:10:19 +00:00
|
|
|
cnt++;
|
|
|
|
}
|
|
|
|
|
2006-08-18 10:14:48 +00:00
|
|
|
if (!cnt) {
|
|
|
|
if (apply_verbosely)
|
|
|
|
say_patch_name(stderr,
|
|
|
|
"Applied patch ", patch, " cleanly.\n");
|
2006-08-18 10:10:19 +00:00
|
|
|
return 0;
|
2006-08-18 10:14:48 +00:00
|
|
|
}
|
2006-08-18 10:10:19 +00:00
|
|
|
|
|
|
|
/* This should not happen, because a removal patch that leaves
|
|
|
|
* contents are marked "rejected" at the patch level.
|
|
|
|
*/
|
|
|
|
if (!patch->new_name)
|
|
|
|
die("internal error");
|
|
|
|
|
2006-08-18 10:14:48 +00:00
|
|
|
/* Say this even without --verbose */
|
|
|
|
say_patch_name(stderr, "Applying patch ", patch, " with");
|
|
|
|
fprintf(stderr, " %d rejects...\n", cnt);
|
|
|
|
|
2006-08-18 10:10:19 +00:00
|
|
|
cnt = strlen(patch->new_name);
|
|
|
|
if (ARRAY_SIZE(namebuf) <= cnt + 5) {
|
|
|
|
cnt = ARRAY_SIZE(namebuf) - 5;
|
|
|
|
fprintf(stderr,
|
|
|
|
"warning: truncating .rej filename to %.*s.rej",
|
|
|
|
cnt - 1, patch->new_name);
|
|
|
|
}
|
|
|
|
memcpy(namebuf, patch->new_name, cnt);
|
|
|
|
memcpy(namebuf + cnt, ".rej", 5);
|
|
|
|
|
|
|
|
rej = fopen(namebuf, "w");
|
|
|
|
if (!rej)
|
|
|
|
return error("cannot open %s: %s", namebuf, strerror(errno));
|
|
|
|
|
|
|
|
/* Normal git tools never deal with .rej, so do not pretend
|
|
|
|
* this is a git patch by saying --git nor give extended
|
|
|
|
* headers. While at it, maybe please "kompare" that wants
|
|
|
|
* the trailing TAB and some garbage at the end of line ;-).
|
|
|
|
*/
|
|
|
|
fprintf(rej, "diff a/%s b/%s\t(rejected hunks)\n",
|
|
|
|
patch->new_name, patch->new_name);
|
2006-08-22 22:49:28 +00:00
|
|
|
for (cnt = 1, frag = patch->fragments;
|
2006-08-18 10:10:19 +00:00
|
|
|
frag;
|
|
|
|
cnt++, frag = frag->next) {
|
|
|
|
if (!frag->rejected) {
|
|
|
|
fprintf(stderr, "Hunk #%d applied cleanly.\n", cnt);
|
|
|
|
continue;
|
2006-08-17 00:55:29 +00:00
|
|
|
}
|
2006-08-18 10:10:19 +00:00
|
|
|
fprintf(stderr, "Rejected hunk #%d.\n", cnt);
|
|
|
|
fprintf(rej, "%.*s", frag->size, frag->patch);
|
2006-08-17 00:55:29 +00:00
|
|
|
if (frag->patch[frag->size-1] != '\n')
|
2006-08-18 10:10:19 +00:00
|
|
|
fputc('\n', rej);
|
2006-08-17 00:55:29 +00:00
|
|
|
}
|
2006-08-18 10:10:19 +00:00
|
|
|
fclose(rej);
|
|
|
|
return -1;
|
2005-06-05 21:05:43 +00:00
|
|
|
}
|
|
|
|
|
2006-08-17 00:55:29 +00:00
|
|
|
static int write_out_results(struct patch *list, int skipped_patch)
|
2005-06-05 21:05:43 +00:00
|
|
|
{
|
2006-07-17 06:52:09 +00:00
|
|
|
int phase;
|
2006-08-17 00:55:29 +00:00
|
|
|
int errs = 0;
|
|
|
|
struct patch *l;
|
2006-07-17 06:52:09 +00:00
|
|
|
|
2005-07-22 16:56:57 +00:00
|
|
|
if (!list && !skipped_patch)
|
2006-08-17 00:55:29 +00:00
|
|
|
return error("No changes");
|
2005-06-05 22:25:28 +00:00
|
|
|
|
2006-07-17 06:52:09 +00:00
|
|
|
for (phase = 0; phase < 2; phase++) {
|
2006-08-17 00:55:29 +00:00
|
|
|
l = list;
|
2006-07-17 06:52:09 +00:00
|
|
|
while (l) {
|
2006-08-17 00:55:29 +00:00
|
|
|
if (l->rejected)
|
|
|
|
errs = 1;
|
2006-08-18 10:10:19 +00:00
|
|
|
else {
|
2006-08-17 00:55:29 +00:00
|
|
|
write_out_one_result(l, phase);
|
2006-08-18 10:10:19 +00:00
|
|
|
if (phase == 1 && write_out_one_reject(l))
|
2006-08-17 00:55:29 +00:00
|
|
|
errs = 1;
|
|
|
|
}
|
2006-07-17 06:52:09 +00:00
|
|
|
l = l->next;
|
|
|
|
}
|
2005-06-05 21:05:43 +00:00
|
|
|
}
|
2006-08-17 00:55:29 +00:00
|
|
|
return errs;
|
2005-06-05 21:05:43 +00:00
|
|
|
}
|
|
|
|
|
2006-06-06 19:51:49 +00:00
|
|
|
static struct lock_file lock_file;
|
2005-06-05 21:05:43 +00:00
|
|
|
|
2005-07-22 16:56:57 +00:00
|
|
|
static struct excludes {
|
|
|
|
struct excludes *next;
|
|
|
|
const char *path;
|
|
|
|
} *excludes;
|
|
|
|
|
|
|
|
static int use_patch(struct patch *p)
|
|
|
|
{
|
2005-08-23 20:34:07 +00:00
|
|
|
const char *pathname = p->new_name ? p->new_name : p->old_name;
|
2005-07-22 16:56:57 +00:00
|
|
|
struct excludes *x = excludes;
|
|
|
|
while (x) {
|
|
|
|
if (fnmatch(x->path, pathname, 0) == 0)
|
|
|
|
return 0;
|
|
|
|
x = x->next;
|
|
|
|
}
|
2005-11-26 07:14:15 +00:00
|
|
|
if (0 < prefix_length) {
|
|
|
|
int pathlen = strlen(pathname);
|
|
|
|
if (pathlen <= prefix_length ||
|
|
|
|
memcmp(prefix, pathname, prefix_length))
|
|
|
|
return 0;
|
|
|
|
}
|
2005-07-22 16:56:57 +00:00
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2007-02-20 02:45:49 +00:00
|
|
|
static void prefix_one(char **name)
|
2007-02-20 01:57:29 +00:00
|
|
|
{
|
2007-02-20 02:45:49 +00:00
|
|
|
char *old_name = *name;
|
|
|
|
if (!old_name)
|
|
|
|
return;
|
|
|
|
*name = xstrdup(prefix_filename(prefix, prefix_length, *name));
|
|
|
|
free(old_name);
|
2007-02-20 01:57:29 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void prefix_patches(struct patch *p)
|
|
|
|
{
|
2007-02-21 22:31:10 +00:00
|
|
|
if (!prefix || p->is_toplevel_relative)
|
2007-02-20 01:57:29 +00:00
|
|
|
return;
|
|
|
|
for ( ; p; p = p->next) {
|
2007-02-21 08:58:18 +00:00
|
|
|
if (p->new_name == p->old_name) {
|
|
|
|
char *prefixed = p->new_name;
|
|
|
|
prefix_one(&prefixed);
|
|
|
|
p->new_name = p->old_name = prefixed;
|
|
|
|
}
|
|
|
|
else {
|
2007-02-20 02:45:49 +00:00
|
|
|
prefix_one(&p->new_name);
|
2007-02-21 08:58:18 +00:00
|
|
|
prefix_one(&p->old_name);
|
|
|
|
}
|
2007-02-20 01:57:29 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-08-15 06:26:51 +00:00
|
|
|
static int apply_patch(int fd, const char *filename, int inaccurate_eof)
|
2005-05-23 17:52:17 +00:00
|
|
|
{
|
2007-09-27 11:33:19 +00:00
|
|
|
size_t offset;
|
|
|
|
struct strbuf buf;
|
2005-05-26 17:23:51 +00:00
|
|
|
struct patch *list = NULL, **listp = &list;
|
2005-07-22 16:56:57 +00:00
|
|
|
int skipped_patch = 0;
|
2005-05-23 17:52:17 +00:00
|
|
|
|
2007-09-27 11:33:19 +00:00
|
|
|
strbuf_init(&buf, 0);
|
2006-02-27 02:13:25 +00:00
|
|
|
patch_input_file = filename;
|
2007-09-27 11:33:19 +00:00
|
|
|
read_patch_file(&buf, fd);
|
2005-05-23 17:52:17 +00:00
|
|
|
offset = 0;
|
2007-09-27 11:33:19 +00:00
|
|
|
while (offset < buf.len) {
|
2005-05-26 17:23:51 +00:00
|
|
|
struct patch *patch;
|
|
|
|
int nr;
|
|
|
|
|
2006-04-03 18:30:46 +00:00
|
|
|
patch = xcalloc(1, sizeof(*patch));
|
2006-06-24 20:10:11 +00:00
|
|
|
patch->inaccurate_eof = inaccurate_eof;
|
2007-10-04 00:42:52 +00:00
|
|
|
nr = parse_chunk(buf.buf + offset, buf.len - offset, patch);
|
2005-05-23 17:52:17 +00:00
|
|
|
if (nr < 0)
|
|
|
|
break;
|
2006-08-15 06:26:51 +00:00
|
|
|
if (apply_in_reverse)
|
2006-07-28 15:46:11 +00:00
|
|
|
reverse_patches(patch);
|
2007-02-20 01:57:29 +00:00
|
|
|
if (prefix)
|
|
|
|
prefix_patches(patch);
|
2005-07-22 16:56:57 +00:00
|
|
|
if (use_patch(patch)) {
|
|
|
|
patch_stats(patch);
|
|
|
|
*listp = patch;
|
|
|
|
listp = &patch->next;
|
2007-02-20 01:57:29 +00:00
|
|
|
}
|
|
|
|
else {
|
2005-07-22 16:56:57 +00:00
|
|
|
/* perhaps free it a bit better? */
|
|
|
|
free(patch);
|
|
|
|
skipped_patch++;
|
|
|
|
}
|
2005-05-23 17:52:17 +00:00
|
|
|
offset += nr;
|
|
|
|
}
|
2005-05-26 17:23:51 +00:00
|
|
|
|
2007-11-23 10:37:03 +00:00
|
|
|
if (whitespace_error && (ws_error_action == die_on_ws_error))
|
2006-02-27 02:13:25 +00:00
|
|
|
apply = 0;
|
|
|
|
|
2007-04-02 05:46:06 +00:00
|
|
|
update_index = check_index && apply;
|
|
|
|
if (update_index && newfd < 0)
|
_GIT_INDEX_OUTPUT: allow plumbing to output to an alternative index file.
When defined, this allows plumbing commands that update the
index (add, apply, checkout-index, merge-recursive, mv,
read-tree, rm, update-index, and write-tree) to write their
resulting index to an alternative index file while holding a
lock to the original index file. With this, git-commit that
jumps the index does not have to make an extra copy of the index
file, and more importantly, it can do the update while holding
the lock on the index.
However, I think the interface to let an environment variable
specify the output is a mistake, as shown in the documentation.
If a curious user has the environment variable set to something
other than the file GIT_INDEX_FILE points at, almost everything
will break. This should instead be a command line parameter to
tell these plumbing commands to write the result in the named
file, to prevent stupid mistakes.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-04-01 06:09:02 +00:00
|
|
|
newfd = hold_locked_index(&lock_file, 1);
|
|
|
|
|
2005-06-05 21:05:43 +00:00
|
|
|
if (check_index) {
|
|
|
|
if (read_cache() < 0)
|
|
|
|
die("unable to read index file");
|
|
|
|
}
|
|
|
|
|
2006-08-17 00:55:29 +00:00
|
|
|
if ((check || apply) &&
|
|
|
|
check_patch_list(list) < 0 &&
|
|
|
|
!apply_with_reject)
|
2005-05-26 22:10:02 +00:00
|
|
|
exit(1);
|
|
|
|
|
2006-08-17 00:55:29 +00:00
|
|
|
if (apply && write_out_results(list, skipped_patch))
|
|
|
|
exit(1);
|
2005-06-05 21:05:43 +00:00
|
|
|
|
2007-09-17 22:34:06 +00:00
|
|
|
if (fake_ancestor)
|
|
|
|
build_fake_ancestor(list, fake_ancestor);
|
2005-10-07 10:42:00 +00:00
|
|
|
|
2005-05-26 22:10:02 +00:00
|
|
|
if (diffstat)
|
|
|
|
stat_patch_list(list);
|
2005-05-26 17:23:51 +00:00
|
|
|
|
2005-10-28 09:43:31 +00:00
|
|
|
if (numstat)
|
|
|
|
numstat_patch_list(list);
|
|
|
|
|
2005-06-22 09:29:46 +00:00
|
|
|
if (summary)
|
|
|
|
summary_patch_list(list);
|
|
|
|
|
2007-09-27 11:33:19 +00:00
|
|
|
strbuf_release(&buf);
|
2005-05-23 17:52:17 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-02-27 22:47:45 +00:00
|
|
|
static int git_apply_config(const char *var, const char *value)
|
|
|
|
{
|
2008-04-08 08:42:33 +00:00
|
|
|
if (!strcmp(var, "apply.whitespace"))
|
|
|
|
return git_config_string(&apply_default_whitespace, var, value);
|
2006-02-27 22:47:45 +00:00
|
|
|
return git_default_config(var, value);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2007-01-21 01:17:19 +00:00
|
|
|
int cmd_apply(int argc, const char **argv, const char *unused_prefix)
|
2005-05-23 17:52:17 +00:00
|
|
|
{
|
|
|
|
int i;
|
2005-05-23 23:42:21 +00:00
|
|
|
int read_stdin = 1;
|
2006-06-24 20:10:11 +00:00
|
|
|
int inaccurate_eof = 0;
|
2006-08-17 00:55:29 +00:00
|
|
|
int errs = 0;
|
2008-03-25 21:06:26 +00:00
|
|
|
int is_not_gitdir;
|
2006-06-24 20:10:11 +00:00
|
|
|
|
2006-02-27 22:47:45 +00:00
|
|
|
const char *whitespace_option = NULL;
|
2005-05-23 17:52:17 +00:00
|
|
|
|
2007-02-17 21:12:52 +00:00
|
|
|
prefix = setup_git_directory_gently(&is_not_gitdir);
|
|
|
|
prefix_length = prefix ? strlen(prefix) : 0;
|
2007-02-18 02:12:46 +00:00
|
|
|
git_config(git_apply_config);
|
|
|
|
if (apply_default_whitespace)
|
|
|
|
parse_whitespace_option(apply_default_whitespace);
|
2007-02-17 20:37:25 +00:00
|
|
|
|
2005-05-23 17:52:17 +00:00
|
|
|
for (i = 1; i < argc; i++) {
|
|
|
|
const char *arg = argv[i];
|
2006-04-10 09:33:06 +00:00
|
|
|
char *end;
|
2005-05-23 17:52:17 +00:00
|
|
|
int fd;
|
|
|
|
|
|
|
|
if (!strcmp(arg, "-")) {
|
2006-08-17 00:55:29 +00:00
|
|
|
errs |= apply_patch(0, "<stdin>", inaccurate_eof);
|
2005-05-23 23:42:21 +00:00
|
|
|
read_stdin = 0;
|
2005-05-23 17:52:17 +00:00
|
|
|
continue;
|
|
|
|
}
|
Mechanical conversion to use prefixcmp()
This mechanically converts strncmp() to use prefixcmp(), but only when
the parameters match specific patterns, so that they can be verified
easily. Leftover from this will be fixed in a separate step, including
idiotic conversions like
if (!strncmp("foo", arg, 3))
=>
if (!(-prefixcmp(arg, "foo")))
This was done by using this script in px.perl
#!/usr/bin/perl -i.bak -p
if (/strncmp\(([^,]+), "([^\\"]*)", (\d+)\)/ && (length($2) == $3)) {
s|strncmp\(([^,]+), "([^\\"]*)", (\d+)\)|prefixcmp($1, "$2")|;
}
if (/strncmp\("([^\\"]*)", ([^,]+), (\d+)\)/ && (length($1) == $3)) {
s|strncmp\("([^\\"]*)", ([^,]+), (\d+)\)|(-prefixcmp($2, "$1"))|;
}
and running:
$ git grep -l strncmp -- '*.c' | xargs perl px.perl
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-02-20 09:53:29 +00:00
|
|
|
if (!prefixcmp(arg, "--exclude=")) {
|
2005-07-22 16:56:57 +00:00
|
|
|
struct excludes *x = xmalloc(sizeof(*x));
|
|
|
|
x->path = arg + 10;
|
|
|
|
x->next = excludes;
|
|
|
|
excludes = x;
|
|
|
|
continue;
|
|
|
|
}
|
Mechanical conversion to use prefixcmp()
This mechanically converts strncmp() to use prefixcmp(), but only when
the parameters match specific patterns, so that they can be verified
easily. Leftover from this will be fixed in a separate step, including
idiotic conversions like
if (!strncmp("foo", arg, 3))
=>
if (!(-prefixcmp(arg, "foo")))
This was done by using this script in px.perl
#!/usr/bin/perl -i.bak -p
if (/strncmp\(([^,]+), "([^\\"]*)", (\d+)\)/ && (length($2) == $3)) {
s|strncmp\(([^,]+), "([^\\"]*)", (\d+)\)|prefixcmp($1, "$2")|;
}
if (/strncmp\("([^\\"]*)", ([^,]+), (\d+)\)/ && (length($1) == $3)) {
s|strncmp\("([^\\"]*)", ([^,]+), (\d+)\)|(-prefixcmp($2, "$1"))|;
}
and running:
$ git grep -l strncmp -- '*.c' | xargs perl px.perl
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-02-20 09:53:29 +00:00
|
|
|
if (!prefixcmp(arg, "-p")) {
|
2006-01-31 05:36:24 +00:00
|
|
|
p_value = atoi(arg + 2);
|
2007-02-22 00:05:56 +00:00
|
|
|
p_value_known = 1;
|
2006-01-31 05:36:24 +00:00
|
|
|
continue;
|
|
|
|
}
|
2005-11-10 04:38:33 +00:00
|
|
|
if (!strcmp(arg, "--no-add")) {
|
|
|
|
no_add = 1;
|
|
|
|
continue;
|
|
|
|
}
|
2005-05-26 19:25:52 +00:00
|
|
|
if (!strcmp(arg, "--stat")) {
|
2005-05-26 22:10:02 +00:00
|
|
|
apply = 0;
|
2005-05-26 19:25:52 +00:00
|
|
|
diffstat = 1;
|
|
|
|
continue;
|
|
|
|
}
|
2006-05-05 09:41:53 +00:00
|
|
|
if (!strcmp(arg, "--allow-binary-replacement") ||
|
|
|
|
!strcmp(arg, "--binary")) {
|
2006-09-07 05:45:21 +00:00
|
|
|
continue; /* now no-op */
|
2005-11-15 01:37:05 +00:00
|
|
|
}
|
2005-10-28 09:43:31 +00:00
|
|
|
if (!strcmp(arg, "--numstat")) {
|
|
|
|
apply = 0;
|
|
|
|
numstat = 1;
|
|
|
|
continue;
|
|
|
|
}
|
2005-06-22 09:29:46 +00:00
|
|
|
if (!strcmp(arg, "--summary")) {
|
|
|
|
apply = 0;
|
|
|
|
summary = 1;
|
|
|
|
continue;
|
|
|
|
}
|
2005-05-26 22:10:02 +00:00
|
|
|
if (!strcmp(arg, "--check")) {
|
|
|
|
apply = 0;
|
|
|
|
check = 1;
|
|
|
|
continue;
|
|
|
|
}
|
2005-06-05 18:03:13 +00:00
|
|
|
if (!strcmp(arg, "--index")) {
|
2007-02-17 21:12:52 +00:00
|
|
|
if (is_not_gitdir)
|
|
|
|
die("--index outside a repository");
|
2005-06-05 18:03:13 +00:00
|
|
|
check_index = 1;
|
|
|
|
continue;
|
|
|
|
}
|
2006-05-15 22:15:47 +00:00
|
|
|
if (!strcmp(arg, "--cached")) {
|
2007-02-17 21:12:52 +00:00
|
|
|
if (is_not_gitdir)
|
|
|
|
die("--cached outside a repository");
|
2006-05-15 22:15:47 +00:00
|
|
|
check_index = 1;
|
|
|
|
cached = 1;
|
|
|
|
continue;
|
|
|
|
}
|
2005-06-23 16:00:01 +00:00
|
|
|
if (!strcmp(arg, "--apply")) {
|
|
|
|
apply = 1;
|
|
|
|
continue;
|
|
|
|
}
|
2007-09-17 22:34:06 +00:00
|
|
|
if (!strcmp(arg, "--build-fake-ancestor")) {
|
2005-10-07 10:42:00 +00:00
|
|
|
apply = 0;
|
2007-09-17 22:34:06 +00:00
|
|
|
if (++i >= argc)
|
|
|
|
die ("need a filename");
|
|
|
|
fake_ancestor = argv[i];
|
2005-10-07 10:42:00 +00:00
|
|
|
continue;
|
|
|
|
}
|
2005-10-15 04:54:52 +00:00
|
|
|
if (!strcmp(arg, "-z")) {
|
|
|
|
line_termination = 0;
|
|
|
|
continue;
|
|
|
|
}
|
Mechanical conversion to use prefixcmp()
This mechanically converts strncmp() to use prefixcmp(), but only when
the parameters match specific patterns, so that they can be verified
easily. Leftover from this will be fixed in a separate step, including
idiotic conversions like
if (!strncmp("foo", arg, 3))
=>
if (!(-prefixcmp(arg, "foo")))
This was done by using this script in px.perl
#!/usr/bin/perl -i.bak -p
if (/strncmp\(([^,]+), "([^\\"]*)", (\d+)\)/ && (length($2) == $3)) {
s|strncmp\(([^,]+), "([^\\"]*)", (\d+)\)|prefixcmp($1, "$2")|;
}
if (/strncmp\("([^\\"]*)", ([^,]+), (\d+)\)/ && (length($1) == $3)) {
s|strncmp\("([^\\"]*)", ([^,]+), (\d+)\)|(-prefixcmp($2, "$1"))|;
}
and running:
$ git grep -l strncmp -- '*.c' | xargs perl px.perl
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-02-20 09:53:29 +00:00
|
|
|
if (!prefixcmp(arg, "-C")) {
|
2006-04-10 09:33:06 +00:00
|
|
|
p_context = strtoul(arg + 2, &end, 0);
|
|
|
|
if (*end != '\0')
|
|
|
|
die("unrecognized context count '%s'", arg + 2);
|
|
|
|
continue;
|
|
|
|
}
|
Mechanical conversion to use prefixcmp()
This mechanically converts strncmp() to use prefixcmp(), but only when
the parameters match specific patterns, so that they can be verified
easily. Leftover from this will be fixed in a separate step, including
idiotic conversions like
if (!strncmp("foo", arg, 3))
=>
if (!(-prefixcmp(arg, "foo")))
This was done by using this script in px.perl
#!/usr/bin/perl -i.bak -p
if (/strncmp\(([^,]+), "([^\\"]*)", (\d+)\)/ && (length($2) == $3)) {
s|strncmp\(([^,]+), "([^\\"]*)", (\d+)\)|prefixcmp($1, "$2")|;
}
if (/strncmp\("([^\\"]*)", ([^,]+), (\d+)\)/ && (length($1) == $3)) {
s|strncmp\("([^\\"]*)", ([^,]+), (\d+)\)|(-prefixcmp($2, "$1"))|;
}
and running:
$ git grep -l strncmp -- '*.c' | xargs perl px.perl
Signed-off-by: Junio C Hamano <junkio@cox.net>
2007-02-20 09:53:29 +00:00
|
|
|
if (!prefixcmp(arg, "--whitespace=")) {
|
2006-02-27 22:47:45 +00:00
|
|
|
whitespace_option = arg + 13;
|
|
|
|
parse_whitespace_option(arg + 13);
|
|
|
|
continue;
|
The war on trailing whitespace
On Sat, 25 Feb 2006, Andrew Morton wrote:
>
> I'd suggest a) git will simply refuse to apply such a patch unless given a
> special `forcing' flag, b) even when thus forced, it will still warn and c)
> with a different flag, it will strip-then-apply, without generating a
> warning.
This doesn't do the "strip-then-apply" thing, but it allows you to make
git-apply generate a warning or error on extraneous whitespace.
Use --whitespace=warn to warn, and (surprise, surprise) --whitespace=error
to make it a fatal error to have whitespace at the end.
Totally untested, of course. But it compiles, so it must be fine.
HOWEVER! Note that this literally will check every single patch-line with
"+" at the beginning. Which means that if you fix a simple typo, and the
line had a space at the end before, and you didn't remove it, that's still
considered a "new line with whitespace at the end", even though obviously
the line wasn't really new.
I assume this is what you wanted, and there isn't really any sane
alternatives (you could make the warning activate only for _pure_
additions with no deletions at all in that hunk, but that sounds a bit
insane).
Linus
2006-02-26 17:29:00 +00:00
|
|
|
}
|
2006-07-28 15:46:11 +00:00
|
|
|
if (!strcmp(arg, "-R") || !strcmp(arg, "--reverse")) {
|
2006-08-15 06:26:51 +00:00
|
|
|
apply_in_reverse = 1;
|
2006-07-28 15:46:11 +00:00
|
|
|
continue;
|
apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches
In "git-apply", we have a few sanity checks and heuristics that
expects that the patch fed to us is a unified diff with at least
one line of context.
* When there is no leading context line in a hunk, the hunk
must apply at the beginning of the preimage. Similarly, no
trailing context means that the hunk is anchored at the end.
* We learn a patch deletes the file from a hunk that has no
resulting line (i.e. all lines are prefixed with '-') if it
has not otherwise been known if the patch deletes the file.
Similarly, no old line means the file is being created.
And we declare an error condition when the file created by a
creation patch already exists, and/or when a deletion patch
still leaves content in the file.
These sanity checks are good safety measures, but breaks down
when people feed a diff generated with --unified=0. This was
recently noticed first by Matthew Wilcox and Gerrit Pape.
This adds a new flag, --unified-zero, to allow bypassing these
checks. If you are in control of the patch generation process,
you should not use --unified=0 patch and fix it up with this
flag; rather you should try work with a patch with context. But
if all you have to work with is a patch without context, this
flag may come handy as the last resort.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2006-09-17 08:04:24 +00:00
|
|
|
}
|
|
|
|
if (!strcmp(arg, "--unidiff-zero")) {
|
|
|
|
unidiff_zero = 1;
|
|
|
|
continue;
|
2006-07-28 15:46:11 +00:00
|
|
|
}
|
2006-08-17 00:55:29 +00:00
|
|
|
if (!strcmp(arg, "--reject")) {
|
2006-08-27 22:53:20 +00:00
|
|
|
apply = apply_with_reject = apply_verbosely = 1;
|
2006-08-17 00:55:29 +00:00
|
|
|
continue;
|
|
|
|
}
|
2007-02-22 19:11:21 +00:00
|
|
|
if (!strcmp(arg, "-v") || !strcmp(arg, "--verbose")) {
|
2006-08-18 10:14:48 +00:00
|
|
|
apply_verbosely = 1;
|
|
|
|
continue;
|
|
|
|
}
|
2006-06-24 20:10:11 +00:00
|
|
|
if (!strcmp(arg, "--inaccurate-eof")) {
|
|
|
|
inaccurate_eof = 1;
|
|
|
|
continue;
|
|
|
|
}
|
2005-11-26 07:14:15 +00:00
|
|
|
if (0 < prefix_length)
|
|
|
|
arg = prefix_filename(prefix, prefix_length, arg);
|
|
|
|
|
2005-05-23 17:52:17 +00:00
|
|
|
fd = open(arg, O_RDONLY);
|
|
|
|
if (fd < 0)
|
2008-04-14 15:30:27 +00:00
|
|
|
die("can't open patch '%s': %s", arg, strerror(errno));
|
2005-05-23 23:42:21 +00:00
|
|
|
read_stdin = 0;
|
2006-02-28 09:12:52 +00:00
|
|
|
set_default_whitespace_mode(whitespace_option);
|
2006-08-17 00:55:29 +00:00
|
|
|
errs |= apply_patch(fd, arg, inaccurate_eof);
|
2005-05-23 17:52:17 +00:00
|
|
|
close(fd);
|
|
|
|
}
|
2006-02-28 09:12:52 +00:00
|
|
|
set_default_whitespace_mode(whitespace_option);
|
2005-05-23 23:42:21 +00:00
|
|
|
if (read_stdin)
|
2006-08-17 00:55:29 +00:00
|
|
|
errs |= apply_patch(0, "<stdin>", inaccurate_eof);
|
2006-02-27 22:16:30 +00:00
|
|
|
if (whitespace_error) {
|
|
|
|
if (squelch_whitespace_errors &&
|
|
|
|
squelch_whitespace_errors < whitespace_error) {
|
|
|
|
int squelched =
|
|
|
|
whitespace_error - squelch_whitespace_errors;
|
2006-08-17 00:55:29 +00:00
|
|
|
fprintf(stderr, "warning: squelched %d "
|
|
|
|
"whitespace error%s\n",
|
2006-02-27 22:16:30 +00:00
|
|
|
squelched,
|
|
|
|
squelched == 1 ? "" : "s");
|
|
|
|
}
|
2007-11-23 10:37:03 +00:00
|
|
|
if (ws_error_action == die_on_ws_error)
|
2007-06-03 02:55:54 +00:00
|
|
|
die("%d line%s add%s whitespace errors.",
|
2006-02-27 22:16:30 +00:00
|
|
|
whitespace_error,
|
|
|
|
whitespace_error == 1 ? "" : "s",
|
|
|
|
whitespace_error == 1 ? "s" : "");
|
2008-01-08 23:46:18 +00:00
|
|
|
if (applied_after_fixing_ws && apply)
|
2006-02-27 22:16:30 +00:00
|
|
|
fprintf(stderr, "warning: %d line%s applied after"
|
2007-06-03 02:55:54 +00:00
|
|
|
" fixing whitespace errors.\n",
|
|
|
|
applied_after_fixing_ws,
|
|
|
|
applied_after_fixing_ws == 1 ? "" : "s");
|
2006-02-27 22:16:30 +00:00
|
|
|
else if (whitespace_error)
|
2007-06-03 02:55:54 +00:00
|
|
|
fprintf(stderr, "warning: %d line%s add%s whitespace errors.\n",
|
2006-02-27 22:16:30 +00:00
|
|
|
whitespace_error,
|
|
|
|
whitespace_error == 1 ? "" : "s",
|
|
|
|
whitespace_error == 1 ? "s" : "");
|
|
|
|
}
|
2006-05-09 08:08:23 +00:00
|
|
|
|
2007-04-02 05:46:06 +00:00
|
|
|
if (update_index) {
|
2006-05-09 08:08:23 +00:00
|
|
|
if (write_cache(newfd, active_cache, active_nr) ||
|
2008-01-16 19:12:46 +00:00
|
|
|
commit_locked_index(&lock_file))
|
2006-06-06 19:51:49 +00:00
|
|
|
die("Unable to write new index file");
|
2006-05-09 08:08:23 +00:00
|
|
|
}
|
|
|
|
|
2006-08-17 00:55:29 +00:00
|
|
|
return !!errs;
|
2005-05-23 17:52:17 +00:00
|
|
|
}
|