mirror of
https://github.com/git/git
synced 2024-08-24 18:26:02 +00:00
Fix botched "leak fix"
When (new_name == old_name), the previous one prefixed old_name alone, leaving new_name untouched, and worse yet, left it dangling pointing at an already freed memory location. Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
parent
c24e9757e9
commit
6c912f5b04
|
@ -2516,9 +2516,15 @@ static void prefix_patches(struct patch *p)
|
|||
if (!prefix)
|
||||
return;
|
||||
for ( ; p; p = p->next) {
|
||||
if (p->new_name != p->old_name)
|
||||
if (p->new_name == p->old_name) {
|
||||
char *prefixed = p->new_name;
|
||||
prefix_one(&prefixed);
|
||||
p->new_name = p->old_name = prefixed;
|
||||
}
|
||||
else {
|
||||
prefix_one(&p->new_name);
|
||||
prefix_one(&p->old_name);
|
||||
prefix_one(&p->old_name);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue