development/git
development/git
1
0
Fork 0
mirror of https://github.com/git/git synced 2024-10-05 16:19:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

apply: do not barf on patch with too large an offset

Browse source 
Previously a patch that records too large a line number caused the
offset matching code in git-apply to overstep its internal buffer.

Noticed by Johannes Schindelin.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2008-02-11 15:32:29 -08:00
parent b2979ff599
commit 52f3c81a9d
2 changed files with 60 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
builtin-apply.c
View file

@ -1809,6 +1809,9 @@ static int find_pos(struct image *img,
else if (match_end)
line = img->nr - preimage->nr;
if (line > img->nr)
line = img->nr;
try = 0;
for (i = 0; i < line; i++)
try += img->line[i].len;

57
t/t4105-apply-fuzz.sh Executable file
View file

@ -0,0 +1,57 @@
#!/bin/sh
test_description='apply with fuzz and offset'
. ./test-lib.sh
dotest () {
name="$1" && shift &&
test_expect_success "$name" "
git checkout-index -f -q -u file &&
git apply $* &&
diff -u expect file
"
}
test_expect_success setup '
for i in 1 2 3 4 5 6 7 8 9 10 11 12
do
echo $i
done >file &&
git update-index --add file &&
for i in 1 2 3 4 5 6 7 a b c d e 8 9 10 11 12
do
echo $i
done >file &&
cat file >expect &&
git diff >O0.diff &&
sed -e "s/@@ -5,6 +5,11 @@/@@ -2,6 +2,11 @@/" >O1.diff O0.diff &&
sed -e "s/@@ -5,6 +5,11 @@/@@ -7,6 +7,11 @@/" >O2.diff O0.diff &&
sed -e "s/@@ -5,6 +5,11 @@/@@ -19,6 +19,11 @@/" >O3.diff O0.diff &&
sed -e "s/^ 5/ S/" >F0.diff O0.diff &&
sed -e "s/^ 5/ S/" >F1.diff O1.diff &&
sed -e "s/^ 5/ S/" >F2.diff O2.diff &&
sed -e "s/^ 5/ S/" >F3.diff O3.diff
'
dotest 'unmodified patch' O0.diff
dotest 'minus offset' O1.diff
dotest 'plus offset' O2.diff
dotest 'big offset' O3.diff
dotest 'fuzz with no offset' -C2 F0.diff
dotest 'fuzz with minus offset' -C2 F1.diff
dotest 'fuzz with plus offset' -C2 F2.diff
dotest 'fuzz with big offset' -C2 F3.diff
test_done