Commit graph

5468 commits

Author SHA1 Message Date
Chris Bracken 3e7e06512c
Correct misspellings throughout the codebase (#79500) 2021-04-01 10:04:03 -07:00
Shi-Hao Hong 9077a5c69b
[gen-l10n] Remove more ignores, conditionally generate some code (#78975) 2021-03-31 19:54:02 -07:00
Jenn Magder 04ebce9279
Fix import device_port_forwarder typo (#79507) 2021-03-31 18:43:34 -07:00
Jenn Magder 152af5aba7
Fix device_port_forwarder file name typo (#79481) 2021-03-31 18:14:03 -07:00
Hannes Winkler e8ad03099f
[flutter_tools] Add support for custom devices (#78113) 2021-03-31 18:09:02 -07:00
Jenn Magder 8ddc27e607
Split globals.dart into null sound and unsound libraries (#79016) 2021-03-31 16:55:20 -07:00
Jonah Williams 29207e4f78
[flutter_tools] split application package factory dependencies (#79461) 2021-03-31 15:11:58 -07:00
Jonah Williams 6b3093b6af
[flutter_tools] remove globals from Device and separate FlutterDeviceManager (#79454) 2021-03-31 12:59:00 -07:00
Jenn Magder 395246f08c
Remove some globals from the tool (#79422) 2021-03-31 11:43:20 -07:00
Jia Hao 9e3eadb98d
[flutter_tools] Support Integration Tests (#76200) 2021-03-30 19:29:02 -07:00
Jenn Magder 83980ef246
Migrate event_printer and test_config to null safety (#79346) 2021-03-30 16:59:05 -07:00
Dan Field b6a6ea7045
Allow writing startup_info.json to somewhere other than the build dir (#79338) 2021-03-30 16:18:45 -07:00
Jenn Magder 5a6d2a0a8e
Check for outdated Podfile before running pod install (#79343) 2021-03-30 12:42:39 -07:00
Jonah Williams f59b185be4
[flutter_tools] do not make drive require pub if --no-pub is requested (#79379) 2021-03-30 11:39:02 -07:00
Jenn Magder 5d87b3efbf
Migrate code_signing to null safety (#79342) 2021-03-30 08:19:28 -07:00
Michael Thomsen 2cdd51900c
Enable null safety by default in templates (#78619) 2021-03-30 10:16:05 +02:00
Jonah Williams 430626d0f3
[flutter_tools] use existing service implementations for web (#78995) 2021-03-29 21:44:03 -07:00
Shi-Hao Hong 134aa8e9da
[gen-l10n] Add nullable-getter flag (#79263) 2021-03-29 20:59:04 -07:00
Jonah Williams cf6d4a35a5
[flutter_tools] guard L service extension in debug mode (#79173) 2021-03-29 20:54:05 -07:00
Jenn Magder 4a2ff6490f
Migrate file_store to null safety (#79111) 2021-03-29 20:44:05 -07:00
Jenn Magder d6c77320ae
Migrate gen_l10n_types to null safety (#79108) 2021-03-29 13:34:55 -07:00
Jonah Williams 35bd77bb08
[flutter_tools] separate concept of null safe language version from current language version (#79052) 2021-03-25 17:14:34 -07:00
Jonah Williams dfc134dd9a
[versions] roll many versions (#79088) 2021-03-25 15:43:44 -07:00
Konstantin Scheglov e31064978a
Add '--protocol-traffic-log' option to 'analyze' command. (#78674) 2021-03-25 15:09:05 -07:00
Zachary Anderson 512ea8f9d0
[flutter_tools] Remove reference to pm genkey and -k (#79047) 2021-03-25 14:51:45 -07:00
Gurjinder Partola fed35b4d9c
[flutter_tools] Add support for versioned Android cmdline tools (#78253) 2021-03-25 13:42:39 -07:00
Michael Goderbauer 99023f0686
Fix missed ignores (#79071) 2021-03-25 13:02:12 -07:00
Jenn Magder f712fecde2
Migrate visual_studio to null safety (#78942) 2021-03-25 10:09:16 -07:00
Jenn Magder 8893e89d11
Migrate device_port_forwarder to null safety (#78949) 2021-03-24 16:56:14 -07:00
Jenn Magder 3c24f16744
Migrate platform_plugins to null safety (#78943) 2021-03-24 16:35:43 -07:00
Jenn Magder bd94007356
Migrate localizations_utils to null safety (#78939) 2021-03-24 16:35:16 -07:00
Jenn Magder b804117802
Removed unnecessary ! in net.dart (#79010) 2021-03-24 15:36:12 -07:00
Jenn Magder 5398c34cfe
Migrate flutter_project_metadata to null safety (#78944) 2021-03-24 15:21:23 -07:00
Jenn Magder 63d6ec56af
Migrate deferred_components_validator to null safety (#78934) 2021-03-24 15:20:05 -07:00
Jenn Magder ce31d4ff7e
Migrate android_console to null safety (#78923) 2021-03-24 15:18:00 -07:00
Jenn Magder 7148cc61f3
Migrate flutter_tool net.dart to null safety (#78922) 2021-03-24 15:16:13 -07:00
Jenn Magder d79b16689d
Migrate error_handling_io to null safety (#78932) 2021-03-24 14:56:26 -07:00
Danny Tuppeny 563338a106
Support WebSockets for injected client (#78961) 2021-03-24 10:45:03 -07:00
Jia Hao aa1df71c20
[flutter_tools] throwToolExit should return Never (#78954) 2021-03-24 10:40:03 -07:00
Gary Qian 2f05751973
Record deferred components assets in AssetManifest.json (#78824) 2021-03-24 02:57:01 -07:00
Shi-Hao Hong 9f49181f40
[gen-l10n] Remove need for ignoring two lints in generated code (#78778)
* Remove need for unused import for placeholder braces

* Remove need for unused intl import for when plurals aren't used in the generated code
2021-03-24 15:46:09 +08:00
Jonah Williams 975fb0f06c
[flutter_tool] fix deletion of gradle wrapper artifacts in cache (#78911) 2021-03-23 21:33:05 -07:00
Jonah Williams 64d9650e51
[flutter_tools] remove suite channel access from web tests (#78915) 2021-03-23 21:32:53 -07:00
Michael Goderbauer cec6491838
Remove ignores that are not ignoring anything (#78669) 2021-03-23 18:46:04 -07:00
Jonah Williams 9cc61b0f90
[flutter_tools] handle concurrent modification in signal callback (#78913) 2021-03-23 17:30:09 -07:00
Jenn Magder d165ea5c42
Migrate os to null safety (#78901) 2021-03-23 17:28:09 -07:00
Zachary Anderson 5efc7169eb
Reverts "Implement dartPluginClass support for plugins #74469" (#78623)
* Revert "Enable dart_plugin_registry_test (#76645)"

This reverts commit 109e0bb9f5.

* Revert "Apply changes caused by https://github.com/flutter/flutter/pull/76662 (#77093)"

This reverts commit cdca6485f0.

* Revert "Disable clang format in the plugin registrants (#76662)"

This reverts commit dadbd47d09.

* Revert "Disable warnings for the dart plugin registrant (#76561)"

This reverts commit 098ece522d.

* Revert "Remove dart_plugin_registry_test timeouts (#76838)"

This reverts commit 1610a27476.

* Revert "Implement dartPluginClass support for plugins (#74469)"

This reverts commit b7d4806243.

Kick.
2021-03-23 14:28:11 -07:00
Jenn Magder 46c99809b4
Migrate flutter_tools file_system to null safety (#78896) 2021-03-23 13:36:34 -07:00
Jenn Magder 5a6bac3037
Migrate command_help to null safety (#78892) 2021-03-23 12:47:48 -07:00
Jenn Magder 7f3c5deb7e
Migrate signals.dart to null safety (#78893) 2021-03-23 12:46:26 -07:00
Danny Tuppeny 596133a723
Pass the --disable-dds flag through to dwds (#78806) 2021-03-23 12:36:53 -07:00
Jenn Magder 8a0cc1bef7
Make launguage_version in flutter_tool null safe (#78843) 2021-03-23 10:11:07 -07:00
Jonah Williams 72ff553af3
[flutter_tools] migrate io, process, logger, terminal (#78816) 2021-03-23 10:10:37 -07:00
Jenn Magder 5a21e2d877
Make version and time in flutter_tool null safe (#78836) 2021-03-23 10:03:23 -07:00
Jenn Magder 0bde67e734
Migrate flutter_tool tool helper files to null safety (#78845) 2021-03-23 10:02:59 -07:00
Jenn Magder 3463946448
Take screenshot when drive fails (#78822) 2021-03-22 19:06:28 -07:00
Shi-Hao Hong 7a88eb97ea
Typo fixes (#78755) 2021-03-23 09:23:43 +08:00
Jonah Williams cf903d7392
[flutter_tools] remove globals from process, filesystem (#78357) 2021-03-22 10:35:40 -07:00
Marcel Čampa e85fe60d00
Command flutter create respects disabled iOS and Android (#78406) 2021-03-22 09:53:05 -07:00
Jonah Williams 985fc7463c
[flutter_tools] add skeleton for build uwp (#78624)
Adds the rest of the scaffolding for building a UWP application. The actual build functionality needs to be implemented, but could use buildWindows as an example (if it is going through cmake)

#14967
2021-03-19 15:36:42 -07:00
Michael Goderbauer 197b440e96
Migrate out custom ignore syntax to flutter_ignore (#78497) 2021-03-19 15:33:05 -07:00
Michael Goderbauer a7e3b1a35d
Clean up ignores that are not ignoring anything (#78493) 2021-03-19 15:32:46 -07:00
Sigurd Meldgaard b948bc073d
Flutter tool - Don't check for updates when run on a bot (#76107) 2021-03-19 14:21:04 -07:00
Jonah Williams 28532edaa5
Update all versions and migrate devicelab framework to package:vm_service (#78557) 2021-03-18 12:38:12 -07:00
Jenn Magder 0e2f66e90c
Parse engine src path from an absolute --local-engine (#78496) 2021-03-18 11:50:38 -07:00
Jonah Williams d27666e058
[flutter_tools] migrate context to null safety (#78359) 2021-03-18 10:18:20 -07:00
Jonah Williams cdfe39556b
[flutter_tools] handle OSError 2 from current working directory (#78380) 2021-03-18 09:49:25 -07:00
Marcus Tomlinson 01c772cc8d
Revert "Add libblkid / liblzma / libgcrypt as an explicit dependancy on Linux" (#78415)
* Revert "Add libgcrypt as an explicit dependancy on Linux"

This reverts commit bf65b3d03c.

* libblkid & liblzma not explicitly required either
2021-03-18 09:14:44 -07:00
Anna Gringauze e8c3ce6bd1
Try fixing web tool tests on windows (#78386) 2021-03-17 22:13:13 -07:00
Jenn Magder 7dd752ace6
Add trace logging to local engine path autodetection (#78482) 2021-03-17 17:35:43 -07:00
Jonah Williams 4807f806e2
[flutter_tools] remove globals from logger (#78353) 2021-03-16 16:46:21 -07:00
Jenn Magder b3fa6eb6f5
Download platform artifacts from assemble if needed (#78272) 2021-03-16 13:48:04 -07:00
Jonah Williams 2584afd7ec
[flutter_tools] scaffolding for Windows UWP template (#78067) 2021-03-16 13:43:04 -07:00
Jenn Magder 61c848c1bd
Point "flutter build ipa --analyze-size" to archive app output (#78259) 2021-03-16 09:43:02 -07:00
Gary Qian 2a8b296ae9
[flutter_tools] Deferred components: Encode base module loading units in manifest metadata (#78079) 2021-03-15 15:58:06 -07:00
Gurjinder Partola 2e17a8e676
Fix avdmanager path detection (#78166) 2021-03-15 11:18:04 -07:00
omerlevran46 c94648f9cc
[fuchsia] remove no devices found from ffx parsing (#77651) 2021-03-15 10:58:05 -07:00
Jenn Magder c3d0f60407
Remove mock from cocoapods_validator_test (#77991) 2021-03-12 19:14:05 -08:00
Jonah Williams 9f420ffb3e
[flutter_tools] io cleanups to simplify null safety migration (#77955) 2021-03-12 16:21:14 -08:00
Jonah Williams a01f37245b
[flutter_tools] remove globals from terminal (#77953) 2021-03-12 12:53:05 -08:00
Marcus Tomlinson 82675474ea
Add libgcrypt as an explicit dependancy on Linux (#77926) 2021-03-12 07:50:03 -08:00
Jonah Williams d20ec4c7d8
[flutter_tools] read expression compilation results into memory before starting next compilation (#77867) 2021-03-11 22:18:51 -08:00
Jonah Williams 2daac9201a
[flutter_tools] simplify shutdown hooks (#77969) 2021-03-11 22:18:15 -08:00
Jonah Williams 32474dca20
[flutter_tools] provide more context for build_system invalidation (#77961) 2021-03-11 15:53:53 -08:00
Jonah Williams c6dbb6f2b5
Update mockito dep and remove usage in manual tests and localizations (#77945) 2021-03-11 11:25:02 -08:00
Jia Hao 9fdda01252
[flutter_tools] Generalize waitForExtension (#77220) 2021-03-11 07:31:25 +08:00
Jonah Williams 0cc087c2ae
[flutter_tools] migrate some base libraries to null safety (#77738) 2021-03-10 12:15:04 -08:00
Jenn Magder 08b225e03d
Implement iOS app install deltas (#77756) 2021-03-10 10:00:03 -08:00
Jonah Williams be8989f185
[flutter_tools] remove mock processes from batch compile_test (#77731) 2021-03-09 23:31:02 -08:00
Jonah Williams 233015572c
[flutter_tools] simplify platform null safety (#77727) 2021-03-09 12:52:57 -08:00
Jenn Magder 7b1aec70ae
Move iOS codesigning into assemble build target (#77664) 2021-03-09 11:45:16 -08:00
Jonah Williams d39d450594
[flutter_tools] remove most globals from resident web runner (#77432) 2021-03-08 14:38:26 -08:00
Jonah Williams acda272cf2
[flutter_tools] add tool feature/scaffold for UWP (#77399) 2021-03-08 08:09:04 -08:00
Michael Goderbauer cb867bbedc
Enable unnecessary_await_in_return lint (#77434) 2021-03-05 18:38:15 -08:00
Jenn Magder 8a9042ba91
archiveing -> archiving (#77424) 2021-03-05 18:34:03 -08:00
Michael Goderbauer 807bb29888
enable prefer_function_declarations_over_variables lint (#77398) 2021-03-05 18:29:04 -08:00
Jonah Williams 721702717d
[flutter_tools] replace MockFlutterVersion usage with fake where possible, move from context (#77390) 2021-03-05 14:04:03 -08:00
Jenn Magder 7e02cc34f9
Bitcode strip Flutter.framework in assemble build target (#77329) 2021-03-05 10:38:57 -08:00
Jenn Magder a7f7687a2e
Delete unzipped FlutterMacOS.framework before replacing artifact (#77316) 2021-03-04 19:36:21 -08:00
Gary Qian ee41782732
[flutter_tools] Deferred components build system (#76192) 2021-03-04 18:09:02 -08:00
Jonah Williams 81b9845041
[flutter_tools] migrate async_guard.dart to null safety (#76748) 2021-03-04 16:00:14 -08:00
Jonah Williams 90f353f9b1
[flutter_tools] dont crash when looking for AS4.1 on windows with no LOCALAPPDATA (#77261) 2021-03-04 11:29:20 -08:00
Michael Goderbauer 7b251f5f37
Enable use_function_type_syntax_for_parameters lint (#77163) 2021-03-04 08:59:17 -08:00
Jenn Magder eee0dc8441
Exclude arm64 from valid iOS simulators (#73828) 2021-03-03 18:58:37 -08:00
Jenn Magder 67b2ca893e
Update minimum required version to Xcode 12 (#77025) 2021-03-03 11:00:35 -08:00
William Oprandi 679b8c2982
Fix Android Studio detection and plugins on Linux (#75612) 2021-03-03 08:29:03 -08:00
Michael Goderbauer 6586a069bc
enable prefer_null_aware_operators (#77105) 2021-03-02 16:14:03 -08:00
Jonah Williams d14a9eaa8d
[flutter_tools] remove chrome launcher, analytics mock from web unit tests (#77066) 2021-03-02 15:29:03 -08:00
Michael Goderbauer fc99e7c0d7
Enable missing_whitespace_between_adjacent_strings (#77027) 2021-03-01 18:30:17 -08:00
Jenn Magder 3969e5b47b
Move iOS Flutter.framework thinning into copy assemble build target (#77007) 2021-03-01 15:45:02 -08:00
omerlevran46 f996033fcc
[fuchsia] - migrate devicer discovery workflows to use ffx (#76241) 2021-03-01 13:16:13 -08:00
Jenn Magder 2a54bb02aa
Opt into CocoaPods parallel codesigning (#76833) 2021-02-26 13:16:03 -08:00
Jonah Williams 666c950989
[flutter_tools] replace most MockBuildSystem instances with TestBuildSystem (#76821) 2021-02-26 08:46:00 -08:00
Jenn Magder 023582db33
Stop trying to thin iOS App.framework (#76834) 2021-02-25 18:49:12 -08:00
Jenn Magder d099ae60f0
Add ephemeral iOS directory to put future generated files (#76830) 2021-02-25 18:16:03 -08:00
Jenn Magder f5903a91e0
Remove dead ensureDirectoryExists (#76829) 2021-02-25 18:11:01 -08:00
Perqin 131f59f17e
[flutter_tools] Avoid duplicated calls to l10n generation (#76066) 2021-02-25 12:11:03 -08:00
Jenn Magder 5bc100da31
Move iOS framework thinning into the tool (#76665) 2021-02-24 18:02:43 -08:00
Gary Qian 9df362a73f
[flutter_tools] Refactor DeferredComponents validator and add build target (#76400) 2021-02-24 17:51:03 -08:00
Jonah Williams d60e9de75d
[flutter_tools] remove remaining extensions (#76743) 2021-02-24 16:46:03 -08:00
Jonah Williams a3b14c58ae
[flutter_tools] replace vm_service extension methods with wrapper class (#76721) 2021-02-24 15:40:33 -08:00
Jonah Williams f7823d58da
[flutter_tools] fix comment in resident web runner (#76724) 2021-02-24 14:06:02 -08:00
Jia Hao bc20f2ee88
[flutter_tools] Fail fast when test dependencies are missing (#76679) 2021-02-24 09:11:03 -08:00
Jonah Williams 8974cef1d9
[flutter_tools] enable experimental invaldation everywhere (#76618) 2021-02-24 08:16:02 -08:00
Emmanuel Garcia dadbd47d09
Disable clang format in the plugin registrants (#76662) 2021-02-23 23:36:04 -08:00
Jonah Williams bbaced6d12
[flutter_tools] cache adb path (#76650) 2021-02-23 17:26:02 -08:00
Jia Hao a341da6e0e
[flutter_tools] Don't stringify null values in EventPrinter (#76579) 2021-02-23 17:06:04 -08:00
Daniel Gomez 739adf3d3e
Add sharding options to test command line (#76382) 2021-02-23 16:26:03 -08:00
Emmanuel Garcia 098ece522d
Disable warnings for the dart plugin registrant (#76561) 2021-02-23 11:45:33 -08:00
Jonah Williams b678d0adec
[flutter_tools] remove globals and mocks from android gradle builder and test (#76416) 2021-02-19 21:07:43 -08:00
Jenn Magder 841f2e082e
Do not show plugin embedding warning with missing example app (#76406) 2021-02-19 17:41:02 -08:00
Jason Simmons 73ec544238
Update all packages and upgrade to path_provider 2.0.0-nullsafety (#76420) 2021-02-19 16:40:24 -08:00
Jonah Williams 75470a0051
[flutter_tools] unify gradle/android sdk reinitialize checks in cache.dart (#76342) 2021-02-19 13:47:12 -08:00
Emmanuel Garcia b7d4806243
Implement dartPluginClass support for plugins (#74469) 2021-02-19 09:22:45 -08:00
Jonah Williams 6b14558a68
[flutter_tools] remove global usage of flutterUsage from gradle (#76330) 2021-02-18 15:52:00 -08:00
Jonah Williams 04182572f7
[flutter_tools] allow bypassing context for FlutterProject creation, remove fromPath (#76258) 2021-02-18 12:36:04 -08:00
Gary Qian ba5cc2cba4
[flutter_tools] Deferred components setup validator (#75739) 2021-02-18 12:01:03 -08:00
Jonah Williams bfcb43d2fc
[flutter_tools] remove local engine from globals in gradle (#76277) 2021-02-18 11:30:44 -08:00
Jonah Williams 555721de24
[flutter_tools] remove mock process manager from gradle tests (#76252) 2021-02-17 17:00:12 -08:00
Jonah Williams 93e7d34dc4
[flutter_tools] Remove globals/mocks from GradleUtils (#76020) 2021-02-17 14:26:57 -08:00
Danny Tuppeny 74b6ce9abb
Pass --run-skipped through to package:test (#76133) 2021-02-17 12:51:02 -08:00
Jia Hao 9e55af5246
[flutter_tools] Decouple FlutterPlatform from Process (#74236) 2021-02-17 10:06:04 -08:00
omerlevran46 75c853c8e7
[fuchsia] - update getting local host address logic (#75981) 2021-02-16 16:36:03 -08:00
Jonah Williams 7088c5ba2a
Update all packages (#76143) 2021-02-16 15:29:12 -08:00
Jonah Williams 65599e2825
[flutter_tools] use less path manipulation in the Android SDK (#75930) 2021-02-16 13:54:44 -08:00
Jonah Williams 820fb0bf2b
[flutter_tools] stop using throttled print for service extensions (#76022) 2021-02-16 12:11:57 -08:00
Jonah Williams 46b8ea8fe6
[flutter_tools] use temp dir for tester dill, use desktop log reader (#75922)
On windows, its not possible to run 2 integration tests using flutter-tester simultaneously. This is due to the flutter tester using a fixed location for its dill output. Use a temp dir instead.

Also replace the custom log reader in flutter-tester with the desktop log reader, and ensure stopApp waits for the process exit code.

Fixes #75534
2021-02-16 10:18:04 -08:00
stuartmorgan 13d051f2f4
Update link for missing desktop projects (#76123) 2021-02-16 09:51:03 -08:00
Ian Hickson ce318b7b53
All arguments must be documented. (#75888) 2021-02-14 12:56:05 -08:00
Jonah Williams dce8f71228
[flutter_tools] do not use context logger in gradle (#75940) 2021-02-12 17:38:52 -08:00
Hidenori Matsubayashi 4cc0ab2d19
[flutter_tools] Add ARM64 Linux host and cross-building option support (#61221) 2021-02-12 14:25:30 -08:00
Jonah Williams 97a9f2ae93
[flutter_tools] move gradle helper methods into AndroidBuilder class body, split unit tests (#75931) 2021-02-12 14:24:13 -08:00
Jonah Williams fb808b40f9
[flutter_tools] add package:http to forbidden imports test (#75925) 2021-02-12 14:23:08 -08:00
Jonah Williams 980880e2b6
[flutter_tools] remove package HTTP and add pub.dev head check tests (#75871) 2021-02-12 10:44:19 -08:00
Jenn Magder ba5e237e24
Avoid duplicating Pods-Runner xcconfig #includes (#75822) 2021-02-11 14:11:15 -08:00
mx1up cc95c972b7
properly pass on gradle exit code (#71484) (#71582) 2021-02-11 14:11:03 -08:00
Yegor e7953b3be4
[web] new service worker loading mechanism (#75535) 2021-02-11 09:16:21 -08:00
Jonah Williams 7ab8517f7e
[flutter_tools] refactor devtools handler to expose single method for run/attach and restart (#75807) 2021-02-10 17:04:47 -08:00
Jonah Williams b05d6ec8d3
[flutter_tools] catch error 32 in cache (#75719) 2021-02-10 17:04:32 -08:00
Ian Hickson b1cc48748d
Only write the pid-file while listening to SIGUSR signals. (#74533) 2021-02-10 16:06:05 -08:00
Jenn Magder 8f3a6245f0
Consolidate ascii spinner stop in devtools activation (#75679) 2021-02-09 16:06:35 -08:00
Jonah Williams 8df58eb650
[flutter_tools] use a single fake implementation of HttpClient (#75471) 2021-02-09 15:32:03 -08:00
Jonah Williams 645cb64392
[flutter_tools] do not crash if shared profile restoration fails (#75718) 2021-02-09 15:31:48 -08:00
Jonah Williams 3aece33534
[flutter_tools] refactor devtools handler into its own class (#75444) 2021-02-09 15:31:39 -08:00
Gary Qian 81530744bf
flutter_tool: DeferredComponent and LoadingUnit classes, Manifest deferred-components parsing (#75394) 2021-02-09 10:02:13 -08:00
Jonah Williams 021311ed8a
Revert "[flutter_tools] move process manager into tool (#75350)" (#75639)
This reverts commit 8b6baae44c.
2021-02-08 09:21:46 -08:00
godofredoc da6528cda6
Point to a new artifacts location. (#70673)
This is in preparation to move the flutter artifacts to a more secure
location.

Bug:
  go/fxb/64576
2021-02-04 18:44:47 -08:00
Jonah Williams 8b6baae44c
[flutter_tools] move process manager into tool (#75350)
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Dan Field bc1cf49458
roll packages (#75370) 2021-02-04 11:41:03 -08:00
Jenn Magder 7a8bbbd807
Install prebuilt iOS app only once (#75387) 2021-02-04 10:19:37 -08:00
Jonah Williams 24d8dbb1e5
[flutter_tools] remove web defines workaround (#75361) 2021-02-03 15:14:59 -08:00
Jenn Magder 7711c1ef8f
Suggest precache instead of build when engine artifacts are missing (#75351) 2021-02-03 13:14:38 -08:00
Shi-Hao Hong 16913b07e8
Relands "[gen-l10n] Fixes named and positional parameter issue with NumberFormat when type is specified" (#75346)
*  Added a new template for [NumberFo
rmat] with positional parameter(s)

* 🔨 Renamed [numberFormatTemplate] to [numberFormatNamedTemplate]

* [gen-l10n] Fixed generation error for namedParameters and optionalParameters

* [gen-l10n] Fixed string value generation for optional parameter

* [gen-l10n-test] Added new tests for `decimalPattern`, `percentPattern`, `scientificPattern` and formats with optional parameters.

* 🔨 Removed trailing whitespaces

* 🔨 replaced [_generateStringParameterValue] with [generateString]

* 🔨 Specified variable types in NumberFormat templates.

*  Added a new template for [NumberFo
rmat] with positional parameter(s)

* 🔨 Renamed [numberFormatTemplate] to [numberFormatNamedTemplate]

* [gen-l10n] Fixed generation error for namedParameters and optionalParameters

* [gen-l10n] Fixed string value generation for optional parameter

* [gen-l10n-test] Added new tests for `decimalPattern`, `percentPattern`, `scientificPattern` and formats with optional parameters.

* 🔨 Removed trailing whitespaces

* 🔨 replaced [_generateStringParameterValue] with [generateString]

* 🔨 Specified variable types in NumberFormat templates.

* [gen-l10n]  added test for parameter having special characters in string value.

* Accidental tab added to integration test

Co-authored-by: arish <arishsultan104@gmail.com>
2021-02-04 03:31:22 +08:00
Jenn Magder 3f163d29a4
Return an empty FlutterViews list when the service disappears (#75301) 2021-02-03 11:01:03 -08:00
Jonah Williams dcd061c70b
[flutter_tools] experiment with skipping process resolution (#74447) 2021-02-03 10:56:22 -08:00
Jonah Williams deb5e40f53
[flutter_tools] handle null package (#75336) 2021-02-03 10:53:30 -08:00
Jonah Williams 3b884aa613
Catch VM Service disappearance from run/attach handler code (#75298) 2021-02-03 10:53:15 -08:00
Jia Hao efd487922d
[flutter_tools] Merge some test options into DebuggingOptions (#75213) 2021-02-02 19:31:03 -08:00
Shi-Hao Hong c12b53e073
Revert "[gen-l10n] Fixes named and positional parameter issue with NumberFormat when type is specified (#75209)" (#75306)
This reverts commit 917577b808.
2021-02-03 10:32:01 +08:00
Shi-Hao Hong 917577b808
[gen-l10n] Fixes named and positional parameter issue with NumberFormat when type is specified (#75209) 2021-02-02 17:06:05 -08:00
Vyacheslav Egorov 4ba26191ea
Add support for producing unstripped AOT snapshots. (#75243) 2021-02-02 09:16:04 -08:00
Jonah Williams 44d5950d27
[flutter_tools] switch dart defines to base64 to avoid windows control characters (#75027)
= gets escaped into %3D which seems to be tripping up cmake on windows since % is a control character. Switch to base64 encoding, since this does not have % nor , in the output character set.

This change is not trivially cherry pickable, and isn't tested on windows aside from my local, manual tests due to the planned CI work not being complete yet.

Fixes #75017
Fixes #74705
2021-02-02 09:10:48 -08:00
Jonah Williams aebf548436
[flutter_tools] skip web renderer defines unless web target is picked (#75160) 2021-02-02 09:05:44 -08:00
Jenn Magder 73506f36f7
Replace MockConfig with TestConfig (#75044) 2021-02-01 18:16:05 -08:00
Ian Hickson 8acac060bf
Remove the timeout when launching DevTools (#74859) 2021-02-01 16:06:02 -08:00
Ian Hickson ac3b9e7f89
Unpin mysteriously pinned packages (#74885) 2021-02-01 14:31:03 -08:00
Michael Goderbauer 0e815a1b87
Bump flutter_gallery_assets (#75026) 2021-02-01 04:51:04 -08:00
Jenn Magder 6ecb8cbcfa
Replace MockUsage with TestUsage (#74946) 2021-01-28 18:49:04 -08:00
Dan Field 5575caa118
vm_service 6.0.1-nullsafety.1, dwds 8.0.2 (#74943) 2021-01-28 18:39:07 -08:00
Jenn Magder bf248fade2
Allow 'flutter create' in dev and example directories (#74932) 2021-01-28 15:24:09 -08:00
Jia Hao 234952cf29
[flutter_tools] Simplify flutter test internals (#74176) 2021-01-28 15:24:04 -08:00
Darshan Rander 7c22f0d214
Added warning when not enabled platform is selected (#73205) 2021-01-28 13:54:04 -08:00
Jonah Williams b926c7b696
[flutter_tools] rewrite Usage.test to capture objects instead of print logs (#74829) 2021-01-28 12:41:14 -08:00
Ian Hickson 29e604e241
Update packages (#74874) 2021-01-28 00:04:03 -08:00
Jenn Magder 51b3edd45f
Revert "Remove package image dependency (#74763)" (#74869)
This reverts commit ca2d7b3d3c.
2021-01-27 19:50:58 -08:00
Ian Hickson ca2d7b3d3c
Remove package image dependency (#74763) 2021-01-27 17:19:03 -08:00
Jonah Williams 74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. (#74832)
* opt out the flutter tool

* oops EOF

* fix import

* Update tool_backend.dart

* Update daemon_client.dart

* fix more
2021-01-27 15:17:53 -08:00
Michael Goderbauer 63267e9016
Make flutter create --smaple null-safe (#74844) 2021-01-27 14:44:03 -08:00
Jonah Williams 91437a0641
[flutter_tools] delete old directories when unzipping ontop of them (#74818)
Fixes #74772

stale files from previous SDKs were getting left in the cache, confusing the analyzer.
2021-01-27 12:56:21 -08:00
Jenn Magder 675fd5540e
Replace MockXcode with Xcode.test in unit tests (#74777) 2021-01-27 11:04:03 -08:00
Jonah Williams 4a1445bb1d
[flutter_tools] handle further devtools NPE (#74764) 2021-01-27 09:11:26 -08:00
Jonah Williams fa8bf67cb6
[flutter_tools] catch errors when getting cwd (#74744) 2021-01-26 12:49:03 -08:00
Dan Field d1538320d2
Roll packages to null safe (vm_service, test, etc.) (#74671) 2021-01-26 09:15:54 -08:00
Jia Hao 22f1700427
[flutter_tools] Make setting of CWD consistent for flutter test (#74622) 2021-01-25 22:34:03 -08:00
Jonah Williams efcf2c664e
[flutter_tools] check if process manager can find adb (#74672) 2021-01-25 14:15:23 -08:00
Ben Konyi 92427f260a
Handle 'Existing VM service clients' error from old VM service instances (#74665) 2021-01-25 12:29:05 -08:00
Jonah Williams 9ba06b4d3b
[flutter_tools] handle waitForExtension having no isolates (#74664) 2021-01-25 11:54:03 -08:00
Ian Hickson 5d8dfa44b6
Don't crash on narrow window widths (#74365) 2021-01-25 11:39:45 -08:00
Jenn Magder c8e8d55365
Allow tests to override _DevFSHttpWriter._startWrite throttle time (#74545) 2021-01-25 10:58:26 -08:00
Jenn Magder 9baca0c3d7
Fail ColdRunner.attach() eagerly when device connection fails (#74543) 2021-01-25 10:54:05 -08:00
Kenzie Schmoll c89d649847
Add connectedVmServiceUri service extension and set from flutter_tools (#74534)
* Add connectedVmServiceUri service extension and set from flutter_tools
2021-01-25 10:40:14 -08:00
Zachary Anderson 2007186d2e
Reland: Handle more cases where the tool receives RPCError 112 (#74602)
* Reland: Handle more cases where the tool receives RPCError 112

* Add null-aware access
2021-01-24 12:54:00 -08:00
Zachary Anderson 6be4d1c8bf
Revert "Handle more cases where the tool receives RPCError 112 (#74574)" (#74601)
This reverts commit c87f15fe09.
2021-01-24 09:52:27 -08:00
Zachary Anderson c87f15fe09
Handle more cases where the tool receives RPCError 112 (#74574) 2021-01-23 23:11:15 -08:00
Jonah Williams c2cd4ef35c
[flutter_tools] ensure unstable compiler features are not available on stable (#74526) 2021-01-22 18:11:59 -08:00
Ben Konyi 35b9288e13
Handle RPCError when VM service disappears while invoking VmService.getIsolate (#74528)
* Handle RPCError when VM service disappears while invoking `VmService.getIsolate`

* Add test
2021-01-22 17:21:39 -08:00
Jonah Williams e599cdd414
[flutter_tools] fix web messaging (#74513) 2021-01-22 11:07:08 -08:00
Jonah Williams 1d3f697160
[flutter_tools] flag flip (#74444) 2021-01-22 09:29:57 -08:00
Jonah Williams 32db0fe791
[flutter_tools] provide correct sources and metadata for different base hrefs (#74452) 2021-01-21 23:04:03 -08:00
Ben Konyi 08068fd94c
Handle service disappeared RPCError when VM service connection disappears (#74424)
* Handle service disappeared RPCError when VM service connection
disappears while invoking a service extension registered by the
framework

* Add unit test, handle non-trivial cases
2021-01-21 22:51:03 -08:00
Kenzie Schmoll 75dc45aba3
Fix bugs with ext.flutter.activeDevToolsServerAddress (#74423) 2021-01-21 11:51:02 -08:00
Kenzie Schmoll b45088c0cf
Print DevTools inspector links in RenderFlex Overflow errors (#74251) 2021-01-21 02:59:04 -08:00
stuartmorgan 5aa6cba31d
Adjust desktop feature flag (#74348)
Prep to make https://github.com/flutter/flutter/issues/73857 easier in the future.
2021-01-20 19:22:08 -08:00
Jonah Williams 851ff68788
[flutter_tools] throwToolExit from archive failure (#74259) 2021-01-20 15:17:58 -08:00
Ben Konyi e2e3976a12
Roll package:dds to 1.7.3 and add error handling for VM service disappearing (#74272) 2021-01-20 10:49:13 -08:00
Michael Thomsen 914c9aa304
Rephrase null safety mode (#74306) 2021-01-20 19:42:16 +01:00
Kenzie Schmoll 118f61230a
Return the existing DevTools server from DevToolsLauncher.serve if one is already running. (#74271)
* Return the existing DevTools server from DevToolsLauncher.serve if one is already running.
2021-01-20 10:38:49 -08:00
Nate Bosch dcc4fdd558
Pass only Uri to package:http APIs (#74285) 2021-01-20 09:59:03 -08:00
Sigurd Meldgaard 178c87cc27
Avoid relative paths in .dart_tool/package_config.json when generate:true (#73944)
Instead of using package:package_config to write the .dart_tool/package_config the original json is modified and rewritten.

The .dart_tool/package_config.json file is read twice to simplify control flow.

This also avoids the issue of package:package_config writing directly to local filesystem.
2021-01-20 14:53:49 +01:00
Jia Hao b362d6f480
[flutter_tools] Fix ignoring of Flutter tester exitCode (#74293) 2021-01-20 18:47:51 +08:00
Ben Konyi 913d5933c1
Check VM service URI is valid before attempting to start DDS (Re-upload #73998) (#74280) 2021-01-19 22:34:03 -08:00
Jonah Williams d325705332
[flutter_tools] pub get skips example dir if there is no pubspec.yaml (#74264) 2021-01-19 15:02:36 -08:00
Michael Goderbauer 2f7804f41b
Add null safety note to flutter create (#74265) 2021-01-19 14:52:43 -08:00
Jonah Williams a0be98020e
[flutter_tools] ensure pub get can run from partially valid state (#74249) 2021-01-19 12:29:07 -08:00
Jonah Williams fc59f01ea8
[flutter_tools] ensure allowExistingDdsInstance param is always non-null (#74091) 2021-01-15 18:04:40 -08:00
Jonas Finnemann Jensen bf89943d94
Fix pub upgrade to work with new arguments (#74060) 2021-01-15 17:39:56 -08:00
Jonah Williams 32e1e00e2e
[flutter_tools] handle NPE in language analytics (#74075) 2021-01-15 14:54:04 -08:00
Jenn Magder 17edb9aa8c
Build x86_64 iOS apps with simulator local engines (#74003) 2021-01-15 14:47:14 -08:00
Jonah Williams 7ee910b0a8
[flutter_tools] ensure --dart-define can parse args with commas (#73798) 2021-01-15 13:51:32 -08:00
Niklas Schulze afe790775b
[flutter_tools] copy flutter_texture_registrar.h header on Windows (#61098) 2021-01-15 16:20:57 -05:00
Jonah Williams 8d72307c47
[flutter_tools] allow applications to specify additional license files to be bundled into the application NOTICES automatically (#73430) 2021-01-14 16:59:04 -08:00
J-P Nurmi e1ff62a78c
[flutter_tools] propagate build errors from the backend (#72196) 2021-01-14 13:39:05 -08:00
Jonah Williams 68d8c4b3bb
[flutter_tools] open chrome to correct base URL (#73962) 2021-01-14 12:16:32 -08:00
Jonah Williams bf4a5484aa
[flutter_tools] no-op maven artifacts if Android SDK is absent (#73957) 2021-01-14 12:09:06 -08:00
Jenn Magder b29a6bc56b
Use SDK podhelper in add-to-app module Podfile (#73072) 2021-01-14 10:15:24 -08:00
Jenn Magder 912c3ab171
Revert "Revert "[flutter_tools] Serve DevTools at app start (#73366)" (#73896)" (#73903)
This reverts commit 388dcd2478.
2021-01-13 15:36:43 -08:00
Jonah Williams abb48f495b
[flutter_tools] add error handling wrapping for File.createSync (#73890) 2021-01-13 14:25:37 -08:00
Jonah Williams 1eb0bb52e1
[flutter_tools] dont crash on invalid utf8 in pubspec (#73891) 2021-01-13 14:25:16 -08:00
Jonah Williams d4f0c08261
[flutter_tools] do not crash if target file cannot be read for language version (#73879) 2021-01-13 14:24:04 -08:00
Jonah Williams b1e99182a8
Move async guard wrapping of crash reporter up a level (#73877) 2021-01-13 14:14:07 -08:00
Jenn Magder 388dcd2478
Revert "[flutter_tools] Serve DevTools at app start (#73366)" (#73896)
This reverts commit 1cb0a24a46.
2021-01-13 13:57:09 -08:00
Claire Davis 546b521f33
[flutter_tools] Sort plugins alphabetically when refreshed (#73803) 2021-01-13 09:41:16 -08:00
Kenzie Schmoll 1cb0a24a46
[flutter_tools] Serve DevTools at app start (#73366)
* [flutter_tools] Serve DevTools at app start
2021-01-12 21:39:27 -08:00
Jenn Magder 7c75c01fc3
Add recommended Xcode version to doctor (#73808) 2021-01-12 19:01:18 -08:00
Jenn Magder f63055a895
Revert "Exclude arm64 from valid iOS simulators (#73755)" (#73807)
This reverts commit 201e5e4ecb.
2021-01-12 13:02:46 -08:00
Sam Rawlins f70ad37ec9
Remove "unnecessary" imports. (#73488) 2021-01-12 11:59:03 -08:00
Jenn Magder 201e5e4ecb
Exclude arm64 from valid iOS simulators (#73755) 2021-01-12 10:35:24 -08:00
Jonah Williams 907bed6982
[flutter_tools] daemon does not report platforms that are not enabled (#73736) 2021-01-12 09:38:23 -08:00
Jonah Williams f7dc19eb23
[flutter_tools] flutter precache downloads all enabled platforms if no flags are provided (#73733) 2021-01-11 14:29:02 -08:00
Jenn Magder 9a83314cfe
Generate dSYM files during iOS archive (#73630) 2021-01-11 12:42:31 -08:00
Ferhat 0c80a31256
[web] Reland - Switch flutter tool web-renderer default for web to auto (#73595) 2021-01-08 15:44:13 -08:00
Jonah Williams 25dd8684b1
[flutter_tools] add 483 to non-recoverable errors (#73579) 2021-01-08 11:56:13 -08:00
Jonah Williams df98145548
[flutter_tools] add API for passing arbitrary flags to tester binary (#73576) 2021-01-08 11:46:15 -08:00
Jenn Magder 1fdf60a2ed
Revert "[web] Switch flutter tool web-renderer default for web to auto (#73502)" (#73529)
This reverts commit d4c77f31ef.
2021-01-07 18:08:03 -08:00
Michael Goderbauer 5d1306e7ab
Update outdated links (#73514) 2021-01-07 16:28:12 -08:00
Jenn Magder 45d71e25ab
Build iOS apps using Swift Packages (#73508) 2021-01-07 15:59:09 -08:00
Ferhat d4c77f31ef
[web] Switch flutter tool web-renderer default for web to auto (#73502) 2021-01-07 15:54:04 -08:00
Gary Roumanis 705811fee2
Fix launching DevTools with Flutter Web applications (#72110) 2021-01-07 15:49:09 -08:00
Jenn Magder f596fdc008
Revert "Exclude arm64 from valid iOS simulators (#73458)" (#73511)
This reverts commit 273630c09d.
2021-01-07 14:06:32 -08:00
Jenn Magder bc7286f118
Use simctl exit code instead of stderr (#73070) 2021-01-07 13:13:56 -08:00
Jenn Magder 273630c09d
Exclude arm64 from valid iOS simulators (#73458) 2021-01-07 13:03:52 -08:00
xster e0dcb787dc
groovy escaping was wrong for aar (#72554) 2021-01-07 11:43:27 -08:00
Jonah Williams ed66037f51
[flutter_tools] describe current null safety build mode (#73426) 2021-01-07 10:26:51 -08:00
Jonah Williams 50dfd137ef
[flutter_tools] prevent hot reload/restart if device has not finished devFS initialization (#73420) 2021-01-06 15:54:04 -08:00
Jenn Magder 74d58105d1
Revert "Build iOS apps using Swift Packages (#72761)" (#73437)
This reverts commit 28db5a0fae.
2021-01-06 15:04:16 -08:00
Jenn Magder 6891928a1f
Optionally include CocoaPods xcconfig (#73112) 2021-01-06 13:55:23 -08:00
Jenn Magder 28db5a0fae
Build iOS apps using Swift Packages (#72761) 2021-01-06 13:54:53 -08:00
Jenn Magder 3082a2806e
build ios-framework simulator slices for profile/release (#73378) 2021-01-06 12:12:23 -08:00
Jenn Magder e21d822074
Remove build ios-framework --universal flag (#73383) 2021-01-06 11:14:05 -08:00
Ferhat 161dde55c9
Fix offline resource loader for serviceworker (#73416) 2021-01-06 10:47:20 -08:00
Jonah Williams 66175760be
[flutter_tools] delete .packages during flutter clean (#73364) 2021-01-05 18:54:03 -08:00
Jonah Williams c2ce0e68c6
[flutter_tools] prevent NPE due to moved/deleted packages during upgrade packages (#73357) 2021-01-05 18:49:02 -08:00
Jonah Williams 7c618758bb
[flutter_tools] delegate first run message re-display to new class, only if changed (#73353) 2021-01-05 18:44:04 -08:00
Jia Hao 47bad77287
Support flutter_test_config for flutter test on web platforms (#72488) 2021-01-05 15:49:02 -08:00
nturgut 985e5ff324
[web] add web-renderer option to flutter test. run web tests with this option (#73069)
* add web-renderer option to flutter test. run web tests with this option

* remove debug lines
2021-01-05 10:57:01 -08:00
Shi-Hao Hong a912030982
[gen_l10n] Use l10n.yaml file instead of command line arguments if it exists (#72950)
* Reorganize files

* Use l10n.yaml instead of command line args
2021-01-05 11:50:32 +08:00
Shi-Hao Hong 4d663472e2
[gen_l10n] Improve status message when untranslated messages are still present (#72944) 2021-01-04 01:54:02 -08:00
Jenn Magder 6118eaa0de
Check for iOS simulator SDK during AOT validation instead of assuming x86 (#72834) 2020-12-23 15:36:20 -08:00
Ben Konyi 620a8284f8
Catch StateError and output more useful error message when DDS fails to start (#72736) 2020-12-22 10:24:04 -08:00
Jenn Magder 7aacff2216
Exclude ARM from macOS builds (#72748) 2020-12-21 16:05:24 -08:00
J-P Nurmi f2536da16f
[flutter_tools] Let CMake handle escaping (#70026) 2020-12-21 16:04:04 -08:00
J-P Nurmi bd08997474
[flutter_tools] catch fatal build output errors on Linux (#72559) 2020-12-21 10:24:03 -08:00
J-P Nurmi 612ef20955
[flutter_tools] use 1-based index for device selection (#72189) 2020-12-21 09:29:05 -08:00
Kenzie Schmoll b793285329
Add --no-launch-browser flag to DevTools pub run command (#72519) 2020-12-18 10:14:36 -08:00
Jenn Magder ff8203dcdc
Migrate usage value plugin count off .flutter-plugins (#72538) 2020-12-17 14:56:05 -08:00
Jenn Magder d6857bc026
Build/copy macOS frameworks to built products instead of ephemeral directory (#72378) 2020-12-17 14:47:05 -08:00
Jenn Magder 1c18cf3da8
Move macOS Podfile logic into the tool (#72020) 2020-12-17 11:48:16 -08:00
Jenn Magder 23f5fbc69d
Update CocoaPods minimum version to 1.9 (#71170) 2020-12-17 10:22:50 -08:00
creativecreatorormaybenot 9ff4326e1f
Test generated_plugin_registrant analysis & suppress long lines in web plugin registrant (#71981) 2020-12-16 22:19:05 -08:00
Jenn Magder cdacae89e1
Revert "Launch named iOS simulators (#72323)" (#72447)
This reverts commit 84a7a611b0.
2020-12-16 11:52:59 -08:00