Consolidate ascii spinner stop in devtools activation (#75679)

This commit is contained in:
Jenn Magder 2021-02-09 16:06:35 -08:00 committed by GitHub
parent b854116333
commit 8f3a6245f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -153,18 +153,17 @@ class DevtoolsServerLauncher extends DevtoolsLauncher {
'devtools'
]);
if (_devToolsActivateProcess.exitCode != 0) {
status.cancel();
_logger.printError('Error running `pub global activate '
'devtools`:\n${_devToolsActivateProcess.stderr}');
return false;
}
status.stop();
_persistentToolState.lastDevToolsActivationTime = DateTime.now();
return true;
} on Exception catch (e, _) {
status.stop();
_logger.printError('Error running `pub global activate devtools`: $e');
return false;
} finally {
status.stop();
}
}