development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 03:32:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Install prebuilt iOS app only once (#75387)

Browse source
This commit is contained in:
Jenn Magder 2021-02-04 10:19:37 -08:00 committed by GitHub
parent 7aa17231ac
commit 7a8bbbd807
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/flutter_tools/lib/src/ios/devices.dart
View file

@ -332,10 +332,6 @@ class IOSDevice extends Device {
return LaunchResult.failed();
}
packageId = buildResult.xcodeBuildExecution?.buildSettings['PRODUCT_BUNDLE_IDENTIFIER'];
} else {
if (!await installApp(package)) {
return LaunchResult.failed();
}
}
packageId ??= package.id;

19
packages/flutter_tools/test/general.shard/ios/ios_device_start_prebuilt_test.dart
View file

@ -27,21 +27,6 @@ import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fakes.dart';
const FakeCommand kDeployCommand = FakeCommand(
command: <String>[
'Artifact.iosDeploy.TargetPlatform.ios',
'--id',
'123',
'--bundle',
'/',
'--no-wifi',
],
environment: <String, String>{
'PATH': '/usr/bin:null',
'DYLD_LIBRARY_PATH': '/path/to/libraries',
}
);
// The command used to actually launch the app with args in release/profile.
const FakeCommand kLaunchReleaseCommand = FakeCommand(
command: <String>[
@ -123,7 +108,6 @@ void main() {
testWithoutContext('IOSDevice.startApp attaches in debug mode via log reading on iOS 13+', () async {
final FileSystem fileSystem = MemoryFileSystem.test();
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[
kDeployCommand,
kAttachDebuggerCommand,
]);
final IOSDevice device = setUpIOSDevice(
@ -160,7 +144,6 @@ void main() {
testWithoutContext('IOSDevice.startApp launches in debug mode via log reading on <iOS 13', () async {
final FileSystem fileSystem = MemoryFileSystem.test();
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[
kDeployCommand,
kLaunchDebugCommand,
]);
final IOSDevice device = setUpIOSDevice(
@ -198,7 +181,6 @@ void main() {
testWithoutContext('IOSDevice.startApp succeeds in release mode', () async {
final FileSystem fileSystem = MemoryFileSystem.test();
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[
kDeployCommand,
kLaunchReleaseCommand,
]);
final IOSDevice device = setUpIOSDevice(
@ -226,7 +208,6 @@ void main() {
testWithoutContext('IOSDevice.startApp forwards all supported debugging options', () async {
final FileSystem fileSystem = MemoryFileSystem.test();
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[
kDeployCommand,
FakeCommand(
command: <String>[
'script',