Todd Volkert
535523dbe0
Add docs to FormFieldValidator ( #30645 )
...
To describe what its return value represents
2019-04-07 21:00:53 -07:00
Dan Field
d42db56b52
Add sample for ValueListenableBuilder ( #30626 )
...
* Add sample for ValueListenableBuilder
2019-04-06 20:14:41 -07:00
Hans Muller
ab06d033ca
Fixed a typo in the Expanded API doc ( #30563 )
2019-04-05 17:40:38 -07:00
LongCatIsLooong
e153883d43
Provide a default IconTheme in CupertinoTheme ( #30521 )
...
-* Inserted an `IconTheme` widget under `CupertinoTheme` to provide a default icon color when using `CupertinoTheme`.
* Changed `CupertinoTheme` to a `StatelessWidget`, to match the implementation of `Theme`
* Changed the nesting order of `Theme`'s sub widgets, to let `Theme.iconTheme` take precedence, so that `Theme`'s behavior is kept as is.
2019-04-05 15:57:29 -07:00
Tim Sneath
529189791c
Replace flutter.io with flutter.dev ( #30562 )
2019-04-05 11:39:30 -07:00
chunhtai
2b7e98973a
Fix issue 21640: Assertion Error : '_listenerAttached': is not true ( #30513 )
2019-04-05 11:31:40 -07:00
Alexandre Ardhuin
32f1b810ae
shorter nullable list duplications ( #30305 )
2019-04-05 10:23:35 -07:00
Tong Mu
1ae32facfe
Correctly synthesise event buttons ( #30535 )
...
* Correctly synthesise buttons, and add tests
2019-04-05 09:53:40 -07:00
Justin McCandless
566ac3ce2f
Trackpad mode crash fix ( #30475 )
...
Fixes a crash that happened when attempting to select text in trackpad mode on iOS.
2019-04-05 09:35:26 -07:00
Wai Hon Law
e8d968ed8d
Update repair command for Arch Linux ( #30428 )
...
The current repair command for Arch Linux is no longer valid because
`lib32-libstdc++5` had been removed from multilib.
Actually, `lib32-gcc-libs` from core just work.
Also see https://github.com/flutter/flutter/issues/25035
2019-04-05 07:55:29 -07:00
Hans Muller
73687a9771
Correct MaterialButton disabledColor ( #30531 )
2019-04-04 18:05:55 -07:00
xster
d15b3b1c8b
Cupertino localization step 5: add french arb as translated example ( #29708 )
2019-04-04 15:14:46 -07:00
Tong Mu
13101c1a86
Touching the screen adds 0x01
to buttons ( #30457 )
...
* Add constants `kPrimaryButton`, `kTouchContact` and `kStylusContact`
* PointerDownEvent and PointerMoveEvent will always set the 0x01 bit on buttons
2019-04-04 15:11:29 -07:00
Morgan
74ee010b7b
Fix MaterialApp's _navigatorObserver when only builder used ( #29413 )
...
Fix MaterialApp's _navigatorObserver so it doesn't cause WidgetApp's assertion to fail when using custom navigator, fixes #18904
2019-04-04 15:02:11 -07:00
Kate Lovett
05d1a10592
Embedding the diagram for BottomNavigationBar. ( #30468 )
2019-04-04 14:17:14 -07:00
Tong Mu
423cf223d9
Fix edge cases of PointerEventConverter ( #29998 )
...
* Fix: ui.PointerChange.remove might contain position change, but we used to expand it into a Cancel and Remove, neither of which allows position change. A Hover event is added, and a test is updated accordingly.
* Fixed the issue where a PointerMoveEvent and a PointerCancelEvent do not receive the correct pressure.
* Refactor the calculation of delta into deltaTo.
2019-04-04 10:27:07 -07:00
Shi-Hao Hong
1e50518cdc
Add ExpansionPanelList and ExpansionPanelList.radio Examples ( #30343 )
2019-04-04 07:12:56 -07:00
Nikita
88d50f78f3
Implement compute for async function ( #16265 ) ( #30275 )
2019-04-04 00:17:26 -07:00
Kate Lovett
0c01a557df
Embedding new raised button diagram. ( #30398 )
2019-04-04 00:14:40 -07:00
Kate Lovett
31086faa28
Updating sample code for BottomNavigationBar class for diagram. ( #30453 )
2019-04-04 00:14:12 -07:00
Michael Goderbauer
77bbd28c62
Random trivial fixes in the animation packages ( #30276 )
2019-04-04 00:13:34 -07:00
Michael Goderbauer
3c8dabefe7
Be more explicit when ValueNotifier notifies ( #30461 )
2019-04-04 00:13:07 -07:00
Zachary Anderson
39ebae2bab
[fuchsia] Fix isolate filter ( #30458 )
2019-04-03 21:14:37 -07:00
liyuqian
16a16e6598
Revert "Error message for setting shaderWarmUp too late ( #30145 )" ( #30463 )
...
This reverts commit ffbb335e35
.
Reason for revert: flutter driver tests may have bugs in getting
first frame. Revert this until we figure out what happened.
2019-04-03 15:38:31 -07:00
Michael Goderbauer
5493fe469e
Moar Videos ( #30452 )
2019-04-03 12:49:13 -07:00
Michael Goderbauer
516ffd0c09
Add 29 Widget of the Week videos ( #30415 )
2019-04-03 12:48:37 -07:00
Vyacheslav Egorov
01e3496ad9
Introduce --report-timings flag for flutter build aot command. ( #30032 )
...
This flag makes flutter build aot report timings for substeps (e.g.
frontend compilation and gen_snapshot) in a machine readable form.
2019-04-03 12:12:18 +02:00
Dan Field
069aabfe95
Draggable Scrollable sheet ( #30058 )
...
* Draggable Scrollable sheet
2019-04-02 18:07:30 -07:00
Amir Hardon
b6afc16a96
Make sure _handleAppFrame is only registered once per frame ( #30346 )
...
There were 2 possible scenarios in which _handleAppFrame is added more than once as a frame callback. When this happens it is possible that the second invocation will try to access _nextFrame.image when _nextFrame is null and crash. The 2 scenarios are:
Scenario 1
A GIF frame is decoded and a Flutter frame is executed before it's time to show the next GIF frame.
The timer that's waiting for enough time to elapse is invoked, and schedules a callback for the next Flutter frame(here).
Before the next Flutter frame is executed, MultiFrameImageStreamCompleter#removeListener is called followed by ``MultiFrameImageStreamCompleter#addListenerthat is invoking_decodeNextFrameAndSchedule` which is adding `_handleAppFrame` again as a next frame callback.
Scenario 2
removeListener and addListener are called multiple times in succession, every call to addListener can result in another registration of _handleAppFrame to the next Flutter frame callbacks list.
This patch fixes the issue by guarding against a second registration of _handleAppFrame.
2019-04-02 12:14:27 -07:00
xster
a83f6eadb8
Add needed singular resources for cupertino_en.arb ( #30160 )
2019-04-02 11:25:06 -07:00
Jon Tippens
f056ea4e70
Fix minor typo ( #30353 )
2019-04-02 09:45:04 -07:00
Kate Lovett
add5f2ea76
Updating sample code for raised button to match forthcoming diagram. ( #30348 )
2019-04-02 09:28:13 -07:00
Michael Goderbauer
7c76dee7a4
Make heroes fly on pushReplacement ( #30228 )
2019-04-01 18:14:20 -07:00
Shi-Hao Hong
d4c4f563c4
Added assert to prevent complete ListTile trailing/leading horizontal expansion ( #30212 )
2019-04-01 17:41:56 -07:00
Tong Mu
fbefd6b816
Simplify logic of TapGestureRecognizer ( #30227 )
...
Refactors the logic of TapGestureRecognizer, making the calling dependency unidirectional between resolve(accept) and checkUp.
2019-04-01 10:58:30 -07:00
Hans Muller
14aa57b18d
Fix OutlineInputBorder crash ( #30123 )
2019-04-01 09:28:18 -07:00
Zachary Anderson
61b5caff9a
[fuchsia_tester] Plumb through the location of icudtl ( #30218 )
2019-04-01 07:48:50 -07:00
Shi-Hao Hong
4d958ea5b7
Added helpful Material assert message ( #30219 )
...
Clarified an assert for when a Material widget's backgroundColor is null when its type isn't MaterialType.transparency
2019-03-30 12:58:58 -07:00
Jonah Williams
c10e7ba6e9
Revert "Ensure that flutter run/drive/test/update_packages only downloads required artifacts ( #30075 )" ( #30232 )
2019-03-29 20:41:07 -07:00
Jonah Williams
89807e68d0
Ensure that flutter run/drive/test/update_packages only downloads required artifacts ( #30075 )
2019-03-29 20:33:37 -07:00
Jonah Williams
b8bcfaa56f
make sure flutter test asks for cache upgrades ( #30216 )
2019-03-29 15:58:16 -07:00
xster
f2d671c15c
Cupertino localization step 3: in-place move some material tools around to make room for cupertino ( #29644 )
2019-03-29 15:57:09 -07:00
xster
d166a8d81e
Make sure everything in the Cupertino page transition can be linear when back swiping ( #28629 )
2019-03-29 15:56:18 -07:00
dacaiguoguo
1c0f82541c
Set custom flutter_assets by add FLTAssetsPath to AppFrameworkInfo.plist ( #29499 )
...
* Get FLTAssetsPath from AppFrameworkInfo.plist
2019-03-29 15:45:18 -07:00
Jonah Williams
8220f8f4e3
add missing test case and handle wildcard removal ( #30205 )
2019-03-29 14:26:56 -07:00
Darren Austin
3892a0d96c
Made the showMenu() position parameter required ( #30206 )
...
Made the showMenu() position parameter required as it doesn't make sense to show a menu without indicating where it should be shown. Also added a test to verify this.
2019-03-29 14:15:03 -07:00
Michael Goderbauer
a3cbe25353
Part 1: Improve Overlay API ( #28747 )
2019-03-29 14:09:30 -07:00
Shi-Hao Hong
0e2eeb5a48
Set Max Height for ListTile trailing and leading widgets ( #29771 )
2019-03-29 12:22:31 -07:00
liyuqian
ffbb335e35
Error message for setting shaderWarmUp too late ( #30145 )
...
Developers may get confused by setting PaintingBinding.shaderWarmUp in
the wrong place. The added assert and error message help avoid that.
2019-03-29 10:49:07 -07:00
Jonah Williams
1bfa2f2311
Intercept errors thrown by synchronous Completers in image resolution. ( #30139 )
2019-03-29 10:05:18 -07:00
Shi-Hao Hong
cbe4c9e1d7
Add link to hero animation page ( #30059 )
2019-03-28 18:14:55 -07:00
Darren Austin
19901f674b
Fix a misuse of matchesGoldenFile() in the physical_model_test. ( #30141 )
...
Fixed a misuse of matchesGoldenFile() in the physical_model_test so that it correctly reports a failed test on Linux (and skips the other platforms).
2019-03-28 18:08:29 -07:00
Jonah Williams
876b45f64e
skip .dart_tool folders when running update-packages ( #30082 )
2019-03-28 12:15:59 -07:00
Jonah Williams
a813dc559a
Add more test coverage to image handling ( #30078 )
2019-03-28 10:37:49 -07:00
Christopher Fujino
ec93c87c89
Move spinner _defaultSlowWarning
message to a new line ( #30071 )
...
* write newline before adding slow restart message to spinner
* update existing test
2019-03-28 10:08:44 -07:00
Francisco Magdaleno
b70d260b3c
Adds the keyboard mapping for Linux ( #29993 )
2019-03-28 10:04:23 -07:00
Jonah Williams
557c94ff77
Move binarySearch implementation in animated_list to foundation/collection.dart. ( #29860 )
2019-03-28 01:00:29 -07:00
Shi-Hao Hong
de6995cfa8
Added Hero zero-frame animation documentation ( #30048 )
2019-03-27 18:17:12 -07:00
Nizarius
ea343ccc3f
CupertinoTextField: added ability to change placeholder color ( #28001 )
2019-03-27 17:25:29 -07:00
Jonah Williams
3c93b65a9b
Update to latest matcher ( #30019 )
2019-03-27 17:21:10 -07:00
Jonah Williams
99866f4a3d
Make timeout durations configurable ( #30053 )
2019-03-27 16:21:16 -07:00
xster
4b365fb92a
Cupertino localization step 1.5: fix a resource mismatch in cupertino_en.arb ( #29821 )
2019-03-27 15:41:44 -07:00
Kate Lovett
76b9962fdd
Embedding new diagrams for API Docs ( #29697 )
...
* Embedding new diarams for API docs: Container, ListView, Align.
* Moving the diagrams to be enclosed within the snippet windows.
* Fixed wording for the alt image text.
2019-03-27 14:52:18 -07:00
Jonah Williams
50f1e1822a
ensure packages file is updated when using build_runner ( #29885 )
2019-03-27 14:40:52 -07:00
Chris Yang
3b3f6c7a04
Include platformViewId in semantics tree for iOS ( #29304 )
...
Include the platformViewId of PlatformViews in the semantics tree. The accessibility bridge in the engine can use this id to steal the semantics nodes from the actual platform view and stick them into Flutter's semantics tree.
It is the iOS PlatformView counter part of https://github.com/flutter/flutter/pull/28953 . It reverts the change in 5b5d6e89ec
and 03fd797eb8
.
https://github.com/flutter/flutter/issues/29302
2019-03-27 13:56:23 -07:00
Jonah Williams
7d678f2adc
Lazy cache 5: The Empire Strikes Back ( #29986 )
2019-03-27 13:54:09 -07:00
xster
7f3485e388
Let CupertinoPageScaffold have tap status bar to scroll to top ( #29946 )
2019-03-27 13:52:45 -07:00
LongCatIsLooong
817b959bfd
update CupertinoSwitch documentation ( #29987 )
...
Documented CupertinoSwitch.value that it can't be null and added an assertion value != null in the constructor.
Related issue: #12948
2019-03-27 13:41:47 -04:00
Justin McCandless
ed9509697c
Docs explaining how to avoid the problem of height toggling with error ( #29811 )
...
Documentation that explains a common use case seen in Github issues where users were surprised by TextFormField growth to accommodate validation messages.
2019-03-27 09:52:23 -07:00
LongCatIsLooong
673e989230
Remove unwanted gap between navigation bar and safe area's child ( #29943 )
...
Remove the additional top padding from CupertinoPageScaffold's MediaQuery when the navigation bar is opaque (as the padding was already consumed by the navigation bar).
Related Issue: #29136
2019-03-27 12:30:46 -04:00
Dwayne Slater
393521defe
Allow PointerEnterEvent and PointerExitEvents to be created from any PointerEvent ( #28602 )
...
Avoids an implicit downcast + crash in MouseTracker, since the last
pointer event can be a Move or Down event, in addition to Hover.
2019-03-27 09:26:28 -07:00
rami-a
64a28e3685
Fix issue with account drawer header arrow rotating when setState is called ( #29980 )
...
The UserAccountsDrawerHeader had a bug with the arrow rotating whenever setState was called on its parent. This change makes sure that we check that the state actually changed before allowing the animation to trigger.
Fixes #25801
2019-03-27 11:19:22 -04:00
Jonah Williams
bafe7cbbb4
Watch wildcard directories in addition to asset bundle ( #29883 )
2019-03-26 21:40:53 -07:00
Jonah Williams
141f87b327
ensure that fe server is always built with tool ( #29768 )
2019-03-26 17:11:04 -07:00
Kate Lovett
204eceea93
Linking Higher & Lower Class Docs ( #29758 )
...
* Adding linking between higher and lower level classes in the API Docs. ref:#22859
* Fixed links between classes.
2019-03-26 10:05:30 -07:00
Jonah Williams
164dae3bf1
Revert "Lazy cache 4 ( #29785 )" ( #29985 )
2019-03-26 10:01:22 -07:00
Amir Hardon
f652f01890
Limit the semantic nodes ID range to 2^16 ( #29928 )
...
This PR limits the framework generated semantic node IDs to be smaller than 2^16, this allows to safely generate semantic node in the engine with IDs >= 2^16 avoiding ID collision (which is done in flutter/engine#8250 ).
2019-03-26 09:37:27 -07:00
Zachary Anderson
7ea7d8d003
[fuchsia] Fix flutter_tool BUILD.gn deps ( #29942 )
2019-03-26 08:57:40 -07:00
Jonah Williams
d71f324e48
Lazy cache 4 ( #29785 )
2019-03-26 08:45:29 -07:00
hyjfine
6e50ccc803
Let CupertinoTextField's clear button also call onChanged ( #29474 )
2019-03-26 00:26:13 -07:00
Jonah Williams
44b22c7b04
Fix cache location, artifacts, and re-enable dart2js test ( #29783 )
2019-03-25 18:47:37 -07:00
liyuqian
42443f6631
Remove tranparent paint hack from BackdropFilter ( #29929 )
...
We can remove the hack because https://github.com/flutter/engine/pull/8183
has been rolled into the framework.
2019-03-25 17:09:39 -07:00
Jonah Williams
9bc85d7e54
wrap Timeline calls in assert ( #29861 )
2019-03-25 09:42:57 -07:00
Jonah Williams
beaf7e28fa
Update upgrade to reset off of hotfix branches ( #29786 )
2019-03-25 09:42:28 -07:00
Jonah Williams
377dfbd90d
dont fail build if codegen fails ( #29818 )
2019-03-25 08:43:13 -07:00
Mouad Debbar
7675a6ea94
Add support for text selection via mouse to Cupertino text fields ( #29769 )
2019-03-22 16:04:55 -07:00
Alexandre Ardhuin
bfa1d25bf9
some formatting of map, parameters and spaces ( #29760 )
2019-03-23 00:02:21 +01:00
Luka Knezic
fa2fd11275
Update CupertinoTextField ( #29008 )
2019-03-22 11:21:06 -07:00
Abhijeeth Padarthi
475d93a172
Removes unnecessary "new" in documentation ( #29779 )
2019-03-21 22:59:05 -07:00
Amir Hardon
e2cd5931a7
Revert "Update upgrade to rebase and stash local changes. ( #29192 )" ( #29780 )
...
This reverts commit e38be671a7
.
2019-03-21 20:34:07 -07:00
Jonah Williams
6701bbc528
update fuchsia-attach ( #29764 )
2019-03-21 16:13:04 -07:00
Jonah Williams
40cbdd11cd
Use Dart version in script cache check ( #29721 )
2019-03-21 15:56:13 -07:00
xster
8e7e435706
Add heart shapes to CupertinoIcons ( #29630 )
2019-03-21 15:31:46 -07:00
Rubens de Melo
a8c1960fc2
Include brackets on OutlineButton doc ( #29654 )
2019-03-21 15:28:51 -07:00
Jonah Williams
e38be671a7
Update upgrade to rebase and stash local changes. ( #29192 )
2019-03-21 14:32:52 -07:00
Jonah Williams
fc9f7dea1a
Allowing adding/updating packages during hot reload ( #29747 )
2019-03-21 13:59:38 -07:00
Mouad Debbar
c80366a160
Avoid flickering while dragging to select text ( #29563 )
2019-03-21 13:25:29 -07:00
Jonah Williams
469a859c72
Enable code generation features in tool ( #29399 )
2019-03-21 13:12:10 -07:00
Shayne Kelly II
db096cdfd8
Update DropdownButton underline to be customizable ( #29138 )
2019-03-21 10:32:43 -07:00
Christopher Fujino
a4b9ef2e79
Fix more tests for ANSI terminals ( #29699 )
...
* have tests that log error messages use a FakePlatform that does not support Ansi color, to fix tests started from color terminals
* add the override to the other tests too, in case someone copy & pastes them in the future for a test involving an error message
2019-03-21 09:11:58 -07:00