Commit graph

9903 commits

Author SHA1 Message Date
Alexander Aprelev d775908c7e
Download and handle product version of flutter patched sdk (#31063)
* Support release/debug flavors of flutter_patched_sdk

* Use [anyNamed] instead of [any] for mocking named arguments

* Fix use of local engine in release mode
2019-04-15 21:02:20 -07:00
Tom Robiquet 4ef0292790 Added opacity to cupertino switch when disabled (#29451) 2019-04-15 20:58:03 -07:00
Jonah Williams 1c779442a0
Add null checks to coverage collection (#31092) 2019-04-15 17:33:28 -07:00
xster 364d73c7d8
Make CupertinoNavigationBarBackButton correctly return an assert error (#30815) 2019-04-15 15:33:33 -07:00
liyuqian a8116e9ea3
Allow profile widget builds in profile mode (#30990)
## Description

Previously, such function is only available in the debug mode. But the
performance information is very noisy in debug mode with JIT. I feel
that such function is as important and useful as the performance overlay
and the `--trace-skia` option for the GPU thread.  So we should give it
the same ability to run in both profile and debug mode.

I've tested it using flutter_gallery in the profile mode. There's no
observable difference in the performance overlay between toggling widget
build profiling.

## Related Issues

https://github.com/flutter/flutter/issues/30984
2019-04-15 13:57:43 -07:00
Dan Field 330dc94c0f Check that ErrorWidget.builder is not modified after test (#30898) 2019-04-15 12:38:51 -07:00
Jonah Williams 28cb589cd3
make flutterProject option of CoverageCollector optional (#31074) 2019-04-15 12:26:43 -07:00
Christopher Fujino be5f345f33
New flag to flutter drive to skip installing fresh app on device (#30818)
* add a --build/--no-build flag to flutter drive command
2019-04-15 09:31:51 -07:00
Jonah Williams 715cb5132e
Fix bugs in contrast guideline and improve heuristic (#31000) 2019-04-15 09:01:09 -07:00
Jonah Williams 301eaa8c32
Make coverage, like, really fast (#30811) 2019-04-15 08:59:28 -07:00
Emily Fortuna ce6fbcea20
Allow mouse hover to only respond to some mouse events but not all. (#30886)
* Allow mouse hover to only respond to some mouse events but not all.
2019-04-11 16:29:21 -07:00
chunhtai fbeb5e0cf5
Fix issue 23527: Exception: RenderViewport exceeded its maximum number of layout cycles (#30809) 2019-04-11 16:23:11 -07:00
Greg Spencer 8bea3fb2eb
Keep hover annotation layers in sync with the mouse detector. (#30829)
Adds a paint after detaching/attaching hover annotations to keep the annotation layers in sync with the annotations attached to the mouse detector.

Fixes #30744
2019-04-11 13:11:22 -07:00
Siva e7c7a58d5d
Use identical instead of '==' in a constant expression. (#30921)
* Use identical instead of '==' in a constant expression.

* Fix analyzer warnings.

* Fix analyzer warnings.
2019-04-11 13:08:00 -07:00
Jonah Williams cadde2459b
Add toggle for debugProfileWidgetBuilds (#30867) 2019-04-11 12:44:33 -07:00
Justin McCandless ecb468f335
Baseline Aligned Row (#30746)
Text in a baseline aligned row now works, and the height of the row is properly calculated.
2019-04-11 09:32:22 -07:00
MH Johnson 3bbb8d8b77
[Material] Fix showDialog crasher caused by old contexts (#30754)
* Fix bug, add regression test.

* remove unnecessary space
2019-04-11 09:48:35 -04:00
Dan Field 42d3464d2e
Let sliver.dart _createErrorWidget work with other Widgets (#30880)
Credit to @ymback
2019-04-11 00:31:06 -07:00
xster 2736c8c19f
Add more dialog doc cross-reference (#30887) 2019-04-10 22:38:34 -07:00
Jonah Williams 259641c4b3
Allow downloading of desktop embedding artifacts (#30648) 2019-04-10 22:08:44 -07:00
LongCatIsLooong 1a3201bc74
CupertinoDatePicker initialDateTime accounts for minuteInterval (#30862)
initialDateTime should account for minuteInterval
2019-04-10 20:14:35 -07:00
LongCatIsLooong b8a1870d92
add golden tests for CupertinoDatePicker (#30828)
Add golden tests for CupertinoDatePicker
2019-04-10 19:46:23 -07:00
liyuqian 8ca7c4cbbd
Simplify toImage future handling (#30876)
Thanks to cbracken@'s suggestion on another Google-internal change.
2019-04-10 19:19:30 -07:00
champeauxr a5dd074b0d Fixed Table flex column layout error #30437 (#30470)
RenderTable._computeColumnWidths() had a logic error that caused flex columns to be collapsed to their minimum widths in certain situations dependent on the layout width constraint and the number of flex columns.
2019-04-10 18:53:27 -07:00
Dan Field d2790bd2bb
Check for invalid elevations (#30215)
* Check for invalid elevation usage in the layer tree
2019-04-10 14:57:46 -07:00
Sam Rawlins 83ddd98849 Fix additional @mustCallSuper indirect overrides and mixins (#30667) 2019-04-10 14:54:51 -07:00
Todd Volkert 499004779b
Revert "Add Form.onSaved (#30643)" (#30793)
This reverts commit 949023b276.
2019-04-10 14:49:10 -07:00
Tong Mu f34c2ef0a3
Revert "Remove pressure customization from some pointer events (#30414)" (#30873)
This reverts commit a821136997.
2019-04-10 14:14:12 -07:00
Tong Mu a821136997
Remove pressure customization from some pointer events (#30414)
* Remove pressure from PointerHoverEvent ctor
2019-04-10 12:40:33 -07:00
Jonah Williams 316d44989a
warn on uncomitted changes (#30235) 2019-04-10 12:24:53 -07:00
Jonah Williams f66ee3e470
Add semanticsLabel parameter to TextSpan (#30837) 2019-04-10 12:24:01 -07:00
Justin McCandless ed91a3be49
Fix cursor outside of input width (#30525)
* Disallow cursor from appearing beyond the width of the input.

* Test that verifies the cursor can't exceed the width of the input

* Use constant from editable.dart to explain 1 pixel difference in test

* Fix failing test that tested the case of overflowing spaces
2019-04-10 10:35:03 -05:00
xster 5a6c140d0d
Cupertino localization step 7: modularize material specific things out of gen_localizations.dart (#29822) 2019-04-10 01:24:58 -07:00
Shi-Hao Hong b3bb5cd6b0
Fix StatefulWidget and StatelessWidget Sample Documentation (#30814) 2019-04-09 19:32:00 -07:00
liyuqian eb30745faf
Print warning if flutter drive is run in debug (#30747)
## Description

Print actionable warnings if `flutter drive` (where most of our performance benchmarks come from) is run in debug mode and it tries to gather benchmarks using `traceAction`.

## Related Issues

https://github.com/flutter/flutter/issues/30625

## Tests

I added the following tests:
* drive_perf_debug_warning devicelab test
2019-04-09 18:55:42 -07:00
xster 5a4eaabaf1
Cupertino localization step 11: add more translation clarifications in the instructions (#30527) 2019-04-09 17:47:44 -07:00
Shi-Hao Hong c7d7ba1c2b
Update ExpansionPanelList Samples with Scaffold template (#30805) 2019-04-09 14:01:47 -07:00
Shi-Hao Hong 1835aac558
Update ListTile sample snippets to use Material Scaffold Template (#30800) 2019-04-09 13:46:31 -07:00
ShaLi Shaltiel a018264131 Updated package template .gitignore file (#27034) 2019-04-09 10:12:32 -07:00
Shi-Hao Hong 9f9c5c29ec
Embedded images and variations to ListTile sample code (#30537)
Also includes counter-examples for list items that differ from ListTile.
2019-04-09 10:10:57 -07:00
Michael Thomsen 811f1ad98f
Forward missing pub commands (#30115) 2019-04-09 17:03:09 +02:00
Jonah Williams 03817a995a
fix cast NPE in invokeListMethod and invokeMapMathod (#30760) 2019-04-09 07:22:25 -07:00
Jonah Williams ed49122aa3
register gradle wrapper as universal artifact (#30755) 2019-04-08 20:22:34 -07:00
xster e2b6a3a7a8
Cupertino localization step 6: add a GlobalCupertinoLocalizations base class with date time formatting (#29767) 2019-04-08 16:56:58 -07:00
Jonah Williams 9baffb97ca
Reland: Ensure that flutter run/drive/test/update_packages only downloads required artifacts (#30254) 2019-04-08 13:49:09 -07:00
Jonah Williams 99b4459944
Allow disabling experimental commands, devices on stable branch (#30153) 2019-04-08 13:48:21 -07:00
Lau Ching Jun 294d7ea0cf
Mark ios-deploy version 2.0.0 as bad (#30578)
Mark ios-deploy version 2.0.0 as bad.

ios-deploy before version 1.9.4 declares itself as v2.0.0
https://github.com/ios-control/ios-deploy/commits/master/src/ios-deploy/version.h
2019-04-08 12:37:43 -07:00
Todd Volkert 0b8403b61c
Add const Border.uniform() (#30640)
`Border.all()` is a factory constructor and thus not const
constructible. This change adds a `const Border.uniform()`
constructor and makes `Border.all()` delegate to it. This allows
callers to more likely be able to make their widget tree const
constructible.
2019-04-07 21:29:32 -07:00
Todd Volkert 949023b276
Add Form.onSaved (#30643)
When submitting data to a server, callers need a callback that will
get invoked after all the individual form fields are saved. If they
have a button that submits the form, they could just do this logic
in the click handler for the button (save the form, then submit to
the server), but if they have more ways than one to submit the form
(i.e. hitting enter while in a text form field), then it becomes
more convoluted and calls for a unified callback that will get
notified when the form is submitted.
2019-04-07 21:02:09 -07:00
Todd Volkert cb78274c3f
Make FormField._validate() return void (#30644)
None of its callers were using the return value, so no need to
invoke the `isValid` getter unnecessarily.
2019-04-07 21:01:33 -07:00