development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 11:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

wrap Timeline calls in assert (#29861)

Browse source
This commit is contained in:
Jonah Williams 2019-03-25 09:42:57 -07:00 committed by GitHub
parent beaf7e28fa
commit 9bc85d7e54
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
packages/flutter/lib/src/material/about.dart
View file

@ -380,18 +380,26 @@ class _LicensePageState extends State<LicensePage> {
bool _loaded = false;
Future<void> _initLicenses() async {
final Flow flow = Flow.begin();
Timeline.timeSync('_initLicenses()', () { }, flow: flow);
int debugFlowId = -1;
assert(() {
final Flow flow = Flow.begin();
Timeline.timeSync('_initLicenses()', () { }, flow: flow);
debugFlowId = flow.id;
return true;
}());
await for (LicenseEntry license in LicenseRegistry.licenses) {
if (!mounted)
if (!mounted) {
return;
Timeline.timeSync('_initLicenses()', () { }, flow: Flow.step(flow.id));
}
assert(() {
Timeline.timeSync('_initLicenses()', () { }, flow: Flow.step(debugFlowId));
return true;
}());
final List<LicenseParagraph> paragraphs =
await SchedulerBinding.instance.scheduleTask<List<LicenseParagraph>>(
() => license.paragraphs.toList(),
license.paragraphs.toList,
Priority.animation,
debugLabel: 'License',
flow: flow,
);
setState(() {
_licenses.add(const Padding(
@ -434,7 +442,10 @@ class _LicensePageState extends State<LicensePage> {
setState(() {
_loaded = true;
});
Timeline.timeSync('Build scheduled', () { }, flow: Flow.end(flow.id));
assert(() {
Timeline.timeSync('Build scheduled', () { }, flow: Flow.end(debugFlowId));
return true;
}());
}
@override