development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-08-27 20:10:11 +00:00
Code Issues Packages Projects Releases Wiki Activity
37354 commits 766 branches 969 tags 1.3 GiB
Commit graph

37354 commits

This branch
This branch
All branches
Author SHA1 Message Date
Victoria Ashworth d6ec0cf564
Change some tests to run on macs without iOS devices attached (#136463) 
Some tests have been running on devicelab bots with iOS devices attached, however, they don't require an iOS device. So moving them to run on bots without iOS devices.

Fixes https://github.com/flutter/flutter/issues/136415.
 2023-10-12 16:52:16 +00:00
engine-flutter-autoroll ee7e41fec0
Roll Packages from 4b483f242936 to 93c3f69fa6c6 (9 revisions) (#136461) 
4b483f2429...93c3f69fa6

2023-10-12 goderbauer@google.com [shared_preferences] update file version constraints (flutter/packages#5121)
2023-10-12 supercionci@hotmail.it [cross_file] Improved documentation about ignored parameters in IO module. (flutter/packages#4416)
2023-10-11 41873024+droidbg@users.noreply.github.com [in_app_purchase] [#135759] Fix. doc reference finishPurchase to completePurchase. (flutter/packages#5081)
2023-10-10 zeucxb@gmail.com Update repo README issues link (flutter/packages#5106)
2023-10-10 43643339+nohli@users.noreply.github.com [flutter_markdown] Fix typo in readme (flutter/packages#5096)
2023-10-10 43054281+camsim99@users.noreply.github.com [camerax] Implements torch mode (flutter/packages#4903)
2023-10-10 25266387+Leptopoda@users.noreply.github.com [shared_preferences] fix documentation wording (flutter/packages#4986)
2023-10-10 katelovett@google.com [two_dimensional_scrollables] Fix paint bug when rows/columns are pinned and axes are reversed (flutter/packages#5038)
2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter from f52fe4f7e5 to 83134ac7e4 (25 revisions) (flutter/packages#5104)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 16:13:06 +00:00
Victoria Ashworth ddc9b40a98
Fix typo in function name (#136273) 
Rename `removeIOSimulator` to `removeIOSSimulator`.
 2023-10-12 15:53:00 +00:00
Taha Tesser f65dd3bac0
Fix chip widgets don't the apply provided iconTheme (#135751) 
fixes [`Chip.iconTheme` does not apply the icon theme](https://github.com/flutter/flutter/issues/111828)

### Description
- Fix chip widgets that don't utilize the provided `iconTheme`.
- Prevent `iconTheme` with just color from overriding the default icon size.
- Add some missing M3 tests for the chip and chip theme properties.

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  final bool _isEnable = true;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            RawChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('RawChip'),
              onPressed: () {},
              isEnabled: _isEnable,
            ),
            const Chip(
              iconTheme: IconThemeData(color: Colors.amber),
              avatar: Icon(Icons.favorite_rounded),
              label: Text('Chip'),
              // onDeleted: () {},
            ),
            FilterChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              selected: false,
              onSelected: _isEnable ? (bool value) {} : null,
            ),
            InputChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('InputChip'),
              isEnabled: _isEnable,
              onPressed: () {},
            ),
            ActionChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('ActionChip'),
              onPressed: _isEnable ? () {} : null,
            ),
            ChoiceChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('ChoiceChip'),
              selected: false,
              onSelected: _isEnable ? (bool value) {} : null,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () {},
        child: const Icon(Icons.add),
      ),
    );
  }
}

```

</details>

### Before
![Screenshot 2023-09-29 at 16 59 39](https://github.com/flutter/flutter/assets/48603081/4bc32032-cff3-4237-812f-86f17ed95337)

### After

![Screenshot 2023-09-29 at 16 55 24](https://github.com/flutter/flutter/assets/48603081/05a1fc52-fb31-4790-a840-18f2e9718241)
 2023-10-12 14:17:56 +00:00
engine-flutter-autoroll fad8bda64a
Roll Flutter Engine from 33a6d21b3364 to 664657d32992 (2 revisions) (#136450) 
33a6d21b33...664657d329

2023-10-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 9afac395dfb1 to 34c06f0bcb29 (1 revision) (flutter/engine#46820)
2023-10-12 skia-flutter-autoroll@skia.org Roll ICU from 985b9a6f70e1 to 995db880cff2 (1 revision) (flutter/engine#46818)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 11:40:22 +00:00
engine-flutter-autoroll b89e1df7ac
Roll Flutter Engine from d00fabf0b919 to 33a6d21b3364 (5 revisions) (#136442) 
d00fabf0b9...33a6d21b33

2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Qjz4zE4Oe0AO_7T3f... to 8AXhoo-MMME8NMKt0... (flutter/engine#46814)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 9f5080c58aac to 2dd1579c6921 (1 revision) (flutter/engine#46813)
2023-10-12 skia-flutter-autoroll@skia.org Roll Dart SDK from db2465f106ad to 9afac395dfb1 (1 revision) (flutter/engine#46812)
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hMA99PoacaRZVXHgr... to giQtXxdSj6NdIViCw... (flutter/engine#46811)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from ff3c2e3d45bd to 9f5080c58aac (1 revision) (flutter/engine#46809)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from hMA99PoacaRZ to giQtXxdSj6Nd
  fuchsia/sdk/core/mac-amd64 from Qjz4zE4Oe0AO to 8AXhoo-MMME8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 08:07:21 +00:00
engine-flutter-autoroll c0d19ca561
Roll Flutter Engine from 05e26c1b2c79 to d00fabf0b919 (5 revisions) (#136431) 
05e26c1b2c...d00fabf0b9

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 924df8d87766 to ff3c2e3d45bd (1 revision) (flutter/engine#46807)
2023-10-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 0732be6b823a to db2465f106ad (8 revisions) (flutter/engine#46797)
2023-10-11 bdero@google.com [Impeller] Use triangle strips to dedupe rectangle vertices. (flutter/engine#46610)
2023-10-11 bdero@google.com [Impeller] Bump impeller-cmake (flutter/engine#46764)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 2459d71707e0 to 924df8d87766 (7 revisions) (flutter/engine#46798)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-12 03:33:07 +00:00
Qun Cheng 6388e3d727
Floating SnackBar should always float above the bottom widgets (#136411) 
Fixes #136162

This PR is to fix the floating `SnackBar` issue so that when the top of the bottom bar is higher than the top of the FAB, the snack bar will still float and not be clipped.

| Before fix | After fix |
|--------|--------|
| ![Screenshot 2023-10-11 at 1 54 30 PM](https://github.com/flutter/flutter/assets/36861262/dbe02312-1a80-4532-9bad-a8f162a6a942) | ![Screenshot 2023-10-11 at 1 54 52 PM](https://github.com/flutter/flutter/assets/36861262/68211de0-f04f-4b1a-b554-baf6a8e2f947)
 |
 2023-10-12 01:17:07 +00:00
Bryan Olivares d9c0d3ae51
SearchBar should listen to changes to the SearchController and update suggestions on change (#134337) 
This PR is adding a listener to the `SearchController`, so that the `suggestionBuilder` can be updated when the `SearchController` changes. 

Another method we can possibly do is  have an update method on `SearchController`, so that the user can manually update the suggestions instead of us doing it automatically.

Fixes #132161
 2023-10-12 00:55:38 +00:00
Kevin Moore 3e60999b11
Allow latest pkg:material_color_utilities (#132445) 
* Allow latest pkg:material_color_utilities
* Bump other dependencies to their latest - including pkg:web
 2023-10-11 23:57:16 +00:00
engine-flutter-autoroll 695825419d
Roll Flutter Engine from 8bf1460892c6 to 05e26c1b2c79 (3 revisions) (#136422) 
8bf1460892...05e26c1b2c

2023-10-11 jason-simmons@users.noreply.github.com Run the binary size treemap script from the buildroot directory (flutter/engine#46740)
2023-10-11 dnfield@google.com [Impeller] flutter_tester --enable-impeller (flutter/engine#46389)
2023-10-11 jacksongardner@google.com Switch to Chrome For Testing instead of Chromium (flutter/engine#46683)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 23:52:06 +00:00
Kevin Chisholm 6027d5d3fc
Create template for umbrella issues (#134235) 
In order to better track features, I propose that we have a unified
template for creating Umbrella issues. This is not required to create
umbrella issue to add to the feature tracker, however for those who
would like a more fleshed out format, this will serve the purpose.

Fixes: https://github.com/flutter/flutter/issues/134234
 2023-10-11 18:22:49 -05:00
Loïc Sharma 50b56de215
[Windows Arm64] Add the 'platform_channel_sample_test_windows' Devicelab test (#136401) 
✅ Successful run: 2a327123e9/+/build.proto?server=chromium-swarm.appspot.com

Part of https://github.com/flutter/flutter/issues/129806
 2023-10-11 23:07:29 +00:00
engine-flutter-autoroll a44e0862a8
Roll Flutter Engine from 2b1b4b97f787 to 8bf1460892c6 (4 revisions) (#136414) 
2b1b4b97f7...8bf1460892

2023-10-11 34871572+gmackall@users.noreply.github.com Revert "[Android] Add support for text processing actions (#44579)" (flutter/engine#46788)
2023-10-11 danchevalier@google.com [web] Adds Noto Music fallback font (flutter/engine#46720)
2023-10-11 jason-simmons@users.noreply.github.com Fix some image_external_texture entries in the license golden file (flutter/engine#46790)
2023-10-11 john@johnmccutchan.com Rename HardwareBufferExternalTexture* to ImageExternalTexture* (flutter/engine#46786)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 23:04:17 +00:00
Christopher Fujino 8ca7d7d136
Stop recommending android sdk root (#136296) 
Fixes https://github.com/flutter/flutter/issues/117245
 2023-10-11 21:04:59 +00:00
engine-flutter-autoroll e83f53e6a0
Roll Flutter Engine from 5fcc16772cdd to 2b1b4b97f787 (1 revision) (#136404) 
5fcc16772c...2b1b4b97f7

2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 6cc9f73ea54e to 2459d71707e0 (1 revision) (flutter/engine#46787)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 20:58:57 +00:00
Jackson Gardner a277c5faaf
Switch to Chrome for Testing instead of vanilla Chromium. (#136214) 
This switches over to using Chrome for Testing instead of Chromium. This should ensure that we are consistently using an official and consistent build of Chrome on all platforms, rather than whatever we can get from the continuous builds archive, which can potentially put platforms out of sync with each other.
 2023-10-11 20:51:14 +00:00
Derek Xu 1a44710d19
Reland "Switch flutter_tools to run frontend server from AOT snapshot" (#136282) 
This reverts commit a1639be.
 2023-10-11 16:15:26 -04:00
engine-flutter-autoroll 58701ac2f2
Roll Flutter Engine from 4b02631b59bf to 5fcc16772cdd (2 revisions) (#136397) 
4b02631b59...5fcc16772c

2023-10-11 john@johnmccutchan.com Fix 303652511 and add a regression test (flutter/engine#46743)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from bfd9af01b785 to 6cc9f73ea54e (1 revision) (flutter/engine#46784)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 20:00:04 +00:00
Kate Lovett 156e3487b0
Fix some deprecation details (#136385) 
This fixes/notates a few deprecations from an audit for the next tech debt cycle.

- ThemeData errorColor and backgroundColor are notated as deprecated in multiple places, but one usage had a different version tag. Updated to match the rest.
- ThemeData.copyWith useMaterial3 was deprecated because it did not do what developers expected - it did not automatically reassign all of the color values and such. (confirmed with @HansMuller) I added a note so that when we later remove it we don't introduce a bug.
- the describeEnum deprecation was tagged wrong, it was a very long PR so by the time it merged the version it was finally tagged with was much later. (https://github.com/flutter/flutter/pull/125016)
 2023-10-11 19:39:06 +00:00
engine-flutter-autoroll 9a8a2c7fc9
Roll Flutter Engine from ed67e8aa9aba to 4b02631b59bf (1 revision) (#136392) 
ed67e8aa9a...4b02631b59

2023-10-11 bdero@google.com [Impeller] Avoid invalid GL depth calls on macOS desktop. (flutter/engine#46758)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 19:02:22 +00:00
droidbg f84831c169
[leak-tracking] Add leak tracking in test/rendering - 1 (#136275) 2023-10-11 11:53:41 -07:00
Loïc Sharma f2931dbd8c
Remove the 'Windows_arm64 plugin_test' Devicelab test (#136379) 
This removes the `Windows_arm64 plugin_test` as Devicelab tests aren't able to target Android from a Windows Arm64 host yet. I opened https://github.com/flutter/flutter/issues/136378 to track this work.
 2023-10-11 18:31:04 +00:00
engine-flutter-autoroll ea8c6307fe
Roll Flutter Engine from 68a8ff743539 to ed67e8aa9aba (2 revisions) (#136383) 
68a8ff7435...ed67e8aa9a

2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from mLc-VlVTg-p18HjiP... to Qjz4zE4Oe0AO_7T3f... (flutter/engine#46778)
2023-10-11 zanderso@users.noreply.github.com Roll goldctl forward (flutter/engine#46771)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from mLc-VlVTg-p1 to Qjz4zE4Oe0AO

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 18:12:06 +00:00
Christopher Fujino 5a4497d47f
extend timeout from default 30 min to 1 hour for windows build tests (#136300) 
Fixes https://github.com/flutter/flutter/issues/136299
 2023-10-11 18:10:52 +00:00
Kenzie Davisson a047358c5c
Add profilePlatformChannels service extension (#136051) 
We will expose this from a button in DevTools.
https://github.com/flutter/devtools/issues/6166
 2023-10-11 10:45:06 -07:00
Maximilian Fischer 6ff02dbc83
Include size factors when computing the intrinsic size of a RenderPositionedBox (#135823) 
This PR includes the `widthFactor` and `heightFactor` when computing the intrinsic size of a `RenderPositionedBox`.

<details><summary>Code sample</summary>

Red should have a height of 100, blue one of 200.

```dart
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Intrinsic Bug',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: Scaffold(
        body: Row(
          crossAxisAlignment: CrossAxisAlignment.start,
          children: [
            Expanded(
              child: IntrinsicHeight(
                child: Align(
                  heightFactor: 0.5,
                  child: Container(
                    height: 200,
                    color: Colors.red,
                  ),
                ),
              ),
            ),
            Expanded(
              child: Container(
                height: 200,
                color: Colors.blue,
              ),
            ),
          ],
        ),
      ),
    );
  }
}
```
</details>

Before:
![grafik](https://github.com/flutter/flutter/assets/45403027/447d8b9b-e7f3-482a-900d-53e436830321)
After:
![grafik](https://github.com/flutter/flutter/assets/45403027/6d1a104b-3327-47e2-8b36-798ed0136793)

Fix #135822
 2023-10-11 17:39:56 +00:00
Zachary Anderson d773c5a9ea
[flutter_tool] Delete skipped tests (#136364) 
These tests have been skipped due to flakiness for a long time.

Closes https://github.com/dart-lang/webdev/issues/1562
Closes https://github.com/flutter/flutter/issues/124214
 2023-10-11 10:24:14 -07:00
engine-flutter-autoroll e090fc1ac2
Roll Flutter Engine from ec1d0d69fcf1 to 68a8ff743539 (2 revisions) (#136380) 
ec1d0d69fc...68a8ff7435

2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 60d51fd2c6bd to bfd9af01b785 (2 revisions) (flutter/engine#46774)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from c05effecb081 to 60d51fd2c6bd (3 revisions) (flutter/engine#46772)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 17:19:32 +00:00
Loïc Sharma c6aeab930a
[Windows] Add Arm64 benchmarks (#135514) 
Part of: https://github.com/flutter/flutter/issues/129806

Test runs kicked off using `led`:
* ✅ [hot_mode_dev_cycle_win_target__benchmark](2079b030ac/+/build.proto?server=chromium-swarm.appspot.com)
* ✅ [windows_home_scroll_perf__timeline_summary](56a3b258e4/+/build.proto?server=chromium-swarm.appspot.com)
* ✅ [flutter_tool_startup](fa6a1056fc/+/build.proto?server=chromium-swarm.appspot.com)

/cc @pbo-linaro
 2023-10-11 16:36:20 +00:00
Kostia Sokolovskyi cc41e25f21
_RenderSnapshotWidget should dispose created OffsetLayer. (#136267) 2023-10-11 08:45:39 -07:00
engine-flutter-autoroll 54d584740b
Roll Flutter Engine from bddb34b09ce9 to ec1d0d69fcf1 (1 revision) (#136368) 
bddb34b09c...ec1d0d69fc

2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from e00577618d81 to c05effecb081 (1 revision) (flutter/engine#46770)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 15:45:21 +00:00
engine-flutter-autoroll ec94ccff83
Roll Flutter Engine from d93fe2367d21 to bddb34b09ce9 (2 revisions) (#136352) 
d93fe2367d...bddb34b09c

2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 11e41e0e2f9f to e00577618d81 (1 revision) (flutter/engine#46763)
2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FX5YzwP_ZEnPP0b3v... to hMA99PoacaRZVXHgr... (flutter/engine#46762)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from FX5YzwP_ZEnP to hMA99PoacaRZ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 11:41:40 +00:00
engine-flutter-autoroll 1ca0991021
Roll Flutter Engine from cb0dabd3b33c to d93fe2367d21 (2 revisions) (#136346) 
cb0dabd3b3...d93fe2367d

2023-10-11 leroux_bruno@yahoo.fr [Android] Add support for text processing actions (flutter/engine#44579)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 4935bed4260d to 11e41e0e2f9f (3 revisions) (flutter/engine#46759)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 10:49:25 +00:00
Taha Tesser 692d7ade9e
Fix FlexibleSpaceBar does compositing with near zero opacity. (#136255) 
fixes [`flexible_space_bar.dart': Failed assertion: line 475 pos 12: 'needsCompositing': is not true.` is thrown when scrolling down in the list and then up](https://github.com/flutter/flutter/issues/135698)
 2023-10-11 07:19:30 +00:00
engine-flutter-autoroll 94f748388e
Roll Flutter Engine from 0d86d529bb7e to cb0dabd3b33c (1 revision) (#136320) 
0d86d529bb...cb0dabd3b3

2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from oTiMPVe_PvyCYnlqR... to mLc-VlVTg-p18HjiP... (flutter/engine#46754)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from oTiMPVe_PvyC to mLc-VlVTg-p1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 05:48:21 +00:00
engine-flutter-autoroll 0d1e73b137
Roll Flutter Engine from 80868149792f to 0d86d529bb7e (1 revision) (#136315) 
8086814979...0d86d529bb

2023-10-11 bdero@google.com [Impeller] Allow pipeline variant sets to have differing defaults. (flutter/engine#46751)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 03:34:12 +00:00
engine-flutter-autoroll 2a221682ec
Roll Flutter Engine from ea275c3d27d3 to 80868149792f (4 revisions) (#136307) 
ea275c3d27...8086814979

2023-10-11 matanlurey@users.noreply.github.com Remove support for `Paint.enableDithering=false` in `dart:ui`. (flutter/engine#46745)
2023-10-11 chris@bracken.jp Move //third_party/glfw to //flutter/third_party/glfw (flutter/engine#46733)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 06145491fd17 to 4935bed4260d (3 revisions) (flutter/engine#46748)
2023-10-11 bdero@google.com [Impeller] Guard calls to extension proc DebugMessageControlKHR. (flutter/engine#46747)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 02:42:14 +00:00
Polina Cherkasova ad05949971
Fix flakiness: finalize dropped gestures in tests to release resources, and update doc-comment. (#136136) 2023-10-10 18:11:23 -07:00
Valentin Vignal b989428fa2
Add SizeTransition.fixedCrossAxisSizeFactor (#134659) 
Fixes https://github.com/flutter/flutter/issues/134654
 2023-10-11 00:53:34 +00:00
Matan Lurey f38244f0b5
Relaxed a test on Paint.toString() to ignore dither: .... (#136302) 
Work towards https://github.com/flutter/flutter/issues/112498.

Behaviorally the same, except doesn't care if `dither: ...` shows up, or
not (it won't when https://github.com/flutter/flutter/issues/112498 is
fixed).
 2023-10-10 17:50:35 -07:00
engine-flutter-autoroll a7edafe7e8
Roll Flutter Engine from 4a4d9de43848 to ea275c3d27d3 (1 revision) (#136301) 
4a4d9de438...ea275c3d27

2023-10-10 jonahwilliams@google.com [Impeller] log specific framebuffer incomplete error. (flutter/engine#46692)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-11 00:40:06 +00:00
engine-flutter-autoroll 85e172658b
Roll Flutter Engine from bdeb53455f7c to 4a4d9de43848 (2 revisions) (#136294) 
bdeb53455f...4a4d9de438

2023-10-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dCjN58uZQBmAFWSxN... to FX5YzwP_ZEnPP0b3v... (flutter/engine#46734)
2023-10-10 bdero@google.com [Impeller] Don't cull readbacks outside the damage rect. (flutter/engine#46705)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from dCjN58uZQBmA to FX5YzwP_ZEnP

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 23:56:17 +00:00
Greg Spencer 7e1d366a4d
Add key event handlers that happen before or after the focus traversal (#136280) 
## Description

This adds a mechanism for listening to key events before or after focus traversal occurs.

It adds four methods to the public `FocusManager` API:

- `addEarlyKeyEventHandler` - Adds a handler that can handle events before they are given to the focus tree for handling.
- `removeEarlyKeyEventHandler` - Removes an early event handler.
- `addLateKeyEventHandler` - Adds a handler that can handle events if they have not been handled by anything in the focus tree.
- `removeLateKeyEventHandler` - Removes a late event handler.

This allows an app to get notified for a key anywhere, and prevent the focus tree from seeing that event if it handles it.

For the menu system, this allows it to eat an escape key press and close all the open menus.

## Related Issues
 - https://github.com/flutter/flutter/issues/135334

## Tests
 - Added tests for new functionality.
 2023-10-10 23:16:25 +00:00
Christopher Fujino b416473bbb
[flutter_tools] catch StdinException when setting terminal to SingleCharMode (#136283) 
Fixes https://github.com/flutter/flutter/issues/129198
 2023-10-10 23:10:29 +00:00
Camille Simon 54cf286e1a
[Android] Update Java/AGP/Gradle warning compatible Java range (#135710) 
Specifies that compatible Java range stated in warning when Java version is incompatible with our template AGP & Gradle versions notes an exclusive upper bound Java version. This was a bug from https://github.com/flutter/flutter/pull/131444, and I will file a CP request to stable once this lands.

The warning uses [`getJavaVersionFor`](b5c8fd11e4/packages/flutter_tools/lib/src/android/gradle_utils.dart (L606)), which returns an exclusive upper bound, which is why this fix is necessary.
 2023-10-10 22:30:50 +00:00
engine-flutter-autoroll 640050ba80
Roll Flutter Engine from 702f366b1c5d to bdeb53455f7c (6 revisions) (#136292) 
702f366b1c...bdeb53455f

2023-10-10 john@johnmccutchan.com Fix high FPS screen flicker of Platform Views when using ImageReaderPlatformViewRenderTarget (flutter/engine#46724)
2023-10-10 matanlurey@users.noreply.github.com Prepare to move new folders into `third_party/` by adding a `.gitignore`. (flutter/engine#46729)
2023-10-10 godofredoc@google.com Use x86 machines for ios builds. (flutter/engine#46726)
2023-10-10 chinmaygarde@google.com Remove workaround for older versions of MSVC. (flutter/engine#46689)
2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from 475286f0f6f1 to 06145491fd17 (1 revision) (flutter/engine#46728)
2023-10-10 jonahwilliams@google.com [Impeller] Implement framebuffer fetch support for OpenGLES. (flutter/engine#46585)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-10 22:29:13 +00:00
Jonah Williams a106b81cc5
[framework] restore old zoom page transition for benchmarking. (#133346) 
In the past I switched the implementation of the zoom page transition because the performance of the old transition was terrible, but I'm hopeful that with Impeller we'll be able to identify and fix the issues that made it so slow. In order to evaluate this though, we need to be able to opt into the old transition for benchmarks on CI.

https://github.com/flutter/flutter/issues/129742
https://github.com/flutter/flutter/issues/121325
 2023-10-10 22:27:07 +00:00
Mitchell Goodwin daa52b2501
Seperate localization tests for Material2 and Material3 (#135779) 
Seperates tests for the localizations package into Material2 and Material3 versions and removes dependency on theme.

More info in #127064
 2023-10-10 21:46:20 +00:00
Christopher Fujino 0fa01b2156
[flutter_tools] allow tool integration tests to quit on SIGINT (#136271) 
fixes https://github.com/flutter/flutter/issues/136270
 2023-10-10 20:47:59 +00:00