Commit graph

13881 commits

Author SHA1 Message Date
chunhtai b2c737547f
makes PopupMenuitem merge the semantics of its child (#62062) 2020-07-28 10:26:10 -07:00
LongCatIsLooong fe88a88a5a
Autofill save (#58731) 2020-07-28 10:23:17 -07:00
includecmath 3215a0130b
[flutter_tools] Unified analyze error log format (#61146)
* Unified analyze error log format

* Fix review issues
2020-07-28 10:21:57 -07:00
songyiYu 0a03d64346
Add LayoutBuilder example (#61948) 2020-07-28 10:21:12 -07:00
Yuqian Li 7c942e390f
Add a test for 3D transform with needsCompositing (#61779) 2020-07-28 10:21:08 -07:00
Jonah Williams 59e0a2ec28
[flutter_tools] update device discovery constructors (#61640)
google3 callsites are updated, remove global lookup from constructor parameters.
2020-07-28 10:20:01 -07:00
Michael Goderbauer 175e5c9aca
Restoration Framework (#60375)
* state restoration

* added example

* typos and analyzer

* whitespace

* more typos

* remove unnecessary import

* whitespace

* fix sample code

* tests for restorationmanager and restorationid

* ++

* typo

* tests for bucket, part1

* rename tests

* more tests

* finished tests for service layer

* remove wrong todo

* ++

* review comments

* tests for Unmanaged and regular scope

* RootRestorationScope tests

* typo

* whitespace

* testing framework

* tests for properties

* last set of tests

* analyzer

* typo

* dan review

* whitespace

* ++

* refactor finalizers

* ++

* ++

* dispose guard

* ++

* ++

* dan review

* add manager assert

* ++

* analyzer

* greg review

* fix typo

* Ian & John review

* ian review

* RestorationID -> String

* revert comment

* Make primitives non-nullable in prep for NNBD
2020-07-28 10:16:36 -07:00
Pragya 1fff10500f
Added expandedHeight in flexibleSpace and flexibleSpaceBar (#61710) 2020-07-28 10:16:13 -07:00
Jenn Magder e8e5de44ec
Parse .flutter-plugins-dependencies for add-to-app iOS modules (#61269) 2020-07-28 10:16:09 -07:00
chunhtai 734782f5d7
clean up hero controller scope (#60655) 2020-07-28 10:11:09 -07:00
Daniel Iglesia 0fdb21f31f
Adds an onMove callback on a DragTarget. (#60174) 2020-07-28 09:56:09 -07:00
Jonah Williams d834673033
roll dart/engine to f27729e97b5a00c3a8d8d49edc7b998fa755b97a (#62368) 2020-07-27 17:51:31 -07:00
Jonah Williams cb615b3bd7
Revert "Make sure all isolates start during flutter driver tests. (#61841)" (#62239)
This reverts commit 5fa5701d72.
2020-07-24 18:16:44 -07:00
Zachary Anderson ab3a4b0e69
Revert "bump nullsafety deps (#61978)" (#62234)
This reverts commit c46aa360b0.
2020-07-24 16:31:42 -07:00
Alexandre Ardhuin c46aa360b0
bump nullsafety deps (#61978) 2020-07-24 16:17:08 -07:00
雷宇辰 7779a14794
[flutter_tools] Make flutter git upstream configurable (#61513) 2020-07-24 16:16:31 -07:00
Jenn Magder f9499f44f7
Detect exact device ID matches quickly (#62070) 2020-07-24 16:15:44 -07:00
Todd Volkert a48446f94b
Fix error handling for errors with empty stack traces (#62224)
Fixes https://github.com/flutter/flutter/issues/62223
2020-07-24 15:50:01 -07:00
Todd Volkert 6e252772d1
Add support for system alert sound (#62086)
* Add SystemSoundType.alert (supported in the engine in flutter/engine#19970)
* Play system alert sound when user tries to dismiss a non-dismissable modal
  barrier
2020-07-24 15:49:41 -07:00
Will Larche 7782845edd
[Material] Updated icons and fonts (#61778) 2020-07-24 15:41:13 -07:00
Pedro Massango 5142a30434
Add minWidth and height parameter into FlatButton widget (#61664) 2020-07-24 15:41:09 -07:00
Brian Eaton 5fa5701d72
Make sure all isolates start during flutter driver tests. (#61841) 2020-07-24 15:36:13 -07:00
Kate Lovett d1411a1626
Remove unused FlutterErrorDetails subclasses (#61579) 2020-07-24 15:36:08 -07:00
Jonah Williams c6dce2318b
[flutter_tools] remove breakpoints from paused isolate on hot restart (#62069)
The embedder requires that the isolate is unpaused, because the runInView method requires interaction with dart engine APIs that are not thread-safe. These APIs must be run on the same thread that would be blocked by the pause. Simply unpausing is not sufficient, because this does not prevent the isolate from immediately hitting a breakpoint, for example if the breakpoint was placed in a loop or in a frequently called method. Instead, all breakpoints are first disabled and then the isolate resumed.
2020-07-24 15:34:55 -07:00
Jonah Williams 6c6c7ba8ec
[flutter_tools] ensure x64 is built if target-platforms is not specified (#62096)
In the add-2-app case, users may not specify the android target platforms field, but this only defaults to arm builds. Add x64 to the default list.

Fixes #62095
2020-07-24 15:33:13 -07:00
Zachary Anderson 523afbe58b
Ensure analytics are sent before disabling (#62094) 2020-07-24 15:31:18 -07:00
Jonah Williams a7db3591cb
[flutter_tools] deflake fastReassemble test (#62152) 2020-07-24 15:17:39 -07:00
Zachary Anderson 5e0ba2290f
Pass --disable-dart-dev in more places (#62217) 2020-07-24 13:37:08 -07:00
chunhtai 561735ad89
Revert "remove usage to applyTextScaleFactorToWidgetSpan (#61636)" (#62144)
This reverts commit c816fabd0a.
2020-07-23 10:35:21 -07:00
Alexandre Ardhuin 8428cf30eb
Add template flutter.widgets.transitionRoute.reverseTransitionDuration (#62136) 2020-07-23 09:22:20 -07:00
Pedro Massango f025ca2fc6
Update basic.dart (#61961) 2020-07-23 08:46:04 -07:00
Alexandre Ardhuin a07219a310
migrate physics to nullsafety (#61941) 2020-07-23 08:41:04 -07:00
Abdur Rafay Saleem b50b5eadb0
Improved docs for minLines in EditableText (#61796) 2020-07-23 08:36:04 -07:00
LongCatIsLooong 64173f75c3
Check if a double is NaN before converting to it int (#61940) 2020-07-23 08:31:08 -07:00
Ming Lyu (CareF) 056e455e94
Add a E2E based performance test case (#61509) 2020-07-23 08:31:04 -07:00
Michael Goderbauer 8e58c51d1a
Update viewport dimensions when scrollDirection changes (#61973) 2020-07-23 08:30:26 -07:00
Michael Goderbauer 4b4287ba78
Make it an error to break macros in docs (and fix existing broken macros) (#62071) 2020-07-23 08:29:46 -07:00
Greg Spencer cac22cdb08
Fix ExcludeFocus so it won't refocus a sibling of the focused node. (#61756)
This changes FocusNode.descendantsAreFocusable so that it doesn't allow the enclosing scope to re-focus a node that is a descendant of the node with descendantsAreFocusable set to false.

Because of the order in which the internal state for descendantsAreFocusable was being set, setting it to false was causing a sibling node to be focused when descendantsAreFocusable of the parent was set to false, even though it shouldn't have been focusable, because the enclosing scope would search for a candidate to be focused before the internal state was set to false.

Instead of looping over the children and telling them all to unfocus (and select the previously focused node), this unfocuses the node that has descendantsAreFocusable set to false, with the disposition UnfocusDisposition.previouslyFocusedChild, so that its enclosing scope will look for a previously focused child that isn't part of the subtree being excluded.

This affects how the ExcludeFocus widget behaves when turning on exclude.
2020-07-23 08:27:53 -07:00
Abdur Rafay Saleem b8df8a8368
Allowed specifying reverseTransitionDuration in PageRouteBuilder class (#61752) 2020-07-22 18:41:09 -07:00
chunhtai c816fabd0a
remove usage to applyTextScaleFactorToWidgetSpan (#61636) 2020-07-22 18:41:06 -07:00
Jonah Williams a19fd72db5
[flutter_tools] check in script for generating per library unit coverage (#61996)
Allows generating a per-library coverage summary like https://gist.github.com/jonahwilliams/f298381c3fb9f472b2dfe54b82a20a88
2020-07-22 18:40:12 -07:00
Jonah Williams 3a976feb58
[flutter_tools] clean plugin dependencies file (#62061)
Clean even more, in case the plugin dependency update logic is wrong-o.
2020-07-22 18:39:33 -07:00
Greg Spencer 60314646b3
Find the target platform more accurately on the web. (#61587) 2020-07-22 18:36:08 -07:00
Pragya d95f79f95f
Updated instructions of 'flutter help attach' (#61569) 2020-07-22 18:31:12 -07:00
Ming Lyu (CareF) 9e2e0ef3b4
implement handlePointerEventRecord for LiveWidgetController (#61266) 2020-07-22 18:31:08 -07:00
Todd Volkert e91b833933
Minor doc updates (#62008) 2020-07-22 18:28:08 -07:00
Todd Volkert 67a9ae173b
Update Actions.invoke to return the result of invoking the action. (#62012)
The boolean value as to whether the action was found and enabled
is less useful than just returning the result of invoking the action
itself.
2020-07-22 18:27:38 -07:00
Pierre-Louis 629395f7ad
Add per thumb Range Slider semantics (#61439) 2020-07-22 18:26:11 -07:00
David Martos 6d303af97e
Use the correct Transform in the WidgetInspector overlay (#59566) (#60990) 2020-07-22 18:26:07 -07:00
huangchaoyang 9da74f66ca
Show correct errors when plugins yaml forgot the 'flutter.plugins.pla… (#61338) 2020-07-22 18:24:03 -07:00
Yazeed Al-Khalaf d41b1fbb50
✒ Spell Check All .md Files Related to Flutter 💙 (#61564)
* 🐛 Fix Spelling Issues in Main README.md

* 🐛 Fix spelling issues in dev README.md

* 🐛 Fix spelling issues in complex_layout README.md

* 🐛 Fix spelling issues in macrobenchmarks README.md

* 🐛 Fix spelling issues in platform_views_layout README.md

* 🐛 Fix spelling issues in test_Apps/stocks README.md

* 🐛 Fix spelling issues in bots README.md

* ✒ Spell Check dev/ci README.md

* ✒ Spell Check dev/ci/docker_linux README.md

* ✒ Spell Check dev/devicelab README.md

* ✒ Spell Check dev/docs README.md

* ✒ Spell Check dev/snippets README.md

* ✒ Spell Check dev/snippets/config/templates README.md

* ✒ Spell Check dev/tools/gen_keycodes README.md

* ✒ Spell Check dev/tools/vitool README.md

* ✒ Spell Check examples/catalog README.md

* ✒ Spell Check examples/flutter_view README.md

* ✒ Spell Check examples/image_list README.md

* ✒ Spell Check examples/layers README.md

* ✒ Spell Check examples/platform_channel README.md

* ✒ Spell Check examples/platform_channel_swift README.md

* ✒ Spell Check examples/platform_view README.md

* ✒ Spell Check packages/_flutter_web_build_script README.md

* ✒ Spell Check packages/flutter_localizations README.md

* ✒ Spell Check packages/flutter_tools README.md

* ✒ Spell Check CODE_OF_CONDUCT.md

* ✒ Spell Check dev/integration_test/android_splash_screens/splash_Screen_load_rotate README.md

* ✒ Spell Check dev/integration_test/android_views README.md

* ✒ Spell Check dev/integration_tests/flutter_driver_screenshot_test README.md

* ✒ Spell Check dev/integration_tests/flutter_gallery README.md

* ✒ Spell Check dev/integration_tests/gradle_deprecated_settings README.md

* ✒ Spell Check dev/integration_tests/ios_add2app_life_cycle README.md

* ✒ Spell Check dev/integration_tests/ios_host_app README.md

* ✒ Spell Check dev/integration_tests/ios_platform_view_tests README.md

* ✒ Spell Check dev/automated_tests/flutter_test README.md

* ✒ Spell Check .github/PULL_REQUEST_TEMPLATE.md

* ✒ Spell Check .hithub/ISSUE_TEMPLATE/ACTIVATION.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/BUG.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/feature_request.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_others.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_speed.md

* ✒ Spell Check packages/flutter_tools/doc/daemon.md

* ✒ Spell Check packages/flutter_tools/fuchsia_enrtypoint_shim/README.md

* ✒ Minimize line to 80 columns

* ✒ Minimize line to 80 columns

* ✒ Fix Typo

* ✒ Chnaged numbers to 1 for testing purposes

* ✒ Changed numbers to 1 for testing purposes

*  Remove 'a' which is a typo

* ✒ Change a sentence to be better

* ✒ Remove 'a' which is a typo

* ✒ Fix small issue

* ✒ Fix small typo

* ✒ Fix some typos

*  Remove trailing space

*  Remove trailing space

* 🐛 Fix small typo

* ✒ Fix Typo

* 🐛 Fix small bug
2020-07-22 18:23:47 -07:00
Jonah Williams 9f040865c9
[flutter_tools] macOS cleanups, attach to log reader in release mode (#61913) 2020-07-22 18:23:20 -07:00
Jenn Magder fe670c04cc
Only try to get build settings if the Xcode project exists (#61979) 2020-07-22 18:22:38 -07:00
Ben Konyi adc9dde3ba
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61975)" (#61993)
This reverts commit f7a1c87ffd.
2020-07-21 16:17:23 -07:00
Ben Konyi f7a1c87ffd
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61975)
This reverts commit 4867f5931f.
2020-07-21 15:44:38 -07:00
chunhtai c44e5a32b5
Revert "InkDecoration do not paint if it's part of the tree doesn't get painted (#61216)" (#61963)
This reverts commit fdf87edd2f.
2020-07-21 09:35:40 -07:00
Pierre-Louis 5d854f63a0
Implement customizable cursor height (#61714) 2020-07-21 07:36:03 -07:00
Ming Lyu (CareF) 3e7fe378e3
Reland "LiveTestWidgetsFlutterBinding support for non-touch event" (#61901) 2020-07-21 02:36:03 -07:00
includecmath aa9119e53b
[flutter_tools] Concise dart2js commands outputKernel & outputJavaScript (#61881) 2020-07-21 02:31:03 -07:00
Jonah Williams 8be1c9ef25
[flutter_tools] turn off fuchsia support by default (#61634) 2020-07-21 02:26:04 -07:00
Otokaze a821bdbfd0
Add more tips for androidLicensesUnknown (#61312) 2020-07-21 02:21:03 -07:00
Jason Simmons b3f0f092ec
Disable the deferred loading variant of gen_l10n_test (#61912) 2020-07-21 02:18:29 -07:00
Alexandre Ardhuin 9e658bc3d5
migrate scheduler to nullsafety (#61570) 2020-07-20 18:56:07 -07:00
xubaolin fdf87edd2f
InkDecoration do not paint if it's part of the tree doesn't get painted (#61216) 2020-07-20 18:56:04 -07:00
Ben Konyi 4867f5931f
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61882)" (#61909)
This reverts commit 895b7ef6fa.
2020-07-20 16:41:01 -07:00
Ben Konyi 895b7ef6fa
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61882)
This reverts commit 38fe887342.
2020-07-20 16:01:58 -07:00
Ming Lyu (CareF) f98a00c750
Revert "LiveTestWidgetsFlutterBinding support for non-touch event (#61872)" (#61900)
This reverts commit aa4b4d35e1.
2020-07-20 17:20:30 -04:00
Jonah Williams 07caa0fbfe
[flutter_tools] Add plumbing for widget cache (#61766)
To support #61407 , the tool needs to check if a single widget reload is feasible, and then conditionally perform a fast reassemble.

To accomplish this, the FlutterDevice class will have a WidgetCache injected. This will eventually contain the logic for parsing the invalidated dart script. Concurrent with the devFS update, the widget cache will be updated/checked if a single widget reload is feasible. If so, an expression evaluation with the target type is performed and the success is communicated through the devFS result. An integration test which demonstrates that this works is already present in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/hot_reload_test.dart#L86

Finally, when actually performing the reassemble the tool simply checks if this flag has been set and calls the alternative reassemble method.

Cleanups:

Remove modules, as this is unused now.
2020-07-20 14:03:44 -07:00
Ming Lyu (CareF) aa4b4d35e1
LiveTestWidgetsFlutterBinding support for non-touch event (#61872) 2020-07-20 17:02:59 -04:00
chunhtai 3577da53ff
Revert "fix intrinsic height and width for widget span (#61485)" (#61876)
This reverts commit fc09119d0a.
2020-07-20 09:54:50 -07:00
Alexandre Ardhuin 3f79310204
restore nullability of FlutterError.onError (#61844) 2020-07-20 18:45:04 +02:00
Helin Shiah 5b9ce492f3
Skip printing rendered error text in machine mode (#61684) 2020-07-20 09:41:03 -07:00
Jenn Magder c4bfa4c7ab
Inject iproxy into context (#61762) 2020-07-20 07:46:05 -07:00
Jonah Williams 78a975444a
[flutter_tools] revert dart format changes (#61760) 2020-07-20 07:41:05 -07:00
Michael Goderbauer 13ac541a00
Remove TODO arround deprecation (#61672) 2020-07-20 07:31:04 -07:00
Jason Simmons 27b306a3da
Track used Android pointer IDs and reuse IDs after a pointer is released (#61668) 2020-07-20 07:26:05 -07:00
Ming Lyu (CareF) 54c9441723
benchmarkLive: a new LiveTestWidgetsFlutterBindingFramePolicy for benchmark on device (#61388)
* add benchmarkLive flag and tests

* update handlePointerEventRecord doc

* using e2e 0.6.1
2020-07-17 18:56:12 -04:00
chunhtai 09dfca6f5d
add static method to create material hero controller (#61662) 2020-07-17 14:26:03 -07:00
Jimmy Wei 14dcbb2d84
Fix overflow issue caused by a long title/subtitle for the vertical stepper (#61623) 2020-07-17 14:21:03 -07:00
Chris Yang 30e556ddc5
Add no-op callbacks to platform view gesture recognizer when necessary (#61671)
After #31935, Some one sequence gesture recognizers requires at least one callback to be able to compete in the arena. This PR adds the a no-op callback in the gesture recognizer in the platform view when the gesture recognizer does not have any callbacks. This way, all the gesture recognizers in the platform view can compete in the arena.
2020-07-17 12:13:22 -07:00
Jenn Magder 55176c4d6f
Show device diagnostic messages in doctor (#61585) 2020-07-17 09:41:03 -07:00
Konstantin Scheglov 741e9675e7
Remote returns for function expression inferred return type void. (#61582) 2020-07-17 09:36:03 -07:00
Todd Volkert 1840b7121a
Make scrollbar thickness and radius customizable (#61401)
* Make scrollbar thickness and radius customizable

https://github.com/flutter/flutter/issues/29576
https://github.com/flutter/flutter/issues/36412

* Add docs for constants

* No more magic numbers in test
2020-07-16 23:15:23 -07:00
Todd Volkert 5587ca17e8
Add assert in PictureLayer.addToScene() (#61655)
SceneBuilder.addPicture() is implemented in C++, and if `picture`
is null, it will seg-fault. This catches the problem before that
happens.
2020-07-16 23:14:56 -07:00
Todd Volkert 7ea710c56e
Fix Border.symmetric: phase 2 (#61666)
This updates the default value of the `invertMeaningOfVerticalAndHorizontal`
argument from true to false.

https://github.com/flutter/flutter/issues/61470
2020-07-16 23:14:44 -07:00
Christopher Fujino df542b6831
update packages and update template (#61678) 2020-07-16 18:32:46 -07:00
Ming Lyu (CareF) 8badf93609
Revert "update packages (#61647)" (#61674)
This reverts commit b7b60a2d2c.
2020-07-16 20:13:18 -04:00
Michael Goderbauer 1b406159f2
Give better error message for describeEnum (#61581) 2020-07-16 16:21:05 -07:00
Ming Lyu (CareF) b7b60a2d2c
update packages (#61647) 2020-07-16 18:55:42 -04:00
Ben Konyi 38fe887342
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61633)" (#61641)
This reverts commit 594c3541aa.
2020-07-16 11:43:54 -07:00
Sam Rawlins 45e097da16
Remove unused parameter from private method in widget_inspector (#61572) 2020-07-16 11:41:03 -07:00
Ben Konyi 594c3541aa
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61633)
This reverts commit a1a5a8f635.
2020-07-16 11:38:17 -07:00
Christopher Fujino f796e047fd
Verbose process exceptions (#61552) 2020-07-16 11:31:03 -07:00
Bogdan Lukin 9ef8192760
Fix/decoration equality (#61551) 2020-07-16 11:26:04 -07:00
Darren Austin c78578417d
Updated date pickers to use the new TextButton in place of FlatButton. (#61489) 2020-07-16 11:21:04 -07:00
Jonah Williams 859fce9010
[flutter_tools] add feature for iOS, android, and fuchsia (#61481)
Add feature flags for android, ios, and fuchsia (on by default). After updating the g3 rollers, the fuchsia feature will be turned off by default. Creates a simpler base type of feature flags for g3 to extend.

Updates android, ios, fuchsia workflows to use feature flags check.
Removes concept of stable artifacts and checks on flutter version.

Fixes #58999
#52859
#12768
2020-07-16 09:51:59 -07:00
Jonah Williams 045f3a54f5
[flutter_tools] turn down flutter generate (#61475)
complete removal of all generate functionality

Fixes #61508
2020-07-16 09:51:22 -07:00
Todd Volkert e2cdc9f981
Allow transparent barrierColor in showDialog methods (#61516)
`showDialog()` and `showGeneralDialog()` were allowing transparent
colors but then triggering an assertion down the stack while building
the modal barrier. The assertion existed to keep from animating from
transparent to transparent, but there's no need for the assertion,
since we can just treat the transparent case as the same as the null
case -- no animation necessary.
2020-07-16 09:43:47 -07:00
Darren Austin 681395e888
Updated time pickers to use the new TextButton in place of FlatButton. (#61492) 2020-07-16 09:43:16 -07:00
Kate Lovett 16d5dd9b13
Fix NestedScrollView inner ballistic activity for 0 velocity (#61386) 2020-07-16 09:41:04 -07:00