development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-14 04:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity
19789 commits 770 branches 974 tags 1.7 GiB
Commit graph

13881 commits

Author SHA1 Message Date
Danny Tuppeny f8135add8e
Add a flag for using WS for debug backend (#61359) 2020-07-13 13:31:04 -07:00
Tong Mu da8695d389
Mouse events report correct local positions (#61190) 2020-07-13 13:26:03 -07:00
chunhtai 067d3da827
Revert "Adds semantics information for the popup menu item (#61258)" (#61377) 
This reverts commit c6058df9ca.
 2020-07-13 12:24:42 -07:00
chunhtai c6058df9ca
Adds semantics information for the popup menu item (#61258) 2020-07-13 11:21:03 -07:00
rami-a b79efb8da3
[Material] Allow for customizing Snack bar margin, padding, and width (#61180) 2020-07-13 14:19:45 -04:00
Jenn Magder cda6c27ff7
Add spaces between sentences in help text (#61135) 2020-07-13 11:16:03 -07:00
xster 8bd2e6585b
Remove v1 Android create templates (#61203) 2020-07-11 12:15:19 -07:00
Hans Muller eac1747169
Renamed ContainedButton et al. to ElevatedButton et al. (#61262) 2020-07-11 08:50:43 -07:00
Greg Spencer b267e7bd9b
This fixes a compile error in the form field example, and switches to using space instead of enter as the example for moving to the next field, since the text field on web unfocuses automatically when enter is pressed. (#61123) 2020-07-10 18:06:02 -07:00
Anna Gringauze 9cbe1dccf3
Added web compiler debug metadata (#61265) 
Made flutter tools serve metadata produced by the frontend server:

pass --experimental-emit-metadata flag to flutter engine
store and serve metadata from web asset server
store and serve merged metadata from web asset server
add tests to verify that metadata is served from memory
update dwds version so it can read metadata
configure dwds to read metadata from file
Prerequisite changes (landed):

sdk: https://dart-review.googlesource.com/c/sdk/+/150181
flutter engine: flutter/engine#19168
webdev:dart-lang/webdev#1064
 2020-07-10 16:36:43 -07:00
Dan Field cd80ed3009
Fix bold not getting cleared on new line (#61256) 
* Fix bold not getting cleared on new line
 2020-07-10 16:09:49 -07:00
Dan Field 5b9c6e2b0e
Revert "Add support for Dart Development Service (DDS) in Flutter Tools (#59114)" (#61276) 
This reverts commit fe7bbf7226.
 2020-07-10 15:53:35 -07:00
Ben Konyi fe7bbf7226
Add support for Dart Development Service (DDS) in Flutter Tools (#59114) 2020-07-10 15:35:21 -07:00
Nolan Scobie dc0f122881
Revert "Revert "Tweaking Material Chip a11y semantics to match buttons (#60141)" (#60645)" (#61048) 2020-07-10 14:21:03 -07:00
Ming Lyu (CareF) a76b5eb79f
Add support in WidgetTester for an array of inputs (#60796) 
* Add input event array support

* Add a tap test

* remove unused import

* remove extra assert
 2020-07-10 17:03:12 -04:00
Jonah Williams 66556faef7
[flutter_tools] deflake integration test with tryToDelete (#61253) 2020-07-10 13:29:49 -07:00
Kaushik Iska afd745e893
Filter profiling events by names not category (#61185) 
Category isn't preserved by timeline events as `Dart_TimelineEvent`
specifies the category as `embedder`.

Fixes: https://github.com/flutter/flutter/issues/60008
 2020-07-10 12:13:56 -07:00
Jonah Williams 1c1ef133ee
[flutter_tools] remove globals from device manager, flutter tester (#61139) 
Remove global variables from device manager, flutter tester devices and update tests
 2020-07-10 11:52:09 -07:00
Jonah Williams fbca40add2
[flutter_tools] abstract logger construction (why can't I hold all these loggers) (#61201) 
We have too many loggers, and the logger construction rules are too complicated to be untested. Capture these in a LoggerFactory and test that construction is correct.
 2020-07-10 11:51:47 -07:00
Jonah Williams d14a898f69
remove LICENSE/NOTICES work around (#61199) 
Now that google3 has been updated, remove the LICENSE loading fallback. This was done in cl/320506032

#16723
 2020-07-10 11:37:48 -07:00
Ayush Bherwani fd80503fd3
[Api docs] Updates ListTile.subtitle docs to address how TextStyle is decided (#61071) 2020-07-10 02:11:02 -07:00
Jonah Williams 6eaaf1650e
[flutter_tools] switch order of injection (#61191) 
Inject loggers in the right order, test WIP. Otherwise verbose machine would not get the AppRunLogger
 2020-07-09 18:04:37 -07:00
Jenn Magder 20fe2f88c5
Prefer tear offs to lambdas in test expects (#61196) 2020-07-09 17:58:51 -07:00
Jonah Williams ed9a705ec2
[flutter_tools] allow unmuting of command logging (#61198) 
Running flutter doctor -v prints out extra details instead of running in verbose mode. Allow disabling this with -vv so it can be debugged.
 2020-07-09 17:55:53 -07:00
Kate Lovett 01ac509620
Skip Audit - Last Leftovers (#60940) 2020-07-09 17:01:01 -07:00
Jenn Magder e110ca7209
Case insensitive check flavor names against Xcode schemes (#61140) 2020-07-09 16:56:02 -07:00
Max Weber c29009b3e8
Added the materialTapTargetSize to the OutlineButton Constructor (#61086) 2020-07-09 14:56:01 -07:00
Kate Lovett e3079a3339
Add additional float location case (#61171) 2020-07-09 14:06:03 -07:00
Alexandre Ardhuin f32a73711a
use nnbd deps (#61177) 2020-07-09 23:01:22 +02:00
Tong Mu d4b4eeed7d
Add all system cursors (framework) (#60931) 2020-07-09 14:01:03 -07:00
includecmath 72258eac5f
[flutter_tools] Separate style and data from AnalysisError (#60591) 2020-07-09 13:51:02 -07:00
remin c65f32f447
Add ThemeData.shadowColor (#60337) 2020-07-09 13:46:04 -07:00
Hans Muller dc31d89c56
New Button Universe (#59702) 2020-07-09 13:41:03 -07:00
Kate Lovett ea777fea1b
Skip Audit - Rendering Library (#58640) 2020-07-09 13:36:03 -07:00
Shi-Hao Hong 61a04b1551
Fix and address Inconsistencies with Pashto support (#60600) 
* Normalize Pashto incomplete translations

* Add comment to README.md about incomplete Pashto support
 2020-07-09 15:52:19 +08:00
Dan Field a9ea825abf
Do not cache itemBuilder calls in a GridView (#61033) 2020-07-08 21:26:03 -07:00
LongCatIsLooong a6ce2d4bc7
Assert valid composing TextRange (#60956) 2020-07-08 21:21:02 -07:00
Dan Field c6fd42499a
Test update_packages for git packages (#61127) 2020-07-08 19:31:02 -07:00
Kate Lovett debb3a5d28
Skip Audit - Widgets Library (#60936) 2020-07-08 19:26:03 -07:00
Robert Ancell 266aeb81a0
Only try the GDK X11 backend, as the FlView only currently supports X11 (#60654) 2020-07-09 14:23:48 +12:00
Jonah Williams d4589e0c71
[flutter_tools] ensure AppRunLogger is injected for run/attach machine (#61103) 
run/attach --machine requires a different logger than daemon, which uses the NotifyingLogger. We have too many loggers!

Fixes #59463
 2020-07-08 18:21:46 -07:00
chunhtai 496ef4f77e
prevents sliver app bar from changing semantics tree when it is not necesaary (#61012) 2020-07-08 18:21:08 -07:00
chunhtai 06b301cdfc
fix semantics to only send relevant node update (#60925) 2020-07-08 18:21:04 -07:00
Kate Lovett b345ecc11b
Skip Audit - Scheduler and Services libraries (#60934) 2020-07-08 18:16:08 -07:00
chunhtai 00b1903bbc
Add a flag to toggle navigator route update reporting (#60621) 2020-07-08 18:16:04 -07:00
Ayush Bherwani 5a00d54eec
[AppBar] adds leadingWidth property to customize width of leading widget (#60915) 2020-07-08 18:11:07 -07:00
includecmath 93eac884eb
[flutter_tools] Clean code analyze command (#60200) 2020-07-08 18:11:03 -07:00
Jonah Williams 741608a261
[flutter_tools] fix recursive asset variant issue (#61129) 
Fixes #45075
Fixes #57210

If an asset was included directly from the project root directory, then the same asset when copied to various output or ephemeral directories would also be picked up as an asset variant. This could cause assets to be recursively copied into asset/build/ephemeral directories, as each time it would run it would pick up all of the previous "variants".

The solution is to include project ephemeral directories, in addition to the build directory.
 2020-07-08 18:07:27 -07:00
chunhtai 589b327816
Issues/58665 reland and prevent the material widget from absorbing gesture (#60536) 2020-07-08 17:46:03 -07:00
Juyeong Lee e2a638e66d
Fix docs for TabBar indicator (#60482) 2020-07-08 17:41:05 -07:00
Ming Lyu (CareF) a5fa083906
Add comment explain dispatchEvent override (#60734) 2020-07-08 18:37:33 -04:00
Ming Lyu (CareF) 78bb587c70
respect line wrapping style guide (#61118) 2020-07-08 16:44:59 -04:00
Ming Lyu (CareF) 61477b5949
Fix PointerAddedEvent handling in LiveTestWidgetsFlutterBinding (#61102) 
* Fix PointerAddedEvent handling in tester
 2020-07-08 13:28:51 -04:00
Mehmet Fidanboylu cc1af3afb6
Revert "Expose height and width factor in AnimatedAlign (#60836)" (#61109) 
This reverts commit e8e1eb51a4.
 2020-07-08 10:19:36 -07:00
Jonah Williams 0cff654220
[flutter_tools] add sdk constraint to plugin/package templates (#60932) 
Gives plugin and package a constraint on the flutter version, which will be from 2 stable's ago when this goes to stable. Adds an upper bound of 2.0
 2020-07-08 10:11:10 -07:00
Maurice Parrish 7d7907e6c1
Fix bug where dispose message requires a map (#61035) 2020-07-08 09:57:34 -07:00
Sim Kern Cheh 5f49654734
Issue with comparison operator in generated service worker (#61066) 2020-07-08 09:56:02 -07:00
Justin McCandless a82005a9dc
InteractiveViewer pan axis locking (#61019) 2020-07-08 09:51:02 -07:00
Per Classon df64d1b303
Remove shouldCapTextScaleForTitle from AppBarTheme (#61000) 2020-07-08 09:46:02 -07:00
Natan Portilho f567a0cc98
Device manager choose running device (#57349) 2020-07-08 09:41:02 -07:00
Dan Field d45ad057b4
Handle git dependencies, roll packages to get transitive deps of flutter_gallery (#61064) 2020-07-07 22:21:19 -07:00
Jonah Williams 07e2d6f63b
[flutter_tools] make precache force blow away stamp files (#61003) 
update flutter precache --force to delete all stamp files. In the event that a user is hitting a cache issue, this should be easier than re-downloading all artifacts or manually blowing away the cache.

This is probably how it should have worked in the first place
 2020-07-07 19:33:25 -07:00
Jonah Williams 77310c152f
[flutter_tools] deprecate flutter version (#60998) 2020-07-07 18:04:02 -07:00
rami-a 843231bbc2
[Material] Misc fixes for time picker input mode (#60991) 2020-07-07 17:59:03 -07:00
Tonic Artos a167610e17
Remove superfluous GestureDetector. (#60730) 2020-07-07 17:54:03 -07:00
Kaushik Iska ff6b7809bc
Re-land gesture detection for hybrid platform views (#61013) 2020-07-07 17:49:54 -07:00
Kate Lovett 3176232cb4
Doc and Error Message Improvements (#60726) 2020-07-07 17:49:03 -07:00
Neevash Ramdial e8e1eb51a4
Expose height and width factor in AnimatedAlign (#60836) 2020-07-07 17:44:07 -07:00
Jason Simmons 5cf0d73764
In layers_test create a canvas to start recording on the PictureRecorder (#60660) 2020-07-07 17:44:02 -07:00
zljj0818 11ff938af5
Added a filterQuality parameter to texture (#59966) 2020-07-07 17:39:04 -07:00
Dan Field 33aa457604
Roll packages (#61034) 
Roll packages, update XML deprecations.
 2020-07-07 16:40:33 -07:00
Dan Field fb57edcc80
Revert "Revert "Fix remaining holes in stack trace demangling (#60478)" (#60916)" (#60996) 
This reverts commit 2c7e5dd935.
 2020-07-07 15:30:32 -07:00
Kaushik Iska 8ed8b06ac5
Revert "Add embedderId to PointerEvent (#60930)" (#61010) 
This reverts commit 2ab5099436.
 2020-07-07 12:12:20 -07:00
Kaushik Iska 2ab5099436
Add embedderId to PointerEvent (#60930) 
This field is used to look-up the event in the platform
that resuted a given `PointerEvent`. This is currently only
used on Android, where the `embedderId` is set to be the
`motionEventId` for a given `MotionEvent`.

Roll engine to d0d6a4c2362d2ed478006bb3b01c34c0e96033b4
 2020-07-07 10:59:12 -07:00
Jonah Williams f111a823ec
[flutter_tools] remove some globals from flutter_tester device (#60787) 
Remove globals from flutter_tester device and cleanup test case. Not completely gone since the Kernel Builder will still use them, but a good incremental improvement.
 2020-07-07 10:24:52 -07:00
Jonah Williams 846418b60b
[flutter_tools] fix crash if the platform section was a list (#60927) 
Missed validation to go with cast. Added test case to reproduce.
 2020-07-07 10:24:42 -07:00
Per Classon db5a62b0ee
Support customizing colors for rows in DataTable (#60764) 2020-07-07 10:24:02 -07:00
Mehmet Fidanboylu 8c67781f36
Comments around hanging tests via runAsync. (#60136) 2020-07-07 09:14:02 -07:00
Jose Alba 9265bdd1ad
RangeSlider overlap properly (#60549) 2020-07-06 17:54:02 -07:00
Darren Austin 5fa937edd1
Keyboard navigation fo the Material Date Range Picker (#60497) 2020-07-06 17:49:03 -07:00
Tong Mu 6f4c4b3cf8
Refactor mouse hit testing system: Direct mouse hit test (#59883) 2020-07-06 17:44:02 -07:00
stuartmorgan 4b12050112
Switch Windows to CMake (#60629) 
* First pass at CMake files; untested

* First pass of adding CMake generation logic on Windows

* Misc fixes

* Get bundling working, start incoprorating CMake build into tool

* Fix debug, exe name.

* Add resources

* Move cmake.dart

* Rip out all the vcxproj/solution plumbing

* Fix plugin cmake generation

* Build with cmake rather than calling VS directly

* Adjust Windows plugin template to match standard header directory structure

* Pass config selection when building

* Partially fix multi-config handling

* Rev template version

* Share the CMake generation instead of splitting it out

* VS build/run cycle works, with slightly awkward requirement to always build all

* Update manifest

* Plugin template fixes

* Minor adjustments

* Build install as part of build command, instead of separately

* Test cleanup

* Update Linux test for adjusted generated CMake approach

* Plugin test typo fix

* Add missing stub file for project test

* Add a constant for VS generator
 2020-07-06 12:59:16 -07:00
giga10 35df978124
Fix typo (#60832) 2020-07-06 12:58:23 -07:00
Jenn Magder 11bf7f0687
Take screenshots of wirelessly paired iOS devices (#60623) 2020-07-06 12:28:29 -07:00
Ram Navan 60deae8546
Issues/58053 - Set default textBaseline to alphabetic in the Table widget (#60586) 2020-07-06 12:19:02 -07:00
Dan Field 2c7e5dd935
Revert "Fix remaining holes in stack trace demangling (#60478)" (#60916) 
This reverts commit d986fdc31a.
 2020-07-06 10:07:36 -07:00
Andre d986fdc31a
Fix remaining holes in stack trace demangling (#60478) 
* Implement stack trace demangling in the framework.
 2020-07-06 08:11:03 -07:00
Nils Reichardt edbd09379b
ListTile Mouse Pointer Fix (#60563) 2020-07-05 11:53:04 -07:00
Maurice Parrish dcbc694b58
Have AndroidViewController extend PlatformViewController and add support for hybrid platform views (#60320) 2020-07-05 11:43:02 -07:00
Pierre-Louis 0bc4368233
Typo sweep (#60693) 2020-07-02 13:08:02 -07:00
Jonah Williams ae9ac9f211
[flutter_tools] support starting in canvaskit with FLUTTER_WEB_USE_SKIA=true (#60708) 2020-07-01 22:53:03 -07:00
Jonah Williams 2f43aeaf54
[flutter_tools] fix crash if grouped doctor validator crashes (#60658) 2020-07-01 22:48:02 -07:00
Justin McCandless 84fc52e1e9
InteractiveViewer with a changing screen size (#60532) 2020-07-01 22:43:03 -07:00
Panmari 14a4ed5888
Adding "Widget of the week" video for color filtered. (#60481) 2020-07-01 22:38:03 -07:00
Justin McCandless 533c6b29b4
Show hint when label is floating (#60394) 2020-07-01 22:33:02 -07:00
Per Classon b35f2cd4ca
Enable shouldCapTextScaleForTitle by default (#60684) 2020-07-01 10:53:01 -07:00
Gary Qian 0e735e4bca
Expose ComputePlatformResolvedLocale (#58482) 2020-06-30 18:54:02 -07:00
gaaclarke e8670de011
Revert "Tweaking Material Chip a11y semantics to match buttons (#60141)" (#60645) 2020-06-30 18:28:01 -07:00
Justin McCandless 8ab513a0c9
InteractiveViewer scroll direction (#60523) 2020-06-30 16:23:01 -07:00
Jonah Williams c543db70dc
[flutter_tools] add null-safety flags to dill cache location (#60633) 
initialize from dill does not handle changing null-safety flags and will incorrectly use the nullability mode of the last compile. Add all extra frontend options to the unique name prefix for the flutter run dill cache to avoid this situation.
 2020-06-30 15:49:31 -07:00
Chris Yang 07e24f6dad
[flutter_tool] fix ide-config crash because of no android key (#60617) 2020-06-30 13:01:47 -07:00
Jonah Williams 7ca324ac01
[flutter_tools] support sound null-safety mode for the web (#60570) 
In web debug mode, infer sound null safety by default. When sound null safety is enabled, provide a separate dill and precompiled Dart SDK. Release builds do not need this setting since we run dart2js from source.

Fixes #59873
 2020-06-30 12:29:42 -07:00
Jonah Williams 2188196125
[flutter_tools] ensure flutter daemon can exit correctly when app fails to start (#60615) 
The flutter daemon unconditionally waits for the appFinished signal, even if startup failed. Ensure this future is correctly completed if there is a failure in ResidentRunner.run and not just ResidentRunner.attach. Adds regression tests for run release, debug, debug web, and release web. Adds missing try catch in cold runner startup.

Manually tested with release/debug on Android and release/debug on web.

Fixes #60613
 2020-06-30 12:26:18 -07:00
James D. Lin cf8fbc363a
[flutter tools] Revert desktop device name changes and print the category instead (#60395) 2020-06-30 11:28:02 -07:00
Greg Spencer ca713557d7
New license page with fix for zero licenses. (#60552) 
This amends #57588 by adding code that also handles the zero license case, and adds translation strings for that.
 2020-06-30 09:15:04 -07:00
Christopher Fujino b15798fa98
Revert "Revert "[flutter_tools] update libimobiledevice (#59512)" (#60551)" (#60569) 
This reverts commit 09cca73aee.
 2020-06-29 18:29:58 -07:00
Jonah Williams 55e3770f3e
[flutter_tools] remove globals from base/android (#60480) 
Remove unnecessary use of globals from base tests, and an android test. This changes the test to avoid bouncing through the global getters, which can lead to incorrectly cached zone values. Switches the memory filesystem implementation to the test implementation
 2020-06-29 15:06:58 -07:00
featherless c239d952a5
Annotate RawMaterialButton as a Material > Button category. (#60545) 2020-06-29 14:58:01 -07:00
Jenn Magder d5225a560d
Fix daemon device discovery crash when Xcode isn't installed (#60546) 2020-06-29 14:54:19 -07:00
Christopher Fujino 09cca73aee
Revert "[flutter_tools] update libimobiledevice (#59512)" (#60551) 
This reverts commit 32000db52e.
 2020-06-29 13:44:38 -07:00
Christopher Fujino 32000db52e
[flutter_tools] update libimobiledevice (#59512) 2020-06-29 13:17:04 -07:00
chunhtai 163a09a535
Revert "fix paint order of ink feature (#59108)" (#60530) 
This reverts commit 1e843bb6ba.
 2020-06-29 10:19:43 -07:00
Darren Austin ed05fd7517
Date picker string translations (#60405) 2020-06-29 10:08:02 -07:00
Darren Austin 812c189de8
Fixed a problem with date calculations that caused a test to fail in a non-US time zone. (#60396) 2020-06-29 10:03:02 -07:00
Justin McCandless f6cd2d4b35
Don't access clipboard passively on iOS (#60316) 2020-06-29 09:43:03 -07:00
Dan Field 06d0cd514e
Allow detection of images using more memory than necessary (#59877) 2020-06-26 15:34:41 -07:00
Kate Lovett fd7a72ee6f
Ensure FloatingActionButtonLocations are always within safe interactive areas (#60248) 2020-06-26 15:18:02 -07:00
Jenn Magder a4fa61b4f1
Use ephemeral ports for iOS port forwarding (#60381) 2020-06-26 15:02:05 -07:00
Nolan Scobie da489c337a
Tweaking Material Chip a11y semantics to match buttons (#60141) 2020-06-26 17:24:27 -04:00
MH Johnson 3ce2691092
[Semantics] Update bottom nav semantics tests to use matches semantics (#60329) 2020-06-26 14:08:02 -07:00
rami-a 7d8d086371
Add property to theme dial label colors (#60383) 2020-06-26 16:38:21 -04:00
Jonah Williams e1538d1b88
[flutter_tools] last pass on general.shard unit tests (#60263) 
Last batch of test fixes for general shard.
 2020-06-26 13:36:06 -07:00
Yegor 7518a146c2
Do not call Picture.toImage on web during shader warm-up (#60379) 2020-06-26 13:33:02 -07:00
Michael Goderbauer 769468298b
Do not return partial semantics from tester.getSemantics (#60367) 2020-06-26 11:03:02 -07:00
Alberto Monteiro aa0382e95d
ReorderableListView should not reorder if there is only a single item present (#59631) 2020-06-26 08:08:01 -07:00
Jonah Williams 4bb6096086
[flutter_tools] surface null safety/experiment flags in attach (#60317) 
Missed this one. Needed for google3 and add2app workflows
 2020-06-25 15:44:57 -07:00
chunhtai 3e5c700fd7
Add material page, cupertino page, and transition page classes (#58511) 
* Add material page, cupertino page, and transition page classes

* update

* update comments

* fix test

* addressing comments

* make page getter private
 2020-06-25 14:47:01 -07:00
chunhtai 1e843bb6ba
fix paint order of ink feature (#59108) 2020-06-25 12:53:03 -07:00
Jonah Williams 82a6f9bf0b
[flutter_tools] remove most use of global packages path (#60231) 
The global packages path could cause tests to fail when it would be overriden to unexpected (in test setup) values. Remove most usage and make it a configuration on buildInfo, along with most other build information. Cleanup the asset builder to require the .packages path and the resident runners to no longer require it, since they already have the information in build_info.

It needs to stick around for the fuchsia deps we do not control.

Filled #60232 for remaining work.
 2020-06-25 12:52:14 -07:00
Greg Spencer c68758fab1
Implement delayed key event synthesis support for Android (#59358) 2020-06-24 21:23:02 -07:00
Shi-Hao Hong 17cb865ec6
Revert "Revert "[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more than once (#58686)" (#59992)" (#60245) 2020-06-24 17:03:01 -07:00
Jenn Magder 0486cebd29
Make module run script names unique (#60228) 2020-06-24 16:52:01 -07:00
Jonah Williams 5cfcae004a
[flutter_tools] fix tests that depend on correct cache existance (#60241) 
These tests will hit the real Cache, failing if the flutter root has been modified
 2020-06-24 16:45:46 -07:00
Jonah Williams a0334fb500
[flutter_tools] maintain file manifest for create (#59706) 
First pass at fixing #57985 and implementing #59602

This doesn't have enough metadata to be useful for IDEs yet, but it prevents the issue from getting worse while we iterate on it.
 2020-06-24 16:20:21 -07:00
Jonah Williams 2a7ee930c3
[flutter_tools] Update WebAssetServer to avoid context, fix tests (#60224) 
WebAssetServer could fail if some of the global statics it depended on were initialized in a different order. Fix this by removing globals.

Delete dwds startup test that needs to spawn a real server.
 2020-06-24 16:19:49 -07:00
chunhtai 62378a3755
fix ink feature tries to get parent transformations when it is in the… (#60129) 2020-06-24 13:53:01 -07:00
Ayush Bherwani 3377781798
[AppBar] adds toolbarHeight property to customize AppBar height (#59405) 2020-06-24 13:08:01 -07:00
Kate Lovett 4d2ddb9199
Doc Updates (#60222) 2020-06-24 12:28:01 -07:00
stuartmorgan d9902a5474
Consider the Linux template stable (#60163) 
Remove the version checking and associated warnings. The Linux template
and build process will now be subject to more typical Flutter breaking
change policy, and should no longer require regularly deleting and
recreating the platform directory.
 2020-06-24 12:23:57 -07:00
Justin McCandless 42e67550af
Update inaccurate documentation for isUtf16Surrogate method (#60219) 2020-06-24 12:18:02 -07:00
Jonah Williams f8c9e1bb67
[flutter_tools] de-flake integration tests (#60221) 
The vm_service_integration test flake is caused by trying to call the method before the framework is initialized (and the extension added). The run errors failure is caused by the error taking some time to propagate to the harness
 2020-06-24 12:14:58 -07:00
David Worsham db48cadd0d
Remove unused physicalDepth code (#60152) 2020-06-24 11:33:01 -07:00
Jonah Williams 9e30d51ac6
[flutter_tools] start fixing command tests (#60172) 2020-06-24 11:26:36 -07:00
Chris Yang 95b98dc2c2
flutter create . on plugins also regenerates files for platforms supported in pubspec.yaml (#60159) 2020-06-24 10:38:03 -07:00
chunhtai 5623fea53c
Reverse the semantics order of modal barrier and modal scope (#59290) 
* Add semantics sort key for modal scope and modal barrier

* fix test

* fix test

* fix test

* fix space

* fix more tests

* addressing comments
 2020-06-24 10:37:53 -07:00
rami-a 50612db86e
Localized new strings added in the redesigned Material Time Picker (#60096) 2020-06-24 10:33:03 -07:00
Jonah Williams 5d61bff294
[flutter_tools] even more test fixes (#60156) 
Fix tests broken under tester
 2020-06-24 10:23:59 -07:00
Darren Austin b946e30c3d
Fix a couple of doc typos. (#60139) 2020-06-23 17:58:01 -07:00
Jonah Williams dd49e57be2
[flutter_tools] more test fixes (#60144) 
Fixes additional bugs uncovered by tester, style fixes to prevent suggested imports.
 2020-06-23 17:53:00 -07:00
Justin McCandless 766e0fa9ef
Export characters (#59620) 2020-06-23 17:43:02 -07:00
Chris Yang 2e63b7d4f8
Add --platforms to flutter create -t plugin command (#59507) 2020-06-23 17:38:03 -07:00
Jonah Williams 14992c5951
Revert "[flutter_tools] separate target platform, host platform, and architecutre (#60119)" (#60147) 
This reverts commit 30d97d89e0.
 2020-06-23 17:19:29 -07:00
Jonah Williams 37db92beeb
[versions] update all versions and fix tool tests (#60127) 
Update all versions, specifically file which fixes some bugs that caused tests to fail if run in different orders:

- systemTemp directories created by MemoryFileSystem will allot names based on the file system instance instead of globally.
- MemoryFile.readAsLines()/readAsLinesSync() no longer treat a final newline in the file as the start of a new, empty line.
- RecordingFile.readAsLine()/readAsLinesSync() now always record a final newline.
 2020-06-23 15:48:37 -07:00
Darren Austin 3a226df607
Expose the ElevationOverlay functions so applications can use the directly. (#60059) 2020-06-23 15:43:01 -07:00
Dan Field 868c4d8ce0
Fix issue with stack traces getting mangled (#59900) 2020-06-23 15:29:57 -07:00
Justin McCandless 2a573a32fe
Reland Characters Usage (#59778) 
Use Dart's characters package to fix user-facing grapheme cluster bugs.
 2020-06-23 15:28:26 -07:00
chunhtai 3a15841d94
reland "fix the widget span layout when text scale factor != 1" and h… (#60021) 2020-06-23 15:18:02 -07:00
Christopher Fujino ca32668b0b
port devicelab from idevice_id -> xcdevices (#59907) 2020-06-23 14:37:14 -07:00
Jenn Magder c8e53b3859
Add null safety options to build ios-framework (#60111) 2020-06-23 14:35:45 -07:00
David Iglesias 8fce4ce974
[flutter_tools] Add web support through MethodChannels. (#60116) 2020-06-23 13:53:01 -07:00
Jonah Williams 30d97d89e0
[flutter_tools] separate target platform, host platform, and architecutre (#60119) 
separate target platform, host platform, and architecture
 2020-06-23 13:51:17 -07:00
Craig Edwards 159557eb6e
iOS mid-drag activity indicator (#58392) 2020-06-23 11:24:09 -07:00
Jonah Williams 2a1c078b76
[flutter_tools] add null safety argument to unbreak frob (#60102) 2020-06-23 11:20:49 -07:00
chunhtai 4953cbce23
Fix the layout calculation in sliver list where the scroll offset cor… (#59888) 2020-06-23 11:18:01 -07:00
Jonah Williams e34c591252
[flutter_tools] fix root directory tests (#60060) 
* fix test compiler test
* fix project test
* fix flutter_platform_test
* fix cocoapods test
 2020-06-23 11:14:38 -07:00
MH Johnson 1c1326ad81
add check for DefaultTextHeightBehavior in EditableText + tests (#59913) 2020-06-23 12:39:35 -04:00
Dan Field e8fa87e303
Make upscaling images opt-in (#59856) 
* Make upscaling images opt-in
 2020-06-23 09:20:28 -07:00
Tonic Artos 65550d0f0c
New license page. (#57588) 
This is a PR addressing #57226 - Proposal: New UI for Licenses Page.

This PR replaces the previous single panel license page with one that uses a master/detail flow (MDFlow) to display packages and their respective licenses.

The License Page API remains unchanged. The logic for processing the license data is kept largely the same. This PR changes how the licenses are displayed, by introducing a responsive UI using the master/detail UI pattern. For now I am calling it Master Detail Flow, or MDFlow.

MDFlow manifests as two layouts depending on the screen size. On small and medium displays, as determined by the breakpoints given by the Material Design Spec, MDFlow utilises a nested layout. On large displays, MDFlow uses a two panel (lateral) layout. MDFlow is implemented in this PR using a Navigator for the nested layout, and a Stack for the lateral layout. The master and detail views are built using builders. For the interactive component, detail pages are requested from the master view using a proxy obtained by a widget lookup on the build context; MasterDetailFlow.of(context).
 2020-06-23 09:19:45 -07:00
renyou 15a28159bc
Revert "[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more than once (#58686)" (#59992) 
This reverts commit fe15d1e793.
 2020-06-23 04:52:58 -07:00
Robert Ancell 8c3b826ebd
Support GTK keycodes (#59961) 2020-06-23 15:19:57 +12:00
Robert Ancell 65ea2be51b
Remove Linux shell window_configuration.cc (#59802) 
Remove Linux shell window_configuration.cc/.h

It was a temporary solution while the shell was changing.
 2020-06-23 15:18:30 +12:00
stuartmorgan b5ddf85595
Fix typo in Linux CMake template (#60017) 2020-06-22 19:08:02 -07:00
Justin McCandless c105708426
RTL caret position (#60009) 2020-06-22 18:58:03 -07:00
zichangg fc64e75a32
Update tooltip_theme_test to unblock Dart SDK roll (#59937) 2020-06-22 18:53:03 -07:00
Jenn Magder d82ef3517c
Use assemble build system directly for build ios-framework (#60041) 2020-06-22 18:44:27 -07:00
Jenn Magder 6a2bc2617e
Replace ANDROID_HOME user messages with ANDROID_SDK_ROOT (#59867) 2020-06-22 18:43:04 -07:00
Tong Mu 9470b9e2ce
Add material state mouse cursor to TextField (#59363) 2020-06-22 18:38:03 -07:00
Jonah Williams 3406870d24
Fix newly added test to opt out of NNBD (#60042) 2020-06-22 17:40:48 -07:00
Jenn Magder 2c538be421
Parse build ios framework build mode from params (#59874) 2020-06-22 17:13:03 -07:00
Darren Austin cc36608f14
Keyboard navigation for the Material Date Picker grid (#59586) 2020-06-22 17:08:03 -07:00
Jia Hao dd6dd7aef1
Fix tracing of startup events (#59982) 
When `retainPriorEvents` is passed as true, the current behavior still limits timeline events to the timestamp after `traceEvents` is called. This can cause startup events to be missing.

This fixes it by passing null to `stopTracingAndDownloadTimeline` for the start and end time.

Related: #58430
 2020-06-23 08:07:05 +08:00
Jonah Williams 55abbb6be6
[flutter_tools] track null safety usage (#59822) 
* [flutter_tools] track null safety usage

* Update flutter_command_test.dart

* cleanups
 2020-06-22 17:05:01 -07:00
Jonah Williams 09f1764d14
[flutter_tools] android test cleanups (#59996) 
Fixes several tests that were failing under tester. Minor style cleanups otherwise
 2020-06-22 17:04:39 -07:00
Jonah Williams a734693ff5
[flutter_tools] cleanup iOS test (#59999) 
The test needs to look up HOME, but one wasn't provided. This would end up using the real home directory, crashing on windows
 2020-06-22 17:04:17 -07:00
Jonah Williams 8e9b78728f
[flutter_tools] switch linux desktop feature on (#60018) 
Enable linux desktop feature on dev channel
 2020-06-22 17:04:01 -07:00
rami-a e676024d37
[Material] Redesign Time Picker (#59191) 2020-06-22 17:03:04 -07:00
Jonah Williams 2cd205bb5a
[flutter_tools] cleanup fuchsia tests (#59997) 
Cleanup fuchsia tests that failed under tester.
 2020-06-22 16:47:28 -07:00
renyou eaf9ff738a
Revert "Implement Comparable<TimeOfDay> (#59317)" (#59981) 
This reverts commit 2933e895e5.
 2020-06-22 11:53:54 -07:00
renyou a88e2c8742
Revert "fix the widget span layout when text scale factor != 1 (#59711)" (#59986) 
This reverts commit 747fe345f1.
 2020-06-22 11:53:14 -07:00
Jonah Williams 04ce9d288c
Revert "Fix outline button solid path when BorderSize.width is used (#51581)" (#60000) 
This reverts commit 5995661777.
 2020-06-22 10:13:37 -07:00
Ferhat 5995661777
Fix outline button solid path when BorderSize.width is used (#51581) 2020-06-19 16:15:58 -07:00
Sam Rawlins 252a3261c4
Remove unused import which shares prefix name with a used import. (#59160) 
Due to a bug in analyzer [1], some unused imports are not reported when
multiple import directives share a prefix name, and one or more are unused.

[1] https://github.com/dart-lang/sdk/issues/38784
 2020-06-19 15:25:13 -07:00
Anna Gringauze aac836c6ad
Enabled expression evaluation by default (#59826) 2020-06-19 15:23:03 -07:00
Jonah Williams fbdc79e448
[versions] update all versions (#59832) 
Fixes #59718

Update all versions, specifically dwds which has a hot restart fix
 2020-06-19 14:48:57 -07:00
Helin Shiah f7a09bd2df
Add integration tests for structured error (#59809) 2020-06-19 13:58:03 -07:00
Justin McCandless b9af6551b2
Label unnecessarily ellided (#59807) 2020-06-19 13:53:05 -07:00
Tong Mu 65b1956005
Add benchmark for Mouse region (web) (#59803) 2020-06-19 13:48:04 -07:00
Michael Goderbauer e48b7e99cd
More word substiturions (#59497) 2020-06-19 13:43:02 -07:00
Jason Simmons 4173881bbf
Fix the paste button label in the new version of the filtered text pasting test (#59865) 2020-06-19 12:41:29 -07:00
Andrew Chen 2933e895e5
Implement Comparable<TimeOfDay> (#59317) 2020-06-19 12:18:03 -07:00
Christopher Fujino 5cfb16b193
Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59876) 
This relands #59120, which was reverted in #59870.
 2020-06-19 12:03:38 -07:00
Christopher Fujino 0d7ff7a9e7
Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59870) 
This reverts commit 8665e13801.
 2020-06-19 10:52:52 -07:00
Ian Hickson 8665e13801
Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120) 2020-06-18 18:08:01 -07:00
Jonah Williams dec7423b44
Revert "Add the ability to ignore lines depending on comments (#58656)" (#59813) 
This reverts commit df02518dc9.
 2020-06-18 17:15:50 -07:00
Robert Ancell e6de0de8f7
Fix Linux shell window default size (#59630) 
The previous call set the minimum size, not just the initial size.
 2020-06-19 11:56:01 +12:00
Jenn Magder f41f795640
Clean up PollingDeviceDiscovery dispose (#59709) 2020-06-18 16:38:02 -07:00
Justin McCandless 339f0363a6
Reland modernize selection menu appearance (#59617) 2020-06-18 16:33:03 -07:00
Robert Ancell dd9fd2c851
Use a HeaderBar for Linux applications. (#59714) 2020-06-19 11:30:36 +12:00
Chris Bracken e0f60918d4
Roll the engine from 965fbbe to b5f5e63 (#59804) 
This rolls the engine from:
965fbbed1776545ee681cb57f3fb1d0c2000bbcb to
b5f5e6332cb4987e9e38ffaa267733ec0a8705ba. A Dart SDK roll in this range
changed the format of the compileExpression RPC VMService endpoint,
necessitating a tool patch.
 2020-06-18 16:12:54 -07:00
James D. Lin bdbe6774a3
[flutter tools] Change the desktop device names and IDs (#58812) 
In google3, the Linux device is always available, and it has confused
people who run the Flutter doctor and see
"• Linux • Linux • linux-x64 • Linux" listed.

Rename the Linux device name to "Linux desktop" and the device ID to
be "linux". Make similar changes to the Windows and macOS
devices for consistency.  This is also  consistent with the web
devices.

The device ID change shouldn't be break -d usage since that does a
case-insensitive prefix match.
 2020-06-18 15:30:00 -07:00
Jonah Williams e72d26a720
Revert "flutter.gradle: collect list of Android plugins from .flutter-plugins-dependencies (#59294)" (#59810) 
This reverts commit 947b48e062.
 2020-06-18 15:19:12 -07:00
Igor Akkerman 947b48e062
flutter.gradle: collect list of Android plugins from .flutter-plugins-dependencies (#59294) 2020-06-18 14:08:01 -07:00
stuartmorgan e85655c48e
Specify encoding for vswhere output (#59607) 
On Windows, Process.run assumes the output uses the system codepage by default. This allows specifying it in our wrapper, and sets the encoding for vswhere to UTF-8 since we're passing a flag that forces it to use UTF-8 output.

Fixes #53515
 2020-06-18 14:00:46 -07:00
Michael Goderbauer 32be39bf16
Fix doc for DecoratedBox (#59791) 2020-06-18 13:58:02 -07:00
Jonah Williams 01e09ea8af
[flutter_tools] add missing null-safety flags (#59773) 
Some of the null-safety commands were missing - plumb them through. Ensure that verbose mode shows their output, and clean up the messaging around sound-null-safety.

Fixes #59769

Adds a test that validate each of the null safety supporting build commands has everything plumbed through.
 2020-06-18 12:34:35 -07:00
Darren Austin 06de567811
Dismiss modal routes with a keyboard shortcut (#59310) 2020-06-18 11:53:02 -07:00
Jose Alba c6f6de6d1b
Chips text scaling (#57745) 2020-06-18 11:48:03 -07:00
Jonah Williams 5e77083b8d
[flutter_tools] make parent logger optional (#59786) 
The addition of the non-optional parent logger broke the google3 roll. Make it optional so we can roll
 2020-06-18 11:44:29 -07:00
Pasindu De Silva df02518dc9
Add the ability to ignore lines depending on comments (#58656) 
https://github.com/dart-lang/coverage - 0.14.0 added the ability to be able to ignore coverage depending on comments.

// coverage:ignore-line to ignore one line.
// coverage:ignore-start and // coverage:ignore-end to ignore range of lines inclusive.
// coverage:ignore-file to ignore the whole file.
 2020-06-18 10:34:42 -07:00
Jonah Williams 447e3d3f38
[flutter_tools] remove globals from compilers (#59184) 
Refactors KernelCompiler and ResidentCompiler to no longer use globals (except as a fallback for g3 migration). Improves the compilation error when running flutter test on a package without a flutter_test dependency.

Updates machine mode to output trace text to stderr
 2020-06-18 10:33:17 -07:00
Jonah Williams e1f4cfb4f4
[flutter_tools] add toggle b and service extension to change platform brightness (#59571) 
A frequent request from the last Flutter developer survey was for an easier method of testing light/dark mode changes. Currently, a user needs to manually change the theme settings or adjust phone settings to see the difference. Instead we should add a toggle from the CLI, and eventually devtools/Intellij/Vscode that allows developers to override the current setting.

Fixes #59495

Adds flutter.ext.brightnessOverride service protocol which either queries the current platform brightness, or overrides it to a new value. This accepts either Brightness.light or Brightness.dark as a value.

Adds a CLI toggle b which allows the setting to be toggled manually.

Requires an update to the MediaQuery, to conditionally use a debug override when not in release mode
 2020-06-18 10:32:43 -07:00
Chris Bracken f39ab52221
Revert "Manual engine roll to update format of compileExpression RPC response (#59717)" (#59774) 
Failing dev/integration_tests/ui/test_driver/keyboard_resize_test.dart
Also timing out on new_gallery_ios__transition_perf

This reverts commit c7a37c72c2.
 2020-06-18 09:52:44 -07:00
Ben Konyi c7a37c72c2
Manual engine roll to update format of compileExpression RPC response (#59717) 2020-06-18 09:18:03 -07:00
chunhtai 747fe345f1
fix the widget span layout when text scale factor != 1 (#59711) 2020-06-18 08:28:03 -07:00
Jonah Williams 719ea5a8c0
[flutter_tools] make expando on vm service null safe to handle web stuff (#59624) 2020-06-18 08:18:04 -07:00
Per Classon dbc6dca5d0
Set upper limit on text scaling for AppBar.title (#58094) 2020-06-18 08:13:02 -07:00
Ming Lyu (CareF) 9c3f0faa6d
Add comments to flutter_driver for timeline class (#58823) 
* Add comments to flutter_driver for timeline class

Mostly about explanation for the json items from
timeline.dart and timeline_summary.dart.
 2020-06-17 18:47:54 -04:00
liyuqian 42e02d60d3
Reland non-breaking "Add clipBehavior to widgets with clipRect #55977" (#59364) 
* Revert "Revert "Add clipBehavior to widgets with clipRect (#55977)" (#58344)"

This reverts commit 1d395c5e18.

* Add missed Overflow
 2020-06-17 10:57:40 -07:00
Jonah Williams 802c4b0f12
[flutter_tools] handle NPE in list views method(#59626) 
Fixes #59608

The VmService getter can be null, handle that in the listViews method. NNBD when
 2020-06-17 10:53:54 -07:00
Jenn Magder b8c64d7014
Don't crash when pubspec isn't a map (#59632) 2020-06-17 10:33:02 -07:00
Alexandre Ardhuin 1fe677a3af
update _isolates_io.dart for better nnbd migration (#59666) 2020-06-17 18:58:21 +02:00
renyou a99d146ba9
Revert "Characters Package (#53381)" (#59677) 
This reverts commit e0ed12c73a.
 2020-06-17 08:39:34 -07:00
Ayush Bherwani 37cb7b7b48
[ExpansionPanelList] adds dividerColor property (#59641) 2020-06-17 01:58:01 -07:00
Alex Vincent fe15d1e793
[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more than once (#58686) 2020-06-16 23:58:01 -07:00
Justin McCandless e0ed12c73a
Characters Package (#53381) 2020-06-16 16:53:04 -07:00
Greg Spencer c5527dc8c4
Remove dependency on package:collection by moving mergeSort into foundation/collections.dart (#59521) 
This removes a dependency from Flutter (package:collection) by copying the implementation of mergeSort into Flutter's foundation/collections.dart.

Also, removed a reference to UnmodifiableSetView from the shortcuts code by just returning a copy instead.
 2020-06-16 14:41:05 -07:00
Per Classon 56a7dacd46
[flutter_tools] For l10n with deferred loading, use loadLibrary for non-web too (#59539) 
After Dart VM change we are now required to use loadLibrary on an import whenever it is imported as deferred.

See: https://dart-review.googlesource.com/c/sdk/+/149613
 2020-06-16 13:36:28 -07:00
stuartmorgan 61c198e766
Switch Linux to the GTK embedding (#59287) 
Updates the tooling to use the GTK embedding, rather than the GLFW embedding:
- Adds new requirements to `doctor`
- Updates the app and plugin templates to make GTK-based runners and plugins
- Stops downloading and installing the GLFW artifacts

Final part of #54860, other than cleanup.
 2020-06-16 13:31:24 -07:00
Kenzie Schmoll 5b147520bf
Cancel tooltip show timer when state is deactivated (#57244) 2020-06-16 13:14:43 -07:00
Jonah Williams 15154b115f
[flutter_tools] deprecate build aot (#59487) 
This command was previously used by the re-entrant build scripts in xcode_backend.sh and build.gradle. These have since been refactored to use flutter assemble.

Deprecation the command in preparation for removal in a future release of flutter. The only current use is a test on HHH
 2020-06-16 13:00:11 -07:00
MH Johnson 7042be8816
Re-land "[Widgets] Add DefaultTextHeightBehavior inherited widget." (#59350) 2020-06-16 12:50:02 -07:00
Diego Henrique Domingues 95ee633f66
[flutter_tools] fix the event attribute used to skip waiting (#59568) 2020-06-16 11:15:02 -07:00
renyou deec88bb97
Revert "Build routes even less. (#58202)" (#59503) 2020-06-16 10:40:04 -07:00
Ayush Bherwani dde1249937
[MergeableMaterial] adds dividerColor property (#59481) 2020-06-16 10:35:03 -07:00
Justin McCandless b429ec1e8f
InteractiveViewer mouse scale bug (#59478) 2020-06-16 10:30:06 -07:00
Jenn Magder 5a4bb5050d
Remove last references to ideviceinstaller (#59508) 2020-06-16 10:25:10 -07:00
Michael Joseph Rosenthal 42666df9b7
Add link to ListTile replacement guide (#59474) 2020-06-16 10:25:06 -07:00
Gary Qian 1b62b805ca
Handle backspace edgecase in trailing whitespace formatter. (#59379) 2020-06-16 10:20:04 -07:00
Christopher Fujino 807b60250a
[flutter_tools] Update roll_dev.dart (#59215) 2020-06-16 09:30:04 -07:00
Darren Austin e66a5cf55d
Removed an unused static local key from ScrollAction. (#59436) 2020-06-16 09:25:10 -07:00