Commit graph

13881 commits

Author SHA1 Message Date
Hans Muller 563afe381c
Updated obsolte button references in Scaffold, IconButton (#61578) 2020-07-16 09:40:26 -07:00
Hans Muller d90a246461
Corrected splash color for TextButton, ElevatedButton, OutlinedButton (#61576) 2020-07-16 09:40:11 -07:00
chunhtai fc09119d0a
fix intrinsic height and width for widget span (#61485) 2020-07-16 09:36:09 -07:00
Kate Lovett d877ad8616
Update Table docs for horizontal scrolling (#61268) 2020-07-16 09:36:05 -07:00
Pedro Massango 5a69de8263
FormField should autovalidate only if its content was changed (fixed) (#59766) 2020-07-16 09:31:05 -07:00
Danny Tuppeny e8eb876489
Fix build (fix references to _flutter -> flutter) (#61568) 2020-07-15 12:45:55 -07:00
Danny Tuppeny 51fcf8fa7a
Add debounce support to daemon hot reload requests (#55376) 2020-07-15 11:56:05 -07:00
Ming Lyu (CareF) c9cf9c9940
Promote WidgetTester.ensureVisible to WidgetController (#61540)
* Promtoe WidgetTester.ensureVisible

* modify according to tvolkert@
2020-07-15 14:54:49 -04:00
Todd Volkert 9e665e1d88
Update documentation for IntrinsicWidth & IntrinsicHeight (#61502)
https://github.com/flutter/flutter/issues/61496
2020-07-15 11:54:32 -07:00
Todd Volkert 0d2421d5df
Add defaults to showGeneralDialog() (#61503)
The function passes most of its arguments through to
`_DialogRoute`, but it wasn't providing the default
values that `_DialogRoute` was, causing it to override
the defaults will null values.
2020-07-15 11:53:55 -07:00
Todd Volkert d009172fd2
Change xcodebuild to be a "slow operation" (#61518)
The Xcode build almost always takes longer than 2 seconds. With the
operation classified as a "fast operation", the Flutter tool will
warn the user that the build is "taking an unexpectedly long time".
This updates the operation to be a "slow operation", which will only
warn the user if it takes 2+ minutes.
2020-07-15 11:53:26 -07:00
Jonah Williams 5e1635b186
fix type error in web builds (#61556) 2020-07-15 10:21:39 -07:00
Jonah Williams d8b6fa153a
[flutter_tools] generate a synthetic flutter_gen package on pub get (#61261)
Allow configuring the flutter_manifest to support a synthetic package, this is done through flutter: generate: true.

When running pub get, insert a flutter_gen entry into the packages if it does not already exist. This points to .dart_tool/flutter_gen, which can be updated to contain the generated intl sources (But doesn't currently)

Adds an integration test that verifies this code can be run and imported when enabled.

Part of #60914
2020-07-15 10:12:52 -07:00
zichangg 3631adc99a
Fixing patch for coming breaking change in HttpClientRequest (#61138)
* Fixing patch for coming breaking change in HttpClientRequest

* Add noSuchMethod() and comment out abort()

* Add ignore: override_on_non_overriding_member
2020-07-15 10:07:57 -07:00
Tong Mu 6e0bc30e84
Document the mapping of system mouse cursors on Windows and Linux (#61399)
Add document for mouse cursor mapping on Windows and Linux.
2020-07-15 10:02:22 -07:00
Danny Tuppeny d19bd37749
Tweak message about debugging with web-server (#61535) 2020-07-15 17:57:14 +01:00
Alexandre Ardhuin 978a2e7bf6
migrate foundation to nullsafety (#61188)
* migrate foundation to nullsafety

* address review comments
2020-07-15 18:55:27 +02:00
Jonah Williams cb7770b3a5
[flutter_tools] add support for enable null safety asserts (#61114)
Enable null safety asserts for web debug mode. This induces runtime asserts at the boundaries between null safe and non-null safe libraries. Adds integration test that validates assertion error is thrown.

#61042
2020-07-15 09:54:39 -07:00
Neevash Ramdial e24cdab517
Re-land Expose height and width factor in AnimatedAlign (#61136) 2020-07-15 09:46:03 -07:00
Anthony 6f56ba453d
Automatically scale down Dialog padding for larger text scale factors (#58245) 2020-07-15 09:36:03 -07:00
Jonah Williams b010f78e3a
[flutter_tools] fix typo in test code (#61548) 2020-07-15 09:21:24 -07:00
Ayush Bherwani 26a5f5c3d6
[ListTileTheme] adds properties to customize tile color at theme level (#61532) 2020-07-15 05:46:03 -07:00
Hans Muller fcb5806933
Update MaterialState API docs (#61479) 2020-07-14 22:41:01 -07:00
Todd Volkert 3ce06efd40
Default textBaseline to alphabetic in Flex (#61425) 2020-07-14 22:36:02 -07:00
Siva e15cfc2c09
Remove code that morphs --sound-null-safety to --null-safety options (#61491) 2020-07-14 17:21:01 -07:00
Jenn Magder 4fba77476d
Support Xcode patch version comparison (#61484) 2020-07-14 17:16:02 -07:00
Ben Konyi a1a5a8f635
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61395)" (#61498)
This reverts commit f98184e487.
2020-07-14 16:32:49 -07:00
chunhtai e78cbe5df9
fix code comments in the route route didadd method (#61400) 2020-07-14 16:06:01 -07:00
Ben Konyi f98184e487
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61395)
This reverts commit 5b9c6e2b0e.
2020-07-14 15:57:36 -07:00
Todd Volkert 4195ad4ef6
Fix Border.symmetric: phase 1 (#61474) 2020-07-14 13:21:02 -07:00
Jonah Williams 485034cab3
[flutter_tools] update fastReassemble method for single widget reloads (#61413)
For #61407 , we need to be able to find all widgets that of a given type. Previously I experimented with using the type name, but of course this does not handles subtypes. The actual check needs to be an is check.

Since there is no way to convert a String to a Type at runtime for use in this check, we can instead evaluate an expression which assigns a closure to a field. The idea for this was inspired by how the dart devtools adds debug functionality to older versions of flutter.

Since the reload feature is not complete yet, adds an integration test which simulates how it will eventually behave
2020-07-14 12:25:13 -07:00
Jonah Williams d22d65c6e7
[flutter_tools] add the feature for single widget reloads (#61411)
Implements the flutter config feature for #61407 , but does not implement any of the functionality.
2020-07-14 12:24:58 -07:00
Todd Volkert 74f3e6dd63
Add assert to Table to check for rows with null children (#61457) 2020-07-14 12:20:22 -07:00
Andre 06a35b3322
Improve error reporting for RenderObject visitChildren errors (#61455)
* Improve error reporting for RenderObject visitChildren errors

* Nits and fixes
2020-07-14 14:21:14 -04:00
Todd Volkert b58c3f0852
Update documentation (#61424) 2020-07-14 10:25:24 -07:00
Jason C.H c047769487
Implement new activity indicator for iOS14 (#60179)
Updates the activity indicator style to iOS14, but places it behind a flag, to be deprecated when iOS 14 is released.
2020-07-14 09:21:27 -07:00
Ayush Bherwani 9cb7ac1353
[ListTile] adds new properties to customize the tile color (#61347) 2020-07-14 03:41:03 -07:00
Pasindu De Silva 5c9d09f05a
Add the ability to ignore lines from coverage depending on comments (#61408) 2020-07-14 01:46:02 -07:00
Jason Simmons af47958eff
Update the golden image comparator to handle read-only image ByteData views (#61406) 2020-07-14 01:41:02 -07:00
Fabusuyi Ayodeji 1c96479760
expose route settings for showModalBottomSheet (#60640) 2020-07-14 01:36:02 -07:00
Hans Muller bb3280885c
Update the Scaffold examples; use the new button classes (#61394) 2020-07-13 16:28:27 -07:00
chunhtai 88a78d660e
reland "Adds semantics information for the popup menu item (#61258)" (#61385) 2020-07-13 16:16:02 -07:00
chunhtai f7688c5001
issue 61346 route can be added and disposed in the same frame (#61375) 2020-07-13 16:11:03 -07:00
Hans Muller 82666ef19e
Update Card example and shadowColor default (#61392) 2020-07-13 16:01:09 -07:00
Jonah Williams e666ea8de4
[flutter_tools] cleanups to web runner functionality (#61178)
Skip unnecessary parsing of chrome URI. Ensure stack traces are initialized in web server. Disclaimer on web server that it does not support debugging and remove help message. Fix generated entrypoint to check for main(List<String> args)

- Fixes #59643
- Fixes #55084
- Fixes #60417
2020-07-13 15:12:46 -07:00
Dan Field eadc35f62b
Optionally invert oversized images (#61209)
* Optionally invert oversized images
2020-07-13 14:03:23 -07:00
Justin McCandless 8048c0332d
Document the addition of LRM and RLM characters (#61104) 2020-07-13 14:01:02 -07:00
Todd Volkert b635d97674
Add widget of the week videos to documentation (#61368) 2020-07-13 13:51:03 -07:00
Darren Austin e2acc6503a
Remove the default shortcut mapping for GameButtonB. (#61370) 2020-07-13 13:46:02 -07:00
Hans Muller 0f57cd26f8
Make ThemeData.shadowColor the default shadowColor in TextButton et al. (#61371) 2020-07-13 13:34:54 -07:00
Danny Tuppeny f8135add8e
Add a flag for using WS for debug backend (#61359) 2020-07-13 13:31:04 -07:00
Tong Mu da8695d389
Mouse events report correct local positions (#61190) 2020-07-13 13:26:03 -07:00
chunhtai 067d3da827
Revert "Adds semantics information for the popup menu item (#61258)" (#61377)
This reverts commit c6058df9ca.
2020-07-13 12:24:42 -07:00
chunhtai c6058df9ca
Adds semantics information for the popup menu item (#61258) 2020-07-13 11:21:03 -07:00
rami-a b79efb8da3
[Material] Allow for customizing Snack bar margin, padding, and width (#61180) 2020-07-13 14:19:45 -04:00
Jenn Magder cda6c27ff7
Add spaces between sentences in help text (#61135) 2020-07-13 11:16:03 -07:00
xster 8bd2e6585b
Remove v1 Android create templates (#61203) 2020-07-11 12:15:19 -07:00
Hans Muller eac1747169
Renamed ContainedButton et al. to ElevatedButton et al. (#61262) 2020-07-11 08:50:43 -07:00
Greg Spencer b267e7bd9b
This fixes a compile error in the form field example, and switches to using space instead of enter as the example for moving to the next field, since the text field on web unfocuses automatically when enter is pressed. (#61123) 2020-07-10 18:06:02 -07:00
Anna Gringauze 9cbe1dccf3
Added web compiler debug metadata (#61265)
Made flutter tools serve metadata produced by the frontend server:

pass --experimental-emit-metadata flag to flutter engine
store and serve metadata from web asset server
store and serve merged metadata from web asset server
add tests to verify that metadata is served from memory
update dwds version so it can read metadata
configure dwds to read metadata from file
Prerequisite changes (landed):

sdk: https://dart-review.googlesource.com/c/sdk/+/150181
flutter engine: flutter/engine#19168
webdev:dart-lang/webdev#1064
2020-07-10 16:36:43 -07:00
Dan Field cd80ed3009
Fix bold not getting cleared on new line (#61256)
* Fix bold not getting cleared on new line
2020-07-10 16:09:49 -07:00
Dan Field 5b9c6e2b0e
Revert "Add support for Dart Development Service (DDS) in Flutter Tools (#59114)" (#61276)
This reverts commit fe7bbf7226.
2020-07-10 15:53:35 -07:00
Ben Konyi fe7bbf7226
Add support for Dart Development Service (DDS) in Flutter Tools (#59114) 2020-07-10 15:35:21 -07:00
Nolan Scobie dc0f122881
Revert "Revert "Tweaking Material Chip a11y semantics to match buttons (#60141)" (#60645)" (#61048) 2020-07-10 14:21:03 -07:00
Ming Lyu (CareF) a76b5eb79f
Add support in WidgetTester for an array of inputs (#60796)
* Add input event array support

* Add a tap test

* remove unused import

* remove extra assert
2020-07-10 17:03:12 -04:00
Jonah Williams 66556faef7
[flutter_tools] deflake integration test with tryToDelete (#61253) 2020-07-10 13:29:49 -07:00
Kaushik Iska afd745e893
Filter profiling events by names not category (#61185)
Category isn't preserved by timeline events as `Dart_TimelineEvent`
specifies the category as `embedder`.

Fixes: https://github.com/flutter/flutter/issues/60008
2020-07-10 12:13:56 -07:00
Jonah Williams 1c1ef133ee
[flutter_tools] remove globals from device manager, flutter tester (#61139)
Remove global variables from device manager, flutter tester devices and update tests
2020-07-10 11:52:09 -07:00
Jonah Williams fbca40add2
[flutter_tools] abstract logger construction (why can't I hold all these loggers) (#61201)
We have too many loggers, and the logger construction rules are too complicated to be untested. Capture these in a LoggerFactory and test that construction is correct.
2020-07-10 11:51:47 -07:00
Jonah Williams d14a898f69
remove LICENSE/NOTICES work around (#61199)
Now that google3 has been updated, remove the LICENSE loading fallback. This was done in cl/320506032

#16723
2020-07-10 11:37:48 -07:00
Ayush Bherwani fd80503fd3
[Api docs] Updates ListTile.subtitle docs to address how TextStyle is decided (#61071) 2020-07-10 02:11:02 -07:00
Jonah Williams 6eaaf1650e
[flutter_tools] switch order of injection (#61191)
Inject loggers in the right order, test WIP. Otherwise verbose machine would not get the AppRunLogger
2020-07-09 18:04:37 -07:00
Jenn Magder 20fe2f88c5
Prefer tear offs to lambdas in test expects (#61196) 2020-07-09 17:58:51 -07:00
Jonah Williams ed9a705ec2
[flutter_tools] allow unmuting of command logging (#61198)
Running flutter doctor -v prints out extra details instead of running in verbose mode. Allow disabling this with -vv so it can be debugged.
2020-07-09 17:55:53 -07:00
Kate Lovett 01ac509620
Skip Audit - Last Leftovers (#60940) 2020-07-09 17:01:01 -07:00
Jenn Magder e110ca7209
Case insensitive check flavor names against Xcode schemes (#61140) 2020-07-09 16:56:02 -07:00
Max Weber c29009b3e8
Added the materialTapTargetSize to the OutlineButton Constructor (#61086) 2020-07-09 14:56:01 -07:00
Kate Lovett e3079a3339
Add additional float location case (#61171) 2020-07-09 14:06:03 -07:00
Alexandre Ardhuin f32a73711a
use nnbd deps (#61177) 2020-07-09 23:01:22 +02:00
Tong Mu d4b4eeed7d
Add all system cursors (framework) (#60931) 2020-07-09 14:01:03 -07:00
includecmath 72258eac5f
[flutter_tools] Separate style and data from AnalysisError (#60591) 2020-07-09 13:51:02 -07:00
remin c65f32f447
Add ThemeData.shadowColor (#60337) 2020-07-09 13:46:04 -07:00
Hans Muller dc31d89c56
New Button Universe (#59702) 2020-07-09 13:41:03 -07:00
Kate Lovett ea777fea1b
Skip Audit - Rendering Library (#58640) 2020-07-09 13:36:03 -07:00
Shi-Hao Hong 61a04b1551
Fix and address Inconsistencies with Pashto support (#60600)
* Normalize Pashto incomplete translations

* Add comment to README.md about incomplete Pashto support
2020-07-09 15:52:19 +08:00
Dan Field a9ea825abf
Do not cache itemBuilder calls in a GridView (#61033) 2020-07-08 21:26:03 -07:00
LongCatIsLooong a6ce2d4bc7
Assert valid composing TextRange (#60956) 2020-07-08 21:21:02 -07:00
Dan Field c6fd42499a
Test update_packages for git packages (#61127) 2020-07-08 19:31:02 -07:00
Kate Lovett debb3a5d28
Skip Audit - Widgets Library (#60936) 2020-07-08 19:26:03 -07:00
Robert Ancell 266aeb81a0
Only try the GDK X11 backend, as the FlView only currently supports X11 (#60654) 2020-07-09 14:23:48 +12:00
Jonah Williams d4589e0c71
[flutter_tools] ensure AppRunLogger is injected for run/attach machine (#61103)
run/attach --machine requires a different logger than daemon, which uses the NotifyingLogger. We have too many loggers!

Fixes #59463
2020-07-08 18:21:46 -07:00
chunhtai 496ef4f77e
prevents sliver app bar from changing semantics tree when it is not necesaary (#61012) 2020-07-08 18:21:08 -07:00
chunhtai 06b301cdfc
fix semantics to only send relevant node update (#60925) 2020-07-08 18:21:04 -07:00
Kate Lovett b345ecc11b
Skip Audit - Scheduler and Services libraries (#60934) 2020-07-08 18:16:08 -07:00
chunhtai 00b1903bbc
Add a flag to toggle navigator route update reporting (#60621) 2020-07-08 18:16:04 -07:00
Ayush Bherwani 5a00d54eec
[AppBar] adds leadingWidth property to customize width of leading widget (#60915) 2020-07-08 18:11:07 -07:00
includecmath 93eac884eb
[flutter_tools] Clean code analyze command (#60200) 2020-07-08 18:11:03 -07:00
Jonah Williams 741608a261
[flutter_tools] fix recursive asset variant issue (#61129)
Fixes #45075
Fixes #57210

If an asset was included directly from the project root directory, then the same asset when copied to various output or ephemeral directories would also be picked up as an asset variant. This could cause assets to be recursively copied into asset/build/ephemeral directories, as each time it would run it would pick up all of the previous "variants".

The solution is to include project ephemeral directories, in addition to the build directory.
2020-07-08 18:07:27 -07:00
chunhtai 589b327816
Issues/58665 reland and prevent the material widget from absorbing gesture (#60536) 2020-07-08 17:46:03 -07:00
Juyeong Lee e2a638e66d
Fix docs for TabBar indicator (#60482) 2020-07-08 17:41:05 -07:00
Ming Lyu (CareF) a5fa083906
Add comment explain dispatchEvent override (#60734) 2020-07-08 18:37:33 -04:00
Ming Lyu (CareF) 78bb587c70
respect line wrapping style guide (#61118) 2020-07-08 16:44:59 -04:00
Ming Lyu (CareF) 61477b5949
Fix PointerAddedEvent handling in LiveTestWidgetsFlutterBinding (#61102)
* Fix PointerAddedEvent handling in tester
2020-07-08 13:28:51 -04:00
Mehmet Fidanboylu cc1af3afb6
Revert "Expose height and width factor in AnimatedAlign (#60836)" (#61109)
This reverts commit e8e1eb51a4.
2020-07-08 10:19:36 -07:00
Jonah Williams 0cff654220
[flutter_tools] add sdk constraint to plugin/package templates (#60932)
Gives plugin and package a constraint on the flutter version, which will be from 2 stable's ago when this goes to stable. Adds an upper bound of 2.0
2020-07-08 10:11:10 -07:00
Maurice Parrish 7d7907e6c1
Fix bug where dispose message requires a map (#61035) 2020-07-08 09:57:34 -07:00
Sim Kern Cheh 5f49654734
Issue with comparison operator in generated service worker (#61066) 2020-07-08 09:56:02 -07:00
Justin McCandless a82005a9dc
InteractiveViewer pan axis locking (#61019) 2020-07-08 09:51:02 -07:00
Per Classon df64d1b303
Remove shouldCapTextScaleForTitle from AppBarTheme (#61000) 2020-07-08 09:46:02 -07:00
Natan Portilho f567a0cc98
Device manager choose running device (#57349) 2020-07-08 09:41:02 -07:00
Dan Field d45ad057b4
Handle git dependencies, roll packages to get transitive deps of flutter_gallery (#61064) 2020-07-07 22:21:19 -07:00
Jonah Williams 07e2d6f63b
[flutter_tools] make precache force blow away stamp files (#61003)
update flutter precache --force to delete all stamp files. In the event that a user is hitting a cache issue, this should be easier than re-downloading all artifacts or manually blowing away the cache.

This is probably how it should have worked in the first place
2020-07-07 19:33:25 -07:00
Jonah Williams 77310c152f
[flutter_tools] deprecate flutter version (#60998) 2020-07-07 18:04:02 -07:00
rami-a 843231bbc2
[Material] Misc fixes for time picker input mode (#60991) 2020-07-07 17:59:03 -07:00
Tonic Artos a167610e17
Remove superfluous GestureDetector. (#60730) 2020-07-07 17:54:03 -07:00
Kaushik Iska ff6b7809bc
Re-land gesture detection for hybrid platform views (#61013) 2020-07-07 17:49:54 -07:00
Kate Lovett 3176232cb4
Doc and Error Message Improvements (#60726) 2020-07-07 17:49:03 -07:00
Neevash Ramdial e8e1eb51a4
Expose height and width factor in AnimatedAlign (#60836) 2020-07-07 17:44:07 -07:00
Jason Simmons 5cf0d73764
In layers_test create a canvas to start recording on the PictureRecorder (#60660) 2020-07-07 17:44:02 -07:00
zljj0818 11ff938af5
Added a filterQuality parameter to texture (#59966) 2020-07-07 17:39:04 -07:00
Dan Field 33aa457604
Roll packages (#61034)
Roll packages, update XML deprecations.
2020-07-07 16:40:33 -07:00
Dan Field fb57edcc80
Revert "Revert "Fix remaining holes in stack trace demangling (#60478)" (#60916)" (#60996)
This reverts commit 2c7e5dd935.
2020-07-07 15:30:32 -07:00
Kaushik Iska 8ed8b06ac5
Revert "Add embedderId to PointerEvent (#60930)" (#61010)
This reverts commit 2ab5099436.
2020-07-07 12:12:20 -07:00
Kaushik Iska 2ab5099436
Add embedderId to PointerEvent (#60930)
This field is used to look-up the event in the platform
that resuted a given `PointerEvent`. This is currently only
used on Android, where the `embedderId` is set to be the
`motionEventId` for a given `MotionEvent`.

Roll engine to d0d6a4c2362d2ed478006bb3b01c34c0e96033b4
2020-07-07 10:59:12 -07:00
Jonah Williams f111a823ec
[flutter_tools] remove some globals from flutter_tester device (#60787)
Remove globals from flutter_tester device and cleanup test case. Not completely gone since the Kernel Builder will still use them, but a good incremental improvement.
2020-07-07 10:24:52 -07:00
Jonah Williams 846418b60b
[flutter_tools] fix crash if the platform section was a list (#60927)
Missed validation to go with cast. Added test case to reproduce.
2020-07-07 10:24:42 -07:00
Per Classon db5a62b0ee
Support customizing colors for rows in DataTable (#60764) 2020-07-07 10:24:02 -07:00
Mehmet Fidanboylu 8c67781f36
Comments around hanging tests via runAsync. (#60136) 2020-07-07 09:14:02 -07:00
Jose Alba 9265bdd1ad
RangeSlider overlap properly (#60549) 2020-07-06 17:54:02 -07:00
Darren Austin 5fa937edd1
Keyboard navigation fo the Material Date Range Picker (#60497) 2020-07-06 17:49:03 -07:00
Tong Mu 6f4c4b3cf8
Refactor mouse hit testing system: Direct mouse hit test (#59883) 2020-07-06 17:44:02 -07:00
stuartmorgan 4b12050112
Switch Windows to CMake (#60629)
* First pass at CMake files; untested

* First pass of adding CMake generation logic on Windows

* Misc fixes

* Get bundling working, start incoprorating CMake build into tool

* Fix debug, exe name.

* Add resources

* Move cmake.dart

* Rip out all the vcxproj/solution plumbing

* Fix plugin cmake generation

* Build with cmake rather than calling VS directly

* Adjust Windows plugin template to match standard header directory structure

* Pass config selection when building

* Partially fix multi-config handling

* Rev template version

* Share the CMake generation instead of splitting it out

* VS build/run cycle works, with slightly awkward requirement to always build all

* Update manifest

* Plugin template fixes

* Minor adjustments

* Build install as part of build command, instead of separately

* Test cleanup

* Update Linux test for adjusted generated CMake approach

* Plugin test typo fix

* Add missing stub file for project test

* Add a constant for VS generator
2020-07-06 12:59:16 -07:00
giga10 35df978124
Fix typo (#60832) 2020-07-06 12:58:23 -07:00
Jenn Magder 11bf7f0687
Take screenshots of wirelessly paired iOS devices (#60623) 2020-07-06 12:28:29 -07:00
Ram Navan 60deae8546
Issues/58053 - Set default textBaseline to alphabetic in the Table widget (#60586) 2020-07-06 12:19:02 -07:00
Dan Field 2c7e5dd935
Revert "Fix remaining holes in stack trace demangling (#60478)" (#60916)
This reverts commit d986fdc31a.
2020-07-06 10:07:36 -07:00
Andre d986fdc31a
Fix remaining holes in stack trace demangling (#60478)
* Implement stack trace demangling in the framework.
2020-07-06 08:11:03 -07:00
Nils Reichardt edbd09379b
ListTile Mouse Pointer Fix (#60563) 2020-07-05 11:53:04 -07:00
Maurice Parrish dcbc694b58
Have AndroidViewController extend PlatformViewController and add support for hybrid platform views (#60320) 2020-07-05 11:43:02 -07:00
Pierre-Louis 0bc4368233
Typo sweep (#60693) 2020-07-02 13:08:02 -07:00
Jonah Williams ae9ac9f211
[flutter_tools] support starting in canvaskit with FLUTTER_WEB_USE_SKIA=true (#60708) 2020-07-01 22:53:03 -07:00
Jonah Williams 2f43aeaf54
[flutter_tools] fix crash if grouped doctor validator crashes (#60658) 2020-07-01 22:48:02 -07:00
Justin McCandless 84fc52e1e9
InteractiveViewer with a changing screen size (#60532) 2020-07-01 22:43:03 -07:00
Panmari 14a4ed5888
Adding "Widget of the week" video for color filtered. (#60481) 2020-07-01 22:38:03 -07:00
Justin McCandless 533c6b29b4
Show hint when label is floating (#60394) 2020-07-01 22:33:02 -07:00
Per Classon b35f2cd4ca
Enable shouldCapTextScaleForTitle by default (#60684) 2020-07-01 10:53:01 -07:00
Gary Qian 0e735e4bca
Expose ComputePlatformResolvedLocale (#58482) 2020-06-30 18:54:02 -07:00
gaaclarke e8670de011
Revert "Tweaking Material Chip a11y semantics to match buttons (#60141)" (#60645) 2020-06-30 18:28:01 -07:00
Justin McCandless 8ab513a0c9
InteractiveViewer scroll direction (#60523) 2020-06-30 16:23:01 -07:00
Jonah Williams c543db70dc
[flutter_tools] add null-safety flags to dill cache location (#60633)
initialize from dill does not handle changing null-safety flags and will incorrectly use the nullability mode of the last compile. Add all extra frontend options to the unique name prefix for the flutter run dill cache to avoid this situation.
2020-06-30 15:49:31 -07:00
Chris Yang 07e24f6dad
[flutter_tool] fix ide-config crash because of no android key (#60617) 2020-06-30 13:01:47 -07:00
Jonah Williams 7ca324ac01
[flutter_tools] support sound null-safety mode for the web (#60570)
In web debug mode, infer sound null safety by default. When sound null safety is enabled, provide a separate dill and precompiled Dart SDK. Release builds do not need this setting since we run dart2js from source.

Fixes #59873
2020-06-30 12:29:42 -07:00
Jonah Williams 2188196125
[flutter_tools] ensure flutter daemon can exit correctly when app fails to start (#60615)
The flutter daemon unconditionally waits for the appFinished signal, even if startup failed. Ensure this future is correctly completed if there is a failure in ResidentRunner.run and not just ResidentRunner.attach. Adds regression tests for run release, debug, debug web, and release web. Adds missing try catch in cold runner startup.

Manually tested with release/debug on Android and release/debug on web.

Fixes #60613
2020-06-30 12:26:18 -07:00
James D. Lin cf8fbc363a
[flutter tools] Revert desktop device name changes and print the category instead (#60395) 2020-06-30 11:28:02 -07:00
Greg Spencer ca713557d7
New license page with fix for zero licenses. (#60552)
This amends #57588 by adding code that also handles the zero license case, and adds translation strings for that.
2020-06-30 09:15:04 -07:00
Christopher Fujino b15798fa98
Revert "Revert "[flutter_tools] update libimobiledevice (#59512)" (#60551)" (#60569)
This reverts commit 09cca73aee.
2020-06-29 18:29:58 -07:00
Jonah Williams 55e3770f3e
[flutter_tools] remove globals from base/android (#60480)
Remove unnecessary use of globals from base tests, and an android test. This changes the test to avoid bouncing through the global getters, which can lead to incorrectly cached zone values. Switches the memory filesystem implementation to the test implementation
2020-06-29 15:06:58 -07:00
featherless c239d952a5
Annotate RawMaterialButton as a Material > Button category. (#60545) 2020-06-29 14:58:01 -07:00
Jenn Magder d5225a560d
Fix daemon device discovery crash when Xcode isn't installed (#60546) 2020-06-29 14:54:19 -07:00
Christopher Fujino 09cca73aee
Revert "[flutter_tools] update libimobiledevice (#59512)" (#60551)
This reverts commit 32000db52e.
2020-06-29 13:44:38 -07:00
Christopher Fujino 32000db52e
[flutter_tools] update libimobiledevice (#59512) 2020-06-29 13:17:04 -07:00
chunhtai 163a09a535
Revert "fix paint order of ink feature (#59108)" (#60530)
This reverts commit 1e843bb6ba.
2020-06-29 10:19:43 -07:00
Darren Austin ed05fd7517
Date picker string translations (#60405) 2020-06-29 10:08:02 -07:00
Darren Austin 812c189de8
Fixed a problem with date calculations that caused a test to fail in a non-US time zone. (#60396) 2020-06-29 10:03:02 -07:00
Justin McCandless f6cd2d4b35
Don't access clipboard passively on iOS (#60316) 2020-06-29 09:43:03 -07:00
Dan Field 06d0cd514e
Allow detection of images using more memory than necessary (#59877) 2020-06-26 15:34:41 -07:00
Kate Lovett fd7a72ee6f
Ensure FloatingActionButtonLocations are always within safe interactive areas (#60248) 2020-06-26 15:18:02 -07:00
Jenn Magder a4fa61b4f1
Use ephemeral ports for iOS port forwarding (#60381) 2020-06-26 15:02:05 -07:00
Nolan Scobie da489c337a
Tweaking Material Chip a11y semantics to match buttons (#60141) 2020-06-26 17:24:27 -04:00
MH Johnson 3ce2691092
[Semantics] Update bottom nav semantics tests to use matches semantics (#60329) 2020-06-26 14:08:02 -07:00
rami-a 7d8d086371
Add property to theme dial label colors (#60383) 2020-06-26 16:38:21 -04:00
Jonah Williams e1538d1b88
[flutter_tools] last pass on general.shard unit tests (#60263)
Last batch of test fixes for general shard.
2020-06-26 13:36:06 -07:00
Yegor 7518a146c2
Do not call Picture.toImage on web during shader warm-up (#60379) 2020-06-26 13:33:02 -07:00
Michael Goderbauer 769468298b
Do not return partial semantics from tester.getSemantics (#60367) 2020-06-26 11:03:02 -07:00
Alberto Monteiro aa0382e95d
ReorderableListView should not reorder if there is only a single item present (#59631) 2020-06-26 08:08:01 -07:00
Jonah Williams 4bb6096086
[flutter_tools] surface null safety/experiment flags in attach (#60317)
Missed this one. Needed for google3 and add2app workflows
2020-06-25 15:44:57 -07:00
chunhtai 3e5c700fd7
Add material page, cupertino page, and transition page classes (#58511)
* Add material page, cupertino page, and transition page classes

* update

* update comments

* fix test

* addressing comments

* make page getter private
2020-06-25 14:47:01 -07:00
chunhtai 1e843bb6ba
fix paint order of ink feature (#59108) 2020-06-25 12:53:03 -07:00
Jonah Williams 82a6f9bf0b
[flutter_tools] remove most use of global packages path (#60231)
The global packages path could cause tests to fail when it would be overriden to unexpected (in test setup) values. Remove most usage and make it a configuration on buildInfo, along with most other build information. Cleanup the asset builder to require the .packages path and the resident runners to no longer require it, since they already have the information in build_info.

It needs to stick around for the fuchsia deps we do not control.

Filled #60232 for remaining work.
2020-06-25 12:52:14 -07:00
Greg Spencer c68758fab1
Implement delayed key event synthesis support for Android (#59358) 2020-06-24 21:23:02 -07:00
Shi-Hao Hong 17cb865ec6
Revert "Revert "[PageTransitionsBuilder] Fix 'ZoomPageTransition' built more than once (#58686)" (#59992)" (#60245) 2020-06-24 17:03:01 -07:00
Jenn Magder 0486cebd29
Make module run script names unique (#60228) 2020-06-24 16:52:01 -07:00
Jonah Williams 5cfcae004a
[flutter_tools] fix tests that depend on correct cache existance (#60241)
These tests will hit the real Cache, failing if the flutter root has been modified
2020-06-24 16:45:46 -07:00
Jonah Williams a0334fb500
[flutter_tools] maintain file manifest for create (#59706)
First pass at fixing #57985 and implementing #59602

This doesn't have enough metadata to be useful for IDEs yet, but it prevents the issue from getting worse while we iterate on it.
2020-06-24 16:20:21 -07:00
Jonah Williams 2a7ee930c3
[flutter_tools] Update WebAssetServer to avoid context, fix tests (#60224)
WebAssetServer could fail if some of the global statics it depended on were initialized in a different order. Fix this by removing globals.

Delete dwds startup test that needs to spawn a real server.
2020-06-24 16:19:49 -07:00
chunhtai 62378a3755
fix ink feature tries to get parent transformations when it is in the… (#60129) 2020-06-24 13:53:01 -07:00
Ayush Bherwani 3377781798
[AppBar] adds toolbarHeight property to customize AppBar height (#59405) 2020-06-24 13:08:01 -07:00
Kate Lovett 4d2ddb9199
Doc Updates (#60222) 2020-06-24 12:28:01 -07:00
stuartmorgan d9902a5474
Consider the Linux template stable (#60163)
Remove the version checking and associated warnings. The Linux template
and build process will now be subject to more typical Flutter breaking
change policy, and should no longer require regularly deleting and
recreating the platform directory.
2020-06-24 12:23:57 -07:00
Justin McCandless 42e67550af
Update inaccurate documentation for isUtf16Surrogate method (#60219) 2020-06-24 12:18:02 -07:00
Jonah Williams f8c9e1bb67
[flutter_tools] de-flake integration tests (#60221)
The vm_service_integration test flake is caused by trying to call the method before the framework is initialized (and the extension added). The run errors failure is caused by the error taking some time to propagate to the harness
2020-06-24 12:14:58 -07:00
David Worsham db48cadd0d
Remove unused physicalDepth code (#60152) 2020-06-24 11:33:01 -07:00
Jonah Williams 9e30d51ac6
[flutter_tools] start fixing command tests (#60172) 2020-06-24 11:26:36 -07:00
Chris Yang 95b98dc2c2
flutter create . on plugins also regenerates files for platforms supported in pubspec.yaml (#60159) 2020-06-24 10:38:03 -07:00
chunhtai 5623fea53c
Reverse the semantics order of modal barrier and modal scope (#59290)
* Add semantics sort key for modal scope and modal barrier

* fix test

* fix test

* fix test

* fix space

* fix more tests

* addressing comments
2020-06-24 10:37:53 -07:00
rami-a 50612db86e
Localized new strings added in the redesigned Material Time Picker (#60096) 2020-06-24 10:33:03 -07:00
Jonah Williams 5d61bff294
[flutter_tools] even more test fixes (#60156)
Fix tests broken under tester
2020-06-24 10:23:59 -07:00
Darren Austin b946e30c3d
Fix a couple of doc typos. (#60139) 2020-06-23 17:58:01 -07:00
Jonah Williams dd49e57be2
[flutter_tools] more test fixes (#60144)
Fixes additional bugs uncovered by tester, style fixes to prevent suggested imports.
2020-06-23 17:53:00 -07:00
Justin McCandless 766e0fa9ef
Export characters (#59620) 2020-06-23 17:43:02 -07:00