Commit graph

4018 commits

Author SHA1 Message Date
Christopher Fujino 2d9902d9ac
Cleanup ios devices (#52568) 2020-03-18 12:51:01 -07:00
Zachary Anderson e8778da12c
[flutter_tools] Don't crash when analytics fails to initialize (#52775) 2020-03-18 10:00:14 -07:00
Jonah Williams 542feb4736
[flutter_tools] remove unused Snapshot.dart artifact and associated code (#52821) 2020-03-18 09:18:41 -07:00
Jonah Williams 46f0a5f7b5
[flutter_tools] Reland android device cleanup. (#52686) 2020-03-17 17:58:39 -07:00
Jonah Williams 90d6169678
[flutter_tools] refactor the IOSDevicePortForwarder and move tests out of devices_test.dart (#52772)
Updates the IOSDevicePortForwarder to no longer depend on context, or on an IOSDevice instance. Instead, it receives all necessary configuration through the constructor.

Moves the IOSDevicePortForwarder to a separate file.
2020-03-17 17:58:05 -07:00
Jonah Williams 6884086e5c
[flutter_tools] Update to latest dwds APIs (#51004)
Update to latest dwds APIs, moving back to dwds driven hot restart and enabling future work on expression evaluation.
2020-03-17 17:29:53 -07:00
gaaclarke 6990b8b2d3
Added the "trace-whitelist" flag to run. (#52556) 2020-03-17 16:42:20 -07:00
Jonah Williams f149eec31b
[flutter_tools] always initialize the resident runner from dill (#52497) 2020-03-17 16:37:06 -07:00
Jenn Magder 757b39ba99
Ignore fuchsia device-finder no device error (#52761) 2020-03-17 16:02:45 -07:00
Christopher Fujino 071d4eb2c8
explicitly catch ArgumentError, and add tests (#52757) 2020-03-17 12:55:57 -07:00
Jonah Williams a7011c4817
[flutter_tools] don't force service worker cache files to be absolute (#52606) 2020-03-17 10:17:03 -07:00
Jenn Magder 93a6057c42
Add SDK location unit tests (#52691) 2020-03-16 16:02:22 -07:00
Jenn Magder 2f216ceee5
Add timeout flag to devices command, pipe through discovery (#51678) 2020-03-16 14:15:00 -07:00
Jonah Williams 028b7dced1
[flutter_tools] remove context from WebWorkflow (#52613) 2020-03-16 11:33:00 -07:00
Michael Thomsen e167181444
Move flutter_gallery to the testing folder (#52532)
Move Flutter Gallery to dev/integration_tests/ as it is an older copy used only for testing. The current version of the Flutter Gallery now lives in https://github.com/flutter/gallery.
2020-03-16 10:31:42 +01:00
Jenn Magder 73ea37eca9
Revert "Fall back to environment SDKROOT passed from Xcode (#52570)" (#52583)
This reverts commit 8e6e15f915.
2020-03-13 18:29:09 -07:00
Jenn Magder 8e6e15f915
Fall back to environment SDKROOT passed from Xcode (#52570) 2020-03-13 17:16:56 -07:00
Dan Field 98cf01858c
Fetch tags for version command (#52212) 2020-03-13 17:16:03 -07:00
Jonah Williams bbc5b9d967
Revert "[flutter_tools]: reland android device cleanup (#52542)" (#52579)
This reverts commit 9186dfc34d.
2020-03-13 16:38:59 -07:00
Jonah Williams 3bc36095da
Revert "[flutter_tools]: reland move engine unpack to dart (#52543)" (#52549)
This reverts commit 3e25e60f57.
2020-03-13 09:50:07 -07:00
Jonah Williams 9186dfc34d
[flutter_tools]: reland android device cleanup (#52542) 2020-03-13 09:42:02 -07:00
Jonah Williams 3e25e60f57
[flutter_tools]: reland move engine unpack to dart (#52543)
Reland of #50707
2020-03-13 09:40:55 -07:00
Jonah Williams b3a37d0273
[flutter_tools] support toggling CanvasKit rendering on with 'k' (#52511) 2020-03-13 07:02:34 -07:00
Jonah Williams 1e8c4572ec
Revert "[flutter_tools] remove globals in AndroidDevices (#52505)" (#52515)
This reverts commit 1bf9d6f4f7.
2020-03-12 18:14:32 -07:00
Christopher Fujino 14d8534c3e
add usbmuxd (#52500) 2020-03-12 17:36:01 -07:00
Jonah Williams 1bf9d6f4f7
[flutter_tools] remove globals in AndroidDevices (#52505) 2020-03-12 15:51:26 -07:00
Zachary Anderson 0cd2ece539
[flutter_tools] Hanlde OSError in places where we've seen it thrown (#52491) 2020-03-12 14:01:01 -07:00
Jonah Williams d98213c46f
[flutter_tools] reland: Update background isolates when performing hot reload/restart (#52479)
Reland of #52149
2020-03-12 12:48:05 -07:00
Finn 9e848f3c78
Add ignore public member api docs in template (#52422) 2020-03-12 10:36:02 -07:00
Christopher Fujino 38a8845481
move iosworkflow to globals (#52444) 2020-03-12 10:16:28 -07:00
Dmitry Ratushnyy 1b0fd265bd
[ISSUE-30478] Release cache dir lock acquired by a command on sigint or sigterm (#52194) 2020-03-12 09:11:01 -07:00
Zachary Anderson 04a1b78b75
Revert "[flutter_tools] Update background isolates when performing hot reload/restart (#52149)" (#52476)
This reverts commit edd03a1af8.
2020-03-12 09:02:31 -07:00
Jonah Williams edd03a1af8
[flutter_tools] Update background isolates when performing hot reload/restart (#52149)
When performing a hot restart, collect isolates without an attached flutter view and send a kill signal. These must have been spawned by running main, so restarting without removing them leads to isolate duplication.

When performing a hot reload, ensure that we send a reloadSources command to every isolate and not just uiIsolates.
2020-03-11 15:52:04 -07:00
Jonah Williams 6804cef587
[flutter_tools] throw exception instead of string from startApp (#52365)
When attempting to start an emulator in profile mode, ensure the daemon can exit gracefully
2020-03-11 09:41:52 -07:00
Emmanuel Garcia 4049889d9e
Make --androidx flag a noop in flutter create (#52340) 2020-03-10 20:05:41 -07:00
Jonah Williams ea3563ea4d
[flutter_tools] update visual studio and validator to remove globals, update test cases (#51680)
Updates VisualStudio and VisualStudioValidator to use constructors instead of global injection. Updates VisualStudio test cases to prefer FakeProcessManager
Updates build_windows test to work without injected VisualStudio
2020-03-10 16:49:23 -07:00
Zachary Anderson 53dce17b35
[flutter_tools] Fallback discovery: Don't crash when an Isolate has no root library (#52354) 2020-03-10 15:31:02 -07:00
Zachary Anderson 78b45fb1b2
[flutter_tools] Throw a tool exit when samples fetch fails (#52355) 2020-03-10 15:21:02 -07:00
Zachary Anderson 7f564b7436
[flutter_tools] Handle StateError in ProtocolDiscovery.uri (#52337) 2020-03-10 14:26:02 -07:00
Jonah Williams 5d289721fc
[flutter_tools] handle null value from sdk version (#52351)
When the AndroidDevice checks for the current API version, it isn't handling a null response. While we can refuse to run on API levels that are unsupported, we should probably assume that a null response = lowest possible API level and allow these to run.
2020-03-10 14:23:18 -07:00
Zachary Anderson 605debfcff
[flutter_tools] Make AndroidConsole check for next line (#52353) 2020-03-10 14:21:01 -07:00
Zachary Anderson 733fc20073
[flutter_tool] Use unzip -t instead of zip -T to verify zip files (#52331) 2020-03-10 12:22:53 -07:00
Jonah Williams fdb7bd3c0f
[flutter_tools] attempt to fix .first crasher in web loading (#52301) 2020-03-10 12:09:37 -07:00
Jonah Williams 2133343a29
[flutter_tools] cache result of BotDetector in persistent tool state (#52325)
The Azure bot detection can take up to a second to determine if a client is/isn't a bot. To prevent this from slowing down all flutter commands, we can cache the results in the persistent tool state - since we don't expect the same client id to ever become a bot or stop being a bot
2020-03-10 11:35:52 -07:00
Jonah Williams 377879825e
[flutter_tools] prevent StateError when log reader is disposed (#52173)
Previously the AdbLogReader did async setup in the StreamController.onListen callback, specifically it would query the api version and start the adb process. If the log subscription was cancelled before this setup completed, then the log output could (haven't confirmed) get added to a closed controller, causing the above state error.
2020-03-10 11:34:40 -07:00
Jenn Magder fdd023fa59
Migrate older Xcode projects off the legacy build system (#52288) 2020-03-10 10:11:16 -07:00
Jonah Williams 60d0fef17a
[flutter_tools] move stack_trace_mapper and require.js into memory file system (#52276) 2020-03-09 22:07:34 -07:00
Jonah Williams 3191af1332
[flutter_tools] add more information to obfuscate option documentation (#52282) 2020-03-09 20:09:47 -07:00
Jonah Williams 88b39402ac
[flutter_tools] configure dwds to not serve devtools (#52284) 2020-03-09 19:20:11 -07:00
Jonah Williams bc43b41d99
[flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261)
This option was defaulting to on, which was tickling some benchmarks
2020-03-09 17:19:14 -07:00
Angjie Li 665d380f81
Add Android Chrome support to Flutter Web Driver. (#51677)
* Support Android Chrome for Flutter Web Driver.
2020-03-09 13:01:07 -07:00
Dan Field e13e17009d
Reland fix --version (#52141) 2020-03-06 21:38:35 -08:00
Dan Field db1f33fd70
Revert "Local engine build mode (#52043)" (#52152)
This reverts commit 4d05ed5deb.
2020-03-06 16:57:18 -08:00
Jonah Williams c1112d3f7e
[flutter_tools] Reland: Allow providing dart-defines to Android, iOS, macOS builds (#52044) 2020-03-06 14:53:36 -08:00
Christopher Fujino 2e18cd347e
Fix simctl process exceptions not being caught (#51916) 2020-03-06 13:16:01 -08:00
Jonah Williams e7d70fbf75
Revert "Fix version command for certain git workflows (#52062)" (#52128)
This reverts commit 20bf43b9eb.
2020-03-06 12:58:00 -08:00
Jenn Magder a14ac4e3c8
Bump recommended CocoaPods version to 1.8 (#52071) 2020-03-06 12:14:42 -08:00
Jenn Magder f6a55125d2
Add usage event for failed iOS project migration (#51879) 2020-03-06 12:14:29 -08:00
Zachary Anderson 6c408a0567
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#52021)
* Reland: [flutter_tool] Where possible, catch only subtypes of Exception

* Add armv7f to getIOSArchForName
2020-03-06 10:22:12 -08:00
Dan Field 20bf43b9eb
Fix version command for certain git workflows (#52062) 2020-03-05 23:51:02 -08:00
Dan Field 4d05ed5deb
Local engine build mode (#52043) 2020-03-05 23:46:02 -08:00
Jonah Williams d2f889b4f0
[flutter_tools] Reduce context usage in analyze command and tests (#49589) 2020-03-05 17:20:54 -08:00
Jonah Williams bafa03e5b5
[flutter_tools] Remove mocking and simplify Dart target tests (#50688) 2020-03-05 17:19:15 -08:00
Jonah Williams 8872d1d8c4
[flutter_tools] Reland: supports tree-shake-icons for web builds (#52054) 2020-03-05 17:18:44 -08:00
Jenn Magder b8472f25ab
Update Maven URL to https (#52042) 2020-03-05 16:00:34 -08:00
Jonah Williams ad16823e4c
[flutter_tools] support new SDK structure for sdkmanager (#51980) 2020-03-05 13:59:20 -08:00
Jonah Williams c411f588c6
Revert "[flutter_tools] supports tree-shake-icons for web builds (#51808)" (#52045)
This reverts commit aed961993d.
2020-03-05 13:02:22 -08:00
Jonah Williams ee476a7bd1
Revert "[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714)" (#52041)
This reverts commit ee60eeea3e.
2020-03-05 12:51:42 -08:00
Jonah Williams ee60eeea3e
[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714) 2020-03-05 12:38:40 -08:00
Jonah Williams aed961993d
[flutter_tools] supports tree-shake-icons for web builds (#51808)
* [flutter_tools] supports tree-shake-icons for web builds

* Update compile.dart

* fix icon_tree_shaker
2020-03-05 12:35:04 -08:00
Jonah Williams 1bf6f0232e
[flutter_tools] support coverage and machine together (#51988) 2020-03-05 12:34:37 -08:00
Jonah Williams bbf913bc4c
[flutter_tools] resolve requests to web directory in debug mode (#51995) 2020-03-05 12:34:03 -08:00
Jonah Williams 374f85c976
[flutter_tools] pin exact build_runner version (#52033) 2020-03-05 11:09:41 -08:00
Alexandre Ardhuin c2ae654ddf
enable avoid_single_cascade_in_expression_statements (#51944) 2020-03-05 08:03:26 +01:00
Jenn Magder db94472aeb
Skip iOS project migration when script is already embedding frameworks (#51963) 2020-03-04 16:12:13 -08:00
Jenn Magder dc33334675
Update iOS project migration help URL (#51973) 2020-03-04 16:12:02 -08:00
Jenn Magder cbbb7ec5a7
Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51774)" (#51960)
This reverts commit 57c6721cd5.
2020-03-04 12:40:15 -08:00
Flutter GitHub Bot 57c6721cd5
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51774) 2020-03-04 11:41:02 -08:00
Ben Konyi 3edd3eb4a2
Updated package:test, package:test_core, package:coverage, package:package_config (#51946)
This is required to roll forward package:vm_service to 3.0.0 and is
blocking a DevTools release.
2020-03-04 11:40:52 -08:00
Zachary Anderson a5bd678585
Revert "Write FLUTTER_BUILD_MODE when using a local engine (#51687)" (#51943)
This reverts commit 9b4b7d7ee0.
2020-03-04 08:56:53 -08:00
Dan Field 9b4b7d7ee0
Write FLUTTER_BUILD_MODE when using a local engine (#51687) 2020-03-04 07:36:55 -08:00
Christopher Fujino 2c846af1a0
Fix _checkPodCondition not handling CocoaPodsStatus.brokenInstall (#51676) 2020-03-03 17:55:02 -08:00
Konstantin Scheglov fb953b719f
Cast to List<dynamic> and cast(). (#51591) 2020-03-03 14:49:02 -08:00
stuartmorgan f9c118b6b2
Exit for missing Windows plugin projects (#51838)
Exit, rather than crash, if a Windows plugin is missing its project.

Fixes #51743
2020-03-03 22:43:42 +01:00
stuartmorgan 8d8439f8e3
Add pre-stable support for create on Linux (#51832)
Adds initial support for `flutter create` of apps and plugins. This is derived from the current FDE example app and sample plugin, with a few changes:
- Added template values where it makes sense.
- Moved some likely-to-change values into separate files for now, to simplify the delete/recreate cycle that will be necessary until it's stable.
- Added some minor Makefile flag handling improvements

Since the APIs/tooling/template aren't stable yet, the app template includes a version marker, which will be updated each time there's a breaking change. The build now checks that the template version matches the version known by that version of the tool, and gives a specific error message when there's a mismatch, which improves over the current breaking change experience of hitting whatever build failure the breaking change causes and having to figure out that the problem is that the runner is out of date. It also adds a warning to the `create` output about the fact that it won't be stable.
2020-03-03 22:42:52 +01:00
Jenn Magder e491544588
Move embedding and linking Flutter frameworks into the tool (#51453)
* Move embedding and linking Flutter frameworks into the tool

* Unused import

* Migrate

* Rename run, add comments, remove typedef

* Add status log to tell the user what we did

* Remove Podfile migration, create IOSMigration superclass

* word-smiting

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* for space

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-03-03 12:11:28 -08:00
Shi-Hao Hong d2c734a36f
Simple repeating word fixes (#51871) 2020-03-03 11:13:07 -08:00
Greg Spencer 1ba4f1f509
Add Linux and Windows target platforms (#51519)
This PR adds the linux and windows target platform enum values, along with automatically setting the defaultTargetPlatform to the appropriate value on those platforms.

Fixes #31366
2020-03-03 04:38:04 -08:00
zsunkun fdbd1b14ff
fix pom file not found when run app with local engine (#51468) 2020-03-02 19:09:01 -08:00
Jonah Williams 3489da9328
[flutter_tools] no more MockLogger in tests (#51684) 2020-03-02 16:23:56 -08:00
Zachary Anderson 914bd76979
[flutter_tools] Handle errors on the std{out,err}.done future (#51660) 2020-02-28 22:31:01 -08:00
Jonah Williams 9b4159c5ee
[flutter_tools] support run -d chrome test scripts (#51658) 2020-02-28 14:21:02 -08:00
Jonah Williams 515027a91c
[flutter_tools] allow configuring libraries spec path for the web compilation (#51590) 2020-02-28 11:26:02 -08:00
Jonah Williams 42ae15f44e
[flutter_tools] remove LinuxWorkflow from injection and clean up tests (#51597) 2020-02-28 10:27:27 -08:00
Zachary Anderson b32ee2f15c
Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51567)" (#51616)
This reverts commit 9de7787f25.
2020-02-27 22:57:13 -08:00
stuartmorgan 33bb1faf5b
Reland: Always use new plugin schema for plugin template (#49832)
Now that the new schema is supported on the stable channel, and the old
schema is considered legacy, the template should always create plugins
using the new schema.
2020-02-27 22:48:25 -08:00
Zachary Anderson 9de7787f25
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51567) 2020-02-27 22:46:23 -08:00
Jonah Williams e00d424de5
[flutter_tools] clean-ups to linux doctor test (#51593) 2020-02-27 15:15:35 -08:00
Jenn Magder 4fb9ce8414
Clean App.framework, Generated.xcconfig, flutter_export_environment.sh (#51532) 2020-02-27 12:18:06 -08:00
Jonah Williams 080dfb5eb3
[flutter_tools] swap mustache dependency for mustache_template (#51578) 2020-02-27 11:23:41 -08:00