development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 19:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bump recommended CocoaPods version to 1.8 (#52071)

Browse source
This commit is contained in:
Jenn Magder 2020-03-06 12:14:42 -08:00 committed by GitHub
parent f6a55125d2
commit a14ac4e3c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/flutter_tools/lib/src/macos/cocoapods.dart
View file

@ -69,7 +69,7 @@ class CocoaPods {
Future<String> _versionText;
String get cocoaPodsMinimumVersion => '1.6.0';
String get cocoaPodsRecommendedVersion => '1.6.0';
String get cocoaPodsRecommendedVersion => '1.8.0';
Future<bool> get isInstalled =>
processUtils.exitsHappy(<String>['which', 'pod']);

14
packages/flutter_tools/test/general.shard/macos/cocoapods_test.dart
View file

@ -68,7 +68,7 @@ void main() {
projectUnderTest = FlutterProject.fromDirectory(fs.directory('project'));
projectUnderTest.ios.xcodeProject.createSync(recursive: true);
cocoaPodsUnderTest = CocoaPods();
pretendPodVersionIs('1.6.0');
pretendPodVersionIs('1.8.0');
fs.file(fs.path.join(
Cache.flutterRoot, 'packages', 'flutter_tools', 'templates', 'cocoapods', 'Podfile-ios-objc',
))
@ -173,9 +173,17 @@ void main() {
ProcessManager: () => mockProcessManager,
});
testUsingContext('detects at recommended version', () async {
testUsingContext('detects below recommended version', () async {
pretendPodIsInstalled();
pretendPodVersionIs('1.6.0');
expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.belowRecommendedVersion);
}, overrides: <Type, Generator>{
ProcessManager: () => mockProcessManager,
});
testUsingContext('detects at recommended version', () async {
pretendPodIsInstalled();
pretendPodVersionIs('1.8.0');
expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.recommended);
}, overrides: <Type, Generator>{
ProcessManager: () => mockProcessManager,
@ -183,7 +191,7 @@ void main() {
testUsingContext('detects above recommended version', () async {
pretendPodIsInstalled();
pretendPodVersionIs('1.6.1');
pretendPodVersionIs('1.8.1');
expect(await cocoaPodsUnderTest.evaluateCocoaPodsInstallation, CocoaPodsStatus.recommended);
}, overrides: <Type, Generator>{
ProcessManager: () => mockProcessManager,