development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-13 19:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ISSUE-30478] Release cache dir lock acquired by a command on sigint or sigterm (#52194)

Browse source
This commit is contained in:
Dmitry Ratushnyy 2020-03-13 01:11:01 +09:00 committed by GitHub
parent 04a1b78b75
commit 1b0fd265bd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 38 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/flutter_tools/lib/src/runner/flutter_command.dart
View file

@ -622,6 +622,7 @@ abstract class FlutterCommand extends Command<void> {
void _registerSignalHandlers(String commandPath, DateTime startTime) {
final SignalHandler handler = (io.ProcessSignal s) {
Cache.releaseLockEarly();
_sendPostUsage(
commandPath,
const FlutterCommandResult(ExitStatus.killed),

37
packages/flutter_tools/test/general.shard/runner/flutter_command_test.dart
View file

@ -287,6 +287,43 @@ void main() {
SystemClock: () => clock,
Usage: () => usage,
});
testUsingContext('command release lock on kill signal', () async {
mockTimes = <int>[1000, 2000];
final Completer<void> completer = Completer<void>();
setExitFunctionForTests((int exitCode) {
expect(exitCode, 0);
restoreExitFunction();
completer.complete();
});
final Completer<void> checkLockCompleter = Completer<void>();
final DummyFlutterCommand flutterCommand =
DummyFlutterCommand(commandFunction: () async {
await Cache.lock();
checkLockCompleter.complete();
final Completer<void> c = Completer<void>();
await c.future;
return null; // unreachable
});
unawaited(flutterCommand.run());
await checkLockCompleter.future;
Cache.checkLockAcquired();
signalController.add(mockSignal);
await completer.future;
await Cache.lock();
Cache.releaseLockEarly();
}, overrides: <Type, Generator>{
ProcessInfo: () => mockProcessInfo,
Signals: () => FakeSignals(
subForSigTerm: signalUnderTest,
exitSignals: <ProcessSignal>[signalUnderTest],
),
Usage: () => usage
});
});
testUsingCommandContext('report execution timing by default', () async {