Kate Lovett
4820e0cd9f
Fix skipping golden comparator for CI environments ( #145619 )
...
Fixes https://github.com/flutter/flutter/issues/145618
The local file comparator was being used in post submit for the Linux coverage shard. This corrects it to choose the skipping comparator.
2024-03-22 20:45:35 +00:00
engine-flutter-autoroll
de68c9385d
Roll Flutter Engine from 68301f268278 to cc8f752b81e5 (1 revision) ( #145621 )
...
68301f2682...cc8f752b81jason-simmons@users.noreply.github.com [Impeller] Check for empty sizes when creating render targets in RenderTargetCache (flutter/engine#51597 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 19:40:30 +00:00
engine-flutter-autoroll
7009b926b5
Roll Packages from b7fbe68d4ec2 to 611aea1657fb (4 revisions) ( #145615 )
...
b7fbe68d4e...611aea1657engine-flutter-autoroll@skia.org Roll Flutter from b96c13d1e918340ea16cflutter/packages#6370 )
2024-03-21 engine-flutter-autoroll@skia.org Roll Flutter (stable) from ba3931984368bfaea224flutter/packages#6368 )
2024-03-21 stuartmorgan@google.com [flutter_adaptive_scaffold] Remove broken link from README (flutter/packages#6364 )
2024-03-21 38110731+aliasgar4558@users.noreply.github.com [adaptive_scaffold] : ð : #110902 : Assertion added when try with less that 2 destinations. (flutter/packages#6360 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 18:40:08 +00:00
engine-flutter-autoroll
e9a0c354a1
Roll Flutter Engine from 63ff0dedd8e6 to 68301f268278 (2 revisions) ( #145613 )
...
63ff0dedd8...68301f2682skia-flutter-autoroll@skia.org Roll Skia from 14c5a8540691 to 6484a450c457 (19 revisions) (flutter/engine#51623 )
2024-03-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b89d2de510d1 to a959c7def805 (4 revisions) (flutter/engine#51622 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 18:38:15 +00:00
engine-flutter-autoroll
26909e0a83
Roll Flutter Engine from 09dadce76828 to 63ff0dedd8e6 (2 revisions) ( #145611 )
...
09dadce768...63ff0dedd8737941+loic-sharma@users.noreply.github.com [Embedder API] Add helper to create viewport metrics (flutter/engine#51562 )
2024-03-22 737941+loic-sharma@users.noreply.github.com [Windows] Allow view controllers to not own the engine (flutter/engine#51570 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 17:23:23 +00:00
Kate Lovett
c5047e0ada
2DScrollView - Fix drag when one axis does not have enough content ( #145566 )
...
Fixes https://github.com/flutter/flutter/issues/144982
For reference, may have to do with #138442 when we reworked the gesture handling. The adjustments to the comments here were certainly from #138442 not updating them. Confused myself for a minute or two. ð
2024-03-22 16:42:19 +00:00
engine-flutter-autoroll
14774b95c2
Roll Flutter Engine from eba6e31498b8 to 09dadce76828 (1 revision) ( #145603 )
...
eba6e31498...09dadce768kjlubick@users.noreply.github.com Update one more use of deprecated GrDirectContext::MakeMetal (flutter/engine#51619 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 16:40:21 +00:00
engine-flutter-autoroll
7ad647ab92
Roll Flutter Engine from f9a34ae0b14f to eba6e31498b8 (1 revision) ( #145598 )
...
f9a34ae0b1...eba6e31498jason-simmons@users.noreply.github.com Post Dart message handling tasks directly to the platform task runner for isolates running on the platform thread (flutter/engine#51573 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 15:55:02 +00:00
Nate
7fb35db62f
Intensive if chain refactoring ( #145194 )
...
This pull request refactors if-statements into switch expressions, as part of the effort to solve issue #144903 .
Making changes beyond just swapping syntax is more difficult (and also more difficult to review, I apologize), but much more satisfying too.
2024-03-22 13:55:06 +00:00
Bruno Leroux
859eb2eda9
Adds numpad navigation shortcuts for Linux ( #145464 )
...
## Description
This PR adds shortcuts related to numpad keys on Linux.
## Related Issue
Linux side for https://github.com/flutter/flutter/issues/144936
## Tests
Adds 2 tests.
2024-03-22 06:22:09 +00:00
engine-flutter-autoroll
5fab92f062
Roll Flutter Engine from 5a12de1beab7 to f9a34ae0b14f (1 revision) ( #145581 )
...
5a12de1bea...f9a34ae0b126625149+0xZOne@users.noreply.github.com [Android] Fix the issue of blank or frozen pages in shared engine scenarios (flutter/engine#50947 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 04:56:12 +00:00
engine-flutter-autoroll
5058c2687e
Roll Flutter Engine from e2f324beac3b to 5a12de1beab7 (1 revision) ( #145578 )
...
e2f324beac...5a12de1bea41930132+hellohuanlin@users.noreply.github.com [ios][platform_view][performance] overlay intersection (flutter/engine#50637 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 03:20:10 +00:00
LongCatIsLooong
d755bc222b
Replace RenderBox.compute* with RenderBox.get* and add @visibleForOverriding ( #145503 )
...
`@visibleForOverriding` + `@protected` unfortunately does not catch the case where a `compute*` method was overridden in a subtype and the overide was called in that same type's implementation.
I did not add a `flutter_ignore` for this because it doesn't seem there will be false positives.
2024-03-22 02:44:55 +00:00
Greg Spencer
0f685f88c6
Add some cross references in the docs, move an example to a dartpad example ( #145571 )
...
## Description
This adds some "See also" links to some docs for `TweenAnimationBuilder` and `ValueListenableBuilder`.
Also, moved a "snippet" example in `ValueListenableBuilder` into the examples directory as a Dartpad example.
## Tests
- Added test for the example.
2024-03-22 02:35:11 +00:00
Bernardo Ferrari
784f19c49c
Fix BorderSide.none requiring explicit transparent color for UnderlineInputBorder ( #145329 )
...
Fix could have been "paint transparent when Border none" but, following other Borders, we will just not paint anything.
Fix https://github.com/flutter/flutter/issues/143746
2024-03-22 02:31:16 +00:00
engine-flutter-autoroll
e1c6445467
Roll Flutter Engine from a46a7b273a5b to e2f324beac3b (1 revision) ( #145576 )
...
a46a7b273a...e2f324beac34871572+gmackall@users.noreply.github.com Make the et feature request link properly add the github label (flutter/engine#51594 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-22 02:25:38 +00:00
Michael Goderbauer
11c034f037
Fix nullability of getFullHeightForCaret ( #145554 )
...
Fixes https://github.com/flutter/flutter/issues/145507 .
Looks like this was accidentally migrated to nullable all the way back when we switched to NNBD.
2024-03-21 23:38:16 +00:00
Gray Mackall
3b390c5284
Add a --no-gradle-generation mode to the generate_gradle_lockfiles.dart script ( #145568 )
...
The script currently overwrites existing `settings.gradle`, `build.gradle`, and `gradle-wrapper.properties` files in the directories it processes. This mode makes it not do that, and just generate the lockfiles themselves.
Related to https://github.com/flutter/flutter/pull/145564#r1371888460
2024-03-21 23:24:09 +00:00
engine-flutter-autoroll
a36569d198
Roll Flutter Engine from 1b842ae58b3d to a46a7b273a5b (2 revisions) ( #145569 )
...
1b842ae58b...a46a7b273a737941+loic-sharma@users.noreply.github.com [Fuchsia] Assert renders are only to the implicit view (flutter/engine#51559 )
2024-03-21 737941+loic-sharma@users.noreply.github.com [Embedder API] Fix test helper's present callback registration (flutter/engine#51560 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 23:15:12 +00:00
Lau Ching Jun
c759c22e71
Fixed race condition in PollingDeviceDiscovery. ( #145506 )
...
There are two issues in the previous implementation:
1. `_populateDevices` will return the devices from `deviceNotifier` if it had been initialized, assuming that once it's initialized, it has been properly populated. That assumption is not true because calling getters like `onAdded` would initialize `deviceNotifier` without populating it.
2. `deviceNotifier` instance might be replaced in some cases, causing `onAdded` subscribers to lose any future updates.
To fix (1), this commit added the `isPopulated` field in `deviceNotifier` as a more accurate flag to determine if we need to populate it.
To fix (2), this commit made `deviceNotifier` a final member in `PolingDeviceDiscovery`.
2024-03-21 22:37:08 +00:00
engine-flutter-autoroll
d69833ceb2
Roll Flutter Engine from a2ed373fa70f to 1b842ae58b3d (1 revision) ( #145565 )
...
a2ed373fa7...1b842ae58bian@hixie.ch Add a breadcrumb from FlutterView to PlatformDispatcher. (flutter/engine#51504 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 22:33:16 +00:00
Ian Hickson
afe01503d8
Clarify AutomaticKeepAliveClientMixin semantics in build method ( #145297 )
...
This should help folks who trace the code before reading the documentation.
2024-03-21 21:28:07 +00:00
Michael Goderbauer
eaf509aaf8
Eliminate more window singleton usages ( #145560 )
...
These usages in strings slipped through the initial clean-up.
2024-03-21 20:59:25 +00:00
Jackson Gardner
31209d04ff
flutter test --wasm support (#145347 )
...
* Adds support for `flutter test --wasm`.
* The test compilation flow is a bit different now, so that it supports compilers other than DDC. Specifically, when we run a set of unit tests, we generate a "switchboard" main function that imports each unit test and runs the main function for a specific one based off of a value set by the JS bootstrapping code. This way, there is one compile step and the same compile output is invoked for each unit test file.
* Also, removes all references to `dart:html` from flutter/flutter.
* Adds CI steps for running the framework unit tests with dart2wasm+skwasm
* These steps are marked as `bringup: true`, so we don't know what kind of failures they will result in. Any failures they have will not block the tree at all yet while we're still in `bringup: true`. Once this PR is merged, I plan on looking at any failures and either fixing them or disabling them so we can get these CI steps running on presubmit.
This fixes https://github.com/flutter/flutter/issues/126692
2024-03-21 20:08:07 +00:00
engine-flutter-autoroll
98d10b6211
Roll Flutter Engine from eb262e9c34db to a2ed373fa70f (2 revisions) ( #145556 )
...
eb262e9c34...a2ed373fa7skia-flutter-autoroll@skia.org Roll Dart SDK from 5724c0dc7846 to b89d2de510d1 (1 revision) (flutter/engine#51584 )
2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 72875d47dbc3 to 14c5a8540691 (1 revision) (flutter/engine#51583 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 19:56:17 +00:00
engine-flutter-autoroll
064660083b
Roll Flutter Engine from bad4a30e1c75 to eb262e9c34db (1 revision) ( #145555 )
...
bad4a30e1c...eb262e9c34jason-simmons@users.noreply.github.com Move //buildtools to //flutter/buildtools (flutter/engine#51526 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 19:03:14 +00:00
engine-flutter-autoroll
18340ea16c
Roll Flutter Engine from 7cdb240c4a16 to bad4a30e1c75 (2 revisions) ( #145551 )
...
7cdb240c4a...bad4a30e1cskia-flutter-autoroll@skia.org Roll Skia from 2ed0d31938e3 to 72875d47dbc3 (1 revision) (flutter/engine#51582 )
2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 5f32b063a869 to 2ed0d31938e3 (1 revision) (flutter/engine#51581 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 18:18:52 +00:00
engine-flutter-autoroll
dbf0637324
Roll Packages from 23e56af4a622 to b7fbe68d4ec2 (3 revisions) ( #145547 )
...
23e56af4a6...b7fbe68d4e38110731+aliasgar4558@users.noreply.github.com [adaptive_scaffold] : ð #141938 - Drawer stays open even on destination tap. (flutter/packages#6289 )
2024-03-20 43054281+camsim99@users.noreply.github.com [camera_android] Update README to encourage users to use CameraX implementation (flutter/packages#6353 )
2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter from d31a85ba5cb96c13d1e9flutter/packages#6359 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 17:47:05 +00:00
Pascal Welsch
4bbe6d594d
Add WidgetsApp.debugShowWidgetInspectorOverride again (deprecated) ( #145334 )
...
`WidgetsApp.debugShowWidgetInspectorOverride` was replaced with ` WidgetsBinding.instance.debugShowWidgetInspectorOverrideNotifier` in https://github.com/flutter/flutter/pull/144029 .
The old API was removed, not deprecated.
It is used by some [open-source projects](https://github.com/search?q=WidgetsApp.debugShowWidgetInspectorOverride&type=code ), thus I'm making the effort of bringing the API back as deprecated.
Fixes https://github.com/flutter/flutter/issues/145333
2024-03-21 17:43:05 +00:00
auto-submit[bot]
fd18e5ce48
Reverts "Roll pub packages ( #145509 )" ( #145550 )
...
Reverts: flutter/flutter#145509
Initiated by: yusuf-goog
Reason for reverting: Failing builds, blocking tree.
Original PR Author: flutter-pub-roller-bot
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
This PR was generated by `flutter update-packages --force-upgrade`.
2024-03-21 17:32:48 +00:00
flutter-pub-roller-bot
5545c95df7
Roll pub packages ( #145509 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-03-21 16:16:07 +00:00
engine-flutter-autoroll
33380c6b42
Roll Flutter Engine from 14b67475cf80 to 7cdb240c4a16 (1 revision) ( #145533 )
...
14b67475cf...7cdb240c4askia-flutter-autoroll@skia.org Roll Dart SDK from 5e825c7fcf59 to 5724c0dc7846 (1 revision) (flutter/engine#51580 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 15:20:52 +00:00
engine-flutter-autoroll
3bfa82919b
Roll Flutter Engine from 6de3d9b6196a to 14b67475cf80 (1 revision) ( #145529 )
...
6de3d9b619...14b67475cfskia-flutter-autoroll@skia.org Roll Skia from 9c0e0b553c02 to 5f32b063a869 (1 revision) (flutter/engine#51579 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 13:34:13 +00:00
engine-flutter-autoroll
616574251c
Roll Flutter Engine from c0d3ac3178fa to 6de3d9b6196a (1 revision) ( #145520 )
...
c0d3ac3178...6de3d9b619skia-flutter-autoroll@skia.org Roll Dart SDK from 43662466cee8 to 5e825c7fcf59 (2 revisions) (flutter/engine#51577 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 09:00:37 +00:00
engine-flutter-autoroll
4b046f104a
Roll Flutter Engine from 23dc0cacc4db to c0d3ac3178fa (1 revision) ( #145519 )
...
23dc0cacc4...c0d3ac3178skia-flutter-autoroll@skia.org Roll Skia from 1d0a90ac5a64 to 9c0e0b553c02 (2 revisions) (flutter/engine#51578 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 07:56:27 +00:00
engine-flutter-autoroll
e077e15710
Roll Flutter Engine from a73e01364de0 to 23dc0cacc4db (2 revisions) ( #145517 )
...
a73e01364d...23dc0cacc4skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uINhDrQ3fkTE08_he... to AW70sjrQKy2sSXpUA... (flutter/engine#51575 )
2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 300e58020707 to 1d0a90ac5a64 (1 revision) (flutter/engine#51576 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uINhDrQ3fkTE to AW70sjrQKy2s
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 07:09:07 +00:00
engine-flutter-autoroll
0e268b5024
Roll Flutter Engine from 45ed36c17bb7 to a73e01364de0 (1 revision) ( #145516 )
...
45ed36c17b...a73e01364dskia-flutter-autoroll@skia.org Roll Skia from 0091e089fb24 to 300e58020707 (3 revisions) (flutter/engine#51574 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 04:34:15 +00:00
engine-flutter-autoroll
b88810d37e
Roll Flutter Engine from 34b304a27f73 to 45ed36c17bb7 (1 revision) ( #145513 )
...
34b304a27f...45ed36c17bskia-flutter-autoroll@skia.org Roll Skia from 3ffa395f8fbc to 0091e089fb24 (2 revisions) (flutter/engine#51564 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 03:56:39 +00:00
engine-flutter-autoroll
416a4b85c3
Roll Flutter Engine from 912c61f30512 to 34b304a27f73 (1 revision) ( #145511 )
...
912c61f305...34b304a27fskia-flutter-autoroll@skia.org Roll Dart SDK from 0f00e7188e0e to 43662466cee8 (1 revision) (flutter/engine#51572 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 03:13:32 +00:00
engine-flutter-autoroll
e95df00605
Roll Flutter Engine from 98cfd9213332 to 912c61f30512 (1 revision) ( #145504 )
...
98cfd92133...912c61f30530870216+gaaclarke@users.noreply.github.com [golden_test_harvester]: Put back sending the dimensions to the SkiaGoldClient (flutter/engine#51536 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-21 00:11:11 +00:00
flutter-pub-roller-bot
61b3f975a0
Roll pub packages ( #145476 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-03-21 00:09:24 +00:00
engine-flutter-autoroll
274152fcbf
Roll Flutter Engine from fe6927c79dc3 to 98cfd9213332 (1 revision) ( #145498 )
...
fe6927c79d...98cfd92133skia-flutter-autoroll@skia.org Roll Skia from 715a74e907d7 to 3ffa395f8fbc (3 revisions) (flutter/engine#51563 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-20 22:01:24 +00:00
engine-flutter-autoroll
a04b557143
Roll Flutter Engine from d1fe8994dedf to fe6927c79dc3 (1 revision) ( #145493 )
...
d1fe8994de...fe6927c79djason-simmons@users.noreply.github.com Add the platform isolate API to the files included in the sky_engine package (flutter/engine#51538 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-20 21:09:09 +00:00
Vatsal Bhesaniya
01fc13d9f9
Add helper widget parameter to InputDecoration ( #145157 )
...
This pull request introduces a new field named `helper` to the InputDecoration class. This field allows for specifying a widget containing contextual information about the InputDecorator.child's value. Unlike `helperText`, which accepts a plain string, `helper` supports widgets, enabling functionalities like tappable links for further explanation. This change aligns with the established pattern of `error`, `label`, `prefix`, and `suffix`.
fixes [#145163 ](https://github.com/flutter/flutter/issues/145163 )
2024-03-20 20:48:05 +00:00
Gray Mackall
39bdff16c1
Remove embedding v1 code in framework ( #144726 )
...
Pre work for https://github.com/flutter/engine/pull/51229 . Removes a lot of code referencing v1 of the android embedding, though not necessarily all of it (I may have missed some, it is hard to know).
Will hopefully make landing that PR less painful (or maybe painless?)
2024-03-20 20:34:14 +00:00
engine-flutter-autoroll
f9f77a481a
Roll Flutter Engine from 1b52f57ca07c to d1fe8994dedf (8 revisions) ( #145491 )
...
1b52f57ca0...d1fe8994deskia-flutter-autoroll@skia.org Roll Skia from ecfbdc3df797 to 715a74e907d7 (2 revisions) (flutter/engine#51557 )
2024-03-20 kjlubick@users.noreply.github.com Migrate use of deprecated GrDirectContext::MakeMetal (flutter/engine#51537 )
2024-03-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 1fec62355504 to 0f00e7188e0e (1 revision) (flutter/engine#51556 )
2024-03-20 jonahwilliams@google.com [Impeller] add test that demonstrates that VVL failures are fatal. (flutter/engine#51525 )
2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 4543913c6243 to ecfbdc3df797 (2 revisions) (flutter/engine#51555 )
2024-03-20 34871572+gmackall@users.noreply.github.com Upgrade to gradle 8.3 (flutter/engine#51422 )
2024-03-20 34871572+gmackall@users.noreply.github.com Add even more logging for UnsatisfiedLinkError (flutter/engine#51554 )
2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 80e713052b7a to 4543913c6243 (2 revisions) (flutter/engine#51553 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-20 19:55:00 +00:00
engine-flutter-autoroll
f6fea45b6f
Roll Flutter Engine from f803f2adec54 to 1b52f57ca07c (1 revision) ( #145479 )
...
f803f2adec...1b52f57ca034871572+gmackall@users.noreply.github.com Add more logging for UnsatisfiedLinkError (flutter/engine#51534 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-20 18:35:22 +00:00
auto-submit[bot]
a01eac78ee
Reverts "Reland #128236 "Improve build output for all platforms" ( #145376 )" ( #145487 )
...
Reverts: flutter/flutter#145376
Initiated by: loic-sharma
Reason for reverting: It caused the following post-submit failures:
1. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752928710548811665/+/u/run_run_release_test_windows/stdout
2. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752927564747697169/+/u/run_run_release_test_windows/stdout
Original PR Author: guidezpl
Reviewed By: {loic-sharma}
This change reverts the following previous change:
Reland #128236 , reverted in https://github.com/flutter/flutter/pull/143125 and https://github.com/flutter/flutter/pull/145261 .
This PR contains 3 additional commits, fixing post-submit tests on Android and Windows.
## Original description
Improves the build output:
1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained)
### `apk`, `appbundle`
<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d ">
<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436 ">
### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.
<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257 ">
<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50 ">
<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698 ">
### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).
<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b ">
<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2 ">
<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5 ">
### Size reporting
When applicable, the printed size matches the OS reported size.
- macOS
<img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce ">
- Windows
<img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7 ">
- Linux
<img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b ">
## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401
2024-03-20 18:18:25 +00:00
engine-flutter-autoroll
be0b4221b8
Roll Flutter Engine from fc2b7a9076b4 to f803f2adec54 (1 revision) ( #145475 )
...
fc2b7a9076...f803f2adecskia-flutter-autoroll@skia.org Roll Skia from 2a6d55ab7a0b to 80e713052b7a (3 revisions) (flutter/engine#51551 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-20 16:39:10 +00:00
Pierre-Louis
6b568f3943
Reland #128236 "Improve build output for all platforms" ( #145376 )
...
Reland #128236 , reverted in https://github.com/flutter/flutter/pull/143125 and https://github.com/flutter/flutter/pull/145261 .
This PR contains 3 additional commits, fixing post-submit tests on Android and Windows.
## Original description
Improves the build output:
1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained)
### `apk`, `appbundle`
<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d ">
<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436 ">
### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.
<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257 ">
<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50 ">
<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698 ">
### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).
<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b ">
<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2 ">
<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5 ">
### Size reporting
When applicable, the printed size matches the OS reported size.
- macOS
<img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce ">
- Windows
<img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7 ">
- Linux
<img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b ">
## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401
2024-03-20 16:14:53 +00:00
