development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-05 15:59:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix BorderSide.none requiring explicit transparent color for UnderlineInputBorder (#145329)

Browse source 
Fix could have been "paint transparent when Border none" but, following other Borders, we will just not paint anything.

Fix https://github.com/flutter/flutter/issues/143746
This commit is contained in:
Bernardo Ferrari 2024-03-21 23:31:16 -03:00 committed by GitHub
parent e1c6445467
commit 784f19c49c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/flutter/lib/src/material/input_border.dart
View file

@ -243,6 +243,10 @@ class UnderlineInputBorder extends InputBorder {
double gapPercentage = 0.0,
TextDirection? textDirection,
}) {
if (borderSide.style == BorderStyle.none) {
return;
}
if (borderRadius.bottomLeft != Radius.zero || borderRadius.bottomRight != Radius.zero) {
// This prevents the border from leaking the color due to anti-aliasing rounding errors.
final BorderRadius updatedBorderRadius = BorderRadius.only(

14
packages/flutter/test/material/input_decorator_test.dart
View file

@ -9729,4 +9729,18 @@ void main() {
expect(tester.renderObject<RenderBox>(find.text('COUNTER')).size, Size.zero);
});
});
testWidgets('UnderlineInputBorder with BorderStyle.none should not show anything', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/143746
const InputDecoration decoration = InputDecoration(
enabledBorder: UnderlineInputBorder(
borderSide: BorderSide(style: BorderStyle.none),
borderRadius: BorderRadius.all(Radius.circular(4)),
),
);
await tester.pumpWidget(buildInputDecorator(decoration: decoration));
final RenderBox box = tester.renderObject(find.byType(InputDecorator));
expect(box, isNot(paints..drrect()));
});
}