Polina Cherkasova
219efce7f1
Cover more tests with leak tracking. ( #134363 )
2023-09-11 09:42:27 -07:00
engine-flutter-autoroll
6de4e16985
Roll Flutter Engine from e9f1696e5060 to 2b5961cbc40d (1 revision) ( #134424 )
...
e9f1696e50...2b5961cbc4skia-flutter-autoroll@skia.org Roll Skia from 4c50e0870461 to 787b61f00100 (1 revision) (flutter/engine#45639 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 13:23:33 +00:00
engine-flutter-autoroll
c6fa26162f
Roll Flutter Engine from ac6be4dbf821 to e9f1696e5060 (1 revision) ( #134410 )
...
ac6be4dbf8...e9f1696e50skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 6PrTSjMiSCsSb0muF... to 7Zk_dvFh301kgQte4... (flutter/engine#45636 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 6PrTSjMiSCsS to 7Zk_dvFh301k
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 09:41:25 +00:00
engine-flutter-autoroll
954444a0e3
Roll Flutter Engine from 1aa11b644855 to ac6be4dbf821 (1 revision) ( #134407 )
...
1aa11b6448...ac6be4dbf8skia-flutter-autoroll@skia.org Roll Skia from 2e80ffb2ebea to 4c50e0870461 (1 revision) (flutter/engine#45635 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 09:00:23 +00:00
engine-flutter-autoroll
ffe1ebd207
Roll Flutter Engine from 7e41b064eb23 to 1aa11b644855 (2 revisions) ( #134404 )
...
7e41b064eb...1aa11b6448skia-flutter-autoroll@skia.org Roll Skia from 5aff628b1c47 to 2e80ffb2ebea (1 revision) (flutter/engine#45634 )
2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 947f91dcacf5 to 5aff628b1c47 (1 revision) (flutter/engine#45633 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 07:46:15 +00:00
engine-flutter-autoroll
69f6e7d15d
Roll Flutter Engine from 04d836f69571 to 7e41b064eb23 (1 revision) ( #134396 )
...
04d836f695...7e41b064ebskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from a024p4HJVVgmCW5Jo... to SFM4ele7RYnVMhr7S... (flutter/engine#45632 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from a024p4HJVVgm to SFM4ele7RYnV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-11 04:50:38 +00:00
engine-flutter-autoroll
0d9ea62756
Roll Flutter Engine from 2acd60d6baed to 04d836f69571 (1 revision) ( #134392 )
...
2acd60d6ba...04d836f695skia-flutter-autoroll@skia.org Roll Skia from 4eea73a072d3 to 947f91dcacf5 (1 revision) (flutter/engine#45629 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 22:34:24 +00:00
engine-flutter-autoroll
44131ae4cf
Roll Flutter Engine from 59b08263f7cc to 2acd60d6baed (1 revision) ( #134391 )
...
59b08263f7...2acd60d6baskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VciXahwZgiusifyh8... to 6PrTSjMiSCsSb0muF... (flutter/engine#45626 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from VciXahwZgius to 6PrTSjMiSCsS
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 21:00:31 +00:00
engine-flutter-autoroll
de25def778
Roll Flutter Engine from a2af0c6965be to 59b08263f7cc (1 revision) ( #134384 )
...
a2af0c6965...59b08263f7skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from U70-bvYinYjKdGGSt... to a024p4HJVVgmCW5Jo... (flutter/engine#45624 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from U70-bvYinYjK to a024p4HJVVgm
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 17:25:28 +00:00
engine-flutter-autoroll
2da03e54a9
Roll Flutter Engine from 47d1a045d140 to a2af0c6965be (1 revision) ( #134375 )
...
47d1a045d1...a2af0c6965skia-flutter-autoroll@skia.org Roll Skia from 1bb0f15f2cff to 4eea73a072d3 (1 revision) (flutter/engine#45623 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 13:15:26 +00:00
Daco Harkes
aa36db1d29
Native assets support for MacOS and iOS ( #130494 )
...
Support for FFI calls with `@Native external` functions through Native assets on MacOS and iOS. This enables bundling native code without any build-system boilerplate code.
For more info see:
* https://github.com/flutter/flutter/issues/129757
### Implementation details for MacOS and iOS.
Dylibs are bundled by (1) making them fat binaries if multiple architectures are targeted, (2) code signing these, and (3) copying them to the frameworks folder. These steps are done manual rather than via CocoaPods. CocoaPods would have done the same steps, but (a) needs the dylibs to be there before the `xcodebuild` invocation (we could trick it, by having a minimal dylib in the place and replace it during the build process, that works), and (b) can't deal with having no dylibs to be bundled (we'd have to bundle a dummy dylib or include some dummy C code in the build file).
The dylibs are build as a new target inside flutter assemble, as that is the moment we know what build-mode and architecture to target.
The mapping from asset id to dylib-path is passed in to every kernel compilation path. The interesting case is hot-restart where the initial kernel file is compiled by the "inner" flutter assemble, while after hot restart the "outer" flutter run compiled kernel file is pushed to the device. Both kernel files need to contain the mapping. The "inner" flutter assemble gets its mapping from the NativeAssets target which builds the native assets. The "outer" flutter run get its mapping from a dry-run invocation. Since this hot restart can be used for multiple target devices (`flutter run -d all`) it contains the mapping for all known targets.
### Example vs template
The PR includes a new template that uses the new native assets in a package and has an app importing that. Separate discussion in: https://github.com/flutter/flutter/issues/131209 .
### Tests
This PR adds new tests to cover the various use cases.
* dev/devicelab/bin/tasks/native_assets_ios.dart
* Runs an example app with native assets in all build modes, doing hot reload and hot restart in debug mode.
* dev/devicelab/bin/tasks/native_assets_ios_simulator.dart
* Runs an example app with native assets, doing hot reload and hot restart.
* packages/flutter_tools/test/integration.shard/native_assets_test.dart
* Runs (incl hot reload/hot restart), builds, builds frameworks for iOS, MacOS and flutter-tester.
* packages/flutter_tools/test/general.shard/build_system/targets/native_assets_test.dart
* Unit tests the new Target in the backend.
* packages/flutter_tools/test/general.shard/ios/native_assets_test.dart
* packages/flutter_tools/test/general.shard/macos/native_assets_test.dart
* Unit tests the native assets being packaged on a iOS/MacOS build.
It also extends various existing tests:
* dev/devicelab/bin/tasks/module_test_ios.dart
* Exercises the add2app scenario.
* packages/flutter_tools/test/general.shard/features_test.dart
* Unit test the new feature flag.
2023-09-10 08:07:13 +00:00
engine-flutter-autoroll
690800bca3
Roll Flutter Engine from feea98d6d0ae to 47d1a045d140 (1 revision) ( #134368 )
...
feea98d6d0...47d1a045d1skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 51fG0shrG6fW64BtN... to VciXahwZgiusifyh8... (flutter/engine#45620 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 51fG0shrG6fW to VciXahwZgius
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 05:41:26 +00:00
engine-flutter-autoroll
8919140c0a
Roll Flutter Engine from 4edbefa5e8f7 to feea98d6d0ae (1 revision) ( #134365 )
...
4edbefa5e8...feea98d6d0skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from i9IPFS-XpkPjlH235... to U70-bvYinYjKdGGSt... (flutter/engine#45618 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from i9IPFS-XpkPj to U70-bvYinYjK
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-10 03:37:11 +00:00
Renzo Olivares
2c477b1812
SelectableRegion onSelectionChange should be called when the selection changes ( #134215 )
...
This change makes sure to call `onSelectionChange` in all cases when selection might change including:
* Dragging selection handles
* Mouse drag to select
* Keyboard actions
* Long press drag to select
2023-09-09 22:03:23 +00:00
engine-flutter-autoroll
c7665ff84c
Roll Flutter Engine from b8afb6deacf3 to 4edbefa5e8f7 (1 revision) ( #134360 )
...
b8afb6deac...4edbefa5e8skia-flutter-autoroll@skia.org Roll Skia from 386c7a6a56fd to 1bb0f15f2cff (1 revision) (flutter/engine#45615 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 21:26:17 +00:00
engine-flutter-autoroll
cc317dff86
Roll Flutter Engine from d1913cb6a276 to b8afb6deacf3 (1 revision) ( #134356 )
...
d1913cb6a2...b8afb6deacskia-flutter-autoroll@skia.org Roll Skia from 58e39bd84ab2 to 386c7a6a56fd (1 revision) (flutter/engine#45614 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 18:06:18 +00:00
engine-flutter-autoroll
7c28e8eb07
Roll Flutter Engine from 4e3231af6efc to d1913cb6a276 (1 revision) ( #134355 )
...
4e3231af6e...d1913cb6a2skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from RbgNQ_B-mcwvmNSq3... to 51fG0shrG6fW64BtN... (flutter/engine#45612 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from RbgNQ_B-mcwv to 51fG0shrG6fW
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 16:48:23 +00:00
engine-flutter-autoroll
6660cc9816
Roll Flutter Engine from 348e3a376807 to 4e3231af6efc (1 revision) ( #134353 )
...
348e3a3768...4e3231af6eskia-flutter-autoroll@skia.org Roll Skia from 3dfd4316b80d to 58e39bd84ab2 (1 revision) (flutter/engine#45610 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 15:52:13 +00:00
Polina Cherkasova
5555836712
Day picker should dispose created MaterialStatesController's. ( #133884 )
...
Fixes https://github.com/flutter/flutter/issues/133862
2023-09-09 08:45:27 -07:00
engine-flutter-autoroll
3f4ee3fbcc
Roll Flutter Engine from 00ef109b845e to 348e3a376807 (1 revision) ( #134349 )
...
00ef109b84...348e3a3768skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jYqYNRum5gWGFyoHR... to i9IPFS-XpkPjlH235... (flutter/engine#45609 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from jYqYNRum5gWG to i9IPFS-XpkPj
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 14:42:37 +00:00
engine-flutter-autoroll
2b642822b0
Roll Flutter Engine from 7af8a5d8d556 to 00ef109b845e (1 revision) ( #134336 )
...
7af8a5d8d5...00ef109b84skia-flutter-autoroll@skia.org Roll Skia from e5987e341cfd to 3dfd4316b80d (1 revision) (flutter/engine#45607 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 08:27:40 +00:00
engine-flutter-autoroll
12ce42b73a
Roll Flutter Engine from 1f2da3d69da7 to 7af8a5d8d556 (2 revisions) ( #134332 )
...
1f2da3d69d...7af8a5d8d5skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from h_bQLstuirD8blCZW... to RbgNQ_B-mcwvmNSq3... (flutter/engine#45603 )
2023-09-09 skia-flutter-autoroll@skia.org Roll ANGLE from fce1e57401bf to 48e2c605adcd (2 revisions) (flutter/engine#45602 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from h_bQLstuirD8 to RbgNQ_B-mcwv
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 04:24:27 +00:00
engine-flutter-autoroll
e5d919caed
Roll Flutter Engine from 3a5f3ad1d054 to 1f2da3d69da7 (1 revision) ( #134328 )
...
3a5f3ad1d0...1f2da3d69d30870216+gaaclarke@users.noreply.github.com Makes Skia's vkQueueSubmit threadsafe. (flutter/engine#45459 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 02:51:25 +00:00
engine-flutter-autoroll
0c2f1af055
Roll Flutter Engine from d6aa2d9061c1 to 3a5f3ad1d054 (3 revisions) ( #134327 )
...
d6aa2d9061...3a5f3ad1d0skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KvtLknmg3f23uqWVm... to jYqYNRum5gWGFyoHR... (flutter/engine#45599 )
2023-09-09 skia-flutter-autoroll@skia.org Roll Skia from 7f1d86d81d41 to e5987e341cfd (1 revision) (flutter/engine#45597 )
2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from 98b0855b9a71 to fce1e57401bf (3 revisions) (flutter/engine#45596 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from KvtLknmg3f23 to jYqYNRum5gWG
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 02:05:27 +00:00
engine-flutter-autoroll
996eb11245
Roll Flutter Engine from 66bec85d5005 to d6aa2d9061c1 (1 revision) ( #134324 )
...
66bec85d50...d6aa2d9061skia-flutter-autoroll@skia.org Roll Skia from 1012ef8349ba to 7f1d86d81d41 (1 revision) (flutter/engine#45594 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-09 00:31:24 +00:00
engine-flutter-autoroll
9c210237c9
Roll Flutter Engine from 8d2892211366 to 66bec85d5005 (3 revisions) ( #134321 )
...
8d28922113...66bec85d50skia-flutter-autoroll@skia.org Roll ANGLE from 765bca2f810a to 98b0855b9a71 (1 revision) (flutter/engine#45589 )
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 4996cc1ef9ba to 1012ef8349ba (1 revision) (flutter/engine#45588 )
2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from a507f31285b8 to 765bca2f810a (1 revision) (flutter/engine#45587 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 22:51:29 +00:00
engine-flutter-autoroll
9dde2166b7
Roll Flutter Engine from 2da727e23518 to 8d2892211366 (1 revision) ( #134316 )
...
2da727e235...8d28922113skia-flutter-autoroll@skia.org Roll Skia from 244c9ba5d0d7 to 4996cc1ef9ba (2 revisions) (flutter/engine#45586 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 22:09:05 +00:00
Kostia Sokolovskyi
5d5da38810
Fix memory leak in _DraggableScrollableSheetState ( #134212 )
2023-09-08 15:06:26 -07:00
Polina Cherkasova
834f5dc296
RestorationManager should dispatch creation in constructor. ( #133911 )
2023-09-08 15:05:43 -07:00
LongCatIsLooong
621ad9872c
Remove TextPainter migration flag from the framework ( #134274 )
...
The migration flag in `ParagraphBuilder` will be removed next.
2023-09-08 22:01:52 +00:00
Renzo Olivares
97cdc0ec07
InputDecoration.error should activate error state ( #134001 )
...
When passed an `error` widget, `InputDecoration` should activate its error state. Before this change the `errorBorder` would only activate if an `errorText` was provided. This change solves this issue by accounting for a provided `error` widget.
2023-09-08 22:01:50 +00:00
engine-flutter-autoroll
fa9c301a84
Roll Flutter Engine from b2cb1d271a88 to 2da727e23518 (1 revision) ( #134314 )
...
b2cb1d271a...2da727e235skia-flutter-autoroll@skia.org Roll Skia from 948959b6b53e to 244c9ba5d0d7 (2 revisions) (flutter/engine#45584 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 19:59:13 +00:00
Taha Tesser
90c524dcdf
Update chip docs to clarify how to specify a shape with no border & explain default values for Material 3 ( #134298 )
...
fixes [Update chip docs for Material 3 defaults.](https://github.com/flutter/flutter/issues/134296 )
Addresses a [comment](https://github.com/flutter/flutter/pull/133856#discussion_r1313513284 ) from @HansMuller as well
2023-09-08 19:41:18 +00:00
chunhtai
f851e7faf0
Add ios analyzer command for universal links ( #134155 )
...
ios version of https://github.com/flutter/flutter/pull/131009/files
2023-09-08 19:22:44 +00:00
engine-flutter-autoroll
2f66f25f34
Roll Flutter Engine from 47a79306eed3 to b2cb1d271a88 (5 revisions) ( #134313 )
...
47a79306ee...b2cb1d271askia-flutter-autoroll@skia.org Roll Skia from 5181fcf6184e to 948959b6b53e (4 revisions) (flutter/engine#45583 )
2023-09-08 gspencergoog@users.noreply.github.com Remove usage of the Jazzy document formatter for Objective C, in favor of Doxygen. (flutter/engine#45561 )
2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from 83030fed595b to a507f31285b8 (1 revision) (flutter/engine#45582 )
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from 5b1e40fc0548 to 5181fcf6184e (2 revisions) (flutter/engine#45580 )
2023-09-08 matanlurey@users.noreply.github.com Document and provide small cleanups to `CommandPoolVk`. (flutter/engine#45558 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 19:08:16 +00:00
engine-flutter-autoroll
d73e1b69f7
Roll Flutter Engine from 6d6b44886175 to 47a79306eed3 (2 revisions) ( #134310 )
...
6d6b448861...47a79306eeskia-flutter-autoroll@skia.org Roll Skia from c5e67d222f46 to 5b1e40fc0548 (5 revisions) (flutter/engine#45578 )
2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from 65ec697f4183 to 83030fed595b (1 revision) (flutter/engine#45577 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 17:43:20 +00:00
Flutter GitHub Bot
da676f79aa
Marks Linux_android very_long_picture_scrolling_perf__e2e_summary to be unflaky ( #134116 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android very_long_picture_scrolling_perf__e2e_summary"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20very_long_picture_scrolling_perf__e2e_summary%22 ).
This test can be marked as unflaky.
2023-09-08 10:08:21 -07:00
LongCatIsLooong
804a7b285f
Make CupertinoTextField at least as tall as its first line of placeholder ( #134198 )
...
Fixes https://github.com/flutter/flutter/issues/133241
and some CupertinoTextField cleanup.
2023-09-08 16:52:57 +00:00
engine-flutter-autoroll
fc671188c4
Roll Flutter Engine from f09a139101c3 to 6d6b44886175 (3 revisions) ( #134306 )
...
f09a139101...6d6b448861skia-flutter-autoroll@skia.org Roll Skia from 71e40cc0faf6 to c5e67d222f46 (4 revisions) (flutter/engine#45576 )
2023-09-08 rmolivares@renzo-olivares.dev [Web] Fix insertions/deletions at inverted selection for TextEditingDeltas (flutter/engine#44693 )
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from ece9f3a15b08 to 71e40cc0faf6 (1 revision) (flutter/engine#45575 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 16:52:55 +00:00
Greg Spencer
3ce6174e6b
Update links to iOS embedder docs to point to new Doxygen docs ( #134246 )
...
## Description
Now that we are using Doxygen for building docs for the embedders, this updates the links to point to the correct URLs.
## Related Issues
- https://github.com/flutter/flutter/issues/124833
## Related PRs
- https://github.com/flutter/engine/pull/45561
2023-09-08 16:42:50 +00:00
engine-flutter-autoroll
53017f8525
Roll Packages from 22d475491502 to aaae5ef97a45 (7 revisions) ( #134301 )
...
22d4754915...aaae5ef97a43054281+camsim99@users.noreply.github.com [tool] Add Android dependency (gradle) option to update dependencies command (flutter/packages#4757 )
2023-09-08 43054281+camsim99@users.noreply.github.com [camerax] Implement resolution configuration (flutter/packages#3799 )
2023-09-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 685ce14b2daea4552acdflutter/packages#4870 )
2023-09-07 ditman@gmail.com [rfw, ci] Regenerate goldens, manually roll #4835 (flutter/packages#4862 )
2023-09-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.6.0 to 4.0.0 (flutter/packages#4845 )
2023-09-07 defuncart@gmail.com [video_player] Add optional web options [web] (flutter/packages#4551 )
2023-09-07 me@nils.re [flutter_markdown] Remove `ignore: avoid_init_to_null` since the package uses Dart 3 (flutter/packages#4852 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 15:38:28 +00:00
engine-flutter-autoroll
7b06874ef5
Roll Flutter Engine from c38feb382e96 to f09a139101c3 (1 revision) ( #134299 )
...
c38feb382e...f09a139101skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 33DToYd0jNpWX1jNv... to KvtLknmg3f23uqWVm... (flutter/engine#45573 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 33DToYd0jNpW to KvtLknmg3f23
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 14:13:16 +00:00
engine-flutter-autoroll
2681e873e2
Roll Flutter Engine from f146d4bf244b to c38feb382e96 (1 revision) ( #134293 )
...
f146d4bf24...c38feb382eskia-flutter-autoroll@skia.org Roll ANGLE from e60556f75b68 to 65ec697f4183 (1 revision) (flutter/engine#45572 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 13:32:11 +00:00
engine-flutter-autoroll
2d9680bab2
Roll Flutter Engine from a140ab4a4ec6 to f146d4bf244b (1 revision) ( #134290 )
...
a140ab4a4e...f146d4bf24whesse@google.com Add dart2wasm dependency to flutter_frontend_server (flutter/engine#45570 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 12:09:26 +00:00
engine-flutter-autoroll
0ddfe9090f
Roll Flutter Engine from ea1d0d28e26f to a140ab4a4ec6 (5 revisions) ( #134288 )
...
ea1d0d28e2...a140ab4a4eskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EuBfOtm5TZIdgNaQe... to h_bQLstuirD8blCZW... (flutter/engine#45571 )
2023-09-08 skia-flutter-autoroll@skia.org Roll ANGLE from 99d39241ad4d to e60556f75b68 (1 revision) (flutter/engine#45569 )
2023-09-08 bdero@google.com [Impeller] Aiks image filters; allow setting effect transforms after FilterContents instantiation. (flutter/engine#45530 )
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from ce3ec572ae77 to ece9f3a15b08 (1 revision) (flutter/engine#45568 )
2023-09-08 skia-flutter-autoroll@skia.org Roll Skia from fb4faa8646f8 to ce3ec572ae77 (1 revision) (flutter/engine#45567 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from EuBfOtm5TZId to h_bQLstuirD8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 10:55:12 +00:00
xubaolin
f4707c2b3d
fix a Scrollbar example crash ( #127925 )
...
Fix a scrollbar example crash.
https://api.flutter.dev/flutter/material/Scrollbar-class.html#material.Scrollbar.1
2023-09-08 09:40:49 +00:00
Taha Tesser
bb8de2167a
Fix Drawer examples are missing dartpad tag ( #134219 )
...
fixes [`Drawer` examples are misssing `dartpad` tag]( https://github.com/flutter/flutter/issues/134217 )
these examples were updated in https://github.com/flutter/flutter/pull/130523
2023-09-08 08:14:05 +00:00
engine-flutter-autoroll
fa1133586a
Roll Flutter Engine from 4ac4429a206b to ea1d0d28e26f (1 revision) ( #134270 )
...
4ac4429a20...ea1d0d28e2skia-flutter-autoroll@skia.org Roll Skia from 658025e9efdd to fb4faa8646f8 (1 revision) (flutter/engine#45564 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 04:08:32 +00:00
engine-flutter-autoroll
1c3c0f8a56
Roll Flutter Engine from df3965a55fd8 to 4ac4429a206b (1 revision) ( #134267 )
...
df3965a55f...4ac4429a20skia-flutter-autoroll@skia.org Roll Skia from 1b8a25d05c45 to 658025e9efdd (1 revision) (flutter/engine#45563 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 03:24:37 +00:00
engine-flutter-autoroll
7cbaa2a41e
Roll Flutter Engine from 505ef3c33102 to df3965a55fd8 (1 revision) ( #134263 )
...
505ef3c331...df3965a55fskia-flutter-autoroll@skia.org Roll ANGLE from a412b149d5b1 to 99d39241ad4d (1 revision) (flutter/engine#45562 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-08 01:29:29 +00:00
